12022-05-16T00:06:29 *** szkl <szkl!uid110435@id-110435.uxbridge.irccloud.com> has joined #bitcoin-core-dev
22022-05-16T00:17:39 *** AaronvanW <AaronvanW!~AaronvanW@user/AaronvanW> has quit IRC (Quit: Leaving...)
32022-05-16T00:21:18 *** z9z0b3t1c <z9z0b3t1c!z9z0b3t1c@gateway/vpn/protonvpn/z9z0b3t1c> has joined #bitcoin-core-dev
42022-05-16T00:24:36 *** z9z0b3t1_ <z9z0b3t1_!z9z0b3t1c@gateway/vpn/protonvpn/z9z0b3t1c> has quit IRC (Ping timeout: 240 seconds)
52022-05-16T00:29:12 *** z9z0b3t1_ <z9z0b3t1_!z9z0b3t1c@gateway/vpn/protonvpn/z9z0b3t1c> has joined #bitcoin-core-dev
62022-05-16T00:30:39 *** z9z0b3t__ <z9z0b3t__!z9z0b3t1c@gateway/vpn/protonvpn/z9z0b3t1c> has joined #bitcoin-core-dev
72022-05-16T00:31:39 *** z9z0b3t1c <z9z0b3t1c!z9z0b3t1c@gateway/vpn/protonvpn/z9z0b3t1c> has quit IRC (Ping timeout: 256 seconds)
82022-05-16T00:33:59 *** z9z0b3t1_ <z9z0b3t1_!z9z0b3t1c@gateway/vpn/protonvpn/z9z0b3t1c> has quit IRC (Ping timeout: 246 seconds)
92022-05-16T00:50:10 *** jonatack <jonatack!~jonatack@user/jonatack> has quit IRC (Ping timeout: 260 seconds)
102022-05-16T01:06:41 <bytes1440000> luke-jr: let me rephrase: its not just consensus related code, bitcoin core can have bugs and vulnerabilities in different thing. Example: CVE-2018â20587
112022-05-16T01:11:39 *** bytes1440000 <bytes1440000!~bytes1440@garza.riseup.net> has quit IRC (Quit: Client closed)
122022-05-16T01:14:00 *** Kaizen_Kintsugi_ <Kaizen_Kintsugi_!~Kaizen_Ki@2600:8802:3806:c200:3c67:f8b:edb7:5828> has quit IRC (Remote host closed the connection)
132022-05-16T01:14:39 *** Kaizen_Kintsugi_ <Kaizen_Kintsugi_!~Kaizen_Ki@ip72-194-104-106.oc.oc.cox.net> has joined #bitcoin-core-dev
142022-05-16T01:19:05 *** Kaizen_Kintsugi_ <Kaizen_Kintsugi_!~Kaizen_Ki@ip72-194-104-106.oc.oc.cox.net> has quit IRC (Ping timeout: 252 seconds)
152022-05-16T01:21:48 *** Kaizen_Kintsugi_ <Kaizen_Kintsugi_!~Kaizen_Ki@2600:8802:3806:c200:3135:748c:ab7d:458f> has joined #bitcoin-core-dev
162022-05-16T01:26:14 *** Kaizen_Kintsugi_ <Kaizen_Kintsugi_!~Kaizen_Ki@2600:8802:3806:c200:3135:748c:ab7d:458f> has quit IRC (Ping timeout: 252 seconds)
172022-05-16T01:41:06 *** Kaizen_Kintsugi_ <Kaizen_Kintsugi_!~Kaizen_Ki@2600:8802:3806:c200:3135:748c:ab7d:458f> has joined #bitcoin-core-dev
182022-05-16T01:54:44 *** hashfuncd0e <hashfuncd0e!~user@2601:5c0:c280:7090:7c25:cf68:625f:614f> has quit IRC (Ping timeout: 248 seconds)
192022-05-16T02:09:50 <luke-jr> obviously
202022-05-16T02:10:00 <luke-jr> and when found, these get fixed
212022-05-16T02:18:23 *** cold <cold!~cold@user/cold> has quit IRC (Quit: Quitting...)
222022-05-16T02:18:43 *** cold <cold!~cold@user/cold> has joined #bitcoin-core-dev
232022-05-16T02:42:41 *** Kaizen_Kintsugi_ <Kaizen_Kintsugi_!~Kaizen_Ki@2600:8802:3806:c200:3135:748c:ab7d:458f> has quit IRC (Ping timeout: 252 seconds)
242022-05-16T02:56:53 *** Kaizen_Kintsugi_ <Kaizen_Kintsugi_!~Kaizen_Ki@2600:8802:3806:c200:3135:748c:ab7d:458f> has joined #bitcoin-core-dev
252022-05-16T03:01:24 *** Kaizen_Kintsugi_ <Kaizen_Kintsugi_!~Kaizen_Ki@2600:8802:3806:c200:3135:748c:ab7d:458f> has quit IRC (Ping timeout: 248 seconds)
262022-05-16T03:04:50 *** sudoforge <sudoforge!~sudoforge@wireguard/tunneler/sudoforge> has quit IRC (Ping timeout: 240 seconds)
272022-05-16T03:29:44 *** Kaizen_Kintsugi_ <Kaizen_Kintsugi_!~Kaizen_Ki@2600:8802:3806:c200:3135:748c:ab7d:458f> has joined #bitcoin-core-dev
282022-05-16T03:46:29 *** brunoerg <brunoerg!~brunoerg@2804:14d:5281:8ae2:d0a9:1ce1:d04f:391e> has quit IRC (Ping timeout: 252 seconds)
292022-05-16T03:47:55 *** Evel-Knievel <Evel-Knievel!~Evel-Knie@user/evel-knievel> has joined #bitcoin-core-dev
302022-05-16T04:01:01 *** cmirror <cmirror!~cmirror@4.53.92.114> has quit IRC (Remote host closed the connection)
312022-05-16T04:01:50 *** brunoerg <brunoerg!~brunoerg@2804:14d:5281:8ae2:d0a9:1ce1:d04f:391e> has joined #bitcoin-core-dev
322022-05-16T04:01:53 *** cmirror <cmirror!~cmirror@4.53.92.114> has joined #bitcoin-core-dev
332022-05-16T04:33:00 *** Kaizen_Kintsugi_ <Kaizen_Kintsugi_!~Kaizen_Ki@2600:8802:3806:c200:3135:748c:ab7d:458f> has quit IRC (Ping timeout: 260 seconds)
342022-05-16T04:47:10 *** z9z0b3t1c <z9z0b3t1c!z9z0b3t1c@gateway/vpn/protonvpn/z9z0b3t1c> has joined #bitcoin-core-dev
352022-05-16T04:50:11 *** z9z0b3t__ <z9z0b3t__!z9z0b3t1c@gateway/vpn/protonvpn/z9z0b3t1c> has quit IRC (Ping timeout: 246 seconds)
362022-05-16T04:54:17 *** brunoerg <brunoerg!~brunoerg@2804:14d:5281:8ae2:d0a9:1ce1:d04f:391e> has quit IRC (Ping timeout: 248 seconds)
372022-05-16T04:54:49 *** brunoerg <brunoerg!~brunoerg@2804:14d:5281:8ae2:ac98:9665:2456:9ae3> has joined #bitcoin-core-dev
382022-05-16T04:54:54 *** brunoerg <brunoerg!~brunoerg@2804:14d:5281:8ae2:ac98:9665:2456:9ae3> has quit IRC (Remote host closed the connection)
392022-05-16T04:55:24 *** brunoerg <brunoerg!~brunoerg@187.183.43.40> has joined #bitcoin-core-dev
402022-05-16T04:57:34 <TallTim> luke-jr, as an outside observer I'm slightly amused that you're being asked to essentially predict bugs. :)
412022-05-16T04:59:56 *** mikehu44 <mikehu44!~quassel@gateway/vpn/pia/mikehu44-jc> has joined #bitcoin-core-dev
422022-05-16T05:02:30 *** brunoerg <brunoerg!~brunoerg@187.183.43.40> has quit IRC (Ping timeout: 240 seconds)
432022-05-16T05:03:01 *** Kaizen_Kintsugi_ <Kaizen_Kintsugi_!~Kaizen_Ki@2600:8802:3806:c200:3c67:f8b:edb7:5828> has joined #bitcoin-core-dev
442022-05-16T05:10:19 *** Kaizen_Kintsugi_ <Kaizen_Kintsugi_!~Kaizen_Ki@2600:8802:3806:c200:3c67:f8b:edb7:5828> has quit IRC (Ping timeout: 240 seconds)
452022-05-16T05:10:49 <luke-jr> >_<
462022-05-16T05:17:11 *** brunoerg <brunoerg!~brunoerg@2804:14d:5281:8ae2:ac98:9665:2456:9ae3> has joined #bitcoin-core-dev
472022-05-16T05:20:07 *** weez22 <weez22!uid553617@user/weez22> has quit IRC (Quit: Connection closed for inactivity)
482022-05-16T05:22:44 *** bfsfhkacjzgcytf9 <bfsfhkacjzgcytf9!~bfsfhkacj@user/bfsfhkacjzgcytf> has joined #bitcoin-core-dev
492022-05-16T05:25:47 *** Kaizen_Kintsugi_ <Kaizen_Kintsugi_!~Kaizen_Ki@2600:8802:3806:c200:3135:748c:ab7d:458f> has joined #bitcoin-core-dev
502022-05-16T05:27:47 *** bfsfhkacjzgcytf9 <bfsfhkacjzgcytf9!~bfsfhkacj@user/bfsfhkacjzgcytf> has quit IRC (Ping timeout: 240 seconds)
512022-05-16T05:41:47 *** upekkha <upekkha!~Advanced@2a01:4f8:1c0c:49df::1> has quit IRC (*.net *.split)
522022-05-16T05:41:48 *** yakshaver <yakshaver!~yakshaver@shindig.notmandatory.org> has quit IRC (*.net *.split)
532022-05-16T05:41:48 *** arik <arik!sid402902@id-402902.lymington.irccloud.com> has quit IRC (*.net *.split)
542022-05-16T05:41:48 *** Nebraskka <Nebraskka!~Nebraskka@user/nebraskka> has quit IRC (*.net *.split)
552022-05-16T05:41:48 *** sebx2a <sebx2a!sid356034@id-356034.uxbridge.irccloud.com> has quit IRC (*.net *.split)
562022-05-16T05:42:00 *** upekkha <upekkha!~Advanced@2a01:4f8:1c0c:49df::1> has joined #bitcoin-core-dev
572022-05-16T05:42:03 *** yakshaver <yakshaver!yakshaver@2600:3c00::f03c:92ff:fe8e:dce6> has joined #bitcoin-core-dev
582022-05-16T05:42:43 *** sebx2a <sebx2a!sid356034@id-356034.uxbridge.irccloud.com> has joined #bitcoin-core-dev
592022-05-16T05:42:49 *** arik <arik!sid402902@id-402902.lymington.irccloud.com> has joined #bitcoin-core-dev
602022-05-16T05:43:02 *** Nebraskka <Nebraskka!~Nebraskka@user/nebraskka> has joined #bitcoin-core-dev
612022-05-16T05:48:22 *** MatrixBot1 <MatrixBot1!~matrixbot@2001:bc8:1828:379::1> has quit IRC (*.net *.split)
622022-05-16T05:48:22 *** ls55 <ls55!sid489830@helmsley.irccloud.com> has quit IRC (*.net *.split)
632022-05-16T05:48:22 *** lightlike <lightlike!sid521075@user/lightlike> has quit IRC (*.net *.split)
642022-05-16T05:48:22 *** blkncd <blkncd!sid505676@id-505676.helmsley.irccloud.com> has quit IRC (*.net *.split)
652022-05-16T05:48:22 *** RubenSomsen <RubenSomsen!sid301948@user/rubensomsen> has quit IRC (*.net *.split)
662022-05-16T05:48:22 *** cjd <cjd!~user@91-165-39-242.subs.proxad.net> has quit IRC (*.net *.split)
672022-05-16T05:48:30 *** blkncd <blkncd!sid505676@id-505676.helmsley.irccloud.com> has joined #bitcoin-core-dev
682022-05-16T05:48:31 *** ls55 <ls55!sid489830@id-489830.helmsley.irccloud.com> has joined #bitcoin-core-dev
692022-05-16T05:48:35 *** MatrixBot1 <MatrixBot1!~matrixbot@2001:bc8:1828:379::1> has joined #bitcoin-core-dev
702022-05-16T05:48:44 *** cjd <cjd!~user@91-165-39-242.subs.proxad.net> has joined #bitcoin-core-dev
712022-05-16T05:48:50 *** RubenSomsen <RubenSomsen!sid301948@user/rubensomsen> has joined #bitcoin-core-dev
722022-05-16T05:49:02 *** lightlike <lightlike!sid521075@user/lightlike> has joined #bitcoin-core-dev
732022-05-16T06:18:38 *** brunoerg <brunoerg!~brunoerg@2804:14d:5281:8ae2:ac98:9665:2456:9ae3> has quit IRC (Ping timeout: 260 seconds)
742022-05-16T06:20:14 *** brunoerg <brunoerg!~brunoerg@2804:14d:5281:8ae2:ac98:9665:2456:9ae3> has joined #bitcoin-core-dev
752022-05-16T06:22:18 *** jonatack <jonatack!~jonatack@user/jonatack> has joined #bitcoin-core-dev
762022-05-16T06:25:00 *** brunoerg <brunoerg!~brunoerg@2804:14d:5281:8ae2:ac98:9665:2456:9ae3> has quit IRC (Ping timeout: 260 seconds)
772022-05-16T06:26:18 *** brunoerg <brunoerg!~brunoerg@2804:14d:5281:8ae2:ac98:9665:2456:9ae3> has joined #bitcoin-core-dev
782022-05-16T06:27:16 *** Kaizen_Kintsugi_ <Kaizen_Kintsugi_!~Kaizen_Ki@2600:8802:3806:c200:3135:748c:ab7d:458f> has quit IRC (Ping timeout: 248 seconds)
792022-05-16T06:30:25 <bitcoin-git> [bitcoin] lazvegas13 opened pull request #25142: 23.x { "name": "BTC.main", "height": 736585, "hash": "000000000000000000047453805dff15189b57656fe1ada8de603a91e75c4ec6", "time": "2022-05-16T06:06:57.885107912Z", "latest_url": "https://api.blockcypher.com/v1/btc/main/blocks/000000000000000000047453805dff15189b57656fe1ada8de603a91e75c4ec6", "previous_hash":
802022-05-16T06:30:26 <bitcoin-git> "000000000000000000073bdb952221c3f22b621cb58c37d0f90f7c51d7c31276", "previous_url": "https://api.blockcypher.com/v1/btc/main/blocks/000000000000000000073bdb952221c3f22b621cb58c37d0f90f7c51d7c31276", "peer_count": 1044, "unconfirmed_count": 6340, "high_fee_per_kb": 18934, "medium_fee_per_kb": 10318, "low_fee_per_kb": 6520, "last_fork_height": 723102, "last_fork_hash":
812022-05-16T06:30:26 <bitcoin-git> "00000000000000000006a970fdd8e537521747aff917d909bf3a78b4b68143e1" } (master...23.x) https://github.com/bitcoin/bitcoin/pull/25142
822022-05-16T06:30:35 <bitcoin-git> [bitcoin] lazvegas13 closed pull request #25142: 23.x { "name": "BTC.main", "height": 736585, "hash": "000000000000000000047453805dff15189b57656fe1ada8de603a91e75c4ec6", "time": "2022-05-16T06:06:57.885107912Z", "latest_url": "https://api.blockcypher.com/v1/btc/main/blocks/000000000000000000047453805dff15189b57656fe1ada8de603a91e75c4ec6", "previous_hash":
832022-05-16T06:30:35 <bitcoin-git> "000000000000000000073bdb952221c3f22b621cb58c37d0f90f7c51d7c31276", "previous_url": "https://api.blockcypher.com/v1/btc/main/blocks/000000000000000000073bdb952221c3f22b621cb58c37d0f90f7c51d7c31276", "peer_count": 1044, "unconfirmed_count": 6340, "high_fee_per_kb": 18934, "medium_fee_per_kb": 10318, "low_fee_per_kb": 6520, "last_fork_height": 723102, "last_fork_hash":
842022-05-16T06:30:35 <bitcoin-git> "00000000000000000006a970fdd8e537521747aff917d909bf3a78b4b68143e1" } (master...23.x) https://github.com/bitcoin/bitcoin/pull/25142
852022-05-16T06:38:52 *** goatpig <goatpig!~goat@2001:861:3241:fa40:e5f5:f5bf:43db:45e2> has joined #bitcoin-core-dev
862022-05-16T06:49:28 *** Guest54 <Guest54!~Guest54@176.33.71.92> has joined #bitcoin-core-dev
872022-05-16T06:51:12 *** Guest54 <Guest54!~Guest54@176.33.71.92> has quit IRC (Client Quit)
882022-05-16T06:52:19 *** salvatoshi <salvatoshi!~salvatosh@genymobile-2-6-86.fib.nerim.net> has joined #bitcoin-core-dev
892022-05-16T06:58:28 *** Kaizen_Kintsugi_ <Kaizen_Kintsugi_!~Kaizen_Ki@ip72-194-104-106.oc.oc.cox.net> has joined #bitcoin-core-dev
902022-05-16T07:02:40 <luke-jr> wut
912022-05-16T07:03:58 *** Kaizen_Kintsugi_ <Kaizen_Kintsugi_!~Kaizen_Ki@ip72-194-104-106.oc.oc.cox.net> has quit IRC (Ping timeout: 272 seconds)
922022-05-16T07:09:30 *** AaronvanW <AaronvanW!~AaronvanW@user/AaronvanW> has joined #bitcoin-core-dev
932022-05-16T07:20:20 *** Kaizen_Kintsugi_ <Kaizen_Kintsugi_!~Kaizen_Ki@2600:8802:3806:c200:3135:748c:ab7d:458f> has joined #bitcoin-core-dev
942022-05-16T07:28:44 *** djb27_ <djb27_!djb27@user/djb27> has joined #bitcoin-core-dev
952022-05-16T07:32:41 *** djb27 <djb27!djb27@user/djb27> has quit IRC (Ping timeout: 256 seconds)
962022-05-16T07:41:46 *** Guyver2 <Guyver2!~Guyver@77-174-98-73.fixed.kpn.net> has joined #bitcoin-core-dev
972022-05-16T07:43:33 *** ___nick___ <___nick___!~quassel@cpc68286-cdif17-2-0-cust533.5-1.cable.virginm.net> has joined #bitcoin-core-dev
982022-05-16T07:49:02 *** aleggg <aleggg!~aleggg@179.187.19.96.dynamic.adsl.gvt.net.br> has quit IRC (Ping timeout: 252 seconds)
992022-05-16T07:49:58 *** aleggg <aleggg!~aleggg@177.204.163.75.dynamic.adsl.gvt.net.br> has joined #bitcoin-core-dev
1002022-05-16T07:52:19 <TallTim> verbose mode
1012022-05-16T08:21:40 *** Kaizen_Kintsugi_ <Kaizen_Kintsugi_!~Kaizen_Ki@2600:8802:3806:c200:3135:748c:ab7d:458f> has quit IRC (Ping timeout: 260 seconds)
1022022-05-16T08:40:25 <bitcoin-git> [bitcoin] MarcoFalke pushed 6 commits to master: https://github.com/bitcoin/bitcoin/compare/b74a6dde8cf5...bc2eee72672a
1032022-05-16T08:40:26 <bitcoin-git> bitcoin/master 370120e Jon Atack: Remove obsolete BDB ENABLE_WALLET section in developer notes
1042022-05-16T08:40:26 <bitcoin-git> bitcoin/master fc4cb85 Jon Atack: Prefer Python for scripts in developer notes
1052022-05-16T08:40:26 <bitcoin-git> bitcoin/master 5fca70f Jon Atack: Link in developer notes style to internal interface exception
1062022-05-16T08:40:29 <bitcoin-git> [bitcoin] MarcoFalke merged pull request #25092: doc: various developer notes updates (master...developer-notes-updates-may-2022) https://github.com/bitcoin/bitcoin/pull/25092
1072022-05-16T08:47:47 *** AaronvanW <AaronvanW!~AaronvanW@user/AaronvanW> has quit IRC (Remote host closed the connection)
1082022-05-16T08:50:56 <bitcoin-git> [bitcoin] MarcoFalke pushed 4 commits to master: https://github.com/bitcoin/bitcoin/compare/bc2eee72672a...195df1eb883d
1092022-05-16T08:50:57 <bitcoin-git> bitcoin/master 23854f8 Jon Atack: refactor: make MainSignalsInstance() a class
1102022-05-16T08:50:57 <bitcoin-git> bitcoin/master 2aaec23 Jon Atack: refactor: remove unused forward declarations in validationinterface.h
1112022-05-16T08:50:57 <bitcoin-git> bitcoin/master ca1ac1f Jon Atack: scripted-diff: Rename MainSignalsInstance() class to MainSignalsImpl()
1122022-05-16T08:50:59 <bitcoin-git> [bitcoin] MarcoFalke merged pull request #25067: validationinterface: make MainSignalsInstance() a class, drop unused forward declarations (master...make-MainSignalsInstance-a-class-and-move-to-header-file) https://github.com/bitcoin/bitcoin/pull/25067
1132022-05-16T08:52:25 *** Kaizen_Kintsugi_ <Kaizen_Kintsugi_!~Kaizen_Ki@ip72-194-104-106.oc.oc.cox.net> has joined #bitcoin-core-dev
1142022-05-16T08:56:56 *** Kaizen_Kintsugi_ <Kaizen_Kintsugi_!~Kaizen_Ki@ip72-194-104-106.oc.oc.cox.net> has quit IRC (Ping timeout: 248 seconds)
1152022-05-16T09:01:47 <bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/195df1eb883d...1511c9efb405
1162022-05-16T09:01:48 <bitcoin-git> bitcoin/master 06822f8 Luke Dashjr: Bugfix: RPC/blockchain: Correct description of getblockchaininfo's prunehe...
1172022-05-16T09:01:48 <bitcoin-git> bitcoin/master 1511c9e MacroFake: Merge bitcoin/bitcoin#24640: Bugfix: RPC/blockchain: Correct description o...
1182022-05-16T09:01:51 <bitcoin-git> [bitcoin] MarcoFalke merged pull request #24640: Bugfix: RPC/blockchain: Correct description of getblockchaininfo's pruneheight result (master...fix_rpcdoc_gbci_pruneheight_desc) https://github.com/bitcoin/bitcoin/pull/24640
1192022-05-16T09:05:51 *** z9z0b3t1_ <z9z0b3t1_!z9z0b3t1c@gateway/vpn/protonvpn/z9z0b3t1c> has joined #bitcoin-core-dev
1202022-05-16T09:09:35 *** z9z0b3t1c <z9z0b3t1c!z9z0b3t1c@gateway/vpn/protonvpn/z9z0b3t1c> has quit IRC (Ping timeout: 256 seconds)
1212022-05-16T09:18:38 *** AaronvanW <AaronvanW!~AaronvanW@user/AaronvanW> has joined #bitcoin-core-dev
1222022-05-16T09:26:17 *** Kaizen_Kintsugi_ <Kaizen_Kintsugi_!~Kaizen_Ki@2600:8802:3806:c200:3135:748c:ab7d:458f> has joined #bitcoin-core-dev
1232022-05-16T09:30:10 *** jonatack <jonatack!~jonatack@user/jonatack> has quit IRC (Ping timeout: 240 seconds)
1242022-05-16T09:51:17 *** aleggg <aleggg!~aleggg@177.204.163.75.dynamic.adsl.gvt.net.br> has quit IRC (Ping timeout: 260 seconds)
1252022-05-16T09:52:14 *** aleggg <aleggg!~aleggg@189.114.128.145.dynamic.adsl.gvt.net.br> has joined #bitcoin-core-dev
1262022-05-16T09:59:11 *** AaronvanW <AaronvanW!~AaronvanW@user/AaronvanW> has quit IRC (Remote host closed the connection)
1272022-05-16T10:16:08 *** TallTim_ <TallTim_!~talltim@184-83-250-114-dynamic.midco.net> has joined #bitcoin-core-dev
1282022-05-16T10:19:27 *** TallTim <TallTim!~talltim@184-83-250-114-dynamic.midco.net> has quit IRC (Ping timeout: 276 seconds)
1292022-05-16T10:29:48 *** Kaizen_Kintsugi_ <Kaizen_Kintsugi_!~Kaizen_Ki@2600:8802:3806:c200:3135:748c:ab7d:458f> has quit IRC (Ping timeout: 272 seconds)
1302022-05-16T10:29:56 *** AaronvanW <AaronvanW!~AaronvanW@user/AaronvanW> has joined #bitcoin-core-dev
1312022-05-16T10:31:17 *** cold <cold!~cold@user/cold> has quit IRC (Ping timeout: 252 seconds)
1322022-05-16T10:31:25 *** midnight_ <midnight_!~midnight@user/midnight> has joined #bitcoin-core-dev
1332022-05-16T10:31:26 *** midnight <midnight!~midnight@user/midnight> has quit IRC (Ping timeout: 246 seconds)
1342022-05-16T10:31:57 *** cold <cold!~cold@user/cold> has joined #bitcoin-core-dev
1352022-05-16T10:34:01 *** goatpig <goatpig!~goat@2001:861:3241:fa40:e5f5:f5bf:43db:45e2> has quit IRC (Remote host closed the connection)
1362022-05-16T10:34:27 *** goatpig <goatpig!~goat@2001:861:3241:fa40:e5f5:f5bf:43db:45e2> has joined #bitcoin-core-dev
1372022-05-16T10:58:35 *** Kaizen_Kintsugi_ <Kaizen_Kintsugi_!~Kaizen_Ki@2600:8802:3806:c200:3135:748c:ab7d:458f> has joined #bitcoin-core-dev
1382022-05-16T11:03:27 *** AaronvanW <AaronvanW!~AaronvanW@user/AaronvanW> has quit IRC (Ping timeout: 240 seconds)
1392022-05-16T11:03:44 *** Kaizen_Kintsugi_ <Kaizen_Kintsugi_!~Kaizen_Ki@2600:8802:3806:c200:3135:748c:ab7d:458f> has quit IRC (Ping timeout: 252 seconds)
1402022-05-16T11:04:57 *** AaronvanW <AaronvanW!~AaronvanW@user/AaronvanW> has joined #bitcoin-core-dev
1412022-05-16T11:10:14 *** AaronvanW <AaronvanW!~AaronvanW@user/AaronvanW> has quit IRC (Remote host closed the connection)
1422022-05-16T11:13:48 *** roconnor <roconnor!~roconnor@coq/roconnor> has joined #bitcoin-core-dev
1432022-05-16T11:14:42 *** AaronvanW <AaronvanW!~AaronvanW@user/AaronvanW> has joined #bitcoin-core-dev
1442022-05-16T11:18:35 *** Kaizen_Kintsugi_ <Kaizen_Kintsugi_!~Kaizen_Ki@2600:8802:3806:c200:3135:748c:ab7d:458f> has joined #bitcoin-core-dev
1452022-05-16T11:19:59 *** Guyver2_ <Guyver2_!~Guyver@77-174-98-73.fixed.kpn.net> has joined #bitcoin-core-dev
1462022-05-16T11:21:02 *** AaronvanW <AaronvanW!~AaronvanW@user/AaronvanW> has quit IRC (Remote host closed the connection)
1472022-05-16T11:22:52 *** Guyver2 <Guyver2!~Guyver@77-174-98-73.fixed.kpn.net> has quit IRC (Ping timeout: 260 seconds)
1482022-05-16T11:30:10 *** emcy_ <emcy_!~emcy@user/emcy> has joined #bitcoin-core-dev
1492022-05-16T11:30:41 *** emcy <emcy!~emcy@user/emcy> has quit IRC (Ping timeout: 256 seconds)
1502022-05-16T11:35:28 *** goatpig <goatpig!~goat@2001:861:3241:fa40:e5f5:f5bf:43db:45e2> has quit IRC (Read error: Connection reset by peer)
1512022-05-16T11:35:53 *** goatpig <goatpig!~goat@2001:861:3241:fa40:e5f5:f5bf:43db:45e2> has joined #bitcoin-core-dev
1522022-05-16T11:40:50 *** sudoforge <sudoforge!~sudoforge@wireguard/tunneler/sudoforge> has joined #bitcoin-core-dev
1532022-05-16T11:43:17 <bitcoin-git> [bitcoin] fanquake pushed 12 commits to master: https://github.com/bitcoin/bitcoin/compare/1511c9efb405...dc0ee573734e
1542022-05-16T11:43:17 <bitcoin-git> bitcoin/master cba909e John Newbery: [net] Stop testing version 1 compact blocks.
1552022-05-16T11:43:17 <bitcoin-git> bitcoin/master 16730b6 John Newbery: [net processing] Only advertise support for version 2 compact blocks
1562022-05-16T11:43:18 <bitcoin-git> bitcoin/master 42882fc John Newbery: [net processing] Only accept `sendcmpct` with version=2
1572022-05-16T11:43:31 <bitcoin-git> [bitcoin] fanquake merged pull request #20799: net processing: Only support version 2 compact blocks (master...2020-12-remove-cmpctblock-v1) https://github.com/bitcoin/bitcoin/pull/20799
1582022-05-16T11:47:00 *** mikehu44 <mikehu44!~quassel@gateway/vpn/pia/mikehu44-jc> has quit IRC (Ping timeout: 260 seconds)
1592022-05-16T11:48:52 *** mikehu44 <mikehu44!~quassel@gateway/vpn/pia/mikehu44-jc> has joined #bitcoin-core-dev
1602022-05-16T11:50:50 *** aleggg <aleggg!~aleggg@189.114.128.145.dynamic.adsl.gvt.net.br> has quit IRC (Ping timeout: 240 seconds)
1612022-05-16T11:51:14 *** aleggg <aleggg!~aleggg@179.179.117.164> has joined #bitcoin-core-dev
1622022-05-16T11:51:58 *** AaronvanW <AaronvanW!~AaronvanW@user/AaronvanW> has joined #bitcoin-core-dev
1632022-05-16T12:07:04 *** bitdex <bitdex!~bitdex@gateway/tor-sasl/bitdex> has quit IRC (Quit: = "")
1642022-05-16T12:19:25 <bitcoin-git> [bitcoin] MarcoFalke pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/dc0ee573734e...aa3200d89672
1652022-05-16T12:19:25 <bitcoin-git> bitcoin/master 7d73f58 Anthony Towns: Increase threadsafety annotation coverage
1662022-05-16T12:19:25 <bitcoin-git> bitcoin/master 436ce02 Anthony Towns: sync.h: strengthen AssertLockNotHeld assertion
1672022-05-16T12:19:26 <bitcoin-git> bitcoin/master aa3200d MacroFake: Merge bitcoin/bitcoin#25109: Strengthen AssertLockNotHeld assertions
1682022-05-16T12:19:27 <bitcoin-git> [bitcoin] MarcoFalke merged pull request #25109: Strengthen AssertLockNotHeld assertions (master...202205-neg-anno-assertnotheld-only) https://github.com/bitcoin/bitcoin/pull/25109
1692022-05-16T12:19:47 *** Kaizen_Kintsugi_ <Kaizen_Kintsugi_!~Kaizen_Ki@2600:8802:3806:c200:3135:748c:ab7d:458f> has quit IRC (Ping timeout: 240 seconds)
1702022-05-16T12:21:16 *** roconnor_ <roconnor_!~roconnor@coq/roconnor> has joined #bitcoin-core-dev
1712022-05-16T12:21:49 *** AaronvanW <AaronvanW!~AaronvanW@user/AaronvanW> has quit IRC (Remote host closed the connection)
1722022-05-16T12:22:18 *** roconnor <roconnor!~roconnor@coq/roconnor> has quit IRC (Ping timeout: 276 seconds)
1732022-05-16T12:32:06 *** ___nick___ <___nick___!~quassel@cpc68286-cdif17-2-0-cust533.5-1.cable.virginm.net> has quit IRC (Quit: https://quassel-irc.org - Chat comfortably. Anywhere.)
1742022-05-16T12:33:44 *** ___nick___ <___nick___!~quassel@cpc68286-cdif17-2-0-cust533.5-1.cable.virginm.net> has joined #bitcoin-core-dev
1752022-05-16T12:34:26 *** ___nick___ <___nick___!~quassel@cpc68286-cdif17-2-0-cust533.5-1.cable.virginm.net> has quit IRC (Client Quit)
1762022-05-16T12:36:10 *** ___nick___ <___nick___!~quassel@cpc68286-cdif17-2-0-cust533.5-1.cable.virginm.net> has joined #bitcoin-core-dev
1772022-05-16T12:48:13 *** AaronvanW <AaronvanW!~AaronvanW@user/AaronvanW> has joined #bitcoin-core-dev
1782022-05-16T12:49:07 *** Guyver2__ <Guyver2__!Guyver@77-174-98-73.fixed.kpn.net> has joined #bitcoin-core-dev
1792022-05-16T12:49:18 *** TallTim_ is now known as TallTim
1802022-05-16T12:50:08 *** Kaizen_Kintsugi_ <Kaizen_Kintsugi_!~Kaizen_Ki@2600:8802:3806:c200:3135:748c:ab7d:458f> has joined #bitcoin-core-dev
1812022-05-16T12:51:50 *** Guyver2_ <Guyver2_!~Guyver@77-174-98-73.fixed.kpn.net> has quit IRC (Ping timeout: 240 seconds)
1822022-05-16T12:52:08 *** Guyver2_ <Guyver2_!~Guyver@2a02-a45c-ba8d-1-d5c9-1ab9-92f7-fd69.fixed6.kpn.net> has joined #bitcoin-core-dev
1832022-05-16T12:53:24 *** Guyver2__ <Guyver2__!Guyver@77-174-98-73.fixed.kpn.net> has quit IRC (Ping timeout: 248 seconds)
1842022-05-16T12:54:19 *** Kaizen_Kintsugi_ <Kaizen_Kintsugi_!~Kaizen_Ki@2600:8802:3806:c200:3135:748c:ab7d:458f> has quit IRC (Ping timeout: 240 seconds)
1852022-05-16T13:06:10 <_aj_> hmm, seems like marco's wresting control of his github account back from drahtbot
1862022-05-16T13:07:06 <fanquake> ongoing situation
1872022-05-16T13:07:23 *** furszy <furszy!~furszy@user/furszy> has joined #bitcoin-core-dev
1882022-05-16T13:07:57 <_aj_> hopefully a short victorious battle will see him soon rejoin irc?
1892022-05-16T13:23:24 *** Kaizen_Kintsugi_ <Kaizen_Kintsugi_!~Kaizen_Ki@2600:8802:3806:c200:3135:748c:ab7d:458f> has joined #bitcoin-core-dev
1902022-05-16T13:25:45 *** jonatack <jonatack!~jonatack@user/jonatack> has joined #bitcoin-core-dev
1912022-05-16T13:26:55 <bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/aa3200d89672...b019cdc03634
1922022-05-16T13:26:55 <bitcoin-git> bitcoin/master fa347a9 MacroFake: rpc: Fix implicit-integer-sign-change in gettxout
1932022-05-16T13:26:55 <bitcoin-git> bitcoin/master b019cdc fanquake: Merge bitcoin/bitcoin#25095: rpc: Fix implicit-integer-sign-change in gett...
1942022-05-16T13:26:59 <bitcoin-git> [bitcoin] fanquake merged pull request #25095: rpc: Fix implicit-integer-sign-change in gettxout (master...2205-rpc-int-ubsan-ð) https://github.com/bitcoin/bitcoin/pull/25095
1952022-05-16T13:29:23 *** z9z0b3t1c <z9z0b3t1c!z9z0b3t1c@gateway/vpn/protonvpn/z9z0b3t1c> has joined #bitcoin-core-dev
1962022-05-16T13:29:30 <bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/b019cdc03634...6b87fa540c40
1972022-05-16T13:29:31 <bitcoin-git> bitcoin/master fae3200 MacroFake: test: Slim down versionbits_tests.cpp
1982022-05-16T13:29:31 <bitcoin-git> bitcoin/master 6b87fa5 fanquake: Merge bitcoin/bitcoin#25125: test: Slim down versionbits_tests.cpp
1992022-05-16T13:29:32 <bitcoin-git> [bitcoin] fanquake merged pull request #25125: test: Slim down versionbits_tests.cpp (master...2205-test-slim-ð) https://github.com/bitcoin/bitcoin/pull/25125
2002022-05-16T13:31:41 *** mikehu44 <mikehu44!~quassel@gateway/vpn/pia/mikehu44-jc> has quit IRC (Quit: No Ping reply in 180 seconds.)
2012022-05-16T13:32:31 *** z9z0b3t1_ <z9z0b3t1_!z9z0b3t1c@gateway/vpn/protonvpn/z9z0b3t1c> has quit IRC (Ping timeout: 256 seconds)
2022022-05-16T13:33:02 *** mikehu44 <mikehu44!~quassel@gateway/vpn/pia/mikehu44-jc> has joined #bitcoin-core-dev
2032022-05-16T13:37:43 *** Guyver2_ <Guyver2_!~Guyver@2a02-a45c-ba8d-1-d5c9-1ab9-92f7-fd69.fixed6.kpn.net> has left #bitcoin-core-dev
2042022-05-16T13:49:50 *** aleggg <aleggg!~aleggg@179.179.117.164> has quit IRC (Ping timeout: 240 seconds)
2052022-05-16T13:50:49 *** aleggg <aleggg!~aleggg@179.176.67.181.dynamic.adsl.gvt.net.br> has joined #bitcoin-core-dev
2062022-05-16T13:55:49 *** roconnor_ is now known as roconnor
2072022-05-16T13:56:55 *** bfsfhkacjzgcytf9 <bfsfhkacjzgcytf9!~bfsfhkacj@user/bfsfhkacjzgcytf> has joined #bitcoin-core-dev
2082022-05-16T14:11:28 <hebasto> luke-jr: re 20:07:36 <luke-jr> master GUI appears to segfault if it gets an unsupported wallet format :/ -- mind opening an issue?
2092022-05-16T14:15:57 *** furszy <furszy!~furszy@user/furszy> has quit IRC (Remote host closed the connection)
2102022-05-16T14:24:34 <bitcoin-git> [bitcoin] MarcoFalke opened pull request #25144: refactor: Pass Peer& to Misbehaving() (master...2205-mis-peer-ð¥) https://github.com/bitcoin/bitcoin/pull/25144
2112022-05-16T14:27:14 <bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/6b87fa540c40...07cb4dee5d12
2122022-05-16T14:27:15 <bitcoin-git> bitcoin/master 11e7908 Martin Leitner-Ankerl: prevector: only allow trivially copyable types
2132022-05-16T14:27:15 <bitcoin-git> bitcoin/master 07cb4de MacroFake: Merge bitcoin/bitcoin#24962: prevector: enforce is_trivially_copyable_v
2142022-05-16T14:27:21 <bitcoin-git> [bitcoin] MarcoFalke merged pull request #24962: prevector: enforce is_trivially_copyable_v (master...2022-04_prevector_fixes) https://github.com/bitcoin/bitcoin/pull/24962
2152022-05-16T14:27:36 *** Kaizen_Kintsugi_ <Kaizen_Kintsugi_!~Kaizen_Ki@2600:8802:3806:c200:3135:748c:ab7d:458f> has quit IRC (Ping timeout: 248 seconds)
2162022-05-16T14:29:54 *** Kaizen_Kintsugi_ <Kaizen_Kintsugi_!~Kaizen_Ki@2600:8802:3806:c200:3135:748c:ab7d:458f> has joined #bitcoin-core-dev
2172022-05-16T14:34:32 *** Kaizen_Kintsugi_ <Kaizen_Kintsugi_!~Kaizen_Ki@2600:8802:3806:c200:3135:748c:ab7d:458f> has quit IRC (Ping timeout: 248 seconds)
2182022-05-16T14:40:55 *** Kaizen_Kintsugi_ <Kaizen_Kintsugi_!~Kaizen_Ki@2600:8802:3806:c200:3135:748c:ab7d:458f> has joined #bitcoin-core-dev
2192022-05-16T14:52:07 *** mikehu44 <mikehu44!~quassel@gateway/vpn/pia/mikehu44-jc> has quit IRC (Ping timeout: 240 seconds)
2202022-05-16T15:31:20 *** jespada <jespada!~jespada@cpc121022-nmal24-2-0-cust171.19-2.cable.virginm.net> has quit IRC (Quit: Textual IRC Client: www.textualapp.com)
2212022-05-16T15:43:56 *** Kaizen_Kintsugi_ <Kaizen_Kintsugi_!~Kaizen_Ki@2600:8802:3806:c200:3135:748c:ab7d:458f> has quit IRC (Ping timeout: 272 seconds)
2222022-05-16T15:44:30 *** salvatoshi <salvatoshi!~salvatosh@genymobile-2-6-86.fib.nerim.net> has quit IRC (Ping timeout: 240 seconds)
2232022-05-16T15:47:40 *** cryptapus <cryptapus!~cryptapus@user/cryptapus> has quit IRC (Remote host closed the connection)
2242022-05-16T15:51:56 *** aleggg <aleggg!~aleggg@179.176.67.181.dynamic.adsl.gvt.net.br> has quit IRC (Ping timeout: 252 seconds)
2252022-05-16T15:52:53 *** aleggg <aleggg!~aleggg@179.177.106.54.dynamic.adsl.gvt.net.br> has joined #bitcoin-core-dev
2262022-05-16T15:57:10 *** Kaizen_Kintsugi_ <Kaizen_Kintsugi_!~Kaizen_Ki@ip72-194-104-106.oc.oc.cox.net> has joined #bitcoin-core-dev
2272022-05-16T16:11:10 *** evanlinjin <evanlinjin!~evanlinji@gateway/tor-sasl/evanlinjin> has joined #bitcoin-core-dev
2282022-05-16T16:18:27 *** goatpig <goatpig!~goat@2001:861:3241:fa40:e5f5:f5bf:43db:45e2> has quit IRC (Remote host closed the connection)
2292022-05-16T16:19:16 *** cryptapus <cryptapus!~cryptapus@user/cryptapus> has joined #bitcoin-core-dev
2302022-05-16T16:30:11 *** bomb-on <bomb-on!~bomb-on@user/bomb-on> has joined #bitcoin-core-dev
2312022-05-16T16:32:34 *** evanlinjin <evanlinjin!~evanlinji@gateway/tor-sasl/evanlinjin> has quit IRC (Ping timeout: 240 seconds)
2322022-05-16T16:48:57 *** Talkless <Talkless!~Talkless@mail.dargis.net> has joined #bitcoin-core-dev
2332022-05-16T16:54:47 *** jonatack <jonatack!~jonatack@user/jonatack> has quit IRC (Ping timeout: 260 seconds)
2342022-05-16T16:59:27 *** Kaizen_Kintsugi_ <Kaizen_Kintsugi_!~Kaizen_Ki@ip72-194-104-106.oc.oc.cox.net> has quit IRC (Ping timeout: 260 seconds)
2352022-05-16T17:00:02 *** bairen <bairen!~bairen@gateway/tor-sasl/bairen> has quit IRC (Remote host closed the connection)
2362022-05-16T17:01:47 *** Kaizen_Kintsugi_ <Kaizen_Kintsugi_!~Kaizen_Ki@2600:8802:3806:c200:3135:748c:ab7d:458f> has joined #bitcoin-core-dev
2372022-05-16T17:32:06 <luke-jr> hebasto: do we want issues for master-only bugs now?
2382022-05-16T17:32:34 <sipa> Why not?
2392022-05-16T17:33:05 <luke-jr> idk, seems like it would hopefully be too short-lived
2402022-05-16T17:33:38 <sipa> If it's longer lived than you mentioning it on IRC, it seems preferable to have an issue open for it so it's not forgotten.
2412022-05-16T17:34:10 <luke-jr> maybe I should just debug it :x
2422022-05-16T17:34:21 <sipa> Like, if you or something else were to open a PR immediately to fix it, I'd say an issue isn't needed (but it still wouldn't hurt).
2432022-05-16T17:34:26 <sipa> *someone else
2442022-05-16T17:36:45 *** NorrinRadd <NorrinRadd!~username@102.67.16.112> has joined #bitcoin-core-dev
2452022-05-16T17:43:38 *** NorrinRadd <NorrinRadd!~username@102.67.16.112> has quit IRC (Ping timeout: 272 seconds)
2462022-05-16T17:46:04 <luke-jr> ugh, it's in spaghetti code
2472022-05-16T17:46:08 * luke-jr just opens an issue instead x.x
2482022-05-16T17:46:38 *** z9z0b3t1_ <z9z0b3t1_!z9z0b3t1c@gateway/vpn/protonvpn/z9z0b3t1c> has joined #bitcoin-core-dev
2492022-05-16T17:49:47 *** z9z0b3t1c <z9z0b3t1c!z9z0b3t1c@gateway/vpn/protonvpn/z9z0b3t1c> has quit IRC (Ping timeout: 256 seconds)
2502022-05-16T17:54:05 <bitcoin-git> [bitcoin] jnewbery opened pull request #25147: Net processing: follow ups to #20799 (removing support for v1 compact blocks) (master...20205_20799_follow_ups) https://github.com/bitcoin/bitcoin/pull/25147
2512022-05-16T17:58:22 *** sipsorcery <sipsorcery!~sipsorcer@2a02:8084:6180:500::12b> has joined #bitcoin-core-dev
2522022-05-16T18:01:04 *** szkl <szkl!uid110435@id-110435.uxbridge.irccloud.com> has quit IRC (Quit: Connection closed for inactivity)
2532022-05-16T18:16:06 *** Nekorand <Nekorand!~Random@cm-188-171-200-176.telecable.es> has joined #bitcoin-core-dev
2542022-05-16T18:32:06 *** ___nick___ <___nick___!~quassel@cpc68286-cdif17-2-0-cust533.5-1.cable.virginm.net> has quit IRC (Quit: https://quassel-irc.org - Chat comfortably. Anywhere.)
2552022-05-16T18:33:46 *** ___nick___ <___nick___!~quassel@cpc68286-cdif17-2-0-cust533.5-1.cable.virginm.net> has joined #bitcoin-core-dev
2562022-05-16T18:34:27 *** ___nick___ <___nick___!~quassel@cpc68286-cdif17-2-0-cust533.5-1.cable.virginm.net> has quit IRC (Client Quit)
2572022-05-16T18:36:02 <bitcoin-git> [bitcoin] achow101 pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/07cb4dee5d12...187504b038cc
2582022-05-16T18:36:03 <bitcoin-git> bitcoin/master a7b65af Sebastian Falbesoner: rpc: avoid scriptPubKeyCTxDestination conversions in `GetReceived` tally
2592022-05-16T18:36:03 <bitcoin-git> bitcoin/master f336ff7 Sebastian Falbesoner: rpc: avoid expensive `IsMine` calls in `GetReceived` tally
2602022-05-16T18:36:03 <bitcoin-git> bitcoin/master 187504b Andrew Chow: Merge bitcoin/bitcoin#23662: rpc: improve `getreceivedby{address,label}` p...
2612022-05-16T18:36:08 *** ___nick___ <___nick___!~quassel@cpc68286-cdif17-2-0-cust533.5-1.cable.virginm.net> has joined #bitcoin-core-dev
2622022-05-16T18:36:10 <bitcoin-git> [bitcoin] achow101 merged pull request #23662: rpc: improve `getreceivedby{address,label}` performance (master...202112-rpc-improve_getreceivedby_performance) https://github.com/bitcoin/bitcoin/pull/23662
2632022-05-16T18:53:36 *** Kaizen_Kintsugi_ <Kaizen_Kintsugi_!~Kaizen_Ki@2600:8802:3806:c200:3135:748c:ab7d:458f> has quit IRC (Remote host closed the connection)
2642022-05-16T18:53:51 *** Kaizen_Kintsugi_ <Kaizen_Kintsugi_!~Kaizen_Ki@2600:8802:3806:c200:3c67:f8b:edb7:5828> has joined #bitcoin-core-dev
2652022-05-16T18:56:01 <bitcoin-git> [bitcoin] hebasto opened pull request #25148: refactor: Remove `NO_THREAD_SAFETY_ANALYSIS` from non-test/benchmarking code (master...220516-todo) https://github.com/bitcoin/bitcoin/pull/25148
2662022-05-16T19:08:47 *** jonatack <jonatack!~jonatack@user/jonatack> has joined #bitcoin-core-dev
2672022-05-16T19:14:44 *** Talkless <Talkless!~Talkless@mail.dargis.net> has quit IRC (Quit: Konversation terminated!)
2682022-05-16T19:30:15 <bitcoin-git> [bitcoin] achow101 pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/187504b038cc...98f4db33056b
2692022-05-16T19:30:16 <bitcoin-git> bitcoin/master ba10b90 Luke Dashjr: Wallet: Ensure m_attaching_chain is set before registering for signals
2702022-05-16T19:30:16 <bitcoin-git> bitcoin/master 98f4db3 Andrew Chow: Merge bitcoin/bitcoin#25088: Wallet: Ensure m_attaching_chain is set befor...
2712022-05-16T19:30:23 <bitcoin-git> [bitcoin] achow101 merged pull request #25088: Wallet: Ensure m_attaching_chain is set before registering for signals (master...fix_wallet_race_attachingbb) https://github.com/bitcoin/bitcoin/pull/25088
2722022-05-16T19:57:44 <bitcoin-git> [bitcoin] achow101 pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/98f4db33056b...91a42d63efaf
2732022-05-16T19:57:44 <bitcoin-git> bitcoin/master 2a22f03 avirgovi: parsing external signer master fingerprint string as bytes instead of cari...
2742022-05-16T19:57:44 <bitcoin-git> bitcoin/master 91a42d6 Andrew Chow: Merge bitcoin/bitcoin#25019: parse external signer master fp as bytes in E...
2752022-05-16T19:57:51 <bitcoin-git> [bitcoin] achow101 merged pull request #25019: parse external signer master fp as bytes in ExternalSigner::SignTransaction (master...lower_master_fp_of_ext_signer_in_SignTransaction) https://github.com/bitcoin/bitcoin/pull/25019
2762022-05-16T20:04:22 *** ___nick___ <___nick___!~quassel@cpc68286-cdif17-2-0-cust533.5-1.cable.virginm.net> has quit IRC (Ping timeout: 260 seconds)
2772022-05-16T20:10:12 *** Nekorand <Nekorand!~Random@cm-188-171-200-176.telecable.es> has quit IRC (Quit: Leaving)
2782022-05-16T20:20:08 <bitcoin-git> [bitcoin] hebasto opened pull request #25149: refactor: Add thread safety annotation to `BanMan::SweepBanned()` (master...220516-bantsa) https://github.com/bitcoin/bitcoin/pull/25149
2792022-05-16T20:37:47 *** szkl <szkl!uid110435@id-110435.uxbridge.irccloud.com> has joined #bitcoin-core-dev
2802022-05-16T20:49:38 *** hashfunc16f7 <hashfunc16f7!~user@2601:5c0:c280:7090:7c25:cf68:625f:614f> has joined #bitcoin-core-dev
2812022-05-16T21:04:24 *** djb27_ <djb27_!djb27@user/djb27> has quit IRC (Ping timeout: 248 seconds)
2822022-05-16T21:56:03 *** z9z0b3t1c <z9z0b3t1c!z9z0b3t1c@gateway/vpn/protonvpn/z9z0b3t1c> has joined #bitcoin-core-dev
2832022-05-16T21:59:07 *** z9z0b3t1_ <z9z0b3t1_!z9z0b3t1c@gateway/vpn/protonvpn/z9z0b3t1c> has quit IRC (Ping timeout: 256 seconds)
2842022-05-16T22:09:19 *** hashfunc16f7 <hashfunc16f7!~user@2601:5c0:c280:7090:7c25:cf68:625f:614f> has quit IRC (Ping timeout: 240 seconds)
2852022-05-16T22:12:03 *** Kaizen_Kintsugi_ <Kaizen_Kintsugi_!~Kaizen_Ki@2600:8802:3806:c200:3c67:f8b:edb7:5828> has quit IRC (Remote host closed the connection)
2862022-05-16T22:12:41 *** Kaizen_Kintsugi_ <Kaizen_Kintsugi_!~Kaizen_Ki@2600:8802:3806:c200:3c67:f8b:edb7:5828> has joined #bitcoin-core-dev
2872022-05-16T22:14:57 *** Kaizen_Kintsugi_ <Kaizen_Kintsugi_!~Kaizen_Ki@2600:8802:3806:c200:3c67:f8b:edb7:5828> has quit IRC (Remote host closed the connection)
2882022-05-16T22:15:12 *** Kaizen_Kintsugi_ <Kaizen_Kintsugi_!~Kaizen_Ki@2600:8802:3806:c200:3c67:f8b:edb7:5828> has joined #bitcoin-core-dev
2892022-05-16T22:29:31 *** Kaizen_Kintsugi_ <Kaizen_Kintsugi_!~Kaizen_Ki@2600:8802:3806:c200:3c67:f8b:edb7:5828> has quit IRC (Remote host closed the connection)
2902022-05-16T22:30:09 *** Kaizen_Kintsugi_ <Kaizen_Kintsugi_!~Kaizen_Ki@2600:8802:3806:c200:3135:748c:ab7d:458f> has joined #bitcoin-core-dev
2912022-05-16T22:34:26 <david-bakin> So, I understand you squash commits before submitting a PR. But when responding to code review suggestions/requests - do you squash and force-push those fix commits? Because doesn't that mess up the PR comment/history?
2922022-05-16T22:34:44 *** Kaizen_Kintsugi_ <Kaizen_Kintsugi_!~Kaizen_Ki@2600:8802:3806:c200:3135:748c:ab7d:458f> has quit IRC (Ping timeout: 248 seconds)
2932022-05-16T22:36:12 <sipa> There is a general philosophical divide on this among projects, but Bitcoin Core follows a very strong squash-before-merging policy.
2942022-05-16T22:36:43 <sipa> Your PR must be in a state where the individual commits make logical sense, without fixups.
2952022-05-16T22:37:42 <david-bakin> ok, squash-before-merge is fine for sure, but I thought I just read here the other day I should squash before submitting the PR? or did I read that wrong? the contributor note does talk about separating format/refactor commits from "featureish" commits ...
2962022-05-16T22:38:08 <sipa> Before submitting, definitely.
2972022-05-16T22:38:30 <sipa> No reason to bother the reviewers with the internal history your PR went through privately.
2982022-05-16T22:38:47 <david-bakin> ok ... so ... a) before submitting and c) at the merge-to-master but NOT necessairly b) during cr itself where it will mess up the PR's comment history?
2992022-05-16T22:41:17 *** sipsorcery <sipsorcery!~sipsorcer@2a02:8084:6180:500::12b> has quit IRC (Ping timeout: 260 seconds)
3002022-05-16T22:42:36 <sipa> Up to you. It may make sense to squash during a PR's review process, or not.
3012022-05-16T22:43:05 <david-bakin> hmm. ok ... I'll do what seems best & see what happens ...
3022022-05-16T22:43:16 <sipa> The goal is making things easy for reviewers, including after the fact ones that want to understand what a PR did after it got merged.
3032022-05-16T22:43:53 <david-bakin> ok
3042022-05-16T22:44:14 <sipa> If you've had a lot of in depth code review, you may not want to squash immediately, because reviewers may dislike having to go through it again.
3052022-05-16T22:47:00 <sipa> But also, a lot of time reviewers spend is on understanding your code changes and concept, rather than actual line-by-line review, and most of that isn't invalidated by squashing.
3062022-05-16T22:48:47 <david-bakin> ok. here's a question I have about the bitcoin CR experience vs that I've experienced at companies: Is the line-by-line review not valued in general or is it just the unfortunate lack of reviewers + reviewer's time? IOW, I don't have the experience (yet) to do the "big picture" concept acks/nacks - but I _do_ know how to do close-reading of code for correctness. Is it worth doing?
3072022-05-16T22:49:29 <sipa> I'm not sure what you mean. Both are important.
3082022-05-16T22:49:32 *** Kaizen_Kintsugi_ <Kaizen_Kintsugi_!~Kaizen_Ki@ip72-194-104-106.oc.oc.cox.net> has joined #bitcoin-core-dev
3092022-05-16T22:50:46 <sipa> But people only pay attention to PRs they are interested in obviously, as there is no one to tell them what to work on. That sometimes means fighting for reviewer attention (regardless of what type of review).
3102022-05-16T22:52:01 <david-bakin> ok
3112022-05-16T23:09:48 *** jarthur_ <jarthur_!~jarthur@user/jarthur> has joined #bitcoin-core-dev
3122022-05-16T23:10:40 *** jarthur <jarthur!~jarthur@user/jarthur> has quit IRC (Ping timeout: 260 seconds)
3132022-05-16T23:11:15 *** Kaizen_Kintsugi_ <Kaizen_Kintsugi_!~Kaizen_Ki@ip72-194-104-106.oc.oc.cox.net> has quit IRC (Remote host closed the connection)
3142022-05-16T23:11:51 *** Kaizen_Kintsugi_ <Kaizen_Kintsugi_!~Kaizen_Ki@ip72-194-104-106.oc.oc.cox.net> has joined #bitcoin-core-dev
3152022-05-16T23:16:17 *** Kaizen_Kintsugi_ <Kaizen_Kintsugi_!~Kaizen_Ki@ip72-194-104-106.oc.oc.cox.net> has quit IRC (Ping timeout: 260 seconds)
3162022-05-16T23:30:56 *** Kaizen_Kintsugi_ <Kaizen_Kintsugi_!~Kaizen_Ki@2600:8802:3806:c200:3c67:f8b:edb7:5828> has joined #bitcoin-core-dev
3172022-05-16T23:36:36 <luke-jr> david-bakin: I'd say the actual code review is *more* helpful than the high-level concept ack, since the latter is easy and the former tends to be the bottleneck
3182022-05-16T23:38:02 <david-bakin> luke-jr that's what I would have thought (again, based on my long experience as a software engineer) but ... I wasn't actually sure it was valued here ... especially by people (like me) who don't have the knowledge to give a concept (n)ack ... I'm thinking of doing CRs with _just_ the close reading and _not_ the concept (n)ack it that'd be appropriate
3192022-05-16T23:45:47 <sipa> luke-jr: it may depend on what PR you're talking about. I think it happens that some bigger, more conceptually invasive don't get reviewed (enough) precisely because it's unclear to reviewers to what extent it's likely the project will go that direction.
3202022-05-16T23:46:15 <sipa> There is a spectrum of course between very high level conceptual direction, and line-by-line nitty naming style comments.
3212022-05-16T23:47:34 <sipa> But personally, I find that even when I've done line-by-line review of a change, I don't actually mind it being squashed, because most of the work was trying to understand how and why the code changes are what they are. Going over the line-by-line changes again a second time tends to be a lot faster (and even if it's a lot, diffing the diffs can help).
3222022-05-16T23:48:33 *** brunoerg <brunoerg!~brunoerg@2804:14d:5281:8ae2:ac98:9665:2456:9ae3> has quit IRC (Remote host closed the connection)
3232022-05-16T23:48:54 <david-bakin> sipa yes I'm not much fussed about naming myself or other small things - my focus is generally on coding for reliability and testability and readability. my question about squashing was becauase I'm not actually that used to how github handles comments on "squashed" code - i'm more used to dedicated code review tools that specifically know about diffs between different commits on
3242022-05-16T23:48:54 <david-bakin> the way to the final pr 'cause that's their focus
3252022-05-16T23:50:50 *** bitdex <bitdex!~bitdex@gateway/tor-sasl/bitdex> has joined #bitcoin-core-dev
3262022-05-16T23:53:32 <sipa> With a few very big changes in the past (my own PRs) I've maintained two parallel versions of the PR, one which was mostly append-only (adding fixup commits), and one with the merged-together clean-history version, keeping them in sync w.r.t. their final state.
3272022-05-16T23:53:43 *** brunoerg <brunoerg!~brunoerg@2804:14d:5281:8ae2:ac98:9665:2456:9ae3> has joined #bitcoin-core-dev
3282022-05-16T23:54:00 <sipa> So that you could both see the result, and the history how it got there. But that's definitely overkill for most changes.
3292022-05-16T23:54:26 <david-bakin> i'm not there yet! little bitty changes for me at this point! but we'll see in a few years ...
3302022-05-16T23:54:39 <sipa> I like your enthousiasm.
3312022-05-16T23:55:28 <david-bakin> !!
3322022-05-16T23:55:29 <gribble> Error: "!" is not a valid command.
3332022-05-16T23:55:38 <david-bakin> yes!
3342022-05-16T23:59:05 <david-bakin> ( I tried to answer "!!" but some bot said that wasn't a valid command - talk about squishing someone's enthusiasm - nuts to that!)