1 2022-05-17T00:01:12  *** brunoerg <brunoerg!~brunoerg@2804:14d:5281:8ae2:ac98:9665:2456:9ae3> has quit IRC (Ping timeout: 260 seconds)
  2 2022-05-17T00:07:42  *** brunoerg <brunoerg!~brunoerg@187.183.43.40> has joined #bitcoin-core-dev
  3 2022-05-17T00:38:49  <luke-jr> sipa: about 1/3 of the Knots patchset at this point is simply bugfixes that presumably should be uncontroversial conceptually
  4 2022-05-17T00:42:16  *** Kaizen_Kintsugi_ <Kaizen_Kintsugi_!~Kaizen_Ki@2600:8802:3806:c200:3c67:f8b:edb7:5828> has quit IRC (Ping timeout: 272 seconds)
  5 2022-05-17T00:50:35  *** Kaizen_Kintsugi_ <Kaizen_Kintsugi_!~Kaizen_Ki@2600:8802:3806:c200:3c67:f8b:edb7:5828> has joined #bitcoin-core-dev
  6 2022-05-17T00:55:05  *** Kaizen_Kintsugi_ <Kaizen_Kintsugi_!~Kaizen_Ki@2600:8802:3806:c200:3c67:f8b:edb7:5828> has quit IRC (Ping timeout: 260 seconds)
  7 2022-05-17T01:01:46  *** Kaizen_Kintsugi_ <Kaizen_Kintsugi_!~Kaizen_Ki@ip72-194-104-106.oc.oc.cox.net> has joined #bitcoin-core-dev
  8 2022-05-17T01:11:15  *** brunoerg <brunoerg!~brunoerg@187.183.43.40> has quit IRC (Ping timeout: 276 seconds)
  9 2022-05-17T01:19:04  *** bitdex <bitdex!~bitdex@gateway/tor-sasl/bitdex> has quit IRC (Ping timeout: 240 seconds)
 10 2022-05-17T01:21:13  *** bitdex <bitdex!~bitdex@gateway/tor-sasl/bitdex> has joined #bitcoin-core-dev
 11 2022-05-17T01:25:01  *** brunoerg <brunoerg!~brunoerg@2804:14d:5281:8ae2:ac98:9665:2456:9ae3> has joined #bitcoin-core-dev
 12 2022-05-17T01:40:56  *** theStack <theStack!~honeybadg@vps1648322.vs.webtropia-customer.com> has quit IRC (Quit: Lost terminal)
 13 2022-05-17T02:03:06  *** z9z0b3t1_ <z9z0b3t1_!z9z0b3t1c@gateway/vpn/protonvpn/z9z0b3t1c> has joined #bitcoin-core-dev
 14 2022-05-17T02:06:18  *** z9z0b3t1c <z9z0b3t1c!z9z0b3t1c@gateway/vpn/protonvpn/z9z0b3t1c> has quit IRC (Ping timeout: 246 seconds)
 15 2022-05-17T02:11:34  *** bitdex <bitdex!~bitdex@gateway/tor-sasl/bitdex> has quit IRC (Ping timeout: 240 seconds)
 16 2022-05-17T02:12:01  *** bitdex <bitdex!~bitdex@gateway/tor-sasl/bitdex> has joined #bitcoin-core-dev
 17 2022-05-17T02:16:56  *** bomb-on <bomb-on!~bomb-on@user/bomb-on> has quit IRC (Quit: aллилѹіа!)
 18 2022-05-17T02:27:04  *** brunoerg <brunoerg!~brunoerg@2804:14d:5281:8ae2:ac98:9665:2456:9ae3> has quit IRC (Ping timeout: 248 seconds)
 19 2022-05-17T02:41:04  *** bitdex <bitdex!~bitdex@gateway/tor-sasl/bitdex> has quit IRC (Ping timeout: 240 seconds)
 20 2022-05-17T02:41:41  *** bitdex <bitdex!~bitdex@gateway/tor-sasl/bitdex> has joined #bitcoin-core-dev
 21 2022-05-17T03:13:10  *** brunoerg <brunoerg!~brunoerg@2804:14d:5281:8ae2:ac98:9665:2456:9ae3> has joined #bitcoin-core-dev
 22 2022-05-17T03:14:00  *** evanlinjin <evanlinjin!~evanlinji@gateway/tor-sasl/evanlinjin> has joined #bitcoin-core-dev
 23 2022-05-17T03:18:10  *** bitdex <bitdex!~bitdex@gateway/tor-sasl/bitdex> has quit IRC (Remote host closed the connection)
 24 2022-05-17T03:18:14  *** bitdex_ <bitdex_!~bitdex@gateway/tor-sasl/bitdex> has joined #bitcoin-core-dev
 25 2022-05-17T03:23:04  *** evanlinjin <evanlinjin!~evanlinji@gateway/tor-sasl/evanlinjin> has quit IRC (Ping timeout: 240 seconds)
 26 2022-05-17T03:26:14  *** evanlinjin <evanlinjin!~evanlinji@gateway/tor-sasl/evanlinjin> has joined #bitcoin-core-dev
 27 2022-05-17T03:31:34  *** evanlinjin <evanlinjin!~evanlinji@gateway/tor-sasl/evanlinjin> has quit IRC (Ping timeout: 240 seconds)
 28 2022-05-17T03:46:42  *** AaronvanW <AaronvanW!~AaronvanW@user/AaronvanW> has quit IRC (Remote host closed the connection)
 29 2022-05-17T04:01:02  *** cmirror <cmirror!~cmirror@4.53.92.114> has quit IRC (Remote host closed the connection)
 30 2022-05-17T04:01:32  *** cmirror <cmirror!~cmirror@4.53.92.114> has joined #bitcoin-core-dev
 31 2022-05-17T04:07:09  *** mikehu44 <mikehu44!~quassel@gateway/vpn/pia/mikehu44-jc> has joined #bitcoin-core-dev
 32 2022-05-17T04:11:57  *** Kaizen_Kintsugi_ <Kaizen_Kintsugi_!~Kaizen_Ki@ip72-194-104-106.oc.oc.cox.net> has quit IRC (Ping timeout: 246 seconds)
 33 2022-05-17T04:12:32  *** Kaizen_Kintsugi_ <Kaizen_Kintsugi_!~Kaizen_Ki@ip72-194-104-106.oc.oc.cox.net> has joined #bitcoin-core-dev
 34 2022-05-17T04:16:42  *** brunoerg <brunoerg!~brunoerg@2804:14d:5281:8ae2:ac98:9665:2456:9ae3> has quit IRC (Ping timeout: 260 seconds)
 35 2022-05-17T04:17:29  *** AaronvanW <AaronvanW!~AaronvanW@user/AaronvanW> has joined #bitcoin-core-dev
 36 2022-05-17T04:19:02  *** Kaizen_Kintsugi_ <Kaizen_Kintsugi_!~Kaizen_Ki@ip72-194-104-106.oc.oc.cox.net> has quit IRC (Ping timeout: 260 seconds)
 37 2022-05-17T04:46:53  *** brunoerg <brunoerg!~brunoerg@2804:14d:5281:8ae2:ac98:9665:2456:9ae3> has joined #bitcoin-core-dev
 38 2022-05-17T04:47:39  *** lukedashjr <lukedashjr!~luke-jr@user/luke-jr> has joined #bitcoin-core-dev
 39 2022-05-17T04:49:05  *** luke-jr <luke-jr!~luke-jr@user/luke-jr> has quit IRC (Ping timeout: 252 seconds)
 40 2022-05-17T04:49:52  *** lukedashjr is now known as luke-jr
 41 2022-05-17T04:51:07  *** AaronvanW <AaronvanW!~AaronvanW@user/AaronvanW> has quit IRC (Ping timeout: 260 seconds)
 42 2022-05-17T05:28:34  *** bitdex_ <bitdex_!~bitdex@gateway/tor-sasl/bitdex> has quit IRC (Ping timeout: 240 seconds)
 43 2022-05-17T05:30:45  *** bitdex_ <bitdex_!~bitdex@gateway/tor-sasl/bitdex> has joined #bitcoin-core-dev
 44 2022-05-17T05:45:57  *** aleggg <aleggg!~aleggg@179.177.106.54.dynamic.adsl.gvt.net.br> has quit IRC (Ping timeout: 260 seconds)
 45 2022-05-17T05:50:42  *** brunoerg <brunoerg!~brunoerg@2804:14d:5281:8ae2:ac98:9665:2456:9ae3> has quit IRC (Ping timeout: 272 seconds)
 46 2022-05-17T05:52:35  *** sipsorcery <sipsorcery!~sipsorcer@2a02:8084:6180:500::12b> has joined #bitcoin-core-dev
 47 2022-05-17T06:01:15  *** aleggg <aleggg!~aleggg@177.132.197.239> has joined #bitcoin-core-dev
 48 2022-05-17T06:03:45  *** cmirror <cmirror!~cmirror@4.53.92.114> has quit IRC (Ping timeout: 276 seconds)
 49 2022-05-17T06:11:41  *** AaronvanW <AaronvanW!~AaronvanW@user/AaronvanW> has joined #bitcoin-core-dev
 50 2022-05-17T06:16:32  *** z9z0b3t1c <z9z0b3t1c!z9z0b3t1c@gateway/vpn/protonvpn/z9z0b3t1c> has joined #bitcoin-core-dev
 51 2022-05-17T06:19:28  *** z9z0b3t1_ <z9z0b3t1_!z9z0b3t1c@gateway/vpn/protonvpn/z9z0b3t1c> has quit IRC (Ping timeout: 250 seconds)
 52 2022-05-17T06:21:09  *** brunoerg <brunoerg!~brunoerg@187.183.43.40> has joined #bitcoin-core-dev
 53 2022-05-17T06:23:38  *** aleggg <aleggg!~aleggg@177.132.197.239> has quit IRC (Ping timeout: 272 seconds)
 54 2022-05-17T06:24:39  *** aleggg <aleggg!~aleggg@179.178.119.144> has joined #bitcoin-core-dev
 55 2022-05-17T06:26:55  <bitcoin-git> [bitcoin] MarcoFalke pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/91a42d63efaf...8270740befa3
 56 2022-05-17T06:26:55  <bitcoin-git> bitcoin/master 8c5533c Sebastian Falbesoner: rpc: remove deprecated "softforks" field from getblockchaininfo
 57 2022-05-17T06:26:55  <bitcoin-git> bitcoin/master a01b92a Sebastian Falbesoner: doc: add release notes about removal of the `deprecatedrpc=softforks` flag
 58 2022-05-17T06:26:55  <bitcoin-git> bitcoin/master 8270740 MacroFake: Merge bitcoin/bitcoin#25114: rpc: remove deprecated "softforks" field from...
 59 2022-05-17T06:26:59  <bitcoin-git> [bitcoin] MarcoFalke merged pull request #25114: rpc: remove deprecated "softforks" field from getblockchaininfo (master...202205-rpc-remove_deprecated_softforks_from_getblockchaininfo) https://github.com/bitcoin/bitcoin/pull/25114
 60 2022-05-17T06:43:09  *** AaronvanW <AaronvanW!~AaronvanW@user/AaronvanW> has quit IRC (Ping timeout: 246 seconds)
 61 2022-05-17T06:45:44  <bitcoin-git> [bitcoin] MarcoFalke pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/8270740befa3...0be1dc1f56f6
 62 2022-05-17T06:45:45  <bitcoin-git> bitcoin/master 8edd0d3 Sebastian Falbesoner: refactor: reduce scope of lock `m_most_recent_block_mutex`
 63 2022-05-17T06:45:45  <bitcoin-git> bitcoin/master 83003ff Sebastian Falbesoner: refactor: replace RecursiveMutex `m_most_recent_block_mutex` with Mutex
 64 2022-05-17T06:45:45  <bitcoin-git> bitcoin/master 0be1dc1 MacroFake: Merge bitcoin/bitcoin#24062: refactor: replace RecursiveMutex `m_most_rece...
 65 2022-05-17T06:45:46  <bitcoin-git> [bitcoin] MarcoFalke merged pull request #24062: refactor: replace RecursiveMutex `m_most_recent_block_mutex` with Mutex (master...202201-refactor_replace_recursive_mutex_cs_last_block) https://github.com/bitcoin/bitcoin/pull/24062
 66 2022-05-17T06:49:22  *** Guyver2 <Guyver2!~Guyver@77-174-98-73.fixed.kpn.net> has joined #bitcoin-core-dev
 67 2022-05-17T06:50:39  *** Guyver2 <Guyver2!~Guyver@77-174-98-73.fixed.kpn.net> has left #bitcoin-core-dev
 68 2022-05-17T06:52:28  <bitcoin-git> [bitcoin] Empact opened pull request #25152: refactor: Split util/system into exception, shell, and fs-specific files (master...2022-05-split-system) https://github.com/bitcoin/bitcoin/pull/25152
 69 2022-05-17T06:53:26  <bitcoin-git> [bitcoin] Empact closed pull request #24455: refactor: Split ArgsManager out of util/system (master...2022-03-util-args-manager) https://github.com/bitcoin/bitcoin/pull/24455
 70 2022-05-17T06:58:10  *** salvatoshi <salvatoshi!~salvatosh@genymobile-2-6-86.fib.nerim.net> has joined #bitcoin-core-dev
 71 2022-05-17T07:00:59  *** sipsorcery <sipsorcery!~sipsorcer@2a02:8084:6180:500::12b> has quit IRC (Ping timeout: 240 seconds)
 72 2022-05-17T07:06:11  *** ronoaldo <ronoaldo!~ronoaldo@187.56.18.151> has quit IRC (Quit: Konversation terminated!)
 73 2022-05-17T07:07:11  *** djb27_ <djb27_!djb27@user/djb27> has joined #bitcoin-core-dev
 74 2022-05-17T07:13:04  *** bitdex_ <bitdex_!~bitdex@gateway/tor-sasl/bitdex> has quit IRC (Ping timeout: 240 seconds)
 75 2022-05-17T07:22:45  *** bitdex_ <bitdex_!~bitdex@gateway/tor-sasl/bitdex> has joined #bitcoin-core-dev
 76 2022-05-17T07:25:42  *** brunoerg <brunoerg!~brunoerg@187.183.43.40> has quit IRC (Ping timeout: 272 seconds)
 77 2022-05-17T07:32:31  *** SpellChecker_ <SpellChecker_!~SpellChec@user/SpellChecker> has joined #bitcoin-core-dev
 78 2022-05-17T07:33:04  *** bitdex_ <bitdex_!~bitdex@gateway/tor-sasl/bitdex> has quit IRC (Ping timeout: 240 seconds)
 79 2022-05-17T07:33:34  *** SpellChecker <SpellChecker!~SpellChec@user/SpellChecker> has quit IRC (Ping timeout: 240 seconds)
 80 2022-05-17T07:37:41  *** bitdex_ <bitdex_!~bitdex@gateway/tor-sasl/bitdex> has joined #bitcoin-core-dev
 81 2022-05-17T07:38:54  *** Guest1 <Guest1!~Guest1@2601:647:5b80:fef0:7801:415f:db15:1a42> has joined #bitcoin-core-dev
 82 2022-05-17T07:40:11  *** brunoerg <brunoerg!~brunoerg@2804:14d:5281:8ae2:ac98:9665:2456:9ae3> has joined #bitcoin-core-dev
 83 2022-05-17T07:42:04  *** SpellChecker_ <SpellChecker_!~SpellChec@user/SpellChecker> has quit IRC (Ping timeout: 240 seconds)
 84 2022-05-17T07:55:05  *** SpellChecker <SpellChecker!~SpellChec@user/SpellChecker> has joined #bitcoin-core-dev
 85 2022-05-17T07:55:16  *** AaronvanW <AaronvanW!~AaronvanW@user/AaronvanW> has joined #bitcoin-core-dev
 86 2022-05-17T08:10:03  *** Guest1 <Guest1!~Guest1@2601:647:5b80:fef0:7801:415f:db15:1a42> has quit IRC (Quit: Client closed)
 87 2022-05-17T08:37:05  *** jonatack <jonatack!~jonatack@user/jonatack> has quit IRC (Ping timeout: 260 seconds)
 88 2022-05-17T08:38:34  *** bitdex_ <bitdex_!~bitdex@gateway/tor-sasl/bitdex> has quit IRC (Ping timeout: 240 seconds)
 89 2022-05-17T08:39:22  *** bitdex_ <bitdex_!~bitdex@gateway/tor-sasl/bitdex> has joined #bitcoin-core-dev
 90 2022-05-17T08:41:19  *** brunoerg <brunoerg!~brunoerg@2804:14d:5281:8ae2:ac98:9665:2456:9ae3> has quit IRC (Ping timeout: 240 seconds)
 91 2022-05-17T08:48:34  *** bitdex_ <bitdex_!~bitdex@gateway/tor-sasl/bitdex> has quit IRC (Ping timeout: 240 seconds)
 92 2022-05-17T08:48:56  *** bitdex_ <bitdex_!~bitdex@gateway/tor-sasl/bitdex> has joined #bitcoin-core-dev
 93 2022-05-17T08:57:04  *** bitdex_ <bitdex_!~bitdex@gateway/tor-sasl/bitdex> has quit IRC (Ping timeout: 240 seconds)
 94 2022-05-17T08:57:49  <bitcoin-git> [bitcoin] MarcoFalke opened pull request #25153: scripted-diff: Use getIntT over get_int/get_int64 (master...2205-uni-int-🗝) https://github.com/bitcoin/bitcoin/pull/25153
 95 2022-05-17T09:03:21  *** kexkey <kexkey!~kexkey@178.249.214.10> has quit IRC (Ping timeout: 248 seconds)
 96 2022-05-17T09:03:53  *** kexkey <kexkey!~kexkey@178.249.214.10> has joined #bitcoin-core-dev
 97 2022-05-17T09:08:13  *** bitdex_ <bitdex_!~bitdex@gateway/tor-sasl/bitdex> has joined #bitcoin-core-dev
 98 2022-05-17T09:12:48  *** brunoerg <brunoerg!~brunoerg@2804:14d:5281:8ae2:ad2f:65db:12a3:24d0> has joined #bitcoin-core-dev
 99 2022-05-17T09:24:13  *** ___nick___ <___nick___!~quassel@cpc68286-cdif17-2-0-cust533.5-1.cable.virginm.net> has joined #bitcoin-core-dev
100 2022-05-17T10:05:10  <bitcoin-git> [bitcoin] fanquake pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/0be1dc1f56f6...1ab389b1bac1
101 2022-05-17T10:05:10  <bitcoin-git> bitcoin/master c9fdaa5 Sebastian Falbesoner: wallet: CreateTransactionInternal(): return out-params as (optional) struct
102 2022-05-17T10:05:10  <bitcoin-git> bitcoin/master 4c5ceb0 Sebastian Falbesoner: wallet: CreateTransaction(): return out-params as (optional) struct
103 2022-05-17T10:05:11  <bitcoin-git> bitcoin/master 1ab389b fanquake: Merge bitcoin/bitcoin#20640: wallet, refactor: return out-params of Create...
104 2022-05-17T10:05:21  <bitcoin-git> [bitcoin] fanquake merged pull request #20640: wallet, refactor: return out-params of CreateTransaction() as optional struct (master...202012-refactor-wallet-createtransaction-return_out_params_in_optstruct) https://github.com/bitcoin/bitcoin/pull/20640
105 2022-05-17T10:10:52  *** yanmaani1 <yanmaani1!~yanmaani@gateway/tor-sasl/yanmaani> has joined #bitcoin-core-dev
106 2022-05-17T10:14:04  *** yanmaani <yanmaani!~yanmaani@gateway/tor-sasl/yanmaani> has quit IRC (Ping timeout: 240 seconds)
107 2022-05-17T10:15:52  *** brunoerg <brunoerg!~brunoerg@2804:14d:5281:8ae2:ad2f:65db:12a3:24d0> has quit IRC (Ping timeout: 248 seconds)
108 2022-05-17T10:26:50  *** sudoforge <sudoforge!~sudoforge@wireguard/tunneler/sudoforge> has quit IRC (Ping timeout: 240 seconds)
109 2022-05-17T10:29:18  *** yanmaani2 <yanmaani2!~yanmaani@gateway/tor-sasl/yanmaani> has joined #bitcoin-core-dev
110 2022-05-17T10:32:34  *** yanmaani1 <yanmaani1!~yanmaani@gateway/tor-sasl/yanmaani> has quit IRC (Ping timeout: 240 seconds)
111 2022-05-17T10:40:00  *** z9z0b3t1_ <z9z0b3t1_!z9z0b3t1c@gateway/vpn/protonvpn/z9z0b3t1c> has joined #bitcoin-core-dev
112 2022-05-17T10:41:59  *** jonatack <jonatack!~jonatack@user/jonatack> has joined #bitcoin-core-dev
113 2022-05-17T10:42:53  *** z9z0b3t__ <z9z0b3t__!~z9z0b3t1c@145.224.66.171> has joined #bitcoin-core-dev
114 2022-05-17T10:42:56  *** z9z0b3t1c <z9z0b3t1c!z9z0b3t1c@gateway/vpn/protonvpn/z9z0b3t1c> has quit IRC (Ping timeout: 250 seconds)
115 2022-05-17T10:45:11  *** theStack <theStack!~honeybadg@vps1648322.vs.webtropia-customer.com> has joined #bitcoin-core-dev
116 2022-05-17T10:46:03  *** z9z0b3t1_ <z9z0b3t1_!z9z0b3t1c@gateway/vpn/protonvpn/z9z0b3t1c> has quit IRC (Ping timeout: 246 seconds)
117 2022-05-17T10:46:58  *** brunoerg <brunoerg!~brunoerg@2804:14d:5281:8ae2:ad2f:65db:12a3:24d0> has joined #bitcoin-core-dev
118 2022-05-17T10:47:06  <jonatack> david-bakin: i agree, some things can be different coming from companies or other open source projects. if helpful wrote a few articles about it at https://jonatack.github.io/articles, perhaps the most useful one is https://jonatack.github.io/articles/how-to-review-pull-requests-in-bitcoin-core
119 2022-05-17T10:47:55  <jonatack> (i try to keep them up to date, so don't hesitate to LMK if anything isn't)
120 2022-05-17T11:11:51  *** outfox <outfox!~outfox@user/outfox> has joined #bitcoin-core-dev
121 2022-05-17T11:49:33  *** mikehu44 <mikehu44!~quassel@gateway/vpn/pia/mikehu44-jc> has quit IRC (Ping timeout: 276 seconds)
122 2022-05-17T11:51:42  *** brunoerg <brunoerg!~brunoerg@2804:14d:5281:8ae2:ad2f:65db:12a3:24d0> has quit IRC (Ping timeout: 260 seconds)
123 2022-05-17T11:53:13  *** mikehu44 <mikehu44!~quassel@gateway/vpn/pia/mikehu44-jc> has joined #bitcoin-core-dev
124 2022-05-17T12:03:57  *** mikehu44 <mikehu44!~quassel@gateway/vpn/pia/mikehu44-jc> has quit IRC (Ping timeout: 260 seconds)
125 2022-05-17T12:07:32  *** szkl <szkl!uid110435@id-110435.uxbridge.irccloud.com> has quit IRC (Quit: Connection closed for inactivity)
126 2022-05-17T12:12:14  *** mikehu44 <mikehu44!~quassel@gateway/vpn/pia/mikehu44-jc> has joined #bitcoin-core-dev
127 2022-05-17T12:20:50  *** brunoerg <brunoerg!~brunoerg@2804:14d:5281:8ae2:ad2f:65db:12a3:24d0> has joined #bitcoin-core-dev
128 2022-05-17T12:24:04  *** mikehu44 <mikehu44!~quassel@gateway/vpn/pia/mikehu44-jc> has quit IRC (Quit: No Ping reply in 180 seconds.)
129 2022-05-17T12:25:24  *** mikehu44 <mikehu44!~quassel@gateway/vpn/pia/mikehu44-jc> has joined #bitcoin-core-dev
130 2022-05-17T12:25:39  <bitcoin-git> [bitcoin] jonatack opened pull request #25155: GetTimeSeconds() removal followups (master...GetTimeSeconds-removal-followups) https://github.com/bitcoin/bitcoin/pull/25155
131 2022-05-17T12:33:14  *** outfox <outfox!~outfox@user/outfox> has quit IRC (Remote host closed the connection)
132 2022-05-17T12:38:15  *** sipsorcery <sipsorcery!~sipsorcer@37.228.225.67> has joined #bitcoin-core-dev
133 2022-05-17T12:42:08  *** bitdex_ <bitdex_!~bitdex@gateway/tor-sasl/bitdex> has quit IRC (Quit: = "")
134 2022-05-17T13:02:16  *** SpellChecker <SpellChecker!~SpellChec@user/SpellChecker> has quit IRC (Remote host closed the connection)
135 2022-05-17T13:03:00  *** kexkey <kexkey!~kexkey@178.249.214.10> has quit IRC (Ping timeout: 248 seconds)
136 2022-05-17T13:08:38  *** SpellChecker <SpellChecker!~SpellChec@user/SpellChecker> has joined #bitcoin-core-dev
137 2022-05-17T13:19:38  <bitcoin-git> [bitcoin] MarcoFalke opened pull request #25156: Disconnect block-relay-only peers with relay permission when they fill tx announcements (master...2205-block-relay-only-why-tx-inv-🤗) https://github.com/bitcoin/bitcoin/pull/25156
138 2022-05-17T13:27:03  *** mikehu44 <mikehu44!~quassel@gateway/vpn/pia/mikehu44-jc> has quit IRC (Ping timeout: 246 seconds)
139 2022-05-17T13:27:42  *** mikehu44 <mikehu44!~quassel@gateway/vpn/pia/mikehu44-jc> has joined #bitcoin-core-dev
140 2022-05-17T13:37:50  *** jamesob <jamesob!~jamesob@pool-108-31-54-223.washdc.fios.verizon.net> has joined #bitcoin-core-dev
141 2022-05-17T13:39:05  <jamesob> sorry, have been out of IRC for a bit; are we not using designated initializers anymore? https://github.com/bitcoin/bitcoin/pull/25064#issuecomment-1127842628
142 2022-05-17T13:51:29  *** ___nick___ <___nick___!~quassel@cpc68286-cdif17-2-0-cust533.5-1.cable.virginm.net> has quit IRC (Quit: https://quassel-irc.org - Chat comfortably. Anywhere.)
143 2022-05-17T13:52:00  <bitcoin-git> [bitcoin] jonatack closed pull request #25155: GetTimeSeconds() removal followups (master...GetTimeSeconds-removal-followups) https://github.com/bitcoin/bitcoin/pull/25155
144 2022-05-17T13:53:03  <laanwj> i think the conclusion from the last meeting it was discussed was that it's okay to use them because all supported compilers effectively support them, but dunno
145 2022-05-17T13:53:13  *** ___nick___ <___nick___!~quassel@cpc68286-cdif17-2-0-cust533.5-1.cable.virginm.net> has joined #bitcoin-core-dev
146 2022-05-17T13:53:22  *** ___nick___ <___nick___!~quassel@cpc68286-cdif17-2-0-cust533.5-1.cable.virginm.net> has quit IRC (Client Quit)
147 2022-05-17T13:55:06  <jamesob> laanwj: ah okay, thanks
148 2022-05-17T13:55:09  *** ___nick___ <___nick___!~quassel@cpc68286-cdif17-2-0-cust533.5-1.cable.virginm.net> has joined #bitcoin-core-dev
149 2022-05-17T13:55:57  <laanwj> i'd guess someone commented on dongcarl using them
150 2022-05-17T14:00:54  *** sudoforge <sudoforge!~sudoforge@wireguard/tunneler/sudoforge> has joined #bitcoin-core-dev
151 2022-05-17T14:04:33  *** SpellChecker_ <SpellChecker_!~SpellChec@user/SpellChecker> has joined #bitcoin-core-dev
152 2022-05-17T14:06:34  *** SpellChecker <SpellChecker!~SpellChec@user/SpellChecker> has quit IRC (Ping timeout: 240 seconds)
153 2022-05-17T14:16:53  *** z9z0b3t__ <z9z0b3t__!~z9z0b3t1c@145.224.66.171> has quit IRC ()
154 2022-05-17T14:18:23  <laanwj> it's hard enough to get things merged without anything controversial
155 2022-05-17T14:22:34  *** yanmaani2 <yanmaani2!~yanmaani@gateway/tor-sasl/yanmaani> has quit IRC (Ping timeout: 240 seconds)
156 2022-05-17T14:25:18  <bitcoin-git> [bitcoin] jonatack opened pull request #25157: Fix -rpcwait with -netinfo returning negative time durations (master...update-time-in-rpcwait-and-netinfo) https://github.com/bitcoin/bitcoin/pull/25157
157 2022-05-17T14:31:02  <david-bakin> jonatack - thanks! will look at those articles
158 2022-05-17T14:35:52  *** SpellChecker_ <SpellChecker_!~SpellChec@user/SpellChecker> has quit IRC (Quit: bye)
159 2022-05-17T14:38:14  <jamesob> laanwj: haha no kidding
160 2022-05-17T14:40:06  *** ronoaldo <ronoaldo!~ronoaldo@187.56.18.151> has joined #bitcoin-core-dev
161 2022-05-17T14:42:01  <_aj_> jamesob: #24531 -- VS 2019 (which CI uses) doesn't support them, and figuring out how to fix that isn't trivial
162 2022-05-17T14:42:02  <gribble> https://github.com/bitcoin/bitcoin/issues/24531 | Use designated initializers by MarcoFalke · Pull Request #24531 · bitcoin/bitcoin · GitHub
163 2022-05-17T14:45:40  <sipsorcery> _aj_: in fairness VS2019 does seem support them it just seems to want to use a massive amount of memory to compile them...
164 2022-05-17T14:47:09  <_aj_> sipsorcery: doesn't support them with the amount of memory we currently allocate for those CI jobs :-P
165 2022-05-17T14:48:31  <sipsorcery> proof of memory
166 2022-05-17T14:49:16  *** sudoforge <sudoforge!~sudoforge@wireguard/tunneler/sudoforge> has quit IRC (Quit: 404)
167 2022-05-17T14:49:18  <sipa> pom pom pom
168 2022-05-17T14:49:27  <sipa> 🍎
169 2022-05-17T14:50:55  *** sudoforge <sudoforge!~sudoforge@wireguard/tunneler/sudoforge> has joined #bitcoin-core-dev
170 2022-05-17T14:52:10  <_aj_> does being a pom pom expert make sipa a cheerleader?
171 2022-05-17T14:52:14  *** kexkey <kexkey!~kexkey@178.249.214.20> has joined #bitcoin-core-dev
172 2022-05-17T14:52:57  *** SpellChecker <SpellChecker!~SpellChec@user/SpellChecker> has joined #bitcoin-core-dev
173 2022-05-17T14:54:35  <TallTim> > <
174 2022-05-17T14:55:29  *** yanmaani2 <yanmaani2!~yanmaani@gateway/tor-sasl/yanmaani> has joined #bitcoin-core-dev
175 2022-05-17T15:04:34  *** evanlinjin <evanlinjin!~evanlinji@gateway/tor-sasl/evanlinjin> has joined #bitcoin-core-dev
176 2022-05-17T15:08:16  <sipa> i wonder if cheerleaders in France say apple apple.
177 2022-05-17T15:08:45  <sipa> *use
178 2022-05-17T15:11:21  *** mikehu44 <mikehu44!~quassel@gateway/vpn/pia/mikehu44-jc> has quit IRC (Ping timeout: 246 seconds)
179 2022-05-17T15:11:33  <_aj_> french pom's: https://www.navalnews.com/naval-news/2020/01/france-confirms-order-for-six-new-pom-offshore-patrol-vessels/
180 2022-05-17T15:19:27  <bitcoin-git> [bitcoin] fanquake pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/1ab389b1bac1...dd8a2df488f6
181 2022-05-17T15:19:28  <bitcoin-git> bitcoin/master 652b54e laanwj: bench: Add `--sanity-check` flag, use it in `make check`
182 2022-05-17T15:19:28  <bitcoin-git> bitcoin/master 4f31c21 laanwj: bench: Make all arguments -kebab-case
183 2022-05-17T15:19:28  <bitcoin-git> bitcoin/master dd8a2df fanquake: Merge bitcoin/bitcoin#25107: bench: Add `--sanity-check` flag, use it in `...
184 2022-05-17T15:19:38  <bitcoin-git> [bitcoin] fanquake merged pull request #25107: bench: Add `--sanity-check` flag, use it in `make check` (master...2022-05-bench-one-iteration) https://github.com/bitcoin/bitcoin/pull/25107
185 2022-05-17T15:34:05  *** evanlinjin <evanlinjin!~evanlinji@gateway/tor-sasl/evanlinjin> has quit IRC (Remote host closed the connection)
186 2022-05-17T15:39:37  <bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/dd8a2df488f6...d5d40d59f8d1
187 2022-05-17T15:39:37  <bitcoin-git> bitcoin/master ada8358 amadeuszpawlik: Sanitize port in `addpeeraddress()`
188 2022-05-17T15:39:38  <bitcoin-git> bitcoin/master d5d40d5 fanquake: Merge bitcoin/bitcoin#23679: Sanitize `port` in `addpeeraddress()`
189 2022-05-17T15:39:41  <bitcoin-git> [bitcoin] fanquake merged pull request #23679: Sanitize `port` in `addpeeraddress()` (master...sanitize_port_rpc) https://github.com/bitcoin/bitcoin/pull/23679
190 2022-05-17T15:40:07  *** ulrichard <ulrichard!~ulrichard@pub158181114196.dh-hfc.datazug.ch> has joined #bitcoin-core-dev
191 2022-05-17T15:41:37  *** moneyball__ <moneyball__!sid299869@id-299869.helmsley.irccloud.com> has joined #bitcoin-core-dev
192 2022-05-17T15:41:41  *** FelixWeis_ <FelixWeis_!sid154231@id-154231.hampstead.irccloud.com> has joined #bitcoin-core-dev
193 2022-05-17T15:42:10  *** hugohn_ <hugohn_!sid304114@id-304114.lymington.irccloud.com> has joined #bitcoin-core-dev
194 2022-05-17T15:42:11  *** schmidty_ <schmidty_!sid297174@id-297174.lymington.irccloud.com> has joined #bitcoin-core-dev
195 2022-05-17T15:42:14  *** hsmiths_ <hsmiths_!uid95325@id-95325.helmsley.irccloud.com> has joined #bitcoin-core-dev
196 2022-05-17T15:42:25  *** josibake_ <josibake_!sid509132@id-509132.helmsley.irccloud.com> has joined #bitcoin-core-dev
197 2022-05-17T15:42:47  *** Lightsword_ <Lightsword_!~Lightswor@user/lightsword> has joined #bitcoin-core-dev
198 2022-05-17T15:42:54  *** instagibbs_ <instagibbs_!~instagibb@pool-100-15-139-5.washdc.fios.verizon.net> has joined #bitcoin-core-dev
199 2022-05-17T15:43:37  *** pinheadmz_ <pinheadmz_!~pinheadmz@hns-contributor.dev> has joined #bitcoin-core-dev
200 2022-05-17T15:43:54  *** javi404_ <javi404_!~quassel@pool-173-63-15-246.nwrknj.fios.verizon.net> has joined #bitcoin-core-dev
201 2022-05-17T15:43:55  *** takinbo_ <takinbo_!~takinbo@user/takinbo> has joined #bitcoin-core-dev
202 2022-05-17T15:44:24  *** orionwl <orionwl!~laanwj@user/laanwj> has joined #bitcoin-core-dev
203 2022-05-17T15:45:01  *** gwillen1 <gwillen1!gwillen@user/gwillen> has joined #bitcoin-core-dev
204 2022-05-17T15:45:24  *** _aj__ <_aj__!aj@azure.erisian.com.au> has joined #bitcoin-core-dev
205 2022-05-17T15:45:28  *** doppo_ <doppo_!~doppo@2604:180::e0fc:a07f> has joined #bitcoin-core-dev
206 2022-05-17T15:45:32  *** kanzure_ <kanzure_!~kanzure@user/kanzure> has joined #bitcoin-core-dev
207 2022-05-17T15:45:45  *** baakeydo1 <baakeydo1!~baake@2001:41d0:203:b12c::> has joined #bitcoin-core-dev
208 2022-05-17T15:49:16  *** z9z0b3t1c <z9z0b3t1c!z9z0b3t1c@gateway/vpn/protonvpn/z9z0b3t1c> has joined #bitcoin-core-dev
209 2022-05-17T15:49:58  *** BUSY <BUSY!~BUSY@user/busy> has quit IRC (*.net *.split)
210 2022-05-17T15:49:58  *** sipa <sipa!~sipa@user/sipa> has quit IRC (*.net *.split)
211 2022-05-17T15:49:59  *** stijnbtc[m] <stijnbtc[m]!~stijnbtcm@2001:470:69fc:105::1:fec3> has quit IRC (*.net *.split)
212 2022-05-17T15:49:59  *** instagibbs <instagibbs!~instagibb@pool-100-15-139-5.washdc.fios.verizon.net> has quit IRC (*.net *.split)
213 2022-05-17T15:49:59  *** javi404 <javi404!~quassel@pool-173-63-15-246.nwrknj.fios.verizon.net> has quit IRC (*.net *.split)
214 2022-05-17T15:49:59  *** schmidty <schmidty!sid297174@id-297174.lymington.irccloud.com> has quit IRC (*.net *.split)
215 2022-05-17T15:49:59  *** kanzure <kanzure!~kanzure@user/kanzure> has quit IRC (*.net *.split)
216 2022-05-17T15:49:59  *** baldur <baldur!~baldur@pool-74-108-229-157.nycmny.fios.verizon.net> has quit IRC (*.net *.split)
217 2022-05-17T15:49:59  *** doppo <doppo!~doppo@2604:180::e0fc:a07f> has quit IRC (*.net *.split)
218 2022-05-17T15:49:59  *** laanwj <laanwj!~laanwj@user/laanwj> has quit IRC (*.net *.split)
219 2022-05-17T15:49:59  *** takinbo <takinbo!~takinbo@user/takinbo> has quit IRC (*.net *.split)
220 2022-05-17T15:50:00  *** pinheadmz <pinheadmz!~pinheadmz@hns-contributor.dev> has quit IRC (*.net *.split)
221 2022-05-17T15:50:00  *** _aj_ <_aj_!aj@user/aj/x-5857768> has quit IRC (*.net *.split)
222 2022-05-17T15:50:00  *** Lightsword <Lightsword!~Lightswor@user/lightsword> has quit IRC (*.net *.split)
223 2022-05-17T15:50:00  *** hsmiths <hsmiths!uid95325@id-95325.helmsley.irccloud.com> has quit IRC (*.net *.split)
224 2022-05-17T15:50:00  *** josibake <josibake!sid509132@id-509132.helmsley.irccloud.com> has quit IRC (*.net *.split)
225 2022-05-17T15:50:00  *** hugohn <hugohn!sid304114@id-304114.lymington.irccloud.com> has quit IRC (*.net *.split)
226 2022-05-17T15:50:00  *** FelixWeis <FelixWeis!sid154231@2a03:5180:f:4::2:5a77> has quit IRC (*.net *.split)
227 2022-05-17T15:50:00  *** baakeydow <baakeydow!~baake@2001:41d0:203:b12c::> has quit IRC (*.net *.split)
228 2022-05-17T15:50:00  *** moneyball_ <moneyball_!sid299869@2a03:5180:f:1::4:935d> has quit IRC (*.net *.split)
229 2022-05-17T15:50:00  *** gwillen <gwillen!gwillen@user/gwillen> has quit IRC (*.net *.split)
230 2022-05-17T15:50:01  *** hsmiths_ is now known as hsmiths
231 2022-05-17T15:50:01  *** schmidty_ is now known as schmidty
232 2022-05-17T15:50:01  *** Lightsword_ is now known as Lightsword
233 2022-05-17T15:50:01  *** FelixWeis_ is now known as FelixWeis
234 2022-05-17T15:55:42  *** baldur <baldur!~baldur@pool-74-108-229-157.nycmny.fios.verizon.net> has joined #bitcoin-core-dev
235 2022-05-17T15:55:46  <jamesob> _aj_: ah okay, thankks
236 2022-05-17T15:56:53  *** BUSY <BUSY!~BUSY@user/busy> has joined #bitcoin-core-dev
237 2022-05-17T15:57:52  *** stijnbtc[m] <stijnbtc[m]!~stijnbtcm@2001:470:69fc:105::1:fec3> has joined #bitcoin-core-dev
238 2022-05-17T16:01:01  *** evanlinjin <evanlinjin!~evanlinji@gateway/tor-sasl/evanlinjin> has joined #bitcoin-core-dev
239 2022-05-17T16:03:24  *** sipa <sipa!~sipa@user/sipa> has joined #bitcoin-core-dev
240 2022-05-17T16:14:50  <bitcoin-git> [bitcoin] brunoerg opened pull request #25158: rpc, wallet: add abandoned field for all categories of transaction in ListTransaction (master...2022-05-abandoned-listtransactions) https://github.com/bitcoin/bitcoin/pull/25158
241 2022-05-17T16:15:24  *** z9z0b3t1c <z9z0b3t1c!z9z0b3t1c@gateway/vpn/protonvpn/z9z0b3t1c> has quit IRC (Ping timeout: 246 seconds)
242 2022-05-17T16:30:22  *** salvatoshi <salvatoshi!~salvatosh@genymobile-2-6-86.fib.nerim.net> has quit IRC (Ping timeout: 272 seconds)
243 2022-05-17T16:35:04  *** jonatack <jonatack!~jonatack@user/jonatack> has quit IRC (Ping timeout: 248 seconds)
244 2022-05-17T16:47:59  *** SpellChecker_ <SpellChecker_!~SpellChec@user/SpellChecker> has joined #bitcoin-core-dev
245 2022-05-17T16:49:04  *** SpellChecker <SpellChecker!~SpellChec@user/SpellChecker> has quit IRC (Ping timeout: 240 seconds)
246 2022-05-17T16:49:32  *** jonatack <jonatack!~jonatack@user/jonatack> has joined #bitcoin-core-dev
247 2022-05-17T16:50:37  *** z9z0b3t1c <z9z0b3t1c!z9z0b3t1c@gateway/vpn/protonvpn/z9z0b3t1c> has joined #bitcoin-core-dev
248 2022-05-17T16:54:46  <dongcarl> Nah no one commented on my using them, but I just wanted to get this PR through without waiting on #24531. Likely will need something like #24531 for later PRs that add a bunch of members to these Options structs tho
249 2022-05-17T16:54:47  <gribble> https://github.com/bitcoin/bitcoin/issues/24531 | Use designated initializers by MarcoFalke · Pull Request #24531 · bitcoin/bitcoin · GitHub
250 2022-05-17T16:54:48  <gribble> https://github.com/bitcoin/bitcoin/issues/24531 | Use designated initializers by MarcoFalke · Pull Request #24531 · bitcoin/bitcoin · GitHub
251 2022-05-17T16:54:54  <dongcarl> jamesob: ^
252 2022-05-17T16:57:34  *** bomb-on <bomb-on!~bomb-on@user/bomb-on> has joined #bitcoin-core-dev
253 2022-05-17T16:58:32  <jamesob> dongcarl: gotcha, thanks
254 2022-05-17T17:00:05  <_aj__> dongcarl: if you make a function to do the construction, you can use clang-tidy's bugprone-argument-comment to check you're initializing what you think you are
255 2022-05-17T17:02:25  *** _aj__ is now known as _aj_
256 2022-05-17T17:02:32  <dongcarl> _aj__: Right... If we don't get anywhere with the designated initializers support I might just do that... Thinking of it, there might be cases where having a constructor is nicer since you can have some logic in there... Will have a think
257 2022-05-17T17:03:27  <_aj_> dongcarl: seems worth doing in the meantime to me, still inconvenient compared to designated initializers
258 2022-05-17T17:03:46  <_aj_> dongcarl: (but works for functions not just structs, so prob still useful even with them)
259 2022-05-17T17:07:27  <david-bakin> I like the naming of those "bugprone" arguments.  I wish compiler messages used that as a tag for certain warnings.  In fact, compiler warnings should all have tags like "bugprone", "undef behavior",
260 2022-05-17T17:07:35  <david-bakin> "impl-defined behavior", etc.
261 2022-05-17T17:15:13  *** Talkless <Talkless!~Talkless@mail.dargis.net> has joined #bitcoin-core-dev
262 2022-05-17T17:15:21  *** Guest55 <Guest55!~Guest55@179.13.153.121> has joined #bitcoin-core-dev
263 2022-05-17T17:15:43  *** kanzure_ is now known as kanzure
264 2022-05-17T17:16:45  *** Guest55 <Guest55!~Guest55@179.13.153.121> has quit IRC (Client Quit)
265 2022-05-17T17:23:30  *** sipsorcery <sipsorcery!~sipsorcer@37.228.225.67> has quit IRC (Ping timeout: 240 seconds)
266 2022-05-17T17:28:19  *** outfox <outfox!~outfox@user/outfox> has joined #bitcoin-core-dev
267 2022-05-17T17:39:35  *** sipsorcery <sipsorcery!~sipsorcer@37.228.225.67> has joined #bitcoin-core-dev
268 2022-05-17T17:46:02  *** theStack <theStack!~honeybadg@vps1648322.vs.webtropia-customer.com> has quit IRC (Remote host closed the connection)
269 2022-05-17T17:52:17  *** kexkey <kexkey!~kexkey@178.249.214.20> has quit IRC (Ping timeout: 252 seconds)
270 2022-05-17T17:52:26  <bitcoin-git> [bitcoin] ishaanam opened pull request #25159: test: use `sendall` in wallet_taproot.py tests (master...wallet_taproot_sendall_fix) https://github.com/bitcoin/bitcoin/pull/25159
271 2022-05-17T17:53:34  *** evanlinjin <evanlinjin!~evanlinji@gateway/tor-sasl/evanlinjin> has quit IRC (Ping timeout: 240 seconds)
272 2022-05-17T17:56:20  *** kexkey <kexkey!~kexkey@static-198-54-132-151.cust.tzulo.com> has joined #bitcoin-core-dev
273 2022-05-17T18:33:35  <achow101> luke-jr: do you only see the segfaul with bitcoin-qt? and can you get it reliably?
274 2022-05-17T18:33:42  <achow101> it doesn't always segfault for me, just sometimes
275 2022-05-17T18:34:11  <achow101> and never in gdb
276 2022-05-17T18:36:45  *** Kaizen_Kintsugi_ <Kaizen_Kintsugi_!~Kaizen_Ki@2600:8802:3806:c200:1523:3230:ccb1:c50b> has joined #bitcoin-core-dev
277 2022-05-17T18:44:09  *** bomb-on <bomb-on!~bomb-on@user/bomb-on> has quit IRC (Quit: aллилѹіа!)
278 2022-05-17T18:49:43  *** Kaizen_Kintsugi_ <Kaizen_Kintsugi_!~Kaizen_Ki@2600:8802:3806:c200:1523:3230:ccb1:c50b> has quit IRC (Remote host closed the connection)
279 2022-05-17T18:52:28  *** Kaizen_Kintsugi_ <Kaizen_Kintsugi_!~Kaizen_Ki@2600:8802:3806:c200:1523:3230:ccb1:c50b> has joined #bitcoin-core-dev
280 2022-05-17T19:07:02  <bitcoin-git> [bitcoin] hebasto opened pull request #25160: ci: Add "macOS 12 native Apple Silicon" task (master...220517-ci) https://github.com/bitcoin/bitcoin/pull/25160
281 2022-05-17T19:13:42  *** evanlinjin <evanlinjin!~evanlinji@gateway/tor-sasl/evanlinjin> has joined #bitcoin-core-dev
282 2022-05-17T19:13:58  *** bomb-on <bomb-on!~bomb-on@user/bomb-on> has joined #bitcoin-core-dev
283 2022-05-17T19:16:59  *** dviola <dviola!~diego@user/dviola> has quit IRC (Ping timeout: 252 seconds)
284 2022-05-17T19:17:13  *** Nekorand <Nekorand!~Random@cm-188-171-200-176.telecable.es> has joined #bitcoin-core-dev
285 2022-05-17T19:17:27  *** Talkless <Talkless!~Talkless@mail.dargis.net> has quit IRC (Quit: Konversation terminated!)
286 2022-05-17T19:18:33  *** dviola <dviola!~diego@189.35.230.120> has joined #bitcoin-core-dev
287 2022-05-17T19:21:08  *** Guyver2 <Guyver2!~Guyver@77-174-98-73.fixed.kpn.net> has joined #bitcoin-core-dev
288 2022-05-17T19:29:15  <luke-jr> achow101: every time, yes
289 2022-05-17T19:29:26  <luke-jr> I didn't try bitcoind tho
290 2022-05-17T19:30:43  *** Brad <Brad!~Brad@d-206-53-78-122.ct.cpe.atlanticbb.net> has joined #bitcoin-core-dev
291 2022-05-17T19:31:50  *** Brad <Brad!~Brad@d-206-53-78-122.ct.cpe.atlanticbb.net> has quit IRC (Client Quit)
292 2022-05-17T19:34:22  <luke-jr> achow101: maybe it's reliable for me because of UBSan?
293 2022-05-17T19:34:30  <achow101> oh, could be
294 2022-05-17T19:34:34  <achow101> lemme try that
295 2022-05-17T19:36:02  *** kexkey <kexkey!~kexkey@static-198-54-132-151.cust.tzulo.com> has quit IRC (Quit: kexkey)
296 2022-05-17T19:37:21  *** kexkey <kexkey!~kexkey@static-198-54-132-151.cust.tzulo.com> has joined #bitcoin-core-dev
297 2022-05-17T19:37:41  *** Kaizen_Kintsugi_ <Kaizen_Kintsugi_!~Kaizen_Ki@2600:8802:3806:c200:1523:3230:ccb1:c50b> has quit IRC (Remote host closed the connection)
298 2022-05-17T19:39:12  *** kexkey <kexkey!~kexkey@static-198-54-132-151.cust.tzulo.com> has quit IRC (Client Quit)
299 2022-05-17T19:45:23  *** kexkey <kexkey!~kexkey@static-198-54-132-151.cust.tzulo.com> has joined #bitcoin-core-dev
300 2022-05-17T19:45:50  <achow101> luke-jr: can you bisect for the commit that introduced the problem?
301 2022-05-17T19:47:42  <luke-jr> k
302 2022-05-17T19:47:48  <luke-jr> confirmed bitcoind is not affected FWIW
303 2022-05-17T19:48:47  <luke-jr> curiously, bitcoind errors out MUCH faster than -qt :o
304 2022-05-17T19:51:15  <achow101> the backtrace you posted seems like maybe it's a problem with InitError and not specifically an unsupported wallet types problem
305 2022-05-17T19:51:50  <luke-jr> possibly, though I got the impression it was trying to cleanup a wallet that wasn't loaded
306 2022-05-17T19:52:41  <luke-jr> unrelated: randomly getting `QVariant::load: unknown user type with name BitcoinUnits::Unit.` - is this fixed recently, or should I open an issue?
307 2022-05-17T19:52:49  <luke-jr> bleh, branch-23 has the segfault too
308 2022-05-17T19:55:03  *** Kaizen_Kintsugi_ <Kaizen_Kintsugi_!~Kaizen_Ki@2600:8802:3806:c200:1523:3230:ccb1:c50b> has joined #bitcoin-core-dev
309 2022-05-17T19:55:04  *** evanlinjin <evanlinjin!~evanlinji@gateway/tor-sasl/evanlinjin> has quit IRC (Ping timeout: 240 seconds)
310 2022-05-17T19:55:42  <achow101> i've not seen that error before
311 2022-05-17T19:57:45  <luke-jr> when I tried to debug it earlier, it disappeared on me :|
312 2022-05-17T19:59:46  <sipa> Ah, a Heisenbug.
313 2022-05-17T20:05:04  *** ___nick___ <___nick___!~quassel@cpc68286-cdif17-2-0-cust533.5-1.cable.virginm.net> has quit IRC (Ping timeout: 272 seconds)
314 2022-05-17T20:16:42  <luke-jr> oh, I guess Core never merged the dbus timeout fix  - that's probably why -qt is slower
315 2022-05-17T20:17:33  *** midnight_ is now known as midnight
316 2022-05-17T20:17:37  <luke-jr> https://github.com/bitcoin-core/gui/pull/152
317 2022-05-17T20:19:14  <hebasto> luke-jr: it is not obvious that bug exist, in first place -- https://github.com/bitcoin-core/gui/pull/152#issuecomment-757524350
318 2022-05-17T20:19:33  <luke-jr> hebasto: it definitely exists
319 2022-05-17T20:19:51  <hebasto> how to reproduce it reliably?
320 2022-05-17T20:19:59  <luke-jr> idk, happens every time for me
321 2022-05-17T20:21:20  <luke-jr> maybe running bitcoin-qt as another user?
322 2022-05-17T20:22:16  <hebasto> ok, could you describe your steps and observations in your PR?
323 2022-05-17T20:23:31  <luke-jr> there's no steps, it just happens
324 2022-05-17T20:26:26  *** Nekorand <Nekorand!~Random@cm-188-171-200-176.telecable.es> has quit IRC (Quit: Leaving)
325 2022-05-17T20:26:32  <hebasto> at least, you could mention your system on which "org.freedesktop.Notifications is missing"
326 2022-05-17T20:29:12  <achow101> luke-jr: can't get it to segfault at all when ubsan is enabled
327 2022-05-17T20:35:34  <luke-jr> achow101: weird, still bisecting
328 2022-05-17T20:37:57  *** z9z0b3t1_ <z9z0b3t1_!z9z0b3t1c@gateway/vpn/protonvpn/z9z0b3t1c> has joined #bitcoin-core-dev
329 2022-05-17T20:38:00  <luke-jr> Bisecting: 10 revisions left to test after this (roughly 4 steps)
330 2022-05-17T20:41:22  *** z9z0b3t1c <z9z0b3t1c!z9z0b3t1c@gateway/vpn/protonvpn/z9z0b3t1c> has quit IRC (Ping timeout: 250 seconds)
331 2022-05-17T20:46:27  *** kexkey <kexkey!~kexkey@static-198-54-132-151.cust.tzulo.com> has quit IRC (Ping timeout: 276 seconds)
332 2022-05-17T20:49:51  <luke-jr> achow101: a749fa539ae4330dd5d610286f418156e080e9dd is the first bad commit
333 2022-05-17T20:49:54  <luke-jr> achow101: I think it's wrong :/
334 2022-05-17T20:50:04  <luke-jr> as I got closer, it seemed intermittent, so I may need to re-bisect
335 2022-05-17T20:50:14  <achow101> yeah.. that looks wrong
336 2022-05-17T20:51:42  *** Guest61 <Guest61!~Guest61@2a01:c22:b99d:f000:8c30:918b:3ca3:f9b2> has joined #bitcoin-core-dev
337 2022-05-17T20:52:31  *** Guest61 <Guest61!~Guest61@2a01:c22:b99d:f000:8c30:918b:3ca3:f9b2> has quit IRC (Client Quit)
338 2022-05-17T20:54:14  * luke-jr adds --without-qtdbus to configure so this hopefully goes faster this time
339 2022-05-17T20:54:58  <achow101> I changed to using clang and it seems to be happening consistently now
340 2022-05-17T20:57:32  <luke-jr> aha, yes, I am building with clang
341 2022-05-17T20:57:55  <luke-jr> always weird when GCC/Clang produces a bug the other doesn't >_<
342 2022-05-17T20:58:24  <sipa> Welcome to the wonderful world of undefined behavior.
343 2022-05-17T20:58:57  <luke-jr> XD
344 2022-05-17T20:59:06  <achow101> if you comment out https://github.com/bitcoin/bitcoin/blob/master/src/qt/splashscreen.cpp#L205, does it still segfault?
345 2022-05-17T20:59:34  <achow101> also, can't get the segfault if I configure with --enable-debug
346 2022-05-17T20:59:41  <achow101> so this smells like a compiler bug :/
347 2022-05-17T20:59:59  <sipa> Not necessarily.
348 2022-05-17T21:00:43  <luke-jr> ./configure CXX=clang++ CC=clang 'LDFLAGS=-O1 -fsanitize=undefined' 'CXXFLAGS=-Wthread-safety-analysis -DDEBUG_LOCKORDER -O1 -ggdb -Wall -Werror=thread-safety-analysis -fsanitize=undefined' 'CFLAGS=-O1 -ggdb -Wall -Werror=thread-safety-analysis -fsanitize=undefined' --with-system-leveldb --with-gui=qt5 --with-tests --with-bench --enable-util-tx --with-miniupnpc --with-system-libsecp256k1 --prefix=/tmp/iitest --without-sqlite  --without-qtdbus
349 2022-05-17T21:00:45  <luke-jr> is what I'm using
350 2022-05-17T21:02:26  <luke-jr> (obviously the --with-system-* are noops on Core commits)
351 2022-05-17T21:09:33  *** Guyver2 <Guyver2!~Guyver@77-174-98-73.fixed.kpn.net> has quit IRC (Quit: Going offline, see ya! (www.adiirc.com))
352 2022-05-17T21:15:23  *** ulrichard <ulrichard!~ulrichard@pub158181114196.dh-hfc.datazug.ch> has quit IRC (Remote host closed the connection)
353 2022-05-17T21:20:22  *** Kaizen_Kintsugi_ <Kaizen_Kintsugi_!~Kaizen_Ki@2600:8802:3806:c200:1523:3230:ccb1:c50b> has quit IRC (Remote host closed the connection)
354 2022-05-17T21:26:43  <luke-jr> f3a17bbe5f7d23b6ecc20e363920492b50859dad is the first bad commit; qt: Do not exit and re-enter main event loop during shutdown
355 2022-05-17T21:26:45  *** sipsorcery <sipsorcery!~sipsorcer@37.228.225.67> has quit IRC (Ping timeout: 276 seconds)
356 2022-05-17T21:31:22  <luke-jr> achow101: no, commenting that line doesn't fix it
357 2022-05-17T21:34:38  *** Kaizen_Kintsugi_ <Kaizen_Kintsugi_!~Kaizen_Ki@ip72-194-104-106.oc.oc.cox.net> has joined #bitcoin-core-dev
358 2022-05-17T21:35:43  *** Kaizen_Kintsugi_ <Kaizen_Kintsugi_!~Kaizen_Ki@ip72-194-104-106.oc.oc.cox.net> has quit IRC (Remote host closed the connection)
359 2022-05-17T21:35:59  *** Kaizen_Kintsugi_ <Kaizen_Kintsugi_!~Kaizen_Ki@2600:8802:3806:c200:1523:3230:ccb1:c50b> has joined #bitcoin-core-dev
360 2022-05-17T21:36:46  *** Kaizen_Kintsugi_ <Kaizen_Kintsugi_!~Kaizen_Ki@2600:8802:3806:c200:1523:3230:ccb1:c50b> has quit IRC (Remote host closed the connection)
361 2022-05-17T21:37:27  *** Kaizen_Kintsugi_ <Kaizen_Kintsugi_!~Kaizen_Ki@2600:8802:3806:c200:1523:3230:ccb1:c50b> has joined #bitcoin-core-dev
362 2022-05-17T21:39:01  <achow101> I think maybe the problem is that the splash screen cleans itself up after the node's walletcontext is cleaned up and that results in a wallet cleanup function callback accessing something that's already gone?
363 2022-05-17T21:39:36  <achow101> It's definitely segfaulting on the context.wallet_load_fns.erase(it) in HandleLoadWallet in src/wallet/wallet.cpp
364 2022-05-17T21:40:14  <achow101> and this function is called when SplashScreen's m_handler_load_wallet is being deleted when SplashScreen is deleted
365 2022-05-17T21:42:15  *** Kaizen_Kintsugi_ <Kaizen_Kintsugi_!~Kaizen_Ki@2600:8802:3806:c200:1523:3230:ccb1:c50b> has quit IRC (Ping timeout: 260 seconds)
366 2022-05-17T21:49:18  <bitcoin-git> [bitcoin] suhailsaqan opened pull request #25161: rpc: Put undocumented JSON failure mode behind a runtime flag (master...master) https://github.com/bitcoin/bitcoin/pull/25161
367 2022-05-17T21:49:35  <luke-jr> achow101: gotta run for a bit, but I reduced the revert to http://dpaste.com/HQBQY5FGH which "fixes" the crash
368 2022-05-17T21:56:41  *** Kaizen_Kintsugi_ <Kaizen_Kintsugi_!~Kaizen_Ki@2600:8802:3806:c200:1523:3230:ccb1:c50b> has joined #bitcoin-core-dev
369 2022-05-17T22:17:49  *** sipsorcery <sipsorcery!~sipsorcer@37.228.225.67> has joined #bitcoin-core-dev
370 2022-05-17T22:29:23  *** jarthur_ <jarthur_!~jarthur@user/jarthur> has quit IRC (Quit: jarthur_)
371 2022-05-17T22:39:58  *** bitdex <bitdex!~bitdex@gateway/tor-sasl/bitdex> has joined #bitcoin-core-dev
372 2022-05-17T22:52:37  *** sipsorcery <sipsorcery!~sipsorcer@37.228.225.67> has quit IRC (Ping timeout: 260 seconds)
373 2022-05-17T22:59:11  *** Zenton <Zenton!~user@user/zenton> has quit IRC (Ping timeout: 252 seconds)
374 2022-05-17T23:40:22  *** brunoerg <brunoerg!~brunoerg@2804:14d:5281:8ae2:ad2f:65db:12a3:24d0> has quit IRC (Remote host closed the connection)
375 2022-05-17T23:52:14  <bitcoin-git> [bitcoin] achow101 pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/d5d40d59f8d1...f7a1e676d536
376 2022-05-17T23:52:14  <bitcoin-git> bitcoin/master c6122f5 ishaanam: test: use sendall in wallet_taproot.py tests
377 2022-05-17T23:52:15  <bitcoin-git> bitcoin/master f7a1e67 Andrew Chow: Merge bitcoin/bitcoin#25159: test: use `sendall` in wallet_taproot.py tests
378 2022-05-17T23:52:15  <bitcoin-git> [bitcoin] achow101 merged pull request #25159: test: use `sendall` in wallet_taproot.py tests (master...wallet_taproot_sendall_fix) https://github.com/bitcoin/bitcoin/pull/25159
379 2022-05-17T23:54:27  *** javi404_ is now known as javi404
380 2022-05-17T23:56:26  *** brunoerg <brunoerg!~brunoerg@2804:14d:5281:8ae2:ad2f:65db:12a3:24d0> has joined #bitcoin-core-dev