1 2022-05-20T00:08:22  *** brunoerg <brunoerg!~brunoerg@2804:14d:5281:8ae2:253d:46d1:6253:dc0c> has joined #bitcoin-core-dev
  2 2022-05-20T00:12:40  *** brunoerg <brunoerg!~brunoerg@2804:14d:5281:8ae2:253d:46d1:6253:dc0c> has quit IRC (Ping timeout: 260 seconds)
  3 2022-05-20T00:12:40  *** NorrinRadd <NorrinRadd!~username@154.6.21.39> has quit IRC (Quit: My MacBook has gone to sleep. ZZZzzz…)
  4 2022-05-20T00:28:36  *** bomb-on <bomb-on!~bomb-on@user/bomb-on> has quit IRC (Quit: aллилѹіа!)
  5 2022-05-20T00:41:09  *** brunoerg <brunoerg!~brunoerg@2804:14d:5281:8ae2:20cc:2e05:bb48:c8dd> has joined #bitcoin-core-dev
  6 2022-05-20T00:45:42  *** brunoerg <brunoerg!~brunoerg@2804:14d:5281:8ae2:20cc:2e05:bb48:c8dd> has quit IRC (Ping timeout: 260 seconds)
  7 2022-05-20T00:47:19  *** brunoerg <brunoerg!~brunoerg@187.183.43.40> has joined #bitcoin-core-dev
  8 2022-05-20T00:50:12  *** bytes1440000 <bytes1440000!~bytes1440@garza.riseup.net> has joined #bitcoin-core-dev
  9 2022-05-20T00:50:44  <bytes1440000> I wish github had advanced search filters to find pull requests merged by someone with some NACKs in reviews.
 10 2022-05-20T00:50:49  <bytes1440000> Tried this: is:pr is:merged involves:fanquake NACK in:comment
 11 2022-05-20T00:50:59  <bytes1440000> But it has lot of false positives.
 12 2022-05-20T00:51:30  *** brunoerg <brunoerg!~brunoerg@187.183.43.40> has quit IRC (Ping timeout: 240 seconds)
 13 2022-05-20T00:53:14  *** Kaizen___ <Kaizen___!Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745> has quit IRC (Remote host closed the connection)
 14 2022-05-20T01:05:11  *** brunoerg <brunoerg!~brunoerg@2804:14d:5281:8ae2:20cc:2e05:bb48:c8dd> has joined #bitcoin-core-dev
 15 2022-05-20T01:09:37  *** brunoerg <brunoerg!~brunoerg@2804:14d:5281:8ae2:20cc:2e05:bb48:c8dd> has quit IRC (Ping timeout: 260 seconds)
 16 2022-05-20T01:10:11  *** bytes1440000 <bytes1440000!~bytes1440@garza.riseup.net> has left #bitcoin-core-dev
 17 2022-05-20T01:14:32  *** Earnestly <Earnestly!~earnest@user/earnestly> has quit IRC (Ping timeout: 272 seconds)
 18 2022-05-20T01:31:02  *** z9z0b3t1c <z9z0b3t1c!z9z0b3t1c@gateway/vpn/protonvpn/z9z0b3t1c> has joined #bitcoin-core-dev
 19 2022-05-20T01:31:39  *** Kaizen_Kintsugi_ <Kaizen_Kintsugi_!Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745> has joined #bitcoin-core-dev
 20 2022-05-20T01:32:56  *** z9z0b3t1_ <z9z0b3t1_!z9z0b3t1c@gateway/vpn/protonvpn/z9z0b3t1c> has quit IRC (Ping timeout: 250 seconds)
 21 2022-05-20T01:33:08  *** brunoerg <brunoerg!~brunoerg@2804:14d:5281:8ae2:20cc:2e05:bb48:c8dd> has joined #bitcoin-core-dev
 22 2022-05-20T01:35:33  *** hashfunc1204 <hashfunc1204!~user@2601:5c0:c280:7090:6cc7:34d7:ac5c:899e> has joined #bitcoin-core-dev
 23 2022-05-20T01:36:27  *** Kaizen_Kintsugi_ <Kaizen_Kintsugi_!Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745> has quit IRC (Ping timeout: 260 seconds)
 24 2022-05-20T01:37:50  *** brunoerg <brunoerg!~brunoerg@2804:14d:5281:8ae2:20cc:2e05:bb48:c8dd> has quit IRC (Ping timeout: 260 seconds)
 25 2022-05-20T01:38:25  *** Kaizen_Kintsugi_ <Kaizen_Kintsugi_!Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745> has joined #bitcoin-core-dev
 26 2022-05-20T01:44:43  *** Kaizen_Kintsugi_ <Kaizen_Kintsugi_!Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745> has quit IRC (Ping timeout: 244 seconds)
 27 2022-05-20T01:50:47  *** bitdex <bitdex!~bitdex@gateway/tor-sasl/bitdex> has joined #bitcoin-core-dev
 28 2022-05-20T02:00:58  *** brunoerg <brunoerg!~brunoerg@187.183.43.40> has joined #bitcoin-core-dev
 29 2022-05-20T02:05:45  *** brunoerg <brunoerg!~brunoerg@187.183.43.40> has quit IRC (Ping timeout: 276 seconds)
 30 2022-05-20T02:06:13  *** brunoerg <brunoerg!~brunoerg@2804:14d:5281:8ae2:20cc:2e05:bb48:c8dd> has joined #bitcoin-core-dev
 31 2022-05-20T02:10:44  *** brunoerg <brunoerg!~brunoerg@2804:14d:5281:8ae2:20cc:2e05:bb48:c8dd> has quit IRC (Ping timeout: 248 seconds)
 32 2022-05-20T02:17:00  *** brunoerg <brunoerg!~brunoerg@2804:14d:5281:8ae2:20cc:2e05:bb48:c8dd> has joined #bitcoin-core-dev
 33 2022-05-20T02:21:22  *** brunoerg <brunoerg!~brunoerg@2804:14d:5281:8ae2:20cc:2e05:bb48:c8dd> has quit IRC (Ping timeout: 260 seconds)
 34 2022-05-20T02:23:10  *** brunoerg <brunoerg!~brunoerg@187.183.43.40> has joined #bitcoin-core-dev
 35 2022-05-20T02:27:21  *** brunoerg <brunoerg!~brunoerg@187.183.43.40> has quit IRC (Ping timeout: 246 seconds)
 36 2022-05-20T02:32:15  *** realies <realies!~realies@user/realies> has quit IRC (Ping timeout: 246 seconds)
 37 2022-05-20T02:33:57  *** brunoerg <brunoerg!~brunoerg@2804:14d:5281:8ae2:20cc:2e05:bb48:c8dd> has joined #bitcoin-core-dev
 38 2022-05-20T02:35:45  *** realies <realies!~realies@user/realies> has joined #bitcoin-core-dev
 39 2022-05-20T02:38:52  *** brunoerg <brunoerg!~brunoerg@2804:14d:5281:8ae2:20cc:2e05:bb48:c8dd> has quit IRC (Ping timeout: 260 seconds)
 40 2022-05-20T02:44:50  *** brunoerg <brunoerg!~brunoerg@187.183.43.40> has joined #bitcoin-core-dev
 41 2022-05-20T02:46:55  *** z9z0b3t1_ <z9z0b3t1_!z9z0b3t1c@gateway/vpn/protonvpn/z9z0b3t1c> has joined #bitcoin-core-dev
 42 2022-05-20T02:49:22  *** brunoerg <brunoerg!~brunoerg@187.183.43.40> has quit IRC (Ping timeout: 260 seconds)
 43 2022-05-20T02:49:31  *** z9z0b3t1c <z9z0b3t1c!z9z0b3t1c@gateway/vpn/protonvpn/z9z0b3t1c> has quit IRC (Ping timeout: 256 seconds)
 44 2022-05-20T02:50:54  *** brunoerg <brunoerg!~brunoerg@2804:14d:5281:8ae2:20cc:2e05:bb48:c8dd> has joined #bitcoin-core-dev
 45 2022-05-20T02:55:47  *** brunoerg <brunoerg!~brunoerg@2804:14d:5281:8ae2:20cc:2e05:bb48:c8dd> has quit IRC (Ping timeout: 260 seconds)
 46 2022-05-20T02:56:14  *** brunoerg <brunoerg!~brunoerg@2804:14d:5281:8ae2:20cc:2e05:bb48:c8dd> has joined #bitcoin-core-dev
 47 2022-05-20T03:00:40  *** brunoerg <brunoerg!~brunoerg@2804:14d:5281:8ae2:20cc:2e05:bb48:c8dd> has quit IRC (Ping timeout: 244 seconds)
 48 2022-05-20T03:07:02  *** brunoerg <brunoerg!~brunoerg@2804:14d:5281:8ae2:20cc:2e05:bb48:c8dd> has joined #bitcoin-core-dev
 49 2022-05-20T03:11:42  *** brunoerg <brunoerg!~brunoerg@2804:14d:5281:8ae2:20cc:2e05:bb48:c8dd> has quit IRC (Ping timeout: 272 seconds)
 50 2022-05-20T03:13:07  *** brunoerg <brunoerg!~brunoerg@2804:14d:5281:8ae2:253d:46d1:6253:dc0c> has joined #bitcoin-core-dev
 51 2022-05-20T03:17:19  *** brunoerg <brunoerg!~brunoerg@2804:14d:5281:8ae2:253d:46d1:6253:dc0c> has quit IRC (Ping timeout: 240 seconds)
 52 2022-05-20T03:23:53  *** brunoerg <brunoerg!~brunoerg@2804:14d:5281:8ae2:20cc:2e05:bb48:c8dd> has joined #bitcoin-core-dev
 53 2022-05-20T03:28:03  *** brunoerg <brunoerg!~brunoerg@2804:14d:5281:8ae2:20cc:2e05:bb48:c8dd> has quit IRC (Ping timeout: 244 seconds)
 54 2022-05-20T03:29:59  *** brunoerg <brunoerg!~brunoerg@2804:14d:5281:8ae2:20cc:2e05:bb48:c8dd> has joined #bitcoin-core-dev
 55 2022-05-20T03:34:19  *** brunoerg <brunoerg!~brunoerg@2804:14d:5281:8ae2:20cc:2e05:bb48:c8dd> has quit IRC (Ping timeout: 240 seconds)
 56 2022-05-20T03:58:37  *** szkl <szkl!uid110435@id-110435.uxbridge.irccloud.com> has joined #bitcoin-core-dev
 57 2022-05-20T04:01:01  *** cmirror <cmirror!~cmirror@4.53.92.114> has quit IRC (Remote host closed the connection)
 58 2022-05-20T04:01:32  *** cmirror <cmirror!~cmirror@4.53.92.114> has joined #bitcoin-core-dev
 59 2022-05-20T04:02:53  *** brunoerg <brunoerg!~brunoerg@187.183.43.40> has joined #bitcoin-core-dev
 60 2022-05-20T04:07:06  *** brunoerg <brunoerg!~brunoerg@187.183.43.40> has quit IRC (Ping timeout: 246 seconds)
 61 2022-05-20T04:08:46  *** mikehu44 <mikehu44!~quassel@gateway/vpn/pia/mikehu44-jc> has joined #bitcoin-core-dev
 62 2022-05-20T04:13:40  *** brunoerg <brunoerg!~brunoerg@2804:14d:5281:8ae2:20cc:2e05:bb48:c8dd> has joined #bitcoin-core-dev
 63 2022-05-20T04:15:20  *** Kaizen_Kintsugi_ <Kaizen_Kintsugi_!Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745> has joined #bitcoin-core-dev
 64 2022-05-20T04:18:02  *** brunoerg <brunoerg!~brunoerg@2804:14d:5281:8ae2:20cc:2e05:bb48:c8dd> has quit IRC (Ping timeout: 260 seconds)
 65 2022-05-20T04:19:45  *** brunoerg <brunoerg!~brunoerg@2804:14d:5281:8ae2:20cc:2e05:bb48:c8dd> has joined #bitcoin-core-dev
 66 2022-05-20T04:21:53  <david-bakin> I just got a linker error from `ld`which ld
 67 2022-05-20T04:22:03  <david-bakin> oops
 68 2022-05-20T04:23:54  *** Kaizen_Kintsugi_ <Kaizen_Kintsugi_!Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745> has quit IRC (Ping timeout: 246 seconds)
 69 2022-05-20T04:24:32  *** brunoerg <brunoerg!~brunoerg@2804:14d:5281:8ae2:20cc:2e05:bb48:c8dd> has quit IRC (Ping timeout: 272 seconds)
 70 2022-05-20T04:24:57  <david-bakin> I just got a linker error from `ld`: "DWARF error: invalid or unhandled FORM value: 0x25" - now, web search tells me this happens when clang's using dwarf v5 and some tool isn't set up for it.  I see in 00_setup_env_native_valgrind.h that they had this problem with valgrind so they set `CXXFLAGS=-fdebug-default-version=4` to get around this.  BUT!
 71 2022-05-20T04:25:34  <david-bakin> 1) if I pass that to configure then all the _other_ CXXFLAGS are overridden - none show up.  So how do I set configure to ADD this to the CXXFLAGS?
 72 2022-05-20T04:26:13  <david-bakin> and 2) should I be doing this anyway?  If I go through with this in this PR won't it change everyone's build?  So ... do I simply need to avoid the C++ construct that triggers this?
 73 2022-05-20T04:26:51  <david-bakin> I'm using clang 15.0.0 and GNU ld 2.37.  Should I be using a different toolchain?
 74 2022-05-20T04:30:32  *** brunoerg <brunoerg!~brunoerg@2804:14d:5281:8ae2:20cc:2e05:bb48:c8dd> has joined #bitcoin-core-dev
 75 2022-05-20T04:34:57  *** brunoerg <brunoerg!~brunoerg@2804:14d:5281:8ae2:20cc:2e05:bb48:c8dd> has quit IRC (Ping timeout: 260 seconds)
 76 2022-05-20T04:36:42  *** brunoerg <brunoerg!~brunoerg@187.183.43.40> has joined #bitcoin-core-dev
 77 2022-05-20T04:40:54  *** brunoerg <brunoerg!~brunoerg@187.183.43.40> has quit IRC (Ping timeout: 244 seconds)
 78 2022-05-20T04:44:49  *** chinggg <chinggg!~chinggg@198.16.63.47> has joined #bitcoin-core-dev
 79 2022-05-20T04:53:28  *** brunoerg <brunoerg!~brunoerg@2804:14d:5281:8ae2:20cc:2e05:bb48:c8dd> has joined #bitcoin-core-dev
 80 2022-05-20T04:58:17  *** brunoerg <brunoerg!~brunoerg@2804:14d:5281:8ae2:20cc:2e05:bb48:c8dd> has quit IRC (Ping timeout: 260 seconds)
 81 2022-05-20T05:02:23  *** Kaizen_Kintsugi_ <Kaizen_Kintsugi_!Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745> has joined #bitcoin-core-dev
 82 2022-05-20T05:06:36  *** Kaizen_Kintsugi_ <Kaizen_Kintsugi_!Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745> has quit IRC (Ping timeout: 246 seconds)
 83 2022-05-20T05:11:58  *** dongcarl <dongcarl!~dongcarl@pool-108-6-233-95.nycmny.fios.verizon.net> has quit IRC (Ping timeout: 260 seconds)
 84 2022-05-20T05:12:11  *** dongcarl <dongcarl!~dongcarl@pool-108-6-233-95.nycmny.fios.verizon.net> has joined #bitcoin-core-dev
 85 2022-05-20T05:32:55  *** hashfunc1204 <hashfunc1204!~user@2601:5c0:c280:7090:6cc7:34d7:ac5c:899e> has quit IRC (Ping timeout: 260 seconds)
 86 2022-05-20T05:35:46  <david-bakin> NVM I just rewrote C++ code until the problem went away.
 87 2022-05-20T05:37:51  *** brunoerg <brunoerg!~brunoerg@2804:14d:5281:8ae2:20cc:2e05:bb48:c8dd> has joined #bitcoin-core-dev
 88 2022-05-20T05:42:28  *** brunoerg <brunoerg!~brunoerg@2804:14d:5281:8ae2:20cc:2e05:bb48:c8dd> has quit IRC (Ping timeout: 248 seconds)
 89 2022-05-20T05:48:44  *** brunoerg <brunoerg!~brunoerg@187.183.43.40> has joined #bitcoin-core-dev
 90 2022-05-20T05:53:14  *** brunoerg <brunoerg!~brunoerg@187.183.43.40> has quit IRC (Ping timeout: 244 seconds)
 91 2022-05-20T05:59:37  *** brunoerg <brunoerg!~brunoerg@187.183.43.40> has joined #bitcoin-core-dev
 92 2022-05-20T06:04:36  *** brunoerg <brunoerg!~brunoerg@187.183.43.40> has quit IRC (Ping timeout: 272 seconds)
 93 2022-05-20T06:05:41  *** brunoerg <brunoerg!~brunoerg@2804:14d:5281:8ae2:20cc:2e05:bb48:c8dd> has joined #bitcoin-core-dev
 94 2022-05-20T06:10:15  *** brunoerg <brunoerg!~brunoerg@2804:14d:5281:8ae2:20cc:2e05:bb48:c8dd> has quit IRC (Ping timeout: 260 seconds)
 95 2022-05-20T06:27:38  *** brunoerg <brunoerg!~brunoerg@2804:14d:5281:8ae2:20cc:2e05:bb48:c8dd> has joined #bitcoin-core-dev
 96 2022-05-20T06:32:12  *** brunoerg <brunoerg!~brunoerg@2804:14d:5281:8ae2:20cc:2e05:bb48:c8dd> has quit IRC (Ping timeout: 260 seconds)
 97 2022-05-20T06:33:45  *** brunoerg <brunoerg!~brunoerg@2804:14d:5281:8ae2:20cc:2e05:bb48:c8dd> has joined #bitcoin-core-dev
 98 2022-05-20T06:36:16  *** z9z0b3t1_ <z9z0b3t1_!z9z0b3t1c@gateway/vpn/protonvpn/z9z0b3t1c> has quit IRC (Ping timeout: 250 seconds)
 99 2022-05-20T06:38:11  *** brunoerg <brunoerg!~brunoerg@2804:14d:5281:8ae2:20cc:2e05:bb48:c8dd> has quit IRC (Ping timeout: 244 seconds)
100 2022-05-20T06:42:41  *** szkl <szkl!uid110435@id-110435.uxbridge.irccloud.com> has quit IRC (Quit: Connection closed for inactivity)
101 2022-05-20T06:43:16  *** z9z0b3t1c <z9z0b3t1c!z9z0b3t1c@gateway/vpn/protonvpn/z9z0b3t1c> has joined #bitcoin-core-dev
102 2022-05-20T06:45:28  *** Guest4630 <Guest4630!~Guest46@94.155.240.227> has joined #bitcoin-core-dev
103 2022-05-20T06:48:10  <laanwj> from what i've seen uusally if you get DWARF errors it means you have to clean your tree, it means object files from different compilers are used together in a way they shouldn't
104 2022-05-20T06:48:22  <bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/0de36941eca1...6407c0e8a33f
105 2022-05-20T06:48:22  <bitcoin-git> bitcoin/master fa305fd MarcoFalke: Add mockable clock type and TicksSinceEpoch helper
106 2022-05-20T06:48:23  <bitcoin-git> bitcoin/master 6407c0e fanquake: Merge bitcoin/bitcoin#25101: Add mockable clock type
107 2022-05-20T06:48:26  <bitcoin-git> [bitcoin] fanquake merged pull request #25101: Add mockable clock type (master...2205-mock-clock-😃) https://github.com/bitcoin/bitcoin/pull/25101
108 2022-05-20T06:48:49  *** Guest4630 <Guest4630!~Guest46@94.155.240.227> has quit IRC (Client Quit)
109 2022-05-20T06:50:44  <laanwj> oh, yes, it could also mean your linker is not compatible with the debug information your compiler generates
110 2022-05-20T06:51:59  <laanwj> it shouldn't be related to anything you wrote at the C++ level, nothing you do at that level should (unless a bug in the toolchain) result in a DWARF error
111 2022-05-20T06:55:54  *** brunoerg <brunoerg!~brunoerg@2804:14d:5281:8ae2:20cc:2e05:bb48:c8dd> has joined #bitcoin-core-dev
112 2022-05-20T06:58:03  <laanwj> jonatack ran into a similar error with clang 15 recently #25120
113 2022-05-20T06:58:04  <gribble> https://github.com/bitcoin/bitcoin/issues/25120 | test: fix DWARF string_view linker error in blockfilter_tests by jonatack · Pull Request #25120 · bitcoin/bitcoin · GitHub
114 2022-05-20T06:58:16  <laanwj> his solution was to clear ccache
115 2022-05-20T07:00:12  *** brunoerg <brunoerg!~brunoerg@2804:14d:5281:8ae2:20cc:2e05:bb48:c8dd> has quit IRC (Ping timeout: 260 seconds)
116 2022-05-20T07:08:23  *** z9z0b3t1_ <z9z0b3t1_!z9z0b3t1c@gateway/vpn/protonvpn/z9z0b3t1c> has joined #bitcoin-core-dev
117 2022-05-20T07:10:59  *** salvatoshi <salvatoshi!~salvatosh@genymobile-2-6-86.fib.nerim.net> has joined #bitcoin-core-dev
118 2022-05-20T07:11:53  *** z9z0b3t1c <z9z0b3t1c!z9z0b3t1c@gateway/vpn/protonvpn/z9z0b3t1c> has quit IRC (Ping timeout: 256 seconds)
119 2022-05-20T07:13:34  *** ___nick___ <___nick___!~quassel@cpc68286-cdif17-2-0-cust533.5-1.cable.virginm.net> has joined #bitcoin-core-dev
120 2022-05-20T07:19:39  <bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/6407c0e8a33f...d433f59f1eb8
121 2022-05-20T07:19:39  <bitcoin-git> bitcoin/master 055d94d brunoerg: test: add coverage for unknown network in -onlynet
122 2022-05-20T07:19:39  <bitcoin-git> bitcoin/master d433f59 MacroFake: Merge bitcoin/bitcoin#25173: test: add coverage for unknown network in -on...
123 2022-05-20T07:19:41  <bitcoin-git> [bitcoin] MarcoFalke merged pull request #25173: test: add coverage for unknown network in -onlynet (master...2022-05-unknown-onlynet) https://github.com/bitcoin/bitcoin/pull/25173
124 2022-05-20T07:28:45  *** Earnestly <Earnestly!~earnest@user/earnestly> has joined #bitcoin-core-dev
125 2022-05-20T07:28:51  *** brunoerg <brunoerg!~brunoerg@2804:14d:5281:8ae2:20cc:2e05:bb48:c8dd> has joined #bitcoin-core-dev
126 2022-05-20T07:29:47  <bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/d433f59f1eb8...4a8709821e64
127 2022-05-20T07:29:47  <bitcoin-git> bitcoin/master 1d4122d Ryan Ofsky: init: Allow -proxy="" setting values
128 2022-05-20T07:29:47  <bitcoin-git> bitcoin/master 4a87098 MacroFake: Merge bitcoin/bitcoin#24830: init: Allow -proxy="" setting values
129 2022-05-20T07:29:50  <bitcoin-git> [bitcoin] MarcoFalke merged pull request #24830: init: Allow -proxy="" setting values (master...pr/proxy) https://github.com/bitcoin/bitcoin/pull/24830
130 2022-05-20T07:33:13  *** brunoerg <brunoerg!~brunoerg@2804:14d:5281:8ae2:20cc:2e05:bb48:c8dd> has quit IRC (Ping timeout: 248 seconds)
131 2022-05-20T07:34:56  *** brunoerg <brunoerg!~brunoerg@2804:14d:5281:8ae2:20cc:2e05:bb48:c8dd> has joined #bitcoin-core-dev
132 2022-05-20T07:36:13  <bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/4a8709821e64...a39002e0c642
133 2022-05-20T07:36:13  <bitcoin-git> bitcoin/master fafae67 MacroFake: build: Enable RPC_DOC_CHECK on --enable-debug
134 2022-05-20T07:36:13  <bitcoin-git> bitcoin/master a39002e fanquake: Merge bitcoin/bitcoin#25170: build: Enable RPC_DOC_CHECK on --enable-debug
135 2022-05-20T07:36:13  <bitcoin-git> [bitcoin] fanquake merged pull request #25170: build: Enable RPC_DOC_CHECK on --enable-debug (master...2205-enable-rpc-doc-check-on-debug-🗿) https://github.com/bitcoin/bitcoin/pull/25170
136 2022-05-20T07:39:36  *** brunoerg <brunoerg!~brunoerg@2804:14d:5281:8ae2:20cc:2e05:bb48:c8dd> has quit IRC (Ping timeout: 272 seconds)
137 2022-05-20T07:40:36  <jonatack> #24150 might be RFM
138 2022-05-20T07:40:37  <gribble> https://github.com/bitcoin/bitcoin/issues/24150 | refactor: move index class members from protected to private by jonatack · Pull Request #24150 · bitcoin/bitcoin · GitHub
139 2022-05-20T07:43:44  *** Cory <Cory!~Cory@user/pasha> has joined #bitcoin-core-dev
140 2022-05-20T07:49:42  <bitcoin-git> [bitcoin] MarcoFalke pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/a39002e0c642...a7e3afb22136
141 2022-05-20T07:49:42  <bitcoin-git> bitcoin/master ef0aa74 Sebastian Falbesoner: rpc: wallet: remove `-deprecatedrpc=exclude_coinbase` logic
142 2022-05-20T07:49:42  <bitcoin-git> bitcoin/master a4703ce Sebastian Falbesoner: doc: add release notes about removal of the `deprecatedrpc=exclude_coinbas...
143 2022-05-20T07:49:43  <bitcoin-git> bitcoin/master a7e3afb MacroFake: Merge bitcoin/bitcoin#25171: rpc: wallet: remove `-deprecatedrpc=exclude_c...
144 2022-05-20T07:49:44  <bitcoin-git> [bitcoin] MarcoFalke merged pull request #25171: rpc: wallet: remove `-deprecatedrpc=exclude_coinbase` logic (master...202205-rpc-remove_deprecated_include_coinbase_option) https://github.com/bitcoin/bitcoin/pull/25171
145 2022-05-20T07:58:42  *** SpellChecker <SpellChecker!~SpellChec@user/SpellChecker> has quit IRC (Remote host closed the connection)
146 2022-05-20T07:59:28  *** SpellChecker <SpellChecker!~SpellChec@user/SpellChecker> has joined #bitcoin-core-dev
147 2022-05-20T08:07:46  *** brunoerg <brunoerg!~brunoerg@2804:14d:5281:8ae2:20cc:2e05:bb48:c8dd> has joined #bitcoin-core-dev
148 2022-05-20T08:12:32  *** brunoerg <brunoerg!~brunoerg@2804:14d:5281:8ae2:20cc:2e05:bb48:c8dd> has quit IRC (Ping timeout: 260 seconds)
149 2022-05-20T08:15:37  *** AaronvanW <AaronvanW!~AaronvanW@user/AaronvanW> has joined #bitcoin-core-dev
150 2022-05-20T08:18:13  *** Aaronvan_ <Aaronvan_!~AaronvanW@user/AaronvanW> has joined #bitcoin-core-dev
151 2022-05-20T08:21:52  *** AaronvanW <AaronvanW!~AaronvanW@user/AaronvanW> has quit IRC (Ping timeout: 260 seconds)
152 2022-05-20T08:23:56  *** david-bakin <david-bakin!~david-bak@c-174-61-163-5.hsd1.wa.comcast.net> has quit IRC (Ping timeout: 272 seconds)
153 2022-05-20T08:31:46  *** jarthur_ <jarthur_!~jarthur@user/jarthur> has joined #bitcoin-core-dev
154 2022-05-20T08:32:59  *** jarthur <jarthur!~jarthur@user/jarthur> has quit IRC (Ping timeout: 240 seconds)
155 2022-05-20T08:36:36  *** sudoforge <sudoforge!~sudoforge@wireguard/tunneler/sudoforge> has quit IRC (Ping timeout: 246 seconds)
156 2022-05-20T08:38:16  *** sudoforge <sudoforge!~sudoforge@wireguard/tunneler/sudoforge> has joined #bitcoin-core-dev
157 2022-05-20T08:39:59  *** brunoerg <brunoerg!~brunoerg@2804:14d:5281:8ae2:20cc:2e05:bb48:c8dd> has joined #bitcoin-core-dev
158 2022-05-20T08:42:41  *** kouloumos <kouloumos!uid539228@id-539228.tinside.irccloud.com> has joined #bitcoin-core-dev
159 2022-05-20T08:44:50  *** brunoerg <brunoerg!~brunoerg@2804:14d:5281:8ae2:20cc:2e05:bb48:c8dd> has quit IRC (Ping timeout: 260 seconds)
160 2022-05-20T08:46:47  <laanwj> jonatack: yes
161 2022-05-20T08:47:49  <bitcoin-git> [bitcoin] laanwj pushed 4 commits to master: https://github.com/bitcoin/bitcoin/compare/a7e3afb22136...0cd1a2eff9e0
162 2022-05-20T08:47:49  <bitcoin-git> bitcoin/master fabdf81 MarcoFalke: test: Add test for embedded null in hex string
163 2022-05-20T08:47:50  <bitcoin-git> bitcoin/master facd1fb MarcoFalke: refactor: Use Span of std::byte in CExtKey::SetSeed
164 2022-05-20T08:47:56  <bitcoin-git> [bitcoin] laanwj merged pull request #23595: util: Add ParseHexstd::byte() helper (master...2111-utilHexByte) https://github.com/bitcoin/bitcoin/pull/23595
165 2022-05-20T08:52:41  <laanwj> jonatack: wait, i don't get it, why make CDBWrapper a struct instead of a class?
166 2022-05-20T08:54:17  <laanwj> i don't really know what the guidance is for making something a struct or a class but anything that *inherits* from a parent class seems definitely in class territory to me
167 2022-05-20T08:54:44  <laanwj> i mean, DB
168 2022-05-20T08:55:37  *** jonatack <jonatack!~jonatack@user/jonatack> has quit IRC (Ping timeout: 244 seconds)
169 2022-05-20T08:55:54  <laanwj> CDBWrapper is a class, BaseIndex::DB is derived from it, so should imo be a class too
170 2022-05-20T09:00:59  *** Aaronvan_ <Aaronvan_!~AaronvanW@user/AaronvanW> has quit IRC (Remote host closed the connection)
171 2022-05-20T09:03:21  *** kexkey <kexkey!~kexkey@178.249.214.10> has quit IRC (Ping timeout: 248 seconds)
172 2022-05-20T09:03:53  *** kexkey <kexkey!~kexkey@178.249.214.10> has joined #bitcoin-core-dev
173 2022-05-20T09:11:25  <laanwj> this PR keeps confusing me on small c++ details
174 2022-05-20T09:12:38  <laanwj> i'm sorry to say but i'm not sure it's really worth it or just a very marginal improvement
175 2022-05-20T09:15:25  *** jonatack <jonatack!~jonatack@user/jonatack> has joined #bitcoin-core-dev
176 2022-05-20T09:30:36  *** brunoerg <brunoerg!~brunoerg@2804:14d:5281:8ae2:20cc:2e05:bb48:c8dd> has joined #bitcoin-core-dev
177 2022-05-20T09:34:47  *** brunoerg <brunoerg!~brunoerg@2804:14d:5281:8ae2:20cc:2e05:bb48:c8dd> has quit IRC (Ping timeout: 240 seconds)
178 2022-05-20T09:39:36  <vasild> https://google.github.io/styleguide/cppguide.html#Structs_vs._Classes has some meaningful guidelines on struct VS class
179 2022-05-20T09:42:58  <jonatack> was offline, now catching up on the discussion
180 2022-05-20T09:44:48  <bitcoin-git> [gui] hebasto merged pull request #594: scripted-diff: replace deprecated Q_OS_MAC with Q_OS_MACOS (master...q_os_macos) https://github.com/bitcoin-core/gui/pull/594
181 2022-05-20T09:45:27  <bitcoin-git> [bitcoin] hebasto pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/0cd1a2eff9e0...8118970c869f
182 2022-05-20T09:45:27  <bitcoin-git> bitcoin/master e3daeca João Barbosa: scripted-diff: replace deprecated Q_OS_MAC with Q_OS_MACOS
183 2022-05-20T09:45:27  <bitcoin-git> bitcoin/master 8118970 Hennadii Stepanov: Merge bitcoin-core/gui#594: scripted-diff: replace deprecated Q_OS_MAC wit...
184 2022-05-20T09:49:47  <jonatack> laanwj: will drop that accessory change in the last commit
185 2022-05-20T09:53:40  *** greypw2546 <greypw2546!~greypw254@grey.pw> has quit IRC (Quit: I'll be back!)
186 2022-05-20T09:53:49  *** greypw2546 <greypw2546!~greypw254@grey.pw> has joined #bitcoin-core-dev
187 2022-05-20T10:01:21  *** bfsfhkacjzgcytf9 <bfsfhkacjzgcytf9!~bfsfhkacj@user/bfsfhkacjzgcytf> has joined #bitcoin-core-dev
188 2022-05-20T10:07:30  *** salvatoshi <salvatoshi!~salvatosh@genymobile-2-6-86.fib.nerim.net> has quit IRC (Ping timeout: 240 seconds)
189 2022-05-20T10:12:29  <jonatack> Done. I think it's a good simplification, encapsulation improvement, and code clarification that helps new virtual functions be added in the right place rather than by default next to  existing ones (that were misplaced). This came up in review feedback over several PRs.
190 2022-05-20T10:14:14  <hebasto> has bitcoin-git bot just got another holiday?
191 2022-05-20T10:25:46  <laanwj> jonatack: thanks!
192 2022-05-20T10:25:54  <laanwj> hebasto: i didn't give if time off i'll check
193 2022-05-20T10:27:10  <hebasto> laanwj: thank you
194 2022-05-20T10:33:48  <bitcoin-git> [gui] hebasto merged pull request #581: refactor: Revamp `ClientModel` code to handle core signals (master...220410-invoke) https://github.com/bitcoin-core/gui/pull/581
195 2022-05-20T10:35:23  <laanwj> i'm not entirely sure what happened (the matrix side was throwing an error resolving the room alias), restarting the bot seems to have solved it
196 2022-05-20T10:37:00  <hebasto> thanks!
197 2022-05-20T11:10:36  *** AaronvanW <AaronvanW!~AaronvanW@user/AaronvanW> has joined #bitcoin-core-dev
198 2022-05-20T11:16:16  *** z9z0b3t1c <z9z0b3t1c!z9z0b3t1c@gateway/vpn/protonvpn/z9z0b3t1c> has joined #bitcoin-core-dev
199 2022-05-20T11:18:48  *** z9z0b3t1_ <z9z0b3t1_!z9z0b3t1c@gateway/vpn/protonvpn/z9z0b3t1c> has quit IRC (Ping timeout: 250 seconds)
200 2022-05-20T11:40:16  <bitcoin-git> [bitcoin] hebasto opened pull request #25175: refactor: Improve thread safety analysis by propagating some negative capabilities (master...220520-nega) https://github.com/bitcoin/bitcoin/pull/25175
201 2022-05-20T11:41:28  *** sudoforge <sudoforge!~sudoforge@wireguard/tunneler/sudoforge> has quit IRC (Ping timeout: 244 seconds)
202 2022-05-20T11:42:05  *** AaronvanW <AaronvanW!~AaronvanW@user/AaronvanW> has quit IRC (Remote host closed the connection)
203 2022-05-20T11:53:31  *** sudoforge <sudoforge!~sudoforge@wireguard/tunneler/sudoforge> has joined #bitcoin-core-dev
204 2022-05-20T11:58:38  *** sudoforge <sudoforge!~sudoforge@wireguard/tunneler/sudoforge> has quit IRC (Ping timeout: 272 seconds)
205 2022-05-20T12:00:04  *** SpellChecker <SpellChecker!~SpellChec@user/SpellChecker> has quit IRC (Ping timeout: 240 seconds)
206 2022-05-20T12:00:59  *** SpellChecker <SpellChecker!~SpellChec@user/SpellChecker> has joined #bitcoin-core-dev
207 2022-05-20T12:01:22  *** sudoforge <sudoforge!~sudoforge@wireguard/tunneler/sudoforge> has joined #bitcoin-core-dev
208 2022-05-20T12:18:50  *** brunoerg <brunoerg!~brunoerg@187.183.43.40> has joined #bitcoin-core-dev
209 2022-05-20T12:23:10  *** brunoerg <brunoerg!~brunoerg@187.183.43.40> has quit IRC (Ping timeout: 240 seconds)
210 2022-05-20T12:37:17  <bitcoin-git> [bitcoin] MarcoFalke pushed 6 commits to master: https://github.com/bitcoin/bitcoin/compare/8c61374ba782...4d0c00dffd13
211 2022-05-20T12:37:17  <bitcoin-git> bitcoin/master fa4ee53 MacroFake: Do not pass time getter to Chainstate helpers
212 2022-05-20T12:37:17  <bitcoin-git> bitcoin/master faf012b MacroFake: Do not pass Consensus::Params& to Chainstate helpers
213 2022-05-20T12:37:17  <bitcoin-git> bitcoin/master fafe5c0 MacroFake: Do not pass CChainParams& to BlockAssembler constructor
214 2022-05-20T12:37:21  <bitcoin-git> [bitcoin] MarcoFalke merged pull request #25168: refactor: Avoid passing params where not needed (master...2205-remove-bloat-🏮) https://github.com/bitcoin/bitcoin/pull/25168
215 2022-05-20T12:42:09  *** Guyver2 <Guyver2!~Guyver@77-174-98-73.fixed.kpn.net> has joined #bitcoin-core-dev
216 2022-05-20T12:48:10  <bitcoin-git> [bitcoin] jonatack opened pull request #25176: Fix frequent -netinfo JSON errors from missing getpeerinfo#relaytxes (master...fix-netinfo-json-errors-from-null-getpeerinfo-relaytxes-field) https://github.com/bitcoin/bitcoin/pull/25176
217 2022-05-20T12:48:18  *** bitdex <bitdex!~bitdex@gateway/tor-sasl/bitdex> has quit IRC (Quit: = "")
218 2022-05-20T12:51:45  *** brunoerg <brunoerg!~brunoerg@187.183.43.40> has joined #bitcoin-core-dev
219 2022-05-20T13:03:34  *** yanmaani2 <yanmaani2!~yanmaani@gateway/tor-sasl/yanmaani> has quit IRC (Ping timeout: 240 seconds)
220 2022-05-20T13:29:25  *** yanmaani2 <yanmaani2!~yanmaani@gateway/tor-sasl/yanmaani> has joined #bitcoin-core-dev
221 2022-05-20T13:55:18  <bitcoin-git> [bitcoin] theStack opened pull request #25178: doc: remove passing `--disable-external-signer` in OpenBSD build guide (master...202205-doc-update_openbsd_build_docs_71) https://github.com/bitcoin/bitcoin/pull/25178
222 2022-05-20T14:05:36  *** furszy <furszy!~furszy@user/furszy> has joined #bitcoin-core-dev
223 2022-05-20T14:11:08  *** noonien <noonien!~noonien@user/noonien> has joined #bitcoin-core-dev
224 2022-05-20T14:16:24  *** Kaizen_Kintsugi_ <Kaizen_Kintsugi_!Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745> has joined #bitcoin-core-dev
225 2022-05-20T14:20:30  *** Kaizen_Kintsugi_ <Kaizen_Kintsugi_!Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745> has quit IRC (Ping timeout: 240 seconds)
226 2022-05-20T15:13:18  *** Guyver2_ <Guyver2_!~Guyver@77-174-98-73.fixed.kpn.net> has joined #bitcoin-core-dev
227 2022-05-20T15:16:02  *** Guyver2 <Guyver2!~Guyver@77-174-98-73.fixed.kpn.net> has quit IRC (Ping timeout: 260 seconds)
228 2022-05-20T15:27:16  *** z9z0b3t1_ <z9z0b3t1_!z9z0b3t1c@gateway/vpn/protonvpn/z9z0b3t1c> has joined #bitcoin-core-dev
229 2022-05-20T15:28:19  *** david-bakin <david-bakin!~david-bak@c-174-61-163-5.hsd1.wa.comcast.net> has joined #bitcoin-core-dev
230 2022-05-20T15:31:07  *** z9z0b3t1c <z9z0b3t1c!z9z0b3t1c@gateway/vpn/protonvpn/z9z0b3t1c> has quit IRC (Ping timeout: 256 seconds)
231 2022-05-20T15:41:15  *** szkl <szkl!uid110435@id-110435.uxbridge.irccloud.com> has joined #bitcoin-core-dev
232 2022-05-20T16:09:55  *** Kaizen_Kintsugi_ <Kaizen_Kintsugi_!Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745> has joined #bitcoin-core-dev
233 2022-05-20T16:10:30  *** mikehu44 <mikehu44!~quassel@gateway/vpn/pia/mikehu44-jc> has quit IRC (Ping timeout: 240 seconds)
234 2022-05-20T16:11:24  *** Common <Common!~Common@096-033-221-075.res.spectrum.com> has joined #bitcoin-core-dev
235 2022-05-20T16:12:29  *** Kaizen_Kintsugi_ <Kaizen_Kintsugi_!Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745> has quit IRC (Remote host closed the connection)
236 2022-05-20T16:12:53  *** Kaizen_Kintsugi_ <Kaizen_Kintsugi_!Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745> has joined #bitcoin-core-dev
237 2022-05-20T16:28:44  *** Kaizen_K_ <Kaizen_K_!Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745> has joined #bitcoin-core-dev
238 2022-05-20T16:32:51  *** Kaizen_Kintsugi_ <Kaizen_Kintsugi_!Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745> has quit IRC (Ping timeout: 276 seconds)
239 2022-05-20T16:33:17  *** furszy <furszy!~furszy@user/furszy> has quit IRC (Remote host closed the connection)
240 2022-05-20T16:34:38  <david-bakin> hmm, clear ccache - i'll try that next time - but I don't rule out an incompatibility in the toolchain because it _did_ go away when I changed the code
241 2022-05-20T17:06:15  *** furszy <furszy!~furszy@user/furszy> has joined #bitcoin-core-dev
242 2022-05-20T17:38:02  *** furszy <furszy!~furszy@user/furszy> has quit IRC ()
243 2022-05-20T18:17:23  *** Kaizen_K_ <Kaizen_K_!Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745> has quit IRC ()
244 2022-05-20T18:40:18  <bitcoin-git> [gui] ryanofsky opened pull request #603: Add settings.json prune-prev, proxy-prev, onion-prev settings  (master...pr/qtkeep) https://github.com/bitcoin-core/gui/pull/603
245 2022-05-20T18:41:09  *** Kaizen_Kintsugi_ <Kaizen_Kintsugi_!~Kaizen_Ki@2600:8802:3806:c200:f8a2:49f0:843c:1b6d> has joined #bitcoin-core-dev
246 2022-05-20T18:41:37  *** Kaizen_Kintsugi_ <Kaizen_Kintsugi_!~Kaizen_Ki@2600:8802:3806:c200:f8a2:49f0:843c:1b6d> has quit IRC (Remote host closed the connection)
247 2022-05-20T18:41:56  <bitcoin-git> [bitcoin] MarcoFalke pushed 4 commits to master: https://github.com/bitcoin/bitcoin/compare/aac99faa66e2...640eb772e556
248 2022-05-20T18:41:57  <bitcoin-git> bitcoin/master dbe45c3 Carl Dong: Add ChainstateManagerOpts, using as ::Options
249 2022-05-20T18:41:57  <bitcoin-git> bitcoin/master 04c31c1 Carl Dong: Add ChainstateManager::m_adjusted_time_callback
250 2022-05-20T18:41:57  <bitcoin-git> bitcoin/master 53494bc Carl Dong: validation: Have ChainstateManager own m_chainparams
251 2022-05-20T18:41:59  <bitcoin-git> [bitcoin] MarcoFalke merged pull request #25064: [kernel 2b/n] Add `ChainstateManager::m_adjusted_time_callback` (master...2022-05-libbitcoinkernel-adjtime) https://github.com/bitcoin/bitcoin/pull/25064
252 2022-05-20T18:42:12  *** Kaizen_Kintsugi_ <Kaizen_Kintsugi_!Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745> has joined #bitcoin-core-dev
253 2022-05-20T18:43:44  *** gnaf <gnaf!~gnaf@195-154-105-157.rev.poneytelecom.eu> has quit IRC (Quit: Konversation terminated!)
254 2022-05-20T19:01:43  <achow101> #startmeeting
255 2022-05-20T19:01:44  <core-meetingbot> Meeting started Fri May 20 19:01:43 2022 UTC.  The chair is achow101. Information about MeetBot at https://bitcoin.jonasschnelli.ch/ircmeetings.
256 2022-05-20T19:01:44  <core-meetingbot> Available commands: action commands idea info link nick
257 2022-05-20T19:01:46  <achow101> #bitcoin-core-dev Wallet Meeting: achow101 _aj_ amiti ariard BlueMatt cfields Chris_Stewart_5 darosior digi_james dongcarl elichai2 emilengler fanquake fjahr gleb glozow gmaxwell gwillen hebasto instagibbs jamesob jarolrod jb55 jeremyrubin jl2012 jnewbery jonasschnelli jonatack jtimon kallewoof kanzure kvaciral laanwj larryruane lightlike luke-jr maaku marcofalke meshcollider michagogo moneyball morcos Murch nehan NicolasDorier paveljanik
258 2022-05-20T19:01:46  <achow101> petertodd phantomcircuit promag provoostenator ryanofsky sdaftuar S3RK sipa vasild
259 2022-05-20T19:02:06  <achow101> we haven't had a wallet meeting in a while
260 2022-05-20T19:02:27  <sipa> hi
261 2022-05-20T19:02:32  <achow101> there aren't any pre-proposed wallet meeting topics. Does anyone have anything to discuss?
262 2022-05-20T19:03:15  <Murch> hi
263 2022-05-20T19:04:35  <kanzure> hi
264 2022-05-20T19:04:37  <achow101> or any PRs to shill?
265 2022-05-20T19:04:43  <Murch> I don't have anything from the top of my head
266 2022-05-20T19:04:58  <Murch>  https://github.com/bitcoin/bitcoin/pull/25083
267 2022-05-20T19:05:15  <Murch> I think it's almost ready to go, could use another review or two
268 2022-05-20T19:06:13  <achow101>  I think #24649 and  #25122 are close as well
269 2022-05-20T19:06:14  <gribble> https://github.com/bitcoin/bitcoin/issues/24649 | wallet: do not count wallet utxos as external by S3RK · Pull Request #24649 · bitcoin/bitcoin · GitHub
270 2022-05-20T19:06:15  <gribble> https://github.com/bitcoin/bitcoin/issues/25122 | rpc: getreceivedbylabel, return early if no addresses were found in the address book by furszy · Pull Request #25122 · bitcoin/bitcoin · GitHub
271 2022-05-20T19:06:57  <Murch> Oh, I should look at #25122
272 2022-05-20T19:06:58  <gribble> https://github.com/bitcoin/bitcoin/issues/25122 | rpc: getreceivedbylabel, return early if no addresses were found in the address book by furszy · Pull Request #25122 · bitcoin/bitcoin · GitHub
273 2022-05-20T19:07:02  <Murch> I have reviewed the other already
274 2022-05-20T19:08:13  <achow101> It looks like there have been a lot of proposed changes to AvailableCoins that conflict with each other, but all look nice to get in
275 2022-05-20T19:08:29  <Murch> Yeah, that's right
276 2022-05-20T19:09:00  <achow101> e.g. #25005 #25118 #25083 #24699 #24584
277 2022-05-20T19:09:01  <gribble> https://github.com/bitcoin/bitcoin/issues/25005 | wallet: remove extra wtx lookup in AvailableCoins + several code cleanups. by furszy · Pull Request #25005 · bitcoin/bitcoin · GitHub
278 2022-05-20T19:09:02  <gribble> https://github.com/bitcoin/bitcoin/issues/25118 | wallet: unify “allow/block other inputs“ concept by furszy · Pull Request #25118 · bitcoin/bitcoin · GitHub
279 2022-05-20T19:09:03  <gribble> https://github.com/bitcoin/bitcoin/issues/25083 | Set effective_value when initializing a COutput by ishaanam · Pull Request #25083 · bitcoin/bitcoin · GitHub
280 2022-05-20T19:09:04  <gribble> https://github.com/bitcoin/bitcoin/issues/24699 | wallet: Improve AvailableCoins performance by reducing duplicated operations by achow101 · Pull Request #24699 · bitcoin/bitcoin · GitHub
281 2022-05-20T19:09:06  <achow101> any thoughts on what to prioritize?
282 2022-05-20T19:09:07  <gribble> https://github.com/bitcoin/bitcoin/issues/24584 | wallet: avoid mixing different `OutputTypes` during coin selection by josibake · Pull Request #24584 · bitcoin/bitcoin · GitHub
283 2022-05-20T19:09:42  <Murch> I don't think Josi's is close to getting merged.
284 2022-05-20T19:09:54  <Murch> I haven't looked at #25005, so I can't comment on that
285 2022-05-20T19:09:55  <gribble> https://github.com/bitcoin/bitcoin/issues/25005 | wallet: remove extra wtx lookup in AvailableCoins + several code cleanups. by furszy · Pull Request #25005 · bitcoin/bitcoin · GitHub
286 2022-05-20T19:10:20  <achow101> 25083 and 25118 both are pretty simple
287 2022-05-20T19:10:20  <Murch> How useful is 24699 now that we use different keys?
288 2022-05-20T19:10:24  <achow101> so I think they can go in soon
289 2022-05-20T19:11:06  *** kouloumos <kouloumos!uid539228@id-539228.tinside.irccloud.com> has quit IRC (Quit: Connection closed for inactivity)
290 2022-05-20T19:11:15  <Murch> I'm biased, one of my PRs is building on #25083 ^^
291 2022-05-20T19:11:16  <gribble> https://github.com/bitcoin/bitcoin/issues/25083 | Set effective_value when initializing a COutput by ishaanam · Pull Request #25083 · bitcoin/bitcoin · GitHub
292 2022-05-20T19:11:21  <achow101> I think 24699 is still a worthwhile promovement. it improves more than just the reused addresses case
293 2022-05-20T19:12:02  <achow101> *improvement
294 2022-05-20T19:12:24  <Murch> okay
295 2022-05-20T19:12:33  <Murch> I'll put all of the above on my review list
296 2022-05-20T19:13:27  <Murch> I think just in the order that they're ready is fine
297 2022-05-20T19:13:44  <Murch> I don't think rebasing would get too bad for any
298 2022-05-20T19:14:23  <Murch> You should add josibake to your ping list ^^
299 2022-05-20T19:14:47  <achow101> I think 24584 might have a larger conflict with the others
300 2022-05-20T19:14:53  <achow101> but it's also not ready imo
301 2022-05-20T19:15:27  <Murch> Yeah, and it is also the biggest one
302 2022-05-20T19:15:49  <achow101> anything else look ready or nearly ready?
303 2022-05-20T19:15:51  <jonatack> hi  (...reading up)
304 2022-05-20T19:17:25  <achow101> anything else to discuss?
305 2022-05-20T19:17:43  <Murch> Not from the top of my head. Really curious to see some simulation results for #24584
306 2022-05-20T19:17:47  <gribble> https://github.com/bitcoin/bitcoin/issues/24584 | wallet: avoid mixing different `OutputTypes` during coin selection by josibake · Pull Request #24584 · bitcoin/bitcoin · GitHub
307 2022-05-20T19:18:17  <Murch> I'm wondering how splitting the UTXO pool in multiple ways will affect the tx costs
308 2022-05-20T19:18:34  <Murch> Oh one more
309 2022-05-20T19:18:55  <Murch> There is this very tight testing corset that S3RK proposed
310 2022-05-20T19:19:12  <Murch> So far you and I reviewed it, achow101
311 2022-05-20T19:19:41  <Murch> Yours sounded like a soft concept nack or approach nack
312 2022-05-20T19:20:09  <achow101> #24580?
313 2022-05-20T19:20:10  <gribble> https://github.com/bitcoin/bitcoin/issues/24580 | test: coinselection edge cases by S3RK · Pull Request #24580 · bitcoin/bitcoin · GitHub
314 2022-05-20T19:20:19  <Murch> I think maintaining the test when we start changing the coin selection algos will be annoying, but it's also kinda nice to see the exact boundaries
315 2022-05-20T19:20:26  <Murch> yeah thanks!
316 2022-05-20T19:20:59  <Murch> I think that S3RK might be a bit stuck there, no way forward not really shot down either
317 2022-05-20T19:21:40  <achow101> perhaps more people should look at it
318 2022-05-20T19:21:59  <Murch> Could we perhaps give more input how it should be developed to address maintainability concerns?
319 2022-05-20T19:23:36  <achow101> maybe more programmatic math rather than hardcoded math
320 2022-05-20T19:23:59  <Murch> Yeah
321 2022-05-20T19:24:28  <Murch> Do you know what the status with Bruno's "Prefer changeless" PR is?
322 2022-05-20T19:24:29  <Murch> That also seemed a bit stuck
323 2022-05-20T19:24:29  <instagibbs> woof, lots of magic numbers
324 2022-05-20T19:24:41  <instagibbs> re: #24580
325 2022-05-20T19:24:42  <gribble> https://github.com/bitcoin/bitcoin/issues/24580 | test: coinselection edge cases by S3RK · Pull Request #24580 · bitcoin/bitcoin · GitHub
326 2022-05-20T19:26:19  <Murch> https://github.com/bitcoin/bitcoin/pull/23475
327 2022-05-20T19:26:23  <achow101> Murch: it seems like it needs conceptual review as to whether that's a good idea?
328 2022-05-20T19:27:03  <Murch> achow101: I think I'd be "concept ack, approach nack", wasn't sure whether that came out clearly
329 2022-05-20T19:27:33  <Murch> Is brunoerg here?
330 2022-05-20T19:27:48  <jonatack>  having good boundary testing of expected behavior in place before making big changes can be good if the testing is of the right kind... maybe hoist the magic numbers up to constants or derive them programmatically as mentioned
331 2022-05-20T19:28:16  <Murch> jonatack: that sounds like a good idea
332 2022-05-20T19:28:39  <jonatack> might be good for people to weigh in on https://github.com/bitcoin/bitcoin/issues/25130
333 2022-05-20T19:28:39  <instagibbs> derive please, don't make follow-on contributors hate life
334 2022-05-20T19:29:23  <instagibbs> can even be done and merged piece by piece
335 2022-05-20T19:29:24  <achow101> #23475 would interact pretty poorly with #24752
336 2022-05-20T19:29:26  <gribble> https://github.com/bitcoin/bitcoin/issues/23475 | wallet: add config to prioritize a solution that doesnt create change in coin selection by brunoerg · Pull Request #23475 · bitcoin/bitcoin · GitHub
337 2022-05-20T19:29:27  <gribble> https://github.com/bitcoin/bitcoin/issues/24752 | wallet: increase BnB upper limit by S3RK · Pull Request #24752 · bitcoin/bitcoin · GitHub
338 2022-05-20T19:29:45  <Murch> instagibbs, jonatack: I think one issue is also that it sorta depends on the current selection of algorithms we use, and sort of tests whether the outcome was Knapsack, or BnB at times
339 2022-05-20T19:30:09  <instagibbs> Murch, yeah I'm not wading in on the overall thrust, deferring on that
340 2022-05-20T19:30:34  <Murch> Yeah, #23475 needs some sanity limit, similar to the avoid_partial_spend approach
341 2022-05-20T19:30:35  <gribble> https://github.com/bitcoin/bitcoin/issues/23475 | wallet: add config to prioritize a solution that doesnt create change in coin selection by brunoerg · Pull Request #23475 · bitcoin/bitcoin · GitHub
342 2022-05-20T19:31:27  <Murch> Okay, I guess the overall result is, we could all take another glance at these and perhaps be a bit more direct with feedback? ;)
343 2022-05-20T19:31:40  <achow101> yes
344 2022-05-20T19:31:44  *** lukedashjr <lukedashjr!~luke-jr@user/luke-jr> has joined #bitcoin-core-dev
345 2022-05-20T19:31:45  <jonatack> instagibbs: Murch: agree, may need more abstraction
346 2022-05-20T19:32:53  <achow101> anything else to discuss?
347 2022-05-20T19:33:50  *** luke-jr <luke-jr!~luke-jr@user/luke-jr> has quit IRC (Ping timeout: 240 seconds)
348 2022-05-20T19:33:56  *** lukedashjr is now known as luke-jr
349 2022-05-20T19:34:11  <Murch> No, just … by the way, I'm of the opinion that Knapsack needs to die
350 2022-05-20T19:34:12  <Murch> :D
351 2022-05-20T19:34:16  <achow101> #endmeeting
352 2022-05-20T19:34:16  <core-meetingbot> topic: Bitcoin Core development discussion and commit log | Feel free to watch, but please take commentary and usage questions to #bitcoin | Channel logs: http://www.erisian.com.au/bitcoin-core-dev/, http://gnusha.org/bitcoin-core-dev/ | Meeting topics http://gnusha.org/bitcoin-core-dev/proposedmeetingtopics.txt / http://gnusha.org/bitcoin-core-dev/proposedwalletmeetingtopics.txt
353 2022-05-20T19:34:16  <core-meetingbot> Meeting ended Fri May 20 19:34:16 2022 UTC.
354 2022-05-20T19:34:16  <core-meetingbot> Minutes:        https://bitcoin.jonasschnelli.ch/ircmeetings/logs/bitcoin-core-dev/2022/bitcoin-core-dev.2022-05-20-19.01.moin.txt
355 2022-05-20T19:34:20  *** Kaizen_Kintsugi_ <Kaizen_Kintsugi_!Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745> has quit IRC (Remote host closed the connection)
356 2022-05-20T19:35:00  *** Kaizen_Kintsugi_ <Kaizen_Kintsugi_!Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745> has joined #bitcoin-core-dev
357 2022-05-20T19:35:15  <Murch> Thanks for hosting
358 2022-05-20T19:36:11  <sipa> @Murch channels his inner cato?
359 2022-05-20T19:36:37  <Murch> Ceterum censeo Knapsackinem esse delendam.
360 2022-05-20T19:39:09  *** Kaizen_Kintsugi_ <Kaizen_Kintsugi_!Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745> has quit IRC (Ping timeout: 246 seconds)
361 2022-05-20T19:39:15  <Murch> Keeps me focused on the important stuff 🤪
362 2022-05-20T19:43:07  <instagibbs> what change size does SRD shoot for these days
363 2022-05-20T19:43:13  <instagibbs> if any
364 2022-05-20T19:49:53  <Murch> äääääässogzonbbclnreolrägnweenagcapshwhlhräl
365 2022-05-20T19:49:56  *** z9z0b3t1c <z9z0b3t1c!z9z0b3t1c@gateway/vpn/protonvpn/z9z0b3t1c> has joined #bitcoin-core-dev
366 2022-05-20T19:50:02  <Murch> oops
367 2022-05-20T19:50:41  <Murch> SRD uses the lower bound of the random change introduced by #24494 as a minimum now
368 2022-05-20T19:50:45  <gribble> https://github.com/bitcoin/bitcoin/issues/24494 | wallet: generate random change target for each tx for better privacy by glozow · Pull Request #24494 · bitcoin/bitcoin · GitHub
369 2022-05-20T19:50:57  *** Kaizen_Kintsugi_ <Kaizen_Kintsugi_!Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745> has joined #bitcoin-core-dev
370 2022-05-20T19:53:36  *** z9z0b3t1_ <z9z0b3t1_!z9z0b3t1c@gateway/vpn/protonvpn/z9z0b3t1c> has quit IRC (Ping timeout: 250 seconds)
371 2022-05-20T19:57:18  <Murch> And that's 50,000 ṩ
372 2022-05-20T20:02:56  <instagibbs> oh wow great to see
373 2022-05-20T20:04:45  *** ___nick___ <___nick___!~quassel@cpc68286-cdif17-2-0-cust533.5-1.cable.virginm.net> has quit IRC (Ping timeout: 276 seconds)
374 2022-05-20T20:14:09  *** bfsfhkacjzgcytf9 <bfsfhkacjzgcytf9!~bfsfhkacj@user/bfsfhkacjzgcytf> has quit IRC (Ping timeout: 246 seconds)
375 2022-05-20T20:14:53  *** mudsip <mudsip!~mudsip@user/mudsip> has joined #bitcoin-core-dev
376 2022-05-20T20:25:07  *** mudsip <mudsip!~mudsip@user/mudsip> has quit IRC ()
377 2022-05-20T20:38:16  *** Talkless <Talkless!~Talkless@mail.dargis.net> has joined #bitcoin-core-dev
378 2022-05-20T20:40:48  *** MiranDaniel <MiranDaniel!~MiranDani@46-13-162-93.customers.tmcz.cz> has joined #bitcoin-core-dev
379 2022-05-20T20:53:08  *** Kaizen_K_ <Kaizen_K_!Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745> has joined #bitcoin-core-dev
380 2022-05-20T20:55:20  *** Kaizen_Kintsugi_ <Kaizen_Kintsugi_!Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745> has quit IRC (Ping timeout: 244 seconds)
381 2022-05-20T21:04:29  *** Kaizen_K_ <Kaizen_K_!Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745> has quit IRC (Remote host closed the connection)
382 2022-05-20T21:05:06  *** Kaizen_Kintsugi_ <Kaizen_Kintsugi_!Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745> has joined #bitcoin-core-dev
383 2022-05-20T21:07:35  *** Kaizen_Kintsugi_ <Kaizen_Kintsugi_!Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745> has quit IRC (Read error: Connection reset by peer)
384 2022-05-20T21:10:39  *** szkl <szkl!uid110435@id-110435.uxbridge.irccloud.com> has quit IRC (Quit: Connection closed for inactivity)
385 2022-05-20T21:22:26  *** Kaizen_Kintsugi_ <Kaizen_Kintsugi_!Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745> has joined #bitcoin-core-dev
386 2022-05-20T21:35:36  *** MiranDaniel <MiranDaniel!~MiranDani@46-13-162-93.customers.tmcz.cz> has quit IRC (Quit: Client closed)
387 2022-05-20T21:35:56  *** MiranDaniel <MiranDaniel!~MiranDani@46-13-162-93.customers.tmcz.cz> has joined #bitcoin-core-dev
388 2022-05-20T21:50:41  *** jarthur <jarthur!~jarthur@user/jarthur> has joined #bitcoin-core-dev
389 2022-05-20T21:51:32  *** jarthur_ <jarthur_!~jarthur@user/jarthur> has quit IRC (Ping timeout: 248 seconds)
390 2022-05-20T21:52:31  <bitcoin-git> [bitcoin] MiranDaniel opened pull request #25182: doc: Fix Markdown formatting (master...master) https://github.com/bitcoin/bitcoin/pull/25182
391 2022-05-20T21:54:18  *** Talkless <Talkless!~Talkless@mail.dargis.net> has quit IRC (Quit: Konversation terminated!)
392 2022-05-20T22:03:03  *** Guyver2_ <Guyver2_!~Guyver@77-174-98-73.fixed.kpn.net> has quit IRC (Ping timeout: 276 seconds)
393 2022-05-20T22:13:48  *** MiranDaniel <MiranDaniel!~MiranDani@46-13-162-93.customers.tmcz.cz> has quit IRC (Quit: Client closed)
394 2022-05-20T22:26:54  *** Kaizen_Kintsugi_ <Kaizen_Kintsugi_!Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745> has quit IRC (Ping timeout: 272 seconds)
395 2022-05-20T22:38:28  *** Kaizen_Kintsugi_ <Kaizen_Kintsugi_!Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745> has joined #bitcoin-core-dev
396 2022-05-20T23:03:04  *** chinggg <chinggg!~chinggg@198.16.63.47> has quit IRC (Quit: Client closed)
397 2022-05-20T23:21:28  *** brunoerg <brunoerg!~brunoerg@187.183.43.40> has quit IRC (Remote host closed the connection)
398 2022-05-20T23:26:44  *** brunoerg <brunoerg!~brunoerg@187.183.43.40> has joined #bitcoin-core-dev
399 2022-05-20T23:30:51  *** brunoerg <brunoerg!~brunoerg@187.183.43.40> has quit IRC (Ping timeout: 244 seconds)
400 2022-05-20T23:37:37  *** brunoerg <brunoerg!~brunoerg@187.183.43.40> has joined #bitcoin-core-dev
401 2022-05-20T23:39:54  *** Guest6 <Guest6!~Guest6@120.29.77.62> has joined #bitcoin-core-dev
402 2022-05-20T23:42:13  *** brunoerg <brunoerg!~brunoerg@187.183.43.40> has quit IRC (Ping timeout: 244 seconds)
403 2022-05-20T23:42:30  *** Kaizen_Kintsugi_ <Kaizen_Kintsugi_!Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745> has quit IRC (Ping timeout: 240 seconds)
404 2022-05-20T23:43:41  *** brunoerg <brunoerg!~brunoerg@2804:14d:5281:8ae2:d919:f52d:939e:99bc> has joined #bitcoin-core-dev
405 2022-05-20T23:44:10  *** Guest6 <Guest6!~Guest6@120.29.77.62> has quit IRC (Client Quit)
406 2022-05-20T23:48:25  *** Kaizen_Kintsugi_ <Kaizen_Kintsugi_!Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745> has joined #bitcoin-core-dev
407 2022-05-20T23:48:36  *** brunoerg <brunoerg!~brunoerg@2804:14d:5281:8ae2:d919:f52d:939e:99bc> has quit IRC (Ping timeout: 272 seconds)
408 2022-05-20T23:50:21  *** szkl <szkl!uid110435@id-110435.uxbridge.irccloud.com> has joined #bitcoin-core-dev
409 2022-05-20T23:53:16  *** z9z0b3t1_ <z9z0b3t1_!z9z0b3t1c@gateway/vpn/protonvpn/z9z0b3t1c> has joined #bitcoin-core-dev
410 2022-05-20T23:53:30  *** Kaizen_Kintsugi_ <Kaizen_Kintsugi_!Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745> has quit IRC (Ping timeout: 240 seconds)
411 2022-05-20T23:56:41  *** z9z0b3t1c <z9z0b3t1c!z9z0b3t1c@gateway/vpn/protonvpn/z9z0b3t1c> has quit IRC (Ping timeout: 244 seconds)
412 2022-05-20T23:59:20  *** Kaizen_Kintsugi_ <Kaizen_Kintsugi_!Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745> has joined #bitcoin-core-dev