1 2022-06-02T00:09:17  *** sudoforge <sudoforge!~sudoforge@wireguard/tunneler/sudoforge> has quit IRC (Ping timeout: 260 seconds)
  2 2022-06-02T00:25:25  *** jonatack <jonatack!~jonatack@user/jonatack> has quit IRC (Ping timeout: 256 seconds)
  3 2022-06-02T00:29:52  *** sudoforge <sudoforge!~sudoforge@wireguard/tunneler/sudoforge> has joined #bitcoin-core-dev
  4 2022-06-02T00:39:34  *** erik-etsuji-kato <erik-etsuji-kato!~erik@gateway/tor-sasl/erik-etsuji-kato> has quit IRC (Ping timeout: 240 seconds)
  5 2022-06-02T00:42:34  *** vasild <vasild!~vd@user/vasild> has quit IRC (Ping timeout: 240 seconds)
  6 2022-06-02T00:44:30  *** vasild <vasild!~vd@user/vasild> has joined #bitcoin-core-dev
  7 2022-06-02T00:48:29  *** hashfunc41a <hashfunc41a!~user@2601:5c0:c280:7090:30da:f74b:fc0a:7f05> has joined #bitcoin-core-dev
  8 2022-06-02T00:54:23  *** Kaizen_Kintsugi_ <Kaizen_Kintsugi_!Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745> has joined #bitcoin-core-dev
  9 2022-06-02T00:54:47  *** brunoerg <brunoerg!~brunoerg@2804:14d:5281:8ae2:9de3:c88:85ba:eb2b> has quit IRC (Ping timeout: 260 seconds)
 10 2022-06-02T00:58:01  *** Kaizen_Kintsugi_ <Kaizen_Kintsugi_!Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745> has quit IRC (Remote host closed the connection)
 11 2022-06-02T00:58:17  *** Kaizen_Kintsugi_ <Kaizen_Kintsugi_!Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745> has joined #bitcoin-core-dev
 12 2022-06-02T01:00:13  *** Kaizen_Kintsugi_ <Kaizen_Kintsugi_!Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745> has quit IRC (Remote host closed the connection)
 13 2022-06-02T01:01:22  *** Guest337 <Guest337!~Guest337@38.101.139.33> has joined #bitcoin-core-dev
 14 2022-06-02T01:02:28  *** vysn <vysn!~vysn@user/vysn> has joined #bitcoin-core-dev
 15 2022-06-02T01:04:47  *** Guest337 <Guest337!~Guest337@38.101.139.33> has quit IRC (Client Quit)
 16 2022-06-02T01:07:45  *** brunoerg <brunoerg!~brunoerg@2804:14d:5281:8ae2:9de3:c88:85ba:eb2b> has joined #bitcoin-core-dev
 17 2022-06-02T01:11:17  *** greypw25460 <greypw25460!~greypw254@grey.pw> has quit IRC (Quit: I'll be back!)
 18 2022-06-02T01:11:55  *** greypw25460 <greypw25460!~greypw254@grey.pw> has joined #bitcoin-core-dev
 19 2022-06-02T01:11:56  *** greypw25460 <greypw25460!~greypw254@grey.pw> has quit IRC (Remote host closed the connection)
 20 2022-06-02T01:12:27  *** greypw25460 <greypw25460!~greypw254@grey.pw> has joined #bitcoin-core-dev
 21 2022-06-02T01:33:53  *** Kaizen_Kintsugi_ <Kaizen_Kintsugi_!Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745> has joined #bitcoin-core-dev
 22 2022-06-02T01:44:22  *** hashfunc41a <hashfunc41a!~user@2601:5c0:c280:7090:30da:f74b:fc0a:7f05> has quit IRC (Remote host closed the connection)
 23 2022-06-02T02:00:36  *** vysn <vysn!~vysn@user/vysn> has quit IRC (Ping timeout: 244 seconds)
 24 2022-06-02T02:02:35  *** ronoaldo <ronoaldo!~ronoaldo@200-171-83-164.dsl.telesp.net.br> has quit IRC (Ping timeout: 255 seconds)
 25 2022-06-02T02:03:15  *** evanlinjin <evanlinjin!~evanlinji@gateway/tor-sasl/evanlinjin> has joined #bitcoin-core-dev
 26 2022-06-02T02:05:17  *** z9z0b3t1c <z9z0b3t1c!z9z0b3t1c@gateway/vpn/protonvpn/z9z0b3t1c> has joined #bitcoin-core-dev
 27 2022-06-02T02:07:54  *** z9z0b3t1_ <z9z0b3t1_!z9z0b3t1c@gateway/vpn/protonvpn/z9z0b3t1c> has quit IRC (Ping timeout: 246 seconds)
 28 2022-06-02T02:13:00  *** brunoerg <brunoerg!~brunoerg@2804:14d:5281:8ae2:9de3:c88:85ba:eb2b> has quit IRC (Ping timeout: 244 seconds)
 29 2022-06-02T02:19:32  *** brunoerg <brunoerg!~brunoerg@2804:14d:5281:8ae2:9de3:c88:85ba:eb2b> has joined #bitcoin-core-dev
 30 2022-06-02T02:24:11  *** brunoerg <brunoerg!~brunoerg@2804:14d:5281:8ae2:9de3:c88:85ba:eb2b> has quit IRC (Ping timeout: 258 seconds)
 31 2022-06-02T02:25:36  *** brunoerg <brunoerg!~brunoerg@2804:14d:5281:8ae2:9de3:c88:85ba:eb2b> has joined #bitcoin-core-dev
 32 2022-06-02T02:33:26  *** Kaizen_Kintsugi_ <Kaizen_Kintsugi_!Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745> has quit IRC (Remote host closed the connection)
 33 2022-06-02T02:34:23  *** Kaizen_Kintsugi_ <Kaizen_Kintsugi_!Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745> has joined #bitcoin-core-dev
 34 2022-06-02T02:34:49  *** Kaizen_Kintsugi_ <Kaizen_Kintsugi_!Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745> has quit IRC (Remote host closed the connection)
 35 2022-06-02T02:36:25  *** ronoaldo <ronoaldo!~ronoaldo@200-171-83-164.dsl.telesp.net.br> has joined #bitcoin-core-dev
 36 2022-06-02T02:37:04  *** evanlinjin <evanlinjin!~evanlinji@gateway/tor-sasl/evanlinjin> has quit IRC (Ping timeout: 240 seconds)
 37 2022-06-02T02:38:56  *** bitdex <bitdex!~bitdex@gateway/tor-sasl/bitdex> has joined #bitcoin-core-dev
 38 2022-06-02T02:43:04  *** bitdex <bitdex!~bitdex@gateway/tor-sasl/bitdex> has quit IRC (Ping timeout: 240 seconds)
 39 2022-06-02T02:46:12  *** bitdex <bitdex!~bitdex@gateway/tor-sasl/bitdex> has joined #bitcoin-core-dev
 40 2022-06-02T02:48:06  *** bitdex <bitdex!~bitdex@gateway/tor-sasl/bitdex> has quit IRC (Client Quit)
 41 2022-06-02T02:49:30  *** bitdex <bitdex!~bitdex@gateway/tor-sasl/bitdex> has joined #bitcoin-core-dev
 42 2022-06-02T02:51:20  *** Kaizen_Kintsugi_ <Kaizen_Kintsugi_!Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745> has joined #bitcoin-core-dev
 43 2022-06-02T03:00:45  *** greypw25460 <greypw25460!~greypw254@grey.pw> has quit IRC (Remote host closed the connection)
 44 2022-06-02T03:00:55  *** greypw25460 <greypw25460!~greypw254@grey.pw> has joined #bitcoin-core-dev
 45 2022-06-02T03:03:28  *** greypw25460 <greypw25460!~greypw254@grey.pw> has quit IRC (Remote host closed the connection)
 46 2022-06-02T03:03:37  *** greypw25460 <greypw25460!~greypw254@grey.pw> has joined #bitcoin-core-dev
 47 2022-06-02T03:15:28  *** evanlinjin <evanlinjin!~evanlinji@gateway/tor-sasl/evanlinjin> has joined #bitcoin-core-dev
 48 2022-06-02T03:19:28  *** jarthur <jarthur!~jarthur@user/jarthur> has quit IRC (Quit: jarthur)
 49 2022-06-02T03:23:02  *** hashfunc1df8 <hashfunc1df8!~user@2601:5c0:c280:7090:30da:f74b:fc0a:7f05> has joined #bitcoin-core-dev
 50 2022-06-02T04:01:01  *** cmirror <cmirror!~cmirror@4.53.92.114> has quit IRC (Remote host closed the connection)
 51 2022-06-02T04:01:32  *** cmirror <cmirror!~cmirror@4.53.92.114> has joined #bitcoin-core-dev
 52 2022-06-02T04:28:04  *** evanlinjin <evanlinjin!~evanlinji@gateway/tor-sasl/evanlinjin> has quit IRC (Ping timeout: 240 seconds)
 53 2022-06-02T04:32:36  *** brunoerg <brunoerg!~brunoerg@2804:14d:5281:8ae2:9de3:c88:85ba:eb2b> has quit IRC (Ping timeout: 248 seconds)
 54 2022-06-02T04:34:36  *** brunoerg <brunoerg!~brunoerg@187.183.43.40> has joined #bitcoin-core-dev
 55 2022-06-02T04:39:15  <davidbakin> I'm trying to understand BIPS-341 and -342 - why is the sig sometimes 64 bytes and sometimes 65 byte?  I infer from BIP-341 note 21 that the 64-byte sig is with hash_type == 0 (i.e., SIGHASH_DEFAULT) and that the 65-byte sigs are for the other hash_types which are _appended_ to the sig - but where is this actually specified (besides this note 21)?
 56 2022-06-02T04:42:55  *** ethan <ethan!uid556645@id-556645.ilkley.irccloud.com> has joined #bitcoin-core-dev
 57 2022-06-02T04:42:59  <davidbakin> 2nd question is: is the tapscript extension the annex or not?  if not, where is it put?
 58 2022-06-02T04:43:45  *** ethan <ethan!uid556645@id-556645.ilkley.irccloud.com> has quit IRC (Client Quit)
 59 2022-06-02T04:44:21  *** sudoforge <sudoforge!~sudoforge@wireguard/tunneler/sudoforge> has quit IRC (Ping timeout: 246 seconds)
 60 2022-06-02T04:44:23  *** saluvoy <saluvoy!uid556645@id-556645.ilkley.irccloud.com> has joined #bitcoin-core-dev
 61 2022-06-02T04:46:29  <davidbakin> 3rd question is when computing the leaf version from the first byte of the control block the low bit is masked off - is that low bit used for anything? if not, is it reserved for something?
 62 2022-06-02T05:01:27  *** Kaizen_Kintsugi_ <Kaizen_Kintsugi_!Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745> has quit IRC (Ping timeout: 240 seconds)
 63 2022-06-02T05:03:32  <davidbakin> P.S. for the 64-byte vs 65-byte signature I also see the hash_type in src/script/interpreter.cpp@1687 but still don't know where that shows up in the BIPs
 64 2022-06-02T05:14:37  *** Kaizen_Kintsugi_ <Kaizen_Kintsugi_!Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745> has joined #bitcoin-core-dev
 65 2022-06-02T05:36:39  *** hashfunc1df8 <hashfunc1df8!~user@2601:5c0:c280:7090:30da:f74b:fc0a:7f05> has quit IRC (Remote host closed the connection)
 66 2022-06-02T05:39:18  *** brunoerg <brunoerg!~brunoerg@187.183.43.40> has quit IRC (Ping timeout: 246 seconds)
 67 2022-06-02T05:41:04  *** hashfunc1bb <hashfunc1bb!~user@2601:5c0:c280:7090:30da:f74b:fc0a:7f05> has joined #bitcoin-core-dev
 68 2022-06-02T05:41:11  *** brunoerg <brunoerg!~brunoerg@187.183.43.40> has joined #bitcoin-core-dev
 69 2022-06-02T05:56:13  <laanwj> davidbakin: if you don't get an answer here, you might want to ask in #bitcoin-wizards
 70 2022-06-02T05:57:08  <davidbakin> good idea but first i'll give it a few hours for the world to spin and people to show up here
 71 2022-06-02T05:57:43  <laanwj> sure!
 72 2022-06-02T06:07:04  *** vasild <vasild!~vd@user/vasild> has quit IRC (Ping timeout: 240 seconds)
 73 2022-06-02T06:17:50  *** vasild <vasild!~vd@user/vasild> has joined #bitcoin-core-dev
 74 2022-06-02T06:18:50  *** Kaizen_Kintsugi_ <Kaizen_Kintsugi_!Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745> has quit IRC (Ping timeout: 240 seconds)
 75 2022-06-02T06:18:51  *** sipsorcery <sipsorcery!~sipsorcer@2a02:8084:6180:500::12b> has joined #bitcoin-core-dev
 76 2022-06-02T06:22:48  *** z9z0b3t1_ <z9z0b3t1_!z9z0b3t1c@gateway/vpn/protonvpn/z9z0b3t1c> has joined #bitcoin-core-dev
 77 2022-06-02T06:25:30  *** z9z0b3t1c <z9z0b3t1c!z9z0b3t1c@gateway/vpn/protonvpn/z9z0b3t1c> has quit IRC (Ping timeout: 246 seconds)
 78 2022-06-02T06:31:50  *** Kaizen_Kintsugi_ <Kaizen_Kintsugi_!Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745> has joined #bitcoin-core-dev
 79 2022-06-02T06:33:08  *** vysn <vysn!~vysn@user/vysn> has joined #bitcoin-core-dev
 80 2022-06-02T06:42:44  *** S3RK <S3RK!~S3RK@user/s3rk> has joined #bitcoin-core-dev
 81 2022-06-02T06:46:46  *** brunoerg <brunoerg!~brunoerg@187.183.43.40> has quit IRC (Ping timeout: 258 seconds)
 82 2022-06-02T06:48:15  *** brunoerg <brunoerg!~brunoerg@2804:14d:5281:8ae2:9de3:c88:85ba:eb2b> has joined #bitcoin-core-dev
 83 2022-06-02T06:52:31  *** brunoerg <brunoerg!~brunoerg@2804:14d:5281:8ae2:9de3:c88:85ba:eb2b> has quit IRC (Ping timeout: 244 seconds)
 84 2022-06-02T06:54:25  *** brunoerg <brunoerg!~brunoerg@187.183.43.40> has joined #bitcoin-core-dev
 85 2022-06-02T07:12:55  *** chinggg <chinggg!~chinggg@49.52.96.106> has joined #bitcoin-core-dev
 86 2022-06-02T07:22:34  *** dongcarl <dongcarl!~dongcarl@pool-108-6-233-95.nycmny.fios.verizon.net> has quit IRC (Read error: Connection reset by peer)
 87 2022-06-02T07:24:42  *** chinggg <chinggg!~chinggg@49.52.96.106> has quit IRC (Ping timeout: 252 seconds)
 88 2022-06-02T07:24:51  *** dongcarl <dongcarl!~dongcarl@pool-108-6-233-95.nycmny.fios.verizon.net> has joined #bitcoin-core-dev
 89 2022-06-02T07:25:26  *** hashfunc1bb <hashfunc1bb!~user@2601:5c0:c280:7090:30da:f74b:fc0a:7f05> has quit IRC (Remote host closed the connection)
 90 2022-06-02T07:36:53  *** chinggg <chinggg!~chinggg@101.94.169.49> has joined #bitcoin-core-dev
 91 2022-06-02T07:39:37  *** sipsorcery <sipsorcery!~sipsorcer@2a02:8084:6180:500::12b> has quit IRC (Ping timeout: 260 seconds)
 92 2022-06-02T07:44:52  *** chinggg <chinggg!~chinggg@101.94.169.49> has quit IRC (Ping timeout: 252 seconds)
 93 2022-06-02T07:49:07  *** Kaizen_Kintsugi_ <Kaizen_Kintsugi_!Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745> has quit IRC (Ping timeout: 256 seconds)
 94 2022-06-02T07:51:06  *** sipsorcery <sipsorcery!~sipsorcer@2a02:8084:6180:500::12b> has joined #bitcoin-core-dev
 95 2022-06-02T07:59:03  *** Guyver2 <Guyver2!~Guyver@77-174-98-73.fixed.kpn.net> has joined #bitcoin-core-dev
 96 2022-06-02T07:59:39  *** brunoerg <brunoerg!~brunoerg@187.183.43.40> has quit IRC (Ping timeout: 246 seconds)
 97 2022-06-02T08:02:41  *** Kaizen_Kintsugi_ <Kaizen_Kintsugi_!Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745> has joined #bitcoin-core-dev
 98 2022-06-02T08:06:13  *** brunoerg <brunoerg!~brunoerg@2804:14d:5281:8ae2:9de3:c88:85ba:eb2b> has joined #bitcoin-core-dev
 99 2022-06-02T08:10:41  *** brunoerg <brunoerg!~brunoerg@2804:14d:5281:8ae2:9de3:c88:85ba:eb2b> has quit IRC (Ping timeout: 255 seconds)
100 2022-06-02T08:12:16  *** brunoerg <brunoerg!~brunoerg@2804:14d:5281:8ae2:9de3:c88:85ba:eb2b> has joined #bitcoin-core-dev
101 2022-06-02T08:17:10  *** brunoerg <brunoerg!~brunoerg@2804:14d:5281:8ae2:9de3:c88:85ba:eb2b> has quit IRC (Ping timeout: 260 seconds)
102 2022-06-02T08:17:37  *** brunoerg <brunoerg!~brunoerg@2804:14d:5281:8ae2:9de3:c88:85ba:eb2b> has joined #bitcoin-core-dev
103 2022-06-02T08:18:04  *** yanmaani <yanmaani!~yanmaani@gateway/tor-sasl/yanmaani> has quit IRC (Ping timeout: 240 seconds)
104 2022-06-02T08:25:35  *** chinggg <chinggg!~chinggg@59.79.1.99> has joined #bitcoin-core-dev
105 2022-06-02T08:33:07  *** chinggg <chinggg!~chinggg@59.79.1.99> has quit IRC (Quit: Client closed)
106 2022-06-02T08:37:55  *** sheb <sheb!~sheb@31.223.228.71> has quit IRC (Quit: Leaving)
107 2022-06-02T08:43:09  <luke-jr> davidbakin: https://github.com/bitcoin/bips/blob/master/bip-0341.mediawiki#taproot-key-path-spending-signature-validation
108 2022-06-02T09:03:00  *** kexkey <kexkey!~kexkey@178.249.214.10> has quit IRC (Ping timeout: 246 seconds)
109 2022-06-02T09:06:26  *** kexkey <kexkey!~kexkey@178.249.214.10> has joined #bitcoin-core-dev
110 2022-06-02T09:13:56  *** yanmaani <yanmaani!~yanmaani@gateway/tor-sasl/yanmaani> has joined #bitcoin-core-dev
111 2022-06-02T09:14:44  *** AaronvanW <AaronvanW!~AaronvanW@user/AaronvanW> has joined #bitcoin-core-dev
112 2022-06-02T09:17:33  *** jonatack <jonatack!~jonatack@user/jonatack> has joined #bitcoin-core-dev
113 2022-06-02T09:21:48  *** brunoerg <brunoerg!~brunoerg@2804:14d:5281:8ae2:9de3:c88:85ba:eb2b> has quit IRC (Ping timeout: 250 seconds)
114 2022-06-02T09:28:24  *** brunoerg <brunoerg!~brunoerg@2804:14d:5281:8ae2:9de3:c88:85ba:eb2b> has joined #bitcoin-core-dev
115 2022-06-02T09:57:34  *** vasild <vasild!~vd@user/vasild> has quit IRC (Ping timeout: 240 seconds)
116 2022-06-02T09:59:50  *** jonatack <jonatack!~jonatack@user/jonatack> has quit IRC (Ping timeout: 260 seconds)
117 2022-06-02T10:29:43  *** z9z0b3t1c <z9z0b3t1c!z9z0b3t1c@gateway/vpn/protonvpn/z9z0b3t1c> has joined #bitcoin-core-dev
118 2022-06-02T10:33:20  *** z9z0b3t1_ <z9z0b3t1_!z9z0b3t1c@gateway/vpn/protonvpn/z9z0b3t1c> has quit IRC (Ping timeout: 255 seconds)
119 2022-06-02T10:34:02  *** brunoerg <brunoerg!~brunoerg@2804:14d:5281:8ae2:9de3:c88:85ba:eb2b> has quit IRC (Ping timeout: 260 seconds)
120 2022-06-02T10:35:29  *** brunoerg <brunoerg!~brunoerg@2804:14d:5281:8ae2:9de3:c88:85ba:eb2b> has joined #bitcoin-core-dev
121 2022-06-02T10:40:05  *** brunoerg <brunoerg!~brunoerg@2804:14d:5281:8ae2:9de3:c88:85ba:eb2b> has quit IRC (Ping timeout: 255 seconds)
122 2022-06-02T10:41:33  *** brunoerg <brunoerg!~brunoerg@2804:14d:5281:8ae2:9de3:c88:85ba:eb2b> has joined #bitcoin-core-dev
123 2022-06-02T10:44:12  *** brunoerg <brunoerg!~brunoerg@2804:14d:5281:8ae2:9de3:c88:85ba:eb2b> has quit IRC (Remote host closed the connection)
124 2022-06-02T10:44:14  *** vasild <vasild!~vd@user/vasild> has joined #bitcoin-core-dev
125 2022-06-02T10:49:21  *** brunoerg <brunoerg!~brunoerg@2804:14d:5281:8ae2:9de3:c88:85ba:eb2b> has joined #bitcoin-core-dev
126 2022-06-02T10:53:48  *** brunoerg <brunoerg!~brunoerg@2804:14d:5281:8ae2:9de3:c88:85ba:eb2b> has quit IRC (Ping timeout: 244 seconds)
127 2022-06-02T10:56:35  *** AaronvanW <AaronvanW!~AaronvanW@user/AaronvanW> has quit IRC (Remote host closed the connection)
128 2022-06-02T10:57:10  *** AaronvanW <AaronvanW!~AaronvanW@user/AaronvanW> has joined #bitcoin-core-dev
129 2022-06-02T11:00:00  *** sturles <sturles!~sturles@sauron.uio.no> has quit IRC (Remote host closed the connection)
130 2022-06-02T11:00:08  *** brunoerg <brunoerg!~brunoerg@2804:14d:5281:8ae2:9de3:c88:85ba:eb2b> has joined #bitcoin-core-dev
131 2022-06-02T11:04:23  *** sturles <sturles!~sturles@sauron.uio.no> has joined #bitcoin-core-dev
132 2022-06-02T11:05:39  <bitcoin-git> [bitcoin] theStack opened pull request #25267: test: check `replaceable` mismatch error in `createrawtransaction` RPC (master...202206-test-check_rbf_mismatch_in_createrawtransaction) https://github.com/bitcoin/bitcoin/pull/25267
133 2022-06-02T11:08:00  <bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/1c7ef0abd11f...39ddd522c37f
134 2022-06-02T11:08:00  <bitcoin-git> bitcoin/master fa72e0b MarcoFalke: Use designated initializers
135 2022-06-02T11:08:01  <bitcoin-git> bitcoin/master 39ddd52 MacroFake: Merge bitcoin/bitcoin#24531: Use designated initializers
136 2022-06-02T11:08:06  <bitcoin-git> [bitcoin] MarcoFalke merged pull request #24531: Use designated initializers (master...2203-designated_init-🛍) https://github.com/bitcoin/bitcoin/pull/24531
137 2022-06-02T12:04:45  *** Kaizen_K_ <Kaizen_K_!Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745> has joined #bitcoin-core-dev
138 2022-06-02T12:06:28  *** brunoerg <brunoerg!~brunoerg@2804:14d:5281:8ae2:9de3:c88:85ba:eb2b> has quit IRC (Ping timeout: 258 seconds)
139 2022-06-02T12:08:12  *** Kaizen_Kintsugi_ <Kaizen_Kintsugi_!Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745> has quit IRC (Ping timeout: 272 seconds)
140 2022-06-02T12:08:13  *** brunoerg <brunoerg!~brunoerg@2804:14d:5281:8ae2:9de3:c88:85ba:eb2b> has joined #bitcoin-core-dev
141 2022-06-02T12:09:04  *** bitdex <bitdex!~bitdex@gateway/tor-sasl/bitdex> has quit IRC (Ping timeout: 240 seconds)
142 2022-06-02T12:09:39  *** bitdex <bitdex!~bitdex@gateway/tor-sasl/bitdex> has joined #bitcoin-core-dev
143 2022-06-02T12:12:37  *** brunoerg <brunoerg!~brunoerg@2804:14d:5281:8ae2:9de3:c88:85ba:eb2b> has quit IRC (Ping timeout: 260 seconds)
144 2022-06-02T12:14:23  *** brunoerg <brunoerg!~brunoerg@187.183.43.40> has joined #bitcoin-core-dev
145 2022-06-02T12:19:59  *** Kaizen_K_ <Kaizen_K_!Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745> has quit IRC (Ping timeout: 255 seconds)
146 2022-06-02T12:25:27  *** furszy <furszy!~furszy@user/furszy> has joined #bitcoin-core-dev
147 2022-06-02T12:33:00  *** Kaizen_Kintsugi_ <Kaizen_Kintsugi_!Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745> has joined #bitcoin-core-dev
148 2022-06-02T12:33:34  *** bitdex <bitdex!~bitdex@gateway/tor-sasl/bitdex> has quit IRC (Quit: = "")
149 2022-06-02T12:34:18  <bitcoin-git> [bitcoin] dergoegge opened pull request #25268: refactor: Introduce EvictionManager (master...2022-05-eviction-manager) https://github.com/bitcoin/bitcoin/pull/25268
150 2022-06-02T13:06:04  *** furszy_ <furszy_!~furszy@186.141.201.103> has joined #bitcoin-core-dev
151 2022-06-02T13:06:08  *** furszy_ <furszy_!~furszy@186.141.201.103> has quit IRC (Client Quit)
152 2022-06-02T13:08:30  *** furszy <furszy!~furszy@user/furszy> has quit IRC (Ping timeout: 240 seconds)
153 2022-06-02T13:08:48  *** furszy <furszy!~furszy@user/furszy> has joined #bitcoin-core-dev
154 2022-06-02T13:32:44  <reardencode> davidbakin: 2: The extension is to the `Common Signature Message` which is hashed with hash_TapSighash. 3: https://github.com/bitcoin/bips/blob/master/bip-0341.mediawiki#cite_ref-10-0
155 2022-06-02T13:49:07  *** Victorsueca <Victorsueca!~Victorsue@user/victorsueca> has quit IRC (Ping timeout: 240 seconds)
156 2022-06-02T13:50:34  <sipa> @davidbakin The annex is completely different from the tapscript extension. Annex is defined in BIP341, and is a way to add extra fields to txins generically. The tapscript extension is what is added to the common sighash computation from BIP341 in BIP342 with the tapscript-specific fields.
157 2022-06-02T13:51:29  <sipa> @davidbakin Yes, that low bit is used to communicate the sign of the tweaking equation (Q = P+H(...)G or Q = -(P+H(...)G).
158 2022-06-02T13:55:52  *** AaronvanW <AaronvanW!~AaronvanW@user/AaronvanW> has quit IRC (Remote host closed the connection)
159 2022-06-02T14:02:03  *** erik-etsuji-kato <erik-etsuji-kato!~erik@gateway/tor-sasl/erik-etsuji-kato> has joined #bitcoin-core-dev
160 2022-06-02T14:03:49  <jamesob> Can someone help me understand why this CI job is failing when all others are passing? The compiler error given seems to correspond to old (or otherwise changed) code: https://github.com/bitcoin/bitcoin/pull/24232/checks?check_run_id=6561221006
161 2022-06-02T14:05:29  <jamesob> Oh, may be silent merge conflict... Is the prev-release CI job the only one that rebases branch on top of current master?
162 2022-06-02T14:08:42  <laanwj> afaik all the CI jobs rebase on top of current master
163 2022-06-02T14:08:55  <sipa> merge, not rebase, i assume
164 2022-06-02T14:09:02  <laanwj> merge, yes
165 2022-06-02T14:14:30  <jamesob> Well a rebase revealed the source of the error - but I find it odd that other jobs didn't fail similarly
166 2022-06-02T14:17:20  <bitcoin-git> [bitcoin] furszy opened pull request #25269: wallet: re-activate the not triggered  "AmountWithFeeExceedsBalance" (master...2022_wallet_fix_missing_AmountWithFeeExceedsBalance) https://github.com/bitcoin/bitcoin/pull/25269
167 2022-06-02T14:18:29  <lightlike> jamesob: the other jobs ran 10 days ago, probably before the conflicting PR was merged. The failed one was apparently restarted only 2 days ago.
168 2022-06-02T14:18:57  <jamesob> lightlike: ah, good point
169 2022-06-02T14:26:42  *** AaronvanW <AaronvanW!~AaronvanW@user/AaronvanW> has joined #bitcoin-core-dev
170 2022-06-02T14:27:39  <sipa> davidbakin: (1) luke-jr gave the link to the spec for key path spending in BIP341. For tapscript script path spending it's in BIP342, https://github.com/bitcoin/bips/blob/master/bip-0342.mediawiki#signature-validation
171 2022-06-02T14:30:39  *** z9z0b3t1_ <z9z0b3t1_!z9z0b3t1c@gateway/vpn/protonvpn/z9z0b3t1c> has joined #bitcoin-core-dev
172 2022-06-02T14:34:06  *** z9z0b3t1c <z9z0b3t1c!z9z0b3t1c@gateway/vpn/protonvpn/z9z0b3t1c> has quit IRC (Ping timeout: 246 seconds)
173 2022-06-02T14:34:45  *** sudoforge <sudoforge!~sudoforge@wireguard/tunneler/sudoforge> has joined #bitcoin-core-dev
174 2022-06-02T14:43:20  *** Kaizen_Kintsugi_ <Kaizen_Kintsugi_!Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745> has quit IRC (Ping timeout: 250 seconds)
175 2022-06-02T14:44:50  *** belcher <belcher!~belcher@user/belcher> has quit IRC (Quit: Leaving)
176 2022-06-02T14:54:04  *** bairen <bairen!~bairen@gateway/tor-sasl/bairen> has quit IRC (Ping timeout: 240 seconds)
177 2022-06-02T14:55:29  *** Kaizen_Kintsugi_ <Kaizen_Kintsugi_!Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745> has joined #bitcoin-core-dev
178 2022-06-02T14:58:41  *** furszy <furszy!~furszy@user/furszy> has quit IRC (Quit: Ping timeout (120 seconds))
179 2022-06-02T14:58:58  *** furszy <furszy!~furszy@user/furszy> has joined #bitcoin-core-dev
180 2022-06-02T14:59:50  *** AaronvanW <AaronvanW!~AaronvanW@user/AaronvanW> has quit IRC (Ping timeout: 240 seconds)
181 2022-06-02T15:02:05  *** AaronvanW <AaronvanW!~AaronvanW@user/AaronvanW> has joined #bitcoin-core-dev
182 2022-06-02T15:09:00  *** furszy <furszy!~furszy@user/furszy> has quit IRC (Quit: Client closed)
183 2022-06-02T15:09:49  *** Guest8765 <Guest8765!~Guest87@2603-7000-a701-2362-2f8e-764f-cfc5-4867.res6.spectrum.com> has joined #bitcoin-core-dev
184 2022-06-02T15:14:20  *** Guest8765 <Guest8765!~Guest87@2603-7000-a701-2362-2f8e-764f-cfc5-4867.res6.spectrum.com> has quit IRC (Client Quit)
185 2022-06-02T15:21:46  *** klement <klement!~textual@218.212.82.174> has joined #bitcoin-core-dev
186 2022-06-02T15:31:51  <davidbakin> ok, so the extension is just something that's appended to the SigMsg before it is hashed - it doesn't actually exist as a field in a serialized transaction; but w.r.t. the 64vs65 byte signature - I have seen how you treat them differently in BIP-341 "taproot key path spending sig validation" but I don't see where there or in BIP-340 an explanation of what that 65th byte is when it
187 2022-06-02T15:31:51  <davidbakin> exists - BIP-340 is totally about 64 byte signatures and doesn't know from hash types, so the only thing that I see describes it is the implication from that note 21
188 2022-06-02T15:32:34  <sipa> BIP340 describes a digital signature scheme, it has no notion of sighash types or even anything related to Bitcoin at all.
189 2022-06-02T15:32:58  <davidbakin> oh wait! I see it in the CODE of taproot_sign_key in BIP-341!  Not in descriptive text!
190 2022-06-02T15:33:29  *** jonatack <jonatack!~jonatack@user/jonatack> has joined #bitcoin-core-dev
191 2022-06-02T15:33:29  <sipa> The rules for verifying signatures in the context of taproot key path spends are specified in BIP341. The rules for verifying signatures in the context of tapscript script path spends are in BIP342.
192 2022-06-02T15:33:56  <sipa> davidbakin: It's literally here: https://github.com/bitcoin/bips/blob/master/bip-0341.mediawiki#taproot-key-path-spending-signature-validation
193 2022-06-02T15:34:01  <sipa> To validate a signature sig with public key q:
194 2022-06-02T15:34:06  <sipa> If the sig is 64 bytes long, return Verify(q, hashTapSighash(0x00 || SigMsg(0x00, 0)), sig)[20], where Verify is defined in BIP340.
195 2022-06-02T15:34:10  <sipa> If the sig is 65 bytes long, return sig[64] ≠ 0x00[21] and Verify(q, hashTapSighash(0x00 || SigMsg(sig[64], 0)), sig[0:64]).
196 2022-06-02T15:34:10  <sipa> Otherwise, fail[22].
197 2022-06-02T15:35:08  <sipa> BIP342 has very similar text:
198 2022-06-02T15:35:14  <sipa> To validate a signature sig with public key p:
199 2022-06-02T15:35:18  <sipa> Compute the tapscript message extension ext described above.
200 2022-06-02T15:35:29  <sipa> If the sig is 64 bytes long, return Verify(p, hashTapSighash(0x00 || SigMsg(0x00, 1) || ext), sig), where Verify is defined in BIP340.
201 2022-06-02T15:35:33  <sipa> If the sig is 65 bytes long, return sig[64] ≠ 0x00 and Verify(p, hashTapSighash(0x00 || SigMsg(sig[64], 1) || ext), sig[0:64]).
202 2022-06-02T15:35:36  <sipa> Otherwise, fail.
203 2022-06-02T15:35:53  <sipa> (under https://github.com/bitcoin/bips/blob/master/bip-0342.mediawiki#signature-validation)
204 2022-06-02T15:36:25  <davidbakin> yes sipa I get that!  tells you what to DO with a 65 byte one - doesn't tell you the circumstance when you CREATE one OR that the 65'th byte is the hash type (if non zero).  I hope I'm not being really stupid.
205 2022-06-02T15:37:01  <davidbakin> but I _did_ find it in the CODE of taproot_sign_key not in the descriptive text
206 2022-06-02T15:37:28  <sipa> Oh, the BIPs don't really describe the creation. They're specifying the validation rules, not construction.
207 2022-06-02T15:37:55  <sipa> There is some context that explains common usage, but that's not really the full description of everything one could do with these BIPs... that'd be unbounded.
208 2022-06-02T15:39:42  <sipa> But fair enough, how to sign with specified sighash type might be worth including.
209 2022-06-02T15:39:42  <davidbakin> i do get that but I nevertheless submit that somewhere there could be a little sentence that said in English "signatures are 65 bytes - the 64 bytes from BIP-340 plus the hash-type, unless the hash type is 0 in which case it is elided" - but that's ok it is in the code
210 2022-06-02T15:40:01  <sipa> Agreed.
211 2022-06-02T15:41:54  <davidbakin> however, something NOT in the code, or, AFAICT, in the text, is that the low order bit of the leaf version byte is the parity bit.  Becuase in the code taproot_tweak_pubkey returns it as a multi-valued return (it's the first element of a pair) but in taproot_output_script where that function is _used_ (only place I can see it used) that first element of the pair is thrown away
212 2022-06-02T15:42:42  <sipa> If q ≠ x(Q) or c[0] & 1 ≠ y(Q) mod 2, fail[10].
213 2022-06-02T15:42:53  <sipa> That's where it is used in the specification text.
214 2022-06-02T15:43:04  <sipa> "c[0] & 1" is the parity bit.
215 2022-06-02T15:44:02  <sipa> In the text about construction below it says.
216 2022-06-02T15:44:05  <sipa> To spend this output using script D, the control block would contain the following data in this order:
217 2022-06-02T15:44:13  <sipa> <control byte with leaf version and parity bit> <internal key p> <C> <E> <AB>
218 2022-06-02T15:45:02  <davidbakin> well yes I see that but it's the same issue with obscurity - you've got to really know what's going on before you know what's going on ... for example, right after the line "let v = c[0]&0xfe" and call it the _leaf version_" there could be a line "let pubpar = c[0]&0x1 and call it the _public key parity" - that would sort of help
219 2022-06-02T15:45:05  <sipa> In any case, if you feel there is text that would have made this more clear to you, feel free to open a PR against the BIP.
220 2022-06-02T15:46:16  <davidbakin> ah! didn't know you could do that with PRs that were already accepted - OH WAIT these Taproot PRs are still Draft.  ok, i'll do that and see what the reviewers say (such as you I suppose, eh?)
221 2022-06-02T15:46:44  <sipa> They probably should be moved off being Draft at this point.
222 2022-06-02T15:46:51  *** klement <klement!~textual@218.212.82.174> has quit IRC (Quit: My MacBook has gone to sleep. ZZZzzz…)
223 2022-06-02T15:46:59  <sipa> But even then, clarifications may be accepted if they don't change the specification.
224 2022-06-02T15:47:40  <sipa> BIP changes are approved by the authors of the BIP (and the editor who decides if procedure is followed).
225 2022-06-02T15:50:23  <davidbakin> eeh, I jumped right over that <control byte ... and parity bit> - ok, i'm clear now (at least on this stuff) thank you all!
226 2022-06-02T15:50:39  <davidbakin> (i will do a PR though)
227 2022-06-02T15:50:47  <sipa> Cool, thanks!
228 2022-06-02T15:51:09  *** furszy <furszy!~furszy@user/furszy> has joined #bitcoin-core-dev
229 2022-06-02T15:52:12  *** klement <klement!~textual@218.212.82.174> has joined #bitcoin-core-dev
230 2022-06-02T15:55:48  *** realies <realies!~realies@user/realies> has joined #bitcoin-core-dev
231 2022-06-02T15:58:38  *** vysn <vysn!~vysn@user/vysn> has quit IRC (Ping timeout: 244 seconds)
232 2022-06-02T16:02:13  <sipa> davidbakin: The parity bit is mentioned in the signing code section too, actually:
233 2022-06-02T16:02:16  <sipa> in taproot_sign_script
234 2022-06-02T16:02:23  <sipa> output_pubkey_y_parity, _ = taproot_tweak_pubkey(internal_pubkey, h)
235 2022-06-02T16:02:23  <sipa> pubkey_data = bytes([output_pubkey_y_parity + leaf_version]) + internal_pubkey
236 2022-06-02T16:03:06  <sipa> it's not in taproot_output_script, because the signing bit isn't used at output creation time, only at signing time
237 2022-06-02T16:03:34  <davidbakin> oh that's correct, ok, NVM about that then - it's all in the code - thanks for helping me read correctly!
238 2022-06-02T16:08:51  *** jonatack <jonatack!~jonatack@user/jonatack> has quit IRC (Quit: Connection closed)
239 2022-06-02T16:14:11  *** furszy <furszy!~furszy@user/furszy> has quit IRC (Quit: Ping timeout (120 seconds))
240 2022-06-02T16:14:28  *** furszy <furszy!~furszy@user/furszy> has joined #bitcoin-core-dev
241 2022-06-02T16:18:33  <bitcoin-git> [gui] laanwj opened pull request #613: qt: Remove unnecessary wallet includes from rpcconsole.cpp (master...2022-06-qtconsole-includes) https://github.com/bitcoin-core/gui/pull/613
242 2022-06-02T16:26:17  *** furszy <furszy!~furszy@user/furszy> has quit IRC (Quit: Ping timeout (120 seconds))
243 2022-06-02T16:26:50  *** furszy <furszy!~furszy@user/furszy> has joined #bitcoin-core-dev
244 2022-06-02T16:37:50  *** Kaizen_Kintsugi_ <Kaizen_Kintsugi_!Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745> has quit IRC (Ping timeout: 255 seconds)
245 2022-06-02T16:50:36  *** furszy <furszy!~furszy@user/furszy> has quit IRC ()
246 2022-06-02T16:52:30  *** Talkless <Talkless!~Talkless@mail.dargis.net> has joined #bitcoin-core-dev
247 2022-06-02T16:54:08  *** realies <realies!~realies@user/realies> has quit IRC (Quit: ~)
248 2022-06-02T17:05:12  <bitcoin-git> [bitcoin] laanwj pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/39ddd522c37f...636991d0c0f9
249 2022-06-02T17:05:12  <bitcoin-git> bitcoin/master a4741bd Cory Fields: kernel: pass params to BlockManager rather than using a global
250 2022-06-02T17:05:13  <bitcoin-git> bitcoin/master 636991d laanwj: Merge bitcoin/bitcoin#25264: kernel: pass params to BlockManager rather th...
251 2022-06-02T17:05:16  <bitcoin-git> [bitcoin] laanwj merged pull request #25264: kernel: pass params to BlockManager rather than using a global (master...no-kernel-global-params) https://github.com/bitcoin/bitcoin/pull/25264
252 2022-06-02T17:09:01  <bitcoin-git> [bitcoin] laanwj pushed 6 commits to master: https://github.com/bitcoin/bitcoin/compare/636991d0c0f9...a100c42a136d
253 2022-06-02T17:09:01  <bitcoin-git> bitcoin/master d7d9c7b glozow: [test util] add chain name to TestChain100Setup ctor
254 2022-06-02T17:09:01  <bitcoin-git> bitcoin/master 5374dfc glozow: [test util] use -checkmempool for TestingSetup mempool check ratio
255 2022-06-02T17:09:02  <bitcoin-git> bitcoin/master 2118750 glozow: [test util] to populate mempool with random transactions/packages
256 2022-06-02T17:09:04  <bitcoin-git> [bitcoin] laanwj merged pull request #24927: Add test util to populate mempool with random transactions, fix #24634 bug (master...2022-04-test-util-populate-mempool) https://github.com/bitcoin/bitcoin/pull/24927
257 2022-06-02T17:10:05  *** z9z0b3t1c <z9z0b3t1c!~z9z0b3t1c@145.224.65.12> has joined #bitcoin-core-dev
258 2022-06-02T17:10:19  *** realies <realies!~realies@user/realies> has joined #bitcoin-core-dev
259 2022-06-02T17:11:06  *** jarthur <jarthur!~jarthur@user/jarthur> has joined #bitcoin-core-dev
260 2022-06-02T17:12:20  *** klement <klement!~textual@218.212.82.174> has quit IRC (Quit: My MacBook has gone to sleep. ZZZzzz…)
261 2022-06-02T17:12:30  *** z9z0b3t1c <z9z0b3t1c!~z9z0b3t1c@145.224.65.12> has quit IRC (Client Quit)
262 2022-06-02T17:12:57  *** z9z0b3t1_ <z9z0b3t1_!z9z0b3t1c@gateway/vpn/protonvpn/z9z0b3t1c> has quit IRC (Ping timeout: 256 seconds)
263 2022-06-02T17:20:27  <bitcoin-git> [gui] hebasto merged pull request #613: Remove unnecessary wallet includes from rpcconsole.cpp (master...2022-06-qtconsole-includes) https://github.com/bitcoin-core/gui/pull/613
264 2022-06-02T17:20:30  <bitcoin-git> [bitcoin] hebasto pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/a100c42a136d...da6792b2eb6a
265 2022-06-02T17:20:30  <bitcoin-git> bitcoin/master 0994273 laanwj: qt: Remove unnecessary wallet includes from rpcconsole.cpp
266 2022-06-02T17:20:31  <bitcoin-git> bitcoin/master da6792b Hennadii Stepanov: Merge bitcoin-core/gui#613: Remove unnecessary wallet includes from rpccon...
267 2022-06-02T17:22:02  *** z9z0b3t1c <z9z0b3t1c!z9z0b3t1c@gateway/vpn/protonvpn/z9z0b3t1c> has joined #bitcoin-core-dev
268 2022-06-02T17:33:00  *** Guyver2 <Guyver2!~Guyver@77-174-98-73.fixed.kpn.net> has left #bitcoin-core-dev (Closing Window)
269 2022-06-02T17:36:37  *** realies <realies!~realies@user/realies> has quit IRC (Quit: ~)
270 2022-06-02T17:37:01  <bitcoin-git> [gui] hebasto merged pull request #583: Add translator comments to `TransactionDesc::FormatTxStatus` (master...translator_comments_transactiondesc) https://github.com/bitcoin-core/gui/pull/583
271 2022-06-02T17:37:29  <bitcoin-git> [bitcoin] hebasto pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/da6792b2eb6a...b11ab25afb44
272 2022-06-02T17:37:30  <bitcoin-git> bitcoin/master 8cfb562 w0xlt: qt, refactor: add translator comments in `TransactionDesc::FormatTxStatus(...
273 2022-06-02T17:37:30  <bitcoin-git> bitcoin/master b11ab25 Hennadii Stepanov: Merge bitcoin-core/gui#583: Add translator comments to `TransactionDesc::F...
274 2022-06-02T17:45:51  *** realies <realies!~realies@user/realies> has joined #bitcoin-core-dev
275 2022-06-02T17:50:01  *** bomb-on <bomb-on!~bomb-on@user/bomb-on> has joined #bitcoin-core-dev
276 2022-06-02T17:51:06  *** z9z0b3t1_ <z9z0b3t1_!~z9z0b3t1c@145.224.65.12> has joined #bitcoin-core-dev
277 2022-06-02T17:54:22  *** z9z0b3t1c <z9z0b3t1c!z9z0b3t1c@gateway/vpn/protonvpn/z9z0b3t1c> has quit IRC (Ping timeout: 244 seconds)
278 2022-06-02T18:00:13  *** kouloumos <kouloumos!uid539228@id-539228.tinside.irccloud.com> has joined #bitcoin-core-dev
279 2022-06-02T18:08:48  *** z9z0b3t1_ <z9z0b3t1_!~z9z0b3t1c@145.224.65.12> has quit IRC (Remote host closed the connection)
280 2022-06-02T18:09:23  *** z9z0b3t1c <z9z0b3t1c!z9z0b3t1c@gateway/vpn/protonvpn/z9z0b3t1c> has joined #bitcoin-core-dev
281 2022-06-02T18:18:59  *** Guest36 <Guest36!~Guest36@92.44.103.246> has joined #bitcoin-core-dev
282 2022-06-02T18:22:01  *** Guest36 <Guest36!~Guest36@92.44.103.246> has quit IRC (Client Quit)
283 2022-06-02T18:29:25  *** jonatack <jonatack!~jonatack@user/jonatack> has joined #bitcoin-core-dev
284 2022-06-02T18:43:45  <bitcoin-git> [bitcoin] laanwj pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/b11ab25afb44...1f63b460a850
285 2022-06-02T18:43:45  <bitcoin-git> bitcoin/master 1bace0c Sebastian Falbesoner: test: check `replaceable` mismatch error in `createrawtransaction` RPC
286 2022-06-02T18:43:46  <bitcoin-git> bitcoin/master 1f63b46 laanwj: Merge bitcoin/bitcoin#25267: test: check `replaceable` mismatch error in `...
287 2022-06-02T18:43:47  <bitcoin-git> [bitcoin] laanwj merged pull request #25267: test: check `replaceable` mismatch error in `createrawtransaction` RPC (master...202206-test-check_rbf_mismatch_in_createrawtransaction) https://github.com/bitcoin/bitcoin/pull/25267
288 2022-06-02T18:51:04  <sdaftuar> hi maintainers, #24171 may be ready for merge? (or if it needs re-acks since it was last rebased, i can ping the previous reviewers)
289 2022-06-02T18:51:06  <gribble> https://github.com/bitcoin/bitcoin/issues/24171 | p2p: Sync chain more readily from inbound peers during IBD by sdaftuar · Pull Request #24171 · bitcoin/bitcoin · GitHub
290 2022-06-02T18:55:21  <_aj_> sdaftuar: front running the meeting, eh?
291 2022-06-02T18:56:12  <sdaftuar> oh i forgot about the meeting!  also going afk in a few minutes
292 2022-06-02T18:58:49  <laanwj> sdaftuar: thanks, will take a look
293 2022-06-02T19:00:28  <laanwj> #startmeeting
294 2022-06-02T19:00:47  <jonatack> hi
295 2022-06-02T19:00:53  <hebasto> hi
296 2022-06-02T19:01:05  <laanwj> #bitcoin-core-dev Meeting: achow101 _aj_ amiti ariard b10c BlueMatt cfields Chris_Stewart_5 darosior digi_james dongcarl elichai2 emilengler fanquake fjahr gleb glozow gmaxwell gwillen hebasto instagibbs jamesob jarolrod jb55 jeremyrubin jl2012 jnewbery jonasschnelli jonatack jtimon kallewoof kanzure kvaciral laanwj larryruane lightlike luke-jr maaku marcofalke meshcollider michagogo
297 2022-06-02T19:01:06  <laanwj> moneyball morcos nehan NicolasDorier paveljanik petertodd phantomcircuit promag provoostenator ryanofsky sdaftuar sipa vasild
298 2022-06-02T19:01:29  *** mrlemke <mrlemke!~mrlemke@208.74.105.200> has quit IRC (Quit: Leaving)
299 2022-06-02T19:01:37  <luke-jr> hi
300 2022-06-02T19:01:48  <dongcarl> hi
301 2022-06-02T19:01:55  <lightlike> hi
302 2022-06-02T19:01:58  <laanwj> welcome to the weekly general bitcoin-core-dev meeting
303 2022-06-02T19:02:17  <laanwj> there have been no topics proposed in advance (you can propose meeting topics with #proposedmeetingtopic <topic> during any time of the week)
304 2022-06-02T19:02:27  <laanwj> any last minute topics?
305 2022-06-02T19:02:29  <sipa> hi
306 2022-06-02T19:02:33  <_aj_> hi
307 2022-06-02T19:03:27  <sipa> #25096 may be close to ready too
308 2022-06-02T19:03:27  <Murch> Hi
309 2022-06-02T19:03:28  <gribble> https://github.com/bitcoin/bitcoin/issues/25096 | [net] Minor improvements to addr caching by dergoegge · Pull Request #25096 · bitcoin/bitcoin · GitHub
310 2022-06-02T19:04:04  <laanwj> sipa: good to know!
311 2022-06-02T19:04:14  <jeremyrubin> hi
312 2022-06-02T19:04:59  *** Cory <Cory!~Cory@user/pasha> has quit IRC (Ping timeout: 255 seconds)
313 2022-06-02T19:05:11  <laanwj> #topic High priority for review
314 2022-06-02T19:05:49  <laanwj> https://github.com/bitcoin/bitcoin/projects/8  | currently we have 10 blocker PRs, 2 chasing concept ACK
315 2022-06-02T19:06:15  <laanwj> does anyone want to add a PR, or remove it
316 2022-06-02T19:06:15  <b10c> hi
317 2022-06-02T19:07:38  <laanwj> or anything else that is almost ready for merge?
318 2022-06-02T19:08:13  <dongcarl> I think #25065 is almost ready for merge, but that's on the high prio list already
319 2022-06-02T19:08:16  <_aj_> #24931 is close i think
320 2022-06-02T19:08:16  <gribble> https://github.com/bitcoin/bitcoin/issues/25065 | [kernel 2c/n] Introduce `kernel::Context`, encapsulate global init/teardown by dongcarl · Pull Request #25065 · bitcoin/bitcoin · GitHub
321 2022-06-02T19:08:19  <gribble> https://github.com/bitcoin/bitcoin/issues/24931 | Strengthen thread safety assertions by ajtowns · Pull Request #24931 · bitcoin/bitcoin · GitHub
322 2022-06-02T19:08:33  <laanwj> dongcarl: _aj_  thanks
323 2022-06-02T19:09:47  <laanwj> is there anything else that people would like to discuss?
324 2022-06-02T19:10:18  <_aj_> would it be good to add a "what people are working on" section to the meeting every now and then?
325 2022-06-02T19:10:40  <dongcarl> ACK
326 2022-06-02T19:10:49  <laanwj> sure, if you'd like that
327 2022-06-02T19:10:50  *** vysn <vysn!~vysn@user/vysn> has joined #bitcoin-core-dev
328 2022-06-02T19:11:22  <laanwj> #topic What are people working on
329 2022-06-02T19:11:42  <sipa> ACK topic :)
330 2022-06-02T19:11:43  <_aj_> we had the lightnign summit the past few days; which will presumably have the notes published sometime. seems like there'll be progress getting funding txs moved to taproot / musig2; also a bunch of discussions about rbf and package relay ideas
331 2022-06-02T19:12:22  <laanwj> oh, neat!
332 2022-06-02T19:13:19  <_aj_> instagibbs in particular is working on actually implementing eltoo as his job(!) so working on getting an anyprevout testbed for him to build that on
333 2022-06-02T19:13:57  <dongcarl> woah that's awesome if he can pull it off
334 2022-06-02T19:14:00  <sipa> I've been working on writing a "production" codebase in Python for working with asmap on https://github.com/sipa/asmap/commits/nextgen. It currently has a module that can decode/encode/diff binary asmap files, tests, command-line tools for interfacing with that, plus gathering/collecting/processing BGP dump files into asmap.
335 2022-06-02T19:14:28  <sipa> It still needs some polishing, but it's getting there, at which points I'll be pinging some people for review.
336 2022-06-02T19:15:52  <laanwj> we've already been using the new Python asmap module in #24864, to replace the DNS based ASN lookup for the hardcoded seeds
337 2022-06-02T19:15:54  <gribble> https://github.com/bitcoin/bitcoin/issues/24864 | contrib: Use asmap for ASN lookup in makeseeds by laanwj · Pull Request #24864 · bitcoin/bitcoin · GitHub
338 2022-06-02T19:16:03  <jonatack> great stuff all, good to hear
339 2022-06-02T19:16:18  <sipa> Also continued review of the PRs darosior has been working on to get Miniscript integrated into Bitcoin Core.
340 2022-06-02T19:17:11  <sipa> Also, spec work on BIP324 (v2 p2p transport) with dhruv and real_or_random, hopefully public soon.
341 2022-06-02T19:18:23  <sipa> Oh, and I did a writeup on optional, private, authentication protocols like Countersign: https://github.com/sipa/writeups/tree/main/private-authentication-protocols. Actually proposing something like that is a way off, as I think it needs more academic rigour first (but that's being worked on too).
342 2022-06-02T19:18:34  <laanwj> speaking of that i've reviewed one of the BIP324 PRs today (#20962)
343 2022-06-02T19:18:37  <gribble> https://github.com/bitcoin/bitcoin/issues/20962 | Alter the ChaCha20Poly1305@Bitcoin AEAD to the new specification by jonasschnelli · Pull Request #20962 · bitcoin/bitcoin · GitHub
344 2022-06-02T19:20:00  <laanwj> interesting, good to hear the authentication side is also still being worked on
345 2022-06-02T19:20:16  *** Talkless <Talkless!~Talkless@mail.dargis.net> has quit IRC (Quit: Konversation terminated!)
346 2022-06-02T19:22:11  <laanwj> thanks for the updates _aj_  dongcarl and sipa
347 2022-06-02T19:22:58  <laanwj> anyone else that'd like to discuss what they're working on? any other topics?
348 2022-06-02T19:23:21  <dongcarl> I think we can probably have these "what are people working on" things as a convention for after the meeting? Don't want it to impose a burden on laanwj.
349 2022-06-02T19:23:57  <jeremyrubin> i think it would be good to have regular updates from each maintainer on how they are prioritizing their time / what PRs they are focused on merging?
350 2022-06-02T19:24:03  <laanwj> it doesn't burden me to discuss it during the meeting really, also we have very few topics lately
351 2022-06-02T19:24:34  <dongcarl> laanwj: Okay cool!
352 2022-06-02T19:25:05  <_aj_> i'd love to hear what fanquake/laanqj/marco are prioritising (assumign it's something specific not just highpri and things people say are rfm of course)
353 2022-06-02T19:25:12  <_aj_> laanwj
354 2022-06-02T19:25:48  <laanwj> i've been looking into BIP324, and catching up with the libbitcoin kernel stuff
355 2022-06-02T19:26:30  <_aj_> (the qml gui stuff seems interesting and i hadn't been aware of it at all)
356 2022-06-02T19:26:53  <hebasto> _aj_: thanks!
357 2022-06-02T19:27:29  <dongcarl> hebasto: you think it's possible we'll use qt6 some day?
358 2022-06-02T19:27:35  <laanwj> i've also tried to review #22702 but it scared me a bit
359 2022-06-02T19:27:37  <gribble> https://github.com/bitcoin/bitcoin/issues/22702 | Add allocator for node based containers by martinus · Pull Request #22702 · bitcoin/bitcoin · GitHub
360 2022-06-02T19:27:53  *** vysn <vysn!~vysn@user/vysn> has quit IRC (Ping timeout: 244 seconds)
361 2022-06-02T19:28:15  <hebasto> dongcarl: maybe switching to cmake will help a lot
362 2022-06-02T19:28:49  *** realies <realies!~realies@user/realies> has quit IRC (Quit: ~)
363 2022-06-02T19:29:01  <hebasto> as cmake is "native" for Qt 6, besides other benefits, of course
364 2022-06-02T19:29:33  <jonatack> laanwj: read your feedback, i've been remiss in not re-reviewing that one yet but it seems like a valuable performance improvement. Do you think it's too dangerous, or it needs more testing and eyes?
365 2022-06-02T19:29:34  <_aj_> is switching to cmake likely or pie-in-the-sky? if likely, is there a gentle introduction to cmake somewhere? :)
366 2022-06-02T19:30:20  <laanwj> jonatack: the performance improvement is very nice but it's so tricky
367 2022-06-02T19:30:30  <sipa> @laanwj I need to look at the latest code changes again, but I'm very concept ACK on that allocator.
368 2022-06-02T19:30:32  <jonatack> laanwj: (have been running it without issues as well)
369 2022-06-02T19:30:46  <hebasto> _aj_: https://github.com/hebasto/bitcoin/tree/cmake/test
370 2022-06-02T19:31:18  <hebasto> https://gist.github.com/hebasto/aac97d2f6b18c4ec2ad951baeb1ac00c
371 2022-06-02T19:31:44  <sipa> IIRC my biggest gripes with it were code organization related things.
372 2022-06-02T19:33:35  <_aj_> hebasto: oh, if dlls "just work" that is a big side benefit
373 2022-06-02T19:33:56  <hebasto> _aj_: indeed :)
374 2022-06-02T19:33:58  <laanwj> i'm just afraid that we'll mess up somewhere with this kind of low level allocation handling, to be clear i'm not against it, but we need to be really sure it gets enough review, that we even have enough developers that can review code like that
375 2022-06-02T19:34:29  <_aj_> laanwj: maybe we should do an advanced version of the pr review club on it?
376 2022-06-02T19:34:38  <laanwj> _aj_: yeah maybe!
377 2022-06-02T19:35:08  <jonatack> sipa: thanks, good to know. Last time I looked it appeared to have been reworked to an extent that a diff review wasn't too feasible, needed a full re-review for me
378 2022-06-02T19:35:19  <laanwj> dlls don't 'just work' i dont believe u!
379 2022-06-02T19:35:34  <sipa> haha
380 2022-06-02T19:35:59  <hebasto> laanwj: feedback is always welcome :)
381 2022-06-02T19:36:16  <laanwj> speaking of dlls, i wonder if we can stop exporting unnecessary symbols from libbitcoin_consensus, it exports all kinds of c++ library symbols at the moment
382 2022-06-02T19:36:19  *** realies <realies!~realies@user/realies> has joined #bitcoin-core-dev
383 2022-06-02T19:36:52  <laanwj> e.g. https://github.com/bitcoin/bitcoin/pull/25020#issuecomment-1142151675
384 2022-06-02T19:37:56  <luke-jr> dlls just work with autotools too <.<
385 2022-06-02T19:38:26  <hebasto> luke-jr: #19772
386 2022-06-02T19:38:27  <gribble> https://github.com/bitcoin/bitcoin/issues/19772 | build: Cross-compiling libbitcoinconsensus for Windows fails with DEBUG=1 · Issue #19772 · bitcoin/bitcoin · GitHub
387 2022-06-02T19:39:09  <luke-jr> "fully static DLLs" is not a normal thing
388 2022-06-02T19:39:32  *** Kaizen_Kintsugi_ <Kaizen_Kintsugi_!Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745> has joined #bitcoin-core-dev
389 2022-06-02T19:39:33  <laanwj> ideally we'd only export bitcoinconsensus_*, _init and _fini, nothing more
390 2022-06-02T19:43:20  <laanwj> i guess that concludes the meeting, thanks for attending everyone
391 2022-06-02T19:43:25  <laanwj> #endmeeting
392 2022-06-02T19:45:49  *** Guest38 <Guest38!~Guest38@80.208.68.183> has joined #bitcoin-core-dev
393 2022-06-02T19:46:05  *** Guest38 <Guest38!~Guest38@80.208.68.183> has quit IRC (Client Quit)
394 2022-06-02T19:58:49  *** Kaizen_Kintsugi_ <Kaizen_Kintsugi_!Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745> has quit IRC (Remote host closed the connection)
395 2022-06-02T20:11:40  <jarolrod> seems like my bouncer wasn't working before
396 2022-06-02T20:11:48  *** Kaizen_Kintsugi_ <Kaizen_Kintsugi_!Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745> has joined #bitcoin-core-dev
397 2022-06-02T20:12:34  <jarolrod> _aj_: thanks! we took a little break in the middle, but we've picked up steam on the qml gui again, and hope to have something to showcase to the community fairly soon
398 2022-06-02T20:35:27  <bitcoin-git> [bitcoin] laanwj pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/1f63b460a850...00ce8543f16f
399 2022-06-02T20:35:27  <bitcoin-git> bitcoin/master 0569b5c Suhas Daftuar: Sync chain more readily from inbound peers during IBD
400 2022-06-02T20:35:27  <bitcoin-git> bitcoin/master 48262a0 Suhas Daftuar: Add functional test for block sync from inbound peers
401 2022-06-02T20:35:28  <bitcoin-git> bitcoin/master 00ce854 laanwj: Merge bitcoin/bitcoin#24171: p2p: Sync chain more readily from inbound pee...
402 2022-06-02T20:35:33  <bitcoin-git> [bitcoin] laanwj merged pull request #24171: p2p: Sync chain more readily from inbound peers during IBD (master...2022-01-download-from-inbound) https://github.com/bitcoin/bitcoin/pull/24171
403 2022-06-02T20:43:41  *** Kaizen_Kintsugi_ <Kaizen_Kintsugi_!Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745> has quit IRC (Remote host closed the connection)
404 2022-06-02T21:11:37  *** BUSY <BUSY!~BUSY@user/busy> has quit IRC (Ping timeout: 260 seconds)
405 2022-06-02T21:27:32  *** AaronvanW <AaronvanW!~AaronvanW@user/AaronvanW> has quit IRC (Quit: Leaving...)
406 2022-06-02T21:39:32  *** kouloumos <kouloumos!uid539228@id-539228.tinside.irccloud.com> has quit IRC (Quit: Connection closed for inactivity)
407 2022-06-02T22:11:42  *** sipsorcery <sipsorcery!~sipsorcer@2a02:8084:6180:500::12b> has quit IRC (Ping timeout: 260 seconds)
408 2022-06-02T22:21:08  *** brunoerg <brunoerg!~brunoerg@187.183.43.40> has quit IRC (Remote host closed the connection)
409 2022-06-02T22:21:35  *** brunoerg <brunoerg!~brunoerg@2804:14d:5281:8ae2:e575:a235:e99d:672b> has joined #bitcoin-core-dev
410 2022-06-02T22:26:20  *** brunoerg <brunoerg!~brunoerg@2804:14d:5281:8ae2:e575:a235:e99d:672b> has quit IRC (Ping timeout: 272 seconds)
411 2022-06-02T22:29:01  *** bairen <bairen!~bairen@gateway/tor-sasl/bairen> has joined #bitcoin-core-dev
412 2022-06-02T22:32:47  *** vasild_ <vasild_!~vd@user/vasild> has joined #bitcoin-core-dev
413 2022-06-02T22:33:40  *** z9z0b3t1_ <z9z0b3t1_!z9z0b3t1c@gateway/vpn/protonvpn/z9z0b3t1c> has joined #bitcoin-core-dev
414 2022-06-02T22:36:04  *** vasild <vasild!~vd@user/vasild> has quit IRC (Ping timeout: 240 seconds)
415 2022-06-02T22:36:45  *** z9z0b3t1c <z9z0b3t1c!z9z0b3t1c@gateway/vpn/protonvpn/z9z0b3t1c> has quit IRC (Ping timeout: 246 seconds)
416 2022-06-02T22:46:49  *** yanmaani <yanmaani!~yanmaani@gateway/tor-sasl/yanmaani> has quit IRC (Remote host closed the connection)
417 2022-06-02T22:51:34  *** mudsip <mudsip!~mudsip@user/mudsip> has joined #bitcoin-core-dev
418 2022-06-02T22:59:03  *** mudsip <mudsip!~mudsip@user/mudsip> has quit IRC ()
419 2022-06-02T23:00:28  *** vysn <vysn!~vysn@user/vysn> has joined #bitcoin-core-dev
420 2022-06-02T23:00:44  *** yanmaani <yanmaani!~yanmaani@gateway/tor-sasl/yanmaani> has joined #bitcoin-core-dev
421 2022-06-02T23:07:22  *** Kaizen_Kintsugi_ <Kaizen_Kintsugi_!Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745> has joined #bitcoin-core-dev
422 2022-06-02T23:11:30  *** Kaizen_Kintsugi_ <Kaizen_Kintsugi_!Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745> has quit IRC (Ping timeout: 240 seconds)
423 2022-06-02T23:12:45  *** brunoerg <brunoerg!~brunoerg@2804:14d:5281:8ae2:e575:a235:e99d:672b> has joined #bitcoin-core-dev
424 2022-06-02T23:15:52  *** Kaizen_Kintsugi_ <Kaizen_Kintsugi_!Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745> has joined #bitcoin-core-dev
425 2022-06-02T23:17:18  *** brunoerg <brunoerg!~brunoerg@2804:14d:5281:8ae2:e575:a235:e99d:672b> has quit IRC (Ping timeout: 258 seconds)
426 2022-06-02T23:21:03  *** Kaizen_Kintsugi_ <Kaizen_Kintsugi_!Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745> has quit IRC (Ping timeout: 276 seconds)
427 2022-06-02T23:22:27  *** vysn <vysn!~vysn@user/vysn> has quit IRC (Ping timeout: 240 seconds)
428 2022-06-02T23:37:59  *** Kaizen_Kintsugi_ <Kaizen_Kintsugi_!Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745> has joined #bitcoin-core-dev
429 2022-06-02T23:41:18  *** klement <klement!~textual@218.212.82.174> has joined #bitcoin-core-dev
430 2022-06-02T23:43:05  *** Kaizen_Kintsugi_ <Kaizen_Kintsugi_!Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745> has quit IRC (Ping timeout: 255 seconds)
431 2022-06-02T23:46:32  *** Alina-malina <Alina-malina!~Alina-mal@user/alina-malina> has quit IRC (Ping timeout: 248 seconds)
432 2022-06-02T23:48:26  *** brunoerg <brunoerg!~brunoerg@187.183.43.40> has joined #bitcoin-core-dev
433 2022-06-02T23:50:51  *** bomb-on <bomb-on!~bomb-on@user/bomb-on> has quit IRC (Quit: aллилѹіа!)
434 2022-06-02T23:52:57  *** brunoerg <brunoerg!~brunoerg@187.183.43.40> has quit IRC (Ping timeout: 258 seconds)
435 2022-06-02T23:53:16  *** klement <klement!~textual@218.212.82.174> has quit IRC (Quit: My MacBook has gone to sleep. ZZZzzz…)