12022-09-13T00:03:10 *** _apex_ <_apex_!~apex@dynamic-acs-24-144-190-15.zoominternet.net> has joined #bitcoin-core-dev
22022-09-13T00:07:49 *** _apex_ <_apex_!~apex@dynamic-acs-24-144-190-15.zoominternet.net> has quit IRC (Ping timeout: 250 seconds)
32022-09-13T00:19:36 *** ziggie <ziggie!uid521459@user/ziggie> has quit IRC (Quit: Connection closed for inactivity)
42022-09-13T00:25:27 *** Kaizen_Kintsugi_ <Kaizen_Kintsugi_!Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745> has quit IRC (Remote host closed the connection)
52022-09-13T00:36:55 *** Kaizen_Kintsugi_ <Kaizen_Kintsugi_!Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745> has joined #bitcoin-core-dev
62022-09-13T00:45:00 *** _apex_ <_apex_!~apex@dynamic-acs-24-144-190-15.zoominternet.net> has joined #bitcoin-core-dev
72022-09-13T00:54:42 *** Kaizen_Kintsugi_ <Kaizen_Kintsugi_!Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745> has quit IRC (Remote host closed the connection)
82022-09-13T01:11:38 *** micha_ <micha_!uid14316@user/michagogo> has quit IRC (Quit: Connection closed for inactivity)
92022-09-13T01:24:32 *** micha_ <micha_!uid14316@user/michagogo> has joined #bitcoin-core-dev
102022-09-13T01:50:48 *** _apex_ <_apex_!~apex@dynamic-acs-24-144-190-15.zoominternet.net> has quit IRC (Ping timeout: 264 seconds)
112022-09-13T02:00:01 *** upekkha <upekkha!~Advanced@2a01:4f8:1c0c:49df::1> has quit IRC (Quit: upekkha)
122022-09-13T02:00:38 *** upekkha <upekkha!~Advanced@2a01:4f8:1c0c:49df::1> has joined #bitcoin-core-dev
132022-09-13T02:02:54 <jarolrod> provoostenator: i just finished syncing from master on a couple of different test machines, including a 2020 intel macbook pro, maybe overheating issues with your macbook?
142022-09-13T02:05:02 *** hashfunc <hashfunc!~user@2601:5c0:c280:7090:83:ebf7:f91d:450a> has joined #bitcoin-core-dev
152022-09-13T02:08:39 *** halosghost <halosghost!~halosghos@user/halosghost> has quit IRC (Quit: WeeChat 3.6)
162022-09-13T02:17:07 *** mikehu44 <mikehu44!~quassel@159.65.11.175> has joined #bitcoin-core-dev
172022-09-13T02:21:00 *** _apex_ <_apex_!~apex@dynamic-acs-24-144-190-15.zoominternet.net> has joined #bitcoin-core-dev
182022-09-13T02:25:25 *** _apex_ <_apex_!~apex@dynamic-acs-24-144-190-15.zoominternet.net> has quit IRC (Ping timeout: 252 seconds)
192022-09-13T02:53:14 *** vasild <vasild!~vd@user/vasild> has quit IRC (Remote host closed the connection)
202022-09-13T02:53:40 *** vasild <vasild!~vd@user/vasild> has joined #bitcoin-core-dev
212022-09-13T02:54:09 *** chipxxx <chipxxx!~chip@pop.92-184-110-22.mobile.abo.orange.fr> has joined #bitcoin-core-dev
222022-09-13T02:59:01 *** _apex_ <_apex_!~apex@dynamic-acs-24-144-190-15.zoominternet.net> has joined #bitcoin-core-dev
232022-09-13T03:04:36 *** _apex_ <_apex_!~apex@dynamic-acs-24-144-190-15.zoominternet.net> has quit IRC (Ping timeout: 264 seconds)
242022-09-13T03:41:38 *** micha_ <micha_!uid14316@user/michagogo> has quit IRC (Quit: Connection closed for inactivity)
252022-09-13T03:44:32 *** mikehu44 <mikehu44!~quassel@159.65.11.175> has quit IRC (Read error: Connection reset by peer)
262022-09-13T03:48:48 *** mikehu44 <mikehu44!~quassel@159.65.11.175> has joined #bitcoin-core-dev
272022-09-13T03:58:00 *** mikehu44 <mikehu44!~quassel@159.65.11.175> has quit IRC (Ping timeout: 264 seconds)
282022-09-13T03:58:45 *** mikehu44 <mikehu44!~quassel@159.65.11.175> has joined #bitcoin-core-dev
292022-09-13T04:01:01 *** cmirror <cmirror!~cmirror@4.53.92.114> has quit IRC (Remote host closed the connection)
302022-09-13T04:01:32 *** cmirror <cmirror!~cmirror@4.53.92.114> has joined #bitcoin-core-dev
312022-09-13T04:07:05 *** mikehu44 <mikehu44!~quassel@159.65.11.175> has quit IRC (Quit: https://quassel-irc.org - Chat comfortably. Anywhere.)
322022-09-13T04:22:50 *** nanotube <nanotube!~nanotube@user/nanotube> has joined #bitcoin-core-dev
332022-09-13T05:00:45 *** _apex_ <_apex_!~apex@dynamic-acs-24-144-190-15.zoominternet.net> has joined #bitcoin-core-dev
342022-09-13T05:05:17 *** _apex_ <_apex_!~apex@dynamic-acs-24-144-190-15.zoominternet.net> has quit IRC (Ping timeout: 252 seconds)
352022-09-13T05:12:15 *** gleb1068924 <gleb1068924!~gleb@178.150.137.228> has quit IRC (Ping timeout: 265 seconds)
362022-09-13T06:01:05 *** chip_x <chip_x!~chip@pop.92-184-102-83.mobile.abo.orange.fr> has joined #bitcoin-core-dev
372022-09-13T06:03:35 *** chipxxx <chipxxx!~chip@pop.92-184-110-22.mobile.abo.orange.fr> has quit IRC (Ping timeout: 252 seconds)
382022-09-13T06:25:36 *** hashfunc <hashfunc!~user@2601:5c0:c280:7090:83:ebf7:f91d:450a> has quit IRC (Ping timeout: 264 seconds)
392022-09-13T06:27:09 *** chip_x <chip_x!~chip@pop.92-184-102-83.mobile.abo.orange.fr> has quit IRC (Read error: Connection reset by peer)
402022-09-13T06:45:33 *** vasild <vasild!~vd@user/vasild> has quit IRC (Remote host closed the connection)
412022-09-13T06:54:38 <provoostenator> jarolrod: it rebooted itself last night so I can't even use ldb on it. Ready for recycling.
422022-09-13T07:00:04 *** vasild <vasild!~vd@user/vasild> has joined #bitcoin-core-dev
432022-09-13T07:05:38 *** vasild <vasild!~vd@user/vasild> has quit IRC (Ping timeout: 258 seconds)
442022-09-13T07:19:36 *** Guyver2 <Guyver2!~Guyver@77-174-98-73.fixed.kpn.net> has joined #bitcoin-core-dev
452022-09-13T07:21:54 *** sipsorcery <sipsorcery!~sipsorcer@2a02:8084:6180:500::12b> has joined #bitcoin-core-dev
462022-09-13T07:53:11 *** _apex_ <_apex_!~apex@dynamic-acs-24-144-190-15.zoominternet.net> has joined #bitcoin-core-dev
472022-09-13T07:57:59 *** _apex_ <_apex_!~apex@dynamic-acs-24-144-190-15.zoominternet.net> has quit IRC (Ping timeout: 250 seconds)
482022-09-13T08:10:21 *** AaronvanW <AaronvanW!~AaronvanW@user/AaronvanW> has joined #bitcoin-core-dev
492022-09-13T08:19:44 *** sipsorcery <sipsorcery!~sipsorcer@2a02:8084:6180:500::12b> has quit IRC (Ping timeout: 244 seconds)
502022-09-13T08:26:28 *** Guyver2 <Guyver2!~Guyver@77-174-98-73.fixed.kpn.net> has quit IRC (Quit: Going offline, see ya! (www.adiirc.com))
512022-09-13T08:42:33 *** Murch <Murch!~murch@user/murch> has quit IRC (Quit: Bridge terminating on SIGTERM)
522022-09-13T08:42:34 *** bitcoin-git <bitcoin-git!~bitcoin-g@2001:470:69fc:105::2:690> has quit IRC (Quit: Bridge terminating on SIGTERM)
532022-09-13T08:42:35 *** provoostenator <provoostenator!~provooste@user/provoostenator> has quit IRC (Quit: Bridge terminating on SIGTERM)
542022-09-13T08:42:35 *** willcl_ark <willcl_ark!~willcl-ar@user/willcl-ark/x-8282106> has quit IRC (Quit: Bridge terminating on SIGTERM)
552022-09-13T08:42:35 *** sipa <sipa!~sipa@user/sipa> has quit IRC (Quit: Bridge terminating on SIGTERM)
562022-09-13T08:42:36 *** BlueMatt[m] <BlueMatt[m]!~bluemattm@2001:470:69fc:105::1:5092> has quit IRC (Quit: Bridge terminating on SIGTERM)
572022-09-13T08:42:36 *** robertspigler <robertspigler!~robertspi@2001:470:69fc:105::2d53> has quit IRC (Quit: Bridge terminating on SIGTERM)
582022-09-13T08:42:37 *** kvaciral <kvaciral!~kvaciral@2001:470:69fc:105::17b> has quit IRC (Quit: Bridge terminating on SIGTERM)
592022-09-13T08:42:37 *** denise[m] <denise[m]!~denisewui@2001:470:69fc:105::1:4ab8> has quit IRC (Quit: Bridge terminating on SIGTERM)
602022-09-13T08:42:38 *** kakolainen[m] <kakolainen[m]!~kakolaine@2001:470:69fc:105::34f9> has quit IRC (Quit: Bridge terminating on SIGTERM)
612022-09-13T08:42:39 *** ishaanam[m] <ishaanam[m]!~ishaanamm@2001:470:69fc:105::2:4078> has quit IRC (Quit: Bridge terminating on SIGTERM)
622022-09-13T08:42:39 *** josie[m] <josie[m]!~josiem]@2001:470:69fc:105::2:47a6> has quit IRC (Quit: Bridge terminating on SIGTERM)
632022-09-13T08:42:39 *** dunxen <dunxen!~dunxen@2001:470:69fc:105::1:fec1> has quit IRC (Quit: Bridge terminating on SIGTERM)
642022-09-13T08:42:39 *** arturomf94[m] <arturomf94[m]!~arturomf9@2001:470:69fc:105::2:235> has quit IRC (Quit: Bridge terminating on SIGTERM)
652022-09-13T08:42:39 *** stratospher[m] <stratospher[m]!~stratosph@2001:470:69fc:105::2:728e> has quit IRC (Quit: Bridge terminating on SIGTERM)
662022-09-13T08:45:51 *** Murch <Murch!~murch@user/murch> has joined #bitcoin-core-dev
672022-09-13T08:50:39 *** kvaciral <kvaciral!~kvaciral@2001:470:69fc:105::17b> has joined #bitcoin-core-dev
682022-09-13T08:50:40 *** BlueMatt[m] <BlueMatt[m]!~bluemattm@2001:470:69fc:105::1:5092> has joined #bitcoin-core-dev
692022-09-13T08:50:40 *** bitcoin-git <bitcoin-git!~bitcoin-g@2001:470:69fc:105::2:690> has joined #bitcoin-core-dev
702022-09-13T08:50:40 *** willcl_ark <willcl_ark!~willcl-ar@user/willcl-ark/x-8282106> has joined #bitcoin-core-dev
712022-09-13T08:50:40 *** denise[m] <denise[m]!~denisewui@2001:470:69fc:105::1:4ab8> has joined #bitcoin-core-dev
722022-09-13T08:50:40 *** sipa <sipa!~sipa@user/sipa> has joined #bitcoin-core-dev
732022-09-13T08:50:40 *** robertspigler <robertspigler!~robertspi@2001:470:69fc:105::2d53> has joined #bitcoin-core-dev
742022-09-13T08:50:40 *** provoostenator <provoostenator!~provooste@user/provoostenator> has joined #bitcoin-core-dev
752022-09-13T08:50:51 *** stratospher[m] <stratospher[m]!~stratosph@2001:470:69fc:105::2:728e> has joined #bitcoin-core-dev
762022-09-13T08:50:51 *** ishaanam[m] <ishaanam[m]!~ishaanamm@2001:470:69fc:105::2:4078> has joined #bitcoin-core-dev
772022-09-13T08:50:51 *** arturomf94[m] <arturomf94[m]!~arturomf9@2001:470:69fc:105::2:235> has joined #bitcoin-core-dev
782022-09-13T08:50:53 *** kakolainen[m] <kakolainen[m]!~kakolaine@2001:470:69fc:105::34f9> has joined #bitcoin-core-dev
792022-09-13T08:50:53 *** josie[m] <josie[m]!~josiem]@2001:470:69fc:105::2:47a6> has joined #bitcoin-core-dev
802022-09-13T08:50:54 *** dunxen <dunxen!~dunxen@2001:470:69fc:105::1:fec1> has joined #bitcoin-core-dev
812022-09-13T09:03:17 *** kexkey <kexkey!~kexkey@178.249.214.19> has quit IRC (Ping timeout: 265 seconds)
822022-09-13T09:05:18 *** kexkey <kexkey!~kexkey@178.249.214.10> has joined #bitcoin-core-dev
832022-09-13T09:07:12 <bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/5558d2f5496d...995fdef14af2
842022-09-13T09:07:12 <bitcoin-git> bitcoin/master beb9426 Hennadii Stepanov: Revert "guix: Build depends/qt with our platform definition"
852022-09-13T09:07:12 <bitcoin-git> bitcoin/master 995fdef fanquake: Merge bitcoin/bitcoin#26059: Revert "guix: Build depends/qt with our platf...
862022-09-13T09:07:15 <bitcoin-git> [bitcoin] fanquake merged pull request #26059: Revert "guix: Build depends/qt with our platform definition" (master...220910-guix) https://github.com/bitcoin/bitcoin/pull/26059
872022-09-13T09:17:25 *** af_mencken <af_mencken!~afmencken@69.4.234.104> has joined #bitcoin-core-dev
882022-09-13T09:17:55 <bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/995fdef14af2...e9e943cfb7c4
892022-09-13T09:17:55 <bitcoin-git> bitcoin/master 2870a97 furszy: RPC: unify arg type error message
902022-09-13T09:17:55 <bitcoin-git> bitcoin/master e9e943c fanquake: Merge bitcoin/bitcoin#26069: rpc: unify arg type error message
912022-09-13T09:17:56 <bitcoin-git> [bitcoin] fanquake merged pull request #26069: rpc: unify arg type error message (master...2022_rpc_unify_error_type) https://github.com/bitcoin/bitcoin/pull/26069
922022-09-13T09:19:34 <bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/e9e943cfb7c4...a361c6cae766
932022-09-13T09:19:35 <bitcoin-git> bitcoin/master 0cd7928 fanquake: guix: use git-minimal over git
942022-09-13T09:19:35 <bitcoin-git> bitcoin/master a361c6c fanquake: Merge bitcoin/bitcoin#26047: guix: use git-minimal over git
952022-09-13T09:19:35 <bitcoin-git> [bitcoin] fanquake merged pull request #26047: guix: use git-minimal over git (master...guix_use_git_minimal) https://github.com/bitcoin/bitcoin/pull/26047
962022-09-13T09:20:41 *** __afmencken <__afmencken!~afmencken@69.4.234.83> has quit IRC (Ping timeout: 265 seconds)
972022-09-13T09:34:18 *** SpellChecker <SpellChecker!~SpellChec@user/SpellChecker> has quit IRC (Quit: bye)
982022-09-13T09:36:26 *** SpellChecker <SpellChecker!~SpellChec@user/SpellChecker> has joined #bitcoin-core-dev
992022-09-13T10:23:06 *** _apex_ <_apex_!~apex@dynamic-acs-24-144-190-15.zoominternet.net> has joined #bitcoin-core-dev
1002022-09-13T10:27:35 *** _apex_ <_apex_!~apex@dynamic-acs-24-144-190-15.zoominternet.net> has quit IRC (Ping timeout: 252 seconds)
1012022-09-13T10:45:04 *** gleb1068924 <gleb1068924!~gleb@178.150.137.228> has joined #bitcoin-core-dev
1022022-09-13T11:05:13 <bitcoin-git> [bitcoin] fanquake closed pull request #25948: doc: added note about brew and Qt 6 on macOS (master...docs-macos-qt6) https://github.com/bitcoin/bitcoin/pull/25948
1032022-09-13T11:10:56 *** Guyver2 <Guyver2!~Guyver@77-174-98-73.fixed.kpn.net> has joined #bitcoin-core-dev
1042022-09-13T11:17:46 <bitcoin-git> [bitcoin] fanquake opened pull request #26073: build: fix depends bdb compilation for BSDs (master..._BSD_bdb_compilation) https://github.com/bitcoin/bitcoin/pull/26073
1052022-09-13T11:26:31 <bitcoin-git> [bitcoin] MarcoFalke opened pull request #26074: refactor: Set RPCArg options with designated initializers (master...2209-rpc-refactor-ð¿) https://github.com/bitcoin/bitcoin/pull/26074
1062022-09-13T11:36:52 <bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/a361c6cae766...94d17845d04e
1072022-09-13T11:36:54 <bitcoin-git> bitcoin/master 2d0b4e4 Vasil Dimov: init: allow startup with -onlynet=onion -listenonion=1
1082022-09-13T11:36:57 <bitcoin-git> bitcoin/master 94d1784 fanquake: Merge bitcoin/bitcoin#24991: init: allow startup with -onlynet=onion -list...
1092022-09-13T11:36:59 <bitcoin-git> [bitcoin] fanquake merged pull request #24991: init: allow startup with -onlynet=onion -listenonion=1 (master...onlynet_onion_with_listenonion_is_ok) https://github.com/bitcoin/bitcoin/pull/24991
1102022-09-13T11:44:08 *** bitdex <bitdex!~bitdex@gateway/tor-sasl/bitdex> has quit IRC (Quit: = "")
1112022-09-13T12:09:24 *** gleb1068924 <gleb1068924!~gleb@178.150.137.228> has quit IRC (Ping timeout: 264 seconds)
1122022-09-13T12:19:41 <bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/94d17845d04e...141540a71f51
1132022-09-13T12:19:41 <bitcoin-git> bitcoin/master faa3d38 MacroFake: refactor: Pass reference to LookUpStats
1142022-09-13T12:19:42 <bitcoin-git> bitcoin/master 141540a MacroFake: Merge bitcoin/bitcoin#25222: refactor: Pass reference to LookUpStats
1152022-09-13T12:19:44 <bitcoin-git> [bitcoin] MarcoFalke merged pull request #25222: refactor: Pass reference to LookUpStats (master...2205-ref-stat-ð¶) https://github.com/bitcoin/bitcoin/pull/25222
1162022-09-13T12:23:02 *** gleb1068924 <gleb1068924!~gleb@178.150.137.228> has joined #bitcoin-core-dev
1172022-09-13T12:36:35 <bitcoin-git> [bitcoin] fanquake opened pull request #26075: contrib: remove 32bit linux code from release scripts (master...remove_32bit_linux_scripts) https://github.com/bitcoin/bitcoin/pull/26075
1182022-09-13T13:10:50 *** brunoerg <brunoerg!~brunoerg@2804:14d:5281:8ae2:d116:387a:e9f6:d613> has joined #bitcoin-core-dev
1192022-09-13T13:19:29 <bitcoin-git> [bitcoin] Sjors opened pull request #26076: Switch hardened derivation marker to h in descriptors (master...2022/09/descriptors_h) https://github.com/bitcoin/bitcoin/pull/26076
1202022-09-13T13:31:43 <bitcoin-git> [bitcoin] MarcoFalke closed pull request #24737: Remove taproot chain param (master...2204-rem-code-ð¥) https://github.com/bitcoin/bitcoin/pull/24737
1212022-09-13T13:34:29 *** fjMSX <fjMSX!~hypni2p@128-68-149-52.broadband.corbina.ru> has joined #bitcoin-core-dev
1222022-09-13T13:42:09 *** mikehu44 <mikehu44!~quassel@159.65.11.175> has joined #bitcoin-core-dev
1232022-09-13T13:45:56 *** __afmencken <__afmencken!~afmencken@69.4.234.76> has joined #bitcoin-core-dev
1242022-09-13T13:48:33 *** af_mencken <af_mencken!~afmencken@69.4.234.104> has quit IRC (Ping timeout: 250 seconds)
1252022-09-13T13:50:54 *** Guyver2_ <Guyver2_!Guyver@77-174-98-73.fixed.kpn.net> has joined #bitcoin-core-dev
1262022-09-13T13:54:21 *** Guyver2 <Guyver2!~Guyver@77-174-98-73.fixed.kpn.net> has quit IRC (Ping timeout: 268 seconds)
1272022-09-13T14:03:29 *** szkl <szkl!uid110435@id-110435.uxbridge.irccloud.com> has joined #bitcoin-core-dev
1282022-09-13T14:04:17 *** mikehu44_ <mikehu44_!~quassel@159.65.11.175> has joined #bitcoin-core-dev
1292022-09-13T14:04:18 *** mikehu44 <mikehu44!~quassel@159.65.11.175> has quit IRC (Ping timeout: 268 seconds)
1302022-09-13T14:06:20 *** _andrewtoth_ <_andrewtoth_!~andrewtot@gateway/tor-sasl/andrewtoth> has quit IRC (Remote host closed the connection)
1312022-09-13T14:42:29 *** halosghost <halosghost!~halosghos@user/halosghost> has joined #bitcoin-core-dev
1322022-09-13T14:43:15 <bitcoin-git> [bitcoin] glozow pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/141540a71f51...3a7e0a210c86
1332022-09-13T14:43:16 <bitcoin-git> bitcoin/master 00eeb31 James O'Beirne: scripted-diff: rename CChainState -> Chainstate
1342022-09-13T14:43:16 <bitcoin-git> bitcoin/master 3a7e0a2 glozow: Merge bitcoin/bitcoin#24513: CChainState -> Chainstate
1352022-09-13T14:43:22 <bitcoin-git> [bitcoin] glozow merged pull request #24513: CChainState - Chainstate (master...2022-03-chainstate-rename) https://github.com/bitcoin/bitcoin/pull/24513
1362022-09-13T14:47:24 <bitcoin-git> [bitcoin] fanquake opened pull request #26077: guix: switch from `guix environment` to `guix shell` (master...guix_shell_over_environment) https://github.com/bitcoin/bitcoin/pull/26077
1372022-09-13T15:04:49 *** mikehu44_ <mikehu44_!~quassel@159.65.11.175> has quit IRC (Ping timeout: 265 seconds)
1382022-09-13T15:14:32 *** andrewtoth <andrewtoth!~andrewtot@gateway/tor-sasl/andrewtoth> has joined #bitcoin-core-dev
1392022-09-13T15:14:33 <jamesob> wow, it actually happened. CChainState is now Chainstate. Feel free to direct all rebase ire at me
1402022-09-13T15:17:29 <bitcoin-git> [bitcoin] jamesob reopened pull request #24364: refactor: remove duplicate code from BlockAssembler (master...2022-02-ba-dup-code) https://github.com/bitcoin/bitcoin/pull/24364
1412022-09-13T15:18:17 <halosghost> lol
1422022-09-13T15:18:39 <halosghost> am I understanding the history correctly that the prefix-C was a hungarian-notation holdover?
1432022-09-13T15:18:59 <halosghost> (namely, for âclassâ)
1442022-09-13T15:19:58 <jamesob> halosghost: yeah, Satoshi had a penchant for it
1452022-09-13T15:21:37 <halosghost> to be fair, a lot of people at the time did âº
1462022-09-13T15:23:57 *** andrewtoth <andrewtoth!~andrewtot@gateway/tor-sasl/andrewtoth> has quit IRC (Remote host closed the connection)
1472022-09-13T15:24:01 *** Guyver2__ <Guyver2__!Guyver@77-174-98-73.fixed.kpn.net> has joined #bitcoin-core-dev
1482022-09-13T15:24:07 *** andrewtoth <andrewtoth!~andrewtot@gateway/tor-sasl/andrewtoth> has joined #bitcoin-core-dev
1492022-09-13T15:26:56 *** Guyver2_ <Guyver2_!Guyver@77-174-98-73.fixed.kpn.net> has quit IRC (Ping timeout: 268 seconds)
1502022-09-13T15:29:07 *** andrewtoth <andrewtoth!~andrewtot@gateway/tor-sasl/andrewtoth> has quit IRC (Remote host closed the connection)
1512022-09-13T15:29:25 *** andrewtoth <andrewtoth!~andrewtot@gateway/tor-sasl/andrewtoth> has joined #bitcoin-core-dev
1522022-09-13T15:35:16 *** jamesob <jamesob!~jamesob@pool-108-51-103-2.washdc.fios.verizon.net> has quit IRC (Ping timeout: 265 seconds)
1532022-09-13T15:52:54 <bitcoin-git> [bitcoin] achow101 pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/3a7e0a210c86...c85688347eac
1542022-09-13T15:52:54 <bitcoin-git> bitcoin/master d26c3cc furszy: wallet: bugfix, load wallet with an unknown descriptor cause fatal error
1552022-09-13T15:52:55 <bitcoin-git> bitcoin/master e066763 furszy: wallet: coverage for loading an unknown descriptor
1562022-09-13T15:52:55 <bitcoin-git> bitcoin/master c856883 Andrew Chow: Merge bitcoin/bitcoin#26021: wallet: bugfix, load a wallet with an unknown...
1572022-09-13T15:53:01 <bitcoin-git> [bitcoin] achow101 merged pull request #26021: wallet: bugfix, load a wallet with an unknown/corrupt descriptor causes a fatal error (master...2022_wallet_fix_descriptor_unserialization) https://github.com/bitcoin/bitcoin/pull/26021
1582022-09-13T15:53:43 *** andrewtoth <andrewtoth!~andrewtot@gateway/tor-sasl/andrewtoth> has quit IRC (Remote host closed the connection)
1592022-09-13T15:54:11 *** andrewtoth <andrewtoth!~andrewtot@gateway/tor-sasl/andrewtoth> has joined #bitcoin-core-dev
1602022-09-13T16:00:05 *** SpellChecker <SpellChecker!~SpellChec@user/SpellChecker> has quit IRC (Quit: bye)
1612022-09-13T16:01:01 *** SpellChecker <SpellChecker!~SpellChec@user/SpellChecker> has joined #bitcoin-core-dev
1622022-09-13T16:03:04 *** jamesob <jamesob!~jamesob@151.200.19.227> has joined #bitcoin-core-dev
1632022-09-13T16:15:14 <bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/c85688347eac...29d540b7ada8
1642022-09-13T16:15:14 <bitcoin-git> bitcoin/master b50a4b7 Cory Fields: build: quiet warnings in system headers installed from homebrew
1652022-09-13T16:15:14 <bitcoin-git> bitcoin/master 29d540b fanquake: Merge bitcoin/bitcoin#26070: build: Quiet warnings in symlinked headers in...
1662022-09-13T16:15:15 <bitcoin-git> [bitcoin] fanquake merged pull request #26070: build: Quiet warnings in symlinked headers installed from homebrew (master...fix-brew-usrlocal) https://github.com/bitcoin/bitcoin/pull/26070
1672022-09-13T16:21:37 *** szkl <szkl!uid110435@id-110435.uxbridge.irccloud.com> has quit IRC (Quit: Connection closed for inactivity)
1682022-09-13T16:22:29 *** fjMSX <fjMSX!~hypni2p@128-68-149-52.broadband.corbina.ru> has quit IRC (Remote host closed the connection)
1692022-09-13T16:24:40 <fanquake> wallet / psbt concerned folks, we need some opinons in regards to #25856 vs #25858
1702022-09-13T16:24:41 <gribble> https://github.com/bitcoin/bitcoin/issues/25856 | [BugFix] Make PSBT serializations 174 compliant by excluding empty taptree from serialization by JeremyRubin · Pull Request #25856 · bitcoin/bitcoin · GitHub
1712022-09-13T16:24:42 <gribble> https://github.com/bitcoin/bitcoin/issues/25858 | psbt: Only include PSBT_OUT_TAP_TREE when the output has a script path by achow101 · Pull Request #25858 · bitcoin/bitcoin · GitHub
1722022-09-13T16:30:29 *** fjMSX <fjMSX!~hypni2p@128-68-149-52.broadband.corbina.ru> has joined #bitcoin-core-dev
1732022-09-13T16:41:32 *** sipsorcery <sipsorcery!~sipsorcer@2a02:8084:6180:500::12b> has joined #bitcoin-core-dev
1742022-09-13T17:03:19 *** DeanGuss <DeanGuss!~dean@user/deanguss> has quit IRC (Quit: buhbye)
1752022-09-13T17:11:58 *** Copinmalin <Copinmalin!~Copinmali@51.91.208.235> has joined #bitcoin-core-dev
1762022-09-13T17:13:13 *** DeanGuss <DeanGuss!~dean@nonplayercharacter.me> has joined #bitcoin-core-dev
1772022-09-13T17:36:15 *** Talkless <Talkless!~Talkless@mail.dargis.net> has joined #bitcoin-core-dev
1782022-09-13T17:38:49 *** gleb1068924 <gleb1068924!~gleb@178.150.137.228> has quit IRC (Ping timeout: 268 seconds)
1792022-09-13T17:42:35 *** gleb1068924 <gleb1068924!~gleb@178.150.137.228> has joined #bitcoin-core-dev
1802022-09-13T17:48:41 *** Guest94 <Guest94!~Guest94@103.216.143.114> has joined #bitcoin-core-dev
1812022-09-13T17:51:21 *** AaronvanW <AaronvanW!~AaronvanW@user/AaronvanW> has quit IRC (Quit: Leaving...)
1822022-09-13T17:53:08 *** Guest94 <Guest94!~Guest94@103.216.143.114> has quit IRC (Client Quit)
1832022-09-13T18:07:04 *** Copinmalin <Copinmalin!~Copinmali@51.91.208.235> has quit IRC (Ping timeout: 252 seconds)
1842022-09-13T18:15:23 *** Copinmalin <Copinmalin!~Copinmali@51.91.208.235> has joined #bitcoin-core-dev
1852022-09-13T18:21:02 *** dougefish <dougefish!~dougefish@77.137.68.0> has quit IRC (Remote host closed the connection)
1862022-09-13T18:25:16 *** Copinmalin <Copinmalin!~Copinmali@51.91.208.235> has quit IRC (Quit: Client closed)
1872022-09-13T18:48:03 *** bomb-on <bomb-on!~bomb-on@user/bomb-on> has joined #bitcoin-core-dev
1882022-09-13T19:16:04 *** Talkless <Talkless!~Talkless@mail.dargis.net> has quit IRC (Quit: Konversation terminated!)
1892022-09-13T20:27:12 *** andrewtoth_ <andrewtoth_!~andrewtot@gateway/tor-sasl/andrewtoth> has joined #bitcoin-core-dev
1902022-09-13T20:29:29 *** andrewtoth <andrewtoth!~andrewtot@gateway/tor-sasl/andrewtoth> has quit IRC (Ping timeout: 258 seconds)
1912022-09-13T20:35:29 *** dougefish <dougefish!~dougefish@2a00:a040:199:52c1:1ac0:4dff:fe34:3985> has joined #bitcoin-core-dev
1922022-09-13T21:23:16 *** Guyver2__ <Guyver2__!Guyver@77-174-98-73.fixed.kpn.net> has quit IRC (Quit: Going offline, see ya! (www.adiirc.com))
1932022-09-13T21:25:42 <bitcoin-git> [bitcoin] brunoerg opened pull request #26078: p2p: return `CSubNet` in `LookupSubNet` (master...2022-09-csubnet-lookup) https://github.com/bitcoin/bitcoin/pull/26078
1942022-09-13T21:28:09 *** brunoerg <brunoerg!~brunoerg@2804:14d:5281:8ae2:d116:387a:e9f6:d613> has quit IRC ()
1952022-09-13T21:44:34 *** realies <realies!~realies@user/realies> has quit IRC (Quit: ~)
1962022-09-13T22:04:11 <bitcoin-git> [bitcoin] hebasto opened pull request #26079: Revert "doc: note that brew installed qt is not supported" (master...220913-brew) https://github.com/bitcoin/bitcoin/pull/26079
1972022-09-13T22:05:06 *** halosghost <halosghost!~halosghos@user/halosghost> has quit IRC (Ping timeout: 260 seconds)
1982022-09-13T22:09:05 <bitcoin-git> [bitcoin] ishaanam opened pull request #26081: sendall: check if the maxtxfee has been exceeded (master...sendall_maxtxfee) https://github.com/bitcoin/bitcoin/pull/26081
1992022-09-13T22:38:17 *** bitdex <bitdex!~bitdex@gateway/tor-sasl/bitdex> has joined #bitcoin-core-dev
2002022-09-13T22:43:15 *** sipsorcery <sipsorcery!~sipsorcer@2a02:8084:6180:500::12b> has quit IRC (Remote host closed the connection)
2012022-09-13T22:43:34 *** sipsorcery <sipsorcery!~sipsorcer@2a02:8084:6180:500::12b> has joined #bitcoin-core-dev
2022022-09-13T22:46:08 *** andrewtoth_ <andrewtoth_!~andrewtot@gateway/tor-sasl/andrewtoth> has quit IRC (Remote host closed the connection)
2032022-09-13T22:51:54 <bitcoin-git> [bitcoin] luke-jr opened pull request #26082: RPC/Wallet: Access wallets via interfaces::Wallet (master...rpc_wallet_interfaces) https://github.com/bitcoin/bitcoin/pull/26082
2042022-09-13T22:51:59 <bitcoin-git> [bitcoin] glozow merged pull request #26081: sendall: check if the maxtxfee has been exceeded (master...sendall_maxtxfee) https://github.com/bitcoin/bitcoin/pull/26081
2052022-09-13T22:52:11 <bitcoin-git> [bitcoin] glozow pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/29d540b7ada8...57a17de05ea2
2062022-09-13T22:52:11 <bitcoin-git> bitcoin/master 6f8e381 ishaanam: sendall: check if the maxtxfee has been exceeded
2072022-09-13T22:52:12 <bitcoin-git> bitcoin/master 57a17de Gloria Zhao: Merge pull request #26081 from ishaanam/sendall_maxtxfee
2082022-09-13T22:52:33 <glozow> OMG that was a total accident, fat finger on mobile
2092022-09-13T22:57:14 <luke-jr> people have GitHub accounts logged into on mobile? <.<
2102022-09-13T22:57:19 <achow101> huh. didn't know that button still worked
2112022-09-13T22:58:39 <luke-jr> huh, the merge is GPG-signed
2122022-09-13T22:58:53 <luke-jr> how is that possible? :x
2132022-09-13T22:59:13 <achow101> I think the github webui has a gpg key
2142022-09-13T22:59:31 *** bomb-on <bomb-on!~bomb-on@user/bomb-on> has quit IRC (Quit: aллилѹÑа!)
2152022-09-13T23:00:10 <sipa> ... the correct one?
2162022-09-13T23:00:31 <achow101> no, I expect CI will fail verify-commits now
2172022-09-13T23:00:45 <luke-jr> ah, it's not her normal one
2182022-09-13T23:00:50 <glozow> no way, it should be on my yubikey
2192022-09-13T23:01:46 <luke-jr> 8 minutes now. probably should just revert and deal with verify-commits consequences :x
2202022-09-13T23:02:17 <luke-jr> (or branch off 24.x from the older commit and deal with the PR as-is)
2212022-09-13T23:02:55 *** jespada <jespada!~jespada@cpc121060-nmal24-2-0-cust249.19-2.cable.virginm.net> has quit IRC (Ping timeout: 252 seconds)
2222022-09-13T23:03:43 <sipa> can't you force push the previous state?
2232022-09-13T23:03:51 <achow101> should I try?
2242022-09-13T23:04:29 <achow101> going to try force pushing 29d540b7ada890dd588c4825d40c27c5e6f20061
2252022-09-13T23:04:55 <achow101> goign to need an owner to do that: remote: error: Cannot force-push to this protected branch
2262022-09-13T23:04:56 <luke-jr> sipa: it will break anyone who pulled in the last 10 mins
2272022-09-13T23:06:26 <luke-jr> otoh, maybe we should take advantage of this to treat it as a malicious push to the git repo
2282022-09-13T23:06:34 <luke-jr> and see who notices / can adapt
2292022-09-13T23:06:50 <luke-jr> I assume in that scenario, we'd force push
2302022-09-13T23:07:22 <luke-jr> is laanwj the only one with needed access?
2312022-09-13T23:07:35 <achow101> I believe fanquake can force too
2322022-09-13T23:10:28 <sipa> i may still be able to, should i try?
2332022-09-13T23:11:00 <luke-jr> IMO yes, but I'm treating it as malicious (no offense to glozow intended)
2342022-09-13T23:11:09 <achow101> sipa: I think so
2352022-09-13T23:11:53 <glozow> I will open a revert. If somebody is able to push, please do.
2362022-09-13T23:12:07 <luke-jr> glozow: no point in a revert if sipa force pushes
2372022-09-13T23:12:20 <luke-jr> though the PR itself will need to be reopened
2382022-09-13T23:12:24 <sipa> give me a minute
2392022-09-13T23:12:36 <luke-jr> re-created*
2402022-09-13T23:13:15 <bitcoin-git> [bitcoin] sipa force pushed 0 commit to master: https://github.com/bitcoin/bitcoin/compare/57a17de05ea2...29d540b7ada8
2412022-09-13T23:13:29 <bitcoin-git> [bitcoin] glozow opened pull request #26083: Revert "sendall: check if the maxtxfee has been exceeded" (master...revert-26081-sendall_maxtxfee) https://github.com/bitcoin/bitcoin/pull/26083
2422022-09-13T23:13:33 <luke-jr> glozow: might I suggest a second unprivileged github account for your mobile?
2432022-09-13T23:13:44 <achow101> that appears to have worked
2442022-09-13T23:14:39 <luke-jr> also confirming the force push worked as results in the expected head commit
2452022-09-13T23:16:19 <glozow> luke-jr: yes indeed, I will need to stop having my account on mobile, lessons learned. Sincerest apologies!
2462022-09-13T23:16:54 <bitcoin-git> [bitcoin] glozow closed pull request #26083: Revert "sendall: check if the maxtxfee has been exceeded" (master...revert-26081-sendall_maxtxfee) https://github.com/bitcoin/bitcoin/pull/26083
2472022-09-13T23:20:23 <glozow> Thank you sipa! Iâm very, very sorry, it was an accident
2482022-09-13T23:21:24 <sipa> There is a setting to require signed commits, though I don't know how it works.
2492022-09-13T23:21:59 <sipa> Or whether it applies to all commits or just the merge commits, or which keys it would accept.
2502022-09-13T23:22:17 <achow101> sipa: I believe that would apply to all commits
2512022-09-13T23:22:53 <achow101> https://docs.github.com/en/repositories/configuring-branches-and-merges-in-your-repository/defining-the-mergeability-of-pull-requests/about-protected-branches#require-signed-commits
2522022-09-13T23:24:33 <achow101> we could probably turn on "Require pull request reviews before merging"?
2532022-09-13T23:25:18 <luke-jr> too bad there's no "don't allow merging via GitHub" XD
2542022-09-13T23:25:43 <achow101> although that would require at least one person to use the "review approval" thing as it probably won't understand ACKs. At least we could set it to 1 and before merging a pr, the maintainer needs to click that button before they can merge it
2552022-09-13T23:26:50 <luke-jr> hmm
2562022-09-13T23:27:00 <luke-jr> does it enforce these policies on git pushes at all?
2572022-09-13T23:27:11 <luke-jr> maybe we can enable an unsatisfiable one to just block the button
2582022-09-13T23:28:18 <achow101> it does block on git pushes too
2592022-09-13T23:29:03 <luke-jr> oh well :/
2602022-09-13T23:30:02 <achow101> it would have to be some policy which can be disabled per pr right before merging
2612022-09-13T23:35:47 *** sipsorcery <sipsorcery!~sipsorcer@2a02:8084:6180:500::12b> has quit IRC (Ping timeout: 244 seconds)
2622022-09-13T23:41:31 *** _apex_ <_apex_!~apex@dynamic-acs-24-144-190-15.zoominternet.net> has joined #bitcoin-core-dev
2632022-09-13T23:55:08 <_aj_> achow101: drahtbot could translate ACKs into a review approval by drahtbot, i suppose