12022-09-15T00:25:21 *** drnet <drnet!~drnet@77.119.216.147.wireless.dyn.drei.com> has joined #bitcoin-core-dev
22022-09-15T00:36:36 *** _apex_ <_apex_!~apex@dynamic-acs-24-144-190-15.zoominternet.net> has joined #bitcoin-core-dev
32022-09-15T00:36:38 *** someone235 <someone235!uid419897@id-419897.ilkley.irccloud.com> has quit IRC (Quit: Connection closed for inactivity)
42022-09-15T00:46:24 *** bitdex <bitdex!~bitdex@gateway/tor-sasl/bitdex> has quit IRC (Read error: Connection reset by peer)
52022-09-15T00:46:24 *** yanmaani2 <yanmaani2!~yanmaani@gateway/tor-sasl/yanmaani> has quit IRC (Read error: Connection reset by peer)
62022-09-15T00:46:53 *** bitdex <bitdex!~bitdex@gateway/tor-sasl/bitdex> has joined #bitcoin-core-dev
72022-09-15T00:47:05 *** yanmaani2 <yanmaani2!~yanmaani@gateway/tor-sasl/yanmaani> has joined #bitcoin-core-dev
82022-09-15T00:49:36 *** drnet <drnet!~drnet@77.119.216.147.wireless.dyn.drei.com> has quit IRC (Ping timeout: 264 seconds)
92022-09-15T01:11:12 *** _apex_ <_apex_!~apex@dynamic-acs-24-144-190-15.zoominternet.net> has quit IRC (Ping timeout: 264 seconds)
102022-09-15T01:11:39 *** drnet <drnet!~drnet@77.119.216.147.wireless.dyn.drei.com> has joined #bitcoin-core-dev
112022-09-15T01:21:15 *** drnet <drnet!~drnet@77.119.216.147.wireless.dyn.drei.com> has quit IRC (Read error: Connection reset by peer)
122022-09-15T01:21:34 *** drnet <drnet!~drnet@77.119.216.147.wireless.dyn.drei.com> has joined #bitcoin-core-dev
132022-09-15T01:33:55 *** sipsorcery <sipsorcery!~sipsorcer@2a02:8084:6180:500::12b> has joined #bitcoin-core-dev
142022-09-15T01:36:07 *** drnet <drnet!~drnet@77.119.216.147.wireless.dyn.drei.com> has quit IRC (Ping timeout: 244 seconds)
152022-09-15T01:49:07 *** sipsorcery <sipsorcery!~sipsorcer@2a02:8084:6180:500::12b> has quit IRC (Read error: Connection reset by peer)
162022-09-15T02:23:08 *** kexkey <kexkey!~kexkey@static-198-54-132-150.cust.tzulo.com> has quit IRC (Ping timeout: 244 seconds)
172022-09-15T02:35:34 *** hashfunc <hashfunc!~user@2601:5c0:c280:7090:83:ebf7:f91d:450a> has joined #bitcoin-core-dev
182022-09-15T02:36:57 *** kexkey <kexkey!~kexkey@178.249.214.10> has joined #bitcoin-core-dev
192022-09-15T03:18:39 *** andrewtoth_ <andrewtoth_!~andrewtot@gateway/tor-sasl/andrewtoth> has joined #bitcoin-core-dev
202022-09-15T04:01:01 *** cmirror <cmirror!~cmirror@4.53.92.114> has quit IRC (Remote host closed the connection)
212022-09-15T04:01:33 *** cmirror <cmirror!~cmirror@4.53.92.114> has joined #bitcoin-core-dev
222022-09-15T04:55:50 *** liviudm <liviudm!~textual@112.206.107.43> has joined #bitcoin-core-dev
232022-09-15T04:58:03 *** mikehu44 <mikehu44!~quassel@159.65.11.175> has joined #bitcoin-core-dev
242022-09-15T05:37:40 *** etherangel <etherangel!~etherboy@2600:8800:3180:839:7c33:c81:fcb6:57> has joined #bitcoin-core-dev
252022-09-15T06:22:28 *** etherangel <etherangel!~etherboy@2600:8800:3180:839:7c33:c81:fcb6:57> has quit IRC (Quit: Leaving)
262022-09-15T06:33:12 *** drnet <drnet!~drnet@185.89.163.206> has joined #bitcoin-core-dev
272022-09-15T06:35:20 *** drnet <drnet!~drnet@185.89.163.206> has quit IRC (Client Quit)
282022-09-15T06:40:06 *** doppo <doppo!~doppo@2604:180::e0fc:a07f> has quit IRC (Remote host closed the connection)
292022-09-15T06:40:34 *** doppo <doppo!~doppo@2604:180::e0fc:a07f> has joined #bitcoin-core-dev
302022-09-15T06:46:34 <bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/2e3cd26a1a5e...718304d22267
312022-09-15T06:46:35 <bitcoin-git> bitcoin/master 6f8e381 ishaanam: sendall: check if the maxtxfee has been exceeded
322022-09-15T06:46:35 <bitcoin-git> bitcoin/master 718304d MacroFake: Merge bitcoin/bitcoin#26084: sendall: check if the maxtxfee has been excee...
332022-09-15T06:46:37 <bitcoin-git> [bitcoin] MarcoFalke merged pull request #26084: sendall: check if the maxtxfee has been exceeded (master...sendall_maxtxfee) https://github.com/bitcoin/bitcoin/pull/26084
342022-09-15T07:02:41 *** fjMSX <fjMSX!~hypni2p@128-68-144-58.broadband.corbina.ru> has quit IRC (Read error: Connection reset by peer)
352022-09-15T07:02:49 *** sipsorcery <sipsorcery!~sipsorcer@2a02:8084:6180:500::12b> has joined #bitcoin-core-dev
362022-09-15T07:10:08 *** liviudm <liviudm!~textual@112.206.107.43> has quit IRC (Quit: liviudm)
372022-09-15T07:12:37 *** liviudm <liviudm!~liviudm@112.206.107.43> has joined #bitcoin-core-dev
382022-09-15T07:15:35 *** liviudm <liviudm!~liviudm@112.206.107.43> has quit IRC (Read error: Connection reset by peer)
392022-09-15T07:16:09 *** liviudm <liviudm!~liviudm@112.206.107.43> has joined #bitcoin-core-dev
402022-09-15T07:17:20 *** liviudm <liviudm!~liviudm@112.206.107.43> has quit IRC (Client Quit)
412022-09-15T07:18:30 *** Guyver2 <Guyver2!~Guyver@77-174-98-73.fixed.kpn.net> has joined #bitcoin-core-dev
422022-09-15T08:01:17 *** hashfunc <hashfunc!~user@2601:5c0:c280:7090:83:ebf7:f91d:450a> has quit IRC (Remote host closed the connection)
432022-09-15T08:10:48 <vasild> sipa: same here (wrt jq), phew! I am not the only one \o/
442022-09-15T08:12:24 *** sipsorcery <sipsorcery!~sipsorcer@2a02:8084:6180:500::12b> has quit IRC (Ping timeout: 244 seconds)
452022-09-15T08:24:59 <vasild> "my guess is these numbers are very skewed by spy nodes that download all transactions" -- I guess it is possible to cross-check if this is the case by looking at how many MEMPOOL messages you received, assuming spies send MEMPOOL.
462022-09-15T08:25:31 *** MacroFake_ <MacroFake_!~none@72.5.34.65> has joined #bitcoin-core-dev
472022-09-15T08:25:46 *** MacroFake <MacroFake!~none@72.5.34.65> has quit IRC (Ping timeout: 265 seconds)
482022-09-15T08:26:06 <vasild> or if they bombard you with lots of getdata, that would be strange
492022-09-15T08:26:35 <glozow> bip35 mempool should be disabled unless you offer them bip 37 bloom filter services iirc
502022-09-15T08:26:55 <vasild> hmm
512022-09-15T08:27:07 *** bomb-on <bomb-on!~bomb-on@user/bomb-on> has joined #bitcoin-core-dev
522022-09-15T08:27:14 <vasild> i briefly checked and got the impression that it is enabled by default...
532022-09-15T08:29:58 <vasild> glozow: here: https://github.com/bitcoin/bitcoin/blob/a8f69541ad53a76d5f69044ba829069d225a4af1/src/net.cpp#L946
542022-09-15T08:29:59 <glozow> see https://github.com/bitcoin/bitcoin/blob/718304d222671f98d2335cd9b90a3022f62d7b21/src/net_processing.cpp#L4487-L4513
552022-09-15T08:30:56 <glozow> I'm not 100% correct, either we offer bloom services or they have mempool permissions. but neither are on by default
562022-09-15T08:31:02 *** MacroFake_ <MacroFake_!~none@72.5.34.65> has quit IRC (Quit: ZNC 1.7.5+deb4 - https://znc.in)
572022-09-15T08:32:18 *** MacroFake <MacroFake!~none@72.5.34.65> has joined #bitcoin-core-dev
582022-09-15T08:32:21 <vasild> it looks to me mempool permission is on by default
592022-09-15T08:33:27 *** aleggg <aleggg!~aleggg@186.213.136.32> has quit IRC ()
602022-09-15T08:33:51 <glozow> that is gated under `if (NetPermissions::HasFlag(permissionFlags, NetPermissionFlags::Implicit)) {`
612022-09-15T08:34:15 <glozow> I may be wrong, but I don't think that is the default?
622022-09-15T08:35:58 <vasild> this comment: https://github.com/bitcoin/bitcoin/blob/a8f69541ad53a76d5f69044ba829069d225a4af1/src/net_permissions.h#L38
632022-09-15T08:37:43 *** fjMSX <fjMSX!~hypni2p@128-68-144-58.broadband.corbina.ru> has joined #bitcoin-core-dev
642022-09-15T08:38:33 <glozow> I think you are misinterpreting the comment. It's "user not set fine-grained permissions," as in they set `-whitelist=address` and did not specify something like `-whitelist=noban@address`
652022-09-15T08:39:54 <vasild> right, Implicit is only added from TryParsePermissionFlags()
662022-09-15T08:40:51 <vasild> So, how do spies download the entire pool? Bombard with a lot of getdata messages, but they must already know/guess txids!?
672022-09-15T08:45:59 <glozow> Sorry I don't have a lot of context on the original conversation, just popped in because you said "mempool" haha. They can query you for transactions they know about (but we try not to just serve everything we have immediately, see `FindTxForGetData`), or keep logs of what you announce.
682022-09-15T08:46:06 *** aleggg <aleggg!~aleggg@186.213.136.32> has joined #bitcoin-core-dev
692022-09-15T08:47:02 *** jesseposner <jesseposner!~jesse@user/jesseposner> has quit IRC (Ping timeout: 265 seconds)
702022-09-15T08:49:49 <vasild> yeah, that means they already know the txid and only check if you have it, but then to download the entire pool one needs to request individual transactions one by one and then this method is not exhaustive - it could miss some txs
712022-09-15T08:50:55 <glozow> yes they must request one by one. to clarify, what do you mean "miss" some?
722022-09-15T08:52:33 <vasild> that some transactions could be missed from this download procedure, e.g. if you have tx1, tx2 and tx3 and they request tx1 and tx2, but they do not know and thus do not request tx3, then tx3 will not be downloaded. So it is not like downloading the _entire_ pool.
732022-09-15T08:52:39 *** aleggg <aleggg!~aleggg@186.213.136.32> has quit IRC ()
742022-09-15T08:55:49 <glozow> oh I see. yes, the spy node only gets what it explicitly requests.
752022-09-15T09:02:28 <vasild> right, and then that must be pretty obvoius because we would get many getdata/tx requests. Would a normal node ever do that?
762022-09-15T09:04:55 *** kexkey <kexkey!~kexkey@178.249.214.10> has quit IRC (Ping timeout: 265 seconds)
772022-09-15T09:05:56 *** kexkey <kexkey!~kexkey@static-198-54-132-86.cust.tzulo.com> has joined #bitcoin-core-dev
782022-09-15T09:13:33 <bitcoin-git> [bitcoin] fanquake opened pull request #26099: build: remove duplicate / unneeded libs from bench_bitcoin (master...bench_duplicate_linking) https://github.com/bitcoin/bitcoin/pull/26099
792022-09-15T09:13:53 <glozow> normal node would not randomly request a bunch of transactions that you didn't announce, no
802022-09-15T09:14:06 <glozow> didn't announce to them*
812022-09-15T09:22:36 <bitcoin-git> [bitcoin] vasild opened pull request #26100: doc: clarify that NetPermissionFlags::Implicit is only about whitelists (master...netperm_implicit_comment) https://github.com/bitcoin/bitcoin/pull/26100
822022-09-15T09:23:03 <vasild> right, so it must be a spy doing that
832022-09-15T09:23:51 <vasild> glozow: a comment clarification in 26100 ^
842022-09-15T09:39:43 *** aleggg <aleggg!~aleggg@186.213.136.32> has joined #bitcoin-core-dev
852022-09-15T09:58:11 *** mikehu44 <mikehu44!~quassel@159.65.11.175> has quit IRC (Ping timeout: 260 seconds)
862022-09-15T10:00:40 *** mikehu44 <mikehu44!~quassel@gateway/vpn/pia/mikehu44-jc> has joined #bitcoin-core-dev
872022-09-15T10:06:35 *** mikehu44 <mikehu44!~quassel@gateway/vpn/pia/mikehu44-jc> has quit IRC (Ping timeout: 244 seconds)
882022-09-15T10:13:08 *** mikehu44 <mikehu44!~quassel@gateway/vpn/pia/mikehu44-jc> has joined #bitcoin-core-dev
892022-09-15T10:18:29 *** mikehu44 <mikehu44!~quassel@gateway/vpn/pia/mikehu44-jc> has quit IRC (Ping timeout: 255 seconds)
902022-09-15T10:18:49 *** mikehu44 <mikehu44!~quassel@159.65.11.175> has joined #bitcoin-core-dev
912022-09-15T10:24:44 <hebasto> linter fails in the master branch with "No parent of HEAD was signed with a trusted key!" message
922022-09-15T10:30:50 <fanquake> probably just gpg failing to retreive keys
932022-09-15T10:41:36 *** chipxxx <chipxxx!~chip@pop.92-184-107-20.mobile.abo.orange.fr> has joined #bitcoin-core-dev
942022-09-15T10:51:35 *** mikehu44_ <mikehu44_!~quassel@159.65.11.175> has joined #bitcoin-core-dev
952022-09-15T10:52:59 *** mikehu44 <mikehu44!~quassel@159.65.11.175> has quit IRC (Ping timeout: 250 seconds)
962022-09-15T11:03:56 *** mikehu44_ <mikehu44_!~quassel@159.65.11.175> has quit IRC (Ping timeout: 244 seconds)
972022-09-15T11:05:30 *** mikehu44 <mikehu44!~quassel@159.65.11.175> has joined #bitcoin-core-dev
982022-09-15T11:20:35 *** mikehu44_ <mikehu44_!~quassel@159.65.11.175> has joined #bitcoin-core-dev
992022-09-15T11:21:36 *** mikehu44 <mikehu44!~quassel@159.65.11.175> has quit IRC (Ping timeout: 260 seconds)
1002022-09-15T11:25:19 *** jesseposner <jesseposner!~jesse@user/jesseposner> has joined #bitcoin-core-dev
1012022-09-15T11:25:25 *** bitdex <bitdex!~bitdex@gateway/tor-sasl/bitdex> has quit IRC (Quit: = "")
1022022-09-15T11:35:58 *** jesseposner <jesseposner!~jesse@user/jesseposner> has quit IRC (Ping timeout: 244 seconds)
1032022-09-15T11:38:14 *** jesseposner <jesseposner!~jesse@user/jesseposner> has joined #bitcoin-core-dev
1042022-09-15T11:41:00 *** mikehu44 <mikehu44!~quassel@159.65.11.175> has joined #bitcoin-core-dev
1052022-09-15T11:42:02 *** mikehu44_ <mikehu44_!~quassel@159.65.11.175> has quit IRC (Ping timeout: 260 seconds)
1062022-09-15T11:47:15 *** mikehu44 <mikehu44!~quassel@159.65.11.175> has quit IRC (Quit: No Ping reply in 180 seconds.)
1072022-09-15T11:48:32 *** mikehu44 <mikehu44!~quassel@159.65.11.175> has joined #bitcoin-core-dev
1082022-09-15T11:58:13 *** ziggie <ziggie!uid521459@user/ziggie> has joined #bitcoin-core-dev
1092022-09-15T12:03:01 *** dermoth <dermoth!~dermoth@user/dermoth> has joined #bitcoin-core-dev
1102022-09-15T12:37:38 <sipa> @vasild I haven't investigated what these spies are doing (or if that's what's happening at all), but one theory is that they aggressively ask for all transactions we announce, including ones they have already received from other nodes
1112022-09-15T12:38:40 <vasild> could be
1122022-09-15T12:39:10 <sipa> unfortunately, if a significant portion of our bandwidth is being consumed by just such nodes behaving undesirably, then erlay will not actually impact total tx bandwidth much, even when increasing peers... at least not without other measures
1132022-09-15T12:39:17 <vasild> it seems that it would be useful to have global detailed traffic stats, like the ones we have per connected peer, but global.
1142022-09-15T12:39:24 <sipa> agree
1152022-09-15T12:39:40 <sipa> or broken down by peer type
1162022-09-15T12:39:58 <vasild> you mean inbound vs outbound?
1172022-09-15T12:40:57 <sipa> yeah, and block-relay-only / full-outbound / addrfetch / ...
1182022-09-15T12:41:49 <vasild> that too... some jq mastery would be required to aggregate it, but I think it would be ok
1192022-09-15T12:43:39 *** jesseposner <jesseposner!~jesse@user/jesseposner> has quit IRC (Ping timeout: 244 seconds)
1202022-09-15T12:45:45 *** jesseposner <jesseposner!~jesse@user/jesseposner> has joined #bitcoin-core-dev
1212022-09-15T12:54:59 *** jesseposner <jesseposner!~jesse@user/jesseposner> has quit IRC (Ping timeout: 265 seconds)
1222022-09-15T13:04:28 *** brunoerg <brunoerg!~brunoerg@2804:14d:5281:8ae2:38cb:b7c9:7f5b:7bc9> has joined #bitcoin-core-dev
1232022-09-15T13:15:38 <_aj_> sipa: make `bitcoin-cli getnetworkinfo | jq .bytessent.full-outbound.inv` report cumulative stats (so you still have info after a peer disconnects)?
1242022-09-15T13:16:30 <sipa> _aj_: That'd be useful, I think.
1252022-09-15T13:23:48 *** szkl <szkl!uid110435@id-110435.uxbridge.irccloud.com> has joined #bitcoin-core-dev
1262022-09-15T13:28:37 *** jesseposner <jesseposner!~jesse@user/jesseposner> has joined #bitcoin-core-dev
1272022-09-15T13:41:51 *** mikehu44 <mikehu44!~quassel@159.65.11.175> has quit IRC (Ping timeout: 268 seconds)
1282022-09-15T13:47:24 *** jesseposner <jesseposner!~jesse@user/jesseposner> has quit IRC (Ping timeout: 268 seconds)
1292022-09-15T13:47:50 *** mikehu44 <mikehu44!~quassel@159.65.11.175> has joined #bitcoin-core-dev
1302022-09-15T13:49:01 *** jesseposner <jesseposner!~jesse@user/jesseposner> has joined #bitcoin-core-dev
1312022-09-15T14:22:00 <bitcoin-git> [bitcoin] fanquake pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/718304d22267...20f03a5aedc2
1322022-09-15T14:22:00 <bitcoin-git> bitcoin/master afce044 fanquake: build: remove unused natpmp / upnp cppflags
1332022-09-15T14:22:00 <bitcoin-git> bitcoin/master 4b656b9 fanquake: build: remove unused libevent cppflags
1342022-09-15T14:22:00 <bitcoin-git> bitcoin/master 20f03a5 fanquake: Merge bitcoin/bitcoin#26089: build: remove unused cppflags
1352022-09-15T14:22:01 <bitcoin-git> [bitcoin] fanquake merged pull request #26089: build: remove unused cppflags (master...prune_unneeded_upnp_natpmp) https://github.com/bitcoin/bitcoin/pull/26089
1362022-09-15T14:26:25 *** halosghost <halosghost!~halosghos@user/halosghost> has joined #bitcoin-core-dev
1372022-09-15T14:32:48 <bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/20f03a5aedc2...f332c4f64d52
1382022-09-15T14:32:48 <bitcoin-git> bitcoin/master 02c9e56 Cory Fields: fs: fully initialize _OVERLAPPED for win32
1392022-09-15T14:32:49 <bitcoin-git> bitcoin/master f332c4f fanquake: Merge bitcoin/bitcoin#26090: fs: fully initialize `_OVERLAPPED` for win32
1402022-09-15T14:32:51 <bitcoin-git> [bitcoin] fanquake merged pull request #26090: fs: fully initialize `_OVERLAPPED` for win32 (master...fixup_overlapped_init_win32) https://github.com/bitcoin/bitcoin/pull/26090
1412022-09-15T14:47:12 *** mikehu44 <mikehu44!~quassel@159.65.11.175> has quit IRC (Ping timeout: 264 seconds)
1422022-09-15T14:49:20 *** mikehu44 <mikehu44!~quassel@159.65.11.175> has joined #bitcoin-core-dev
1432022-09-15T14:59:07 *** chipxxx <chipxxx!~chip@pop.92-184-107-20.mobile.abo.orange.fr> has quit IRC (Read error: Connection reset by peer)
1442022-09-15T15:04:13 *** mikehu44 <mikehu44!~quassel@159.65.11.175> has quit IRC (Ping timeout: 252 seconds)
1452022-09-15T15:26:11 <fanquake> I've moved the consolidated release note snippets from #26093 over into https://github.com/bitcoin-core/bitcoin-devwiki/wiki/24.0-Release-Notes-draft
1462022-09-15T15:26:12 <gribble> https://github.com/bitcoin/bitcoin/issues/26093 | doc: consolidate release-note fragments pre-wiki by fanquake · Pull Request #26093 · bitcoin/bitcoin · GitHub
1472022-09-15T15:26:18 <fanquake> hopefully created that wiki page correctly
1482022-09-15T15:26:56 <fanquake> have also just gone through the "Needs release note" label and removed basically everything, as it was pretty much leftovers from previous releases
1492022-09-15T15:27:56 <fanquake> if there is anything on https://github.com/bitcoin/bitcoin/milestone/54 that needs notes, or something that will be in 24.x that is missing from the milestone and needs notes, please point it out / add to the wiki etc
1502022-09-15T15:28:45 <bitcoin-git> [bitcoin] theuni opened pull request #26101: script: create V1SigVersion for functions which should only accept taproot/tapscript (master...explicit-v1-scriptver) https://github.com/bitcoin/bitcoin/pull/26101
1512022-09-15T16:02:17 *** vasild <vasild!~vd@user/vasild> has quit IRC (Ping timeout: 258 seconds)
1522022-09-15T16:03:24 *** vasild <vasild!~vd@user/vasild> has joined #bitcoin-core-dev
1532022-09-15T16:26:18 <bitcoin-git> [bitcoin] aureleoules opened pull request #26102: test: test_runner option to run tests in priority (master...2022-09-test-runner-priority) https://github.com/bitcoin/bitcoin/pull/26102
1542022-09-15T16:34:25 *** kexkey <kexkey!~kexkey@static-198-54-132-86.cust.tzulo.com> has quit IRC (Ping timeout: 265 seconds)
1552022-09-15T16:35:53 *** kexkey <kexkey!~kexkey@178.249.214.10> has joined #bitcoin-core-dev
1562022-09-15T16:37:37 *** andrewtoth_ <andrewtoth_!~andrewtot@gateway/tor-sasl/andrewtoth> has quit IRC (Remote host closed the connection)
1572022-09-15T16:56:37 *** andrewtoth <andrewtoth!~andrewtot@gateway/tor-sasl/andrewtoth> has joined #bitcoin-core-dev
1582022-09-15T17:18:28 <bitcoin-git> [bitcoin] achow101 pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/f332c4f64d52...96f1b2d34fd5
1592022-09-15T17:18:28 <bitcoin-git> bitcoin/master faa4916 MacroFake: test/doc: Remove unused syncwithvalidationinterfacequeue
1602022-09-15T17:18:29 <bitcoin-git> bitcoin/master fa1ce96 MacroFake: test: Add missing syncwithvalidationinterfacequeue
1612022-09-15T17:18:29 <bitcoin-git> bitcoin/master 96f1b2d Andrew Chow: Merge bitcoin/bitcoin#26091: test: Fix syncwithvalidationinterfacequeue ca...
1622022-09-15T17:18:30 <bitcoin-git> [bitcoin] achow101 merged pull request #26091: test: Fix syncwithvalidationinterfacequeue calls (master...2209-test-fix-ð») https://github.com/bitcoin/bitcoin/pull/26091
1632022-09-15T17:27:09 <bitcoin-git> [bitcoin] achow101 pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/96f1b2d34fd5...a56876e6b9da
1642022-09-15T17:27:10 <bitcoin-git> bitcoin/master cc434cb kouloumos: wallet: fix sendall creates tx that fails tx-size check
1652022-09-15T17:27:10 <bitcoin-git> bitcoin/master a56876e Andrew Chow: Merge bitcoin/bitcoin#26024: wallet: fix sendall creates tx that fails tx-...
1662022-09-15T17:27:10 <bitcoin-git> [bitcoin] achow101 merged pull request #26024: wallet: fix sendall creates tx that fails tx-size check (master...wallet-fix-sendall-tx-size) https://github.com/bitcoin/bitcoin/pull/26024
1672022-09-15T17:54:18 *** kouloumos <kouloumos!uid539228@id-539228.tinside.irccloud.com> has joined #bitcoin-core-dev
1682022-09-15T17:59:12 *** vasild <vasild!~vd@user/vasild> has quit IRC (Ping timeout: 258 seconds)
1692022-09-15T18:04:54 *** vasild <vasild!~vd@user/vasild> has joined #bitcoin-core-dev
1702022-09-15T18:19:16 <bitcoin-git> [bitcoin] sipa closed pull request #26065: i2p: use the same destination type for transient and persistent addresses (master...i2p_transient_addr_type) https://github.com/bitcoin/bitcoin/pull/26065
1712022-09-15T18:19:18 <bitcoin-git> [bitcoin] sipa reopened pull request #26065: i2p: use the same destination type for transient and persistent addresses (master...i2p_transient_addr_type) https://github.com/bitcoin/bitcoin/pull/26065
1722022-09-15T18:21:40 *** baldur <baldur!~baldur@pool-74-108-229-157.nycmny.fios.verizon.net> has quit IRC (Remote host closed the connection)
1732022-09-15T18:28:42 *** sipsorcery <sipsorcery!~sipsorcer@37.228.225.67> has joined #bitcoin-core-dev
1742022-09-15T18:30:13 *** baldur <baldur!~baldur@pool-74-108-229-157.nycmny.fios.verizon.net> has joined #bitcoin-core-dev
1752022-09-15T18:37:46 *** szkl <szkl!uid110435@id-110435.uxbridge.irccloud.com> has quit IRC (Quit: Connection closed for inactivity)
1762022-09-15T18:58:18 *** Talkless <Talkless!~Talkless@mail.dargis.net> has joined #bitcoin-core-dev
1772022-09-15T19:01:21 *** test_ <test_!flooded@gateway/vpn/protonvpn/flood/x-43489060> has joined #bitcoin-core-dev
1782022-09-15T19:03:13 <achow101> meeting?
1792022-09-15T19:04:04 <laanwj> #startmeeting
1802022-09-15T19:04:05 <core-meetingbot> Meeting started Thu Sep 15 19:04:04 2022 UTC. The chair is laanwj. Information about MeetBot at https://bitcoin.jonasschnelli.ch/ircmeetings.
1812022-09-15T19:04:05 <core-meetingbot> Available commands: action commands idea info link nick
1822022-09-15T19:04:20 <achow101> hi
1832022-09-15T19:04:24 <fanquake> hi
1842022-09-15T19:04:26 *** flooded <flooded!flooded@gateway/vpn/protonvpn/flood/x-43489060> has quit IRC (Ping timeout: 244 seconds)
1852022-09-15T19:04:29 <laanwj> #bitcoin-core-dev Meeting: achow101 _aj_ amiti ariard b10c BlueMatt cfields Chris_Stewart_5 darosior digi_james dongcarl elichai2 emilengler fanquake fjahr gleb glozow gmaxwell gwillen hebasto instagibbs jamesob jarolrod jb55 jeremyrubin jl2012 jnewbery jonasschnelli jonatack jtimon kallewoof kanzure kvaciral laanwj larryruane lightlike luke-jr maaku marcofalke meshcollider michagogo
1862022-09-15T19:04:30 <laanwj> moneyball morcos nehan NicolasDorier paveljanik petertodd phantomcircuit promag provoostenator ryanofsky sdaftuar sipa vasild
1872022-09-15T19:04:37 <laanwj> welcome to the weekly bitcoin-core-dev meeting
1882022-09-15T19:04:38 <jarolrod> hi
1892022-09-15T19:04:42 <kouloumos> hi
1902022-09-15T19:04:58 <laanwj> one proposed meeting topic this week: important changes in 24.0 to cover in the new RC Testing Guide (kouloumos)
1912022-09-15T19:05:05 <ajonas> hi
1922022-09-15T19:05:05 <lightlike> hi
1932022-09-15T19:05:18 <kanzure> hi
1942022-09-15T19:05:32 <achow101> will we be branching today too?
1952022-09-15T19:05:40 <furszy> hi
1962022-09-15T19:05:48 <cfields> hi
1972022-09-15T19:06:17 <sipa> hi
1982022-09-15T19:06:18 <laanwj> achow101: that's another topic to discuss
1992022-09-15T19:06:42 <kouloumos> should I go first or we are discussing high-priority first?
2002022-09-15T19:07:40 <hebasto> hi
2012022-09-15T19:07:41 <laanwj> we don't do high priority at the moment, though we could go over the milesteone
2022022-09-15T19:08:05 <fanquake> https://github.com/bitcoin/bitcoin/milestone/54
2032022-09-15T19:08:26 <laanwj> it seems that there's still some PRs open that need to go in before the split-off- anyhow
2042022-09-15T19:08:49 <MacroFake> Yeah, backporting one or two things is fine, but 5 seems too much
2052022-09-15T19:08:53 <laanwj> fanquake: ah im glad you noticed the release fragments in doc/release-notes, in #26093
2062022-09-15T19:08:54 <gribble> https://github.com/bitcoin/bitcoin/issues/26093 | doc: consolidate release-note fragments pre-wiki by fanquake · Pull Request #26093 · bitcoin/bitcoin · GitHub
2072022-09-15T19:09:19 <laanwj> i noticed those a few days ago then forgot to comment
2082022-09-15T19:09:56 <fanquake> A couple PRs on the milestone almost ready for merge. The few others likely be resolved / mergable in the next day or so I think.
2092022-09-15T19:10:12 <laanwj> MacroFake: right, backports makes sense for things that come as a surprise, not what has been open already for a while
2102022-09-15T19:11:43 <MacroFake> Maybe #26005 can be merged an someone picks up the feedback in a follow-up?
2112022-09-15T19:11:45 <gribble> https://github.com/bitcoin/bitcoin/issues/26005 | Wallet: Fix error handling (copy_file failure in RestoreWallet, and in general via interfaces) by luke-jr · Pull Request #26005 · bitcoin/bitcoin · GitHub
2122022-09-15T19:11:54 <laanwj> ok, so i think the answer is no, no branch-off today, there are still some things that need to go in
2132022-09-15T19:12:19 <lightlike> #26068 doesn't look likely to be resolved in the near future (at least I don't know why it happens / couldn't reproduce)
2142022-09-15T19:12:21 <gribble> https://github.com/bitcoin/bitcoin/issues/26068 | Segmentation fault in the scheduler thread when an index fails to commit to the db · Issue #26068 · bitcoin/bitcoin · GitHub
2152022-09-15T19:12:23 <achow101> MacroFake: I think that's reasonable
2162022-09-15T19:13:18 <MacroFake> lightlike: Did you try to force the failed commit, or just run the unit test as is?
2172022-09-15T19:14:27 <MacroFake> Locally I can't reproduce almost no issue seen in the CI and usually I have to modify the source code to force a sleep in the right place or so.
2182022-09-15T19:15:44 <lightlike> MacroFake: ran the test as it, and tried to change order of subtests in the src file to see if that could have been the reason, because in the failed CI runs the second subtest was run before the first one
2192022-09-15T19:16:17 <MacroFake> ok, I might take another look tomorrow, but otherwise it shouldn't block rc1 for now
2202022-09-15T19:17:28 <MacroFake> #25985 is just a performance thing, and not even a regression, so shouldn't block rc1 either
2212022-09-15T19:17:29 <gribble> https://github.com/bitcoin/bitcoin/issues/25985 | Revert "build: Use Homebrews sqlite package if it is available" by fanquake · Pull Request #25985 · bitcoin/bitcoin · GitHub
2222022-09-15T19:17:42 <fanquake> I somewhat disagree
2232022-09-15T19:18:29 <fanquake> It's causing continual confusion downstream, a new report overnight of devs becoming confused over terrible performance, this time in BDK: https://github.com/bitcoindevkit/bdk/issues/749
2242022-09-15T19:18:38 *** sipsorcery <sipsorcery!~sipsorcer@37.228.225.67> has quit IRC (Ping timeout: 268 seconds)
2252022-09-15T19:19:59 <fanquake> Although this is also easy to backport, so doesn't matter too much
2262022-09-15T19:20:16 <achow101> It also doesn't have any effect on our release binaries
2272022-09-15T19:20:17 <laanwj> doesn't seem too risky to merge an OSX specific build system revert?
2282022-09-15T19:20:47 *** sipsorcery <sipsorcery!~sipsorcer@37.228.225.67> has joined #bitcoin-core-dev
2292022-09-15T19:21:46 <fanquake> Yea, any risk is limited to compiling on macOS, which is why it's mostly devs posting issues
2302022-09-15T19:23:27 <laanwj> #topic important changes in 24.0 to cover in the new RC Testing Guide (kouloumos)
2312022-09-15T19:23:27 <core-meetingbot> topic: important changes in 24.0 to cover in the new RC Testing Guide (kouloumos)
2322022-09-15T19:23:39 <kouloumos> I'm working on the 24.0 RC Testing Guide and I'd like to get some feedback on which changes are considered important and useful to test.
2332022-09-15T19:23:46 <kouloumos> The current version is available here: https://gist.github.com/kouloumos/fc112640a533e522d435c0995dcaaaf4
2342022-09-15T19:23:53 <kouloumos> From the release notes ( https://github.com/bitcoin-core/bitcoin-devwiki/wiki/24.0-Release-Notes-draft ), I've already included testing guidance for 4 changes that I think most worthwhile to test and I have 1 pending. I'd appreciate feedback on if you think anything else should be included, and if maybe something can be omitted.
2352022-09-15T19:24:05 <kouloumos> The changes I've included are:
2362022-09-15T19:24:10 <kouloumos> 1) Using the GUI to restore a wallet from a backup file (#471)
2372022-09-15T19:24:11 <gribble> https://github.com/bitcoin/bitcoin/issues/471 | DbException after Ctrl+C on bitcoind.exe (Windows) · Issue #471 · bitcoin/bitcoin · GitHub
2382022-09-15T19:24:15 <kouloumos> 2) Peristent settings are now unified between bitcoind and the GUI. (#15936,#602)
2392022-09-15T19:24:19 <gribble> https://github.com/bitcoin/bitcoin/issues/15936 | interfaces: Expose settings.json methods to GUI by ryanofsky · Pull Request #15936 · bitcoin/bitcoin · GitHub
2402022-09-15T19:24:20 <gribble> https://github.com/bitcoin/bitcoin/issues/602 | Cleaned up critical section code. by cgaebel · Pull Request #602 · bitcoin/bitcoin · GitHub
2412022-09-15T19:24:21 <kouloumos> 3) Using the new migratewallet RPC to migrate legacy wallets to descriptor wallets. (#19602)
2422022-09-15T19:24:23 <gribble> https://github.com/bitcoin/bitcoin/issues/19602 | wallet: Migrate legacy wallets to descriptor wallets by achow101 · Pull Request #19602 · bitcoin/bitcoin · GitHub
2432022-09-15T19:24:28 <kouloumos> 4) Wallet support for watchonly Miniscript descriptors. (#24148)
2442022-09-15T19:24:31 <gribble> https://github.com/bitcoin/bitcoin/issues/24148 | Miniscript support in Output Descriptors by darosior · Pull Request #24148 · bitcoin/bitcoin · GitHub
2452022-09-15T19:24:38 <kouloumos> The additional change that I am planning to add is:
2462022-09-15T19:24:41 <kouloumos> 5) The new `sendall` RPC, useful to empty wallets or to create a changeless payment from select UTXOs. (#24118)
2472022-09-15T19:24:44 <gribble> https://github.com/bitcoin/bitcoin/issues/24118 | Add sendall RPC née sweep by Xekyo · Pull Request #24118 · bitcoin/bitcoin · GitHub
2482022-09-15T19:24:54 <kouloumos> Also, glozow suggested, and I am currently looking at:
2492022-09-15T19:24:58 <kouloumos> 6) Observe pre-syncing step during IBD (#25717)
2502022-09-15T19:25:05 <gribble> https://github.com/bitcoin/bitcoin/issues/25717 | p2p: Implement anti-DoS headers sync by sdaftuar · Pull Request #25717 · bitcoin/bitcoin · GitHub
2512022-09-15T19:25:11 <kouloumos> 7) Try new RPC gettxspendingprevout (#25874) 8) Try -mempoolfullrbf option (#25353)
2522022-09-15T19:25:12 <gribble> https://github.com/bitcoin/bitcoin/issues/25874 | BIP155 CJDNS address with length 187 (should be 16) · Issue #25874 · bitcoin/bitcoin · GitHub
2532022-09-15T19:25:14 <gribble> https://github.com/bitcoin/bitcoin/issues/25353 | Add a `-mempoolfullrbf` node setting by ariard · Pull Request #25353 · bitcoin/bitcoin · GitHub
2542022-09-15T19:25:28 <sipa> Cool
2552022-09-15T19:25:55 <lightlike> +1 for #25717 - can be tested by syncing headers on mainnet, testnet etc. with -stopatheight=1000 or so, with or without gui
2562022-09-15T19:25:59 <gribble> https://github.com/bitcoin/bitcoin/issues/25717 | p2p: Implement anti-DoS headers sync by sdaftuar · Pull Request #25717 · bitcoin/bitcoin · GitHub
2572022-09-15T19:26:53 <kouloumos> lightlike: appreciate the suggestion!
2582022-09-15T19:28:01 <sipa> For 25717 observing the pre-syncing phase is one thing (it should be there), but arguably the more interesting property is that syncing still works at all. It's only triggered when syncing a new node from scratch, or one that is ~months or more behind.
2592022-09-15T19:29:24 <lightlike> yes, the test guide should recommend to use an empty datadir for that.
2602022-09-15T19:30:02 <kouloumos> Yes, that's already suggested on every test.
2612022-09-15T19:32:15 <bitcoin-git> [bitcoin] stickies-v opened pull request #26103: refactor: mempool: use CTxMemPool::Limits (master...mempool-simplify-fn-signatures) https://github.com/bitcoin/bitcoin/pull/26103
2622022-09-15T19:32:39 <kouloumos> Great! thank you everyone, I'll look into including 25717 and give progress updates in https://github.com/bitcoin/bitcoin/issues/26092 . Please reach out with ideas and feedback. Thanks!
2632022-09-15T19:32:57 <kouloumos> Note: I'll also need write access to bitcoindev-wiki to add the guide.
2642022-09-15T19:32:59 <sipa> Feel free to ping me here if you have questions.
2652022-09-15T19:34:25 <kouloumos> I'll do! thanks
2662022-09-15T19:36:29 <laanwj> ok let's give you write access to the wiki
2672022-09-15T19:37:50 <laanwj> any other topics?
2682022-09-15T19:38:54 <laanwj> appparently not, let's close the meeting
2692022-09-15T19:38:56 <laanwj> #endmeeting
2702022-09-15T19:38:57 <core-meetingbot> topic: Bitcoin Core development discussion and commit log | Feel free to watch, but please take commentary and usage questions to #bitcoin | Channel logs: http://www.erisian.com.au/bitcoin-core-dev/, http://gnusha.org/bitcoin-core-dev/ | Meeting topics http://gnusha.org/bitcoin-core-dev/proposedmeetingtopics.txt / http://gnusha.org/bitcoin-core-dev/proposedwalletmeetingtopics.txt
2712022-09-15T19:38:57 <core-meetingbot> Meeting ended Thu Sep 15 19:38:56 2022 UTC.
2722022-09-15T19:38:57 <core-meetingbot> Minutes: https://bitcoin.jonasschnelli.ch/ircmeetings/logs/bitcoin-core-dev/2022/bitcoin-core-dev.2022-09-15-19.04.moin.txt
2732022-09-15T19:43:52 <bitcoin-git> [bitcoin] Xekyo opened pull request #26104: Check whether feerate is higher than long_term_feerate only once (master...2022-09-high-feerate-optimization) https://github.com/bitcoin/bitcoin/pull/26104
2742022-09-15T20:02:20 <bitcoin-git> [bitcoin] Xekyo closed pull request #26104: coin selection: Check whether feerate is higher than long_term_feerate only once (master...2022-09-high-feerate-optimization) https://github.com/bitcoin/bitcoin/pull/26104
2752022-09-15T20:50:06 <bitcoin-git> [bitcoin] sipa opened pull request #26105: Use ReadLE64 in uint256::GetUint64 instead of duplicating logic (master...202209_uint256_readle64) https://github.com/bitcoin/bitcoin/pull/26105
2762022-09-15T20:52:19 *** sipsorcery <sipsorcery!~sipsorcer@37.228.225.67> has quit IRC (Read error: Connection reset by peer)
2772022-09-15T20:56:59 *** brunoerg <brunoerg!~brunoerg@2804:14d:5281:8ae2:38cb:b7c9:7f5b:7bc9> has quit IRC ()
2782022-09-15T20:58:08 *** sipsorcery <sipsorcery!~sipsorcer@2a02:8084:6180:500::12b> has joined #bitcoin-core-dev
2792022-09-15T21:27:02 *** halosghost <halosghost!~halosghos@user/halosghost> has quit IRC (Quit: WeeChat 3.6)
2802022-09-15T21:27:33 *** Guyver2 <Guyver2!~Guyver@77-174-98-73.fixed.kpn.net> has quit IRC (Quit: Going offline, see ya! (www.adiirc.com))
2812022-09-15T21:57:24 *** sipsorcery <sipsorcery!~sipsorcer@2a02:8084:6180:500::12b> has quit IRC (Ping timeout: 264 seconds)
2822022-09-15T22:14:04 *** kouloumos <kouloumos!uid539228@id-539228.tinside.irccloud.com> has quit IRC (Quit: Connection closed for inactivity)
2832022-09-15T22:21:20 *** F1nny <F1nny!~f1nny@user/f1nny> has joined #bitcoin-core-dev
2842022-09-15T22:23:38 <robertspigler> Not 24.0 testing related, but I have been running 23.0 with i2prouter with `i2psam=127.0.0.1:7656` and `i2pacceptincoming=1` with my port forwarded. I know I am well connected because the console shows that I have used over 30GB bandwidth both in and out in ~5 days, have over 4,000 peers and over 10 tunnels. However, I had no automatically connected I2P peers, and after connecting to a few manual outbound I2P peers from
2852022-09-15T22:23:38 <robertspigler> bitcoin/contrib/seeds/nodes_main.txt, I still don't have any automatic outbound or inbound I2P peers. Is this an issue with preferential peering?
2862022-09-15T22:24:14 <robertspigler> I have ~40 connections, mostly IPv4 and a handful Onion, each both way
2872022-09-15T22:29:28 *** bomb-on <bomb-on!~bomb-on@user/bomb-on> has quit IRC (Quit: aллилѹÑа!)
2882022-09-15T22:38:32 *** sipsorcery <sipsorcery!~sipsorcer@2a02:8084:6180:500::12b> has joined #bitcoin-core-dev
2892022-09-15T23:14:44 *** sipsorcery <sipsorcery!~sipsorcer@2a02:8084:6180:500::12b> has quit IRC (Ping timeout: 268 seconds)
2902022-09-15T23:33:53 *** Evel-Knievel <Evel-Knievel!~Evel-Knie@user/evel-knievel> has quit IRC (Ping timeout: 252 seconds)
2912022-09-15T23:34:17 *** Evel-Knievel <Evel-Knievel!~Evel-Knie@user/evel-knievel> has joined #bitcoin-core-dev