12022-12-07T00:00:08 <achow101> any ideas why configuring with --enable-debug makes wallet_import_rescan.py go from taking 20 secs to 400 secs?
22022-12-07T00:38:16 <achow101> hmm, looks like generating a lot of blocks gets a lot slower with enable-debug
32022-12-07T00:43:50 *** dviola <dviola!~diego@179.235.13.211> has quit IRC (Quit: WeeChat 3.7.1)
42022-12-07T01:03:38 <sipa> Does --enable-debug enable a block index check or so?
52022-12-07T01:03:58 <sipa> Generating N blocks could have a quadratic effect (after every block, check the entire index).
62022-12-07T01:08:19 <achow101> I don't think so. I think it just disables some compiler optimizations
72022-12-07T01:09:48 <achow101> and enables debug lockorder and lock contention
82022-12-07T01:14:26 *** andrewtoth_ <andrewtoth_!~andrewtot@gateway/tor-sasl/andrewtoth> has quit IRC (Remote host closed the connection)
92022-12-07T01:16:25 *** andrewtoth <andrewtoth!~andrewtot@gateway/tor-sasl/andrewtoth> has joined #bitcoin-core-dev
102022-12-07T01:21:00 *** andrewtoth <andrewtoth!~andrewtot@gateway/tor-sasl/andrewtoth> has quit IRC (Remote host closed the connection)
112022-12-07T01:28:09 *** enyc <enyc!~enyc@user/enyc> has quit IRC (Ping timeout: 255 seconds)
122022-12-07T01:29:32 *** enyc <enyc!~enyc@user/enyc> has joined #bitcoin-core-dev
132022-12-07T02:16:55 *** SpellChecker <SpellChecker!~SpellChec@user/SpellChecker> has quit IRC (Remote host closed the connection)
142022-12-07T02:17:23 *** SpellChecker <SpellChecker!~SpellChec@user/SpellChecker> has joined #bitcoin-core-dev
152022-12-07T02:31:35 *** merlinB_ <merlinB_!~merlinB@i5C74C391.versanet.de> has quit IRC (Ping timeout: 260 seconds)
162022-12-07T02:43:14 *** andrewtoth <andrewtoth!~andrewtot@gateway/tor-sasl/andrewtoth> has joined #bitcoin-core-dev
172022-12-07T03:13:25 *** andrewtoth <andrewtoth!~andrewtot@gateway/tor-sasl/andrewtoth> has quit IRC (Remote host closed the connection)
182022-12-07T03:13:51 *** andrewtoth <andrewtoth!~andrewtot@gateway/tor-sasl/andrewtoth> has joined #bitcoin-core-dev
192022-12-07T03:14:10 *** ziggie <ziggie!uid521459@user/ziggie> has quit IRC (Quit: Connection closed for inactivity)
202022-12-07T03:16:56 *** bitdex <bitdex!~bitdex@gateway/tor-sasl/bitdex> has quit IRC (Remote host closed the connection)
212022-12-07T03:17:36 *** bitdex <bitdex!~bitdex@gateway/tor-sasl/bitdex> has joined #bitcoin-core-dev
222022-12-07T03:27:56 *** bitdex <bitdex!~bitdex@gateway/tor-sasl/bitdex> has quit IRC (Ping timeout: 255 seconds)
232022-12-07T03:29:32 *** vasild <vasild!~vd@user/vasild> has quit IRC (Remote host closed the connection)
242022-12-07T03:30:26 *** bitdex <bitdex!~bitdex@gateway/tor-sasl/bitdex> has joined #bitcoin-core-dev
252022-12-07T03:34:56 *** vasild <vasild!~vd@user/vasild> has joined #bitcoin-core-dev
262022-12-07T03:52:20 *** sloorush <sloorush!~sloorush@52.187.184.81> has quit IRC (Ping timeout: 248 seconds)
272022-12-07T03:52:52 *** sloorush <sloorush!~sloorush@52.187.184.81> has joined #bitcoin-core-dev
282022-12-07T03:55:04 *** bitdex <bitdex!~bitdex@gateway/tor-sasl/bitdex> has quit IRC (Remote host closed the connection)
292022-12-07T03:56:57 *** bitdex <bitdex!~bitdex@gateway/tor-sasl/bitdex> has joined #bitcoin-core-dev
302022-12-07T04:09:11 *** andrewtoth_ <andrewtoth_!~andrewtot@gateway/tor-sasl/andrewtoth> has joined #bitcoin-core-dev
312022-12-07T04:09:17 *** andrewtoth <andrewtoth!~andrewtot@gateway/tor-sasl/andrewtoth> has quit IRC (Remote host closed the connection)
322022-12-07T04:57:14 *** jon_atack <jon_atack!~jonatack@user/jonatack> has joined #bitcoin-core-dev
332022-12-07T04:59:39 *** jonatack <jonatack!~jonatack@user/jonatack> has quit IRC (Ping timeout: 260 seconds)
342022-12-07T05:01:01 *** cmirror <cmirror!~cmirror@4.53.92.114> has quit IRC (Remote host closed the connection)
352022-12-07T05:01:32 *** cmirror <cmirror!~cmirror@4.53.92.114> has joined #bitcoin-core-dev
362022-12-07T05:08:59 *** jon_atack <jon_atack!~jonatack@user/jonatack> has quit IRC (Ping timeout: 260 seconds)
372022-12-07T05:54:13 *** andrewtoth_ <andrewtoth_!~andrewtot@gateway/tor-sasl/andrewtoth> has quit IRC (Remote host closed the connection)
382022-12-07T05:54:57 *** andrewtoth_ <andrewtoth_!~andrewtot@gateway/tor-sasl/andrewtoth> has joined #bitcoin-core-dev
392022-12-07T05:56:27 *** andrewtoth_ <andrewtoth_!~andrewtot@gateway/tor-sasl/andrewtoth> has quit IRC (Remote host closed the connection)
402022-12-07T05:56:51 *** andrewtoth_ <andrewtoth_!~andrewtot@gateway/tor-sasl/andrewtoth> has joined #bitcoin-core-dev
412022-12-07T06:04:03 *** bitdex <bitdex!~bitdex@gateway/tor-sasl/bitdex> has quit IRC (Remote host closed the connection)
422022-12-07T06:04:04 *** vasild <vasild!~vd@user/vasild> has quit IRC (Read error: Connection reset by peer)
432022-12-07T06:04:04 *** SpellChecker <SpellChecker!~SpellChec@user/SpellChecker> has quit IRC (Read error: Connection reset by peer)
442022-12-07T06:04:04 *** andrewtoth_ <andrewtoth_!~andrewtot@gateway/tor-sasl/andrewtoth> has quit IRC (Read error: Connection reset by peer)
452022-12-07T06:04:25 *** vasild <vasild!~vd@user/vasild> has joined #bitcoin-core-dev
462022-12-07T06:04:32 *** andrewtoth_ <andrewtoth_!~andrewtot@gateway/tor-sasl/andrewtoth> has joined #bitcoin-core-dev
472022-12-07T06:04:52 *** bitdex <bitdex!~bitdex@gateway/tor-sasl/bitdex> has joined #bitcoin-core-dev
482022-12-07T06:07:22 *** andrewtoth_ <andrewtoth_!~andrewtot@gateway/tor-sasl/andrewtoth> has quit IRC (Remote host closed the connection)
492022-12-07T06:07:27 *** SpellChecker <SpellChecker!~SpellChec@user/SpellChecker> has joined #bitcoin-core-dev
502022-12-07T06:08:09 *** andrewtoth_ <andrewtoth_!~andrewtot@gateway/tor-sasl/andrewtoth> has joined #bitcoin-core-dev
512022-12-07T06:09:32 *** andrewtoth_ <andrewtoth_!~andrewtot@gateway/tor-sasl/andrewtoth> has quit IRC (Remote host closed the connection)
522022-12-07T06:10:43 *** andrewtoth_ <andrewtoth_!~andrewtot@gateway/tor-sasl/andrewtoth> has joined #bitcoin-core-dev
532022-12-07T06:13:11 *** vasild <vasild!~vd@user/vasild> has quit IRC (Remote host closed the connection)
542022-12-07T06:18:26 *** vasild <vasild!~vd@user/vasild> has joined #bitcoin-core-dev
552022-12-07T06:21:15 *** andrewtoth_ <andrewtoth_!~andrewtot@gateway/tor-sasl/andrewtoth> has quit IRC (Remote host closed the connection)
562022-12-07T06:21:44 *** andrewtoth_ <andrewtoth_!~andrewtot@gateway/tor-sasl/andrewtoth> has joined #bitcoin-core-dev
572022-12-07T06:24:38 *** SpellChecker <SpellChecker!~SpellChec@user/SpellChecker> has quit IRC (Remote host closed the connection)
582022-12-07T06:26:04 *** SpellChecker <SpellChecker!~SpellChec@user/SpellChecker> has joined #bitcoin-core-dev
592022-12-07T07:11:21 *** bitdex <bitdex!~bitdex@gateway/tor-sasl/bitdex> has quit IRC (Remote host closed the connection)
602022-12-07T07:12:18 *** bitdex <bitdex!~bitdex@gateway/tor-sasl/bitdex> has joined #bitcoin-core-dev
612022-12-07T07:49:22 <bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/0596aa40f77a...272fb0a5cf2c
622022-12-07T07:49:23 <bitcoin-git> bitcoin/master fa825bd MarcoFalke: util: Include full version id in bug reports
632022-12-07T07:49:23 <bitcoin-git> bitcoin/master 272fb0a MarcoFalke: Merge bitcoin/bitcoin#26645: util: Include full version id in bug reports
642022-12-07T07:49:28 <bitcoin-git> [bitcoin] MarcoFalke merged pull request #26645: util: Include full version id in bug reports (master...2212-full-version-id-ð) https://github.com/bitcoin/bitcoin/pull/26645
652022-12-07T07:51:55 *** zeropoint <zeropoint!~alex@c-67-169-157-130.hsd1.ca.comcast.net> has quit IRC (Quit: leaving)
662022-12-07T07:57:33 *** AaronvanW <AaronvanW!~AaronvanW@user/AaronvanW> has joined #bitcoin-core-dev
672022-12-07T08:11:20 <vasild> If PR1 introducing some feature gets merged seemingly without controversy and shortly afterwards PR2 attempts to revert PR1 and PR2 turns out to be strongly controversal with many strong ACKs and NACKs, then I think it follows that PR1 would have been controversal too if the people ACKings the reversal were aware of it and its implications. Could that be a reason to merge the reversal PR2 even
682022-12-07T08:11:26 <vasild> though it is controversal? (I am not taking side in the fullrbf debate)
692022-12-07T08:32:48 *** sipsorcery <sipsorcery!~sipsorcer@2a02:8084:6180:500::12b> has joined #bitcoin-core-dev
702022-12-07T08:44:00 *** lowhope <lowhope!~lowhope@2602:fffa:fff:108a:0:16:3e86:c70e> has quit IRC (Ping timeout: 260 seconds)
712022-12-07T08:46:07 *** lowhope_ <lowhope_!~lowhope@2602:fffa:fff:108a:0:16:3e86:c70e> has joined #bitcoin-core-dev
722022-12-07T08:53:13 *** Guest6 <Guest6!~Guest6@89-179-32-96.broadband.corbina.ru> has joined #bitcoin-core-dev
732022-12-07T08:53:59 *** Guest6 <Guest6!~Guest6@89-179-32-96.broadband.corbina.ru> has quit IRC (Client Quit)
742022-12-07T08:55:08 *** _andrewtoth_ <_andrewtoth_!~andrewtot@gateway/tor-sasl/andrewtoth> has joined #bitcoin-core-dev
752022-12-07T08:57:20 *** andrewtoth_ <andrewtoth_!~andrewtot@gateway/tor-sasl/andrewtoth> has quit IRC (Ping timeout: 255 seconds)
762022-12-07T09:00:31 <josie[m]> vasild: "then I think it follows that PR1 would have been controversal too if the people ACKings the reversal were aware of it and its implications" i dont think this is necessarily always true. it may apply to some cases but not enough to prescribe as a general rule. better to treat PRs on a case by case basis, imo
772022-12-07T09:01:04 <vasild> josie[m]: yeah, I agree
782022-12-07T09:07:39 *** SpellChecker <SpellChecker!~SpellChec@user/SpellChecker> has quit IRC (Remote host closed the connection)
792022-12-07T09:11:26 *** SpellChecker <SpellChecker!~SpellChec@user/SpellChecker> has joined #bitcoin-core-dev
802022-12-07T09:15:59 *** sipsorcery <sipsorcery!~sipsorcer@2a02:8084:6180:500::12b> has quit IRC (Ping timeout: 260 seconds)
812022-12-07T09:23:54 *** bitdex <bitdex!~bitdex@gateway/tor-sasl/bitdex> has quit IRC (Remote host closed the connection)
822022-12-07T09:25:05 *** bitdex <bitdex!~bitdex@gateway/tor-sasl/bitdex> has joined #bitcoin-core-dev
832022-12-07T09:26:44 *** andrewtoth_ <andrewtoth_!~andrewtot@gateway/tor-sasl/andrewtoth> has joined #bitcoin-core-dev
842022-12-07T09:28:50 *** vasild <vasild!~vd@user/vasild> has quit IRC (Ping timeout: 255 seconds)
852022-12-07T09:29:02 <bitcoinerrorlog> In the case of RBF topics, I think it's fair to say they have always been controversial. In the case of mempoolfullrbf, I think it is fair to say there was controversy before v24 actually shipped, evidenced by quite a few mailing list posts, the original version of my PR by Suhas, etc. The current debate is made more complicated by uncertainty around what is procedure, what the actual benefit of mempoolfullrbf might
862022-12-07T09:29:02 <bitcoinerrorlog> n/whether it is okay to break the user space.
872022-12-07T09:29:17 *** _andrewtoth_ <_andrewtoth_!~andrewtot@gateway/tor-sasl/andrewtoth> has quit IRC (Ping timeout: 255 seconds)
882022-12-07T09:39:10 *** vasild <vasild!~vd@user/vasild> has joined #bitcoin-core-dev
892022-12-07T09:40:47 <fanquake> To github.com:bitcoin-core/bitcoin-detached-sigs.git
902022-12-07T09:40:51 <fanquake> * [new tag] v24.0.1 -> v24.0.1
912022-12-07T09:41:19 <bitcoin-git> [bitcoin] MarcoFalke opened pull request #26651: test: Avoid intermittent timeout in feature_assumevalid.py (master...2212-test-fix-assumevalid-ð) https://github.com/bitcoin/bitcoin/pull/26651
922022-12-07T09:42:46 *** mudsip <mudsip!~mudsip@user/mudsip> has joined #bitcoin-core-dev
932022-12-07T09:45:22 *** mudsip <mudsip!~mudsip@user/mudsip> has quit IRC (Client Quit)
942022-12-07T09:46:22 *** szkl <szkl!uid110435@id-110435.uxbridge.irccloud.com> has joined #bitcoin-core-dev
952022-12-07T09:57:49 *** Lightsword <Lightsword!~Lightswor@user/lightsword> has quit IRC (Quit: ZNC)
962022-12-07T09:58:17 *** windsok <windsok!~windsok@rarepepe.cash> has quit IRC (Quit: No Ping reply in 180 seconds.)
972022-12-07T09:59:26 *** Lightsword <Lightsword!~Lightswor@user/lightsword> has joined #bitcoin-core-dev
982022-12-07T10:00:32 *** windsok <windsok!~windsok@rarepepe.cash> has joined #bitcoin-core-dev
992022-12-07T10:04:16 *** vasild <vasild!~vd@user/vasild> has quit IRC (Remote host closed the connection)
1002022-12-07T10:12:25 *** GregTonoski <GregTonoski!~GregTonos@oyf170.internetdsl.tpnet.pl> has joined #bitcoin-core-dev
1012022-12-07T10:14:38 *** vasild <vasild!~vd@user/vasild> has joined #bitcoin-core-dev
1022022-12-07T10:48:41 *** GregTonoski <GregTonoski!~GregTonos@oyf170.internetdsl.tpnet.pl> has quit IRC (Quit: Client closed)
1032022-12-07T10:56:12 *** sipsorcery <sipsorcery!~sipsorcer@2a02:8084:6180:500::12b> has joined #bitcoin-core-dev
1042022-12-07T11:03:14 *** ajonas <ajonas!sid385278@id-385278.helmsley.irccloud.com> has quit IRC (Quit: Connection closed for inactivity)
1052022-12-07T11:04:10 *** sipsorcery <sipsorcery!~sipsorcer@2a02:8084:6180:500::12b> has quit IRC (Ping timeout: 252 seconds)
1062022-12-07T11:14:08 *** vasild <vasild!~vd@user/vasild> has quit IRC (Ping timeout: 255 seconds)
1072022-12-07T11:14:30 *** vasild <vasild!~vd@user/vasild> has joined #bitcoin-core-dev
1082022-12-07T11:16:23 *** bitdex <bitdex!~bitdex@gateway/tor-sasl/bitdex> has quit IRC (Ping timeout: 255 seconds)
1092022-12-07T11:18:18 *** bitdex <bitdex!~bitdex@gateway/tor-sasl/bitdex> has joined #bitcoin-core-dev
1102022-12-07T11:27:46 *** AaronvanW <AaronvanW!~AaronvanW@user/AaronvanW> has quit IRC (Remote host closed the connection)
1112022-12-07T11:52:57 <bitcoin-git> [bitcoin] dergoegge closed pull request #26590: net, refactor: Kill proxy globals (master...2022-11-socks5-refactor) https://github.com/bitcoin/bitcoin/pull/26590
1122022-12-07T11:55:31 <bitcoin-git> [bitcoin] dergoegge closed pull request #26583: net: Make CNode message process queue private (master...2022-11-connman-pollmessage) https://github.com/bitcoin/bitcoin/pull/26583
1132022-12-07T11:58:32 *** brunoerg <brunoerg!~brunoerg@2804:14d:5281:8ae2:5122:644c:c142:5646> has joined #bitcoin-core-dev
1142022-12-07T11:58:55 *** AaronvanW <AaronvanW!~AaronvanW@user/AaronvanW> has joined #bitcoin-core-dev
1152022-12-07T12:32:48 *** AaronvanW <AaronvanW!~AaronvanW@user/AaronvanW> has quit IRC (Ping timeout: 265 seconds)
1162022-12-07T12:50:44 *** andrewtoth_ <andrewtoth_!~andrewtot@gateway/tor-sasl/andrewtoth> has quit IRC (Remote host closed the connection)
1172022-12-07T12:52:23 *** andrewtoth_ <andrewtoth_!~andrewtot@gateway/tor-sasl/andrewtoth> has joined #bitcoin-core-dev
1182022-12-07T13:05:08 *** bitdex <bitdex!~bitdex@gateway/tor-sasl/bitdex> has quit IRC (Quit: = "")
1192022-12-07T13:21:38 *** AaronvanW <AaronvanW!~AaronvanW@user/AaronvanW> has joined #bitcoin-core-dev
1202022-12-07T13:28:14 *** vasild <vasild!~vd@user/vasild> has quit IRC (Ping timeout: 255 seconds)
1212022-12-07T13:30:04 *** vasild <vasild!~vd@user/vasild> has joined #bitcoin-core-dev
1222022-12-07T13:53:31 *** jon_atack <jon_atack!~jonatack@user/jonatack> has joined #bitcoin-core-dev
1232022-12-07T13:59:33 *** jonatack1 <jonatack1!~jonatack@user/jonatack> has joined #bitcoin-core-dev
1242022-12-07T14:00:59 *** jon_atack <jon_atack!~jonatack@user/jonatack> has quit IRC (Ping timeout: 260 seconds)
1252022-12-07T14:36:28 *** jtraub91 <jtraub91!~jason@2601:581:8100:7cb0:8107:b66:e649:b1a8> has joined #bitcoin-core-dev
1262022-12-07T14:46:52 *** jonatack1 <jonatack1!~jonatack@user/jonatack> has quit IRC (Ping timeout: 252 seconds)
1272022-12-07T14:47:30 *** jonatack1 <jonatack1!~jonatack@user/jonatack> has joined #bitcoin-core-dev
1282022-12-07T14:54:51 <bitcoin-git> [bitcoin] fanquake pushed 4 commits to master: https://github.com/bitcoin/bitcoin/compare/272fb0a5cf2c...7d515600034b
1292022-12-07T14:54:51 <bitcoin-git> bitcoin/master 82e272a Ryan Ofsky: refactor: Move src/interfaces/*.cpp files to libbitcoin_common.a
1302022-12-07T14:54:52 <bitcoin-git> bitcoin/master dd6e8bd fanquake: build: remove BOOST_CPPFLAGS from libbitcoin_util
1312022-12-07T14:54:52 <bitcoin-git> bitcoin/master b19c412 Ryan Ofsky: refactor: Rename ambiguous interfaces::MakeHandler functions
1322022-12-07T14:54:57 <bitcoin-git> [bitcoin] fanquake merged pull request #26298: refactor: Move src/interfaces/*.cpp files to libbitcoin_common.a (master...pr/intclean) https://github.com/bitcoin/bitcoin/pull/26298
1332022-12-07T15:07:13 *** Ombre <Ombre!~debianvm1@82.180.149.170> has joined #bitcoin-core-dev
1342022-12-07T15:53:19 *** halosghost <halosghost!~halosghos@user/halosghost> has joined #bitcoin-core-dev
1352022-12-07T15:57:25 *** pablomartin <pablomartin!~pablomart@195.234.124.17> has joined #bitcoin-core-dev
1362022-12-07T16:03:56 *** jonatack1 <jonatack1!~jonatack@user/jonatack> has quit IRC (Ping timeout: 246 seconds)
1372022-12-07T16:04:35 *** AaronvanW <AaronvanW!~AaronvanW@user/AaronvanW> has quit IRC (Remote host closed the connection)
1382022-12-07T16:15:26 *** Guest52 <Guest52!~Guest52@188.70.18.201> has joined #bitcoin-core-dev
1392022-12-07T16:24:21 *** rozehnal_paul <rozehnal_paul!~rozehnal_@198.168.27.218> has joined #bitcoin-core-dev
1402022-12-07T16:24:37 *** rozehnal_paul42 <rozehnal_paul42!~rozehnal_@198.168.27.218> has joined #bitcoin-core-dev
1412022-12-07T16:25:45 *** rozehnal_paul42 <rozehnal_paul42!~rozehnal_@198.168.27.218> has quit IRC (Client Quit)
1422022-12-07T16:35:16 <bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/7d515600034b...9052d869c967
1432022-12-07T16:35:17 <bitcoin-git> bitcoin/master 6fb102c Randall Naar: test: Changed small_txpuzzle_randfee to return the virtual size instead of...
1442022-12-07T16:35:18 <bitcoin-git> bitcoin/master 9052d86 MarcoFalke: Merge bitcoin/bitcoin#26517: test: Changed small_txpuzzle_randfee to retur...
1452022-12-07T16:35:25 <bitcoin-git> [bitcoin] MarcoFalke merged pull request #26517: test: Changed small_txpuzzle_randfee to return the virtual size instead of the transaction hex for feerate calculation. (master...use-vsize-for-fee-tests) https://github.com/bitcoin/bitcoin/pull/26517
1462022-12-07T16:35:39 *** AaronvanW <AaronvanW!~AaronvanW@user/AaronvanW> has joined #bitcoin-core-dev
1472022-12-07T16:39:42 *** pablomartin4btc <pablomartin4btc!~pablomart@109.69.107.225> has joined #bitcoin-core-dev
1482022-12-07T16:42:19 *** pablomartin <pablomartin!~pablomart@195.234.124.17> has quit IRC (Ping timeout: 248 seconds)
1492022-12-07T16:44:26 *** Guest52 <Guest52!~Guest52@188.70.18.201> has quit IRC (Quit: Client closed)
1502022-12-07T16:47:40 *** Ombre <Ombre!~debianvm1@82.180.149.170> has left #bitcoin-core-dev
1512022-12-07T16:50:01 *** ghost43_ <ghost43_!~ghost43@gateway/tor-sasl/ghost43> has joined #bitcoin-core-dev
1522022-12-07T16:50:43 *** b_101 <b_101!~robert@173.254.196.62.adsl.inet-telecom.org> has joined #bitcoin-core-dev
1532022-12-07T16:50:44 *** ghost43 <ghost43!~ghost43@gateway/tor-sasl/ghost43> has quit IRC (Ping timeout: 255 seconds)
1542022-12-07T17:02:07 *** yashraj <yashraj!yashraj@gateway/vpn/protonvpn/yashraj> has joined #bitcoin-core-dev
1552022-12-07T17:02:37 *** ghost43_ <ghost43_!~ghost43@gateway/tor-sasl/ghost43> has quit IRC (Remote host closed the connection)
1562022-12-07T17:02:54 *** ghost43 <ghost43!~ghost43@gateway/tor-sasl/ghost43> has joined #bitcoin-core-dev
1572022-12-07T17:12:24 <bitcoin-git> [bitcoin] brunoerg opened pull request #26653: test, init: perturb file to ensure failure instead of only deleting them (master...2022-12-stress-test-perturbing) https://github.com/bitcoin/bitcoin/pull/26653
1582022-12-07T17:20:57 <sdaftuar> glozow: i was just looking at your comment in #26451 about the mining-on-a-mempool-cluster code in #26152, which i just took a look at.
1592022-12-07T17:21:00 <gribble> https://github.com/bitcoin/bitcoin/issues/26451 | Enforce incentive compatibility for all RBF replacements by sdaftuar · Pull Request #26451 · bitcoin/bitcoin · GitHub
1602022-12-07T17:21:05 <gribble> https://github.com/bitcoin/bitcoin/issues/26152 | Bump unconfirmed ancestor transactions to target feerate by Xekyo · Pull Request #26152 · bitcoin/bitcoin · GitHub
1612022-12-07T17:21:40 <sdaftuar> glozow: am i correct in understanding that the CalculateCluster function could pull in the whole mempool, and isn't constrained by ancestor/descendant limits?
1622022-12-07T17:22:01 <sdaftuar> (that's my read of what connectedness means, so i want to check to see if i might have misunderstood)
1632022-12-07T17:24:17 <sdaftuar> Murch: ^ you may know the answer to this as well?
1642022-12-07T17:27:33 <glozow> sdaftuar: yes correct, that is possible
1652022-12-07T17:30:43 <sdaftuar> thank you!
1662022-12-07T17:31:57 *** Talkless <Talkless!~Talkless@mail.dargis.net> has joined #bitcoin-core-dev
1672022-12-07T17:37:10 <glozow> (so yeah, not really acceptable if calling from p2p)
1682022-12-07T17:38:10 <glozow> it should be very easy to implement a stopping point based on number of entries visited for example. but if we need an answer...
1692022-12-07T17:43:26 <sdaftuar> glozow: i was thinking that perhaps we could just look at the direct conflicts + ancestors. that has the benefit of the RBF reasoning being "local", in the sense that unrelated transactions are excluded from the logic (which seems better for reasoning), and also limits computational complexity
1702022-12-07T17:44:00 <sdaftuar> however that is still potentially a lot of transactions (roughly 2500 i think, with the 100-reaplcement rule in effect)
1712022-12-07T17:44:48 <sdaftuar> also, you might want to consider putting in some kind of similar limit for the wallet
1722022-12-07T17:45:23 <sdaftuar> but i haven't reviewed the PR so can't really comment, just seems worrisome on its face
1732022-12-07T17:45:48 *** b_101 <b_101!~robert@173.254.196.62.adsl.inet-telecom.org> has quit IRC (Ping timeout: 252 seconds)
1742022-12-07T17:50:06 *** yashraj <yashraj!yashraj@gateway/vpn/protonvpn/yashraj> has quit IRC (Remote host closed the connection)
1752022-12-07T17:50:41 *** yashraj <yashraj!yashraj@gateway/vpn/protonvpn/yashraj> has joined #bitcoin-core-dev
1762022-12-07T17:55:30 *** yashraj <yashraj!yashraj@gateway/vpn/protonvpn/yashraj> has quit IRC (Ping timeout: 256 seconds)
1772022-12-07T18:00:22 *** sipsorcery <sipsorcery!~sipsorcer@2a02:8084:6180:500::12b> has joined #bitcoin-core-dev
1782022-12-07T18:02:18 <glozow> agree a limit makes sense for wallet-only as well yes
1792022-12-07T18:02:18 <glozow> My initial reaction is that limiting to direct conflicts + ancestors leaves quite a bit of room for underestimation, as I tend to think of these things as "can somebody pin." Improving the heuristic even if still perfect seems worthwhile given the current Rule #2 has little impact on "can somebody pin" anyway.
1802022-12-07T18:02:21 <gribble> https://github.com/bitcoin/bitcoin/issues/2 | Long-term, safe, store-of-value · Issue #2 · bitcoin/bitcoin · GitHub
1812022-12-07T18:02:24 <glozow> still imperfect*
1822022-12-07T18:21:35 <bitcoin-git> [bitcoin] john-moffett opened pull request #26654: util: Show descriptive error messages when FileCommit fails (master...2022_12_BetterSystemErrorLogging) https://github.com/bitcoin/bitcoin/pull/26654
1832022-12-07T18:34:03 *** rozehnal_paul <rozehnal_paul!~rozehnal_@198.168.27.218> has quit IRC (Quit: Connection closed)
1842022-12-07T18:37:47 *** andrewtoth_ <andrewtoth_!~andrewtot@gateway/tor-sasl/andrewtoth> has quit IRC (Remote host closed the connection)
1852022-12-07T18:38:24 *** andrewtoth_ <andrewtoth_!~andrewtot@gateway/tor-sasl/andrewtoth> has joined #bitcoin-core-dev
1862022-12-07T18:38:39 *** sipsorcery <sipsorcery!~sipsorcer@2a02:8084:6180:500::12b> has quit IRC (Remote host closed the connection)
1872022-12-07T18:38:54 *** sipsorcery <sipsorcery!~sipsorcer@2a02:8084:6180:500::12b> has joined #bitcoin-core-dev
1882022-12-07T18:41:12 *** Talkless <Talkless!~Talkless@mail.dargis.net> has quit IRC (Quit: Konversation terminated!)
1892022-12-07T18:41:43 *** Talkless <Talkless!~Talkless@mail.dargis.net> has joined #bitcoin-core-dev
1902022-12-07T18:45:24 *** bitcoinerrorlog1 <bitcoinerrorlog1!~Adium@bl10-161-110.dsl.telepac.pt> has joined #bitcoin-core-dev
1912022-12-07T18:49:15 *** bitcoinerrorlog <bitcoinerrorlog!~Adium@2001:8a0:6cc3:5a00:29ca:b6bb:9a75:618e> has quit IRC (Ping timeout: 260 seconds)
1922022-12-07T18:54:36 *** zeropoint <zeropoint!~alex@c-67-169-157-130.hsd1.ca.comcast.net> has joined #bitcoin-core-dev
1932022-12-07T19:02:28 *** codo <codo!~codeautis@user/codeautist> has joined #bitcoin-core-dev
1942022-12-07T19:18:25 *** cotsuka9 <cotsuka9!~cotsuka@user/cotsuka> has joined #bitcoin-core-dev
1952022-12-07T19:19:37 *** jonatack1 <jonatack1!~jonatack@user/jonatack> has joined #bitcoin-core-dev
1962022-12-07T19:19:50 *** cotsuka <cotsuka!~cotsuka@user/cotsuka> has quit IRC (Ping timeout: 268 seconds)
1972022-12-07T19:19:51 *** cotsuka9 is now known as cotsuka
1982022-12-07T19:50:37 <Murch> glozow: We chatted a bunch about this today at lunch. I think that if we considered all ancestors and only our own other relatives for each UTXO, we would only be prone to overestimating bump fees by essentially not relying on bumping by foreign descendants of our ancestry.
1992022-12-07T19:57:43 <sdaftuar> glozow: er i misspoke when i said "direct conflicts and ancestors". what i was thinking in my head was "all conflicts and their ancestors"
2002022-12-07T19:58:02 <sdaftuar> glozow: but not sure i follow what you mean by leaving room for underestimation, can you clarify?
2012022-12-07T19:59:52 <sdaftuar> i think that underestimating the mining scores of what is in the mempool (eg because we exclude parts of the transaction graph which might make those conflicting transactions actually have a higher score)
2022022-12-07T20:00:13 <sdaftuar> results in less "pinning" because new transactions don't need to pay as much as they really should
2032022-12-07T20:00:29 <sdaftuar> that's an incentive compatibility issue, though -- but maybe a small isssue in practice
2042022-12-07T20:01:27 <sdaftuar> where it gets murkier is exactly what comparison we do. in the world where we use a mini-miner on a transaction subgraph, is the right calculation to ensure that the mining score of the new transaction is strictly better than that of all the to-be-replaced transactions? or do we quantify things in some more precise way?
2052022-12-07T20:28:22 *** SpellChecker <SpellChecker!~SpellChec@user/SpellChecker> has quit IRC (Quit: bye)
2062022-12-07T20:29:17 *** SpellChecker <SpellChecker!~SpellChec@user/SpellChecker> has joined #bitcoin-core-dev
2072022-12-07T20:31:17 *** Talkless <Talkless!~Talkless@mail.dargis.net> has quit IRC (Quit: Konversation terminated!)
2082022-12-07T20:43:48 *** sipsorcery <sipsorcery!~sipsorcer@2a02:8084:6180:500::12b> has quit IRC (Ping timeout: 256 seconds)
2092022-12-07T20:44:33 *** sipsorcery <sipsorcery!~sipsorcer@37.228.225.67> has joined #bitcoin-core-dev
2102022-12-07T20:47:12 *** andrewtoth_ <andrewtoth_!~andrewtot@gateway/tor-sasl/andrewtoth> has quit IRC (Remote host closed the connection)
2112022-12-07T20:49:06 *** andrewtoth_ <andrewtoth_!~andrewtot@gateway/tor-sasl/andrewtoth> has joined #bitcoin-core-dev
2122022-12-07T20:53:17 *** jonatack1 <jonatack1!~jonatack@user/jonatack> has quit IRC (Ping timeout: 252 seconds)
2132022-12-07T21:01:11 *** andrewtoth_ <andrewtoth_!~andrewtot@gateway/tor-sasl/andrewtoth> has quit IRC (Remote host closed the connection)
2142022-12-07T21:01:44 *** Guest42 <Guest42!~Guest42@2600:4041:5318:e600:3967:f9c4:14b4:d9df> has joined #bitcoin-core-dev
2152022-12-07T21:01:47 *** andrewtoth_ <andrewtoth_!~andrewtot@gateway/tor-sasl/andrewtoth> has joined #bitcoin-core-dev
2162022-12-07T21:02:56 *** Guest42 <Guest42!~Guest42@2600:4041:5318:e600:3967:f9c4:14b4:d9df> has quit IRC (Client Quit)
2172022-12-07T21:05:25 *** jtraub91 <jtraub91!~jason@2601:581:8100:7cb0:8107:b66:e649:b1a8> has quit IRC (Ping timeout: 260 seconds)
2182022-12-07T21:29:47 *** pablomartin4btc <pablomartin4btc!~pablomart@109.69.107.225> has quit IRC (Ping timeout: 260 seconds)
2192022-12-07T21:36:31 *** jtraub91 <jtraub91!~jason@2601:581:8100:7cb0:8107:b66:e649:b1a8> has joined #bitcoin-core-dev
2202022-12-07T21:40:59 *** jtraub91 <jtraub91!~jason@2601:581:8100:7cb0:8107:b66:e649:b1a8> has quit IRC (Ping timeout: 260 seconds)
2212022-12-07T21:50:55 *** brunoerg <brunoerg!~brunoerg@2804:14d:5281:8ae2:5122:644c:c142:5646> has quit IRC ()
2222022-12-07T21:55:00 *** b_101 <b_101!~robert@173.254.196.62.adsl.inet-telecom.org> has joined #bitcoin-core-dev
2232022-12-07T21:59:54 *** b_101 <b_101!~robert@173.254.196.62.adsl.inet-telecom.org> has quit IRC (Ping timeout: 260 seconds)
2242022-12-07T22:31:17 *** halosghost <halosghost!~halosghos@user/halosghost> has quit IRC (Quit: WeeChat 3.7.1)
2252022-12-07T22:39:23 *** b_101 <b_101!~robert@173.254.196.62.adsl.inet-telecom.org> has joined #bitcoin-core-dev
2262022-12-07T23:07:42 *** bitdex <bitdex!~bitdex@gateway/tor-sasl/bitdex> has joined #bitcoin-core-dev
2272022-12-07T23:29:53 *** yanmaani1 <yanmaani1!~yanmaani@gateway/tor-sasl/yanmaani> has quit IRC (Ping timeout: 255 seconds)
2282022-12-07T23:30:41 <bitcoin-git> [bitcoin] achow101 pushed 4 commits to master: https://github.com/bitcoin/bitcoin/compare/9052d869c967...bbfcbcfa0c10
2292022-12-07T23:30:41 <bitcoin-git> bitcoin/master a27a445 willcl-ark: refactor: Sub-folder bash completions
2302022-12-07T23:30:41 <bitcoin-git> bitcoin/master 7075848 willcl-ark: script: Add fish completions
2312022-12-07T23:30:42 <bitcoin-git> bitcoin/master ccba4fe willcl-ark: doc: Add completion subdir to contrib/README.md
2322022-12-07T23:30:55 <bitcoin-git> [bitcoin] achow101 merged pull request #24611: Add fish completions (master...fish_completions) https://github.com/bitcoin/bitcoin/pull/24611
2332022-12-07T23:32:41 *** yanmaani1 <yanmaani1!~yanmaani@gateway/tor-sasl/yanmaani> has joined #bitcoin-core-dev
2342022-12-07T23:42:53 <bitcoin-git> [bitcoin] achow101 pushed 5 commits to master: https://github.com/bitcoin/bitcoin/compare/bbfcbcfa0c10...a653f4bb1f06
2352022-12-07T23:42:53 <bitcoin-git> bitcoin/master 852891f brunoerg: refactor, wallet: use optional for `label` in `ListTransactions`
2362022-12-07T23:42:54 <bitcoin-git> bitcoin/master 722e9a4 brunoerg: wallet, rpc: add `label` to `listsinceblock`
2372022-12-07T23:42:54 <bitcoin-git> bitcoin/master fe488b4 brunoerg: test: add coverage for `label` in `listsinceblock`
2382022-12-07T23:42:58 <bitcoin-git> [bitcoin] achow101 merged pull request #25934: wallet, rpc: add `label` to `listsinceblock` (master...2022-08-add-label-listsinceblock) https://github.com/bitcoin/bitcoin/pull/25934