12023-01-05T00:02:45 *** AaronvanW <AaronvanW!~AaronvanW@user/AaronvanW> has quit IRC (Quit: Leaving...)
22023-01-05T00:05:24 *** koolazer <koolazer!~koo@user/koolazer> has joined #bitcoin-core-dev
32023-01-05T00:36:27 *** drue <drue!~drue@ec2-18-216-100-168.us-east-2.compute.amazonaws.com> has joined #bitcoin-core-dev
42023-01-05T00:53:09 *** javi404 <javi404!~quassel@c-73-1-238-68.hsd1.fl.comcast.net> has quit IRC (Ping timeout: 260 seconds)
52023-01-05T01:13:44 *** mudsip <mudsip!~mudsip@user/mudsip> has joined #bitcoin-core-dev
62023-01-05T01:19:13 *** mudsip <mudsip!~mudsip@user/mudsip> has quit IRC ()
72023-01-05T01:19:23 *** sipsorcery <sipsorcery!~sipsorcer@2a02:8084:6180:500:9f97:ce49:553a:6cb3> has quit IRC (Ping timeout: 264 seconds)
82023-01-05T01:53:47 *** b_101_ <b_101_!~robert@173.254.196.62.adsl.inet-telecom.org> has joined #bitcoin-core-dev
92023-01-05T01:56:24 *** b_101 <b_101!~robert@173.254.196.62.adsl.inet-telecom.org> has quit IRC (Ping timeout: 260 seconds)
102023-01-05T01:57:11 *** franbopzle <franbopzle!~franboppl@20.1.142.20> has quit IRC (Ping timeout: 246 seconds)
112023-01-05T02:03:09 *** bitdex <bitdex!~bitdex@gateway/tor-sasl/bitdex> has quit IRC (Remote host closed the connection)
122023-01-05T02:04:06 *** bitdex <bitdex!~bitdex@gateway/tor-sasl/bitdex> has joined #bitcoin-core-dev
132023-01-05T02:05:09 *** dermoth <dermoth!~dermoth@user/dermoth> has quit IRC (Ping timeout: 260 seconds)
142023-01-05T02:24:23 *** dermoth <dermoth!~dermoth@user/dermoth> has joined #bitcoin-core-dev
152023-01-05T04:01:31 *** lisper29 <lisper29!~vibs29``@83-87-73-107.cable.dynamic.v4.ziggo.nl> has quit IRC (Quit: Leaving)
162023-01-05T05:01:01 *** cmirror <cmirror!~cmirror@4.53.92.114> has quit IRC (Remote host closed the connection)
172023-01-05T05:01:36 *** cmirror <cmirror!~cmirror@4.53.92.114> has joined #bitcoin-core-dev
182023-01-05T05:35:53 *** Guest67 <Guest67!~Guest67@89.187.164.137> has joined #bitcoin-core-dev
192023-01-05T05:36:17 *** Guest67 <Guest67!~Guest67@89.187.164.137> has quit IRC (Client Quit)
202023-01-05T05:48:14 *** Guest91 <Guest91!~Guest91@173-255-172-85.msp.as54203.net> has joined #bitcoin-core-dev
212023-01-05T05:55:18 *** Guest91 <Guest91!~Guest91@173-255-172-85.msp.as54203.net> has quit IRC (Quit: Client closed)
222023-01-05T06:00:03 *** as2333 <as2333!~as2333@host170.181-12-230.telecom.net.ar> has quit IRC (Quit: as2333)
232023-01-05T06:18:22 *** javi404 <javi404!~quassel@c-73-1-238-68.hsd1.fl.comcast.net> has joined #bitcoin-core-dev
242023-01-05T08:21:09 <bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/360e047a7102...296e88225096
252023-01-05T08:21:09 <bitcoin-git> bitcoin/master e6864fa fanquake: contrib: remove builder keys
262023-01-05T08:21:09 <bitcoin-git> bitcoin/master 296e882 MarcoFalke: Merge bitcoin/bitcoin#26598: contrib: remove builder keys
272023-01-05T08:43:21 <bitcoin-git> [bitcoin] zpv closed pull request #26815: builder-keys: remove luke-jr (master...patch-1) https://github.com/bitcoin/bitcoin/pull/26815
282023-01-05T08:43:41 <bitcoin-git> [bitcoin] MarcoFalke closed pull request #26598: contrib: remove builder keys (master...drop_non_guix_keys) https://github.com/bitcoin/bitcoin/pull/26598
292023-01-05T08:50:45 *** Guyver2 <Guyver2!~Guyver@77.174.98.73> has joined #bitcoin-core-dev
302023-01-05T09:00:06 *** jakwolf[m] <jakwolf[m]!~jakwolfma@2001:470:69fc:105::2:acc8> has quit IRC (Quit: You have been kicked for being idle)
312023-01-05T09:04:27 *** jon_atack <jon_atack!~jonatack@user/jonatack> has quit IRC (Ping timeout: 268 seconds)
322023-01-05T09:06:02 *** jon_atack <jon_atack!~jonatack@user/jonatack> has joined #bitcoin-core-dev
332023-01-05T09:26:55 *** gossie <gossie!~gossie@2001:1c02:11e:3500:9941:94eb:7c34:cc0f> has joined #bitcoin-core-dev
342023-01-05T09:27:56 *** Guyver2 <Guyver2!~Guyver@77.174.98.73> has left #bitcoin-core-dev (Closing Window)
352023-01-05T10:44:23 <p2plife> init message: messages are odd, in code they are _("foo_").translated - not sure why the final "_" nor why the .translated
362023-01-05T10:45:27 <p2plife> the result is that these messaged (seen with grep "init message" ~/.bitcoin/debug.log) are all ending with bytes e2 80 a6, and then the newline 0a
372023-01-05T10:45:54 <p2plife> I noticed since on screen these bytes looked like random characters. is that a known problem? I couldn't find it mentioned in Issues on github
382023-01-05T10:55:34 <p2plife> ok nevermind. that's the ellipsis unicode. it looks weird on plain terminals,
392023-01-05T11:01:39 <hebasto> p2plife: maybe open an issue to let others to reproduce the behaviour you mentioned?
402023-01-05T11:02:47 <hebasto> oh, nm, you mentioned the "ellipsis" unicode
412023-01-05T11:19:27 *** ___nick___ <___nick___!~quassel@cpc68289-cdif17-2-0-cust317.5-1.cable.virginm.net> has joined #bitcoin-core-dev
422023-01-05T11:49:34 *** AaronvanW <AaronvanW!~AaronvanW@user/AaronvanW> has joined #bitcoin-core-dev
432023-01-05T11:50:03 <bitcoin-git> [bitcoin] MarcoFalke opened pull request #26817: doc: Remove copyright years (master...2301-doc-copy-ð¼) https://github.com/bitcoin/bitcoin/pull/26817
442023-01-05T12:02:46 *** brunoerg <brunoerg!~brunoerg@2804:14d:5281:8ae2:9cec:e75:2ae:365b> has joined #bitcoin-core-dev
452023-01-05T13:07:34 *** AaronvanW <AaronvanW!~AaronvanW@user/AaronvanW> has quit IRC (Remote host closed the connection)
462023-01-05T13:12:13 <bitcoin-git> [bitcoin] MarcoFalke opened pull request #26818: test: Fix feature_startupnotify intermittent issue (master...2301-test-fix-s-ð«) https://github.com/bitcoin/bitcoin/pull/26818
472023-01-05T13:40:55 *** AaronvanW <AaronvanW!~AaronvanW@user/AaronvanW> has joined #bitcoin-core-dev
482023-01-05T13:41:31 *** vasild_ <vasild_!~vd@user/vasild> has joined #bitcoin-core-dev
492023-01-05T13:44:26 *** vasild <vasild!~vd@user/vasild> has quit IRC (Ping timeout: 255 seconds)
502023-01-05T14:30:12 *** jungly <jungly!~jungly@host-95-238-185-44.retail.telecomitalia.it> has joined #bitcoin-core-dev
512023-01-05T14:37:59 *** BUSY <BUSY!~BUSY@user/busy> has quit IRC (Ping timeout: 260 seconds)
522023-01-05T14:50:06 *** BUSY <BUSY!~BUSY@user/busy> has joined #bitcoin-core-dev
532023-01-05T14:58:42 *** Guest39 <Guest39!~Guest39@pool-96-241-171-211.washdc.fios.verizon.net> has joined #bitcoin-core-dev
542023-01-05T15:09:52 *** vasild_ <vasild_!~vd@user/vasild> has quit IRC (Quit: leaving)
552023-01-05T15:12:53 *** AaronvanW <AaronvanW!~AaronvanW@user/AaronvanW> has quit IRC (Remote host closed the connection)
562023-01-05T15:34:51 *** vasild <vasild!~vd@user/vasild> has joined #bitcoin-core-dev
572023-01-05T15:43:31 *** Guyver2 <Guyver2!~Guyver@77-174-98-73.fixed.kpn.net> has joined #bitcoin-core-dev
582023-01-05T15:43:49 *** AaronvanW <AaronvanW!~AaronvanW@user/AaronvanW> has joined #bitcoin-core-dev
592023-01-05T15:48:25 *** halosghost <halosghost!~halosghos@user/halosghost> has joined #bitcoin-core-dev
602023-01-05T16:02:41 *** sipsorcery <sipsorcery!~sipsorcer@2a02:8084:6180:500:9f97:ce49:553a:6cb3> has joined #bitcoin-core-dev
612023-01-05T16:17:21 *** AaronvanW <AaronvanW!~AaronvanW@user/AaronvanW> has quit IRC (Ping timeout: 268 seconds)
622023-01-05T16:20:25 *** jungly <jungly!~jungly@host-95-238-185-44.retail.telecomitalia.it> has quit IRC (Ping timeout: 260 seconds)
632023-01-05T16:24:52 <bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/296e88225096...61f35159ffad
642023-01-05T16:24:52 <bitcoin-git> bitcoin/master fac810b MarcoFalke: test: Fix feature_startupnotify intermittent issue
652023-01-05T16:24:52 <bitcoin-git> bitcoin/master 61f3515 MarcoFalke: Merge bitcoin/bitcoin#26818: test: Fix feature_startupnotify intermittent ...
662023-01-05T16:26:14 <bitcoin-git> [bitcoin] MarcoFalke closed pull request #26818: test: Fix feature_startupnotify intermittent issue (master...2301-test-fix-s-ð«) https://github.com/bitcoin/bitcoin/pull/26818
672023-01-05T16:33:23 <bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/61f35159ffad...3212d104f4ac
682023-01-05T16:33:23 <bitcoin-git> bitcoin/master f2fc03e Pasta: refactor: use braced init for integer constants instead of c style casts
692023-01-05T16:33:23 <bitcoin-git> bitcoin/master 3212d10 MarcoFalke: Merge bitcoin/bitcoin#23829: refactor: use braced init for integer literal...
702023-01-05T16:33:34 <bitcoin-git> [bitcoin] MarcoFalke merged pull request #23829: refactor: use braced init for integer literals instead of c style casts (master...use-braced-init) https://github.com/bitcoin/bitcoin/pull/23829
712023-01-05T16:36:28 *** kexkey <kexkey!~kexkey@static-198-54-132-134.cust.tzulo.com> has quit IRC (Ping timeout: 272 seconds)
722023-01-05T16:39:25 *** kexkey <kexkey!~kexkey@static-198-54-132-141.cust.tzulo.com> has joined #bitcoin-core-dev
732023-01-05T16:48:50 *** ___nick___ <___nick___!~quassel@cpc68289-cdif17-2-0-cust317.5-1.cable.virginm.net> has quit IRC (Quit: https://quassel-irc.org - Chat comfortably. Anywhere.)
742023-01-05T16:50:42 *** ___nick___ <___nick___!~quassel@cpc68289-cdif17-2-0-cust317.5-1.cable.virginm.net> has joined #bitcoin-core-dev
752023-01-05T16:51:20 *** ___nick___ <___nick___!~quassel@cpc68289-cdif17-2-0-cust317.5-1.cable.virginm.net> has quit IRC (Client Quit)
762023-01-05T16:53:20 *** ___nick___ <___nick___!~quassel@cpc68289-cdif17-2-0-cust317.5-1.cable.virginm.net> has joined #bitcoin-core-dev
772023-01-05T16:57:59 *** SpellChecker_ <SpellChecker_!~SpellChec@user/SpellChecker> has joined #bitcoin-core-dev
782023-01-05T17:02:26 *** SpellChecker <SpellChecker!~SpellChec@user/SpellChecker> has quit IRC (Ping timeout: 255 seconds)
792023-01-05T17:19:17 *** b_101 <b_101!~robert@173.254.196.62.adsl.inet-telecom.org> has joined #bitcoin-core-dev
802023-01-05T17:19:25 *** as2333 <as2333!~as2333@host170.181-12-230.telecom.net.ar> has joined #bitcoin-core-dev
812023-01-05T17:21:41 *** b_101_ <b_101_!~robert@173.254.196.62.adsl.inet-telecom.org> has quit IRC (Quit: Lost terminal)
822023-01-05T17:23:13 <bitcoin-git> [bitcoin] achow101 pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/3212d104f4ac...b4fb0a3255d3
832023-01-05T17:23:14 <bitcoin-git> bitcoin/master d5f4ae7 Sebastian Falbesoner: wallet: fully migrate address book entries for watchonly/solvable wallets
842023-01-05T17:23:14 <bitcoin-git> bitcoin/master 730e14a Sebastian Falbesoner: test: wallet: check that labels are migrated to watchonly wallet
852023-01-05T17:23:14 <bitcoin-git> bitcoin/master b4fb0a3 Andrew Chow: Merge bitcoin/bitcoin#26761: wallet: fully migrate address book entries fo...
862023-01-05T17:23:19 <bitcoin-git> [bitcoin] achow101 merged pull request #26761: wallet: fully migrate address book entries for watchonly/solvable wallets (master...202212-migratewallet_persist_addressbook) https://github.com/bitcoin/bitcoin/pull/26761
872023-01-05T17:33:02 *** bitdex <bitdex!~bitdex@gateway/tor-sasl/bitdex> has quit IRC (Ping timeout: 255 seconds)
882023-01-05T17:33:58 *** bitdex <bitdex!~bitdex@gateway/tor-sasl/bitdex> has joined #bitcoin-core-dev
892023-01-05T17:36:55 <p2plife> will people be releasing statement regarding if commits and recent changes from luke-jr are "audited"? there are rumours or doubt arising that sources are "compromised" (yes I know there is a review process, but not everyone knows)
902023-01-05T17:40:21 <achow101> p2plife: luke isn't a maintainer, he can't merge anything
912023-01-05T17:55:18 <bitcoin-git> [bitcoin] hebasto opened pull request #26821: refactor: Make `ThreadHTTP` return void (master...220105-http) https://github.com/bitcoin/bitcoin/pull/26821
922023-01-05T17:56:38 *** cotsuka <cotsuka!~cotsuka@user/cotsuka> has quit IRC (Quit: Bye!)
932023-01-05T17:59:21 <halosghost> though, might be a different question about knots
942023-01-05T17:59:42 *** cotsuka <cotsuka!~cotsuka@user/cotsuka> has joined #bitcoin-core-dev
952023-01-05T18:15:48 *** Guest39 <Guest39!~Guest39@pool-96-241-171-211.washdc.fios.verizon.net> has quit IRC (Ping timeout: 260 seconds)
962023-01-05T18:16:34 *** AaronvanW <AaronvanW!~AaronvanW@user/AaronvanW> has joined #bitcoin-core-dev
972023-01-05T18:34:25 <jamesob> Surprising that this is dead code in the functional test suite: https://github.com/bitcoin/bitcoin/blob/master/test/functional/test_framework/script.py#L817-L820
982023-01-05T18:34:35 <jamesob> Where are all the taproot spends?
992023-01-05T18:34:53 <jamesob> Looks like they only happen in feature_taproot.py, which is horrifying
1002023-01-05T18:35:05 <sipa> Why?
1012023-01-05T18:35:23 <jamesob> I just mean it's a beastly functional test when attempting to read through and find a simple taproot spend
1022023-01-05T18:36:40 <sipa> If you mean that feature_taproot.py is horrifying in terms of readability, I agree (though I'm still quite proud of it...).
1032023-01-05T18:36:58 <jamesob> Yeah just in terms of readability. I'm sure it delivers a lot of functionality and coverage
1042023-01-05T18:37:01 <sipa> I thought you meant it's horrifying that that's the only thing testing it.
1052023-01-05T18:37:14 <jamesob> I'm just surprised - I thought P2TR spends were more common in the functional tests
1062023-01-05T18:38:09 <sipa> Well most tests involve directing bitcoind to do the spending; there are few uses for doing the spending on the functional test side (except when testing verification of the relevant rules).
1072023-01-05T18:43:28 *** Talkless <Talkless!~Talkless@mail.dargis.net> has joined #bitcoin-core-dev
1082023-01-05T18:45:55 <bitcoin-git> [bitcoin] brunoerg opened pull request #26822: p2p, rpc: don't allow past absolute timestamp in `setban` (master...2023-01-fix-ban-time) https://github.com/bitcoin/bitcoin/pull/26822
1092023-01-05T18:47:35 *** AaronvanW <AaronvanW!~AaronvanW@user/AaronvanW> has quit IRC (Ping timeout: 264 seconds)
1102023-01-05T18:49:49 <bitcoin-git> [bitcoin] MarcoFalke opened pull request #26823: refactor: Work around Werror=free-nonheap-object in AssumeCalculateMemPoolAncestors (master...2301-s390x-refactor-gcc-bug-ð§) https://github.com/bitcoin/bitcoin/pull/26823
1112023-01-05T18:51:04 *** AaronvanW <AaronvanW!~AaronvanW@user/AaronvanW> has joined #bitcoin-core-dev
1122023-01-05T19:01:37 <achow101> meeting?
1132023-01-05T19:02:19 <Murch1> Hi
1142023-01-05T19:02:36 <brunoerg> Hi
1152023-01-05T19:02:41 <achow101> #startmeeting
1162023-01-05T19:02:41 <core-meetingbot> Meeting started Thu Jan 5 19:02:41 2023 UTC. The chair is achow101. Information about MeetBot at https://bitcoin.jonasschnelli.ch/ircmeetings.
1172023-01-05T19:02:41 <core-meetingbot> Available commands: action commands idea info link nick
1182023-01-05T19:02:54 <achow101> #bitcoin-core-dev Meeting: achow101 aj amiti ariard b10c BlueMatt cfields Chris_Stewart_5 darosior digi_james dongcarl elichai2 emilengler fanquake fjahr gleb glozow gmaxwell gwillen hebasto instagibbs jamesob jarolrod jb55 jeremyrubin jl2012 jnewbery jonasschnelli jonatack jtimon kallewoof kanzure kvaciral laanwj larryruane lightlike luke-jr maaku marcofalke meshcollider michagogo moneyball morcos nehan NicolasDorier paveljanik petertodd
1192023-01-05T19:02:54 <achow101> phantomcircuit promag provoostenator ryanofsky sdaftuar sipa vasild
1202023-01-05T19:03:01 <sipa> Hi
1212023-01-05T19:03:02 <jamesob> hi
1222023-01-05T19:03:05 <instagibbs> hi
1232023-01-05T19:03:15 <furszy> hi
1242023-01-05T19:03:22 <kvaciral> hi
1252023-01-05T19:03:36 <achow101> Welcome to the weekly general IRC meeting.
1262023-01-05T19:04:09 <achow101> There are no preproposed meeting topics this week, does anyone have any last minute topics to discuss?
1272023-01-05T19:04:50 <LarryRuane> hi
1282023-01-05T19:05:16 <achow101> #topic high priority for review
1292023-01-05T19:05:16 <core-meetingbot> topic: high priority for review
1302023-01-05T19:05:25 <achow101> https://github.com/orgs/bitcoin/projects/1
1312023-01-05T19:05:30 <achow101> anything to add/remove/merge?
1322023-01-05T19:05:59 <jamesob> did the board get reset? I though I had an assumeutxo PR on there
1332023-01-05T19:06:32 <jamesob> can I add #25740?
1342023-01-05T19:06:35 <gribble> https://github.com/bitcoin/bitcoin/issues/25740 | assumeutxo: background validation completion by jamesob · Pull Request #25740 · bitcoin/bitcoin · GitHub
1352023-01-05T19:06:40 <achow101> jamesob: I don't think it's been changed
1362023-01-05T19:07:08 <jamesob> that's weird... I definitely remember my AU PR being on there
1372023-01-05T19:07:33 <lightlike> maybe it was the one that got merged recently?
1382023-01-05T19:08:08 <jamesob> hmm, dunno.
1392023-01-05T19:08:40 <achow101> jamesob: added
1402023-01-05T19:08:45 <jamesob> thanks
1412023-01-05T19:10:09 <LarryRuane> I may as well ask here, anyone have a PR they'd like to be covered in review club? (I'm hosting on Feb 15)
1422023-01-05T19:10:44 <achow101> all of them :)
1432023-01-05T19:10:45 <LarryRuane> Also we're always welcome to have people host, if you'd like to try that
1442023-01-05T19:10:49 <LarryRuane> :)
1452023-01-05T19:12:15 *** Guest96 <Guest96!~Guest96@2605:8d80:682:dd56:dc84:f30d:5972:3964> has joined #bitcoin-core-dev
1462023-01-05T19:13:57 <achow101> LarryRuane: I think anything in the high prio board and the pr status board (https://github.com/orgs/bitcoin/projects/5/views/1)
1472023-01-05T19:15:08 <LarryRuane> achow101: +1 thanks
1482023-01-05T19:15:53 <achow101> anything else to discuss?
1492023-01-05T19:17:29 <achow101> #endmeeting
1502023-01-05T19:17:30 <core-meetingbot> topic: Bitcoin Core development discussion and commit log | Feel free to watch, but please take commentary and usage questions to #bitcoin | Channel logs: http://www.erisian.com.au/bitcoin-core-dev/, http://gnusha.org/bitcoin-core-dev/ | Meeting topics http://gnusha.org/bitcoin-core-dev/proposedmeetingtopics.txt / http://gnusha.org/bitcoin-core-dev/proposedwalletmeetingtopics.txt
1512023-01-05T19:17:30 <core-meetingbot> Meeting ended Thu Jan 5 19:17:29 2023 UTC.
1522023-01-05T19:17:30 <core-meetingbot> Minutes: https://bitcoin.jonasschnelli.ch/ircmeetings/logs/bitcoin-core-dev/2023/bitcoin-core-dev.2023-01-05-19.02.moin.txt
1532023-01-05T19:18:02 <bitcoin-git> [bitcoin] fanquake opened pull request #26824: build: fix configuring with only bitcoin-util (master...fix_bitcoin_util_configure) https://github.com/bitcoin/bitcoin/pull/26824
1542023-01-05T19:18:08 <achow101> laanwj: I guess I should take over chairing the meetings permanently?
1552023-01-05T19:23:04 <jamesob> what's the policy on type hints in test_framework? are people amenable to those being added? I think generally it'd be a pretty big contributor to readability
1562023-01-05T19:24:59 <achow101> jamesob: we have type hints in some places, and the linter does run a type checker
1572023-01-05T19:25:39 <jamesob> e.g. in test_framework.key, test_framework.wallet, there are many places where the function has to be inspected to determine return type but just having that information accessible in the function signature would be convenient
1582023-01-05T19:26:13 <achow101> I would say add type hints as new stuff is added, kind of like how we do style stuff
1592023-01-05T19:28:22 <jamesob> I do think it would be beneficial if someone just started adding type information to signatures... because isn't it all trivially verifiable by the type checker? Like if someone adds incorrect annotations, that will be caught by CI, right?
1602023-01-05T19:29:11 <achow101> although test_framework is pretty low volume so blanket adding type annotations to all function signatures probably wouldn't cause too much rebasing?
1612023-01-05T19:29:22 <jamesob> yeah I wouldn't think so
1622023-01-05T19:29:59 <sipa> I think it may be helpful to do it for the few modules where it would actually have helped you in your work.
1632023-01-05T19:30:09 <jamesob> I think in individual tests would be too much churn, but for the framework I think adding annotations is reasonable; it's almost like scripted-diff in that it's CI enforced
1642023-01-05T19:30:18 <jamesob> sipa: yeah that's what I was thinking
1652023-01-05T19:30:31 <sipa> Given that we apparently already have annotations in some modules but not others, it doesn't seem like there is much of a need to do it over the entirety of the function test codebase at once.
1662023-01-05T19:30:39 <jamesob> (not to discourage adding type info in new tests...)
1672023-01-05T19:30:53 <bitcoin-git> [bitcoin] fanquake opened pull request #26825: build: remove already tested headers from AC_CHECK_HEADERS (master...remove_already_tested_headers) https://github.com/bitcoin/bitcoin/pull/26825
1682023-01-05T19:30:56 <jamesob> sipa: yeah and that'd be really tedious work anyway...
1692023-01-05T19:32:08 <sipa> And there isn't a strict separation between "having" and "not having" annotations; like you could go put "Any" on everything, and it wouldn't mean anything.
1702023-01-05T19:32:18 <sipa> (no pun intended)
1712023-01-05T19:32:47 *** SpellChecker_ <SpellChecker_!~SpellChec@user/SpellChecker> has quit IRC (Remote host closed the connection)
1722023-01-05T19:32:48 <jamesob> hah, right
1732023-01-05T19:32:58 *** SpellChecker <SpellChecker!~SpellChec@user/SpellChecker> has joined #bitcoin-core-dev
1742023-01-05T19:40:05 *** Guest96 <Guest96!~Guest96@2605:8d80:682:dd56:dc84:f30d:5972:3964> has quit IRC (Quit: Client closed)
1752023-01-05T19:46:17 <bitcoin-git> [bitcoin] fanquake opened pull request #26826: refactor: remove windows-only compat.h usage in randomenv (master...windows_randomenv_compat_usage) https://github.com/bitcoin/bitcoin/pull/26826
1762023-01-05T19:57:12 <bitcoin-git> [bitcoin] fanquake opened pull request #26827: doc: use "std lib clock" over "C++11 clock" (master...doc_std_lib_clocks) https://github.com/bitcoin/bitcoin/pull/26827
1772023-01-05T19:57:23 *** andrewtoth <andrewtoth!~andrewtot@gateway/tor-sasl/andrewtoth> has quit IRC (Remote host closed the connection)
1782023-01-05T19:57:50 *** andrewtoth <andrewtoth!~andrewtot@gateway/tor-sasl/andrewtoth> has joined #bitcoin-core-dev
1792023-01-05T20:17:18 *** vasild <vasild!~vd@user/vasild> has quit IRC (Remote host closed the connection)
1802023-01-05T20:22:46 *** Talkless <Talkless!~Talkless@mail.dargis.net> has quit IRC (Quit: Konversation terminated!)
1812023-01-05T20:26:35 *** vasild <vasild!~vd@user/vasild> has joined #bitcoin-core-dev
1822023-01-05T20:26:41 *** andrewtoth <andrewtoth!~andrewtot@gateway/tor-sasl/andrewtoth> has quit IRC (Remote host closed the connection)
1832023-01-05T20:27:15 *** andrewtoth <andrewtoth!~andrewtot@gateway/tor-sasl/andrewtoth> has joined #bitcoin-core-dev
1842023-01-05T21:04:07 *** ___nick___ <___nick___!~quassel@cpc68289-cdif17-2-0-cust317.5-1.cable.virginm.net> has quit IRC (Ping timeout: 268 seconds)
1852023-01-05T21:44:31 *** brunoerg <brunoerg!~brunoerg@2804:14d:5281:8ae2:9cec:e75:2ae:365b> has quit IRC ()
1862023-01-05T21:56:34 *** lisper29 <lisper29!~vibs29``@83-87-73-107.cable.dynamic.v4.ziggo.nl> has joined #bitcoin-core-dev
1872023-01-05T22:15:25 <lisper29> I'm learning to use BIP32 derived addresses in bitcoind. BIP32 4.3.2 (pub->pub) ends by specifying that when a derivation at index i is invalid "one should proceed with the next value for i". So if the deriveaddresses RPC returns an error, I'll try the next index. But I don't see the getnewaddress RPC or the Qt "create new receiving address" button's code trying the next index for this type of failed derivation. Do
1882023-01-05T22:15:26 <lisper29> they have a bug in that they'll never get past that invalid index? (pubkey.cpp CPubKey::Derive is what I assume performs the BIP32 4.3.2 validation.)
1892023-01-05T22:20:23 <sipa> It's not a bug in that it cannot occur. I should perhaps explain that in the BIP.
1902023-01-05T22:21:48 *** Guest57 <Guest57!~Guest57@189.6.9.148> has joined #bitcoin-core-dev
1912023-01-05T22:21:58 <lisper29> sipa: I think you've just ended many weeks of my misery. thank you!
1922023-01-05T22:22:47 *** Guest57 <Guest57!~Guest57@189.6.9.148> has quit IRC (Client Quit)
1932023-01-05T22:25:40 <sipa> "cannot" as in the probability of it ever occurring in our lifetimes is negligible
1942023-01-05T22:25:46 <bitcoin-git> [bitcoin] andrewtoth opened pull request #26828: assumeutxo: catch and log fs::remove error instead of two exist checks (master...assumeutxo-remove-fix) https://github.com/bitcoin/bitcoin/pull/26828
1952023-01-05T22:25:56 <lisper29> Do I understand correctly then that deriveaddresses also will always produce a valid address at every index in [0,2^31-1]?
1962023-01-05T22:27:15 <sipa> yes
1972023-01-05T22:28:14 <lisper29> Ah I see, it's low probability, got it. I did see the 2^-126 probability for another section of BIP32. This section didn't mention it. And anyway its specified algorithm says that if invalid then try the next. So not being cryptographer or mathematician, I figured I must follow prescribed algorithm.
1982023-01-05T22:30:10 <lisper29> Hurray, thank you. That's a huge weight off a programmer's shoulders.
1992023-01-05T22:39:53 <lisper29> Last question: If that low probability index occurs, does deriveaddresses return an error? Then I can write code to try next index. Or does deriveaddresses return an address that I won't know is dangerous to advertise?
2002023-01-05T22:40:12 *** halosghost <halosghost!~halosghos@user/halosghost> has quit IRC (Quit: WeeChat 3.7.1)
2012023-01-05T22:42:16 <lisper29> If it's meaningless to reason at such low probabilities (e.g. because many other things can fail before then, such as hashes colliding), please ignore of course.
2022023-01-05T22:51:14 *** Guyver2 <Guyver2!~Guyver@77-174-98-73.fixed.kpn.net> has left #bitcoin-core-dev (Closing Window)
2032023-01-05T23:09:26 <sipa> Yeah, it's just practically impossible to hit, even if someone were to intentionally try to make it happen with all computational power in the world.
2042023-01-05T23:09:35 <sipa> We can't even write a test for it, because of that.
2052023-01-05T23:22:15 *** AaronvanW <AaronvanW!~AaronvanW@user/AaronvanW> has quit IRC (Remote host closed the connection)
2062023-01-05T23:22:50 *** AaronvanW <AaronvanW!~AaronvanW@user/AaronvanW> has joined #bitcoin-core-dev
2072023-01-05T23:23:19 <lisper29> Right, I guessed that it was low from no test vectors and the 2^-126 mentioned elsewhere. I know what to do. Assuming CPubKey::Derive does properly return a failure, there's 0 (not just negligible) probability of deriveaddresses returning an address when it shouldn't. So I'll write client code to loop to next index. Regardless, client code will never see a bad address from deriveaddresses, even if it runs until the
2082023-01-05T23:23:19 <lisper29> last table entry at: https://en.wikipedia.org/wiki/Timeline_of_the_far_future . And I'll tell all users of my program that in dealing with cryptography (which underlies bitcoin), there are these negligibly likely events. That's enough agonising for now :-)
2092023-01-05T23:23:30 *** AaronvanW <AaronvanW!~AaronvanW@user/AaronvanW> has quit IRC (Client Quit)
2102023-01-05T23:42:42 *** sipsorcery <sipsorcery!~sipsorcer@2a02:8084:6180:500:9f97:ce49:553a:6cb3> has quit IRC (Ping timeout: 265 seconds)