12023-03-26T00:12:16 <bitcoin-git> [bitcoin] aureleoules closed pull request #26858: wallet: Use defined purposes instead of inlining (master...2023-01-purpose-refactor) https://github.com/bitcoin/bitcoin/pull/26858
22023-03-26T00:55:39 *** jarthur <jarthur!~jarthur@user/jarthur> has quit IRC (Quit: jarthur)
32023-03-26T01:31:35 *** zeropoint <zeropoint!~alex@45-28-139-114.lightspeed.sntcca.sbcglobal.net> has joined #bitcoin-core-dev
42023-03-26T01:51:19 *** jarthur <jarthur!~jarthur@user/jarthur> has joined #bitcoin-core-dev
52023-03-26T02:34:26 *** zeropoint <zeropoint!~alex@45-28-139-114.lightspeed.sntcca.sbcglobal.net> has quit IRC (Quit: leaving)
62023-03-26T02:42:59 *** mudsip <mudsip!~mudsip@user/mudsip> has joined #bitcoin-core-dev
72023-03-26T02:47:53 *** yanmaani1 <yanmaani1!~yanmaani@gateway/tor-sasl/yanmaani> has quit IRC (Ping timeout: 255 seconds)
82023-03-26T02:55:56 *** mudsip <mudsip!~mudsip@user/mudsip> has quit IRC ()
92023-03-26T03:34:57 *** zeropoint <zeropoint!~alex@45-28-139-114.lightspeed.sntcca.sbcglobal.net> has joined #bitcoin-core-dev
102023-03-26T03:48:06 *** zeropoint <zeropoint!~alex@45-28-139-114.lightspeed.sntcca.sbcglobal.net> has quit IRC (Quit: leaving)
112023-03-26T04:01:01 *** cmirror <cmirror!~cmirror@4.53.92.114> has quit IRC (Remote host closed the connection)
122023-03-26T04:01:32 *** cmirror <cmirror!~cmirror@4.53.92.114> has joined #bitcoin-core-dev
132023-03-26T04:34:20 *** zeropoint <zeropoint!~alex@45-28-139-114.lightspeed.sntcca.sbcglobal.net> has joined #bitcoin-core-dev
142023-03-26T06:21:58 *** zeropoint <zeropoint!~alex@45-28-139-114.lightspeed.sntcca.sbcglobal.net> has quit IRC (Quit: leaving)
152023-03-26T07:38:43 *** PaperSword <PaperSword!~Thunderbi@securemail.qrsnap.io> has quit IRC (Remote host closed the connection)
162023-03-26T08:30:26 *** salvatoshi <salvatoshi!~salvatosh@lfbn-idf3-1-1331-187.w92-170.abo.wanadoo.fr> has joined #bitcoin-core-dev
172023-03-26T08:32:33 *** gnusha <gnusha!~gnusha@user/gnusha> has quit IRC (Remote host closed the connection)
182023-03-26T08:32:34 *** kanzure <kanzure!~kanzure@user/kanzure> has quit IRC (Remote host closed the connection)
192023-03-26T08:38:48 *** anhi <anhi!~anhi@94.26.22.151> has quit IRC (Quit: Client closed)
202023-03-26T08:39:29 *** gnusha <gnusha!~gnusha@user/gnusha> has joined #bitcoin-core-dev
212023-03-26T09:02:20 *** jonatack3 <jonatack3!~jonatack@user/jonatack> has joined #bitcoin-core-dev
222023-03-26T09:03:39 *** jonatack2 <jonatack2!~jonatack@user/jonatack> has quit IRC (Ping timeout: 248 seconds)
232023-03-26T09:03:45 *** Talkless <Talkless!~Talkless@mail.dargis.net> has joined #bitcoin-core-dev
242023-03-26T09:07:37 *** chip_x <chip_x!~chip@2001:8a0:f620:6500:8f6d:c640:c292:171c> has quit IRC (Ping timeout: 256 seconds)
252023-03-26T09:10:56 *** PaperSword <PaperSword!~Thunderbi@securemail.qrsnap.io> has joined #bitcoin-core-dev
262023-03-26T09:42:34 *** AaronvanW <AaronvanW!~AaronvanW@user/AaronvanW> has joined #bitcoin-core-dev
272023-03-26T09:52:38 <darosior> andytoshi: don't know if you seen it, but slightly related: https://github.com/bitcoin/bitcoin/issues/19151
282023-03-26T10:57:23 *** kanzure <kanzure!~kanzure@user/kanzure> has joined #bitcoin-core-dev
292023-03-26T11:10:06 *** AaronvanW <AaronvanW!~AaronvanW@user/AaronvanW> has quit IRC (Quit: Leaving...)
302023-03-26T11:19:24 *** dunxen <dunxen!~dunxen@2001:470:69fc:105::1:fec1> has joined #bitcoin-core-dev
312023-03-26T11:43:37 *** gnaf <gnaf!~gnaf@212-83-165-160.rev.poneytelecom.eu> has joined #bitcoin-core-dev
322023-03-26T11:48:14 *** gnaf <gnaf!~gnaf@212-83-165-160.rev.poneytelecom.eu> has quit IRC (Client Quit)
332023-03-26T12:03:15 *** jonatack <jonatack!~jonatack@user/jonatack> has joined #bitcoin-core-dev
342023-03-26T12:04:59 *** jonatack3 <jonatack3!~jonatack@user/jonatack> has quit IRC (Ping timeout: 264 seconds)
352023-03-26T12:32:56 *** vstoyanov <vstoyanov!~vstoyanov@94.26.22.151> has joined #bitcoin-core-dev
362023-03-26T12:33:35 *** vstoyanov <vstoyanov!~vstoyanov@94.26.22.151> has quit IRC (Client Quit)
372023-03-26T12:33:48 *** vstoyanov <vstoyanov!~vstoyanov@94.26.22.151> has joined #bitcoin-core-dev
382023-03-26T12:38:55 <bitcoin-git> [bitcoin] vstoyanov opened pull request #27333: ci: cleanup of CI_EXEC & CI_EXEC_ROOT (refs #27321) (master...bitcoin#27321) https://github.com/bitcoin/bitcoin/pull/27333
392023-03-26T12:49:52 *** Guyver2 <Guyver2!~Guyver@77-174-98-73.fixed.kpn.net> has joined #bitcoin-core-dev
402023-03-26T13:08:00 <vstoyanov> Hey. What would be a good first issue which is not taken. I went through all of them labeled that way and they are all at some stage of discussion/implementation. I sort of lack the intuition/context-awareness to read between the lines and pick something up. Bot C++ and shell/infra are Ok for me
412023-03-26T13:08:20 <vstoyanov> Both*
422023-03-26T13:15:01 <andytoshi> darosior: thanks! it is slightly related, in that we're both trying to add more-or-less the same capability
432023-03-26T13:18:41 *** Hercules1 <Hercules1!~Hercules@2001:4641:613f:0:1c2a:fe4f:87b6:eb74> has joined #bitcoin-core-dev
442023-03-26T13:22:13 *** ddisqq <ddisqq!~ddisqq@pool-100-6-78-166.pitbpa.fios.verizon.net> has joined #bitcoin-core-dev
452023-03-26T13:26:53 *** bitdex <bitdex!~bitdex@gateway/tor-sasl/bitdex> has quit IRC (Ping timeout: 255 seconds)
462023-03-26T13:32:05 *** TallTim <TallTim!~talltim@184-83-250-114-static.midco.net> has quit IRC (Quit: Leaving)
472023-03-26T13:34:21 *** bitdex <bitdex!~bitdex@gateway/tor-sasl/bitdex> has joined #bitcoin-core-dev
482023-03-26T14:00:39 *** vstoyanov <vstoyanov!~vstoyanov@94.26.22.151> has quit IRC (Ping timeout: 255 seconds)
492023-03-26T14:05:38 *** vstoyanov <vstoyanov!~vstoyanov@94.26.22.151> has joined #bitcoin-core-dev
502023-03-26T14:06:22 *** Hercules1 <Hercules1!~Hercules@2001:4641:613f:0:1c2a:fe4f:87b6:eb74> has quit IRC (Quit: Leaving)
512023-03-26T14:39:05 <martinus> In prevector.h, the destructor calls "_union.indirect_contents.indirect = nullptr;". Any particular reason why this is done? It's done that ever since https://github.com/bitcoin/bitcoin/pull/6914/ was merged in 2015
522023-03-26T14:55:49 <bitcoin-git> [bitcoin] martinus opened pull request #27334: util: implement `noexcept` move assignment & move ctor for `prevector` (master...2023-03-prevector-move) https://github.com/bitcoin/bitcoin/pull/27334
532023-03-26T14:59:29 *** yanmaani1 <yanmaani1!~yanmaani@gateway/tor-sasl/yanmaani> has joined #bitcoin-core-dev
542023-03-26T15:02:43 *** aielima <aielima!~aielima@user/aielima> has joined #bitcoin-core-dev
552023-03-26T15:27:01 *** vstoyanov <vstoyanov!~vstoyanov@94.26.22.151> has quit IRC (Ping timeout: 240 seconds)
562023-03-26T15:28:18 *** vstoyanov <vstoyanov!~vstoyanov@151.251.248.62> has joined #bitcoin-core-dev
572023-03-26T16:31:36 *** beshology <beshology!~beshology@197.54.211.210> has joined #bitcoin-core-dev
582023-03-26T16:41:31 *** salvatoshi <salvatoshi!~salvatosh@lfbn-idf3-1-1331-187.w92-170.abo.wanadoo.fr> has quit IRC (Ping timeout: 240 seconds)
592023-03-26T16:43:15 <vasild> vstoyanov: I can't name a particular issue, but in general you can also look at ones not labeled "good first issue". Or you can start by reviewing some opened PR - or at least try to compile the code and run the tests, that helps to gather some knowledge and is useful to the project too.
602023-03-26T16:45:17 *** beshology <beshology!~beshology@197.54.211.210> has quit IRC (Quit: Leaving)
612023-03-26T16:47:20 <vstoyanov> Hi Vasil, I'm well past compiling the code and running tests :) I already opened a PR on the only free 'good first issue' I saw and asked if another one is stale indeed - unfortunately they all seem to be in some stage of completion.
622023-03-26T16:47:20 <vstoyanov> Jonatack told me that the real shortage is in reviewers, so I read his guides and will probably go this way for now.
632023-03-26T16:47:56 <vstoyanov> Apologies, it's been a long time since I last used IRC
642023-03-26T16:50:08 *** ddisqq <ddisqq!~ddisqq@pool-100-6-78-166.pitbpa.fios.verizon.net> has quit IRC (Remote host closed the connection)
652023-03-26T16:50:44 *** ddisqq <ddisqq!~ddisqq@pool-100-6-78-166.pitbpa.fios.verizon.net> has joined #bitcoin-core-dev
662023-03-26T16:52:22 *** ddisqq <ddisqq!~ddisqq@pool-100-6-78-166.pitbpa.fios.verizon.net> has quit IRC (Read error: Connection reset by peer)
672023-03-26T16:52:27 *** ddisqq_ <ddisqq_!~ddisqq@pool-100-6-78-166.pitbpa.fios.verizon.net> has joined #bitcoin-core-dev
682023-03-26T16:55:14 *** yanmaani1 <yanmaani1!~yanmaani@gateway/tor-sasl/yanmaani> has quit IRC (Ping timeout: 255 seconds)
692023-03-26T17:00:11 *** ddisqq_ <ddisqq_!~ddisqq@pool-100-6-78-166.pitbpa.fios.verizon.net> has quit IRC (Ping timeout: 264 seconds)
702023-03-26T17:02:07 *** zeropoint <zeropoint!~alex@45-28-139-114.lightspeed.sntcca.sbcglobal.net> has joined #bitcoin-core-dev
712023-03-26T17:07:34 *** _flood <_flood!flooded@gateway/vpn/protonvpn/flood/x-43489060> has quit IRC (Ping timeout: 276 seconds)
722023-03-26T17:25:37 *** Guyver2 <Guyver2!~Guyver@77-174-98-73.fixed.kpn.net> has left #bitcoin-core-dev (Closing Window)
732023-03-26T17:33:03 *** gnaf <gnaf!~gnaf@212-83-144-108.rev.poneytelecom.eu> has joined #bitcoin-core-dev
742023-03-26T17:35:59 *** ddisqq <ddisqq!~ddisqq@c-73-236-190-119.hsd1.pa.comcast.net> has joined #bitcoin-core-dev
752023-03-26T17:40:27 *** ddisqq <ddisqq!~ddisqq@c-73-236-190-119.hsd1.pa.comcast.net> has quit IRC (Ping timeout: 248 seconds)
762023-03-26T17:40:38 *** ddisqq_ <ddisqq_!~ddisqq@c-73-117-17-115.hsd1.pa.comcast.net> has joined #bitcoin-core-dev
772023-03-26T17:46:51 *** ddisqq_ <ddisqq_!~ddisqq@c-73-117-17-115.hsd1.pa.comcast.net> has quit IRC (Ping timeout: 248 seconds)
782023-03-26T17:46:58 *** gnaf <gnaf!~gnaf@212-83-144-108.rev.poneytelecom.eu> has quit IRC (Quit: Konversation terminated!)
792023-03-26T17:59:01 *** vstoyanov <vstoyanov!~vstoyanov@151.251.248.62> has quit IRC (Read error: Connection reset by peer)
802023-03-26T17:59:19 *** vstoyanov <vstoyanov!~vstoyanov@94.26.22.151> has joined #bitcoin-core-dev
812023-03-26T18:06:01 *** vstoyanov <vstoyanov!~vstoyanov@94.26.22.151> has quit IRC (Ping timeout: 240 seconds)
822023-03-26T18:06:45 *** vstoyanov <vstoyanov!~vstoyanov@151.251.248.62> has joined #bitcoin-core-dev
832023-03-26T18:10:41 *** vstoyanov <vstoyanov!~vstoyanov@151.251.248.62> has quit IRC (Read error: Connection reset by peer)
842023-03-26T18:11:41 *** vstoyanov <vstoyanov!~vstoyanov@94.26.22.151> has joined #bitcoin-core-dev
852023-03-26T18:12:17 *** vstoyanov <vstoyanov!~vstoyanov@94.26.22.151> has quit IRC (Client Quit)
862023-03-26T18:25:56 <bitcoin-git> [bitcoin] martinus closed pull request #23169: fix initialization in FastRandomContext: removes undefined behavior & uninitialized read (master...2021-10-fix-Wmaybe-uninitialized-warnings) https://github.com/bitcoin/bitcoin/pull/23169
872023-03-26T18:30:41 *** Talkless <Talkless!~Talkless@mail.dargis.net> has quit IRC (Quit: Konversation terminated!)
882023-03-26T18:59:54 *** aielima <aielima!~aielima@user/aielima> has quit IRC (Quit: Ciao)
892023-03-26T19:16:28 *** bugs_ <bugs_!~bugs@user/bugs/x-5128603> has joined #bitcoin-core-dev
902023-03-26T19:23:50 *** yanmaani1 <yanmaani1!~yanmaani@gateway/tor-sasl/yanmaani> has joined #bitcoin-core-dev
912023-03-26T19:34:17 *** ddisqq <ddisqq!~ddisqq@pool-100-6-78-166.pitbpa.fios.verizon.net> has joined #bitcoin-core-dev
922023-03-26T19:36:20 *** yanmaani1 <yanmaani1!~yanmaani@gateway/tor-sasl/yanmaani> has quit IRC (Ping timeout: 255 seconds)
932023-03-26T19:40:51 *** ddisqq <ddisqq!~ddisqq@pool-100-6-78-166.pitbpa.fios.verizon.net> has quit IRC (Ping timeout: 255 seconds)
942023-03-26T19:48:55 *** yanmaani1 <yanmaani1!~yanmaani@gateway/tor-sasl/yanmaani> has joined #bitcoin-core-dev
952023-03-26T19:51:29 *** TallTim <TallTim!~talltim@184-83-250-114-static.midco.net> has joined #bitcoin-core-dev
962023-03-26T20:05:14 *** luke-jr <luke-jr!~luke-jr@user/luke-jr> has quit IRC (Remote host closed the connection)
972023-03-26T20:05:46 *** luke-jr <luke-jr!~luke-jr@user/luke-jr> has joined #bitcoin-core-dev
982023-03-26T20:23:08 *** yanmaani1 <yanmaani1!~yanmaani@gateway/tor-sasl/yanmaani> has quit IRC (Ping timeout: 255 seconds)
992023-03-26T20:26:40 *** yanmaani1 <yanmaani1!~yanmaani@gateway/tor-sasl/yanmaani> has joined #bitcoin-core-dev
1002023-03-26T20:33:17 <ariard> Been asked what was going with Chaincode with the Jackson Lewis letter - After one more what-the-fuck communication from the other side (thanks Alex), here my version of the story: https://gist.github.com/ariard/a4e81e6c0f17d71803352774cac8c77c
1012023-03-26T20:33:25 <ariard> And I don't give a fuck anymore :)
1022023-03-26T21:13:59 *** bugs_ <bugs_!~bugs@user/bugs/x-5128603> has quit IRC (Quit: Leaving)
1032023-03-26T21:31:14 <bitcoin-git> [bitcoin] EthanHeilman opened pull request #27335: Fixes compile errors in MSVC build #27332 (master...fixmsvc) https://github.com/bitcoin/bitcoin/pull/27335
1042023-03-26T21:43:14 *** yanmaani1 <yanmaani1!~yanmaani@gateway/tor-sasl/yanmaani> has quit IRC (Ping timeout: 255 seconds)
1052023-03-26T22:23:04 *** yanmaani1 <yanmaani1!~yanmaani@gateway/tor-sasl/yanmaani> has joined #bitcoin-core-dev
1062023-03-26T22:30:29 *** yanmaani1 <yanmaani1!~yanmaani@gateway/tor-sasl/yanmaani> has quit IRC (Ping timeout: 255 seconds)
1072023-03-26T22:51:58 *** Guest7098 <Guest7098!~Guest70@45.134.22.177> has joined #bitcoin-core-dev
1082023-03-26T22:56:14 *** zeropoint <zeropoint!~alex@45-28-139-114.lightspeed.sntcca.sbcglobal.net> has quit IRC (Quit: leaving)
1092023-03-26T22:57:59 *** Guest7098 <Guest7098!~Guest70@45.134.22.177> has quit IRC (Quit: Client closed)
1102023-03-26T22:58:23 *** Ev0x1 <Ev0x1!~Ev0x1@45.134.22.226> has joined #bitcoin-core-dev
1112023-03-26T23:03:52 *** yanmaani1 <yanmaani1!~yanmaani@gateway/tor-sasl/yanmaani> has joined #bitcoin-core-dev
1122023-03-26T23:10:16 *** pakaro <pakaro!~quassel@2605:8d80:5a1:140c:6ef6:ccc1:10d7:5db1> has joined #bitcoin-core-dev
1132023-03-26T23:10:56 <Ev0x1> d
1142023-03-26T23:11:05 <Ev0x1> Hello ! Tell me what to do, I do not quite understand how multisignature works !
1152023-03-26T23:11:06 <Ev0x1> I created an address with two public keys with the command createmultisig 2 ...
1162023-03-26T23:11:06 <Ev0x1> How do I get the money that came to this address and then sign it?
1172023-03-26T23:24:19 <andytoshi> achow101: https://github.com/bitcoin/bitcoin/blob/master/src/wallet/wallet.cpp#L3599-L3602 i think this code should check whether a spookyman already exists with this ID
1182023-03-26T23:25:09 <andytoshi> currently this function is only called in two places -- in one we generate a uniformly random seed so the spkman will have a unique ID, so that's fine. in the other the key might come from wallet migration data but (i think) the original DB will have a unique seed, so it's also fine
1192023-03-26T23:26:26 <andytoshi> but if we provide any way for a user to import new seeds, you can get dupes, and then bad things happen (we overwrite an old scriptpubkeyman, which i think will lose data, at least in-memory, and then when we try to record the seed for the new spkman in the db, we get an error because (thankfully) we set fOverwrite=false somewhere)
1202023-03-26T23:26:41 <andytoshi> i say "thankfully" because otherwise this would've been pretty hard to notice :P
1212023-03-26T23:32:35 *** yanmaani1 <yanmaani1!~yanmaani@gateway/tor-sasl/yanmaani> has quit IRC (Ping timeout: 255 seconds)
1222023-03-26T23:44:15 *** yanmaani1 <yanmaani1!~yanmaani@gateway/tor-sasl/yanmaani> has joined #bitcoin-core-dev