12023-12-18T00:00:44 *** brunoerg <brunoerg!~brunoerg@187.183.43.117> has quit IRC (Ping timeout: 256 seconds)
22023-12-18T00:01:20 *** AaronvanW <AaronvanW!~AaronvanW@user/AaronvanW> has quit IRC (Remote host closed the connection)
32023-12-18T00:03:08 *** TracaChang <TracaChang!~Traca@gateway/tor-sasl/tracachang> has quit IRC (Remote host closed the connection)
42023-12-18T00:03:41 *** TracaChang <TracaChang!~Traca@gateway/tor-sasl/tracachang> has joined #bitcoin-core-dev
52023-12-18T00:29:43 *** brunoerg <brunoerg!~brunoerg@187.183.43.117> has joined #bitcoin-core-dev
62023-12-18T00:31:40 *** Guest87 <Guest87!~Guest87@108.181.132.151> has joined #bitcoin-core-dev
72023-12-18T00:32:27 *** AaronvanW <AaronvanW!~AaronvanW@user/AaronvanW> has joined #bitcoin-core-dev
82023-12-18T00:34:12 *** brunoerg <brunoerg!~brunoerg@187.183.43.117> has quit IRC (Ping timeout: 252 seconds)
92023-12-18T00:41:10 <bitcoin-git> [bitcoin] Aminkavoos opened pull request #29104: 23.x (master...23.x) https://github.com/bitcoin/bitcoin/pull/29104
102023-12-18T00:56:29 *** szkl <szkl!uid110435@id-110435.uxbridge.irccloud.com> has quit IRC (Quit: Connection closed for inactivity)
112023-12-18T01:03:20 *** brunoerg <brunoerg!~brunoerg@187.183.43.117> has joined #bitcoin-core-dev
122023-12-18T01:06:06 *** AaronvanW <AaronvanW!~AaronvanW@user/AaronvanW> has quit IRC (Ping timeout: 252 seconds)
132023-12-18T01:06:22 *** szkl <szkl!uid110435@id-110435.uxbridge.irccloud.com> has joined #bitcoin-core-dev
142023-12-18T01:08:15 *** brunoerg <brunoerg!~brunoerg@187.183.43.117> has quit IRC (Ping timeout: 256 seconds)
152023-12-18T01:37:34 *** brunoerg <brunoerg!~brunoerg@187.183.43.117> has joined #bitcoin-core-dev
162023-12-18T01:42:10 *** brunoerg <brunoerg!~brunoerg@187.183.43.117> has quit IRC (Ping timeout: 255 seconds)
172023-12-18T01:50:31 *** Guest87 <Guest87!~Guest87@108.181.132.151> has quit IRC (Quit: Client closed)
182023-12-18T02:09:04 *** jonatack <jonatack!~jonatack@user/jonatack> has joined #bitcoin-core-dev
192023-12-18T02:11:48 *** brunoerg <brunoerg!~brunoerg@187.183.43.117> has joined #bitcoin-core-dev
202023-12-18T02:16:30 *** brunoerg <brunoerg!~brunoerg@187.183.43.117> has quit IRC (Ping timeout: 252 seconds)
212023-12-18T02:40:36 *** realies <realies!~realies@user/realies> has quit IRC (Quit: ~)
222023-12-18T02:46:52 *** brunoerg <brunoerg!~brunoerg@187.183.43.117> has joined #bitcoin-core-dev
232023-12-18T02:51:35 *** brunoerg <brunoerg!~brunoerg@187.183.43.117> has quit IRC (Ping timeout: 264 seconds)
242023-12-18T03:03:45 *** AaronvanW <AaronvanW!~AaronvanW@user/AaronvanW> has joined #bitcoin-core-dev
252023-12-18T03:06:29 *** szkl <szkl!uid110435@id-110435.uxbridge.irccloud.com> has quit IRC (Quit: Connection closed for inactivity)
262023-12-18T03:10:29 *** piku <piku!~piku@47-202-112-244.tamp.fl.frontiernet.net> has joined #bitcoin-core-dev
272023-12-18T03:36:15 *** AaronvanW <AaronvanW!~AaronvanW@user/AaronvanW> has quit IRC (Ping timeout: 252 seconds)
282023-12-18T04:00:41 <bitcoin-git> [bitcoin] achow101 closed pull request #29104: 23.x (master...23.x) https://github.com/bitcoin/bitcoin/pull/29104
292023-12-18T04:16:17 *** brunoerg <brunoerg!~brunoerg@187.183.43.117> has joined #bitcoin-core-dev
302023-12-18T04:20:54 *** brunoerg <brunoerg!~brunoerg@187.183.43.117> has quit IRC (Ping timeout: 260 seconds)
312023-12-18T04:24:19 *** kevkevin <kevkevin!~kevkevin@104-182-134-253.lightspeed.cicril.sbcglobal.net> has joined #bitcoin-core-dev
322023-12-18T04:28:40 *** kevkevin <kevkevin!~kevkevin@104-182-134-253.lightspeed.cicril.sbcglobal.net> has quit IRC (Ping timeout: 255 seconds)
332023-12-18T04:36:02 *** rbatty <rbatty!~rbatty@user/rbatty> has joined #bitcoin-core-dev
342023-12-18T04:39:03 *** brunoerg <brunoerg!~brunoerg@187.183.43.117> has joined #bitcoin-core-dev
352023-12-18T04:43:41 *** brunoerg <brunoerg!~brunoerg@187.183.43.117> has quit IRC (Ping timeout: 245 seconds)
362023-12-18T04:55:44 *** piku <piku!~piku@47-202-112-244.tamp.fl.frontiernet.net> has quit IRC (Quit: Leaving)
372023-12-18T05:01:01 *** cmirror <cmirror!~cmirror@4.53.92.114> has quit IRC (Remote host closed the connection)
382023-12-18T05:01:33 *** cmirror <cmirror!~cmirror@4.53.92.114> has joined #bitcoin-core-dev
392023-12-18T05:12:28 *** brunoerg <brunoerg!~brunoerg@187.183.43.117> has joined #bitcoin-core-dev
402023-12-18T05:17:13 *** brunoerg <brunoerg!~brunoerg@187.183.43.117> has quit IRC (Ping timeout: 268 seconds)
412023-12-18T05:30:30 *** PaperSword <PaperSword!~Thunderbi@securemail.qrsnap.io> has joined #bitcoin-core-dev
422023-12-18T05:33:20 *** brunoerg <brunoerg!~brunoerg@187.183.43.117> has joined #bitcoin-core-dev
432023-12-18T05:34:33 *** szkl <szkl!uid110435@id-110435.uxbridge.irccloud.com> has joined #bitcoin-core-dev
442023-12-18T05:38:54 *** brunoerg <brunoerg!~brunoerg@187.183.43.117> has quit IRC (Ping timeout: 252 seconds)
452023-12-18T06:00:51 *** AaronvanW <AaronvanW!~AaronvanW@user/AaronvanW> has joined #bitcoin-core-dev
462023-12-18T06:16:10 *** brunoerg <brunoerg!~brunoerg@187.183.43.117> has joined #bitcoin-core-dev
472023-12-18T06:18:06 *** not_reserved <not_reserved!~not_reser@154.16.157.85> has joined #bitcoin-core-dev
482023-12-18T06:21:11 *** brunoerg <brunoerg!~brunoerg@187.183.43.117> has quit IRC (Ping timeout: 260 seconds)
492023-12-18T06:43:55 *** TallTim <TallTim!~talltim@184-83-238-129-dynamic.midco.net> has quit IRC (Remote host closed the connection)
502023-12-18T06:43:57 *** TallTim_ <TallTim_!~talltim@184-83-238-129-dynamic.midco.net> has joined #bitcoin-core-dev
512023-12-18T06:49:55 *** brunoerg <brunoerg!~brunoerg@187.183.43.117> has joined #bitcoin-core-dev
522023-12-18T06:55:37 *** brunoerg <brunoerg!~brunoerg@187.183.43.117> has quit IRC (Ping timeout: 256 seconds)
532023-12-18T07:03:37 *** AaronvanW <AaronvanW!~AaronvanW@user/AaronvanW> has quit IRC (Ping timeout: 276 seconds)
542023-12-18T07:11:53 *** dviola <dviola!~diego@user/dviola> has quit IRC (Quit: WeeChat 4.1.2)
552023-12-18T07:14:18 *** hardtotell2 <hardtotell2!~hardtotel@user/hardtotell> has joined #bitcoin-core-dev
562023-12-18T07:14:23 *** hardtotell <hardtotell!~hardtotel@user/hardtotell> has quit IRC (Ping timeout: 260 seconds)
572023-12-18T07:14:23 *** hardtotell2 is now known as hardtotell
582023-12-18T07:19:52 *** hardtotell <hardtotell!~hardtotel@user/hardtotell> has quit IRC (Ping timeout: 276 seconds)
592023-12-18T07:24:32 *** brunoerg <brunoerg!~brunoerg@187.183.43.117> has joined #bitcoin-core-dev
602023-12-18T07:29:08 *** brunoerg <brunoerg!~brunoerg@187.183.43.117> has quit IRC (Ping timeout: 255 seconds)
612023-12-18T07:30:58 *** hardtotell <hardtotell!~hardtotel@user/hardtotell> has joined #bitcoin-core-dev
622023-12-18T07:38:18 *** hardtotell <hardtotell!~hardtotel@user/hardtotell> has quit IRC (Ping timeout: 260 seconds)
632023-12-18T07:55:15 *** salvatoshi <salvatoshi!~salvatosh@genymobile-2-6-86.fib.nerim.net> has joined #bitcoin-core-dev
642023-12-18T07:57:32 *** brunoerg <brunoerg!~brunoerg@187.183.43.117> has joined #bitcoin-core-dev
652023-12-18T08:02:23 *** brunoerg <brunoerg!~brunoerg@187.183.43.117> has quit IRC (Ping timeout: 264 seconds)
662023-12-18T08:31:20 *** brunoerg <brunoerg!~brunoerg@187.183.43.117> has joined #bitcoin-core-dev
672023-12-18T08:36:05 *** brunoerg <brunoerg!~brunoerg@187.183.43.117> has quit IRC (Ping timeout: 268 seconds)
682023-12-18T08:42:07 *** hardtotell <hardtotell!~hardtotel@user/hardtotell> has joined #bitcoin-core-dev
692023-12-18T08:47:00 *** conman <conman!~con@180-150-21-3.b49615.mel.static.aussiebb.net> has quit IRC (Remote host closed the connection)
702023-12-18T08:55:44 *** AaronvanW <AaronvanW!~AaronvanW@user/AaronvanW> has joined #bitcoin-core-dev
712023-12-18T09:05:33 *** Guyver2 <Guyver2!~Guyver@77-174-98-73.fixed.kpn.net> has joined #bitcoin-core-dev
722023-12-18T09:07:36 *** brunoerg <brunoerg!~brunoerg@187.183.43.117> has joined #bitcoin-core-dev
732023-12-18T09:12:05 *** brunoerg <brunoerg!~brunoerg@187.183.43.117> has quit IRC (Ping timeout: 240 seconds)
742023-12-18T09:37:22 <bitcoin-git> [bitcoin] fanquake closed pull request #29101: Explain what the wallet password does (master...thanos-107) https://github.com/bitcoin/bitcoin/pull/29101
752023-12-18T09:40:42 *** brunoerg <brunoerg!~brunoerg@187.183.43.117> has joined #bitcoin-core-dev
762023-12-18T09:44:13 <gleb> DrahtBot asks me for review right after i submitted review comments.... weird. https://github.com/bitcoin/bitcoin/pull/28538#event-11274140167
772023-12-18T09:45:28 *** brunoerg <brunoerg!~brunoerg@187.183.43.117> has quit IRC (Ping timeout: 255 seconds)
782023-12-18T09:52:40 *** adiabat_ <adiabat_!~adiabat@63.209.32.102> has quit IRC (Remote host closed the connection)
792023-12-18T09:58:01 *** not_reserved <not_reserved!~not_reser@154.16.157.85> has quit IRC (Quit: Client closed)
802023-12-18T10:10:12 <glozow> gleb: drahty's just funny like that sometimes
812023-12-18T10:11:16 *** brunoerg <brunoerg!~brunoerg@187.183.43.117> has joined #bitcoin-core-dev
822023-12-18T10:16:02 *** brunoerg <brunoerg!~brunoerg@187.183.43.117> has quit IRC (Ping timeout: 260 seconds)
832023-12-18T10:45:31 *** brunoerg <brunoerg!~brunoerg@187.183.43.117> has joined #bitcoin-core-dev
842023-12-18T10:49:56 *** brunoerg <brunoerg!~brunoerg@187.183.43.117> has quit IRC (Ping timeout: 245 seconds)
852023-12-18T10:57:34 *** freesprung512 <freesprung512!~freesprun@user/freesprung> has joined #bitcoin-core-dev
862023-12-18T11:00:13 *** freesprung51 <freesprung51!~freesprun@user/freesprung> has quit IRC (Ping timeout: 276 seconds)
872023-12-18T11:00:13 *** freesprung512 is now known as freesprung51
882023-12-18T11:19:23 *** brunoerg <brunoerg!~brunoerg@187.183.43.117> has joined #bitcoin-core-dev
892023-12-18T11:20:05 *** TallTim_ is now known as TallTim
902023-12-18T11:22:58 *** freesprung51 <freesprung51!~freesprun@user/freesprung> has quit IRC (Ping timeout: 276 seconds)
912023-12-18T11:24:35 *** brunoerg <brunoerg!~brunoerg@187.183.43.117> has quit IRC (Ping timeout: 264 seconds)
922023-12-18T11:26:03 *** brunoerg <brunoerg!~brunoerg@187.183.43.117> has joined #bitcoin-core-dev
932023-12-18T11:29:29 *** ___nick___ <___nick___!~quassel@host31-53-26-90.range31-53.btcentralplus.com> has joined #bitcoin-core-dev
942023-12-18T11:32:32 *** ___nick___ <___nick___!~quassel@host31-53-26-90.range31-53.btcentralplus.com> has quit IRC (Client Quit)
952023-12-18T11:34:59 *** ___nick___ <___nick___!~quassel@host31-53-26-90.range31-53.btcentralplus.com> has joined #bitcoin-core-dev
962023-12-18T12:24:37 *** conman <conman!~con@180-150-21-3.b49615.mel.static.aussiebb.net> has joined #bitcoin-core-dev
972023-12-18T12:48:32 <bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/3695ecbf680a...925a750d99bc
982023-12-18T12:48:33 <bitcoin-git> bitcoin/master ff896d2 fanquake: contrib: drop GCC MAX_VERSION to 4.3.0 in symbol-check
992023-12-18T12:48:33 <bitcoin-git> bitcoin/master 925a750 fanquake: Merge bitcoin/bitcoin#28844: contrib: drop GCC MAX_VERSION to 4.3.0 in sym...
1002023-12-18T12:48:39 <bitcoin-git> [bitcoin] fanquake merged pull request #28844: contrib: drop GCC MAX_VERSION to 4.3.0 in symbol-check (master...libgcc_4_3_0) https://github.com/bitcoin/bitcoin/pull/28844
1012023-12-18T12:53:10 <bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/925a750d99bc...4b94578fd856
1022023-12-18T12:53:11 <bitcoin-git> bitcoin/master fa769d3 MarcoFalke: fuzz: Limit p2p fuzz targets to MAX_PROTOCOL_MESSAGE_LENGTH
1032023-12-18T12:53:12 <bitcoin-git> bitcoin/master 4b94578 fanquake: Merge bitcoin/bitcoin#29079: fuzz: Limit p2p fuzz targets to MAX_PROTOCOL_...
1042023-12-18T12:53:17 <bitcoin-git> [bitcoin] fanquake merged pull request #29079: fuzz: Limit p2p fuzz targets to MAX_PROTOCOL_MESSAGE_LENGTH (master...2312-fuzz-limit-p2p-) https://github.com/bitcoin/bitcoin/pull/29079
1052023-12-18T12:54:42 <bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/4b94578fd856...c840dea27edf
1062023-12-18T12:54:43 <bitcoin-git> bitcoin/master fa87a20 MarcoFalke: build: Bump guix time-machine to unlock riscv64 metal
1072023-12-18T12:54:44 <bitcoin-git> bitcoin/master c840dea fanquake: Merge bitcoin/bitcoin#29078: build: Bump guix time-machine to unlock riscv...
1082023-12-18T12:54:50 <bitcoin-git> [bitcoin] fanquake merged pull request #29078: build: Bump guix time-machine to unlock riscv64 metal (master...2312-riscv64-metal-) https://github.com/bitcoin/bitcoin/pull/29078
1092023-12-18T12:55:38 <bitcoin-git> [bitcoin] SatoshiNT0 opened pull request #29106: bitcoin (master...master) https://github.com/bitcoin/bitcoin/pull/29106
1102023-12-18T12:56:25 <bitcoin-git> [bitcoin] fanquake closed pull request #29106: bitcoin (master...master) https://github.com/bitcoin/bitcoin/pull/29106
1112023-12-18T13:08:22 *** boris <boris!~boris@user/boris> has joined #bitcoin-core-dev
1122023-12-18T13:08:42 *** boris- <boris-!~boris@201.189.90.31> has quit IRC (Ping timeout: 260 seconds)
1132023-12-18T13:16:12 <bitcoin-git> [bitcoin] kristapsk opened pull request #29107: Fix spelling errors (master...fix-spelling) https://github.com/bitcoin/bitcoin/pull/29107
1142023-12-18T13:35:14 *** jon_atack <jon_atack!~jonatack@user/jonatack> has joined #bitcoin-core-dev
1152023-12-18T13:37:47 *** jonatack <jonatack!~jonatack@user/jonatack> has quit IRC (Ping timeout: 264 seconds)
1162023-12-18T13:42:31 *** qxs <qxs!~qxs@gateway/tor-sasl/qxs> has quit IRC (Ping timeout: 240 seconds)
1172023-12-18T13:43:57 *** bitdex <bitdex!~bitdex@gateway/tor-sasl/bitdex> has quit IRC (Quit: = "")
1182023-12-18T13:44:50 *** qxs <qxs!~qxs@gateway/tor-sasl/qxs> has joined #bitcoin-core-dev
1192023-12-18T13:54:14 <bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/c840dea27edf...eef19c4ce2f8
1202023-12-18T13:54:15 <bitcoin-git> bitcoin/master b2fc7a2 dergoegge: [fuzz] Improve fuzzing stability for minisketch harness
1212023-12-18T13:54:16 <bitcoin-git> bitcoin/master eef19c4 fanquake: Merge bitcoin/bitcoin#29064: fuzz: Improve fuzzing stability for minisketc...
1222023-12-18T13:54:21 <bitcoin-git> [bitcoin] fanquake merged pull request #29064: fuzz: Improve fuzzing stability for minisketch harness (master...2023-12-fuzz-stability-minisketch) https://github.com/bitcoin/bitcoin/pull/29064
1232023-12-18T13:57:14 <bitcoin-git> [bitcoin] maflcko opened pull request #29108: refactor: Replace ALWAYS_FALSE with false (master...2312-false-) https://github.com/bitcoin/bitcoin/pull/29108
1242023-12-18T13:58:06 *** test_ <test_!flooded@gateway/vpn/protonvpn/flood/x-43489060> has joined #bitcoin-core-dev
1252023-12-18T14:04:02 <bitcoin-git> [bitcoin] maflcko closed pull request #29108: refactor: Replace ALWAYS_FALSE with false (master...2312-false-) https://github.com/bitcoin/bitcoin/pull/29108
1262023-12-18T14:08:38 *** AaronvanW <AaronvanW!~AaronvanW@user/AaronvanW> has quit IRC (Remote host closed the connection)
1272023-12-18T14:23:52 *** flooded <flooded!flooded@gateway/vpn/protonvpn/flood/x-43489060> has joined #bitcoin-core-dev
1282023-12-18T14:27:26 *** AaronvanW <AaronvanW!~AaronvanW@user/AaronvanW> has joined #bitcoin-core-dev
1292023-12-18T14:27:42 *** qxs <qxs!~qxs@gateway/tor-sasl/qxs> has quit IRC (Remote host closed the connection)
1302023-12-18T14:28:00 *** qxs <qxs!~qxs@gateway/tor-sasl/qxs> has joined #bitcoin-core-dev
1312023-12-18T14:28:11 *** test_ <test_!flooded@gateway/vpn/protonvpn/flood/x-43489060> has quit IRC (Ping timeout: 264 seconds)
1322023-12-18T14:30:37 *** AaronvanW <AaronvanW!~AaronvanW@user/AaronvanW> has quit IRC (Remote host closed the connection)
1332023-12-18T15:01:40 *** AaronvanW <AaronvanW!~AaronvanW@user/AaronvanW> has joined #bitcoin-core-dev
1342023-12-18T15:03:08 *** qxs <qxs!~qxs@gateway/tor-sasl/qxs> has quit IRC (Remote host closed the connection)
1352023-12-18T15:03:22 *** qxs <qxs!~qxs@gateway/tor-sasl/qxs> has joined #bitcoin-core-dev
1362023-12-18T15:05:31 <fanquake> Time for us to turn the MSVC functional tests back off?
1372023-12-18T15:05:42 <fanquake> They were recently re-enabled in #29059
1382023-12-18T15:05:44 <gribble> https://github.com/bitcoin/bitcoin/issues/29059 | Revert "ci: Only run functional tests on windows in master" by hebasto · Pull Request #29059 · bitcoin/bitcoin · GitHub
1392023-12-18T15:06:04 <fanquake> However are clearly still just failing sporadically. See #29090
1402023-12-18T15:06:05 <gribble> https://github.com/bitcoin/bitcoin/issues/29090 | ci: feature_proxy failing in MSVC job · Issue #29090 · bitcoin/bitcoin · GitHub
1412023-12-18T15:06:30 <fanquake> Same random timeouts, different tests etc
1422023-12-18T15:06:35 *** AaronvanW <AaronvanW!~AaronvanW@user/AaronvanW> has quit IRC (Ping timeout: 264 seconds)
1432023-12-18T15:30:42 *** kevkevin <kevkevin!~kevkevin@2600:1700:b30:47c0:b02f:758:3be0:66ff> has joined #bitcoin-core-dev
1442023-12-18T15:34:25 *** not_reserved <not_reserved!~not_reser@154.16.157.99> has joined #bitcoin-core-dev
1452023-12-18T15:35:25 *** kevkevin <kevkevin!~kevkevin@2600:1700:b30:47c0:b02f:758:3be0:66ff> has quit IRC (Ping timeout: 268 seconds)
1462023-12-18T15:35:50 <bitcoin-git> [bitcoin] glozow pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/eef19c4ce2f8...dd391944dc2d
1472023-12-18T15:35:51 <bitcoin-git> bitcoin/master 8dec9c5 ismaelsadeeq: wallet, mempool: propagete `checkChainLimits` error message to wallet
1482023-12-18T15:35:51 <bitcoin-git> bitcoin/master dd39194 glozow: Merge bitcoin/bitcoin#28863: wallet, mempool: propagete `checkChainLimits`...
1492023-12-18T15:35:57 <bitcoin-git> [bitcoin] glozow merged pull request #28863: wallet, mempool: propagete `checkChainLimits` error message to wallet (master...11-2023-prograte-checkPackageLimit-error-up) https://github.com/bitcoin/bitcoin/pull/28863
1502023-12-18T15:37:15 <vasild> https://github.com/bitcoin/bitcoin/blob/eef19c4ce2f85118e439a0d3165f46075c20ca1f/src/validation.h#L883 is cs_main guarding just the pointer m_active_chainstate or also the object that the pointer points to?
1512023-12-18T15:42:14 <vasild> or also keeping the pointer/object in consistency with other variables?
1522023-12-18T15:44:12 <sipa> vasild: my guess is that it's protecting all of those things
1532023-12-18T15:44:34 <sipa> but the annotation on that pointer is just about the pointer itself
1542023-12-18T15:45:18 <sipa> the pointer points to the object contained in either the m_ibd_chainstate or m_snapshot_chainstate unique_ptrs, and those are also annotated to be protected by cs_main
1552023-12-18T15:47:37 <vasild> what about https://github.com/bitcoin/bitcoin/blob/eef19c4ce2f85118e439a0d3165f46075c20ca1f/src/validation.cpp#L5715-L5720 ChainstateManager::ActiveChainstate() which returns the object to a caller that may not own cs_main? That's unsafe.
1562023-12-18T15:49:28 <sipa> i'm wrong; Chainstate has its own internal mutex (Chainstate::m_chainstate_mutex)
1572023-12-18T15:49:45 <vasild> wrong about what?
1582023-12-18T15:51:08 <sipa> i'm wrong in my guess that cs_main protects all of the things you listed; it seems to only protect the pointers, as the objects internally have their own mutex
1592023-12-18T15:51:40 <jamesob> vasild: yes, cs_main is repurposed to protect both the pointer m_active_chainstate and a lot of the chainstate content itself (e.g. coinscache contents)
1602023-12-18T15:52:15 <sipa> jamesob: what does m_chainstate_mutex protect then?
1612023-12-18T15:52:19 <jamesob> e.g. see the `CoinsTip()1 annotation
1622023-12-18T15:52:26 <vasild> so cs_main is guarding just the pointer?
1632023-12-18T15:52:54 <vasild> otherwise it is unsafe to do anything with the return value of ChainstateManager::ActiveChainstate()
1642023-12-18T15:52:59 *** kevkevin <kevkevin!~kevkevin@2600:1700:b30:47c0:71fb:7fcb:3bcc:8991> has joined #bitcoin-core-dev
1652023-12-18T15:53:41 <jamesob> sipa: m_chainstate_mutex is pretty mysterious; as far as I can remember/guess, it's used to get around the fact that you can't go into ActivateBestChain holding cs_main but you still need a mutex at that point. Reading now to refresh my cache...
1662023-12-18T15:54:44 <jamesob> it also looks as though it's used to mutex calling ABC() and InvalidateBlock() - but on the whole it isn't used for very much, which makes its very general name confusing
1672023-12-18T15:55:50 <jamesob> but the headline here is: basically everything relating to Chainstate is guarded solely by cs_main. The implicit design is that all on-disk chainstate stuff is synchronized with cs_main, as well as some tangential in-memory stuff like certain CBlockIndex attributes
1682023-12-18T15:59:06 <jamesob> So after reading code, I think m_chainstate_mutex is used to lock the chainstate during an ABC() call, whereas cs_main is acquired for the granular ABCStep() calls. You might ask "why not just hold cs_main for the whole ABC() call?" I think the rationale was that we want to interrupt the cs_main hold to e.g. service net_processing activity during
1692023-12-18T15:59:06 <jamesob> long best-chain activations
1702023-12-18T15:59:58 <jamesob> vasild sipa: making sense?
1712023-12-18T16:00:08 <sipa> yeah, makes sense to me
1722023-12-18T16:00:18 <sipa> thanks for elaborating
1732023-12-18T16:00:39 <vasild> no :)
1742023-12-18T16:02:10 <vasild> aha!
1752023-12-18T16:02:23 <vasild> so callers that do m_chainman.ActiveChain().Tip()->nHeight must own cs_main
1762023-12-18T16:03:00 <vasild> ActiveChain() const EXCLUSIVE_LOCKS_REQUIRED(GetMutex()) // GetMutex returns cs_main
1772023-12-18T16:03:37 <jamesob> yes, pretty much anything relating to Tip content requires cs_main
1782023-12-18T16:04:40 <vasild> the annotation would not catch usage like: CChain& c = WITH_LOCK(cs_main, return m_chainman.ActiveChain()); /* unsafe */ c.Tip()
1792023-12-18T16:06:02 <vasild> anyway, I guess that there are always ways to shoot yourself in the foot, if really wanted :)
1802023-12-18T16:06:39 <vasild> Thanks!
1812023-12-18T16:06:58 *** cguida <cguida!~cguida@2806:2f0:55e1:f7b9:6b55:7e43:5ea6:2f6> has joined #bitcoin-core-dev
1822023-12-18T16:07:41 <jamesob> sure thing
1832023-12-18T16:10:46 *** cguida <cguida!~cguida@2806:2f0:55e1:f7b9:6b55:7e43:5ea6:2f6> has quit IRC (Remote host closed the connection)
1842023-12-18T16:10:58 *** cguida <cguida!~cguida@2806:2f0:55e1:f7b9:458:f4c9:49bd:c9d7> has joined #bitcoin-core-dev
1852023-12-18T16:11:57 *** freesprung512 <freesprung512!~freesprun@user/freesprung> has joined #bitcoin-core-dev
1862023-12-18T16:15:31 *** brunoerg <brunoerg!~brunoerg@187.183.43.117> has quit IRC (Remote host closed the connection)
1872023-12-18T16:16:36 *** brunoerg <brunoerg!~brunoerg@187.183.43.117> has joined #bitcoin-core-dev
1882023-12-18T16:19:17 *** abubakarsadiq <abubakarsadiq!uid602234@id-602234.hampstead.irccloud.com> has joined #bitcoin-core-dev
1892023-12-18T16:41:57 *** not_reserved <not_reserved!~not_reser@154.16.157.99> has quit IRC (Quit: Client closed)
1902023-12-18T16:42:17 *** not_reserved <not_reserved!~not_reser@154.16.157.99> has joined #bitcoin-core-dev
1912023-12-18T16:57:29 *** AaronvanW <AaronvanW!~AaronvanW@user/AaronvanW> has joined #bitcoin-core-dev
1922023-12-18T17:08:03 *** salvatoshi <salvatoshi!~salvatosh@genymobile-2-6-86.fib.nerim.net> has quit IRC (Ping timeout: 252 seconds)
1932023-12-18T17:27:53 *** Guest32 <Guest32!~Guest32@172.58.122.130> has joined #bitcoin-core-dev
1942023-12-18T17:28:00 *** brunoerg <brunoerg!~brunoerg@187.183.43.117> has quit IRC (Remote host closed the connection)
1952023-12-18T17:28:33 *** brunoerg <brunoerg!~brunoerg@187.183.43.117> has joined #bitcoin-core-dev
1962023-12-18T17:28:37 *** bugs_ <bugs_!~bugs@user/bugs/x-5128603> has joined #bitcoin-core-dev
1972023-12-18T17:31:13 *** AaronvanW <AaronvanW!~AaronvanW@user/AaronvanW> has quit IRC (Ping timeout: 255 seconds)
1982023-12-18T17:32:13 *** salvatoshi <salvatoshi!~salvatosh@lfbn-idf3-1-1331-187.w92-170.abo.wanadoo.fr> has joined #bitcoin-core-dev
1992023-12-18T17:34:34 *** Guest32 <Guest32!~Guest32@172.58.122.130> has quit IRC (Quit: Client closed)
2002023-12-18T17:58:40 *** realies <realies!~realies@user/realies> has joined #bitcoin-core-dev
2012023-12-18T18:01:06 *** preimage <preimage!~halosghos@user/halosghost> has joined #bitcoin-core-dev
2022023-12-18T18:09:31 *** Talkless <Talkless!~Talkless@mail.dargis.net> has joined #bitcoin-core-dev
2032023-12-18T18:14:16 *** brunoerg <brunoerg!~brunoerg@187.183.43.117> has quit IRC (Remote host closed the connection)
2042023-12-18T18:18:03 *** realies <realies!~realies@user/realies> has quit IRC (Quit: ~)
2052023-12-18T18:18:25 *** realies <realies!~realies@user/realies> has joined #bitcoin-core-dev
2062023-12-18T18:24:57 *** realies <realies!~realies@user/realies> has quit IRC (Quit: ~)
2072023-12-18T18:32:13 *** brunoerg <brunoerg!~brunoerg@187.183.43.117> has joined #bitcoin-core-dev
2082023-12-18T18:39:15 *** brunoerg <brunoerg!~brunoerg@187.183.43.117> has quit IRC (Remote host closed the connection)
2092023-12-18T18:43:42 *** brunoerg <brunoerg!~brunoerg@187.183.43.117> has joined #bitcoin-core-dev
2102023-12-18T18:48:35 *** brunoerg <brunoerg!~brunoerg@187.183.43.117> has quit IRC (Ping timeout: 264 seconds)
2112023-12-18T18:58:59 *** abubakarsadiq <abubakarsadiq!uid602234@id-602234.hampstead.irccloud.com> has quit IRC (Quit: Connection closed for inactivity)
2122023-12-18T18:59:37 *** preimage <preimage!~halosghos@user/halosghost> has quit IRC (Quit: WeeChat 4.1.1)
2132023-12-18T19:16:38 *** jarthur <jarthur!~jarthur@user/jarthur> has joined #bitcoin-core-dev
2142023-12-18T19:21:28 *** brunoerg <brunoerg!~brunoerg@187.183.43.117> has joined #bitcoin-core-dev
2152023-12-18T19:25:58 *** brunoerg <brunoerg!~brunoerg@187.183.43.117> has quit IRC (Ping timeout: 255 seconds)
2162023-12-18T19:28:38 *** AaronvanW <AaronvanW!~AaronvanW@user/AaronvanW> has joined #bitcoin-core-dev
2172023-12-18T19:28:47 *** zato <zato!~zato@user/zato> has joined #bitcoin-core-dev
2182023-12-18T19:36:33 *** ___nick___ <___nick___!~quassel@host31-53-26-90.range31-53.btcentralplus.com> has quit IRC (Ping timeout: 252 seconds)
2192023-12-18T19:43:40 *** kevkevin <kevkevin!~kevkevin@2600:1700:b30:47c0:71fb:7fcb:3bcc:8991> has quit IRC (Remote host closed the connection)
2202023-12-18T19:52:31 *** TallTim <TallTim!~talltim@184-83-238-129-dynamic.midco.net> has quit IRC (Ping timeout: 256 seconds)
2212023-12-18T19:55:18 *** brunoerg <brunoerg!~brunoerg@187.183.43.117> has joined #bitcoin-core-dev
2222023-12-18T20:00:12 *** brunoerg <brunoerg!~brunoerg@187.183.43.117> has quit IRC (Ping timeout: 252 seconds)
2232023-12-18T20:00:40 *** huggingbitch <huggingbitch!~huggingbi@94.44.126.32> has joined #bitcoin-core-dev
2242023-12-18T20:01:11 *** AaronvanW <AaronvanW!~AaronvanW@user/AaronvanW> has quit IRC (Ping timeout: 264 seconds)
2252023-12-18T20:03:08 *** huggingbitch <huggingbitch!~huggingbi@94.44.126.32> has quit IRC (Client Quit)
2262023-12-18T20:03:29 *** kevkevin <kevkevin!~kevkevin@2600:1700:b30:47c0:71fb:7fcb:3bcc:8991> has joined #bitcoin-core-dev
2272023-12-18T20:03:41 *** huggingbitch <huggingbitch!~huggingbi@94.44.126.32> has joined #bitcoin-core-dev
2282023-12-18T20:06:46 *** huggingbitch <huggingbitch!~huggingbi@94.44.126.32> has quit IRC (Client Quit)
2292023-12-18T20:07:01 *** huggingbitch <huggingbitch!~huggingbi@94.44.126.32> has joined #bitcoin-core-dev
2302023-12-18T20:07:09 *** TallTim <TallTim!~talltim@184.83.238.129> has joined #bitcoin-core-dev
2312023-12-18T20:13:51 *** cryptapus <cryptapus!~cryptapus@user/cryptapus> has quit IRC (Remote host closed the connection)
2322023-12-18T20:14:37 *** huggingbitch <huggingbitch!~huggingbi@94.44.126.32> has quit IRC (Quit: Client closed)
2332023-12-18T20:16:00 *** Talkless <Talkless!~Talkless@mail.dargis.net> has quit IRC (Quit: Konversation terminated!)
2342023-12-18T20:19:28 *** huggingbitch <huggingbitch!~huggingbi@94.44.126.32> has joined #bitcoin-core-dev
2352023-12-18T20:20:48 *** huggingbitch <huggingbitch!~huggingbi@94.44.126.32> has quit IRC (Client Quit)
2362023-12-18T20:28:16 *** brunoerg <brunoerg!~brunoerg@187.183.43.117> has joined #bitcoin-core-dev
2372023-12-18T20:33:11 *** brunoerg <brunoerg!~brunoerg@187.183.43.117> has quit IRC (Ping timeout: 256 seconds)
2382023-12-18T20:44:14 *** szkl <szkl!uid110435@id-110435.uxbridge.irccloud.com> has quit IRC (Quit: Connection closed for inactivity)
2392023-12-18T20:52:39 *** szkl <szkl!uid110435@id-110435.uxbridge.irccloud.com> has joined #bitcoin-core-dev
2402023-12-18T20:56:01 *** brunoerg <brunoerg!~brunoerg@187.183.43.117> has joined #bitcoin-core-dev
2412023-12-18T21:08:39 *** AaronvanW <AaronvanW!~AaronvanW@user/AaronvanW> has joined #bitcoin-core-dev
2422023-12-18T21:17:13 *** Guyver2 <Guyver2!~Guyver@77-174-98-73.fixed.kpn.net> has quit IRC (Read error: Connection reset by peer)
2432023-12-18T21:18:22 *** not_reserved <not_reserved!~not_reser@154.16.157.99> has quit IRC (Quit: Client closed)
2442023-12-18T21:33:23 *** brunoerg <brunoerg!~brunoerg@187.183.43.117> has quit IRC (Remote host closed the connection)
2452023-12-18T21:34:01 *** brunoerg <brunoerg!~brunoerg@187.183.43.117> has joined #bitcoin-core-dev
2462023-12-18T21:34:36 *** vysn <vysn!~vysn@user/vysn> has joined #bitcoin-core-dev
2472023-12-18T21:40:32 *** kevkevin <kevkevin!~kevkevin@2600:1700:b30:47c0:71fb:7fcb:3bcc:8991> has quit IRC (Remote host closed the connection)
2482023-12-18T21:50:03 *** Guest86 <Guest86!~Guest86@2a02:26f7:ec58:4000:c27b:221f:21e5:86> has joined #bitcoin-core-dev
2492023-12-18T21:50:49 *** Guest86 <Guest86!~Guest86@2a02:26f7:ec58:4000:c27b:221f:21e5:86> has quit IRC (Client Quit)
2502023-12-18T22:06:40 *** vysn <vysn!~vysn@user/vysn> has quit IRC (Remote host closed the connection)
2512023-12-18T22:18:20 *** brunoerg <brunoerg!~brunoerg@187.183.43.117> has quit IRC (Remote host closed the connection)
2522023-12-18T22:20:50 <Sjors[m]> I think I learned today that using Span<std::byte> as a return type is an absolutely terrible idea.
2532023-12-18T22:27:22 <bitcoin-git> [bitcoin] achow101 opened pull request #29112: sqlite: Disallow writing from multiple `SQLiteBatch`s (master...sqlite-concurrent-writes) https://github.com/bitcoin/bitcoin/pull/29112
2542023-12-18T22:42:06 *** AaronvanW <AaronvanW!~AaronvanW@user/AaronvanW> has quit IRC (Remote host closed the connection)
2552023-12-18T22:42:32 *** brunoerg <brunoerg!~brunoerg@187.183.43.117> has joined #bitcoin-core-dev
2562023-12-18T22:47:25 *** brunoerg <brunoerg!~brunoerg@187.183.43.117> has quit IRC (Ping timeout: 276 seconds)
2572023-12-18T23:00:55 *** bugs_ <bugs_!~bugs@user/bugs/x-5128603> has quit IRC (Quit: Leaving)
2582023-12-18T23:07:44 *** Smiler89 <Smiler89!~Smiler89@85.190.84.201> has joined #bitcoin-core-dev
2592023-12-18T23:12:18 <Smiler89> Hey everyone :)
2602023-12-18T23:12:24 <Smiler89> is anyone online here?
2612023-12-18T23:12:28 * Smiler89 looks around
2622023-12-18T23:13:12 *** AaronvanW <AaronvanW!~AaronvanW@user/AaronvanW> has joined #bitcoin-core-dev
2632023-12-18T23:19:51 *** salvatoshi <salvatoshi!~salvatosh@lfbn-idf3-1-1331-187.w92-170.abo.wanadoo.fr> has quit IRC (Ping timeout: 252 seconds)
2642023-12-18T23:29:28 *** dongcarl <dongcarl!~dongcarl@066-065-169-019.res.spectrum.com> has quit IRC (Quit: Ping timeout (120 seconds))
2652023-12-18T23:29:56 *** dongcarl <dongcarl!~dongcarl@066-065-169-019.res.spectrum.com> has joined #bitcoin-core-dev
2662023-12-18T23:45:03 *** bomb-on <bomb-on!~bomb-on@user/bomb-on> has joined #bitcoin-core-dev
2672023-12-18T23:46:36 *** AaronvanW <AaronvanW!~AaronvanW@user/AaronvanW> has quit IRC (Ping timeout: 245 seconds)
2682023-12-18T23:46:45 *** zato <zato!~zato@user/zato> has quit IRC (Quit: Om mani padme hum)
2692023-12-18T23:56:43 *** brunoerg <brunoerg!~brunoerg@187.183.43.117> has joined #bitcoin-core-dev