12024-09-12T00:02:07 <bitcoin-git> [bitcoin] kevkevinpal opened pull request #30875: doc: replaced --enable-debug with -DCMAKE_BUILD_TYPE=Debug in developer-notes (master...devNotesDebugBuild) https://github.com/bitcoin/bitcoin/pull/30875
22024-09-12T00:23:59 *** zeropoint <zeropoint!~alex@45-28-139-114.lightspeed.sntcca.sbcglobal.net> has quit IRC (Quit: leaving)
32024-09-12T00:49:07 *** benwestgate <benwestgate!~BenWestga@2603:8080:7401:18ac:4036:795:1d6b:1e91> has quit IRC (Ping timeout: 272 seconds)
42024-09-12T00:52:34 *** benwestgate <benwestgate!~BenWestga@syn-076-184-062-115.res.spectrum.com> has joined #bitcoin-core-dev
52024-09-12T00:56:31 *** andrewtoth_ <andrewtoth_!~andrewtot@gateway/tor-sasl/andrewtoth> has quit IRC (Ping timeout: 260 seconds)
62024-09-12T02:33:14 *** jonatack <jonatack!~jonatack@user/jonatack> has quit IRC (Ping timeout: 252 seconds)
72024-09-12T02:35:12 *** jonatack <jonatack!~jonatack@user/jonatack> has joined #bitcoin-core-dev
82024-09-12T02:54:52 *** emcy__ <emcy__!~emcy@148.252.147.147> has joined #bitcoin-core-dev
92024-09-12T02:55:14 *** jarthur_ <jarthur_!~jarthur@user/jarthur> has joined #bitcoin-core-dev
102024-09-12T02:55:45 *** jarthur <jarthur!~jarthur@user/jarthur> has quit IRC (Ping timeout: 260 seconds)
112024-09-12T02:55:53 *** jarthur_ is now known as jarthur
122024-09-12T02:57:54 *** mcey_ <mcey_!~emcy@148.252.147.147> has quit IRC (Ping timeout: 260 seconds)
132024-09-12T03:03:23 *** jonatack <jonatack!~jonatack@user/jonatack> has quit IRC (Read error: Connection reset by peer)
142024-09-12T03:07:57 *** jonatack <jonatack!~jonatack@user/jonatack> has joined #bitcoin-core-dev
152024-09-12T03:10:08 *** preimage <preimage!~halosghos@user/halosghost> has quit IRC (Quit: WeeChat 4.4.2)
162024-09-12T04:01:01 *** cmirror <cmirror!~cmirror@4.53.92.114> has quit IRC (Remote host closed the connection)
172024-09-12T04:01:33 *** cmirror <cmirror!~cmirror@4.53.92.114> has joined #bitcoin-core-dev
182024-09-12T04:46:32 *** qxs <qxs!~qxs@gateway/tor-sasl/qxs> has quit IRC (Remote host closed the connection)
192024-09-12T04:46:58 *** qxs <qxs!~qxs@gateway/tor-sasl/qxs> has joined #bitcoin-core-dev
202024-09-12T04:53:07 *** xspynks <xspynks!~xspynks@2804:d59:814c:f600:9922:8fcc:549b:b56f> has joined #bitcoin-core-dev
212024-09-12T05:01:50 *** emcy__ <emcy__!~emcy@148.252.147.147> has quit IRC (Remote host closed the connection)
222024-09-12T05:01:50 *** mcey <mcey!~emcy@148.252.147.147> has joined #bitcoin-core-dev
232024-09-12T05:11:35 *** xspynks <xspynks!~xspynks@2804:d59:814c:f600:9922:8fcc:549b:b56f> has quit IRC (Quit: Client closed)
242024-09-12T06:35:30 *** maxfangx <maxfangx!~maxfangx@142.147.89.217> has quit IRC (Ping timeout: 246 seconds)
252024-09-12T06:35:39 *** maxfangx <maxfangx!~maxfangx@142.147.89.217> has joined #bitcoin-core-dev
262024-09-12T07:14:34 *** virtu <virtu!~virtu@user/virtu> has quit IRC (Remote host closed the connection)
272024-09-12T07:14:49 *** virtu <virtu!~virtu@vmd108895.contaboserver.net> has joined #bitcoin-core-dev
282024-09-12T07:30:01 *** jarthur <jarthur!~jarthur@user/jarthur> has quit IRC (Quit: jarthur)
292024-09-12T07:30:35 *** noonien808310429 <noonien808310429!~noonien@86.125.147.232> has quit IRC (Ping timeout: 255 seconds)
302024-09-12T07:43:53 *** brunoerg <brunoerg!~brunoerg@2804:14c:3bfb:37:8070:82cf:93bb:afb3> has quit IRC (Read error: Connection reset by peer)
312024-09-12T07:44:19 *** brunoerg <brunoerg!~brunoerg@2804:14c:3bfb:37:e48d:675b:4f3e:2a9a> has joined #bitcoin-core-dev
322024-09-12T08:08:20 *** vyHamii <vyHamii!~vyHamii@113.190.232.10> has joined #bitcoin-core-dev
332024-09-12T08:17:40 *** abubakarsadiq <abubakarsadiq!uid602234@id-602234.hampstead.irccloud.com> has joined #bitcoin-core-dev
342024-09-12T08:19:27 *** Guyver2 <Guyver2!~Guyver@77-174-98-73.fixed.kpn.net> has joined #bitcoin-core-dev
352024-09-12T08:28:34 <bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/349632e022da...c77361888695
362024-09-12T08:28:34 <bitcoin-git> bitcoin/master 0037d53 Hennadii Stepanov: build: Fix `ENABLE_WALLET` option
372024-09-12T08:28:35 <bitcoin-git> bitcoin/master c773618 merge-script: Merge bitcoin/bitcoin#30867: build: Fix `ENABLE_WALLET` option
382024-09-12T08:28:35 <bitcoin-git> [bitcoin] fanquake merged pull request #30867: build: Fix `ENABLE_WALLET` option (master...240910-wallet-option) https://github.com/bitcoin/bitcoin/pull/30867
392024-09-12T08:37:33 *** BrandonOdiwuor <BrandonOdiwuor!~BrandonOd@41.90.37.95> has joined #bitcoin-core-dev
402024-09-12T08:37:48 <bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/c77361888695...155963768af6
412024-09-12T08:37:49 <bitcoin-git> bitcoin/master b07fe66 Hennadii Stepanov: build: Minimize I/O operations in `GenerateHeaderFrom{Json,Raw}.cmake`
422024-09-12T08:37:49 <bitcoin-git> bitcoin/master 1559637 merge-script: Merge bitcoin/bitcoin#30842: build: Minimize I/O operations in `GenerateHe...
432024-09-12T08:37:51 <bitcoin-git> [bitcoin] fanquake merged pull request #30842: build: Minimize I/O operations in `GenerateHeaderFrom{Json,Raw}.cmake` (master...240907-scripts) https://github.com/bitcoin/bitcoin/pull/30842
442024-09-12T08:44:13 *** BrandonOdiwuor <BrandonOdiwuor!~BrandonOd@41.90.37.95> has quit IRC (Quit: Client closed)
452024-09-12T08:54:26 <bitcoin-git> [bitcoin] fanquake pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/155963768af6...f0eb63399a8f
462024-09-12T08:54:27 <bitcoin-git> bitcoin/master 6e5f33a Hennadii Stepanov: ci: Handle log files regardless of CMake's version
472024-09-12T08:54:27 <bitcoin-git> bitcoin/master c45186c Hennadii Stepanov: ci: Switch from `make` to `cmake --build`
482024-09-12T08:54:27 <bitcoin-git> bitcoin/master f0eb633 merge-script: Merge bitcoin/bitcoin#30841: ci: Post CMake-migration fixes and amendments
492024-09-12T08:54:29 <bitcoin-git> [bitcoin] fanquake merged pull request #30841: ci: Post CMake-migration fixes and amendments (master...240907-ci-cmake) https://github.com/bitcoin/bitcoin/pull/30841
502024-09-12T09:17:14 <bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/f0eb63399a8f...a86e7a476d50
512024-09-12T09:17:15 <bitcoin-git> bitcoin/master 5ba03e7 Hennadii Stepanov: build: Use CMake's default permissions in macOS `deploy` target
522024-09-12T09:17:15 <bitcoin-git> bitcoin/master a86e7a4 merge-script: Merge bitcoin/bitcoin#30838: build: Use CMake's default permissions in mac...
532024-09-12T09:17:17 <bitcoin-git> [bitcoin] fanquake merged pull request #30838: build: Use CMake's default permissions in macOS `deploy` target (master...240906-permissions) https://github.com/bitcoin/bitcoin/pull/30838
542024-09-12T09:20:49 *** maxfangx <maxfangx!~maxfangx@142.147.89.217> has quit IRC (Ping timeout: 245 seconds)
552024-09-12T09:21:49 *** maxfangx <maxfangx!~maxfangx@142.147.89.217> has joined #bitcoin-core-dev
562024-09-12T09:30:15 <bitcoin-git> [bitcoin] fanquake pushed 8 commits to master: https://github.com/bitcoin/bitcoin/compare/a86e7a476d50...db8350b0e3f5
572024-09-12T09:30:16 <bitcoin-git> bitcoin/master 6f2cb0e Hennadii Stepanov: doc: Amend comment about ZeroMQ config files
582024-09-12T09:30:16 <bitcoin-git> bitcoin/master f03c942 Hennadii Stepanov: build, test: Add missed log options
592024-09-12T09:30:16 <bitcoin-git> bitcoin/master 73b6185 Hennadii Stepanov: build: Print `CMAKE_CXX_COMPILER_ARG1` in summary
602024-09-12T09:30:18 <bitcoin-git> [bitcoin] fanquake merged pull request #30803: build: Minor build system fixes and amendments (master...240903-cmake-amend) https://github.com/bitcoin/bitcoin/pull/30803
612024-09-12T09:30:51 *** mcey_ <mcey_!~emcy@148.252.129.55> has joined #bitcoin-core-dev
622024-09-12T09:34:24 *** mcey <mcey!~emcy@148.252.147.147> has quit IRC (Ping timeout: 276 seconds)
632024-09-12T09:48:41 *** jirijakes <jirijakes!~jirijakes@118.150.148.23> has joined #bitcoin-core-dev
642024-09-12T09:58:58 <bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/db8350b0e3f5...11e2f9fff48f
652024-09-12T09:58:59 <bitcoin-git> bitcoin/master 7b04fab Hennadii Stepanov: build: Introduce "Kernel" installation component
662024-09-12T09:58:59 <bitcoin-git> bitcoin/master 11e2f9f merge-script: Merge bitcoin/bitcoin#30835: build: Introduce "Kernel" installation compon...
672024-09-12T09:59:03 <bitcoin-git> [bitcoin] fanquake merged pull request #30835: build: Introduce "Kernel" installation component (master...240906-kernel) https://github.com/bitcoin/bitcoin/pull/30835
682024-09-12T10:28:33 <bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/11e2f9fff48f...85833cf05fb6
692024-09-12T10:28:33 <bitcoin-git> bitcoin/master 5c80192 Hennadii Stepanov: test: Drop no longer needed workarounds
702024-09-12T10:28:34 <bitcoin-git> bitcoin/master 85833cf merge-script: Merge bitcoin/bitcoin#30847: test: Drop no longer needed workarounds
712024-09-12T10:28:36 <bitcoin-git> [bitcoin] fanquake merged pull request #30847: test: Drop no longer needed workarounds (master...240908-tests) https://github.com/bitcoin/bitcoin/pull/30847
722024-09-12T10:32:36 <bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/85833cf05fb6...fcb61bbc8dd7
732024-09-12T10:32:37 <bitcoin-git> bitcoin/master be4f782 fanquake: contrib: test for FORTIFY_SOURCE in security-check.py
742024-09-12T10:32:38 <bitcoin-git> bitcoin/master fcb61bb merge-script: Merge bitcoin/bitcoin#27038: security-check: test for `_FORTIFY_SOURCE` us...
752024-09-12T10:32:39 <bitcoin-git> [bitcoin] fanquake merged pull request #27038: security-check: test for `_FORTIFY_SOURCE` usage in release binaries (master...sec_check_fortify_source) https://github.com/bitcoin/bitcoin/pull/27038
762024-09-12T10:33:22 <bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/fcb61bbc8dd7...0c1e5072781f
772024-09-12T10:33:23 <bitcoin-git> bitcoin/master f15e817 Pieter Wuille: build: add more CMake presets (dev-mode, libfuzzer, libfuzzer-nosan)
782024-09-12T10:33:23 <bitcoin-git> bitcoin/master 0c1e507 merge-script: Merge bitcoin/bitcoin#30871: build: Add more cmake presets
792024-09-12T10:33:25 <bitcoin-git> [bitcoin] fanquake merged pull request #30871: build: Add more cmake presets (master...202409_cmake_presets) https://github.com/bitcoin/bitcoin/pull/30871
802024-09-12T11:17:15 <bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/0c1e5072781f...a5e99669ccfe
812024-09-12T11:17:15 <bitcoin-git> bitcoin/master 2ad5601 LÅrinc: Remove unused src_dir param from run_tests
822024-09-12T11:17:16 <bitcoin-git> bitcoin/master a5e9966 merge-script: Merge bitcoin/bitcoin#30733: test: remove unused src_dir param from run_te...
832024-09-12T11:17:17 <bitcoin-git> [bitcoin] fanquake merged pull request #30733: test: remove unused src_dir param from run_tests after CMake migration (master...l0rinc/test-runner-param-cleanup) https://github.com/bitcoin/bitcoin/pull/30733
842024-09-12T11:25:15 *** jonatack <jonatack!~jonatack@user/jonatack> has quit IRC (Ping timeout: 252 seconds)
852024-09-12T11:31:31 *** jonatack <jonatack!~jonatack@user/jonatack> has joined #bitcoin-core-dev
862024-09-12T12:00:28 *** kevkevin <kevkevin!~kevkevin@209-242-39-30.rev.dls.net> has joined #bitcoin-core-dev
872024-09-12T12:22:51 *** jonatack <jonatack!~jonatack@user/jonatack> has quit IRC (Ping timeout: 265 seconds)
882024-09-12T12:24:50 *** jonatack <jonatack!~jonatack@user/jonatack> has joined #bitcoin-core-dev
892024-09-12T12:26:50 *** jirijakes <jirijakes!~jirijakes@118.150.148.23> has quit IRC (Ping timeout: 260 seconds)
902024-09-12T12:40:39 *** BrandonOdiwuor <BrandonOdiwuor!~BrandonOd@41.90.37.95> has joined #bitcoin-core-dev
912024-09-12T12:50:40 *** gribble <gribble!~gribble@bitcoin/bot/gribble> has quit IRC (Remote host closed the connection)
922024-09-12T12:53:50 *** gribble <gribble!~gribble@bitcoin/bot/gribble> has joined #bitcoin-core-dev
932024-09-12T12:53:50 *** ChanServ sets mode: +o gribble
942024-09-12T12:57:46 <bitcoin-git> [bitcoin] theStack opened pull request #30877: code style: update .editorconfig file (master...202409-update_editorconfig) https://github.com/bitcoin/bitcoin/pull/30877
952024-09-12T13:06:07 *** BrandonOdiwuor <BrandonOdiwuor!~BrandonOd@41.90.37.95> has quit IRC (Ping timeout: 256 seconds)
962024-09-12T13:20:36 *** andrewtoth_ <andrewtoth_!~andrewtot@gateway/tor-sasl/andrewtoth> has joined #bitcoin-core-dev
972024-09-12T13:49:53 *** preimage <preimage!~halosghos@user/halosghost> has joined #bitcoin-core-dev
982024-09-12T13:50:44 *** pablomartin <pablomartin!~pablomart@193.160.246.74> has joined #bitcoin-core-dev
992024-09-12T13:55:43 *** Emc99 <Emc99!~Emc99@212.129.87.102> has joined #bitcoin-core-dev
1002024-09-12T14:00:02 *** Emc99 <Emc99!~Emc99@212.129.87.102> has quit IRC (Client Quit)
1012024-09-12T14:00:27 *** dzxzg <dzxzg!~dzxzg@user/dzxzg> has joined #bitcoin-core-dev
1022024-09-12T14:00:29 <achow101> #startmeeting
1032024-09-12T14:00:31 <Sjors[m]11> Hi
1042024-09-12T14:00:33 <achow101> #bitcoin-core-dev Meeting: achow101 _aj_ amiti ariard aureleoules b10c BlueMatt brunoerg cfields darosior dergoegge dongcarl fanquake fjahr furszy gleb glozow hebasto instagibbs jamesob jarolrod jonatack josibake kallewoof kanzure kouloumos kvaciral laanwj LarryRuane lightlike luke-jr MacroFake Murch phantomcircuit pinheadmz promag provoostenator ryanofsky sdaftuar S3RK stickies-v sipa sr_gi theStack TheCharlatan vasild
1052024-09-12T14:00:38 <Murch[m]> hi
1062024-09-12T14:00:40 <brunoerg> hi
1072024-09-12T14:00:41 <vasild> hi
1082024-09-12T14:00:41 <gleb> hi
1092024-09-12T14:00:46 <dzxzg> hi
1102024-09-12T14:00:49 <josie> hi
1112024-09-12T14:00:49 <achow101> There are no pre-proposed meeting topics this week. Any last minute ones to add?
1122024-09-12T14:00:51 <TheCharlatan> hi
1132024-09-12T14:00:54 <hebasto> hi
1142024-09-12T14:01:21 <laanwj> hi
1152024-09-12T14:01:23 <pinheadmz> hi
1162024-09-12T14:01:25 <lightlike> Hi
1172024-09-12T14:01:59 <achow101> #topic Ad-hoc high priority for review
1182024-09-12T14:02:00 <achow101> Anything to add or remove from https://github.com/orgs/bitcoin/projects/1/views/4
1192024-09-12T14:02:11 <glozow> hi
1202024-09-12T14:02:35 <sipa> hi
1212024-09-12T14:02:37 *** Emc99 <Emc99!~Emc99@212.129.87.102> has joined #bitcoin-core-dev
1222024-09-12T14:02:40 <Sjors[m]11> #29868 is draft now
1232024-09-12T14:02:42 <gribble> https://github.com/bitcoin/bitcoin/issues/29868 | Reintroduce external signer support for Windows by hebasto · Pull Request #29868 · bitcoin/bitcoin · GitHub
1242024-09-12T14:02:50 <kanzure> hi
1252024-09-12T14:02:57 <bitcoin-git> [bitcoin] willcl-ark opened pull request #30879: test: re-bucket p2p_node_network_limited (master...ci-p2p_node_network_limited) https://github.com/bitcoin/bitcoin/pull/30879
1262024-09-12T14:02:58 <achow101> a bunch of those need rebasing too
1272024-09-12T14:03:19 <Sjors[m]11> And as muchas I like #30043 it needs laanwj
1282024-09-12T14:03:21 <gribble> https://github.com/bitcoin/bitcoin/issues/30043 | net: Replace libnatpmp with built-in PCP+NATPMP implementation by laanwj · Pull Request #30043 · bitcoin/bitcoin · GitHub
1292024-09-12T14:03:30 <laanwj> i'm here
1302024-09-12T14:03:43 <Sjors[m]11> ð
1312024-09-12T14:03:57 <achow101> removing #30043 #29868 and #30116 for now
1322024-09-12T14:03:59 <gribble> https://github.com/bitcoin/bitcoin/issues/30043 | net: Replace libnatpmp with built-in PCP+NATPMP implementation by laanwj · Pull Request #30043 · bitcoin/bitcoin · GitHub
1332024-09-12T14:03:59 <hebasto> yes, 29868 can be removed
1342024-09-12T14:04:00 <gribble> https://github.com/bitcoin/bitcoin/issues/29868 | Reintroduce external signer support for Windows by hebasto · Pull Request #29868 · bitcoin/bitcoin · GitHub
1352024-09-12T14:04:02 <gribble> https://github.com/bitcoin/bitcoin/issues/30116 | p2p: Fill reconciliation sets (Erlay) attempt 2 by sr-gi · Pull Request #30116 · bitcoin/bitcoin · GitHub
1362024-09-12T14:04:03 <laanwj> but yes it needs rebase, will get to it one of these dayd
1372024-09-12T14:04:15 <laanwj> sorry for the delay
1382024-09-12T14:04:51 <Sjors[m]11> Maybe add #30409
1392024-09-12T14:04:53 <gribble> https://github.com/bitcoin/bitcoin/issues/30409 | Introduce waitTipChanged() mining interface, replace RPCNotifyBlockChange, drop CRPCSignals & g_best_block by Sjors · Pull Request #30409 · bitcoin/bitcoin · GitHub
1402024-09-12T14:05:14 <Sjors[m]11> Already has two ACKs but could use more eyes.
1412024-09-12T14:05:14 <achow101> Sjors[m]11: done
1422024-09-12T14:06:21 <achow101> #topic 28.0 release priorities
1432024-09-12T14:06:33 <achow101> Milestone is https://github.com/bitcoin/bitcoin/milestone/66
1442024-09-12T14:06:44 <achow101> Current backports pr #30827
1452024-09-12T14:06:46 <gribble> https://github.com/bitcoin/bitcoin/issues/30827 | [28.x] Further backports and rc2 by achow101 · Pull Request #30827 · bitcoin/bitcoin · GitHub
1462024-09-12T14:07:08 <achow101> The remaining active issue is this ibd regression on Windows
1472024-09-12T14:07:26 <achow101> any thoughts on fixing that?
1482024-09-12T14:08:00 <jonatack> hi
1492024-09-12T14:08:46 <Sjors[m]11> xor causing a slowdown?
1502024-09-12T14:08:53 <dzxzg> I thought maybe it could be the size of the array that is being allocated, have not tested yet though: https://github.com/davidgumberg/bitcoin/commit/64b7313437b0cadce69678efdaacb5c03c912786
1512024-09-12T14:08:54 <achow101> it looks like the ibd regression is probably caused by blocksdir xor, so perhaps we should revert that?
1522024-09-12T14:08:57 <sipa> i don't think we have a good theory what could even cause it
1532024-09-12T14:09:03 <abubakarsadiq> hi
1542024-09-12T14:09:13 <laanwj> looking at the issue, https://github.com/bitcoin/bitcoin/issues/30833 , some people report not seeing any difference
1552024-09-12T14:09:14 <lightlike> maybe revert it just for windows?
1562024-09-12T14:09:21 <lightlike> (or disable)
1572024-09-12T14:09:49 <achow101> i didn't observe a difference, so it might be hardware dependent too
1582024-09-12T14:10:15 <laanwj> it's extremely unlikely to be an xor operation causing such a slowdown
1592024-09-12T14:10:15 <sipa> unfortunately, windows is probably the only platform where people might want the xoring... (due to the prevalance of virus scanners there)
1602024-09-12T14:10:22 <Sjors[m]11> Turning it off for Windows until it's clear what's happening seems like a safe option.
1612024-09-12T14:10:37 <Sjors[m]11> But also it indeed tends to flag stuff
1622024-09-12T14:10:44 <pablomartin> sure is it only Win? https://github.com/bitcoin/bitcoin/issues/30878#issuecomment-2346309699
1632024-09-12T14:10:57 <achow101> pablomartin: that's a different problem
1642024-09-12T14:10:57 <sipa> davidgumberg has a patch that fixes the slowdown if xoring is disabled at runtime
1652024-09-12T14:11:02 <pablomartin> ok
1662024-09-12T14:11:05 <sipa> we could combine that with defaulting it to off on windows
1672024-09-12T14:11:16 <laanwj> might add a flag to turn it off so that the person reporting the issue can benchmark with it on and off?
1682024-09-12T14:12:04 <achow101> sipa: that seems reasonable
1692024-09-12T14:12:11 <laanwj> until it's confirmed that it's really that which is the problem, turning it permanently off for any platform makes no sense
1702024-09-12T14:13:00 <achow101> laanwj: it looks like they bisected to the commit adding it
1712024-09-12T14:13:09 <laanwj> oh, didn't see that
1722024-09-12T14:13:26 <achow101> https://github.com/bitcoin/bitcoin/issues/30833#issuecomment-2335184072
1732024-09-12T14:13:27 <dzxzg> There is a cli flag `-blocksxor=0` for disabling but it doesn't currently stop bitcoin core from avoiding the xor path, I've a commit here: https://github.com/davidgumberg/bitcoin/commit/aa0be4031cbe5bed407bc7a1753875cc1c4ddccb
1742024-09-12T14:13:28 <laanwj> curious, why would xoring (which id assume, is one assembler instruction) cause such a slowdown
1752024-09-12T14:13:28 <dzxzg> And I've reproduced that on 28.x with xoring disabled the regression is gone
1762024-09-12T14:13:49 <achow101> dzxzg: can you open a pr?
1772024-09-12T14:13:52 <sipa> laanwj: there are different code paths in AutoFile that get used when xoring is used vs not used
1782024-09-12T14:13:54 <dzxzg> I suspect it's probably not the x'oring, it's something to do with the array and copying
1792024-09-12T14:13:54 <laanwj> it should be neglible compared to any i/o
1802024-09-12T14:14:10 <dzxzg> achow101: sure
1812024-09-12T14:14:31 <laanwj> sipa: okay, thanks
1822024-09-12T14:14:35 <sipa> given the situation, i think that dzxzg commit doesn't hurt
1832024-09-12T14:14:50 <sipa> then we can disable on enable on windows easily, and revert if fixed
1842024-09-12T14:15:33 <achow101> Has anyone noticed any other issues with 28.0rc1?
1852024-09-12T14:15:52 <achow101> There's a testing guide now: https://github.com/bitcoin-core/bitcoin-devwiki/wiki/28.0-Release-Candidate-Testing-Guide
1862024-09-12T14:16:58 <achow101> or any other topics to discuss today?
1872024-09-12T14:18:20 <achow101> #endmeeting
1882024-09-12T14:18:56 <bitcoin-git> [bitcoin] fjahr opened pull request #30880: test: Wait for local services to update in feature_assumeutxo (master...2024-09-au-services-test) https://github.com/bitcoin/bitcoin/pull/30880
1892024-09-12T14:18:59 <laanwj> <dzxzg> "I suspect it's probably not..." <- allocation overhead can definitely explain an OS specific difference
1902024-09-12T14:19:22 *** Emc99 <Emc99!~Emc99@212.129.87.102> has quit IRC (Quit: Client closed)
1912024-09-12T14:20:04 <laanwj> libc malloc tends to be lots faster than what mingw uses
1922024-09-12T14:22:02 <dzxzg> Yeah it doesn't make sense to me either that the allocation is the issue
1932024-09-12T14:22:36 <dzxzg> Could it be `ftell`? Either it's own overhead or preventing some optimization of writes
1942024-09-12T14:23:35 <sipa> The cost of an `ftell` could differ wildly between platforms.
1952024-09-12T14:23:49 <laanwj> yes, and file systems
1962024-09-12T14:23:52 <sipa> If there are are many more of those if XOR is enabled vs. not, that could explain things.
1972024-09-12T14:24:46 <achow101> each call to AutoFile::write() has a ftell if xoring
1982024-09-12T14:24:50 <achow101> while nothing if not
1992024-09-12T14:25:04 <dzxzg> Yep: https://github.com/bitcoin/bitcoin/blob/a5e99669ccfe0683749ce2e2b21732a359ef62d7/src/streams.cpp#L74
2002024-09-12T14:25:16 <achow101> if someone can figure out how to profile on windows, that'd be great
2012024-09-12T14:25:48 <laanwj> it could cache the current position, right?
2022024-09-12T14:26:05 <sipa> yeah, i was just going to suggest that
2032024-09-12T14:27:17 <sipa> it's possible that fwrite is cached by the libc layer, while ftell always triggers a kernel call?
2042024-09-12T14:27:52 <laanwj> std::fwrite is cached, yes
2052024-09-12T14:28:46 <laanwj> and it's likely ftell is not optimized in any way because software uses it only rarely (usually to seek once to the end to determine file size)
2062024-09-12T14:28:51 <maflcko> Yeah, ftell being the issue seems the most plausible explanation
2072024-09-12T14:29:20 <laanwj> yeah the one-time 4096 byte allocation per write call likely isn't going to be the overhead
2082024-09-12T14:29:34 <vasild> sipa: I think no, I do not think it can happen that ftell reports incorrect because it misses a recent fwrite which is cached and ftell asks the kernel directly
2092024-09-12T14:29:38 <bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/a5e99669ccfe...cf786eccd7ab
2102024-09-12T14:29:39 <bitcoin-git> bitcoin/master 23eedc5 Hennadii Stepanov: build: Skip secp256k1 ctime tests when tests are not being built
2112024-09-12T14:29:39 <bitcoin-git> bitcoin/master cf786ec merge-script: Merge bitcoin/bitcoin#30865: build: Skip secp256k1 ctime tests when tests ...
2122024-09-12T14:29:42 <bitcoin-git> [bitcoin] fanquake merged pull request #30865: build: Skip secp256k1 ctime tests when tests are not being built (master...240910-ctime-test) https://github.com/bitcoin/bitcoin/pull/30865
2132024-09-12T14:30:06 <maflcko> Writing code to cache it would be trivial, but then one could no longer use fseek outside the class
2142024-09-12T14:30:07 <laanwj> vasild: maybe it flushes first
2152024-09-12T14:30:14 <laanwj> this would make sense
2162024-09-12T14:30:40 <bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/cf786eccd7ab...7d43bca05220
2172024-09-12T14:30:41 <bitcoin-git> bitcoin/master 72b46f2 Max Edwards: test: fix exclude parsing for functional runner
2182024-09-12T14:30:41 <bitcoin-git> bitcoin/master 7d43bca merge-script: Merge bitcoin/bitcoin#30872: test: fix exclude parsing for functional runn...
2192024-09-12T14:30:43 <bitcoin-git> [bitcoin] fanquake merged pull request #30872: test: fix exclude parsing for functional runner (master...110924-fix-runner-exclude) https://github.com/bitcoin/bitcoin/pull/30872
2202024-09-12T14:30:52 <vasild> ftell operates on the same layer as fwrite - the libc FILE* stuff
2212024-09-12T14:31:20 <laanwj> maflcko: fseeking outside the class sounds like a bad idea in the first place, not encapsulating it for nothing
2222024-09-12T14:31:37 <sipa> vasild: yes, it does, but it's still possible that libc forwards all ftell calls to the OS
2232024-09-12T14:31:57 <sipa> oh!@
2242024-09-12T14:32:10 <sipa> laanwj: ftell triggering a flush is a better explanation
2252024-09-12T14:32:29 <sipa> maflcko: working on a patch
2262024-09-12T14:32:35 <maflcko> sipa: Thanks!
2272024-09-12T14:35:42 *** Guyver2 <Guyver2!~Guyver@77-174-98-73.fixed.kpn.net> has left #bitcoin-core-dev (Closing Window)
2282024-09-12T14:35:53 <dzxzg> sipa: I can test the patch on my windows box that exhibits the slowdown
2292024-09-12T14:36:30 *** jarthur <jarthur!~jarthur@user/jarthur> has joined #bitcoin-core-dev
2302024-09-12T14:40:45 *** marcofleon <marcofleon!~marcofleo@82.163.218.33> has joined #bitcoin-core-dev
2312024-09-12T14:41:51 <vasild> When CConnman prepares sockets to poll(2), it skips the sockets of some nodes: https://github.com/bitcoin/bitcoin/blob/7d43bca05220ead797e65937dc6df57bdb89defe/src/net.cpp#L2005-L2021
2322024-09-12T14:43:05 <vasild> It would be simpler to poll(2) all sockets and then omit nodes based on these criteria (eg pnode->fPauseRecv).
2332024-09-12T14:44:20 <vasild> Anybody sees or remembers a special reason to do the filtering before poll(2)?
2342024-09-12T14:46:10 <sipa> vasild: i think i last touched that code
2352024-09-12T14:46:29 <vasild> and? :)
2362024-09-12T14:46:40 <sipa> i don't see a problem with always polling and doing the filtering later
2372024-09-12T14:47:02 <vasild> \o/
2382024-09-12T14:51:25 <laanwj> couldn't polling connections unnecessarily have a potential performance overhead?
2392024-09-12T14:52:38 <laanwj> not sure it makes much of a difference, it's one system call either way, but i suspect that's the reason to only add conditionally
2402024-09-12T14:53:26 <sipa> laanwj: maybe, but i sort of assume that polling many file descriptors at once is pretty well optimized in the kernel, so the marginal cost for an extra one is low
2412024-09-12T14:53:44 <sipa> likely more so than our own code for determining what to poll
2422024-09-12T14:54:06 <sipa> 1090551 pts/1 S+ 0:00 /bin/sh -c cd /home/pw/git/bitcoin/build_dev_mode/src/bench && /usr/bin/cmake -DRAW_SOURCE_PATH=/home/pw/git/bi
2432024-09-12T14:54:09 <sipa> 1090553 pts/1 R+ 2:20 /usr/bin/cmake -DRAW_SOURCE_PATH=/home/pw/git/bitcoin/src/bench/data/block413567.raw -DHEADER_PATH=/home/pw/g
2442024-09-12T14:54:30 <sipa> anyone have a clue why building block413567.raw.h seems to take forever?
2452024-09-12T14:54:47 <laanwj> agree, it's not like we're dealing with ten thousands of extra fds here anyway
2462024-09-12T14:54:56 <fanquake> sipa: probably a regression from #30842
2472024-09-12T14:54:57 <gribble> https://github.com/bitcoin/bitcoin/issues/30842 | build: Minimize I/O operations in `GenerateHeaderFrom{Json,Raw}.cmake` by hebasto · Pull Request #30842 · bitcoin/bitcoin · GitHub
2482024-09-12T14:55:05 <fanquake> a similar issue was also reported there
2492024-09-12T14:55:34 <sipa> fanquake: thanks
2502024-09-12T14:55:50 <fanquake> ill open an issue to track
2512024-09-12T14:56:21 <fanquake> given it was meant to be an optimsation for native windows, which seems to be causing perf issues on linux, should probably be reverted, unless we find a quick fix
2522024-09-12T14:57:57 <fanquake> #30881
2532024-09-12T14:57:58 <gribble> https://github.com/bitcoin/bitcoin/issues/30881 | cmake: GenerateHeaderFrom very slow · Issue #30881 · bitcoin/bitcoin · GitHub
2542024-09-12T14:58:36 <sipa> reverting 30842 fixes the issue
2552024-09-12T15:00:03 *** jarthur <jarthur!~jarthur@user/jarthur> has quit IRC (Ping timeout: 276 seconds)
2562024-09-12T15:03:16 *** jarthur_ <jarthur_!~jarthur@user/jarthur> has joined #bitcoin-core-dev
2572024-09-12T15:13:37 *** pablomartin <pablomartin!~pablomart@193.160.246.74> has quit IRC (Ping timeout: 272 seconds)
2582024-09-12T15:16:56 <bitcoin-git> [bitcoin] dergoegge opened pull request #30882: wip: Split fuzz binary (take 2) (master...2024-09-split-fuzz) https://github.com/bitcoin/bitcoin/pull/30882
2592024-09-12T15:19:51 *** bugs_ <bugs_!~bugs@user/bugs/x-5128603> has joined #bitcoin-core-dev
2602024-09-12T15:20:27 <dzxzg> I tried setting up windows profiling in Visual Studio but could only get the CPU profiler to work, on my system at least Visual Studio just crashes when I try to use the more sophisticated "Instrumentation" profiler that measures call counts and wall clock time taken by calls with bitcoin core. (You have to add the /PROFILE linker flag to use the
2612024-09-12T15:20:28 <dzxzg> instrumentation profiler)
2622024-09-12T15:24:57 *** zeropoint <zeropoint!~alex@45-28-139-114.lightspeed.sntcca.sbcglobal.net> has joined #bitcoin-core-dev
2632024-09-12T15:29:12 <maflcko> PSA, if you receive the "At least one of the CI tasks failed." DrahtBot notification, it is a true issue with the pull request, and not one of the (sadly currently common) unrelated ones.
2642024-09-12T15:32:19 <sipa> good DrahtBot
2652024-09-12T15:38:05 <bitcoin-git> [bitcoin] hebasto opened pull request #30883: Revert "build: Minimize I/O operations in `GenerateHeaderFrom{Json,Raw}.cmake`" (master...240912-slow-string) https://github.com/bitcoin/bitcoin/pull/30883
2662024-09-12T15:39:41 <bitcoin-git> [bitcoin] fanquake pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/7d43bca05220...24817e8b1510
2672024-09-12T15:39:41 <bitcoin-git> bitcoin/master 45be32f TheCharlatan: build: Produce a usable static kernel library
2682024-09-12T15:39:42 <bitcoin-git> bitcoin/master 0dd16d7 TheCharlatan: build: Add a pkg-config file for libbitcoinkernel
2692024-09-12T15:39:42 <bitcoin-git> bitcoin/master 24817e8 merge-script: Merge bitcoin/bitcoin#30814: kernel: Create usable static kernel library
2702024-09-12T15:39:43 <bitcoin-git> [bitcoin] fanquake merged pull request #30814: kernel: Create usable static kernel library (master...staticKernel) https://github.com/bitcoin/bitcoin/pull/30814
2712024-09-12T15:53:38 <bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/24817e8b1510...07c7c96022dd
2722024-09-12T15:53:38 <bitcoin-git> bitcoin/master fdeb717 Hennadii Stepanov: Revert "build: Minimize I/O operations in `GenerateHeaderFrom{Json,Raw}.cm...
2732024-09-12T15:53:38 <bitcoin-git> bitcoin/master 07c7c96 merge-script: Merge bitcoin/bitcoin#30883: build: Revert "Minimize I/O operations in `Ge...
2742024-09-12T15:53:40 <bitcoin-git> [bitcoin] fanquake merged pull request #30883: build: Revert "Minimize I/O operations in `GenerateHeaderFrom{Json,Raw}.cmake`" (master...240912-slow-string) https://github.com/bitcoin/bitcoin/pull/30883
2752024-09-12T15:54:24 *** _flooded <_flooded!flooded@gateway/vpn/protonvpn/flood/x-43489060> has joined #bitcoin-core-dev
2762024-09-12T15:55:34 *** jonasschnelli_ <jonasschnelli_!~jonasschn@2a01:4f9:3081:504d::2> has joined #bitcoin-core-dev
2772024-09-12T15:56:07 *** he1 <he1!hel@libera/staff/el> has joined #bitcoin-core-dev
2782024-09-12T15:57:26 <bitcoin-git> [bitcoin] sipa opened pull request #30884: streams: cache file position within AutoFile (master...202409_reduce_ftell_xor) https://github.com/bitcoin/bitcoin/pull/30884
2792024-09-12T15:57:53 <sipa> dzxzg: ^
2802024-09-12T15:58:16 *** gmaxwell_ <gmaxwell_!~gmaxwell@user/gmaxwell> has joined #bitcoin-core-dev
2812024-09-12T15:58:23 *** nickler_ <nickler_!~nickler@static.219.205.69.159.clients.your-server.de> has joined #bitcoin-core-dev
2822024-09-12T15:58:50 *** zeropoin1 <zeropoin1!~alex@45-28-139-114.lightspeed.sntcca.sbcglobal.net> has joined #bitcoin-core-dev
2832024-09-12T15:58:53 *** andytosh1 <andytosh1!~apoelstra@user/andytoshi> has joined #bitcoin-core-dev
2842024-09-12T16:00:37 *** dzxzg <dzxzg!~dzxzg@user/dzxzg> has quit IRC (Quit: Client closed)
2852024-09-12T16:01:18 *** dzxzg <dzxzg!~dzxzg@user/dzxzg> has joined #bitcoin-core-dev
2862024-09-12T16:02:03 <dzxzg> sipa: thanks, testing now
2872024-09-12T16:02:41 <sipa> great
2882024-09-12T16:03:31 *** zeropoint <zeropoint!~alex@45-28-139-114.lightspeed.sntcca.sbcglobal.net> has quit IRC (*.net *.split)
2892024-09-12T16:03:31 *** jarthur_ <jarthur_!~jarthur@user/jarthur> has quit IRC (*.net *.split)
2902024-09-12T16:03:31 *** preimage <preimage!~halosghos@user/halosghost> has quit IRC (*.net *.split)
2912024-09-12T16:03:31 *** jetpack <jetpack!~jetpack@2605:2700:1:100e:dc::f01d> has quit IRC (*.net *.split)
2922024-09-12T16:03:31 *** gmaxwell <gmaxwell!~gmaxwell@user/gmaxwell> has quit IRC (*.net *.split)
2932024-09-12T16:03:31 *** nanotube <nanotube!~nanotube@user/nanotube> has quit IRC (*.net *.split)
2942024-09-12T16:03:31 *** hel <hel!hel@libera/staff/el> has quit IRC (*.net *.split)
2952024-09-12T16:03:31 *** kouloumos <kouloumos!sid539228@id-539228.tinside.irccloud.com> has quit IRC (*.net *.split)
2962024-09-12T16:03:31 *** _flood <_flood!flooded@gateway/vpn/protonvpn/flood/x-43489060> has quit IRC (*.net *.split)
2972024-09-12T16:03:32 *** hugohn____ <hugohn____!sid304114@id-304114.lymington.irccloud.com> has quit IRC (*.net *.split)
2982024-09-12T16:03:32 *** reardencode <reardencode!~reardenco@console.reardencode.com> has quit IRC (*.net *.split)
2992024-09-12T16:03:32 *** nickler <nickler!~nickler@static.219.205.69.159.clients.your-server.de> has quit IRC (*.net *.split)
3002024-09-12T16:03:32 *** achow101 <achow101!~achow101@user/achow101> has quit IRC (*.net *.split)
3012024-09-12T16:03:32 *** andytoshi <andytoshi!~apoelstra@user/andytoshi> has quit IRC (*.net *.split)
3022024-09-12T16:03:32 *** jonasschnelli <jonasschnelli!~jonasschn@bitcoinsrv3.jonasschnelli.ch> has quit IRC (*.net *.split)
3032024-09-12T16:03:35 *** he1 is now known as hel
3042024-09-12T16:10:30 *** nanotube <nanotube!~nanotube@user/nanotube> has joined #bitcoin-core-dev
3052024-09-12T16:28:22 *** dzxzg <dzxzg!~dzxzg@user/dzxzg> has quit IRC (Quit: Client closed)
3062024-09-12T16:28:37 *** dzxzg <dzxzg!~dzxzg@user/dzxzg> has joined #bitcoin-core-dev
3072024-09-12T16:31:32 <bitcoin-git> [bitcoin] davidgumberg closed pull request #29965: Lint: improve subtree exclusion (master...rustlinv2) https://github.com/bitcoin/bitcoin/pull/29965
3082024-09-12T16:36:46 <bitcoin-git> [bitcoin] ryanofsky pushed 4 commits to master: https://github.com/bitcoin/bitcoin/compare/07c7c96022dd...be768dbd185b
3092024-09-12T16:36:47 <bitcoin-git> bitcoin/master 743ac30 LÅrinc: Add std::optional support to Boost's equality check
3102024-09-12T16:36:47 <bitcoin-git> bitcoin/master 1994786 LÅrinc: Use BOOST_CHECK_EQUAL for optional, arith_uint256, uint256, uint160
3112024-09-12T16:36:47 <bitcoin-git> bitcoin/master 1eac96a LÅrinc: Compare FromUserHex result against other hex validators and parsers
3122024-09-12T16:36:48 <bitcoin-git> [bitcoin] ryanofsky merged pull request #30618: test: support std::optional in BOOST_CHECK_* and increase FromUserHex fuzz feature coverage (master...paplorinc/uint256S-usages) https://github.com/bitcoin/bitcoin/pull/30618
3132024-09-12T16:52:28 *** adiabat <adiabat!~adiabat@63.209.32.102> has quit IRC (Remote host closed the connection)
3142024-09-12T16:52:47 *** adiabat <adiabat!~adiabat@63.209.32.102> has joined #bitcoin-core-dev
3152024-09-12T16:54:26 *** preimage <preimage!~halosghos@user/halosghost> has joined #bitcoin-core-dev
3162024-09-12T16:56:16 *** PaperSword <PaperSword!~Thunderbi@securemail.qrsnap.io> has joined #bitcoin-core-dev
3172024-09-12T17:00:09 *** dzxzg <dzxzg!~dzxzg@user/dzxzg> has quit IRC (Ping timeout: 256 seconds)
3182024-09-12T17:01:28 *** jarthur_ <jarthur_!~jarthur@user/jarthur> has joined #bitcoin-core-dev
3192024-09-12T17:01:28 *** jetpack <jetpack!~jetpack@2605:2700:1:100e:dc::f01d> has joined #bitcoin-core-dev
3202024-09-12T17:01:28 *** kouloumos <kouloumos!sid539228@id-539228.tinside.irccloud.com> has joined #bitcoin-core-dev
3212024-09-12T17:01:28 *** hugohn____ <hugohn____!sid304114@id-304114.lymington.irccloud.com> has joined #bitcoin-core-dev
3222024-09-12T17:01:28 *** reardencode <reardencode!~reardenco@console.reardencode.com> has joined #bitcoin-core-dev
3232024-09-12T17:01:28 *** achow101 <achow101!~achow101@user/achow101> has joined #bitcoin-core-dev
3242024-09-12T17:01:36 *** marcofleon <marcofleon!~marcofleo@82.163.218.33> has quit IRC (Quit: Connection closed)
3252024-09-12T17:03:57 *** PaperSword <PaperSword!~Thunderbi@securemail.qrsnap.io> has quit IRC (Quit: PaperSword)
3262024-09-12T17:22:02 <bitcoin-git> [bitcoin] ryanofsky pushed 5 commits to master: https://github.com/bitcoin/bitcoin/compare/be768dbd185b...e46bebb444df
3272024-09-12T17:22:02 <bitcoin-git> bitcoin/master fae7b83 MarcoFalke: lint: Remove forbidden functions from lint-format-strings.py
3282024-09-12T17:22:03 <bitcoin-git> bitcoin/master faa62c0 MarcoFalke: util: Add ConstevalFormatString
3292024-09-12T17:22:03 <bitcoin-git> bitcoin/master fa7087b MarcoFalke: util: Use compile-time check for FatalErrorf
3302024-09-12T17:22:03 <bitcoin-git> [bitcoin] ryanofsky merged pull request #30546: util: Use consteval checked format string in FatalErrorf, LogConnectFailure (master...2407-log) https://github.com/bitcoin/bitcoin/pull/30546
3312024-09-12T17:29:49 *** aleggg <aleggg!~aleggg@177.204.240.221.dynamic.adsl.gvt.net.br> has joined #bitcoin-core-dev
3322024-09-12T17:33:08 *** Talkless <Talkless!~Talkless@mail.dargis.net> has joined #bitcoin-core-dev
3332024-09-12T17:33:11 <bitcoin-git> [bitcoin] fjahr opened pull request #30885: scripted-diff: Modernize nLocalServices to m_local_services (master...2024-09-localservices-new) https://github.com/bitcoin/bitcoin/pull/30885
3342024-09-12T17:38:46 *** dzxzg <dzxzg!~dzxzg@user/dzxzg> has joined #bitcoin-core-dev
3352024-09-12T17:39:40 <bitcoin-git> [bitcoin] instagibbs opened pull request #30886: rpc: Add support to populate PSBT input utxos via rpc (master...2024-09-updateutxo_psbt) https://github.com/bitcoin/bitcoin/pull/30886
3362024-09-12T18:00:41 *** ___nick___ <___nick___!~quassel@82-132-212-116.dab.02.net> has joined #bitcoin-core-dev
3372024-09-12T18:02:33 <bitcoin-git> [bitcoin] l0rinc opened pull request #30888: build: Minimize I/O operations in GenerateHeaderFromRaw.cmake (master...lorinc/cmake-header-optimization) https://github.com/bitcoin/bitcoin/pull/30888
3382024-09-12T18:30:28 *** ___nick___ <___nick___!~quassel@82-132-212-116.dab.02.net> has quit IRC (Quit: https://quassel-irc.org - Chat comfortably. Anywhere.)
3392024-09-12T18:32:44 *** ___nick___ <___nick___!~quassel@82-132-212-116.dab.02.net> has joined #bitcoin-core-dev
3402024-09-12T18:33:38 *** ___nick___ <___nick___!~quassel@82-132-212-116.dab.02.net> has quit IRC (Client Quit)
3412024-09-12T18:35:56 *** ___nick___ <___nick___!~quassel@82-132-212-116.dab.02.net> has joined #bitcoin-core-dev
3422024-09-12T18:37:22 <bitcoin-git> [bitcoin] maflcko opened pull request #30889: log: Use ConstevalFormatString (master...2407-log) https://github.com/bitcoin/bitcoin/pull/30889
3432024-09-12T18:37:24 *** abubakarsadiq <abubakarsadiq!uid602234@id-602234.hampstead.irccloud.com> has quit IRC (Quit: Connection closed for inactivity)
3442024-09-12T18:47:39 *** Talkless <Talkless!~Talkless@mail.dargis.net> has quit IRC (Remote host closed the connection)
3452024-09-12T18:52:23 <bitcoin-git> [bitcoin] achow101 pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/e46bebb444df...cf0120ff024a
3462024-09-12T18:52:23 <bitcoin-git> bitcoin/master 19f4a7c Fabian Jahr: test: Wait for local services to update in feature_assumeutxo
3472024-09-12T18:52:23 <bitcoin-git> bitcoin/master cf0120f Ava Chow: Merge bitcoin/bitcoin#30880: test: Wait for local services to update in fe...
3482024-09-12T18:52:25 <bitcoin-git> [bitcoin] achow101 merged pull request #30880: test: Wait for local services to update in feature_assumeutxo (master...2024-09-au-services-test) https://github.com/bitcoin/bitcoin/pull/30880
3492024-09-12T18:57:02 <bitcoin-git> [bitcoin] jonatack opened pull request #30890: doc: unit test runner help fixup (master...2024-09-unit-test-doc-fixup) https://github.com/bitcoin/bitcoin/pull/30890
3502024-09-12T18:57:04 *** abubakarsadiq <abubakarsadiq!uid602234@id-602234.hampstead.irccloud.com> has joined #bitcoin-core-dev
3512024-09-12T18:58:01 *** dzxzg <dzxzg!~dzxzg@user/dzxzg> has quit IRC (Ping timeout: 256 seconds)
3522024-09-12T19:10:40 *** jarthur_ is now known as jarthur
3532024-09-12T19:34:25 *** kevkevin <kevkevin!~kevkevin@209-242-39-30.rev.dls.net> has quit IRC (Remote host closed the connection)
3542024-09-12T19:36:59 *** kevkevin <kevkevin!~kevkevin@209-242-39-30.rev.dls.net> has joined #bitcoin-core-dev
3552024-09-12T19:41:49 *** kevkevin <kevkevin!~kevkevin@209-242-39-30.rev.dls.net> has quit IRC (Ping timeout: 260 seconds)
3562024-09-12T19:48:49 *** kevkevin <kevkevin!~kevkevin@2607:fb90:9b3c:a418:41c8:d830:6973:dcf7> has joined #bitcoin-core-dev
3572024-09-12T20:04:05 *** ___nick___ <___nick___!~quassel@82-132-212-116.dab.02.net> has quit IRC (Ping timeout: 252 seconds)
3582024-09-12T20:07:20 *** Guest53 <Guest53!~Guest53@2a02:908:f21:d480:bd49:327c:efe7:bbc8> has joined #bitcoin-core-dev
3592024-09-12T20:08:31 *** Guest53 <Guest53!~Guest53@2a02:908:f21:d480:bd49:327c:efe7:bbc8> has quit IRC (Client Quit)
3602024-09-12T20:14:03 *** Guest33 <Guest33!~Guest33@2001:8a0:6df7:fe00:21da:75ae:95b4:1acc> has joined #bitcoin-core-dev
3612024-09-12T20:42:33 *** Guest12 <Guest12!~Guest33@2001:8a0:6df7:fe00:21da:75ae:95b4:1acc> has joined #bitcoin-core-dev
3622024-09-12T20:45:41 *** Guest33 <Guest33!~Guest33@2001:8a0:6df7:fe00:21da:75ae:95b4:1acc> has quit IRC (Ping timeout: 256 seconds)
3632024-09-12T20:51:00 *** kevkevin <kevkevin!~kevkevin@2607:fb90:9b3c:a418:41c8:d830:6973:dcf7> has quit IRC (Remote host closed the connection)
3642024-09-12T20:53:58 *** twistedline <twistedline!~bitcoin@185.193.125.44> has quit IRC (Ping timeout: 252 seconds)
3652024-09-12T20:54:23 *** twistedline <twistedline!~bitcoin@185.193.125.44> has joined #bitcoin-core-dev
3662024-09-12T20:58:43 *** Guest12 <Guest12!~Guest33@2001:8a0:6df7:fe00:21da:75ae:95b4:1acc> has quit IRC (Ping timeout: 256 seconds)
3672024-09-12T21:22:51 <bitcoin-git> [bitcoin] fjahr opened pull request #30892: test: Check already deactivated network stays suspended after dumptxoutset (master...2024-09-network-inactive) https://github.com/bitcoin/bitcoin/pull/30892
3682024-09-12T21:24:03 *** twistedline_ <twistedline_!~bitcoin@185.193.125.44> has joined #bitcoin-core-dev
3692024-09-12T21:24:07 *** twistedline <twistedline!~bitcoin@185.193.125.44> has quit IRC (Ping timeout: 272 seconds)
3702024-09-12T21:36:52 *** emcy__ <emcy__!~emcy@85.255.237.50> has joined #bitcoin-core-dev
3712024-09-12T21:39:48 *** mcey_ <mcey_!~emcy@148.252.129.55> has quit IRC (Ping timeout: 252 seconds)
3722024-09-12T21:42:22 <bitcoin-git> [bitcoin] fjahr opened pull request #30893: test: Introduce ensure helper (master...2024-09-shouldnt-happen) https://github.com/bitcoin/bitcoin/pull/30893
3732024-09-12T21:48:47 *** preimage <preimage!~halosghos@user/halosghost> has quit IRC (Quit: WeeChat 4.4.2)
3742024-09-12T21:51:10 *** kevkevin <kevkevin!~kevkevin@209-242-39-30.rev.dls.net> has joined #bitcoin-core-dev
3752024-09-12T21:56:24 *** _andrewtoth_ <_andrewtoth_!~andrewtot@gateway/tor-sasl/andrewtoth> has joined #bitcoin-core-dev
3762024-09-12T21:57:53 *** bugs_ <bugs_!~bugs@user/bugs/x-5128603> has quit IRC (Quit: Leaving)
3772024-09-12T21:58:51 *** andrewtoth_ <andrewtoth_!~andrewtot@gateway/tor-sasl/andrewtoth> has quit IRC (Ping timeout: 260 seconds)
3782024-09-12T21:59:46 *** _andrewtoth_ <_andrewtoth_!~andrewtot@gateway/tor-sasl/andrewtoth> has quit IRC (Remote host closed the connection)
3792024-09-12T22:01:46 <bitcoin-git> [gui] furszy opened pull request #835: gui: fix crash when closing wallet (master...2024_gui_fix_wallet_close_crash) https://github.com/bitcoin-core/gui/pull/835
3802024-09-12T22:11:31 *** pablomartin <pablomartin!~pablomart@193.160.246.70> has joined #bitcoin-core-dev
3812024-09-12T22:38:20 *** pablomartin <pablomartin!~pablomart@193.160.246.70> has quit IRC (Quit: Leaving)
3822024-09-12T23:53:14 *** jarthur <jarthur!~jarthur@user/jarthur> has quit IRC (Ping timeout: 260 seconds)
3832024-09-12T23:56:24 *** jarthur_ <jarthur_!~jarthur@user/jarthur> has joined #bitcoin-core-dev
3842024-09-12T23:57:09 *** achow101 <achow101!~achow101@user/achow101> has quit IRC (Quit: Bye)
3852024-09-12T23:57:45 *** achow101 <achow101!~achow101@user/achow101> has joined #bitcoin-core-dev