12025-05-23T00:04:44 *** jespada <jespada!~jespada@r167-61-220-219.dialup.adsl.anteldata.net.uy> has quit IRC (Ping timeout: 252 seconds)
22025-05-23T00:07:01 *** emcy__ <emcy__!~emcy@148.252.132.78> has joined #bitcoin-core-dev
32025-05-23T00:09:36 *** zeropoint <zeropoint!~alex@45-28-139-114.lightspeed.sntcca.sbcglobal.net> has quit IRC (Quit: leaving)
42025-05-23T00:10:39 *** mcey_ <mcey_!~emcy@185.69.144.38> has quit IRC (Ping timeout: 276 seconds)
52025-05-23T00:18:07 *** antanst <antanst!~antanst@user/antanst> has quit IRC (Read error: Connection reset by peer)
62025-05-23T00:18:08 *** antanst9 <antanst9!~antanst@user/antanst> has joined #bitcoin-core-dev
72025-05-23T00:39:55 <bitcoin-git> [bitcoin] achow101 opened pull request #32597: wallet: Always set descriptor cache upgraded flag for new wallets (master...desc-cache-is-upgraded) https://github.com/bitcoin/bitcoin/pull/32597
82025-05-23T00:42:11 <bitcoin-git> [bitcoin] achow101 opened pull request #32598: walletdb: Log additional exception error messages for corrupted wallets (master...loadwallet-log-runtime_error) https://github.com/bitcoin/bitcoin/pull/32598
92025-05-23T01:16:25 <jon_atack> Would someone with label privileges add the Review club label to the pull for next week's meeting, please?
102025-05-23T01:16:27 <jon_atack> https://github.com/bitcoin/bitcoin/pull/32051
112025-05-23T03:14:19 *** charlie_capt <charlie_capt!~charlie_c@119.75.194.99> has joined #bitcoin-core-dev
122025-05-23T03:24:21 *** kevkevin <kevkevin!~kevkevin@209.242.39.30> has joined #bitcoin-core-dev
132025-05-23T03:27:46 *** charlie_capt <charlie_capt!~charlie_c@119.75.194.99> has quit IRC (Quit: Client closed)
142025-05-23T03:29:03 *** kevkevin <kevkevin!~kevkevin@209.242.39.30> has quit IRC (Ping timeout: 265 seconds)
152025-05-23T03:32:00 *** Cory80 <Cory80!~Cory80@user/pasha> has quit IRC (Quit: Client closed)
162025-05-23T03:32:30 *** Cory80 <Cory80!~Cory80@user/pasha> has joined #bitcoin-core-dev
172025-05-23T03:39:38 *** maflcko <maflcko!~none@107.172.8.183> has quit IRC (Quit: ZNC 1.8.2+deb2ubuntu0.1 - https://znc.in)
182025-05-23T03:44:35 *** maflcko <maflcko!~none@107.172.8.183> has joined #bitcoin-core-dev
192025-05-23T03:47:41 *** maflcko <maflcko!~none@107.172.8.183> has quit IRC (Client Quit)
202025-05-23T04:01:02 *** cmirror <cmirror!~cmirror@4.53.92.114> has quit IRC (Remote host closed the connection)
212025-05-23T04:01:32 *** cmirror <cmirror!~cmirror@4.53.92.114> has joined #bitcoin-core-dev
222025-05-23T04:07:02 *** maflcko <maflcko!~none@107.172.8.183> has joined #bitcoin-core-dev
232025-05-23T04:10:54 *** Cory80 <Cory80!~Cory80@user/pasha> has quit IRC (Quit: Client closed)
242025-05-23T04:11:09 *** Cory80 <Cory80!~Cory80@user/pasha> has joined #bitcoin-core-dev
252025-05-23T04:17:51 *** robszarka <robszarka!~szarka@2603:3003:4eac:100:112e:106d:fa3f:4caa> has joined #bitcoin-core-dev
262025-05-23T04:20:59 *** szarka <szarka!~szarka@2603:3003:4eac:100:28aa:caf5:198d:3518> has quit IRC (Ping timeout: 260 seconds)
272025-05-23T04:36:30 <bitcoin-git> [gui-qml] johnny9 opened pull request #459: Disable forms when loading (main...disable-forms) https://github.com/bitcoin-core/gui-qml/pull/459
282025-05-23T04:47:14 *** charlie_capt <charlie_capt!~charlie_c@119.75.194.99> has joined #bitcoin-core-dev
292025-05-23T05:30:22 *** jon_atack <jon_atack!~jonatack@user/jonatack> has quit IRC (Ping timeout: 276 seconds)
302025-05-23T05:57:44 *** charlie_capt <charlie_capt!~charlie_c@119.75.194.99> has quit IRC (Quit: Client closed)
312025-05-23T06:04:13 *** bitdex <bitdex!~bitdex@gateway/tor-sasl/bitdex> has quit IRC (Quit: = "")
322025-05-23T06:09:28 <bitcoin-git> [bitcoin] maflcko closed pull request #32535: rev_32343_wip_nomerge_ci (master...2505-rev_32343_wip_nomerge_ci) https://github.com/bitcoin/bitcoin/pull/32535
332025-05-23T06:11:59 *** jonatack <jonatack!~jonatack@user/jonatack> has joined #bitcoin-core-dev
342025-05-23T06:24:13 *** Christoph_ <Christoph_!~Christoph@host-88-217-174-126.customer.m-online.net> has joined #bitcoin-core-dev
352025-05-23T06:25:22 *** Christoph__ <Christoph__!~Christoph@host-88-217-174-126.customer.m-online.net> has joined #bitcoin-core-dev
362025-05-23T06:28:37 *** Christoph_ <Christoph_!~Christoph@host-88-217-174-126.customer.m-online.net> has quit IRC (Ping timeout: 252 seconds)
372025-05-23T06:47:35 *** jonatack <jonatack!~jonatack@user/jonatack> has quit IRC (Ping timeout: 260 seconds)
382025-05-23T07:03:19 *** maflcko <maflcko!~none@107.172.8.183> has quit IRC (Quit: ZNC 1.8.2+deb2ubuntu0.1 - https://znc.in)
392025-05-23T07:04:05 *** maflcko <maflcko!~none@107.172.8.183> has joined #bitcoin-core-dev
402025-05-23T07:39:30 *** Guyver2 <Guyver2!~Guyver@77-174-98-73.fixed.kpn.net> has joined #bitcoin-core-dev
412025-05-23T07:39:36 *** jonatack <jonatack!~jonatack@user/jonatack> has joined #bitcoin-core-dev
422025-05-23T07:52:03 *** Guest74 <Guest74!~Guest37@109.73.6.202> has joined #bitcoin-core-dev
432025-05-23T07:53:10 *** Guest74 <Guest74!~Guest37@109.73.6.202> has quit IRC (Client Quit)
442025-05-23T08:40:57 *** charlie_capt <charlie_capt!~charlie_c@119.75.194.99> has joined #bitcoin-core-dev
452025-05-23T08:41:57 *** Christoph__ <Christoph__!~Christoph@host-88-217-174-126.customer.m-online.net> has quit IRC (Quit: Christoph__)
462025-05-23T08:45:42 *** charlie_capt <charlie_capt!~charlie_c@119.75.194.99> has quit IRC (Client Quit)
472025-05-23T08:53:41 <TheCharlatan> cfields, mind linking that github comment re cuckoocache locking? Was working on that a couple of days ago, but was also not clear to me what might have been the original intention of externalizing the locks.
482025-05-23T09:00:03 *** charlie_capt <charlie_capt!~charlie_c@119.75.194.99> has joined #bitcoin-core-dev
492025-05-23T09:05:19 *** Christoph_ <Christoph_!~Christoph@host-88-217-174-126.customer.m-online.net> has joined #bitcoin-core-dev
502025-05-23T09:05:52 *** antanst9 <antanst9!~antanst@user/antanst> has quit IRC (Remote host closed the connection)
512025-05-23T09:06:07 <gmaxwell> sipa: on the unlikely hypothetical of bare multisig txouts becoming commercially popular. The obvious solution in that case is that for any output >>256 bits in size it should just be stored in the utxo set as a hash and transactions should have to come with the preimage. ... and I think an example of the answer to problematic tx flux is to just fix the problem.
522025-05-23T09:06:10 *** antanst9 <antanst9!~antanst@user/antanst> has joined #bitcoin-core-dev
532025-05-23T09:07:11 <gmaxwell> (or, consider the sigops limit ... to consensus ban them)
542025-05-23T09:07:15 <gmaxwell> (creating them)
552025-05-23T09:11:48 *** Holz <Holz!~Holz@user/Holz> has quit IRC (Ping timeout: 252 seconds)
562025-05-23T09:29:44 *** Holz <Holz!~Holz@user/Holz> has joined #bitcoin-core-dev
572025-05-23T09:55:53 *** Christoph_ <Christoph_!~Christoph@host-88-217-174-126.customer.m-online.net> has quit IRC (Quit: Christoph_)
582025-05-23T10:00:25 *** Christoph_ <Christoph_!~Christoph@host-88-217-174-126.customer.m-online.net> has joined #bitcoin-core-dev
592025-05-23T10:12:57 *** Guyver2 <Guyver2!~Guyver@77-174-98-73.fixed.kpn.net> has left #bitcoin-core-dev (Closing Window)
602025-05-23T10:53:00 <sipa> gmaxwell: UHS !
612025-05-23T11:01:44 *** jespada <jespada!~jespada@r167-61-220-219.dialup.adsl.anteldata.net.uy> has joined #bitcoin-core-dev
622025-05-23T11:06:13 *** charlie_capt <charlie_capt!~charlie_c@119.75.194.99> has quit IRC (Quit: Client closed)
632025-05-23T11:06:35 *** antanst91 <antanst91!~antanst@user/antanst> has joined #bitcoin-core-dev
642025-05-23T11:07:30 *** antanst9 <antanst9!~antanst@user/antanst> has quit IRC (Ping timeout: 268 seconds)
652025-05-23T11:07:30 *** antanst91 is now known as antanst9
662025-05-23T11:20:22 *** Guest13 <Guest13!~Guest13@125.160.228.214> has joined #bitcoin-core-dev
672025-05-23T11:22:03 *** Guest13 <Guest13!~Guest13@125.160.228.214> has quit IRC (Client Quit)
682025-05-23T11:36:11 *** Christoph_ <Christoph_!~Christoph@host-88-217-174-126.customer.m-online.net> has quit IRC (Quit: Christoph_)
692025-05-23T11:36:33 *** Christoph_ <Christoph_!~Christoph@host-88-217-174-126.customer.m-online.net> has joined #bitcoin-core-dev
702025-05-23T11:45:36 *** Christoph_ <Christoph_!~Christoph@host-88-217-174-126.customer.m-online.net> has quit IRC (Quit: Christoph_)
712025-05-23T12:07:45 *** vasild <vasild!~vd@user/vasild> has quit IRC (Remote host closed the connection)
722025-05-23T12:07:58 *** vasild <vasild!~vd@user/vasild> has joined #bitcoin-core-dev
732025-05-23T12:25:47 *** jespada <jespada!~jespada@r167-61-220-219.dialup.adsl.anteldata.net.uy> has quit IRC (Quit: My Mac has gone to sleep. ZZZzzzâ¦)
742025-05-23T12:27:51 *** jespada <jespada!~jespada@r167-61-220-219.dialup.adsl.anteldata.net.uy> has joined #bitcoin-core-dev
752025-05-23T12:29:14 *** jespada <jespada!~jespada@r167-61-220-219.dialup.adsl.anteldata.net.uy> has quit IRC (Client Quit)
762025-05-23T12:30:21 *** jespada <jespada!~jespada@r167-61-220-219.dialup.adsl.anteldata.net.uy> has joined #bitcoin-core-dev
772025-05-23T12:38:03 *** vasild <vasild!~vd@user/vasild> has quit IRC (Remote host closed the connection)
782025-05-23T12:38:18 *** vasild <vasild!~vd@user/vasild> has joined #bitcoin-core-dev
792025-05-23T12:51:45 <bitcoin-git> [bitcoin] hebasto opened pull request #32601: test: Fix `system_tests/run_command` test (master...250523-run-comand-test) https://github.com/bitcoin/bitcoin/pull/32601
802025-05-23T12:51:56 <bitcoin-git> [bitcoin] hebasto closed pull request #32577: subprocess: Let shell parse command on non-Windows systems (master...250521-subprocess-split) https://github.com/bitcoin/bitcoin/pull/32577
812025-05-23T12:56:05 *** vasild <vasild!~vd@user/vasild> has quit IRC (Remote host closed the connection)
822025-05-23T12:56:16 *** vasild <vasild!~vd@user/vasild> has joined #bitcoin-core-dev
832025-05-23T12:58:58 <instagibbs> gmaxwell think cfields was punting that idea around years ago
842025-05-23T12:59:52 <sipa> yep: https://gnusha.org/pi/bitcoindev/CAApLimjfPKDxmiy_SHjuOKbfm6HumFPjc9EFKvw=3NwZO8JcmQ@mail.gmail.com/
852025-05-23T13:01:32 <instagibbs> ah didnt know it had a name, maybe I heard the pre-pitch irl
862025-05-23T13:01:44 *** saturday- <saturday-!~saturday7@59.167.129.22> has quit IRC (Quit: ZNC 1.9.1 - https://znc.in)
872025-05-23T13:02:09 *** saturday7 <saturday7!~saturday7@59.167.129.22> has joined #bitcoin-core-dev
882025-05-23T13:12:06 *** vasild <vasild!~vd@user/vasild> has quit IRC (Remote host closed the connection)
892025-05-23T13:12:18 *** vasild <vasild!~vd@user/vasild> has joined #bitcoin-core-dev
902025-05-23T13:13:55 *** Earnestly <Earnestly!~earnest@user/earnestly> has quit IRC (Ping timeout: 268 seconds)
912025-05-23T13:14:19 *** Earnestly <Earnestly!~earnest@user/earnestly> has joined #bitcoin-core-dev
922025-05-23T13:15:31 *** jon_atack <jon_atack!~jonatack@user/jonatack> has joined #bitcoin-core-dev
932025-05-23T13:16:51 *** jonatack <jonatack!~jonatack@user/jonatack> has quit IRC (Ping timeout: 244 seconds)
942025-05-23T14:00:00 *** bugs_ <bugs_!~bugs@user/bugs/x-5128603> has joined #bitcoin-core-dev
952025-05-23T14:15:01 *** jespada <jespada!~jespada@r167-61-220-219.dialup.adsl.anteldata.net.uy> has quit IRC (Ping timeout: 252 seconds)
962025-05-23T14:15:19 *** jamesob443688173 <jamesob443688173!~jamesob@pool-108-44-244-6.clppva.fios.verizon.net> has joined #bitcoin-core-dev
972025-05-23T14:15:19 *** jamesob156659 <jamesob156659!~jamesob@pool-108-44-244-6.clppva.fios.verizon.net> has joined #bitcoin-core-dev
982025-05-23T14:16:23 *** Guest39 <Guest39!~Guest39@67.159.25.6> has joined #bitcoin-core-dev
992025-05-23T14:18:03 *** jespada <jespada!~jespada@r167-61-145-158.dialup.adsl.anteldata.net.uy> has joined #bitcoin-core-dev
1002025-05-23T14:19:55 *** Guest39 <Guest39!~Guest39@67.159.25.6> has quit IRC (Client Quit)
1012025-05-23T14:20:47 *** kevkevin <kevkevin!~kevkevin@209.242.39.30> has joined #bitcoin-core-dev
1022025-05-23T15:01:26 <bitcoin-git> [bitcoin] marcofleon opened pull request #32602: fuzz: Add target for coins database (master...2025/05/coins-view-db-fuzztest) https://github.com/bitcoin/bitcoin/pull/32602
1032025-05-23T15:01:42 *** bugs_ <bugs_!~bugs@user/bugs/x-5128603> has quit IRC (Remote host closed the connection)
1042025-05-23T15:14:34 <gmaxwell> I stumbled into this somewhat old PR https://github.com/bitcoin/bitcoin/issues/28272 I think it's a moderately severe privacy problem. Consider a wallet in blocksonly mode. An attacker can race to send it an unsolicited compact block to determine what transactions the node sent. There is a straightforward fix: drop or treat as header messages any compact block where you hadn't asked the peer
1052025-05-23T15:14:40 <gmaxwell> for it.
1062025-05-23T15:15:44 <gmaxwell> (and blocksonly nodes won't do so)
1072025-05-23T15:17:12 <gmaxwell> that behavior avoids another kind of potential abuse where someone spams the network with unsolicited corrupted compact blocks to gum operations (fortunately that attack would not be so effective) or an attack where they mass broadcast faithful compact blocks to speed up their own propagation (more effective, but less harmful).
1082025-05-23T15:19:07 <bitcoin-git> [bitcoin] rkrux opened pull request #32603: wallet, rpc: clarify wallet version in getwalletinfo help (master...wallet-version) https://github.com/bitcoin/bitcoin/pull/32603
1092025-05-23T15:19:39 <gmaxwell> (or perhaps ideally disconnect the peer, unless they had recently been HB-- simply because treating it as a header might gum block propagation a little given that we already can tell the peer is violating the protocol)
1102025-05-23T15:37:18 *** dzxzg <dzxzg!~dzxzg@user/dzxzg> has joined #bitcoin-core-dev
1112025-05-23T16:16:21 <lightlike> gmaxwell: doesn't the fact that we are in blocksonly mode, and still sent out txns (which would have need to be done directly via rpc) mean that all expectations for privacy are already abandoned anyway?
1122025-05-23T16:17:21 <gmaxwell> lightlike: hm? you can run a wallet in blocksonly mode, no rpc required AFAIK.
1132025-05-23T16:17:38 <gmaxwell> lightlike: you certantly have way less private since there is no cover for anyone who saw your announcement.
1142025-05-23T16:18:12 <lightlike> -blocksonly "Disables automatic broadcast and rebroadcast of transactions"
1152025-05-23T16:18:44 <lightlike> ... unless the source peer has the 'forcerelay' permission
1162025-05-23T16:18:54 <gmaxwell> or you've set walletbroadcast=1 ?
1172025-05-23T16:21:51 <gmaxwell> (yes)
1182025-05-23T16:21:57 *** spynxic <spynxic!~spynxic@spynxic.powered.by.lunarbnc.net> has quit IRC (Ping timeout: 272 seconds)
1192025-05-23T16:22:25 <lightlike> yes, I guess you can overwrite it. but my point is if you send out txns when in blocksonly mode (whatever way) you already told all your peers that they are yours, so no one needs to perform an elaborate compact block attack on you
1202025-05-23T16:22:46 *** spynxic <spynxic!~spynxic@spynxic.powered.by.lunarbnc.net> has joined #bitcoin-core-dev
1212025-05-23T16:25:39 <gmaxwell> lightlike: Good point, I had been thinking that the non-broadcast txn was still in your mempool just not announced. Actually checking the code I see that that isn't so, if broadcast is off it's not even mempooled.
1222025-05-23T16:27:15 <gmaxwell> lightlike: thanks!
1232025-05-23T16:27:24 <lightlike> gmaxwell: even if it was mempooled, how would attackers know what txid to probe for? they'd have to have learnt about the tx some other way i guess?
1242025-05-23T16:28:30 <gmaxwell> lightlike: they don't even have to probe for it if it's mined, just offer you the block and learn which txn you *don't* request. :P but also on that general point, for leak attacks you can just guess and keep trying.
1252025-05-23T16:28:48 <gmaxwell> (I mean guess among txn you know of via some other means, indeed)
1262025-05-23T16:29:42 <gmaxwell> the annoying thing about information leaks is that the attacker can just keep trying and eventually the evidence becomes overwhelming, unless you're like .. only transacting once a year.
1272025-05-23T16:30:32 <gmaxwell> and like, someone doesn't need total certanty before they decide you're worth taking a wrench to. :P
1282025-05-23T16:31:21 *** bugs_ <bugs_!~bugs@user/bugs/x-5128603> has joined #bitcoin-core-dev
1292025-05-23T16:31:22 <gmaxwell> but you convinced me that there is no big additional concern here. (I mean, I still think unsolicited unexpected messages need to be dropped, but it's not a big privacy issue)
1302025-05-23T16:33:19 <lightlike> sorry, I feel like I'm missing something important. How did the tx that I never announced (but put into my mempool) end up in a block? How does anyone but me know its txid / on what basis do you probe?
1312025-05-23T16:34:30 <gmaxwell> lightlike: because you announced it seperately. This is a thing some people do-- by submitting it using wumpus python tool over tor, or using one of the web submission APIs over tor.
1322025-05-23T16:34:53 <gmaxwell> but I read the code(tm) just now and see that it doesn't appear to be mempooled.
1332025-05-23T16:35:00 <lightlike> gmaxwell: ok, gotcha. yes, in that case I'm vulnerale, agreed.
1342025-05-23T16:35:14 <gmaxwell> I think no? just because it won't be in your mempool.
1352025-05-23T16:35:51 <gmaxwell> (but it was my (mis)understanding until a few minutes ago that it would be mempolled, probably primed by reading the issue)
1362025-05-23T16:36:12 <lightlike> right, okay.
1372025-05-23T16:38:51 <gmaxwell> I think in general private wallet use is an important area, since just using a wallet privately is a big reason to use bitcoin core. Essentially all other wallet approaches (except perhaps obscure ones) end up identifying you to third parties even when you're not sending a txn. Best you can do is use them over tor which has pretty significant limitations for long lived usage.
1382025-05-23T16:42:12 <bitcoin-git> [gui-qml] hebasto pushed 7 commits to main: https://github.com/bitcoin-core/gui-qml/compare/b411e5894145...fa34a743abc3
1392025-05-23T16:42:13 <bitcoin-git> gui-qml/main ed5f034 johnny9: qml: Add initialized property to WalletQmlController
1402025-05-23T16:42:13 <bitcoin-git> gui-qml/main bad0648 johnny9: qml: Fix walletqmlmodel.cpp include order
1412025-05-23T16:42:13 <bitcoin-git> gui-qml/main 6bbd72d johnny9: qml: Introduce Skeleton.qml
1422025-05-23T16:42:14 <bitcoin-git> [gui-qml] hebasto merged pull request #455: Add Skeleton loading animation to the Wallet selector (main...skeleton-loading) https://github.com/bitcoin-core/gui-qml/pull/455
1432025-05-23T16:47:09 <bitcoin-git> [gui-qml] hebasto pushed 3 commits to main: https://github.com/bitcoin-core/gui-qml/compare/fa34a743abc3...1c7e20a3edec
1442025-05-23T16:47:09 <bitcoin-git> gui-qml/main 3a29670 johnny9: qml: Add initialized property to WalletQmlController
1452025-05-23T16:47:10 <bitcoin-git> gui-qml/main 1ba83b4 johnny9: qml: Disable Send/Receive forms when loading
1462025-05-23T16:47:10 <bitcoin-git> gui-qml/main 1c7e20a merge-script: Merge bitcoin-core/gui-qml#459: Disable forms when loading
1472025-05-23T16:47:10 <bitcoin-git> [gui-qml] hebasto merged pull request #459: Disable forms when loading (main...disable-forms) https://github.com/bitcoin-core/gui-qml/pull/459
1482025-05-23T16:47:38 *** bitdex <bitdex!~bitdex@gateway/tor-sasl/bitdex> has joined #bitcoin-core-dev
1492025-05-23T16:47:53 *** robszarka <robszarka!~szarka@2603:3003:4eac:100:112e:106d:fa3f:4caa> has quit IRC (Quit: Leaving)
1502025-05-23T16:48:15 *** szarka <szarka!~szarka@2603:3003:4eac:100:112e:106d:fa3f:4caa> has joined #bitcoin-core-dev
1512025-05-23T16:51:08 <bitcoin-git> [gui-qml] hebasto pushed 2 commits to main: https://github.com/bitcoin-core/gui-qml/compare/1c7e20a3edec...42f58adabcda
1522025-05-23T16:51:10 <bitcoin-git> [gui-qml] hebasto merged pull request #458: Add missing cstdint declarations (main...5-22-2025-cstdint-qml) https://github.com/bitcoin-core/gui-qml/pull/458
1532025-05-23T16:52:46 *** Guest80 <Guest80!~Guest80@103.158.171.237> has joined #bitcoin-core-dev
1542025-05-23T16:53:56 *** Guest80 <Guest80!~Guest80@103.158.171.237> has quit IRC (Client Quit)
1552025-05-23T16:54:09 *** Guest80 <Guest80!~Guest80@103.158.171.237> has joined #bitcoin-core-dev
1562025-05-23T16:55:06 *** Christoph_ <Christoph_!~Christoph@2a02:810d:1399:b700:f143:be3c:bf7a:2707> has joined #bitcoin-core-dev
1572025-05-23T16:55:53 *** Guest80 <Guest80!~Guest80@103.158.171.237> has quit IRC (Client Quit)
1582025-05-23T16:56:05 *** Guest80 <Guest80!~Guest80@103.158.171.237> has joined #bitcoin-core-dev
1592025-05-23T17:02:06 *** Christoph_ <Christoph_!~Christoph@2a02:810d:1399:b700:f143:be3c:bf7a:2707> has quit IRC (Quit: Christoph_)
1602025-05-23T17:02:27 *** Christoph_ <Christoph_!~Christoph@2a02:810d:1399:b700:f143:be3c:bf7a:2707> has joined #bitcoin-core-dev
1612025-05-23T17:04:04 *** Guest80 <Guest80!~Guest80@103.158.171.237> has quit IRC (Quit: Client closed)
1622025-05-23T17:06:39 *** Cory80 <Cory80!~Cory80@user/pasha> has quit IRC (Quit: Client closed)
1632025-05-23T17:06:56 *** Cory80 <Cory80!~Cory80@user/pasha> has joined #bitcoin-core-dev
1642025-05-23T17:06:57 *** Christoph_ <Christoph_!~Christoph@2a02:810d:1399:b700:f143:be3c:bf7a:2707> has quit IRC (Ping timeout: 248 seconds)
1652025-05-23T17:19:46 <bitcoin-git> [bitcoin] hebasto reopened pull request #32577: subprocess: Let shell parse command on non-Windows systems (master...250521-subprocess-split) https://github.com/bitcoin/bitcoin/pull/32577
1662025-05-23T17:36:16 *** eugenesiegel <eugenesiegel!~eugenesie@user/eugenesiegel> has joined #bitcoin-core-dev
1672025-05-23T17:50:36 *** Cory80 <Cory80!~Cory80@user/pasha> has quit IRC (Quit: Client closed)
1682025-05-23T17:50:55 *** Cory80 <Cory80!~Cory80@user/pasha> has joined #bitcoin-core-dev
1692025-05-23T17:56:23 *** jonatack <jonatack!~jonatack@user/jonatack> has joined #bitcoin-core-dev
1702025-05-23T17:58:41 *** jon_atack <jon_atack!~jonatack@user/jonatack> has quit IRC (Ping timeout: 252 seconds)
1712025-05-23T18:12:23 <bitcoin-git> [bitcoin] mzumsande closed pull request #31714: validation: Do less work in NeedsRedownload (master...202501_simpler_segwit_check) https://github.com/bitcoin/bitcoin/pull/31714
1722025-05-23T18:17:44 *** eugenesiegel <eugenesiegel!~eugenesie@user/eugenesiegel> has quit IRC (Quit: Client closed)
1732025-05-23T18:24:00 *** Cory80 <Cory80!~Cory80@user/pasha> has quit IRC (Quit: Client closed)
1742025-05-23T18:24:18 *** Cory80 <Cory80!~Cory80@user/pasha> has joined #bitcoin-core-dev
1752025-05-23T18:40:51 *** bugs_ <bugs_!~bugs@user/bugs/x-5128603> has quit IRC (Ping timeout: 276 seconds)
1762025-05-23T18:45:24 <dzxzg> wouldn't disallowing unsolicited compact block messages delay block propagation by a round trip?
1772025-05-23T18:47:31 <lightlike> dzxzg: The one's we actually want (from a high-bandwidth peer) wouldn't count as unsolicited and wouldn't be affected.
1782025-05-23T18:52:26 <dzxzg> ah, I see, that makes sense. But, a node would still be if it were unlucky enough to have selected a nosy peer as high bandwidth (doesn't apply to blocksonly since they never mark peers as high bandwidth)
1792025-05-23T18:52:32 <dzxzg> *would still be vulnerable
1802025-05-23T18:58:51 <lightlike> dzxzg: yes, but in the non-blocksonly case the question is vulnerable to what: in general the mempool (all txns older than our last inv to the peer) can also be queried with simple GETDATAs, see my post in #28272
1812025-05-23T18:58:52 <corebot> https://github.com/bitcoin/bitcoin/issues/28272 | compact block fingerprinting · Issue #28272 · bitcoin/bitcoin · GitHub
1822025-05-23T18:59:53 <gmaxwell> dzxzg: lightlike convinced me the leak issue was a nothing burger, though I think it should still drop them to discourage other abusive behavior.
1832025-05-23T19:03:01 <gmaxwell> dzxzg: I'm not sure what the status of random transaction requests are. Previously the relay pool prevented you from doing that generally, and I know there was at least private-security discussion about further restricting it so that someone else being relayed a transaction wouldn't permit you to request it. But there were also some complications around orphan parent fetching.
1842025-05-23T19:12:31 *** mcey_ <mcey_!~emcy@85.255.233.201> has joined #bitcoin-core-dev
1852025-05-23T19:15:12 <sipa> gmaxwell: i think #27675 is probably the latest there (tldr: whenever an INV is sent, you permit the peer to request whatever was in your mempool at the time of the INV)
1862025-05-23T19:15:13 *** jonatack <jonatack!~jonatack@user/jonatack> has quit IRC (Read error: Connection reset by peer)
1872025-05-23T19:15:15 <corebot> https://github.com/bitcoin/bitcoin/issues/27675 | p2p: Drop m_recently_announced_invs bloom filter by ajtowns · Pull Request #27675 · bitcoin/bitcoin · GitHub
1882025-05-23T19:15:27 *** jonatack <jonatack!~jonatack@user/jonatack> has joined #bitcoin-core-dev
1892025-05-23T19:16:07 *** emcy__ <emcy__!~emcy@148.252.132.78> has quit IRC (Ping timeout: 272 seconds)
1902025-05-23T19:19:06 <gmaxwell> sipa: ah, thats pretty good. At least to the extent that when you INV you will have sent ~all the relayable things up to that point (ignoring rate limiting corner cases I guess, and the fact that the peer may not have been connected forever)
1912025-05-23T19:21:55 <gmaxwell> Also means that CB stuff there is an information leak, not the most cosmic since it requires that attacker to have possession of a block header you'd accept.
1922025-05-23T19:24:21 <sipa> gmaxwell: i think prior to that PR, the rule was that only transactions which (a) have been in the mempool for at least some amount of time (like a few minutes) or (b) were recently announced to the peer, were requestable. But the observation of the PR was that the INV ratelimiting is only for saving bandwidth, and isn't a privacy gain, and because of that, allowed dropping the recently-announced
1932025-05-23T19:24:27 <sipa> set
1942025-05-23T19:25:27 <gmaxwell> yeah I think the relay behavior post that PR sounds fine.
1952025-05-23T19:26:57 <gmaxwell> An observation on that issue is that compact blocks can be used to interogate the mempool in varrious ways that bypass that limit. Like you get a new block header and then quickly go tell a peer a made up compact block that has a bunch of short IDs that correspond to txid you want to probe for in their mempool which may not have been relayed out by them at all, and then observe what they
1962025-05-23T19:27:03 <gmaxwell> getblocktxn.
1972025-05-23T19:28:03 <gmaxwell> To close it completely would require replacing compact blocks with something that uses FEC to covey missed txn, as that gives you a high amount of automatic privacy over what you're fetching.
1982025-05-23T19:28:14 <gmaxwell> But it could be reduced by not processing unsolicited compact blocks.
1992025-05-23T19:29:10 <sipa> Or adding a ZKP that the short IDs actually correspond to wtxids whose txids's Merkle root is the one in the header
2002025-05-23T19:29:43 <gmaxwell> yes but I think that's strictly less good than FEC fill in data.
2012025-05-23T19:31:04 <gmaxwell> sipa: or just sending the wtxids as your 'compact block' then it's self proving but the communications performance is poor.
2022025-05-23T19:31:59 <sipa> wtxids + coinbase merkle path
2032025-05-23T19:32:16 <sipa> but, indeed
2042025-05-23T19:32:27 <gmaxwell> I think at one point there was discussion of constructing the CB nonce in such a way that the block could have a commitment to the short-ids, but I think the cost of the reveal on that proof makes it kinda unattractive.
2052025-05-23T19:32:39 *** MrHAPPY <MrHAPPY!~pxq@user/MrHAPPY> has joined #bitcoin-core-dev
2062025-05-23T19:32:59 <gmaxwell> and then we also decided that having diverse CB nonces was just really nice because any collision would at least be a localized transmission fault.
2072025-05-23T19:33:54 <gmaxwell> (which made it easier to justify having pretty short shortids)
2082025-05-23T19:34:40 <sipa> Yep.
2092025-05-23T19:35:04 <bitcoin-git> [bitcoin] achow101 pushed 4 commits to master: https://github.com/bitcoin/bitcoin/compare/2df824f4e62b...638a4c0bd8b5
2102025-05-23T19:35:05 <bitcoin-git> bitcoin/master db465a5 Sebastian Falbesoner: wallet, rpc: remove obsolete "keypoololdest" result field/code
2112025-05-23T19:35:05 <bitcoin-git> bitcoin/master 7a05f94 Sebastian Falbesoner: rpc: doc: drop descriptor wallet mentions in fast wallet rescan related RP...
2122025-05-23T19:35:05 <bitcoin-git> bitcoin/master e5cbea4 Sebastian Falbesoner: rpc: doc: remove redundant "descriptors" parameter in `createwallet` examp...
2132025-05-23T19:35:07 <bitcoin-git> [bitcoin] achow101 merged pull request #32596: wallet, rpc, doc: various legacy wallet removal cleanups in RPCs (master...2025-wallet-rpc-related_legacy_wallet_cleanups) https://github.com/bitcoin/bitcoin/pull/32596
2142025-05-23T20:10:42 *** jamesob443688173 <jamesob443688173!~jamesob@pool-108-44-244-6.clppva.fios.verizon.net> has quit IRC (Ping timeout: 252 seconds)
2152025-05-23T20:10:42 *** jamesob156659 <jamesob156659!~jamesob@pool-108-44-244-6.clppva.fios.verizon.net> has quit IRC (Ping timeout: 252 seconds)
2162025-05-23T20:18:19 *** jamesob443688173 <jamesob443688173!~jamesob@pool-108-44-244-6.clppva.fios.verizon.net> has joined #bitcoin-core-dev
2172025-05-23T20:18:32 *** jamesob156659 <jamesob156659!~jamesob@pool-108-44-244-6.clppva.fios.verizon.net> has joined #bitcoin-core-dev
2182025-05-23T20:25:39 *** rmatte <rmatte!rmatte@user/rmatte> has joined #bitcoin-core-dev
2192025-05-23T20:48:54 <bitcoin-git> [bitcoin] Crypt-iQ opened pull request #32604: log: Mitigate disk filling attacks by rate limiting LogPrintf, LogInfo, LogWarning, LogError (master...log_ratelimiting_05192025) https://github.com/bitcoin/bitcoin/pull/32604
2202025-05-23T21:58:19 <bitcoin-git> [bitcoin] davidgumberg opened pull request #32606: p2p: Drop unsolicited CMPCTBLOCK from non-HB peer (master...5-23-25-ignore-unsolicited) https://github.com/bitcoin/bitcoin/pull/32606
2212025-05-23T22:30:21 <bitcoin-git> [bitcoin] benthecarman opened pull request #32607: rpc: Note in fundrawtransaction doc, fee rate is for package (master...fundawtx-pkg-doc) https://github.com/bitcoin/bitcoin/pull/32607
2222025-05-23T23:05:40 *** conman <conman!~con@180-150-21-3.b49615.mel.static.aussiebb.net> has quit IRC (Quit: Konversation terminated!)
2232025-05-23T23:09:08 *** chengse-yaowan <chengse-yaowan!uid704172@id-704172.uxbridge.irccloud.com> has joined #bitcoin-core-dev
2242025-05-23T23:39:04 *** MrHAPPY <MrHAPPY!~pxq@user/MrHAPPY> has quit IRC ()