12025-06-05T00:00:26 *** bitdex <bitdex!~bitdex@gateway/tor-sasl/bitdex> has quit IRC (Remote host closed the connection)
22025-06-05T00:03:53 *** bitdex <bitdex!~bitdex@gateway/tor-sasl/bitdex> has joined #bitcoin-core-dev
32025-06-05T00:04:50 *** jespada <jespada!~jespada@r179-25-40-226.dialup.adsl.anteldata.net.uy> has quit IRC (Ping timeout: 260 seconds)
42025-06-05T00:29:58 *** adil <adil!~Thunderbi@2402:d000:8134:2f97:122:a523:ff0e:5368> has joined #bitcoin-core-dev
52025-06-05T00:38:28 *** adil <adil!~Thunderbi@2402:d000:8134:2f97:122:a523:ff0e:5368> has quit IRC (Quit: adil)
62025-06-05T00:47:48 *** Earnestly <Earnestly!~earnest@user/earnestly> has quit IRC (Ping timeout: 252 seconds)
72025-06-05T01:02:31 *** dzxzg <dzxzg!~dzxzg@user/dzxzg> has quit IRC (Quit: Konversation terminated!)
82025-06-05T01:35:45 *** zeropoint <zeropoint!~alex@45-28-139-114.lightspeed.sntcca.sbcglobal.net> has quit IRC (Quit: leaving)
92025-06-05T02:04:10 *** bitdex <bitdex!~bitdex@gateway/tor-sasl/bitdex> has quit IRC (Ping timeout: 244 seconds)
102025-06-05T02:06:31 *** bitdex <bitdex!~bitdex@gateway/tor-sasl/bitdex> has joined #bitcoin-core-dev
112025-06-05T02:07:30 *** wafflefrie <wafflefrie!uid478376@id-478376.uxbridge.irccloud.com> has quit IRC (Quit: Connection closed for inactivity)
122025-06-05T02:12:09 *** bitdex <bitdex!~bitdex@gateway/tor-sasl/bitdex> has quit IRC (Read error: Connection reset by peer)
132025-06-05T02:13:01 *** bitdex <bitdex!~bitdex@gateway/tor-sasl/bitdex> has joined #bitcoin-core-dev
142025-06-05T02:31:27 *** Christoph_ <Christoph_!~Christoph@2a02:810d:1399:b700:ecee:1968:d5a3:ef2f> has joined #bitcoin-core-dev
152025-06-05T02:36:01 *** Christoph_ <Christoph_!~Christoph@2a02:810d:1399:b700:ecee:1968:d5a3:ef2f> has quit IRC (Ping timeout: 248 seconds)
162025-06-05T03:42:53 *** robobub <robobub!uid248673@id-248673.uxbridge.irccloud.com> has joined #bitcoin-core-dev
172025-06-05T04:01:01 *** cmirror <cmirror!~cmirror@4.53.92.114> has quit IRC (Remote host closed the connection)
182025-06-05T04:01:32 *** cmirror <cmirror!~cmirror@4.53.92.114> has joined #bitcoin-core-dev
192025-06-05T04:04:11 *** wafflefrie <wafflefrie!uid478376@id-478376.uxbridge.irccloud.com> has joined #bitcoin-core-dev
202025-06-05T04:10:39 *** Randolf <Randolf!~randolf@184.70.10.188> has joined #bitcoin-core-dev
212025-06-05T04:12:10 <bitcoin-git> [gui-qml] johnny9 opened pull request #465: Show "Select Wallet" or "Add Wallet" in the Wallet selector if a wallet isn't loaded (main...no-wallets-loaded) https://github.com/bitcoin-core/gui-qml/pull/465
222025-06-05T04:17:06 *** bitdex <bitdex!~bitdex@gateway/tor-sasl/bitdex> has quit IRC (Quit: = "")
232025-06-05T04:34:58 *** abubakarsadiq <abubakarsadiq!uid602234@id-602234.hampstead.irccloud.com> has quit IRC (Quit: Connection closed for inactivity)
242025-06-05T05:35:58 *** kevkevin <kevkevin!~kevkevin@209.242.39.30> has quit IRC (Remote host closed the connection)
252025-06-05T05:41:05 *** Randolf <Randolf!~randolf@184.70.10.188> has quit IRC (Ping timeout: 248 seconds)
262025-06-05T05:50:02 *** Randolf <Randolf!~randolf@184.70.10.188> has joined #bitcoin-core-dev
272025-06-05T06:00:22 *** Randolf <Randolf!~randolf@184.70.10.188> has quit IRC (Quit: Leaving)
282025-06-05T06:06:27 *** kevkevin <kevkevin!~kevkevin@209.242.39.30> has joined #bitcoin-core-dev
292025-06-05T06:11:01 *** kevkevin <kevkevin!~kevkevin@209.242.39.30> has quit IRC (Ping timeout: 248 seconds)
302025-06-05T06:26:39 *** kevkevin <kevkevin!~kevkevin@209.242.39.30> has joined #bitcoin-core-dev
312025-06-05T06:38:10 *** kevkevin <kevkevin!~kevkevin@209.242.39.30> has quit IRC (Ping timeout: 268 seconds)
322025-06-05T07:05:49 *** kevkevin <kevkevin!~kevkevin@209.242.39.30> has joined #bitcoin-core-dev
332025-06-05T07:20:04 *** kevkevin <kevkevin!~kevkevin@209.242.39.30> has quit IRC (Ping timeout: 252 seconds)
342025-06-05T07:22:18 *** SpellChecker <SpellChecker!~SpellChec@user/SpellChecker> has joined #bitcoin-core-dev
352025-06-05T07:24:34 *** Guyver2 <Guyver2!~Guyver@77-174-98-73.fixed.kpn.net> has joined #bitcoin-core-dev
362025-06-05T07:24:46 *** Guest38 <Guest38!~Guest38@2600:1700:a6c0:13d0:e982:daae:a894:db96> has joined #bitcoin-core-dev
372025-06-05T07:36:58 *** abubakarsadiq <abubakarsadiq!uid602234@id-602234.hampstead.irccloud.com> has joined #bitcoin-core-dev
382025-06-05T07:44:44 <bitcoin-git> [bitcoin] maflcko opened pull request #32680: ci: Rewrite test-each-commit as rust script (master...2506-ci-rust-script) https://github.com/bitcoin/bitcoin/pull/32680
392025-06-05T07:46:00 *** kevkevin <kevkevin!~kevkevin@209.242.39.30> has joined #bitcoin-core-dev
402025-06-05T07:50:30 *** Guest38 <Guest38!~Guest38@2600:1700:a6c0:13d0:e982:daae:a894:db96> has quit IRC (Quit: Client closed)
412025-06-05T08:00:46 <bitcoin-git> [gui-qml] GBKS opened pull request #466: Visual tweaks to the fee selector in the send form (main...feature/fee-selection-visual-tweaks) https://github.com/bitcoin-core/gui-qml/pull/466
422025-06-05T08:02:18 *** kevkevin <kevkevin!~kevkevin@209.242.39.30> has quit IRC (Ping timeout: 252 seconds)
432025-06-05T08:03:49 *** wafflefrie <wafflefrie!uid478376@id-478376.uxbridge.irccloud.com> has quit IRC (Quit: Connection closed for inactivity)
442025-06-05T08:28:33 <bitcoin-git> [bitcoin] fanquake pushed 4 commits to master: https://github.com/bitcoin/bitcoin/compare/f94167512dc9...fd4399cb9c69
452025-06-05T08:28:33 <bitcoin-git> bitcoin/master 56d878c Antoine Poinsot: fuzz: avoid underflow in coins_view target
462025-06-05T08:28:34 <bitcoin-git> bitcoin/master 46e1463 Antoine Poinsot: fuzz: move the coins_view target's body into a standalone function
472025-06-05T08:28:34 <bitcoin-git> bitcoin/master cfc42ae Antoine Poinsot: fuzz: add a target for the coins database
482025-06-05T08:28:35 <bitcoin-git> [bitcoin] fanquake merged pull request #32602: fuzz: Add target for coins database (master...2025/05/coins-view-db-fuzztest) https://github.com/bitcoin/bitcoin/pull/32602
492025-06-05T08:38:47 <bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/fd4399cb9c69...6a2ff6790929
502025-06-05T08:38:47 <bitcoin-git> bitcoin/master 4ce5349 ismaelsadeeq: doc: update tor docs to use bitcoind binary from path
512025-06-05T08:38:47 <bitcoin-git> bitcoin/master 6a2ff67 merge-script: Merge bitcoin/bitcoin#32679: doc: update tor docs to use bitcoind binary f...
522025-06-05T08:38:49 <bitcoin-git> [bitcoin] fanquake merged pull request #32679: doc: update tor docs to use bitcoind binary from path (master...06-2025-fix-tor-docs) https://github.com/bitcoin/bitcoin/pull/32679
532025-06-05T08:45:28 *** kevkevin <kevkevin!~kevkevin@209.242.39.30> has joined #bitcoin-core-dev
542025-06-05T08:46:11 *** ioannis <ioannis!~ioannis@94.204.178.143> has joined #bitcoin-core-dev
552025-06-05T08:46:42 *** ioannis <ioannis!~ioannis@94.204.178.143> has quit IRC (Client Quit)
562025-06-05T08:54:17 <bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/6a2ff6790929...ae024137bda9
572025-06-05T08:54:18 <bitcoin-git> bitcoin/master 9653ebc fanquake: depends: remove support for Windows Qt LTO builds
582025-06-05T08:54:18 <bitcoin-git> bitcoin/master ae02413 merge-script: Merge bitcoin/bitcoin#32496: depends: drop `ltcg` for Windows Qt
592025-06-05T08:54:19 <bitcoin-git> [bitcoin] fanquake merged pull request #32496: depends: drop `ltcg` for Windows Qt (master...depends_qt_ltcg) https://github.com/bitcoin/bitcoin/pull/32496
602025-06-05T09:05:39 *** kevkevin <kevkevin!~kevkevin@209.242.39.30> has quit IRC (Ping timeout: 272 seconds)
612025-06-05T09:40:25 *** kevkevin <kevkevin!~kevkevin@209.242.39.30> has joined #bitcoin-core-dev
622025-06-05T09:58:13 *** kevkevin <kevkevin!~kevkevin@209.242.39.30> has quit IRC (Ping timeout: 272 seconds)
632025-06-05T10:06:51 <bitcoin-git> [bitcoin] Sjors opened pull request #32682: wallet: have external signer use PSBT error code EXTERNAL_SIGNER_NOT_FOUND (master...2025/06/external-signer-error) https://github.com/bitcoin/bitcoin/pull/32682
642025-06-05T10:19:03 <bitcoin-git> [gui-qml] hebasto pushed 2 commits to main: https://github.com/bitcoin-core/gui-qml/compare/989bbe0d106a...7af57088372e
652025-06-05T10:19:04 <bitcoin-git> gui-qml/main b987ae5 johnny9: qml: Add Skeleton loading to Activity
662025-06-05T10:19:04 <bitcoin-git> gui-qml/main 7af5708 merge-script: Merge bitcoin-core/gui-qml#460: Add Skeleton loading to Activity
672025-06-05T10:19:04 <bitcoin-git> [gui-qml] hebasto merged pull request #460: Add Skeleton loading to Activity (main...activity-skeleton) https://github.com/bitcoin-core/gui-qml/pull/460
682025-06-05T10:25:19 *** kevkevin <kevkevin!~kevkevin@209.242.39.30> has joined #bitcoin-core-dev
692025-06-05T10:34:42 *** oneeyedalien <oneeyedalien!~oneeyedal@user/oneeyedalien> has joined #bitcoin-core-dev
702025-06-05T10:38:45 *** oneeyedalien <oneeyedalien!~oneeyedal@user/oneeyedalien> has quit IRC (Client Quit)
712025-06-05T10:41:47 *** kevkevin <kevkevin!~kevkevin@209.242.39.30> has quit IRC (Ping timeout: 252 seconds)
722025-06-05T10:48:17 *** Christoph_ <Christoph_!~Christoph@host-88-217-174-126.customer.m-online.net> has joined #bitcoin-core-dev
732025-06-05T11:02:00 *** jespada <jespada!~jespada@r179-25-40-226.dialup.adsl.anteldata.net.uy> has joined #bitcoin-core-dev
742025-06-05T11:19:10 *** antanst9 <antanst9!~antanst@user/antanst> has quit IRC (Ping timeout: 260 seconds)
752025-06-05T11:24:30 *** kevkevin <kevkevin!~kevkevin@209.242.39.30> has joined #bitcoin-core-dev
762025-06-05T11:32:36 *** Guest0 <Guest0!~Guest0@2001:4c0:3300:ee:c1b5:130:ab15:208e> has joined #bitcoin-core-dev
772025-06-05T11:34:09 *** kevkevin <kevkevin!~kevkevin@209.242.39.30> has quit IRC (Ping timeout: 248 seconds)
782025-06-05T11:34:59 *** Guest0 <Guest0!~Guest0@2001:4c0:3300:ee:c1b5:130:ab15:208e> has quit IRC (Client Quit)
792025-06-05T11:50:38 *** kevkevin <kevkevin!~kevkevin@209.242.39.30> has joined #bitcoin-core-dev
802025-06-05T12:07:35 *** dermoth <dermoth!~dermoth@user/dermoth> has quit IRC (Ping timeout: 252 seconds)
812025-06-05T12:08:42 *** kevkevin <kevkevin!~kevkevin@209.242.39.30> has quit IRC (Ping timeout: 268 seconds)
822025-06-05T12:10:08 *** jespada <jespada!~jespada@r179-25-40-226.dialup.adsl.anteldata.net.uy> has quit IRC (Quit: My Mac has gone to sleep. ZZZzzzâ¦)
832025-06-05T12:11:13 *** jespada <jespada!~jespada@r179-25-40-226.dialup.adsl.anteldata.net.uy> has joined #bitcoin-core-dev
842025-06-05T12:22:00 *** Christoph_ <Christoph_!~Christoph@host-88-217-174-126.customer.m-online.net> has quit IRC (Quit: Christoph_)
852025-06-05T12:22:19 *** Christoph_ <Christoph_!~Christoph@host-88-217-174-126.customer.m-online.net> has joined #bitcoin-core-dev
862025-06-05T12:23:03 *** Christoph_ <Christoph_!~Christoph@host-88-217-174-126.customer.m-online.net> has quit IRC (Client Quit)
872025-06-05T12:31:47 *** kevkevin <kevkevin!~kevkevin@209.242.39.30> has joined #bitcoin-core-dev
882025-06-05T12:32:29 *** mcey_ <mcey_!~emcy@85.255.235.102> has joined #bitcoin-core-dev
892025-06-05T12:33:09 *** dermoth <dermoth!~dermoth@user/dermoth> has joined #bitcoin-core-dev
902025-06-05T12:33:17 *** Christoph_ <Christoph_!~Christoph@host-88-217-174-126.customer.m-online.net> has joined #bitcoin-core-dev
912025-06-05T12:34:22 *** dermoth <dermoth!~dermoth@user/dermoth> has quit IRC (Remote host closed the connection)
922025-06-05T12:35:23 *** emcy__ <emcy__!~emcy@85.255.235.102> has quit IRC (Ping timeout: 244 seconds)
932025-06-05T12:45:01 *** dermoth <dermoth!~dermoth@user/dermoth> has joined #bitcoin-core-dev
942025-06-05T13:27:06 *** adil <adil!~Thunderbi@2402:d000:8134:2f97:122:a523:ff0e:5368> has joined #bitcoin-core-dev
952025-06-05T13:32:08 *** adil <adil!~Thunderbi@2402:d000:8134:2f97:122:a523:ff0e:5368> has quit IRC (Quit: adil)
962025-06-05T13:35:45 *** kevkevin <kevkevin!~kevkevin@209.242.39.30> has quit IRC (Ping timeout: 248 seconds)
972025-06-05T13:36:28 <bitcoin-git> [bitcoin] fanquake pushed 12 commits to 28.x: https://github.com/bitcoin/bitcoin/compare/59c19a541695...7f1da7626923
982025-06-05T13:36:29 <bitcoin-git> bitcoin/28.x 00b401c Ava Chow: guix: Rename unsigned.tar.gz to codesigning.tar.gz
992025-06-05T13:36:29 <bitcoin-git> bitcoin/28.x 9f0ee1c Ava Chow: guix: Rename MacOS binaries to unsigned.tar.gz
1002025-06-05T13:36:29 <bitcoin-git> bitcoin/28.x 2c21db6 Ava Chow: guix: Rename Windows unsigned binaries to unsigned.zip
1012025-06-05T13:36:30 <bitcoin-git> [bitcoin] fanquake merged pull request #32563: [28.x] Backport #31407 (28.x...backport_codesigning) https://github.com/bitcoin/bitcoin/pull/32563
1022025-06-05T13:40:23 <hebasto> sipa: would you be willing to consider enabling GitHub Actions for https://github.com/bitcoin-core/minisketch?
1032025-06-05T13:41:29 <dergoegge> glozow: re https://github.com/bitcoin/bitcoin/pull/31829 why change the orphanage to a multi index and change behavior in the same commit? :sob:
1042025-06-05T13:41:29 <dergoegge> it makes the PR harder to review imo
1052025-06-05T13:47:35 *** antanst9 <antanst9!~antanst@user/antanst> has joined #bitcoin-core-dev
1062025-06-05T13:48:15 *** antanst9 <antanst9!~antanst@user/antanst> has quit IRC (Client Quit)
1072025-06-05T13:48:40 *** antanst9 <antanst9!~antanst@user/antanst> has joined #bitcoin-core-dev
1082025-06-05T13:48:41 <sipa> hebasto: does it work now?
1092025-06-05T13:48:48 <dergoegge> I think ideally it'd be 2 PRs: 1. switch to multi index while leaving the interfaces untouched 2. change behavior
1102025-06-05T13:50:43 <glozow> dergoegge: yeah sad, but if I reimplement the old eviction strategy as a multi index, it needs like twice as many indexes
1112025-06-05T13:51:32 <glozow> you could first review the old version where the new eviction strategy is implemented using the existing data structures if that's more familiar
1122025-06-05T13:52:09 <bitcoin-git> [bitcoin] fanquake opened pull request #32684: [28.x] 28.2rc2 (28.x...28_2_rc2) https://github.com/bitcoin/bitcoin/pull/32684
1132025-06-05T13:52:33 *** Christoph_ <Christoph_!~Christoph@host-88-217-174-126.customer.m-online.net> has quit IRC (Quit: Christoph_)
1142025-06-05T13:53:31 <glozow> I wrote a comment about this
1152025-06-05T13:54:59 <glozow> dergoegge: here is the old PR https://github.com/glozow/bitcoin/commits/2025-05-copy-31829/
1162025-06-05T13:55:05 <sipa> FWIW, we discussed this and my thinking was that separating the impl/behavior change isn't really worth it for review, if the result is a substantial amount of code that would be added just to be deleted immediately after
1172025-06-05T13:55:09 <hebasto> sipa: the "Actions" tab is now available, but it seems not working until a workflow description become part of the default branch :(
1182025-06-05T13:56:02 *** Christoph_ <Christoph_!~Christoph@host-88-217-174-126.customer.m-online.net> has joined #bitcoin-core-dev
1192025-06-05T13:56:34 <sipa> hebasto: i'm perhaps not the right person to help you
1202025-06-05T13:57:21 <hebasto> sipa: thanks for enabling them; I mean it will work when/if https://github.com/bitcoin-core/minisketch/pull/75 is merged
1212025-06-05T13:57:26 <sipa> ah ok
1222025-06-05T13:57:43 <dergoegge> marcofleon was gonna deferentially fuzz the old and new (multi index) version but like this its not possible
1232025-06-05T13:58:01 <glozow> porting the existing eviction strategy would need interfaces <ByWtxid> <ByPeer> <ByExpiry> and a random-access for eviction. Then we'd introduce a sequence number, then delete half of the indexes... it just didn't seem worth it.
1242025-06-05T13:58:08 <glozow> why not?
1252025-06-05T13:58:41 <dergoegge> because the behavior changed
1262025-06-05T13:59:36 <glozow> the behavior is supposed to change though?
1272025-06-05T13:59:47 <marcofleon> I was gonna differential fuzz the refactor only
1282025-06-05T13:59:53 <glozow> wait do you mean the old PR or orphanage on master?
1292025-06-05T14:00:02 <sipa> dergoegge: i think what you'd really want for differential fuzzing is first implement the new behavior without multi-index, then add a multi-index version, then fuzz the difference between the two, and then delete/switch over
1302025-06-05T14:00:13 <dergoegge> current orphange against multi index refactor
1312025-06-05T14:00:30 *** kevkevin <kevkevin!~kevkevin@209.242.39.30> has joined #bitcoin-core-dev
1322025-06-05T14:00:31 <sipa> because otherwise all you're doing is fuzzing an implementation using two data structures of behavior that's going away anyway
1332025-06-05T14:00:34 <glozow> why not fuzz the old version of the PR against the multi index version?
1342025-06-05T14:01:36 <dergoegge> i mean that seems different but probably useful too
1352025-06-05T14:01:39 <marcofleon> old pr vs new pr could work, that makes sense
1362025-06-05T14:03:49 <sipa> i'm not sure that's all that useful, unless it is somehow the case that the old PR is more obviously correctly implements the desired behavior than the new PR
1372025-06-05T14:03:50 <marcofleon> basically differential fuzz the new behavior, one without multi-index and one with
1382025-06-05T14:03:54 <glozow> If we really want this, I can write it. But it's a bunch more code to review that then goes away immediately. I don't think it's meaningful to differentially fuzz against behavior that we know is subpar and want to change
1392025-06-05T14:04:23 <glozow> Like, we are doing this because we know the eviction sucks and want to change it
1402025-06-05T14:04:43 <sipa> the point of such a fuzz test is to increase reviewer confidence by establishing that something more-obviously-correct and something less-obviously-correct are equivalent
1412025-06-05T14:05:42 <sipa> but i don't think that's the case here, the multi-index makes it a lot easier to reason about
1422025-06-05T14:06:02 <glozow> If we want to do 2 stages, we could do the old version of the PR and then the refactor after...?
1432025-06-05T14:06:16 <instagibbs> hmm, I'm not sure I found the non-multi index version of the PR significantly easier to read?
1442025-06-05T14:06:34 <instagibbs> Unless it is just trivially badly done performance wise then swapped out
1452025-06-05T14:06:53 <sipa> instagibbs: that's my point - i think the multi-index one is easier to read, so differential fuzzing with something else isn't really a gain
1462025-06-05T14:07:06 <dergoegge> glozow: right that makes sense, I wasn't aware it'd be much more code
1472025-06-05T14:07:07 <dergoegge> I was under the impression that the multi index suggestion came up in the context of reviewing the behavior change (i.e. it'd be easier if it was a multi index)
1482025-06-05T14:07:07 <dergoegge> Therefore to me it seemed useful to first make sure the switch to multi-index was correct
1492025-06-05T14:07:12 <instagibbs> sipa ah ok +1
1502025-06-05T14:08:01 <dergoegge> old vs new pr is good, it should be the same thing
1512025-06-05T14:08:29 <sipa> but did anyone fully review the old one?
1522025-06-05T14:08:52 <sipa> if there is no reason to have confidence that the old one was implementing the desired behavior, i don't think i see the point
1532025-06-05T14:09:02 <instagibbs> they're gonna be subtly different too, FIFO eviction vs random from Dosiest peer
1542025-06-05T14:09:05 <instagibbs> for one
1552025-06-05T14:09:25 <sipa> if anything, you'd want a separate test-only even-more-trivial implementation of the exactly desired behavior, and then have a fuzz test that compares the real implementation with that
1562025-06-05T14:09:45 <dergoegge> sipa: right if the fuzzing doesn't turn anything up there is no gain but I think if there is a difference then that at least lets us decide which one is correct/desireable
1572025-06-05T14:09:47 <instagibbs> sipa yeah that was my one possible suggestion, it recalculates everythign in some really dumb wy
1582025-06-05T14:09:53 *** eugenesiegel <eugenesiegel!~eugenesie@user/eugenesiegel> has joined #bitcoin-core-dev
1592025-06-05T14:10:24 <sipa> (this is what txrequest did/does, it also switched implementation and behavior at the same time, but also added a trivial reimplementation and comparison with it)
1602025-06-05T14:10:42 <sipa> but i think the complexity in the implementation in txorphanage is a lot less, so i'm not sure it's worth the effort
1612025-06-05T14:13:29 <sipa> still, i think that's more valuable than a comparison with a more complex, more error-prone, never deployed, only partially reviewed, older implementation of the same thing
1622025-06-05T14:13:31 <instagibbs> fwiw the introduced fuzz targets didn't have to change much, at least the "one honest package" one didn't
1632025-06-05T14:17:35 <marcofleon> txorphan_protected you mean?
1642025-06-05T14:17:43 <instagibbs> sounds right
1652025-06-05T14:27:58 <dergoegge> instagibbs: ok if we know there are subtle differences already, then there truly is no point
1662025-06-05T14:29:20 <instagibbs> whispering more fuzz harness suggestions to marcofleon
1672025-06-05T14:35:03 *** jespada <jespada!~jespada@r179-25-40-226.dialup.adsl.anteldata.net.uy> has quit IRC (Quit: My Mac has gone to sleep. ZZZzzzâ¦)
1682025-06-05T14:37:30 *** jespada <jespada!~jespada@r179-25-40-226.dialup.adsl.anteldata.net.uy> has joined #bitcoin-core-dev
1692025-06-05T14:39:42 *** szarka <szarka!~szarka@2603:3003:4eac:100:1caf:9753:ca8c:3cbd> has quit IRC (Quit: Leaving)
1702025-06-05T14:45:43 *** certiorari <certiorari!~certiorar@94-255-242-247.cust.bredband2.com> has joined #bitcoin-core-dev
1712025-06-05T15:14:03 *** Christoph_ <Christoph_!~Christoph@host-88-217-174-126.customer.m-online.net> has quit IRC (Quit: Christoph_)
1722025-06-05T15:49:21 *** szarka <szarka!~szarka@2603:3003:4eac:100:ecad:ad8:9197:d6ee> has joined #bitcoin-core-dev
1732025-06-05T15:50:05 <bitcoin-git> [qa-assets] marcofleon opened pull request #226: add coins_view_db inputs (main...coins-view-db-inputs) https://github.com/bitcoin-core/qa-assets/pull/226
1742025-06-05T15:54:20 *** rkrux <rkrux!~rkrux@user/rkrux> has joined #bitcoin-core-dev
1752025-06-05T15:56:43 *** rkrux <rkrux!~rkrux@user/rkrux> has quit IRC (Client Quit)
1762025-06-05T15:57:28 *** Emc99 <Emc99!~Emc99@212.129.72.114> has joined #bitcoin-core-dev
1772025-06-05T16:00:53 <achow101> #startmeeting
1782025-06-05T16:00:53 <corebot> achow101: Meeting started at 2025-06-05T16:00+0000
1792025-06-05T16:00:54 <corebot> achow101: Current chairs: achow101
1802025-06-05T16:00:55 <corebot> achow101: Useful commands: #action #info #idea #link #topic #motion #vote #close #endmeeting
1812025-06-05T16:00:56 <corebot> achow101: See also: https://hcoop-meetbot.readthedocs.io/en/stable/
1822025-06-05T16:00:57 <corebot> achow101: Participants should now identify themselves with '#here' or with an alias like '#here FirstLast'
1832025-06-05T16:01:03 <jonatack> hi
1842025-06-05T16:01:04 <hodlinator> hi
1852025-06-05T16:01:05 <TheCharlatan> hi
1862025-06-05T16:01:06 <eugenesiegel> hi
1872025-06-05T16:01:06 <fjahr> hi
1882025-06-05T16:01:07 <lightlike> Hi
1892025-06-05T16:01:09 <achow101> #bitcoin-core-dev Meeting: abubakarsadiq achow101 _aj_ ajonas b10c brunoerg cfields darosior dergoegge fanquake fjahr furszy gleb glozow hebasto hodlinator instagibbs jarolrod jonatack josibake kanzure laanwj LarryRuane lightlike luke-jr maflcko marcofleon maxedw Murch pinheadmz provoostenator ryanofsky sdaftuar S3RK stickies-v sipa sr_gi tdb3 theStack TheCharlatan vasild willcl-ark
1902025-06-05T16:01:15 <hebasto> hi
1912025-06-05T16:01:15 <cfields> hi
1922025-06-05T16:01:15 <stickies-v> hi
1932025-06-05T16:01:34 *** dzxzg <dzxzg!~dzxzg@user/dzxzg> has joined #bitcoin-core-dev
1942025-06-05T16:01:35 <achow101> There are no preproposed meeting topics this week. Any last minute ones to add?
1952025-06-05T16:01:39 <instagibbs> hi
1962025-06-05T16:01:41 <dzxzg> hi
1972025-06-05T16:01:54 <Murch[m]> Hi
1982025-06-05T16:02:11 <marcofleon> hi
1992025-06-05T16:02:11 *** rkrux <rkrux!~rkrux@user/rkrux> has joined #bitcoin-core-dev
2002025-06-05T16:02:14 <rkrux> hi
2012025-06-05T16:02:23 <brunoerg_> hi
2022025-06-05T16:02:26 <achow101> #topic Kernel WG Update (TheCharlatan)
2032025-06-05T16:02:33 *** neha <neha!~neha@gromit-6.media.mit.edu> has joined #bitcoin-core-dev
2042025-06-05T16:02:38 <TheCharlatan> looking for review on #32317
2052025-06-05T16:02:41 <corebot> https://github.com/bitcoin/bitcoin/issues/32317 | kernel: Separate UTXO set access from validation functions by TheCharlatan · Pull Request #32317 · bitcoin/bitcoin · GitHub
2062025-06-05T16:03:10 <sipa> hi
2072025-06-05T16:03:19 <TheCharlatan> other than that, been working on the block tree storage some more. that's all :)
2082025-06-05T16:03:39 <achow101> #topic Cluster Mempool WG Update (sdaftuar, sipa)
2092025-06-05T16:03:39 <johnny9dev> hi
2102025-06-05T16:03:42 *** rkrux <rkrux!~rkrux@user/rkrux> has quit IRC (Client Quit)
2112025-06-05T16:04:22 <glozow> hi
2122025-06-05T16:04:38 <sipa> not much progress since last week
2132025-06-05T16:05:01 <sipa> we had a very well attended review club about a related PR, #30605
2142025-06-05T16:05:03 <corebot> https://github.com/bitcoin/bitcoin/issues/30605 | Cluster linearization: separate tests from tests-of-tests by sipa · Pull Request #30605 · bitcoin/bitcoin · GitHub
2152025-06-05T16:05:08 <sipa> so well attended that it's going to be repeated
2162025-06-05T16:05:34 <marcofleon> i'm hoping it's not as crowded as last one was
2172025-06-05T16:05:47 <instagibbs> #31553 (still the thing to review)
2182025-06-05T16:05:50 <corebot> https://github.com/bitcoin/bitcoin/issues/31553 | cluster mempool: add TxGraph reorg functionality by sipa · Pull Request #31553 · bitcoin/bitcoin · GitHub
2192025-06-05T16:05:56 <sipa> indeed!
2202025-06-05T16:06:10 <sipa> also, some more work on comparing benchmarks for the new algorithm on multiple platforms
2212025-06-05T16:06:21 <sipa> if you'd like to help, see https://github.com/bitcoin/bitcoin/pull/32545#issuecomment-2928370752
2222025-06-05T16:06:35 <sipa> also pretty graphs
2232025-06-05T16:06:57 <sipa> that's it for me, i think
2242025-06-05T16:07:20 <achow101> #topic MuSig2 WG Update (achow101, rkrux)
2252025-06-05T16:07:25 <achow101> #31244 continues to get review, and is still the PR to review.
2262025-06-05T16:07:28 <corebot> https://github.com/bitcoin/bitcoin/issues/31244 | descriptors: MuSig2 by achow101 · Pull Request #31244 · bitcoin/bitcoin · GitHub
2272025-06-05T16:07:31 <achow101> A reviewer pointed out that the PR did not implement the restriction specified in BIP 390 that musig() descriptors cannot contain duplicate participants. When I started implementing it, I realized that this restriction is a bit more complicated than I had thought it would be, so I have proposed to the mailing list to drop that.
2282025-06-05T16:07:45 <achow101> I forsee some more BIP work will need to be done soon(tm)
2292025-06-05T16:08:18 <achow101> #topic orphan resolution WG Update (glozow)
2302025-06-05T16:08:45 <glozow> #31829 is up for review, thanks people who have taken a look
2312025-06-05T16:08:48 <corebot> https://github.com/bitcoin/bitcoin/issues/31829 | p2p: improve TxOrphanage denial of service bounds by glozow · Pull Request #31829 · bitcoin/bitcoin · GitHub
2322025-06-05T16:09:33 <glozow> I'm open to splitting it, but don't see a good way to do so. lmk if people have ideas
2332025-06-05T16:11:02 <glozow> Maybe we could do the prep commits in a separate PR? idk
2342025-06-05T16:11:11 <glozow> that's it from me
2352025-06-05T16:11:32 <achow101> #topic QML GUI WG Update (jarolrod, johnny9dev)
2362025-06-05T16:11:41 <johnny9dev> A lot of QML work getting completed and PRs opened.
2372025-06-05T16:11:42 <johnny9dev> Addtional init loading animations were merged in bitcoin-core/gui-qml#460
2382025-06-05T16:11:42 <johnny9dev> Standard fee selection control was added to Send to set very basic (low/default/high) block-based fees. This has been merged bitcoin-core/gui-qml#461
2392025-06-05T16:11:42 <johnny9dev> Some cleanup to our layouts are being done by goqusan bitcoin-core/gui-qml#463. He's been working through what we have and fixing up messy anchors and layouts and his reviews have helped give clarity on getting the layouts where they need to be
2402025-06-05T16:11:42 <johnny9dev> Multiple Recipients in the Send form has been PR'd and close to being merged bitcoin-core/gui-qml#450
2412025-06-05T16:11:43 <johnny9dev> First set of form input validation for Send has been PR'd. This will also be used for payment requests. bitcoin-core/gui-qml#462
2422025-06-05T16:11:44 <corebot> https://github.com/bitcoin-core/gui-qml/issues/460 | Add Skeleton loading to Activity by johnny9 · Pull Request #460 · bitcoin-core/gui-qml · GitHub
2432025-06-05T16:11:44 <johnny9dev> RequestPayment page has finally been hooked up to our wallet model to generate and commit actual payment requests and addresses. bitcoin-core/gui-qml#464
2442025-06-05T16:11:45 <corebot> https://github.com/bitcoin-core/gui-qml/issues/461 | Introduce standard fee selection to Send by johnny9 · Pull Request #461 · bitcoin-core/gui-qml · GitHub
2452025-06-05T16:11:46 <johnny9dev> The case where no wallet is actually loaded has been PRd at bitcoin-core/gui-qml#465
2462025-06-05T16:11:46 <corebot> https://github.com/bitcoin-core/gui-qml/issues/463 | Fix layouts 1/n by goqusan · Pull Request #463 · bitcoin-core/gui-qml · GitHub
2472025-06-05T16:11:47 <corebot> https://github.com/bitcoin-core/gui-qml/issues/450 | Add Multiple Recipients option to the Send form by johnny9 · Pull Request #450 · bitcoin-core/gui-qml · GitHub
2482025-06-05T16:11:49 <corebot> https://github.com/bitcoin-core/gui-qml/issues/462 | Add validation to the Send form (address and amount) by johnny9 · Pull Request #462 · bitcoin-core/gui-qml · GitHub
2492025-06-05T16:11:50 <corebot> https://github.com/bitcoin-core/gui-qml/issues/464 | Connect Receive page to WalletQmlModel and Cleanup Layouts by johnny9 · Pull Request #464 · bitcoin-core/gui-qml · GitHub
2502025-06-05T16:11:51 <corebot> https://github.com/bitcoin-core/gui-qml/issues/465 | Show "Select Wallet" or "Add Wallet" in the Wallet selector if a wallet isn't loaded by johnny9 · Pull Request #465 · bitcoin-core/gui-qml · GitHub
2512025-06-05T16:12:02 <johnny9dev> Momentum is really starting to pick up which is really encouraging
2522025-06-05T16:12:35 <sipa> cool
2532025-06-05T16:12:37 <fanquake> Have we rebased onto CMake / Qt 6 now?
2542025-06-05T16:12:41 <johnny9dev> One issue I'm having and need some help with is related to managing issues on the repo itself. I'm unable to change state on them myself and its slowing us down a bit
2552025-06-05T16:13:18 <johnny9dev> I plan on starting build/depends work in a couple of weeks. It will likely start in july
2562025-06-05T16:13:21 <achow101> johnny9dev: we can give you triage permissions for that
2572025-06-05T16:14:14 <johnny9dev> by build/depends I mean that I will be looking at the best way to update to the latest systems and check on how to properly separate concerns with this project
2582025-06-05T16:14:18 <jarolrod> pinheadmz: should have an update on the sync
2592025-06-05T16:14:41 <sipa> he's OOO today
2602025-06-05T16:14:48 *** jespada <jespada!~jespada@r179-25-40-226.dialup.adsl.anteldata.net.uy> has quit IRC (Quit: My Mac has gone to sleep. ZZZzzzâ¦)
2612025-06-05T16:14:50 <jarolrod> ð´ð´ð´
2622025-06-05T16:15:31 <johnny9dev> triage permissions would help a lot. thank you
2632025-06-05T16:15:42 <johnny9dev> thats all i have for this week
2642025-06-05T16:16:06 <achow101> #topic Script Validation WG Update (fjahr)
2652025-06-05T16:19:29 <achow101> perhaps fjahr is not here
2662025-06-05T16:19:35 <achow101> Any other topics to discuss this week?
2672025-06-05T16:19:41 <fjahr> sorry, i had connection issues
2682025-06-05T16:19:46 <fjahr> Since I last reported here in batch validation (#29491) I have addressed some comments and the latest benchmarks look very promising. Also added some unit tests. I hope I can finally fix the taproot test soon and take it out of draft status afterwards.
2692025-06-05T16:19:49 <corebot> https://github.com/bitcoin/bitcoin/issues/29491 | [EXPERIMENTAL] Schnorr batch verification for blocks by fjahr · Pull Request #29491 · bitcoin/bitcoin · GitHub
2702025-06-05T16:19:58 <fjahr> Though maybe not, itâs still blocked by the secp PR. Also hoping for that to get an update soon.
2712025-06-05T16:20:03 <fjahr> Thatâs it.
2722025-06-05T16:20:15 <achow101> Any other topics?
2732025-06-05T16:22:21 <achow101> #endmeeting
2742025-06-05T16:22:21 <corebot> achow101: Meeting ended at 2025-06-05T16:22+0000
2752025-06-05T16:22:22 <corebot> achow101: Raw log: https://achow101.com/ircmeetings/2025/bitcoin-core-dev.2025-06-05_16_00.log.json
2762025-06-05T16:22:23 <corebot> achow101: Formatted log: https://achow101.com/ircmeetings/2025/bitcoin-core-dev.2025-06-05_16_00.log.html
2772025-06-05T16:22:24 <corebot> achow101: Minutes: https://achow101.com/ircmeetings/2025/bitcoin-core-dev.2025-06-05_16_00.html
2782025-06-05T16:22:30 *** Emc99 <Emc99!~Emc99@212.129.72.114> has quit IRC (Quit: Client closed)
2792025-06-05T16:24:16 *** TheRec <TheRec!~toto@user/therec> has quit IRC (Ping timeout: 244 seconds)
2802025-06-05T16:25:37 *** TheRec <TheRec!~toto@84-75-225-47.dclient.hispeed.ch> has joined #bitcoin-core-dev
2812025-06-05T16:27:32 *** neha <neha!~neha@gromit-6.media.mit.edu> has quit IRC (Quit: Client closed)
2822025-06-05T16:27:52 *** eugenesiegel <eugenesiegel!~eugenesie@user/eugenesiegel> has quit IRC (Quit: Client closed)
2832025-06-05T16:56:46 *** jon_atack <jon_atack!~jonatack@user/jonatack> has joined #bitcoin-core-dev
2842025-06-05T16:59:46 *** jonatack <jonatack!~jonatack@user/jonatack> has quit IRC (Ping timeout: 252 seconds)
2852025-06-05T17:00:07 *** dzxzg <dzxzg!~dzxzg@user/dzxzg> has quit IRC ()
2862025-06-05T17:00:27 <bitcoin-git> [qa-assets] maflcko merged pull request #226: add coins_view_db inputs (main...coins-view-db-inputs) https://github.com/bitcoin-core/qa-assets/pull/226
2872025-06-05T17:00:29 <bitcoin-git> [qa-assets] maflcko pushed 2 commits to main: https://github.com/bitcoin-core/qa-assets/compare/4e64c5b478cd...ef94b3a22671
2882025-06-05T17:00:30 <bitcoin-git> qa-assets/main dfc1993 marcofleon: add coins_view_db inputs
2892025-06-05T17:00:30 <bitcoin-git> qa-assets/main ef94b3a maflcko: Merge pull request #226 from marcofleon/coins-view-db-inputs
2902025-06-05T17:19:33 *** jespada <jespada!~jespada@r179-25-40-226.dialup.adsl.anteldata.net.uy> has joined #bitcoin-core-dev
2912025-06-05T17:19:48 *** jespada <jespada!~jespada@r179-25-40-226.dialup.adsl.anteldata.net.uy> has quit IRC (Client Quit)
2922025-06-05T17:29:50 <gmaxwell> fjahr: if you're seeing slowdowns in batch validation with more threads that persist after resolving locking issues there are some internal parameters in libsecp256k1 that influence the cache footprint that might not be optimal because they were tuned by single thread testing.
2932025-06-05T17:31:17 *** Earnestly <Earnestly!~earnest@user/earnestly> has joined #bitcoin-core-dev
2942025-06-05T17:31:18 <gmaxwell> I see in the PR some comments about merging batches-- probably could be done in the API (due to lack of use it hasn't had a lot of development) but I think you don't want to anyways.. the asymptotic batching gain is only like 2x or whatnot, so it'll usually be better for performance to have more concurrency than more batching.
2952025-06-05T17:32:08 <gmaxwell> instead you'll probably want to get IBD validation able to batch validate multiple blocks at once eventually... and then even with a zillion cores all the batches will be reasonably large.
2962025-06-05T17:41:37 *** dviola <dviola!~diego@user/dviola> has quit IRC (Ping timeout: 248 seconds)
2972025-06-05T17:55:19 *** jon_atack <jon_atack!~jonatack@user/jonatack> has quit IRC (Ping timeout: 252 seconds)
2982025-06-05T18:11:03 *** jespada <jespada!~jespada@r179-25-40-226.dialup.adsl.anteldata.net.uy> has joined #bitcoin-core-dev
2992025-06-05T19:38:28 *** jadi <jadi!~jadi@d23-16-146-102.bchsia.telus.net> has joined #bitcoin-core-dev
3002025-06-05T19:49:21 *** certiorari <certiorari!~certiorar@94-255-242-247.cust.bredband2.com> has quit IRC (Remote host closed the connection)
3012025-06-05T20:01:16 *** jonatack <jonatack!~jonatack@user/jonatack> has joined #bitcoin-core-dev
3022025-06-05T20:22:03 *** spynxic <spynxic!~spynxic@spynxic.powered.by.lunarbnc.net> has quit IRC (Read error: Connection reset by peer)
3032025-06-05T20:22:31 *** spynxic <spynxic!~spynxic@spynxic.powered.by.lunarbnc.net> has joined #bitcoin-core-dev
3042025-06-05T20:33:18 *** spynxic <spynxic!~spynxic@spynxic.powered.by.lunarbnc.net> has quit IRC (Read error: Connection reset by peer)
3052025-06-05T20:33:40 *** spynxic <spynxic!~spynxic@spynxic.powered.by.lunarbnc.net> has joined #bitcoin-core-dev
3062025-06-05T20:35:32 *** Guyver2 <Guyver2!~Guyver@77-174-98-73.fixed.kpn.net> has left #bitcoin-core-dev (Closing Window)
3072025-06-05T20:36:13 <bitcoin-git> [bitcoin] PeterWrighten opened pull request #32685: wallet: Allow read-only database access for info and dump commands (master...wallet-readonly-access) https://github.com/bitcoin/bitcoin/pull/32685
3082025-06-05T20:57:25 *** jespada <jespada!~jespada@r179-25-40-226.dialup.adsl.anteldata.net.uy> has quit IRC (Quit: My Mac has gone to sleep. ZZZzzzâ¦)
3092025-06-05T21:01:18 *** jespada <jespada!~jespada@r179-25-40-226.dialup.adsl.anteldata.net.uy> has joined #bitcoin-core-dev
3102025-06-05T21:01:20 *** SpellChecker_ <SpellChecker_!~SpellChec@user/SpellChecker> has joined #bitcoin-core-dev
3112025-06-05T21:01:44 *** ghost43_ <ghost43_!~ghost43@gateway/tor-sasl/ghost43> has joined #bitcoin-core-dev
3122025-06-05T21:01:52 *** SpellChecker <SpellChecker!~SpellChec@user/SpellChecker> has quit IRC (Ping timeout: 244 seconds)
3132025-06-05T21:02:15 *** ghost43 <ghost43!~ghost43@gateway/tor-sasl/ghost43> has quit IRC (Remote host closed the connection)
3142025-06-05T21:37:28 *** jonatack <jonatack!~jonatack@user/jonatack> has quit IRC (Quit: WeeChat 4.6.3)
3152025-06-05T21:45:19 *** jonatack <jonatack!~jonatack@user/jonatack> has joined #bitcoin-core-dev
3162025-06-05T21:53:15 *** jespada <jespada!~jespada@r179-25-40-226.dialup.adsl.anteldata.net.uy> has quit IRC (Ping timeout: 260 seconds)
3172025-06-05T22:00:02 *** jespada <jespada!~jespada@r179-25-18-162.dialup.adsl.anteldata.net.uy> has joined #bitcoin-core-dev
3182025-06-05T22:03:22 *** wafflefrie <wafflefrie!uid478376@id-478376.uxbridge.irccloud.com> has joined #bitcoin-core-dev
3192025-06-05T22:22:49 <fjahr> gmaxwell: Cool, thanks for the feedback. Currently, the secp PR is still missing usage of Pippenger which is why I am mostly looking at relative improvements in benchmarks by changes in the core PR. After pippenger is added the caching would be good to check to look at next. I suggested the merging because I seemed like a good idea in my head but got the feedback that merging scratch spaces would be needed for that and it
3202025-06-05T22:22:49 <fjahr> sounded like something that would take a lot of effort with unclear gains, so might be reconsidered later if it's even worth it at all like you are saying.
3212025-06-05T22:26:12 <gmaxwell> yeah my point is that like, if you have 16 cpus you should have 16 batches, because doing say, 8 somewhat larger batches will always be slower than using all the cores. (or even 15 slightly larger batches vs 16 smaller using all the cores). I think the only reason you'd ever want to merge batches is if for some reason you had more validation threads than cores.
3222025-06-05T22:26:49 <gmaxwell> as far as merging them, I think it wouldn't actually be complicated, you'd just copy all of one into the other, keeping the destination scratch space size the same.
3232025-06-05T22:26:58 <gmaxwell> but I don't think it would actually be useful.
3242025-06-05T22:44:04 *** zeropoint <zeropoint!~alex@45-28-139-114.lightspeed.sntcca.sbcglobal.net> has joined #bitcoin-core-dev
3252025-06-05T23:08:44 *** jadi <jadi!~jadi@d23-16-146-102.bchsia.telus.net> has quit IRC (Remote host closed the connection)
3262025-06-05T23:08:55 *** jadi <jadi!~jadi@d23-16-146-102.bchsia.telus.net> has joined #bitcoin-core-dev
3272025-06-05T23:40:17 *** Earnestly <Earnestly!~earnest@user/earnestly> has quit IRC (Ping timeout: 272 seconds)
3282025-06-05T23:41:37 *** Earnestly <Earnestly!~earnest@user/earnestly> has joined #bitcoin-core-dev
3292025-06-05T23:53:01 *** jadi <jadi!~jadi@d23-16-146-102.bchsia.telus.net> has quit IRC (Remote host closed the connection)
3302025-06-05T23:53:12 *** jadi <jadi!~jadi@d23-16-146-102.bchsia.telus.net> has joined #bitcoin-core-dev