12025-06-12T00:03:32 *** jespada <jespada!~jespada@r179-25-133-111.dialup.adsl.anteldata.net.uy> has quit IRC (Ping timeout: 265 seconds)
22025-06-12T01:38:16 *** dyscope_ <dyscope_!~dyscope@91.218.89.24> has quit IRC (Ping timeout: 265 seconds)
32025-06-12T01:38:31 *** dyscope <dyscope!~dyscope@91.218.89.24> has quit IRC (Ping timeout: 276 seconds)
42025-06-12T01:46:58 *** spynxic <spynxic!~spynxic@spynxic.powered.by.lunarbnc.net> has quit IRC (Remote host closed the connection)
52025-06-12T01:47:28 *** spynxic <spynxic!~spynxic@spynxic.powered.by.lunarbnc.net> has joined #bitcoin-core-dev
62025-06-12T02:03:59 *** TheRec <TheRec!~toto@user/therec> has quit IRC ()
72025-06-12T02:52:29 *** mcey_ <mcey_!~emcy@185.69.145.202> has joined #bitcoin-core-dev
82025-06-12T02:55:17 *** emcy__ <emcy__!~emcy@185.69.145.202> has quit IRC (Ping timeout: 248 seconds)
92025-06-12T02:57:15 *** adil <adil!~Thunderbi@2402:d000:8134:2f97:c384:1f18:9ca6:4eff> has joined #bitcoin-core-dev
102025-06-12T03:00:02 <bitcoin-git> [gui-qml] johnny9 opened pull request #473: qml: Remove duplicate property in BlockClock (main...duplicate-property) https://github.com/bitcoin-core/gui-qml/pull/473
112025-06-12T03:30:38 *** lol_ <lol_!~lol@2603:3016:1e01:b960:1872:dc19:7a90:e870> has joined #bitcoin-core-dev
122025-06-12T03:35:03 *** jcarpenter2 <jcarpenter2!~lol@2603:3016:1e01:b960:98b9:322d:e05e:b646> has quit IRC (Ping timeout: 268 seconds)
132025-06-12T03:35:34 *** lol_ <lol_!~lol@2603:3016:1e01:b960:1872:dc19:7a90:e870> has left #bitcoin-core-dev
142025-06-12T04:01:01 *** cmirror <cmirror!~cmirror@4.53.92.114> has quit IRC (Remote host closed the connection)
152025-06-12T04:01:32 *** cmirror <cmirror!~cmirror@4.53.92.114> has joined #bitcoin-core-dev
162025-06-12T04:08:22 *** luke-jr <luke-jr!~luke-jr@user/luke-jr> has joined #bitcoin-core-dev
172025-06-12T04:10:14 *** luke-jr_ <luke-jr_!~luke-jr@user/luke-jr> has quit IRC (Ping timeout: 252 seconds)
182025-06-12T04:23:13 *** robszarka <robszarka!~szarka@2603:3003:4eac:100:3c4d:a401:db8b:2324> has joined #bitcoin-core-dev
192025-06-12T04:26:34 *** szarka <szarka!~szarka@2603:3003:4eac:100:29ca:6320:d90c:7c65> has quit IRC (Ping timeout: 260 seconds)
202025-06-12T04:28:19 *** jonatack <jonatack!~jonatack@user/jonatack> has joined #bitcoin-core-dev
212025-06-12T04:45:57 *** wafflefrie <wafflefrie!uid478376@id-478376.uxbridge.irccloud.com> has quit IRC (Quit: Connection closed for inactivity)
222025-06-12T04:50:53 *** kevkevin <kevkevin!~kevkevin@209.242.39.30> has quit IRC (Remote host closed the connection)
232025-06-12T05:00:35 *** dyscope_ <dyscope_!~dyscope@91.218.89.24> has joined #bitcoin-core-dev
242025-06-12T05:00:36 *** dyscope <dyscope!~dyscope@91.218.89.24> has joined #bitcoin-core-dev
252025-06-12T05:21:22 *** kevkevin <kevkevin!~kevkevin@209.242.39.30> has joined #bitcoin-core-dev
262025-06-12T05:26:09 *** dyscope_ <dyscope_!~dyscope@91.218.89.24> has quit IRC (Quit: Leaving)
272025-06-12T05:26:09 *** dyscope <dyscope!~dyscope@91.218.89.24> has quit IRC (Quit: Leaving)
282025-06-12T05:31:05 *** kevkevin <kevkevin!~kevkevin@209.242.39.30> has quit IRC (Ping timeout: 272 seconds)
292025-06-12T05:54:00 *** Christoph_ <Christoph_!~Christoph@host-88-217-174-126.customer.m-online.net> has joined #bitcoin-core-dev
302025-06-12T06:02:25 *** kevkevin <kevkevin!~kevkevin@209.242.39.30> has joined #bitcoin-core-dev
312025-06-12T06:14:13 *** BlueMatt <BlueMatt!~BlueMatt@ircb.bluematt.me> has quit IRC (Quit: Quit)
322025-06-12T06:14:34 *** BlueMatt <BlueMatt!~BlueMatt@ircb.bluematt.me> has joined #bitcoin-core-dev
332025-06-12T06:14:59 *** b10c[m] <b10c[m]!~b10cb10cm@2620:6e:a000:ce11::1c> has quit IRC (Ping timeout: 244 seconds)
342025-06-12T06:15:23 *** sr_gi[m]1 <sr_gi[m]1!~srgimatri@2620:6e:a000:ce11::2a> has quit IRC (Ping timeout: 268 seconds)
352025-06-12T06:15:30 *** bitcoin-git <bitcoin-git!~bitcoin-g@2620:6e:a000:ce11::21> has quit IRC (Ping timeout: 244 seconds)
362025-06-12T06:15:50 *** BlueMattMtrxBot <BlueMattMtrxBot!~bluemattm@2620:6e:a000:ce11::44> has quit IRC (Ping timeout: 260 seconds)
372025-06-12T06:16:09 *** laanwj <laanwj!~laanwj@user/laanwj> has quit IRC (Ping timeout: 276 seconds)
382025-06-12T06:16:25 *** stratospher[m] <stratospher[m]!~stratosph@2620:6e:a000:ce11::1e> has quit IRC (Ping timeout: 260 seconds)
392025-06-12T06:16:48 *** kvaciral[m] <kvaciral[m]!~kvaciralx@2620:6e:a000:ce11::27> has quit IRC (Ping timeout: 276 seconds)
402025-06-12T06:20:01 *** kevkevin <kevkevin!~kevkevin@209.242.39.30> has quit IRC (Ping timeout: 252 seconds)
412025-06-12T06:25:07 *** jkczyz <jkczyz!sid419941@id-419941.lymington.irccloud.com> has quit IRC (*.net *.split)
422025-06-12T06:25:07 *** schmidty <schmidty!sid297174@id-297174.lymington.irccloud.com> has quit IRC (*.net *.split)
432025-06-12T06:30:18 *** laanwj <laanwj!~laanwj@user/laanwj> has joined #bitcoin-core-dev
442025-06-12T06:30:25 *** sr_gi[m]1 <sr_gi[m]1!~srgimatri@2620:6e:a000:ce11::2a> has joined #bitcoin-core-dev
452025-06-12T06:30:33 *** jkczyz <jkczyz!sid419941@id-419941.lymington.irccloud.com> has joined #bitcoin-core-dev
462025-06-12T06:30:33 *** schmidty <schmidty!sid297174@id-297174.lymington.irccloud.com> has joined #bitcoin-core-dev
472025-06-12T06:35:14 *** peter_wrighten <peter_wrighten!~halloy616@user/peter-wrighten:19862> has joined #bitcoin-core-dev
482025-06-12T06:36:14 *** BlueMattMtrxBot <BlueMattMtrxBot!~bluemattm@2620:6e:a000:ce11::44> has joined #bitcoin-core-dev
492025-06-12T06:37:42 *** b10c[m] <b10c[m]!~b10cb10cm@2620:6e:a000:ce11::1c> has joined #bitcoin-core-dev
502025-06-12T06:39:09 *** stratospher[m] <stratospher[m]!~stratosph@2620:6e:a000:ce11::1e> has joined #bitcoin-core-dev
512025-06-12T06:39:44 *** bitcoin-git <bitcoin-git!~bitcoin-g@2620:6e:a000:ce11::21> has joined #bitcoin-core-dev
522025-06-12T06:46:47 *** kevkevin <kevkevin!~kevkevin@209.242.39.30> has joined #bitcoin-core-dev
532025-06-12T07:01:09 *** adil <adil!~Thunderbi@2402:d000:8134:2f97:c384:1f18:9ca6:4eff> has quit IRC (Ping timeout: 260 seconds)
542025-06-12T07:04:21 *** kevkevin <kevkevin!~kevkevin@209.242.39.30> has quit IRC (Ping timeout: 248 seconds)
552025-06-12T07:18:26 *** adil <adil!~Thunderbi@2402:d000:8134:2f97:c384:1f18:9ca6:4eff> has joined #bitcoin-core-dev
562025-06-12T07:28:00 *** emcy__ <emcy__!~emcy@185.69.145.202> has joined #bitcoin-core-dev
572025-06-12T07:29:44 *** hardtotell8 <hardtotell8!~hardtotel@user/hardtotell> has joined #bitcoin-core-dev
582025-06-12T07:29:46 *** sliv3r__- <sliv3r__-!~sliv3r__@user/sliv3r-:76883> has joined #bitcoin-core-dev
592025-06-12T07:30:34 *** sliv3r__ <sliv3r__!~sliv3r__@user/sliv3r-:76883> has quit IRC (Remote host closed the connection)
602025-06-12T07:30:52 *** hardtotell <hardtotell!~hardtotel@user/hardtotell> has quit IRC (Read error: Connection reset by peer)
612025-06-12T07:30:52 *** hardtotell8 is now known as hardtotell
622025-06-12T07:31:29 *** mcey_ <mcey_!~emcy@185.69.145.202> has quit IRC (Ping timeout: 260 seconds)
632025-06-12T07:35:24 *** Guyver2 <Guyver2!~Guyver@77-174-98-73.fixed.kpn.net> has joined #bitcoin-core-dev
642025-06-12T07:51:54 *** kevkevin <kevkevin!~kevkevin@209.242.39.30> has joined #bitcoin-core-dev
652025-06-12T07:55:36 *** dzxzg <dzxzg!~dzxzg@user/dzxzg> has quit IRC (Ping timeout: 276 seconds)
662025-06-12T07:58:57 *** dzxzg <dzxzg!~dzxzg@user/dzxzg> has joined #bitcoin-core-dev
672025-06-12T08:08:51 *** kevkevin <kevkevin!~kevkevin@209.242.39.30> has quit IRC (Ping timeout: 268 seconds)
682025-06-12T08:26:54 *** adil <adil!~Thunderbi@2402:d000:8134:2f97:c384:1f18:9ca6:4eff> has quit IRC (Ping timeout: 260 seconds)
692025-06-12T08:32:20 <vasild> #proposedmeetingtopic Rough poll - how many people use GCC and how many of those do generate code coverage with GCC? Context: https://github.com/bitcoin/bitcoin/issues/31047#issuecomment-2965646793
702025-06-12T08:41:55 <fanquake> Seems like the wrong two questions? Shouldn't it just be, "What compiler do you use to generate code coverage?".
712025-06-12T08:43:11 *** kevkevin <kevkevin!~kevkevin@209.242.39.30> has joined #bitcoin-core-dev
722025-06-12T08:45:28 <janb84> clang + llvm-cov
732025-06-12T08:45:51 <vasild> Well, if we want to know how many people would be affected if we drop X, then the question to ask it "Who is using X?". Also, another thing to consider is that people that use GCC but did not generate coverage in the past are potential users of the to-be-dropped stuff.
742025-06-12T08:46:08 <fanquake> Yea. All of our fuzzing infra, mutation testing etc all use Clang, because it's the only thing that works
752025-06-12T08:46:51 <maflcko> for one-off coverage I just use assert(false) or std::cout and see if it is hit (works with any compiler without coverage tooling)
762025-06-12T08:47:01 <fanquake> Those people can still do whatever they want, assuming they can make it work amongst the matrix of tooling and lcov versions and gcov versions (another reason why it doesn't work out of the box consistently)
772025-06-12T08:49:22 *** adil <adil!~Thunderbi@2402:d000:8134:2f97:c384:1f18:9ca6:4eff> has joined #bitcoin-core-dev
782025-06-12T08:49:43 <dergoegge> https://maflcko.github.io/b-c-cov/ uses the gcc stuff, right?
792025-06-12T08:50:07 <fanquake> My suggestion is just that we should switch what we have implemented, to be more convenient, for the majority of people already doing useful work (a few exceptions obviously, but that can likely accomodate/don't care too much)
802025-06-12T08:54:45 <maflcko> yeah, corecheck as well: https://github.com/corecheck/corecheck/blob/7734c3773da2ae2f133b7a720dee7d3ede966520/workers/coverage-worker/entrypoint.sh#L50 So would have to remove -DCMAKE_BUILD_TYPE=Coverage there first, before removing it from the build system
812025-06-12T08:56:03 <fanquake> I'm not saying we shouldn't remove it, I'm saying we implement it so it works with Clang, rather than GCC
822025-06-12T08:57:00 <fanquake> *should
832025-06-12T08:57:42 <hebasto> Using clang for coverage reports doesnât need a dedicated build configuration at all
842025-06-12T08:57:53 <fanquake> (and not try and use any compatibility modes etc)
852025-06-12T08:58:00 <fanquake> Sure, but neither does GCC
862025-06-12T09:02:36 *** antanst9 <antanst9!~antanst@user/antanst> has quit IRC (Ping timeout: 272 seconds)
872025-06-12T09:03:43 *** kevkevin <kevkevin!~kevkevin@209.242.39.30> has quit IRC (Ping timeout: 244 seconds)
882025-06-12T09:04:19 <hebasto> the coverage build configuration facilitates helping scripts when using cmake multi-config generators.
892025-06-12T09:10:28 *** antanst9 <antanst9!~antanst@user/antanst> has joined #bitcoin-core-dev
902025-06-12T09:11:33 <_aj_> i've done a cov build in the past; don't remember if it was gcc or clang. i mostly found the upstream tools confusing, vs problems with the autotools/make stuff (which is why i haven't tried it recently). my config.log suggests i was trying with clang at one point for whatever that's worth
912025-06-12T09:11:54 <fanquake> Given multi-config is primarily to support Windows, it seems less relevant here? Is anyone doing multi-config converage builds (on windows?)?
922025-06-12T09:12:34 <fanquake> _aj_: if you tried using Clang with the current coverage build type, you likely would have run into issues yea
932025-06-12T09:13:47 <_aj_> fanquake: i mean "how do i get useful reports? ah, this then this then that then the other thing. ugh, it worked, but that was so annoying i never want to do it again" from what i remember, anyway
942025-06-12T09:14:13 <_aj_> fanquake: easier to use the drahtbot links now :-/
952025-06-12T09:21:51 <fanquake> _aj: sounds like a situation we need to improve
962025-06-12T09:28:36 <bitcoin-git> [bitcoin] waketraindev closed pull request #32732: net, rpc, qt: add per-peer blocktxn stats to getpeerinfo and qt debug window (master...extra-blocktxn-stats) https://github.com/bitcoin/bitcoin/pull/32732
972025-06-12T09:38:20 *** tarotfied <tarotfied!~tarotfied@user/tarotfied> has quit IRC (Ping timeout: 244 seconds)
982025-06-12T09:39:37 *** tarotfied <tarotfied!~tarotfied@user/tarotfied> has joined #bitcoin-core-dev
992025-06-12T09:42:09 *** Christoph_ <Christoph_!~Christoph@host-88-217-174-126.customer.m-online.net> has quit IRC (Quit: Christoph_)
1002025-06-12T09:42:31 *** Christoph_ <Christoph_!~Christoph@host-88-217-174-126.customer.m-online.net> has joined #bitcoin-core-dev
1012025-06-12T09:44:54 *** kevkevin <kevkevin!~kevkevin@209.242.39.30> has joined #bitcoin-core-dev
1022025-06-12T09:45:31 <bitcoin-git> [bitcoin] fanquake opened pull request #32735: [28.x] More backports (28.x...28_x_win_sign_cmake_4) https://github.com/bitcoin/bitcoin/pull/32735
1032025-06-12T09:47:29 *** Christoph_ <Christoph_!~Christoph@host-88-217-174-126.customer.m-online.net> has quit IRC (Ping timeout: 245 seconds)
1042025-06-12T09:49:29 *** Cory <Cory!~Cory@user/pasha> has quit IRC (Quit: Client closed)
1052025-06-12T09:49:42 *** kevkevin <kevkevin!~kevkevin@209.242.39.30> has quit IRC (Ping timeout: 244 seconds)
1062025-06-12T09:49:48 *** Cory <Cory!~Cory@user/pasha> has joined #bitcoin-core-dev
1072025-06-12T10:01:23 *** Christoph_ <Christoph_!~Christoph@host-88-217-174-126.customer.m-online.net> has joined #bitcoin-core-dev
1082025-06-12T10:03:33 *** kevkevin <kevkevin!~kevkevin@209.242.39.30> has joined #bitcoin-core-dev
1092025-06-12T10:10:36 *** Christoph_ <Christoph_!~Christoph@host-88-217-174-126.customer.m-online.net> has quit IRC (Ping timeout: 265 seconds)
1102025-06-12T10:22:59 *** TheRec <TheRec!~toto@user/therec> has joined #bitcoin-core-dev
1112025-06-12T10:25:06 *** kevkevin <kevkevin!~kevkevin@209.242.39.30> has quit IRC (Ping timeout: 265 seconds)
1122025-06-12T10:51:57 *** kevkevin <kevkevin!~kevkevin@209.242.39.30> has joined #bitcoin-core-dev
1132025-06-12T10:55:18 <bitcoin-git> [gui-qml] hebasto pushed 2 commits to main: https://github.com/bitcoin-core/gui-qml/compare/c7678375d081...07093a161c0d
1142025-06-12T10:55:19 <bitcoin-git> gui-qml/main b9a9007 johnny9: qml: Remove duplicate property in BlockClock
1152025-06-12T10:55:19 <bitcoin-git> gui-qml/main 07093a1 merge-script: Merge bitcoin-core/gui-qml#473: qml: Remove duplicate property in BlockClo...
1162025-06-12T10:55:20 <bitcoin-git> [gui-qml] hebasto merged pull request #473: qml: Remove duplicate property in BlockClock (main...duplicate-property) https://github.com/bitcoin-core/gui-qml/pull/473
1172025-06-12T10:57:26 *** Guyver2 <Guyver2!~Guyver@77-174-98-73.fixed.kpn.net> has quit IRC (Quit: Going offline, see ya! (www.adiirc.com))
1182025-06-12T11:01:42 *** jespada <jespada!~jespada@r179-25-148-209.dialup.adsl.anteldata.net.uy> has joined #bitcoin-core-dev
1192025-06-12T11:03:16 *** Cory <Cory!~Cory@user/pasha> has quit IRC (Quit: Client closed)
1202025-06-12T11:03:33 *** Cory <Cory!~Cory@user/pasha> has joined #bitcoin-core-dev
1212025-06-12T11:07:53 *** l0rinc <l0rinc!~l0rinc@user/l0rinc> has joined #bitcoin-core-dev
1222025-06-12T11:09:27 <l0rinc> #proposedmeetingtopic [IBD] multi-byte block obfuscation (part of #32043)
1232025-06-12T11:09:28 <l0rinc> With the AutoFile batching now merged (#31551), seeking reviewers/reproducers for the block/index obfuscation optimizations in #31144 - achieving >20x performance gain and ~4% overall IBD speedup
1242025-06-12T11:09:30 <corebot`> https://github.com/bitcoin/bitcoin/issues/32043 | [IBD] Tracking PR for speeding up Initial Block Download by l0rinc · Pull Request #32043 · bitcoin/bitcoin · GitHub
1252025-06-12T11:09:33 <corebot`> https://github.com/bitcoin/bitcoin/issues/31551 | [IBD] batch block reads/writes during `AutoFile` serialization by l0rinc · Pull Request #31551 · bitcoin/bitcoin · GitHub
1262025-06-12T11:09:36 <corebot`> https://github.com/bitcoin/bitcoin/issues/31144 | [IBD] multi-byte block obfuscation by l0rinc · Pull Request #31144 · bitcoin/bitcoin · GitHub
1272025-06-12T11:10:13 *** kevkevin <kevkevin!~kevkevin@209.242.39.30> has quit IRC (Ping timeout: 248 seconds)
1282025-06-12T11:22:29 *** adil <adil!~Thunderbi@2402:d000:8134:2f97:c384:1f18:9ca6:4eff> has quit IRC (Ping timeout: 260 seconds)
1292025-06-12T11:25:05 *** peter_wrighten <peter_wrighten!~halloy616@user/peter-wrighten:19862> has quit IRC (Ping timeout: 252 seconds)
1302025-06-12T11:29:24 *** adil <adil!~Thunderbi@2402:d000:8134:2f97:c384:1f18:9ca6:4eff> has joined #bitcoin-core-dev
1312025-06-12T11:30:17 *** Christoph_ <Christoph_!~Christoph@host-88-217-174-126.customer.m-online.net> has joined #bitcoin-core-dev
1322025-06-12T11:35:26 *** adil <adil!~Thunderbi@2402:d000:8134:2f97:c384:1f18:9ca6:4eff> has quit IRC (Quit: adil)
1332025-06-12T11:35:27 *** Guest14 <Guest14!~Guest14@175.100.56.115> has joined #bitcoin-core-dev
1342025-06-12T11:35:42 *** Guest14 <Guest14!~Guest14@175.100.56.115> has quit IRC (Client Quit)
1352025-06-12T11:46:29 *** kevkevin <kevkevin!~kevkevin@209.242.39.30> has joined #bitcoin-core-dev
1362025-06-12T12:06:25 *** kevkevin <kevkevin!~kevkevin@209.242.39.30> has quit IRC (Ping timeout: 260 seconds)
1372025-06-12T12:11:21 *** l0rinc <l0rinc!~l0rinc@user/l0rinc> has quit IRC (Quit: l0rinc)
1382025-06-12T12:20:20 *** Guyver2 <Guyver2!Guyver@77-174-98-73.fixed.kpn.net> has joined #bitcoin-core-dev
1392025-06-12T12:30:20 *** kevkevin <kevkevin!~kevkevin@209.242.39.30> has joined #bitcoin-core-dev
1402025-06-12T12:31:49 <vasild> achow101: (or whoever hosts the meeting) I will not be at the meeting. The point of the topic I proposed is to get an estimate of how many people would be affected if we remove something that they use (GCC coverage from CMake as it is now)
1412025-06-12T12:38:39 *** janb84 <janb84!~janb84@user/janb84> has quit IRC (Ping timeout: 244 seconds)
1422025-06-12T12:40:42 *** janb84 <janb84!~janb84@user/janb84> has joined #bitcoin-core-dev
1432025-06-12T12:42:47 *** sliv3r__- <sliv3r__-!~sliv3r__@user/sliv3r-:76883> has quit IRC (Read error: Connection reset by peer)
1442025-06-12T12:42:53 *** sliv3r__ <sliv3r__!~sliv3r__@user/sliv3r-:76883> has joined #bitcoin-core-dev
1452025-06-12T13:00:23 *** ghost43 <ghost43!~ghost43@gateway/tor-sasl/ghost43> has quit IRC (Remote host closed the connection)
1462025-06-12T13:00:23 *** SpellChecker <SpellChecker!~SpellChec@user/SpellChecker> has quit IRC (Read error: Connection reset by peer)
1472025-06-12T13:00:47 *** SpellChecker <SpellChecker!~SpellChec@user/SpellChecker> has joined #bitcoin-core-dev
1482025-06-12T13:00:47 *** ghost43 <ghost43!~ghost43@gateway/tor-sasl/ghost43> has joined #bitcoin-core-dev
1492025-06-12T13:09:26 *** Guyver2 <Guyver2!Guyver@77-174-98-73.fixed.kpn.net> has left #bitcoin-core-dev (Closing Window)
1502025-06-12T13:21:05 *** VonNaturAustreVe <VonNaturAustreVe!~natur@2804:14c:65d7:8e6c:7541:3e0a:2a42:b855> has joined #bitcoin-core-dev
1512025-06-12T13:28:39 *** kevkevin <kevkevin!~kevkevin@209.242.39.30> has quit IRC (Remote host closed the connection)
1522025-06-12T13:29:49 *** kevkevin <kevkevin!~kevkevin@209.242.39.30> has joined #bitcoin-core-dev
1532025-06-12T13:30:48 *** SpellChecker <SpellChecker!~SpellChec@user/SpellChecker> has quit IRC (Remote host closed the connection)
1542025-06-12T13:31:05 *** SpellChecker <SpellChecker!~SpellChec@user/SpellChecker> has joined #bitcoin-core-dev
1552025-06-12T13:42:39 <bitcoin-git> [bitcoin] hodlinator opened pull request #32736: wallet: Warn upon failing to scan directory (master...2025/06/wallet_dir_iter) https://github.com/bitcoin/bitcoin/pull/32736
1562025-06-12T13:49:09 *** l0rinc <l0rinc!~l0rinc@user/l0rinc> has joined #bitcoin-core-dev
1572025-06-12T14:00:19 *** l0rinc <l0rinc!~l0rinc@user/l0rinc> has quit IRC (Ping timeout: 252 seconds)
1582025-06-12T14:01:49 *** Guest5082 <Guest5082!~ubuntu@197.237.184.179> has joined #bitcoin-core-dev
1592025-06-12T14:21:50 *** jonatack <jonatack!~jonatack@user/jonatack> has quit IRC (Ping timeout: 252 seconds)
1602025-06-12T14:27:06 *** jonatack <jonatack!~jonatack@user/jonatack> has joined #bitcoin-core-dev
1612025-06-12T14:32:40 *** jonatack <jonatack!~jonatack@user/jonatack> has quit IRC (Ping timeout: 276 seconds)
1622025-06-12T14:46:30 *** mcey_ <mcey_!~emcy@148.252.145.190> has joined #bitcoin-core-dev
1632025-06-12T14:49:19 *** emcy__ <emcy__!~emcy@185.69.145.202> has quit IRC (Ping timeout: 252 seconds)
1642025-06-12T14:49:24 *** Cory <Cory!~Cory@user/pasha> has quit IRC (Quit: Client closed)
1652025-06-12T14:49:41 *** Cory <Cory!~Cory@user/pasha> has joined #bitcoin-core-dev
1662025-06-12T14:51:11 *** Cory <Cory!~Cory@user/pasha> has quit IRC (Client Quit)
1672025-06-12T14:51:25 *** Cory <Cory!~Cory@user/pasha> has joined #bitcoin-core-dev
1682025-06-12T14:53:51 <bitcoin-git> [bitcoin] rkrux opened pull request #32737: rpc, doc: clarify the response of listtransactions RPC (master...listtx) https://github.com/bitcoin/bitcoin/pull/32737
1692025-06-12T14:57:17 *** jespada <jespada!~jespada@r179-25-148-209.dialup.adsl.anteldata.net.uy> has quit IRC (Quit: My Mac has gone to sleep. ZZZzzzâ¦)
1702025-06-12T14:58:27 *** jespada <jespada!~jespada@r179-25-148-209.dialup.adsl.anteldata.net.uy> has joined #bitcoin-core-dev
1712025-06-12T15:01:53 *** purpleKarrot <purpleKarrot!~purpleKar@user/purpleKarrot> has joined #bitcoin-core-dev
1722025-06-12T15:08:22 <lightlike> vasild: I usually use gcc and have used lcov with it on occasion before, but clang is necessary anyway (sanitizers, fuzzing), so I don't really care, just need something that works and is documented.
1732025-06-12T15:13:02 *** Christoph_ <Christoph_!~Christoph@host-88-217-174-126.customer.m-online.net> has quit IRC (Quit: Christoph_)
1742025-06-12T15:27:48 *** bugs_ <bugs_!~bugs@user/bugs/x-5128603> has joined #bitcoin-core-dev
1752025-06-12T15:37:33 <bitcoin-git> [bitcoin] Bitchryankilledme opened pull request #32738: Create msbuild.yml (master...master) https://github.com/bitcoin/bitcoin/pull/32738
1762025-06-12T15:37:45 <bitcoin-git> [bitcoin] DrahtBot closed pull request #32738: Create msbuild.yml (master...master) https://github.com/bitcoin/bitcoin/pull/32738
1772025-06-12T15:43:30 *** jonatack <jonatack!~jonatack@user/jonatack> has joined #bitcoin-core-dev
1782025-06-12T15:45:10 *** Cory <Cory!~Cory@user/pasha> has quit IRC (Quit: Client closed)
1792025-06-12T15:45:27 *** Cory <Cory!~Cory@user/pasha> has joined #bitcoin-core-dev
1802025-06-12T15:51:24 *** eugenesiegel <eugenesiegel!~eugenesie@user/eugenesiegel> has joined #bitcoin-core-dev
1812025-06-12T15:55:39 *** Emc99 <Emc99!~Emc99@212.129.86.199> has joined #bitcoin-core-dev
1822025-06-12T15:58:00 *** dermoth_ <dermoth_!~dermoth@user/dermoth> has joined #bitcoin-core-dev
1832025-06-12T16:00:15 <achow101> #startmeeting
1842025-06-12T16:00:15 <corebot`> achow101: Meeting started at 2025-06-12T16:00+0000
1852025-06-12T16:00:16 <corebot`> achow101: Current chairs: achow101
1862025-06-12T16:00:17 <hodlinator> hi
1872025-06-12T16:00:18 <corebot`> achow101: Useful commands: #action #info #idea #link #topic #motion #vote #close #endmeeting
1882025-06-12T16:00:19 <corebot`> achow101: See also: https://hcoop-meetbot.readthedocs.io/en/stable/
1892025-06-12T16:00:20 <corebot`> achow101: Participants should now identify themselves with '#here' or with an alias like '#here FirstLast'
1902025-06-12T16:00:22 <TheCharlatan> hi
1912025-06-12T16:00:25 <achow101> #bitcoin-core-dev Meeting: abubakarsadiq achow101 _aj_ ajonas b10c brunoerg cfields darosior dergoegge fanquake fjahr furszy gleb glozow hebasto hodlinator instagibbs jarolrod jonatack josibake kanzure laanwj LarryRuane lightlike luke-jr maflcko marcofleon maxedw Murch pinheadmz provoostenator ryanofsky sdaftuar S3RK stickies-v sipa sr_gi tdb3 theStack TheCharlatan vasild willcl-ark
1922025-06-12T16:00:25 <maxedw> hi
1932025-06-12T16:00:25 *** dermoth <dermoth!~dermoth@user/dermoth> has quit IRC (Ping timeout: 276 seconds)
1942025-06-12T16:00:28 <hebasto> hi
1952025-06-12T16:00:29 <furszy> hi
1962025-06-12T16:00:30 <johnny9dev> hi
1972025-06-12T16:00:32 <dergoegge> hi
1982025-06-12T16:00:34 <pinheadmz> hi
1992025-06-12T16:00:36 <fjahr> hi
2002025-06-12T16:00:39 <brunoerg_> hi
2012025-06-12T16:00:41 <vasild> hi (I am back on time)
2022025-06-12T16:00:42 <lightlike> hi
2032025-06-12T16:00:51 <instagibbs> hi
2042025-06-12T16:00:52 <achow101> There are 2 preproposed meeting topics this week. Any last minute ones to add?
2052025-06-12T16:01:05 <eugenesiegel> hi
2062025-06-12T16:01:15 <stickies-v> hi
2072025-06-12T16:01:23 *** l0rinc <l0rinc!~l0rinc@user/l0rinc> has joined #bitcoin-core-dev
2082025-06-12T16:01:31 <l0rinc> hi
2092025-06-12T16:01:38 *** enochazariah <enochazariah!~enochazar@102.91.103.249> has joined #bitcoin-core-dev
2102025-06-12T16:01:45 <cfields> hi
2112025-06-12T16:01:48 <jonatack> hi
2122025-06-12T16:01:55 <achow101> #topic Fuzzing WG Update (dergoegge)
2132025-06-12T16:02:09 <dergoegge> Fuzzamoto (https://github.com/dergoegge/fuzzamoto) has been my primary focus the last couple months. Wrote some notes on what Iâve been up to here: https://gist.github.com/dergoegge/46c7a5fd2468b5b108f5c34ac1f88e45. Quick summary:
2142025-06-12T16:02:21 <dergoegge> The project now includes a custom fuzzing engine for structure aware fuzzing of p2p protocol message sequences. Coverage report for that as of jun 10: https://dergoegge.github.io/bitcoin-coverage/fuzzamoto/ir-jun10/coverage/bitcoin/index.html
2152025-06-12T16:02:32 <dergoegge> Highlights from the cov report:
2162025-06-12T16:02:39 <dergoegge> More net_processing coverage than the in-repo fuzz tests, in all coverage metrics (line, function, region, branch) coverage (e.g. ~70% vs ~ 64% line coverage). Also coverage for reorgs went from nothing to something (i.e. Chainstate::DisconnectTip, Chainstate::MaybeUpdateMempoolForReorg)
2172025-06-12T16:02:51 *** dermoth_ is now known as dermoth
2182025-06-12T16:03:01 <dergoegge> Iâm still working on extending the fuzzer to increase coverage (e.g. no compact block support atm) and brainstorming what kind of bug oracles are feasible (please lmk if you have any ideas, join the fuzzing wg)
2192025-06-12T16:03:08 <purpleKarrot> hi
2202025-06-12T16:03:20 <dergoegge> Lastly, it would be interesting to have a collection of real p2p/validation bugs to test the fuzzer against (beyond whatâs list ed on https://bitcoincore.org/en/security-advisories/). If you know of or have found bugs in your own or other PRs please let me know! Any kind of bug (logic, crash, â¦) is fine.
2212025-06-12T16:03:24 *** Christoph_ <Christoph_!~Christoph@2a02:810d:1399:b700:353f:ec3a:a049:af38> has joined #bitcoin-core-dev
2222025-06-12T16:03:37 *** rkrux <rkrux!~rkrux@user/rkrux> has joined #bitcoin-core-dev
2232025-06-12T16:03:40 <marcofleon> hype
2242025-06-12T16:03:48 <instagibbs> nice re:reorgs
2252025-06-12T16:03:55 <rkrux> hi
2262025-06-12T16:03:55 <eugenesiegel> awesome about reorgs
2272025-06-12T16:04:16 <brunoerg_> nice
2282025-06-12T16:04:41 <sipa> hi
2292025-06-12T16:05:35 <sipa> dergoegge: cool, will think about bugs that can be included
2302025-06-12T16:06:38 <achow101> #topic Kernel WG Update (TheCharlatan)
2312025-06-12T16:06:43 <TheCharlatan> I pushed a new version of #32427 including a write ahead log and crc32c checksums for each entry. Performance still seems to be a bit better compared to leveldb. This should make writes atomic and provide detection for potential corruption.
2322025-06-12T16:06:45 <corebot`> https://github.com/bitcoin/bitcoin/issues/32427 | (RFC) kernel: Replace leveldb-based BlockTreeDB with flat-file based store by TheCharlatan · Pull Request #32427 · bitcoin/bitcoin · GitHub
2332025-06-12T16:07:12 <cfields> ð
2342025-06-12T16:07:18 *** Christoph_ <Christoph_!~Christoph@2a02:810d:1399:b700:353f:ec3a:a049:af38> has quit IRC (Client Quit)
2352025-06-12T16:07:42 <TheCharlatan> also looking for review on #32317
2362025-06-12T16:07:45 <corebot`> https://github.com/bitcoin/bitcoin/issues/32317 | kernel: Separate UTXO set access from validation functions by TheCharlatan · Pull Request #32317 · bitcoin/bitcoin · GitHub
2372025-06-12T16:08:13 <TheCharlatan> that's all for now
2382025-06-12T16:08:13 <sipa> TheCharlatan: (sorry for being lazy and not looking at code), what path structure are you using?
2392025-06-12T16:08:14 <cfields> 32427 spawned a discussion about a new on-disk block layout that is a bit of a distraction...
2402025-06-12T16:08:17 <sr_gi[m]1> hi
2412025-06-12T16:08:31 <abubakarsadiq> hi
2422025-06-12T16:08:38 *** enochazariah97 <enochazariah97!~enochazar@169.197.85.174> has joined #bitcoin-core-dev
2432025-06-12T16:08:40 <sipa> cfields: jinx, ok...
2442025-06-12T16:08:45 <cfields> I think it might be worth having that discussion here a bit..
2452025-06-12T16:08:47 <TheCharlatan> path structures?
2462025-06-12T16:08:47 <cfields> sipa: hah
2472025-06-12T16:09:00 <sipa> TheCharlatan: directory/file names
2482025-06-12T16:09:14 *** hernanmarino <hernanmarino!~hernanmar@2800:2330:2800:2e7:90fa:a87a:ffb2:3428> has quit IRC (Ping timeout: 268 seconds)
2492025-06-12T16:09:22 <l0rinc> TheCharlatan: "Performance still seems to be a bit better compared to leveldb" - I have measured a reindex until 888888 blocks for your PR and the performance seemed roughly the same
2502025-06-12T16:09:39 *** enochazariah <enochazariah!~enochazar@102.91.103.249> has quit IRC (Ping timeout: 272 seconds)
2512025-06-12T16:09:47 <TheCharlatan> oh, yeah, the PR does not touch the actual block storage hierarchy.
2522025-06-12T16:09:59 <sipa> ah, ok
2532025-06-12T16:10:33 <cfields> tldr: in the review for 32427, several reviewers brought up the idea of changing the on-disk block format while we're at it. One suggested example is one-file-per-block...
2542025-06-12T16:10:54 <dergoegge> the on disk block index storage performance should not affect ibd at all, we keep all of it in memory no?
2552025-06-12T16:11:30 <sipa> dergoegge: flushes to utxo set trigger flushes of block data, which could take some marginal amount of time?
2562025-06-12T16:11:37 <TheCharlatan> I also think that given that we have some flexibility with the existing pair of 64bit numbers to point to a location on disk, we might be able to use the encoding for single block files.
2572025-06-12T16:11:47 <cfields> for 32427 to move forward, we either need to agree to punt on that discussion and bring it up again later, or bikeshed some layout changes. For the sake of not grinding the flat index changes to a halt, I prefer the former.
2582025-06-12T16:11:53 <dergoegge> sipa: ah right, ty
2592025-06-12T16:11:56 <vasild> "one-file-per-block" ... some filesystems may not handle well 1M files, is there any benefit from doing that?
2602025-06-12T16:12:00 <l0rinc> won't we have problems with so many open files on Windows - like we had with LevelDB?
2612025-06-12T16:12:27 <sipa> vasild: they can be grouped into subdirectories too, either by hash, or (my suggestion, i think) by height
2622025-06-12T16:12:31 <cfields> vasild: you don't really need an index anymore if the blocks can be located using the filesystem alone.
2632025-06-12T16:12:47 <vasild> sure, I do not mean 1M files in a single directory
2642025-06-12T16:12:53 <cfields> er, a much simpler index at least.
2652025-06-12T16:13:00 <sipa> yes, agree with that, don't put 1M files in a single directory :)
2662025-06-12T16:13:00 <l0rinc> would be really cool to try it out though - let me know if I can help with benchmarking anything
2672025-06-12T16:13:13 <TheCharlatan> dergoegge yes, in ibd time it is just good to know there are no regressions. The speedup during block index loading when starting a node is more significant though.
2682025-06-12T16:13:15 <lightlike> people tend to copy datadirs for backups etc. years ago that would take very long with millions of files, did that change?
2692025-06-12T16:13:55 <sipa> cfields: no need for the block data structure change (if any) to be made in the same PR, it suffices if it's in the same release
2702025-06-12T16:14:33 *** enochazariah97 <enochazariah97!~enochazar@169.197.85.174> has quit IRC (Quit: Client closed)
2712025-06-12T16:14:42 *** freedomcode <freedomcode!~reardenco@shrugged.reardencode.com> has quit IRC (Remote host closed the connection)
2722025-06-12T16:14:58 *** reardencode <reardencode!~reardenco@shrugged.reardencode.com> has joined #bitcoin-core-dev
2732025-06-12T16:15:00 <sipa> cfields: well "index" isn't the right word anymore then, but we still have a block database with things like validation status and so on (though, arguably, that belongs more in validation then block storage)
2742025-06-12T16:15:02 <vasild> cfields: that would be like outsouring the indexing to the OS/filesystem, e.g. blocks/1/15/153/153764 (for block 153764). The question is can we do better than the worst OS/FS that is going to use Bitcoin Core, or even, better than the best FS?
2752025-06-12T16:15:03 <l0rinc> would that mean that leveldb indexes can point to files and indexes now instead of duplicating any data? Or is that still problematic for pruned nodes?
2762025-06-12T16:15:30 <sipa> it'd be pretty awesome if the block index can go away, and its remaining fields moved into the chainstate
2772025-06-12T16:15:56 <vasild> I guess it has to be tested...
2782025-06-12T16:15:57 <cfields> sipa: right
2792025-06-12T16:16:07 <sipa> though maybe not more than an aesthetical advantage
2802025-06-12T16:16:26 <sipa> it's just ugly that we store validity of a block in the block index, it's not a storage-related thing but a validation-related one
2812025-06-12T16:16:33 <cfields> sipa: much easier for non-core software to read blocks. definitely not just aesthetic.
2822025-06-12T16:16:53 <sipa> cfields: i'm talking about the block index going away, independent of block storage structure used
2832025-06-12T16:17:41 <sipa> lightlike: yeah, i worry about that too - maybe in these days with fast SSDs that's less of an issue, but i don't actually know
2842025-06-12T16:18:20 <cfields> sipa: not sure what you mean. how does it go away if we still need to map them to a non-addressable location?
2852025-06-12T16:19:21 <TheCharlatan> also seems useful though to have block validity included for as long as we can't read the chainstate easily from external sources.
2862025-06-12T16:20:00 <sipa> cfields: sorry, i'm being confusing. I'm talking about the advantage of the block index going away, which is something that's only possible with a change to directory structure - but i'm just talking that that index going away itself is nice, ignoring the advantage that the directory structure may bring without that
2872025-06-12T16:20:07 <sipa> TheCharlatan: i disagree!
2882025-06-12T16:20:29 <sipa> TheCharlatan: it's pretty counterintuitive that someone just copying the block data, but not chainstate, would inherit the validity status from that block data
2892025-06-12T16:20:39 <cfields> sipa: ah, yes, completely agree.
2902025-06-12T16:22:45 <TheCharlatan> mmh, so you couldn't recreate the block tree anymore without re-validating?
2912025-06-12T16:23:27 <sipa> TheCharlatan: i just wouldn't think of the validity status as part of the block data
2922025-06-12T16:23:47 <sipa> you can recreate it from just disk, but without a chainstate to fill in validity status, every block would be marked as non-validated
2932025-06-12T16:23:54 *** Christoph_ <Christoph_!~Christoph@2a02:810d:1399:b700:353f:ec3a:a049:af38> has joined #bitcoin-core-dev
2942025-06-12T16:24:10 <sipa> this is probably getting a bit into the weeds for this meeting
2952025-06-12T16:24:19 <TheCharlatan> yes :)
2962025-06-12T16:24:25 <lightlike> i feel like the discussion of this idea deserves a separate issue, it's not that related to ThCharlatan's PR.
2972025-06-12T16:25:40 <TheCharlatan> sooo... next topic?
2982025-06-12T16:25:54 <achow101> next topic
2992025-06-12T16:25:55 <achow101> #topic Benchmarking WG Update (josie, l0rinc)
3002025-06-12T16:26:10 <l0rinc> I have opened the obfuscation PR in Oct 2024, split off other smaller optimizations since, some of those are merged already - the XOR block obfuscation one is next, reproducers and reviewers are welcome
3012025-06-12T16:26:35 <l0rinc> I've received 2 raspberry pi servers recently, I will be able to do benchmarks on those as well (already measured Sipa's #32545) - since many people are complaining they're IBDs are taking weeks
3022025-06-12T16:26:37 <corebot`> https://github.com/bitcoin/bitcoin/issues/32545 | Replace cluster linearization algorithm with SFL by sipa · Pull Request #32545 · bitcoin/bitcoin · GitHub
3032025-06-12T16:26:58 <l0rinc> And lately I'm measuring memory usages as well besides performance with massif and heaptrack as well - see #28531
3042025-06-12T16:27:01 <corebot`> https://github.com/bitcoin/bitcoin/issues/28531 | improve MallocUsage() accuracy by LarryRuane · Pull Request #28531 · bitcoin/bitcoin · GitHub
3052025-06-12T16:27:15 <jonatack> nice
3062025-06-12T16:27:48 <l0rinc> I noticed that GCC and Clang optimize differently - is it important to benchmark both?
3072025-06-12T16:27:54 *** Guest5082 <Guest5082!~ubuntu@197.237.184.179> has quit IRC (Ping timeout: 245 seconds)
3082025-06-12T16:28:01 <sipa> whatever is used for releases is what matters most
3092025-06-12T16:28:11 <fanquake> GCC 13.3.0
3102025-06-12T16:28:13 <sipa> which is IIRC clang for macOS and gcc for windows and linux
3112025-06-12T16:28:21 <fanquake> clang 18 for macos
3122025-06-12T16:29:30 <l0rinc> the tracking PR for speeding up Initial Block Download, where I have collected the results of the benchmarks I've done is in #32043
3132025-06-12T16:29:32 <corebot`> https://github.com/bitcoin/bitcoin/issues/32043 | [IBD] Tracking PR for speeding up Initial Block Download by l0rinc · Pull Request #32043 · bitcoin/bitcoin · GitHub
3142025-06-12T16:29:43 <jonatack> maybe you are already doing so, but benchmarking with slow internet connections for ibd/p2p might reveal additional issues in how a change under consideration impacts nodes under more hostile conditions like that
3152025-06-12T16:30:39 *** Cory <Cory!~Cory@user/pasha> has quit IRC (Quit: Client closed)
3162025-06-12T16:30:42 <l0rinc> the PI server are also on slightly slower network and lower memory (4 & 8GB)
3172025-06-12T16:30:54 *** Cory <Cory!~Cory@user/pasha> has joined #bitcoin-core-dev
3182025-06-12T16:31:28 <dzxzg> it's challenging to create realistic bad network conditions in a way that is also reproducible
3192025-06-12T16:31:59 <l0rinc> if you think it's important, I can simulate slow connections as well to see what that reveals (the Hetzner servers I have are very fast for normal IBD as well, I guess the nodes it find are probably also from Hetnzer)
3202025-06-12T16:32:36 <jonatack> benchmarking how bitcoind holds up under tough conditions seems valuable (i find it does very well currently, apart from ibd time)
3212025-06-12T16:33:01 <jonatack> (and the stalling/timeout->disconnect logic)
3222025-06-12T16:33:14 <sipa> yeah i think those are very different things to measure
3232025-06-12T16:33:20 <l0rinc> I've also checked swiftsync with very simpmple xor instead of muhash - and locally on my laptop it finished a reindex until 888888 blocks in 29 minutes
3242025-06-12T16:33:31 <sipa> pure computation/disk/io based effects
3252025-06-12T16:33:39 <abubakarsadiq> not sure whether it will help, but having a node with few peers as well? like doing ibd without inbounds, someone complained to me that their ibd was slow.
3262025-06-12T16:33:39 <abubakarsadiq> when I checked it due to having very few peers, basically no inbounds at all.
3272025-06-12T16:33:40 <sipa> vs network block IBD fetching effects
3282025-06-12T16:33:48 <eugenesiegel> I have heard that netem can be used to simulate latency
3292025-06-12T16:34:43 <achow101> sorry, going to try to keep things moving since we have 2 actual topics this week
3302025-06-12T16:34:51 <achow101> we can have further discussion after the meeting, or in an issue on github
3312025-06-12T16:34:52 <l0rinc> k, thanks
3322025-06-12T16:34:57 <achow101> #topic Cluster Mempool WG Update (sdaftuar, sipa)
3332025-06-12T16:35:01 <sipa> not much to report
3342025-06-12T16:35:24 <sipa> next to review remains reorg support in txgraph, #31553
3352025-06-12T16:35:28 <corebot`> https://github.com/bitcoin/bitcoin/issues/31553 | cluster mempool: add TxGraph reorg functionality by sipa · Pull Request #31553 · bitcoin/bitcoin · GitHub
3362025-06-12T16:36:00 <sipa> had some activity on a test-only but non-blocking PR, #30605, which had a review club, and grew a bit in more test improvements since
3372025-06-12T16:36:02 <corebot`> https://github.com/bitcoin/bitcoin/issues/30605 | Cluster linearization: separate tests from tests-of-tests by sipa · Pull Request #30605 · bitcoin/bitcoin · GitHub
3382025-06-12T16:36:35 <sipa> i posted instructions for more intensive benchmarking of the new linearization algorithm in #32545, if people want to participate in that
3392025-06-12T16:36:37 <corebot`> https://github.com/bitcoin/bitcoin/issues/32545 | Replace cluster linearization algorithm with SFL by sipa · Pull Request #32545 · bitcoin/bitcoin · GitHub
3402025-06-12T16:36:46 <sipa> that's it from me
3412025-06-12T16:36:52 <achow101> #topic MuSig2 WG Update (achow101, rkrux)
3422025-06-12T16:37:03 <achow101> Not much to update, #31244 has gotten some review which I've been addressing
3432025-06-12T16:37:07 <corebot`> https://github.com/bitcoin/bitcoin/issues/31244 | descriptors: MuSig2 by achow101 · Pull Request #31244 · bitcoin/bitcoin · GitHub
3442025-06-12T16:37:11 <achow101> The change to the BIP is still waiting to see if anyone has an opinion on the duplicate participants
3452025-06-12T16:37:25 <achow101> #topic QML GUI WG Update (jarolrod, johnny9dev)
3462025-06-12T16:37:26 <sipa> achow101: link to BIP change?
3472025-06-12T16:37:43 <sipa> ah, or that's on the ML?
3482025-06-12T16:37:47 <achow101> sipa: ML
3492025-06-12T16:37:49 <jonatack> https://github.com/bitcoin/bips/pull/1867
3502025-06-12T16:37:51 <johnny9dev> Significant progress was made this week on rebasing the project and moving it to CMake+Qt6. Both hebasto and pinheadmz have PRs now to test and fix issues with the update. bitcoin-core/gui-qml#470 bitcoin-core/gui-qml#472. Both PRs are now able to load up the QML app and get to the main navigation and views.
3512025-06-12T16:37:51 <johnny9dev> For myself, I've been focused on the current Send and Recieve PRs that are in review. I've also been making updates to how address inputs are handled, bitcoin amount label formatting, and address label formatting to get closer to the design spec.
3522025-06-12T16:37:57 <corebot`> https://github.com/bitcoin-core/gui-qml/issues/470 | [WIP] Sync with main repo: CMake + Qt 6 by hebasto · Pull Request #470 · bitcoin-core/gui-qml · GitHub
3532025-06-12T16:37:59 <sipa> achow101: thanks
3542025-06-12T16:38:00 <corebot`> https://github.com/bitcoin-core/gui-qml/issues/472 | Rebase gui-qml on bitcoin/bitcoin, include qt6 and cmake by pinheadmz · Pull Request #472 · bitcoin-core/gui-qml · GitHub
3552025-06-12T16:38:36 *** rkrux <rkrux!~rkrux@user/rkrux> has quit IRC (Quit: Client closed)
3562025-06-12T16:38:37 <hebasto> bitcoin-core/gui-qml#472 is preferred
3572025-06-12T16:38:41 <corebot`> https://github.com/bitcoin-core/gui-qml/issues/472 | Rebase gui-qml on bitcoin/bitcoin, include qt6 and cmake by pinheadmz · Pull Request #472 · bitcoin-core/gui-qml · GitHub
3582025-06-12T16:39:57 <achow101> #topic Script Validation WG Update (fjahr)
3592025-06-12T16:40:01 <fjahr> Nothing really noteworthy this week, more time for the *actual* topics ;)
3602025-06-12T16:40:15 <achow101> #topic Erlay WG Update (sr_gi, gleb)
3612025-06-12T16:41:03 <sr_gi[m]1> Nothing much to report on my end either, I've been off a couple of weeks. Currently picking warnet sims where I left them before leaving. Will report once I'm finished
3622025-06-12T16:41:16 <achow101> #topic Rough poll - how many people use GCC and how many of those do generate code coverage with GCC? (vasild)
3632025-06-12T16:41:25 <vasild> Trying to get an estimate of how many people are using the current GCC-oriented coverage we have in CMake.
3642025-06-12T16:41:55 <eugenesiegel> I use gcc for code coverage
3652025-06-12T16:41:58 <achow101> I use gcc, but I haven't generated coverage with it in ~5 years (or any other coverage really)
3662025-06-12T16:42:08 <sipa> i use GCC for creating benchmarking builds, and clang for fuzzing builds; i haven't used coverage tools for a long time (maybe i should?)
3672025-06-12T16:42:11 *** Guest4319 <Guest4319!~ubuntu@197.237.184.179> has joined #bitcoin-core-dev
3682025-06-12T16:42:27 <fjahr> Only have been using clang for anything cov related since that was what was recommended to me, but definitely not a heavy user lately
3692025-06-12T16:42:34 <eugenesiegel> coverage reports are nice for telling you where the fuzzer is stuck
3702025-06-12T16:43:01 <fanquake> eugenesiegel: are you using GCC for fuzzing? Or just switching to it for coverage?
3712025-06-12T16:44:19 <eugenesiegel> fanquake: I use libfuzzer to fuzz on a VM, and then run the corpus through with gcc coverage on my mac
3722025-06-12T16:44:56 <fanquake> gcc on a mac is clang though? So brew installed GCC?
3732025-06-12T16:44:59 <l0rinc> I usually use test code coverage in cLion which automatically adds the `-DCMAKE_CXX_FLAGS="-fcoverage-mapping -fprofile-instr-generate" -DCMAKE_C_FLAGS="-fcoverage-mapping -fprofile-instr-generate"` options
3742025-06-12T16:45:53 <dergoegge> l0rinc: and then you (or cLion) uses the llvm tools to create the actual report?
3752025-06-12T16:46:55 <l0rinc> there's a built-in report, haven't checked how it generates it
3762025-06-12T16:46:55 <eugenesiegel> fanquake: oh, I didn't know that. I use gcov so I assumed it was gcc
3772025-06-12T16:47:22 <fanquake> What is the output of gcc --version
3782025-06-12T16:47:33 <dergoegge> eugenesiegel: to clarify, your reports look like this: https://maflcko.github.io/b-c-cov/fuzz.coverage/index.html ?
3792025-06-12T16:47:41 <vasild> for the records, the context of this topic is https://github.com/bitcoin/bitcoin/issues/31047
3802025-06-12T16:48:06 <eugenesiegel> fanquake: clang 16
3812025-06-12T16:48:50 <fanquake> Right, so that'll probably be Clang in compat mode
3822025-06-12T16:49:23 <eugenesiegel> dergoegge: no they don't, they look like this https://crypt-iq.github.io/fuzz_coverage_reports/cmpctblock-nyx-cov-06012025/
3832025-06-12T16:49:24 <jonatack> brew says gcc 15.1, but currently for me gcc --version is Apple clang version 17.0.0 (clang-1700.0.13.5)
3842025-06-12T16:49:58 <achow101> I'm fine with replacing the gcc based coverage with clang based. IIRC, the current instructions don't even work?
3852025-06-12T16:50:27 *** Sjors[m]1 <Sjors[m]1!~provooste@2620:6e:a000:ce11::1f> has quit IRC (Quit: Reconnecting)
3862025-06-12T16:50:35 <achow101> already have to switch compilers to use libfuzzer, and to get things like thread-safety warnings
3872025-06-12T16:50:42 *** Sjors[m]1 <Sjors[m]1!~provooste@2620:6e:a000:ce11::1f> has joined #bitcoin-core-dev
3882025-06-12T16:50:55 <marcofleon> I think we have proper clang coverage instructions in the docs?
3892025-06-12T16:50:59 <dergoegge> eugenesiegel: got it! "Generated by llvm-cov", so you're using the clang and the llvm tooling
3902025-06-12T16:51:15 <vasild> achow101: current instructions work for me: https://github.com/bitcoin/bitcoin/issues/31047#issuecomment-2658930755
3912025-06-12T16:51:18 <dergoegge> (that's what it says at the bottom)
3922025-06-12T16:51:21 <Sjors[m]1> #31047
3932025-06-12T16:51:23 <corebot`> https://github.com/bitcoin/bitcoin/issues/31047 | build: RFC Coverage build type · Issue #31047 · bitcoin/bitcoin · GitHub
3942025-06-12T16:51:39 <dzxzg> Isn't it possible to compile with gcc and make a coverage report with lcov?
3952025-06-12T16:52:05 <achow101> vasild: hmm ok. I did try a while ago and it didn't work, but didn't try to debug what went wrong
3962025-06-12T16:52:37 <eugenesiegel> dergoegge: oops. I think I used to use gcc but I guess not anymore
3972025-06-12T16:52:41 <fanquake> dzxzg: it depends on the system, the verison of the tools, might require additional options etc
3982025-06-12T16:53:05 <fanquake> i.e there are breaking changes between lcov 1.6 and 2.0
3992025-06-12T16:53:22 <dergoegge> I think the llvm reports are also just more readable (see my comment here: https://github.com/bitcoin/bitcoin/issues/31047#issuecomment-2396661558)
4002025-06-12T16:53:38 <fanquake> using clang / llvm, unless you're installation is somehow broken, everything will just work in harmony
4012025-06-12T16:53:53 <fanquake> and you get working sanitizers, fuzzing, thread safety etc
4022025-06-12T16:54:08 <fanquake> (hence why all of our important infra is using it)
4032025-06-12T16:54:19 <achow101> i think further discussion can happen in the issue
4042025-06-12T16:54:40 <dergoegge> so no one is using gcc is the conclusion?
4052025-06-12T16:54:47 <sipa> except release builds
4062025-06-12T16:54:50 <sipa> :p
4072025-06-12T16:54:53 <achow101> dergoegge: seems like it
4082025-06-12T16:54:59 <vasild> :)
4092025-06-12T16:55:07 <achow101> #topic [IBD] multi-byte block obfuscation (l0rinc)
4102025-06-12T16:55:09 <dergoegge> :D
4112025-06-12T16:55:56 <l0rinc> I have already talked about this, thanks
4122025-06-12T16:56:17 <achow101> ah, it was just asking for more review?
4132025-06-12T16:56:39 <achow101> Any other topics to discuss?
4142025-06-12T16:56:40 <l0rinc> and I haven't talked about this before, just decided to join IRC, so wanted to give some context :)
4152025-06-12T16:58:08 <achow101> #endmeeting
4162025-06-12T16:58:08 <corebot`> achow101: Meeting ended at 2025-06-12T16:58+0000
4172025-06-12T16:58:09 <corebot`> achow101: Raw log: https://achow101.com/ircmeetings/2025/bitcoin-core-dev.2025-06-12_16_00.log.json
4182025-06-12T16:58:10 <corebot`> achow101: Formatted log: https://achow101.com/ircmeetings/2025/bitcoin-core-dev.2025-06-12_16_00.log.html
4192025-06-12T16:58:11 <corebot`> achow101: Minutes: https://achow101.com/ircmeetings/2025/bitcoin-core-dev.2025-06-12_16_00.html
4202025-06-12T16:58:27 *** Emc99 <Emc99!~Emc99@212.129.86.199> has quit IRC (Quit: Client closed)
4212025-06-12T16:58:33 <achow101> vasild: I think last time I tried lcov was before we merged cmake, so maybe the problem was autotools :)
4222025-06-12T16:59:04 <vasild> ;-)
4232025-06-12T16:59:21 <bitcoin-git> [bitcoin] fanquake opened pull request #32739: tsan: drop Qt wildcard suppressions (master...unwildcard_qt) https://github.com/bitcoin/bitcoin/pull/32739
4242025-06-12T17:01:40 *** l0rinc <l0rinc!~l0rinc@user/l0rinc> has quit IRC (Quit: l0rinc)
4252025-06-12T17:02:18 *** dzxzg <dzxzg!~dzxzg@user/dzxzg> has quit IRC ()
4262025-06-12T17:02:56 <darosior> vasild: most of the time i use gcc for default builds and clang for fuzzing or using sanitizers. I generate source-based coverage with LLVM. I have never used gcov based coverage as presented in our doc.
4272025-06-12T17:03:33 *** Christoph_ <Christoph_!~Christoph@2a02:810d:1399:b700:353f:ec3a:a049:af38> has quit IRC (Quit: Christoph_)
4282025-06-12T17:07:52 *** Guest4319 <Guest4319!~ubuntu@197.237.184.179> has quit IRC (Remote host closed the connection)
4292025-06-12T17:10:33 *** eugenesiegel <eugenesiegel!~eugenesie@user/eugenesiegel> has quit IRC (Quit: Client closed)
4302025-06-12T17:10:58 *** eugenesiegel <eugenesiegel!~eugenesie@user/eugenesiegel> has joined #bitcoin-core-dev
4312025-06-12T17:11:46 *** cotsuka <cotsuka!~cotsuka@user/cotsuka> has quit IRC (Remote host closed the connection)
4322025-06-12T17:13:17 *** cotsuka <cotsuka!~cotsuka@user/cotsuka> has joined #bitcoin-core-dev
4332025-06-12T17:19:26 *** eugenesiegel <eugenesiegel!~eugenesie@user/eugenesiegel> has quit IRC (Quit: Client closed)
4342025-06-12T17:25:53 *** l0rinc <l0rinc!~l0rinc@user/l0rinc> has joined #bitcoin-core-dev
4352025-06-12T17:32:59 *** Talkless <Talkless!~Talkless@138.199.6.197> has joined #bitcoin-core-dev
4362025-06-12T17:55:05 *** jonatack <jonatack!~jonatack@user/jonatack> has quit IRC (Ping timeout: 265 seconds)
4372025-06-12T18:00:51 <vasild> darosior: looks like one more confirmation of "< dergoegge> so no one is using gcc is the conclusion?" :)
4382025-06-12T18:08:03 *** l0rinc <l0rinc!~l0rinc@user/l0rinc> has quit IRC (Quit: l0rinc)
4392025-06-12T18:14:44 *** Cory93 <Cory93!~Cory@user/pasha> has joined #bitcoin-core-dev
4402025-06-12T18:18:37 *** jonatack <jonatack!~jonatack@user/jonatack> has joined #bitcoin-core-dev
4412025-06-12T18:18:51 *** Cory <Cory!~Cory@user/pasha> has quit IRC (Ping timeout: 272 seconds)
4422025-06-12T18:21:20 <hodlinator> vasild: I've used GCC mainly for getting benchmarks resembling release builds, otherwise I'm happy to use Clang. Haven't really used coverage that much yet.
4432025-06-12T18:28:02 *** purpleKarrot <purpleKarrot!~purpleKar@user/purpleKarrot> has quit IRC (Quit: purpleKarrot)
4442025-06-12T18:38:21 <fanquake> CoreCheck is using it, however speaking to Max, he was already looking into migrating to LLVM/Clang
4452025-06-12T18:55:20 *** VonNaturAustreVe <VonNaturAustreVe!~natur@user/vonnaturaustreve> has quit IRC (Ping timeout: 260 seconds)
4462025-06-12T19:15:14 *** purpleKarrot <purpleKarrot!~purpleKar@user/purpleKarrot> has joined #bitcoin-core-dev
4472025-06-12T19:19:28 *** Cory15 <Cory15!~Cory93@user/pasha> has joined #bitcoin-core-dev
4482025-06-12T19:23:27 *** Cory93 <Cory93!~Cory@user/pasha> has quit IRC (Ping timeout: 272 seconds)
4492025-06-12T19:24:00 *** Talkless <Talkless!~Talkless@138.199.6.197> has quit IRC (Quit: Konversation terminated!)
4502025-06-12T19:31:59 *** dyscope <dyscope!~dyscope@91.218.89.24> has joined #bitcoin-core-dev
4512025-06-12T19:32:05 *** dyscope_ <dyscope_!~dyscope@91.218.89.24> has joined #bitcoin-core-dev
4522025-06-12T19:32:43 *** dyscope <dyscope!~dyscope@91.218.89.24> has quit IRC (Remote host closed the connection)
4532025-06-12T19:32:43 *** dyscope_ <dyscope_!~dyscope@91.218.89.24> has quit IRC (Remote host closed the connection)
4542025-06-12T19:32:56 *** dyscope <dyscope!~dyscope@91.218.89.24> has joined #bitcoin-core-dev
4552025-06-12T19:36:31 *** dyscope <dyscope!~dyscope@91.218.89.24> has quit IRC (Remote host closed the connection)
4562025-06-12T19:36:45 *** dyscope <dyscope!~dyscope@91.218.89.24> has joined #bitcoin-core-dev
4572025-06-12T19:37:26 *** VonNaturAustreVe <VonNaturAustreVe!~natur@user/vonnaturaustreve> has joined #bitcoin-core-dev
4582025-06-12T19:43:49 *** VonNaturAustreVe <VonNaturAustreVe!~natur@user/vonnaturaustreve> has quit IRC (Ping timeout: 248 seconds)
4592025-06-12T19:55:09 *** robobub <robobub!uid248673@id-248673.uxbridge.irccloud.com> has quit IRC (Quit: Connection closed for inactivity)
4602025-06-12T20:05:13 *** bugs_ <bugs_!~bugs@user/bugs/x-5128603> has quit IRC (Quit: Leaving)
4612025-06-12T20:16:42 *** purpleKarrot <purpleKarrot!~purpleKar@user/purpleKarrot> has quit IRC (Quit: purpleKarrot)
4622025-06-12T20:20:12 <bitcoin-git> [bitcoin] danielabrozzoni opened pull request #32740: refactor: Optimizations & simplifications following #25717 (master...upforgrabs/25968) https://github.com/bitcoin/bitcoin/pull/32740
4632025-06-12T20:24:29 *** dyscope <dyscope!~dyscope@91.218.89.24> has quit IRC (Quit: Leaving)
4642025-06-12T20:26:51 *** Guest22 <Guest22!~Guest22@199.19.145.27> has joined #bitcoin-core-dev
4652025-06-12T20:28:24 *** Guest22 <Guest22!~Guest22@199.19.145.27> has quit IRC (Client Quit)
4662025-06-12T20:54:09 *** jespada <jespada!~jespada@r179-25-148-209.dialup.adsl.anteldata.net.uy> has quit IRC (Ping timeout: 260 seconds)
4672025-06-12T20:56:04 *** jespada <jespada!~jespada@r179-25-148-209.dialup.adsl.anteldata.net.uy> has joined #bitcoin-core-dev
4682025-06-12T21:05:57 *** jonatack <jonatack!~jonatack@user/jonatack> has quit IRC (Ping timeout: 248 seconds)
4692025-06-12T21:19:18 *** kevkevin <kevkevin!~kevkevin@209.242.39.30> has quit IRC (Remote host closed the connection)
4702025-06-12T21:51:10 <bitcoin-git> [bitcoin] waketraindev opened pull request #32741: rpc: add optional nodeid param to filter getpeerinfo (master...2025-06-getpeerinfo-filterid) https://github.com/bitcoin/bitcoin/pull/32741
4712025-06-12T21:56:07 *** conman <conman!~con@180-150-21-3.b49615.mel.static.aussiebb.net> has quit IRC (Remote host closed the connection)
4722025-06-12T22:01:26 *** kevkevin <kevkevin!~kevkevin@2607:fb90:9b24:d22b:e9da:8ef6:2374:2a08> has joined #bitcoin-core-dev
4732025-06-12T22:07:50 *** conman <conman!~con@180-150-21-3.b49615.mel.static.aussiebb.net> has joined #bitcoin-core-dev
4742025-06-12T22:21:43 *** jonatack <jonatack!~jonatack@user/jonatack> has joined #bitcoin-core-dev
4752025-06-12T22:23:23 *** kevkevin <kevkevin!~kevkevin@2607:fb90:9b24:d22b:e9da:8ef6:2374:2a08> has quit IRC (Remote host closed the connection)
4762025-06-12T22:53:14 *** PaperSword <PaperSword!~Thunderbi@securemail.qrsnap.io> has quit IRC (Quit: PaperSword)
4772025-06-12T22:54:03 *** kevkevin <kevkevin!~kevkevin@2607:fb90:9b24:d22b:e9da:8ef6:2374:2a08> has joined #bitcoin-core-dev
4782025-06-12T22:54:11 *** jonatack <jonatack!~jonatack@user/jonatack> has quit IRC (Ping timeout: 272 seconds)
4792025-06-12T23:01:29 <bitcoin-git> [bitcoin] achow101 pushed 6 commits to master: https://github.com/bitcoin/bitcoin/compare/5757de4ddd37...19765dca197a
4802025-06-12T23:01:30 <bitcoin-git> bitcoin/master 331a25c furszy: test: indexes, avoid creating threads when sync runs synchronously
4812025-06-12T23:01:30 <bitcoin-git> bitcoin/master 0a24870 Ryan Ofsky: indexes, refactor: Stop requiring CBlockIndex type to call IsBIP30Unspenda...
4822025-06-12T23:01:31 <bitcoin-git> bitcoin/master 6f1392c Ryan Ofsky: indexes, refactor: Remove remaining CBlockIndex* uses in index Rewind meth...
4832025-06-12T23:01:32 <bitcoin-git> [bitcoin] achow101 merged pull request #32694: index: move disk read lookups to base class (master...2025_indexes_remove_CBlockIndex_access) https://github.com/bitcoin/bitcoin/pull/32694
4842025-06-12T23:12:26 *** jonatack <jonatack!~jonatack@user/jonatack> has joined #bitcoin-core-dev
4852025-06-12T23:38:15 *** hernanmarino <hernanmarino!~hernanmar@2800:2330:2800:14a:2ac5:5534:eadb:be0e> has joined #bitcoin-core-dev
4862025-06-12T23:44:57 *** hernanmarino <hernanmarino!~hernanmar@2800:2330:2800:14a:2ac5:5534:eadb:be0e> has quit IRC (Ping timeout: 268 seconds)
4872025-06-12T23:47:20 *** hernanmarino <hernanmarino!~hernanmar@181.85.47.153> has joined #bitcoin-core-dev