12025-08-12T00:13:10 *** PaperSword <PaperSword!~Thunderbi@securemail.qrsnap.io> has quit IRC (Quit: PaperSword)
22025-08-12T00:25:06 *** conman <conman!~con@180-150-21-3.b49615.mel.static.aussiebb.net> has quit IRC (Remote host closed the connection)
32025-08-12T00:33:28 *** jon_atack <jon_atack!~jonatack@user/jonatack> has joined #bitcoin-core-dev
42025-08-12T00:34:58 *** jonatack <jonatack!~jonatack@user/jonatack> has quit IRC (Ping timeout: 240 seconds)
52025-08-12T00:39:31 *** jonatack <jonatack!~jonatack@user/jonatack> has joined #bitcoin-core-dev
62025-08-12T00:41:44 *** jon_atack <jon_atack!~jonatack@user/jonatack> has quit IRC (Ping timeout: 252 seconds)
72025-08-12T00:45:57 *** jerryf <jerryf!~jerryf@user/jerryf> has quit IRC (Ping timeout: 240 seconds)
82025-08-12T00:47:24 *** jerryf <jerryf!~jerryf@user/jerryf> has joined #bitcoin-core-dev
92025-08-12T00:58:08 *** jon_atack <jon_atack!~jonatack@user/jonatack> has joined #bitcoin-core-dev
102025-08-12T00:59:46 *** jonatack <jonatack!~jonatack@user/jonatack> has quit IRC (Ping timeout: 255 seconds)
112025-08-12T01:10:23 *** _durandal <_durandal!~durandal@148.252.129.148> has joined #bitcoin-core-dev
122025-08-12T01:10:58 *** conman <conman!~con@180-150-21-3.b49615.mel.static.aussiebb.net> has joined #bitcoin-core-dev
132025-08-12T01:13:28 *** durandal_ <durandal_!~durandal@148.252.146.89> has quit IRC (Ping timeout: 240 seconds)
142025-08-12T01:19:43 *** zeropoint <zeropoint!~alex@45-28-139-114.lightspeed.sntcca.sbcglobal.net> has quit IRC (Quit: leaving)
152025-08-12T01:20:22 *** jonatack <jonatack!~jonatack@user/jonatack> has joined #bitcoin-core-dev
162025-08-12T01:22:30 *** jon_atack <jon_atack!~jonatack@user/jonatack> has quit IRC (Ping timeout: 252 seconds)
172025-08-12T01:44:43 *** l0rinc <l0rinc!~l0rinc@user/l0rinc> has quit IRC (Quit: l0rinc)
182025-08-12T01:52:18 <bitcoin-git> [bitcoin] jderibamar opened pull request #33174: Add startup log message for initialization confirmation (master...improve-test-docs) https://github.com/bitcoin/bitcoin/pull/33174
192025-08-12T02:01:01 *** Guest1 <Guest1!~Guest1@2601:603:1100:48f0:35aa:86c4:7a14:84d2> has joined #bitcoin-core-dev
202025-08-12T02:08:24 *** Guest1 <Guest1!~Guest1@2601:603:1100:48f0:35aa:86c4:7a14:84d2> has quit IRC (Quit: Client closed)
212025-08-12T02:08:58 *** joetor5 <joetor5!~Thunderbi@user/joetor5> has joined #bitcoin-core-dev
222025-08-12T02:25:04 *** bitdex <bitdex!~bitdex@gateway/tor-sasl/bitdex> has joined #bitcoin-core-dev
232025-08-12T02:29:05 *** twistedline <twistedline!~bitcoin@185.193.125.44> has quit IRC ()
242025-08-12T02:30:34 *** bitcoinlover <bitcoinlover!~hacker4we@user/hacker4web3bitco> has joined #bitcoin-core-dev
252025-08-12T02:34:17 *** twistedline <twistedline!~bitcoin@185.193.125.44> has joined #bitcoin-core-dev
262025-08-12T03:04:43 *** jon_atack <jon_atack!~jonatack@user/jonatack> has joined #bitcoin-core-dev
272025-08-12T03:06:40 *** jonatack <jonatack!~jonatack@user/jonatack> has quit IRC (Ping timeout: 255 seconds)
282025-08-12T03:16:06 *** jon_atack <jon_atack!~jonatack@user/jonatack> has quit IRC (Ping timeout: 252 seconds)
292025-08-12T03:18:09 *** joetor5 <joetor5!~Thunderbi@user/joetor5> has quit IRC (Quit: joetor5)
302025-08-12T03:39:18 *** l0rinc <l0rinc!~l0rinc@user/l0rinc> has joined #bitcoin-core-dev
312025-08-12T04:01:01 *** cmirror <cmirror!~cmirror@4.53.92.114> has quit IRC (Remote host closed the connection)
322025-08-12T04:01:32 *** cmirror <cmirror!~cmirror@4.53.92.114> has joined #bitcoin-core-dev
332025-08-12T04:29:24 <bitcoin-git> [bitcoin] Ataraxia009 closed pull request #33126: Removing Bitcoin core text where unnecessary (master...multi-client-support) https://github.com/bitcoin/bitcoin/pull/33126
342025-08-12T05:06:50 <bitcoin-git> [bitcoin] Ataraxia009 closed pull request #33127: Adding alert for failure to prevent dead-end user crash (master...launch-crash-failure) https://github.com/bitcoin/bitcoin/pull/33127
352025-08-12T05:45:52 *** bitcoinlover <bitcoinlover!~hacker4we@user/hacker4web3bitco> has quit IRC (Ping timeout: 260 seconds)
362025-08-12T06:00:15 *** Christoph_ <Christoph_!~Christoph@2a02:810d:1399:b700:f468:5c34:5dbd:3a55> has joined #bitcoin-core-dev
372025-08-12T06:03:58 *** l0rinc <l0rinc!~l0rinc@user/l0rinc> has quit IRC (Quit: l0rinc)
382025-08-12T06:14:23 *** BlueMattMtrxBot <BlueMattMtrxBot!~bluemattm@2620:6e:a000:ce11::44> has quit IRC (Server closed connection)
392025-08-12T06:14:42 *** BlueMattMtrxBot <BlueMattMtrxBot!~bluemattm@2620:6e:a000:ce11::44> has joined #bitcoin-core-dev
402025-08-12T06:21:17 *** kevkevin <kevkevin!~kevkevin@209.242.39.30> has quit IRC (Remote host closed the connection)
412025-08-12T06:31:54 *** Guest19 <Guest19!~Guest19@196.189.224.32> has joined #bitcoin-core-dev
422025-08-12T06:32:00 *** WizJin_ <WizJin_!~Wizzy@2402:a00:184:8354:3ccc:e206:c376:1b02> has joined #bitcoin-core-dev
432025-08-12T06:32:05 *** WizJin_ <WizJin_!~Wizzy@2402:a00:184:8354:3ccc:e206:c376:1b02> has quit IRC (Remote host closed the connection)
442025-08-12T06:32:23 *** WizJin_ <WizJin_!~Wizzy@2402:a00:184:8354:3ccc:e206:c376:1b02> has joined #bitcoin-core-dev
452025-08-12T06:33:17 *** Guest19 <Guest19!~Guest19@196.189.224.32> has quit IRC (Client Quit)
462025-08-12T06:34:53 *** WizJin_ <WizJin_!~Wizzy@2402:a00:184:8354:3ccc:e206:c376:1b02> has quit IRC (Client Quit)
472025-08-12T06:36:51 *** kevkevin <kevkevin!~kevkevin@209.242.39.30> has joined #bitcoin-core-dev
482025-08-12T06:37:46 *** Guest95 <Guest95!~Guest95@49.37.157.100> has joined #bitcoin-core-dev
492025-08-12T06:38:08 *** Guest95 <Guest95!~Guest95@49.37.157.100> has left #bitcoin-core-dev
502025-08-12T06:41:52 *** kevkevin <kevkevin!~kevkevin@209.242.39.30> has quit IRC (Ping timeout: 260 seconds)
512025-08-12T06:55:24 *** Guest67 <Guest67!~Guest15@2600:8800:568c:3500:e133:21de:896c:62c7> has joined #bitcoin-core-dev
522025-08-12T06:55:35 *** Guest30 <Guest30!~Guest30@2001:5a8:463e:e00:5d73:2e9b:11b9:efcd> has joined #bitcoin-core-dev
532025-08-12T06:56:43 *** Guest67 <Guest67!~Guest15@2600:8800:568c:3500:e133:21de:896c:62c7> has quit IRC (Client Quit)
542025-08-12T07:05:03 *** WizJin <WizJin!~Wizzy@user/WizJin> has joined #bitcoin-core-dev
552025-08-12T07:06:58 *** Guest30 <Guest30!~Guest30@2001:5a8:463e:e00:5d73:2e9b:11b9:efcd> has quit IRC (Quit: Client closed)
562025-08-12T07:08:31 *** kevkevin <kevkevin!~kevkevin@209.242.39.30> has joined #bitcoin-core-dev
572025-08-12T07:13:16 *** kevkevin <kevkevin!~kevkevin@209.242.39.30> has quit IRC (Ping timeout: 255 seconds)
582025-08-12T07:14:17 <bitcoin-git> [bitcoin] rejected-l opened pull request #33175: ci: bump actions/checkout to v5 (master...master) https://github.com/bitcoin/bitcoin/pull/33175
592025-08-12T07:15:42 <bitcoin-git> [bitcoin] fanquake closed pull request #33175: ci: bump actions/checkout to v5 (master...master) https://github.com/bitcoin/bitcoin/pull/33175
602025-08-12T07:16:28 <fanquake> must be the new drive-by trend
612025-08-12T07:20:35 *** f321x <f321x!~f321x@user/f321x> has joined #bitcoin-core-dev
622025-08-12T07:23:17 *** f321x <f321x!~f321x@user/f321x> has quit IRC (Remote host closed the connection)
632025-08-12T07:26:31 *** f321x <f321x!~f321x@user/f321x> has joined #bitcoin-core-dev
642025-08-12T07:27:32 *** Christoph_ <Christoph_!~Christoph@2a02:810d:1399:b700:f468:5c34:5dbd:3a55> has quit IRC (Quit: Christoph_)
652025-08-12T07:35:24 *** dviola <dviola!~diego@user/dviola> has quit IRC (Quit: WeeChat 4.7.0)
662025-08-12T07:41:16 *** robszarka <robszarka!~szarka@2603:3003:4eac:100:128:bb2f:fe80:67d6> has joined #bitcoin-core-dev
672025-08-12T07:44:52 *** szarka <szarka!~szarka@2603:3003:4eac:100:cc06:2eb7:47a8:fb86> has quit IRC (Ping timeout: 260 seconds)
682025-08-12T07:52:59 *** bitcoinlover <bitcoinlover!~hacker4we@user/hacker4web3bitco> has joined #bitcoin-core-dev
692025-08-12T08:00:08 *** kevkevin <kevkevin!~kevkevin@209.242.39.30> has joined #bitcoin-core-dev
702025-08-12T08:00:20 *** Guyver2 <Guyver2!~Guyver@77-174-98-73.fixed.kpn.net> has joined #bitcoin-core-dev
712025-08-12T08:52:40 *** Christoph_ <Christoph_!~Christoph@2a02:810d:1399:b700:f468:5c34:5dbd:3a55> has joined #bitcoin-core-dev
722025-08-12T09:04:46 *** kevkevin <kevkevin!~kevkevin@209.242.39.30> has quit IRC (Ping timeout: 276 seconds)
732025-08-12T09:19:01 *** robszarka <robszarka!~szarka@2603:3003:4eac:100:128:bb2f:fe80:67d6> has quit IRC (Quit: Leaving)
742025-08-12T09:19:23 *** szarka <szarka!~szarka@2603:3003:4eac:100:128:bb2f:fe80:67d6> has joined #bitcoin-core-dev
752025-08-12T09:28:06 *** kevkevin <kevkevin!~kevkevin@209.242.39.30> has joined #bitcoin-core-dev
762025-08-12T09:29:54 <bitcoin-git> [bitcoin] fanquake closed pull request #33174: Add startup log message for initialization confirmation (master...improve-test-docs) https://github.com/bitcoin/bitcoin/pull/33174
772025-08-12T09:31:43 *** Guyver2 <Guyver2!~Guyver@77-174-98-73.fixed.kpn.net> has left #bitcoin-core-dev (Closing Window)
782025-08-12T09:43:45 *** laanwj <laanwj!~laanwj@user/laanwj> has quit IRC (Server closed connection)
792025-08-12T09:44:07 *** laanwj <laanwj!~laanwj@user/laanwj> has joined #bitcoin-core-dev
802025-08-12T10:10:18 *** shwouchk <shwouchk!~shwouchk@user/shwouchk> has quit IRC (Read error: Connection reset by peer)
812025-08-12T10:10:47 *** shwouchk <shwouchk!~shwouchk@user/shwouchk> has joined #bitcoin-core-dev
822025-08-12T10:16:03 *** jerryf <jerryf!~jerryf@user/jerryf> has quit IRC (Remote host closed the connection)
832025-08-12T10:16:25 *** jerryf <jerryf!~jerryf@user/jerryf> has joined #bitcoin-core-dev
842025-08-12T10:32:52 *** kevkevin <kevkevin!~kevkevin@209.242.39.30> has quit IRC (Ping timeout: 260 seconds)
852025-08-12T11:02:16 *** kevkevin <kevkevin!~kevkevin@209.242.39.30> has joined #bitcoin-core-dev
862025-08-12T11:26:24 *** uasf <uasf!~uasf@2604:a880:2:d0::1bda:1001> has quit IRC (Server closed connection)
872025-08-12T11:27:40 *** uasf <uasf!~uasf@2604:a880:2:d0::1bda:1001> has joined #bitcoin-core-dev
882025-08-12T11:38:57 *** joetor5 <joetor5!~Thunderbi@user/joetor5> has joined #bitcoin-core-dev
892025-08-12T11:56:45 *** aleggg <aleggg!~aleggg@187.34.168.103> has joined #bitcoin-core-dev
902025-08-12T12:17:03 *** jonatack <jonatack!~jonatack@user/jonatack> has joined #bitcoin-core-dev
912025-08-12T12:17:52 *** warren <warren!~warren@fedora/wombat/warren> has quit IRC (Server closed connection)
922025-08-12T12:18:06 *** warren <warren!~warren@fedora/wombat/warren> has joined #bitcoin-core-dev
932025-08-12T12:32:52 *** jespada <jespada!~jespada@2800:a4:22e2:6200:858b:10bb:57f7:c59> has joined #bitcoin-core-dev
942025-08-12T12:54:27 *** jon_atack <jon_atack!~jonatack@user/jonatack> has joined #bitcoin-core-dev
952025-08-12T12:54:57 *** jonatack <jonatack!~jonatack@user/jonatack> has quit IRC (Ping timeout: 252 seconds)
962025-08-12T12:59:39 *** jonatack <jonatack!~jonatack@user/jonatack> has joined #bitcoin-core-dev
972025-08-12T13:02:45 *** jon_atack <jon_atack!~jonatack@user/jonatack> has quit IRC (Ping timeout: 252 seconds)
982025-08-12T13:48:08 <bitcoin-git> [bitcoin] fanquake opened pull request #33178: guix: increase maximum allowed (runtime) GCC to 7 (master...sym_check_gcc_7) https://github.com/bitcoin/bitcoin/pull/33178
992025-08-12T13:52:57 *** virtu <virtu!~virtu@vmd108895.contaboserver.net> has quit IRC (Ping timeout: 260 seconds)
1002025-08-12T13:53:29 *** virtu <virtu!~virtu@vmd108895.contaboserver.net> has joined #bitcoin-core-dev
1012025-08-12T14:00:48 *** theStack <theStack!~theStack@95.179.145.232> has quit IRC (Server closed connection)
1022025-08-12T14:10:35 *** joetor5 <joetor5!~Thunderbi@user/joetor5> has quit IRC (Quit: joetor5)
1032025-08-12T14:14:11 <hebasto> https://usercontent.irccloud-cdn.com/file/iADb3YpB/image.png
1042025-08-12T14:14:31 <sipa> hebasto: awesome!
1052025-08-12T14:14:40 <hebasto> gh glitch?
1062025-08-12T14:15:13 <sipa> the PRs are still there if you go to #12345
1072025-08-12T14:15:18 <corebot> https://github.com/bitcoin/bitcoin/issues/12345 | Asymmetric encryption stubs. by Rutkouski · Pull Request #12345 · bitcoin/bitcoin · GitHub
1082025-08-12T14:15:24 <sipa> just not listed
1092025-08-12T14:15:31 <sipa> in the overview
1102025-08-12T14:17:38 <glozow> finally, we did it guys, we're free!
1112025-08-12T14:23:27 <bitcoin-git> [bitcoin] glozow pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/273e600e65c2...ec484bd5ce43
1122025-08-12T14:23:28 <bitcoin-git> bitcoin/master db32280 willcl-ark: util: detect and warn when using exFAT on macOS
1132025-08-12T14:23:28 <bitcoin-git> bitcoin/master ec484bd merge-script: Merge bitcoin/bitcoin#31453: util: detect and warn when using exFAT on Mac...
1142025-08-12T14:23:29 <bitcoin-git> [bitcoin] glozow merged pull request #31453: util: detect and warn when using exFAT on MacOS (master...macos-exfat) https://github.com/bitcoin/bitcoin/pull/31453
1152025-08-12T14:24:06 *** Guest25 <Guest25!~Guest25@199.48.247.42> has joined #bitcoin-core-dev
1162025-08-12T14:24:07 *** Guest25 <Guest25!~Guest25@199.48.247.42> has quit IRC (Client Quit)
1172025-08-12T14:36:56 *** jon_atack <jon_atack!~jonatack@user/jonatack> has joined #bitcoin-core-dev
1182025-08-12T14:38:18 *** jonatack <jonatack!~jonatack@user/jonatack> has quit IRC (Ping timeout: 245 seconds)
1192025-08-12T14:45:55 *** janb84 <janb84!~janb84@user/janb84> has joined #bitcoin-core-dev
1202025-08-12T14:48:16 *** jonatack <jonatack!~jonatack@user/jonatack> has joined #bitcoin-core-dev
1212025-08-12T14:50:25 *** jon_atack <jon_atack!~jonatack@user/jonatack> has quit IRC (Ping timeout: 260 seconds)
1222025-08-12T14:53:32 <bitcoin-git> [bitcoin] Sjors opened pull request #33179: doc: update wallet build instruction (master...2025/08/wallet) https://github.com/bitcoin/bitcoin/pull/33179
1232025-08-12T14:59:05 *** jon_atack <jon_atack!~jonatack@user/jonatack> has joined #bitcoin-core-dev
1242025-08-12T14:59:45 *** jonatack <jonatack!~jonatack@user/jonatack> has quit IRC (Ping timeout: 260 seconds)
1252025-08-12T15:11:20 *** jonatack <jonatack!~jonatack@user/jonatack> has joined #bitcoin-core-dev
1262025-08-12T15:13:25 *** jon_atack <jon_atack!~jonatack@user/jonatack> has quit IRC (Ping timeout: 255 seconds)
1272025-08-12T15:21:40 *** zeropoint <zeropoint!~alex@45-28-139-114.lightspeed.sntcca.sbcglobal.net> has joined #bitcoin-core-dev
1282025-08-12T15:30:53 *** jon_atack <jon_atack!~jonatack@user/jonatack> has joined #bitcoin-core-dev
1292025-08-12T15:31:38 *** visiteur <visiteur!~visiteur@77.119.165.69.wireless.dyn.drei.com> has joined #bitcoin-core-dev
1302025-08-12T15:32:05 *** zeropoint <zeropoint!~alex@45-28-139-114.lightspeed.sntcca.sbcglobal.net> has quit IRC (Ping timeout: 248 seconds)
1312025-08-12T15:32:37 *** jonatack <jonatack!~jonatack@user/jonatack> has quit IRC (Ping timeout: 248 seconds)
1322025-08-12T15:33:12 *** l0rinc <l0rinc!~l0rinc@user/l0rinc> has joined #bitcoin-core-dev
1332025-08-12T15:35:08 *** jonatack <jonatack!~jonatack@user/jonatack> has joined #bitcoin-core-dev
1342025-08-12T15:37:25 *** jon_atack <jon_atack!~jonatack@user/jonatack> has quit IRC (Ping timeout: 248 seconds)
1352025-08-12T15:54:27 *** bugs_ <bugs_!~bugs@user/bugs/x-5128603> has joined #bitcoin-core-dev
1362025-08-12T15:54:42 *** visiteur <visiteur!~visiteur@77.119.165.69.wireless.dyn.drei.com> has quit IRC (K-Lined)
1372025-08-12T15:59:31 *** LUKASZICHO <LUKASZICHO!~LUKASZICH@adsl-dyn174.78-99-33.t-com.sk> has joined #bitcoin-core-dev
1382025-08-12T15:59:34 *** l0rinc <l0rinc!~l0rinc@user/l0rinc> has quit IRC (Quit: l0rinc)
1392025-08-12T16:00:22 *** LUKASZICHO <LUKASZICHO!~LUKASZICH@adsl-dyn174.78-99-33.t-com.sk> has quit IRC (Client Quit)
1402025-08-12T16:01:00 *** l0rinc <l0rinc!~l0rinc@user/l0rinc> has joined #bitcoin-core-dev
1412025-08-12T16:01:52 *** Christoph_ <Christoph_!~Christoph@2a02:810d:1399:b700:f468:5c34:5dbd:3a55> has quit IRC (Ping timeout: 260 seconds)
1422025-08-12T16:03:53 *** bitcoinlover <bitcoinlover!~hacker4we@user/hacker4web3bitco> has quit IRC (Ping timeout: 252 seconds)
1432025-08-12T16:04:11 *** Christoph_ <Christoph_!~Christoph@2a02:810d:1399:b700:f468:5c34:5dbd:3a55> has joined #bitcoin-core-dev
1442025-08-12T16:16:16 *** ghost43_ <ghost43_!~ghost43@gateway/tor-sasl/ghost43> has joined #bitcoin-core-dev
1452025-08-12T16:16:17 *** ghost43 <ghost43!~ghost43@gateway/tor-sasl/ghost43> has quit IRC (Ping timeout: 240 seconds)
1462025-08-12T16:26:47 *** stringintech <stringintech!~stringint@5.120.141.31> has joined #bitcoin-core-dev
1472025-08-12T16:27:01 *** jespada <jespada!~jespada@2800:a4:22e2:6200:858b:10bb:57f7:c59> has quit IRC (Ping timeout: 248 seconds)
1482025-08-12T16:28:17 *** l0rinc <l0rinc!~l0rinc@user/l0rinc> has quit IRC (Quit: l0rinc)
1492025-08-12T16:28:46 <Sjors[m]1> I'd like to propose #31802 for the v30 milestone, if only to discuss if it needs to be punted to the next release again.
1502025-08-12T16:28:48 <corebot> https://github.com/bitcoin/bitcoin/issues/31802 | Add bitcoin-{node,gui} to release binaries for IPC by Sjors · Pull Request #31802 · bitcoin/bitcoin · GitHub
1512025-08-12T16:30:28 *** jespada <jespada!~jespada@2800:a4:2276:cf00:8551:f64b:3496:fa1b> has joined #bitcoin-core-dev
1522025-08-12T16:34:55 *** purpleKarrot <purpleKarrot!~purpleKar@user/purpleKarrot> has joined #bitcoin-core-dev
1532025-08-12T16:42:10 *** stringintech <stringintech!~stringint@user/stringintech> has quit IRC (Quit: Client closed)
1542025-08-12T16:43:19 *** theStack <theStack!~theStack@95.179.145.232> has joined #bitcoin-core-dev
1552025-08-12T16:43:53 *** stringintech <stringintech!~stringint@user/stringintech> has joined #bitcoin-core-dev
1562025-08-12T16:53:30 *** jon_atack <jon_atack!~jonatack@user/jonatack> has joined #bitcoin-core-dev
1572025-08-12T16:55:36 *** jonatack <jonatack!~jonatack@user/jonatack> has quit IRC (Ping timeout: 252 seconds)
1582025-08-12T16:56:24 *** jespada <jespada!~jespada@2800:a4:2276:cf00:8551:f64b:3496:fa1b> has quit IRC (Ping timeout: 252 seconds)
1592025-08-12T16:56:49 *** jespada <jespada!~jespada@2800:a4:2276:cf00:f556:c198:b7ff:e1b2> has joined #bitcoin-core-dev
1602025-08-12T16:58:00 *** josie <josie!~josibake@suhail.uberspace.de> has quit IRC (Server closed connection)
1612025-08-12T16:58:14 *** josie <josie!~josibake@suhail.uberspace.de> has joined #bitcoin-core-dev
1622025-08-12T16:58:25 <stringintech> Reviewing IBD staller detection logic; the condition for setting the staller variable in FindNextBlocks() differs from the condition for setting m_stalling_since for that staller after detection. The first condition checks if we've reached the end of the IBD window and found no blocks to download from the peer, but the second checks if there are
1632025-08-12T16:58:25 <stringintech> any in-flight requests from that peer (which could include block requests from earlier). I wondered whether this difference is intentional. (I can think of a scenario where no in-flight requests are resolved from any peer and we wouldn't trigger the timeout for any peer until the in-flight requests are cleared)
1642025-08-12T17:02:43 *** stringintech10 <stringintech10!~stringint@user/stringintech> has joined #bitcoin-core-dev
1652025-08-12T17:03:20 *** f321x <f321x!~f321x@user/f321x> has quit IRC (Quit: f321x)
1662025-08-12T17:03:56 *** stringintech10 <stringintech10!~stringint@user/stringintech> has quit IRC (Client Quit)
1672025-08-12T17:04:14 *** stringintech73 <stringintech73!~stringint@user/stringintech> has joined #bitcoin-core-dev
1682025-08-12T17:06:09 *** stringintech <stringintech!~stringint@user/stringintech> has quit IRC (Ping timeout: 250 seconds)
1692025-08-12T17:06:15 *** stringintech73 <stringintech73!~stringint@user/stringintech> has quit IRC (Client Quit)
1702025-08-12T17:06:38 *** stringintech <stringintech!~stringint@user/stringintech> has joined #bitcoin-core-dev
1712025-08-12T17:29:54 *** jonatack <jonatack!~jonatack@user/jonatack> has joined #bitcoin-core-dev
1722025-08-12T17:31:01 <sipa> stringintech: hmm
1732025-08-12T17:31:45 *** zeropoint <zeropoint!~alex@45-28-139-114.lightspeed.sntcca.sbcglobal.net> has joined #bitcoin-core-dev
1742025-08-12T17:32:25 *** jon_atack <jon_atack!~jonatack@user/jonatack> has quit IRC (Ping timeout: 276 seconds)
1752025-08-12T17:32:44 <sipa> i'm probably the author of that code, but i don't recall that being intentional
1762025-08-12T17:32:52 <sipa> it's also possible it has been changed since i wrote it
1772025-08-12T17:38:35 <stringintech> sipa: Thanks! Wouldn't it make more sense if the second one would check for vToDownload.empty() instead of state.vBlocksInFlight.empty() since we could have requested a block from this peer but we could not because of the staller?
1782025-08-12T17:46:27 *** WizJin_ <WizJin_!~Wizzy@2402:a00:184:8354:55f:6a75:8aa4:5e93> has joined #bitcoin-core-dev
1792025-08-12T17:50:22 *** WizJin <WizJin!~Wizzy@user/WizJin> has quit IRC (Ping timeout: 260 seconds)
1802025-08-12T17:52:57 *** stringintech <stringintech!~stringint@user/stringintech> has quit IRC (Ping timeout: 250 seconds)
1812025-08-12T17:54:59 *** stringintech <stringintech!~stringint@user/stringintech> has joined #bitcoin-core-dev
1822025-08-12T18:04:13 *** stringintech <stringintech!~stringint@user/stringintech> has quit IRC (Ping timeout: 250 seconds)
1832025-08-12T18:04:17 *** jon_atack <jon_atack!~jonatack@user/jonatack> has joined #bitcoin-core-dev
1842025-08-12T18:05:42 *** jonatack <jonatack!~jonatack@user/jonatack> has quit IRC (Ping timeout: 252 seconds)
1852025-08-12T18:06:59 *** bugs_ <bugs_!~bugs@user/bugs/x-5128603> has quit IRC (Quit: Leaving)
1862025-08-12T18:28:07 *** l0rinc <l0rinc!~l0rinc@user/l0rinc> has joined #bitcoin-core-dev
1872025-08-12T18:33:22 *** ___nick___ <___nick___!~quassel@82-132-214-203.dab.02.net> has joined #bitcoin-core-dev
1882025-08-12T18:33:33 *** ___nick___ <___nick___!~quassel@82-132-214-203.dab.02.net> has quit IRC (Client Quit)
1892025-08-12T18:34:07 <bitcoin-git> [bitcoin] achow101 pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/ec484bd5ce43...73972d56176a
1902025-08-12T18:34:08 <bitcoin-git> bitcoin/master 0173788 Ryan Ofsky: wallet: Translate [default wallet] string in progress messages
1912025-08-12T18:34:08 <bitcoin-git> bitcoin/master db225ce Ryan Ofsky: wallet, refactor: Replace GetDisplayName() with LogName()
1922025-08-12T18:34:08 <bitcoin-git> bitcoin/master 73972d5 Ava Chow: Merge bitcoin/bitcoin#31296: wallet: Translate [default wallet] string in ...
1932025-08-12T18:34:09 <bitcoin-git> [bitcoin] achow101 merged pull request #31296: wallet: Translate [default wallet] string in progress messages (master...pr/dtran) https://github.com/bitcoin/bitcoin/pull/31296
1942025-08-12T18:35:52 *** ___nick___ <___nick___!~quassel@82-132-214-203.dab.02.net> has joined #bitcoin-core-dev
1952025-08-12T18:40:47 *** l0rinc <l0rinc!~l0rinc@user/l0rinc> has quit IRC (Quit: l0rinc)
1962025-08-12T18:41:59 *** l0rinc <l0rinc!~l0rinc@user/l0rinc> has joined #bitcoin-core-dev
1972025-08-12T18:44:21 *** Christoph_ <Christoph_!~Christoph@2a02:810d:1399:b700:f468:5c34:5dbd:3a55> has quit IRC (Quit: Christoph_)
1982025-08-12T19:03:04 *** jonatack <jonatack!~jonatack@user/jonatack> has joined #bitcoin-core-dev
1992025-08-12T19:05:04 *** jon_atack <jon_atack!~jonatack@user/jonatack> has quit IRC (Ping timeout: 272 seconds)
2002025-08-12T19:06:55 *** jespada_ <jespada_!~jespada@2800:a4:2276:cf00:b488:502d:af3f:426d> has joined #bitcoin-core-dev
2012025-08-12T19:09:16 *** jespada <jespada!~jespada@2800:a4:2276:cf00:f556:c198:b7ff:e1b2> has quit IRC (Ping timeout: 276 seconds)
2022025-08-12T19:22:38 *** ___nick___ <___nick___!~quassel@82-132-214-203.dab.02.net> has quit IRC (Ping timeout: 252 seconds)
2032025-08-12T19:48:57 *** bitdex <bitdex!~bitdex@gateway/tor-sasl/bitdex> has quit IRC (Ping timeout: 240 seconds)
2042025-08-12T19:54:19 *** l0rinc <l0rinc!~l0rinc@user/l0rinc> has quit IRC (Quit: l0rinc)
2052025-08-12T20:07:57 *** VonNaturAustreVe <VonNaturAustreVe!~natur@user/vonnaturaustreve> has joined #bitcoin-core-dev
2062025-08-12T20:13:29 *** bitdex <bitdex!~bitdex@gateway/tor-sasl/bitdex> has joined #bitcoin-core-dev
2072025-08-12T20:33:39 *** zeropoint <zeropoint!~alex@45-28-139-114.lightspeed.sntcca.sbcglobal.net> has quit IRC (Quit: leaving)
2082025-08-12T20:34:27 *** jon_atack <jon_atack!~jonatack@user/jonatack> has joined #bitcoin-core-dev
2092025-08-12T20:36:54 *** jonatack <jonatack!~jonatack@user/jonatack> has quit IRC (Ping timeout: 272 seconds)
2102025-08-12T20:54:33 *** purpleKarrot <purpleKarrot!~purpleKar@user/purpleKarrot> has quit IRC (Quit: purpleKarrot)
2112025-08-12T20:54:45 *** purpleKarrot <purpleKarrot!~purpleKar@user/purpleKarrot> has joined #bitcoin-core-dev
2122025-08-12T20:57:25 *** BGL <BGL!eighty@75.149.171.58> has quit IRC (Ping timeout: 248 seconds)
2132025-08-12T20:58:34 *** l0rinc <l0rinc!~l0rinc@user/l0rinc> has joined #bitcoin-core-dev
2142025-08-12T21:19:50 *** jonatack <jonatack!~jonatack@user/jonatack> has joined #bitcoin-core-dev
2152025-08-12T21:22:03 *** jon_atack <jon_atack!~jonatack@user/jonatack> has quit IRC (Ping timeout: 252 seconds)
2162025-08-12T21:33:32 *** jon_atack <jon_atack!~jonatack@user/jonatack> has joined #bitcoin-core-dev
2172025-08-12T21:35:15 *** jonatack <jonatack!~jonatack@user/jonatack> has quit IRC (Ping timeout: 252 seconds)
2182025-08-12T21:35:38 <bitcoin-git> [bitcoin] achow101 pushed 4 commits to master: https://github.com/bitcoin/bitcoin/compare/73972d56176a...dadf15f88cba
2192025-08-12T21:35:38 <bitcoin-git> bitcoin/master 266dd0e Anthony Towns: net_processing: drop MaybePunishNodeForTx
2202025-08-12T21:35:38 <bitcoin-git> bitcoin/master b29ae9e Anthony Towns: validation: only check input scripts once
2212025-08-12T21:35:38 <bitcoin-git> bitcoin/master 876dbdf Anthony Towns: tests: drop expect_disconnect behaviour for tx relay
2222025-08-12T21:35:39 <bitcoin-git> [bitcoin] achow101 merged pull request #33050: net, validation: don't punish peers for consensus-invalid txs (master...202507-nopunishtx) https://github.com/bitcoin/bitcoin/pull/33050
2232025-08-12T21:49:41 *** PaperSword <PaperSword!~Thunderbi@securemail.qrsnap.io> has joined #bitcoin-core-dev
2242025-08-12T21:54:25 *** PaperSword <PaperSword!~Thunderbi@securemail.qrsnap.io> has quit IRC (Client Quit)
2252025-08-12T22:03:20 *** joetor5 <joetor5!~Thunderbi@user/joetor5> has joined #bitcoin-core-dev
2262025-08-12T22:09:57 *** jerryf <jerryf!~jerryf@user/jerryf> has quit IRC (Ping timeout: 240 seconds)
2272025-08-12T22:10:11 *** ghost43 <ghost43!~ghost43@gateway/tor-sasl/ghost43> has joined #bitcoin-core-dev
2282025-08-12T22:10:17 *** ghost43_ <ghost43_!~ghost43@gateway/tor-sasl/ghost43> has quit IRC (Ping timeout: 240 seconds)
2292025-08-12T22:11:06 *** jerryf <jerryf!~jerryf@user/jerryf> has joined #bitcoin-core-dev
2302025-08-12T22:23:20 *** nymius <nymius!~nymius@user/nymius> has joined #bitcoin-core-dev
2312025-08-12T22:24:49 *** BGL <BGL!eighty@75.149.171.58> has joined #bitcoin-core-dev
2322025-08-12T22:30:52 *** l0rinc <l0rinc!~l0rinc@user/l0rinc> has quit IRC (Quit: l0rinc)
2332025-08-12T22:33:02 *** flag <flag!~flag@81.56.46.144> has quit IRC (Ping timeout: 265 seconds)
2342025-08-12T22:34:27 *** flag <flag!~flag@81.56.46.144> has joined #bitcoin-core-dev
2352025-08-12T22:37:29 *** l0rinc <l0rinc!~l0rinc@user/l0rinc> has joined #bitcoin-core-dev
2362025-08-12T22:42:59 *** purpleKarrot <purpleKarrot!~purpleKar@user/purpleKarrot> has quit IRC (Quit: purpleKarrot)
2372025-08-12T22:43:12 *** purpleKarrot <purpleKarrot!~purpleKar@user/purpleKarrot> has joined #bitcoin-core-dev
2382025-08-12T22:47:52 *** aleggg <aleggg!~aleggg@187.34.168.103> has quit IRC (Ping timeout: 260 seconds)
2392025-08-12T22:53:42 *** jonatack <jonatack!~jonatack@user/jonatack> has joined #bitcoin-core-dev
2402025-08-12T22:54:55 *** jon_atack <jon_atack!~jonatack@user/jonatack> has quit IRC (Ping timeout: 252 seconds)
2412025-08-12T23:00:15 *** jon_atack <jon_atack!~jonatack@user/jonatack> has joined #bitcoin-core-dev
2422025-08-12T23:01:54 *** jonatack <jonatack!~jonatack@user/jonatack> has quit IRC (Ping timeout: 252 seconds)
2432025-08-12T23:04:51 *** l0rinc <l0rinc!~l0rinc@user/l0rinc> has quit IRC (Quit: l0rinc)
2442025-08-12T23:11:23 *** nymius <nymius!~nymius@user/nymius> has quit IRC (Quit: nymius)
2452025-08-12T23:13:45 *** jonatack <jonatack!~jonatack@user/jonatack> has joined #bitcoin-core-dev
2462025-08-12T23:14:29 *** jon_atack <jon_atack!~jonatack@user/jonatack> has quit IRC (Ping timeout: 248 seconds)
2472025-08-12T23:19:25 *** VonNaturAustreVe <VonNaturAustreVe!~natur@user/vonnaturaustreve> has quit IRC (Ping timeout: 255 seconds)
2482025-08-12T23:31:22 <lightlike> stringintech: (not online but maybe you'll see this in the logs) I think the idea behind the stalling logic is that we are in a stalling situation when a peer that could do work for us has to become idle because we can't assign it any.
2492025-08-12T23:31:45 <lightlike> We don't require that its assigned queue of 16 blocks must be full all of the time. So as long as state.vBlocksInFlight is non-empty, we are not in a stalling case yet, because the peer has still work scheduled and isn't idle.
2502025-08-12T23:48:24 <lightlike> I think the suggested alternative would also be possible (require all queues to be at the MAX_BLOCKS_IN_TRANSIT_PER_PEER limit), it would be stricter, resulting in earlier (and therefore more) stalling disconnections. I don't think though that any of the two approaches is inconsistent.
2512025-08-12T23:53:54 *** VonNaturAustreVe <VonNaturAustreVe!~natur@user/vonnaturaustreve> has joined #bitcoin-core-dev
2522025-08-12T23:59:01 *** VonNaturAustreVe <VonNaturAustreVe!~natur@user/vonnaturaustreve> has quit IRC (Ping timeout: 255 seconds)
2532025-08-12T23:59:20 *** l0rinc <l0rinc!~l0rinc@user/l0rinc> has joined #bitcoin-core-dev