12025-08-25T00:03:01 *** kevkevin <kevkevin!~kevkevin@209.242.39.30> has quit IRC (Ping timeout: 256 seconds)
22025-08-25T00:12:12 *** kevkevin <kevkevin!~kevkevin@209.242.39.30> has joined #bitcoin-core-dev
32025-08-25T00:25:11 *** adil <adil!~Thunderbi@2402:d000:8134:2f97:2c9f:2520:fce9:7677> has joined #bitcoin-core-dev
42025-08-25T00:30:18 *** adil <adil!~Thunderbi@2402:d000:8134:2f97:2c9f:2520:fce9:7677> has quit IRC (Quit: adil)
52025-08-25T00:47:09 *** Cory48 <Cory48!~Cory40@user/pasha> has joined #bitcoin-core-dev
62025-08-25T00:50:43 *** Cory40 <Cory40!~Cory83@user/pasha> has quit IRC (Ping timeout: 250 seconds)
72025-08-25T00:51:27 *** Cory39 <Cory39!~Cory48@user/pasha> has joined #bitcoin-core-dev
82025-08-25T00:55:03 *** Cory48 <Cory48!~Cory40@user/pasha> has quit IRC (Ping timeout: 250 seconds)
92025-08-25T01:02:25 *** kevkevin <kevkevin!~kevkevin@209.242.39.30> has quit IRC (Quit: Leaving...)
102025-08-25T01:12:27 *** w0xlt <w0xlt!~w0xlt@209.184.121.14> has joined #bitcoin-core-dev
112025-08-25T01:16:36 *** w0xlt <w0xlt!~w0xlt@209.184.121.14> has quit IRC (Ping timeout: 244 seconds)
122025-08-25T01:26:30 *** Cory96 <Cory96!~Cory39@user/pasha> has joined #bitcoin-core-dev
132025-08-25T01:29:52 *** PaperSword <PaperSword!~Thunderbi@securemail.qrsnap.io> has quit IRC (Quit: PaperSword)
142025-08-25T01:30:09 *** Cory39 <Cory39!~Cory48@user/pasha> has quit IRC (Ping timeout: 250 seconds)
152025-08-25T01:31:54 *** Cory72 <Cory72!~Cory96@user/pasha> has joined #bitcoin-core-dev
162025-08-25T01:35:15 *** Cory49 <Cory49!~Cory72@user/pasha> has joined #bitcoin-core-dev
172025-08-25T01:35:21 *** Cory96 <Cory96!~Cory39@user/pasha> has quit IRC (Ping timeout: 250 seconds)
182025-08-25T01:38:49 *** Cory72 <Cory72!~Cory96@user/pasha> has quit IRC (Ping timeout: 250 seconds)
192025-08-25T01:48:57 *** real_or_random <real_or_random!sid554204@user/real-or-random/x-4440763> has quit IRC (Server closed connection)
202025-08-25T01:49:08 *** real_or_random <real_or_random!sid554204@user/real-or-random/x-4440763> has joined #bitcoin-core-dev
212025-08-25T01:54:26 <phantomcircuit> sliv3r__, i did the test that gmaxwell is talking about and it slightly improved performance but only in the extremely happy path where every transaction in the block is in the mempool
222025-08-25T02:14:00 *** hacker4web3bitco <hacker4web3bitco!~hacker4we@user/hacker4web3bitco> has joined #bitcoin-core-dev
232025-08-25T02:19:23 *** Cory65 <Cory65!~Cory49@user/pasha> has joined #bitcoin-core-dev
242025-08-25T02:21:59 *** Cory67 <Cory67!~Cory65@user/pasha> has joined #bitcoin-core-dev
252025-08-25T02:23:01 *** Cory49 <Cory49!~Cory72@user/pasha> has quit IRC (Ping timeout: 250 seconds)
262025-08-25T02:25:37 *** Cory65 <Cory65!~Cory49@user/pasha> has quit IRC (Ping timeout: 250 seconds)
272025-08-25T02:33:45 <phantomcircuit> sliv3r__, the unhappy path it was like 2-3x slower
282025-08-25T02:33:55 <phantomcircuit> so overall i think not a good change, at least not at this time
292025-08-25T02:34:14 <phantomcircuit> sipa is working on a mempool clustering thing and we should reassess after that, maybe it'll be faster
302025-08-25T02:53:17 *** danielabrozzoni <danielabrozzoni!sid661616@id-661616.ilkley.irccloud.com> has quit IRC (Server closed connection)
312025-08-25T02:53:28 *** danielabrozzoni <danielabrozzoni!sid661616@id-661616.ilkley.irccloud.com> has joined #bitcoin-core-dev
322025-08-25T03:05:13 <sliv3r__> @phantomcircuit do you have the experiment documented to take a look?
332025-08-25T03:17:35 <phantomcircuit> sliv3r__, uh
342025-08-25T03:18:45 <phantomcircuit> looks like no
352025-08-25T03:20:00 <sliv3r__> :'( it's ok, thanks!
362025-08-25T03:22:38 <phantomcircuit> i think i just changed PartiallyDownloadedBlock::InitData to iterate over one of the mempool boost multindexes instead of the txns_randomized vector
372025-08-25T03:23:03 <phantomcircuit> sliv3r__, i seem to recall it was annoying to figure out how the multi index container thing works but once i had that it was trivial and of course i cant remember anymore
382025-08-25T03:27:08 <sliv3r__> noted, will check, thx
392025-08-25T03:49:19 <gmaxwell> the decode speed appeared to be clearly problematic though, I had assumed that it was all due to the fact that it had to iterate everything now due to missing transactions, hadn't considered the fact that more recent changes may have just made it much slower in general
402025-08-25T03:49:43 <gmaxwell> (and I guess while I say clearly problematic the decode time is still kinda of irrelevant compared to missed txn)
412025-08-25T03:59:01 <bitcoin-git> [bitcoin] frankomosh opened pull request #33252: fuzz: add target for `DifferenceFormatter` and invariant check in `net_processing.cpp` (master...fuzz-differenceFormatter) https://github.com/bitcoin/bitcoin/pull/33252
422025-08-25T04:01:01 *** cmirror <cmirror!~cmirror@4.53.92.114> has quit IRC (Remote host closed the connection)
432025-08-25T04:01:33 *** cmirror <cmirror!~cmirror@4.53.92.114> has joined #bitcoin-core-dev
442025-08-25T04:02:07 *** robszarka <robszarka!~szarka@2603:3003:4eac:100:51ff:3569:b8fd:2d55> has joined #bitcoin-core-dev
452025-08-25T04:05:34 *** szarka <szarka!~szarka@2603:3003:4eac:100:9cb1:eda2:cc64:576a> has quit IRC (Ping timeout: 256 seconds)
462025-08-25T04:13:22 *** Cory12 <Cory12!~Cory67@user/pasha> has joined #bitcoin-core-dev
472025-08-25T04:16:59 *** Cory67 <Cory67!~Cory65@user/pasha> has quit IRC (Ping timeout: 250 seconds)
482025-08-25T04:26:50 <phantomcircuit> gmaxwell, i seem to recall my basic thought was that it didn't actually matter that much compared to reducing tx misses
492025-08-25T04:27:09 <phantomcircuit> and because sipa was changing stuff there anyways any benchmark would be outdated soon enough
502025-08-25T04:28:22 <_aj_> gmaxwell: doing a cache optimisation and not having either a comment in the code as to what it's for, nor a benchmark to measure its effectiveness or catch regressions seems like the bigger issue than C++...
512025-08-25T04:33:00 *** shiza <shiza!~admin@ec2-54-194-87-13.eu-west-1.compute.amazonaws.com> has quit IRC (Server closed connection)
522025-08-25T04:33:25 *** shiza <shiza!~admin@ec2-54-194-87-13.eu-west-1.compute.amazonaws.com> has joined #bitcoin-core-dev
532025-08-25T04:35:21 *** Guest42 <Guest42!~Guest42@ip68-101-122-207.oc.oc.cox.net> has joined #bitcoin-core-dev
542025-08-25T04:37:59 *** Guest42 <Guest42!~Guest42@ip68-101-122-207.oc.oc.cox.net> has quit IRC (Client Quit)
552025-08-25T04:38:41 *** michaelfolkson <michaelfolkson!~michaelfo@138.68.143.20> has quit IRC (Ping timeout: 258 seconds)
562025-08-25T04:38:42 *** Lightsword_ <Lightsword_!~Lightswor@user/lightsword> has joined #bitcoin-core-dev
572025-08-25T04:38:47 *** JTL2 <JTL2!~jtl@user/jtl> has joined #bitcoin-core-dev
582025-08-25T04:38:47 *** oribellow_ <oribellow_!~oribellow@user/oribellow> has joined #bitcoin-core-dev
592025-08-25T04:38:58 *** JTL <JTL!~jtl@user/jtl> has quit IRC (Killed (NickServ (GHOST command used by JTL2)))
602025-08-25T04:39:01 *** michaelfolkson <michaelfolkson!~michaelfo@138.68.143.20> has joined #bitcoin-core-dev
612025-08-25T04:39:02 *** JTL2 is now known as JTL
622025-08-25T04:39:27 *** Earnestly <Earnestly!~earnest@user/earnestly> has quit IRC (Ping timeout: 258 seconds)
632025-08-25T04:39:27 *** oribellow <oribellow!~oribellow@user/oribellow> has quit IRC (Ping timeout: 258 seconds)
642025-08-25T04:39:27 *** Lightsword <Lightsword!~Lightswor@user/lightsword> has quit IRC (Ping timeout: 258 seconds)
652025-08-25T04:39:50 *** entropyx <entropyx!~blackbox@user/entropyx> has quit IRC (Ping timeout: 258 seconds)
662025-08-25T04:40:44 *** Lightsword_ is now known as Lightsword
672025-08-25T04:40:48 *** entropyx <entropyx!~blackbox@user/entropyx> has joined #bitcoin-core-dev
682025-08-25T04:41:33 *** Earnestly <Earnestly!~earnest@user/earnestly> has joined #bitcoin-core-dev
692025-08-25T04:41:37 *** oribellow_ is now known as oribellow
702025-08-25T05:13:31 <gmaxwell> _aj_: "a cache optimization" -- come on. Any time you add more pointer chasing it's a potentially performance hit, unless none of it is in a performance relevant path. Are you suggesting the involved contributors didn't know block reconstruction was performance relevant? I think it's a lot more likely that no one considered that the change would have a performance consequence at all.
712025-08-25T05:16:02 <_aj_> gmaxwell: i don't think those two scenarios are meaningfully different, or that it being in a language other than C++ would've helped in either case
722025-08-25T05:21:16 <_aj_> gmaxwell: prioritising clean/simple code over performance optimisations is extremely common; so (a) not being aware of a technique that's likely to be important to performance; (b) not having a good judgement of where an improvement is important; and (c) prioritising other things even knowing there could be some effect on performance all seems like things to expect to see from open source
732025-08-25T05:21:17 <_aj_> contributors, unless you have a closed repo like sqlite or something i guess
742025-08-25T05:25:07 <gmaxwell> I withdraw the comment, because that change wasn't actually obfscuated by an interface in this case.
752025-08-25T05:25:49 <_aj_> haha, okay i get where you were coming from now
762025-08-25T05:46:29 *** w0xlt <w0xlt!~w0xlt@209.184.121.14> has joined #bitcoin-core-dev
772025-08-25T05:47:54 *** stringintech <stringintech!~stringint@user/stringintech> has joined #bitcoin-core-dev
782025-08-25T05:52:45 *** stringintech <stringintech!~stringint@user/stringintech> has quit IRC (Ping timeout: 250 seconds)
792025-08-25T05:56:38 *** takinbo <takinbo!~takinbo@user/takinbo> has quit IRC (Server closed connection)
802025-08-25T05:56:54 *** takinbo <takinbo!~takinbo@user/takinbo> has joined #bitcoin-core-dev
812025-08-25T06:03:43 *** gnusha_ <gnusha_!~gnusha@user/gnusha> has quit IRC (Server closed connection)
822025-08-25T06:03:54 *** gnusha <gnusha!~gnusha@user/gnusha> has joined #bitcoin-core-dev
832025-08-25T06:13:16 *** PaperSword <PaperSword!~Thunderbi@securemail.qrsnap.io> has joined #bitcoin-core-dev
842025-08-25T06:18:29 *** pinheadmz <pinheadmz!~pinheadmz@165.227.93.117> has quit IRC (Server closed connection)
852025-08-25T06:18:49 *** pinheadmz <pinheadmz!~pinheadmz@165.227.93.117> has joined #bitcoin-core-dev
862025-08-25T06:24:01 *** yuvicc <yuvicc!~yuvicc@user/yuvicc> has joined #bitcoin-core-dev
872025-08-25T06:24:37 *** abubakarsadiq <abubakarsadiq!uid602234@id-602234.hampstead.irccloud.com> has joined #bitcoin-core-dev
882025-08-25T06:32:32 *** yuvicc <yuvicc!~yuvicc@user/yuvicc> has quit IRC (Quit: yuvicc)
892025-08-25T06:32:58 <bitcoin-git> [bitcoin] maflcko closed pull request #33252: fuzz: add target for `DifferenceFormatter` and invariant check in `net_processing.cpp` (master...fuzz-differenceFormatter) https://github.com/bitcoin/bitcoin/pull/33252
902025-08-25T06:43:36 *** w0xlt <w0xlt!~w0xlt@209.184.121.14> has quit IRC (Ping timeout: 248 seconds)
912025-08-25T06:45:32 *** kerm|t <kerm|t!sid393220@user/kermit4> has quit IRC (Server closed connection)
922025-08-25T06:45:43 *** kerm|t <kerm|t!sid393220@user/kermit4> has joined #bitcoin-core-dev
932025-08-25T06:47:22 *** jerryf <jerryf!~jerryf@user/jerryf> has joined #bitcoin-core-dev
942025-08-25T06:48:20 *** jerryf_ <jerryf_!~jerryf@user/jerryf> has quit IRC (Ping timeout: 272 seconds)
952025-08-25T07:06:35 *** f321x <f321x!~f321x@user/f321x> has joined #bitcoin-core-dev
962025-08-25T07:14:21 <bitcoin-git> [bitcoin] maflcko reopened pull request #33252: fuzz: add target for `DifferenceFormatter` and invariant check in `net_processing.cpp` (master...fuzz-differenceFormatter) https://github.com/bitcoin/bitcoin/pull/33252
972025-08-25T07:16:50 *** f321x <f321x!~f321x@user/f321x> has quit IRC (Ping timeout: 272 seconds)
982025-08-25T07:19:30 *** f321x <f321x!~f321x@user/f321x> has joined #bitcoin-core-dev
992025-08-25T07:47:52 *** Guyver2 <Guyver2!~Guyver@77-174-98-73.fixed.kpn.net> has joined #bitcoin-core-dev
1002025-08-25T08:00:31 *** Talkless <Talkless!~Talkless@138.199.6.197> has joined #bitcoin-core-dev
1012025-08-25T08:18:10 *** rodarmor <rodarmor!sid210835@id-210835.helmsley.irccloud.com> has quit IRC (Server closed connection)
1022025-08-25T08:18:21 *** rodarmor <rodarmor!sid210835@id-210835.helmsley.irccloud.com> has joined #bitcoin-core-dev
1032025-08-25T08:24:54 *** ___nick___ <___nick___!~quassel@82-132-215-12.dab.02.net> has joined #bitcoin-core-dev
1042025-08-25T08:25:11 *** purpleKarrot <purpleKarrot!~purpleKar@185.240.173.188> has joined #bitcoin-core-dev
1052025-08-25T08:25:35 *** ___nick___ <___nick___!~quassel@82-132-215-12.dab.02.net> has quit IRC (Client Quit)
1062025-08-25T08:27:41 *** ___nick___ <___nick___!~quassel@82-132-215-12.dab.02.net> has joined #bitcoin-core-dev
1072025-08-25T08:36:36 *** jerryf_ <jerryf_!~jerryf@user/jerryf> has joined #bitcoin-core-dev
1082025-08-25T08:40:26 *** jerryf <jerryf!~jerryf@user/jerryf> has quit IRC (Ping timeout: 272 seconds)
1092025-08-25T08:56:46 *** FelixWeis__ <FelixWeis__!sid154231@id-154231.hampstead.irccloud.com> has quit IRC (Server closed connection)
1102025-08-25T08:56:55 *** FelixWeis__ <FelixWeis__!sid154231@id-154231.hampstead.irccloud.com> has joined #bitcoin-core-dev
1112025-08-25T09:04:36 *** _durandal <_durandal!~durandal@148.252.128.180> has joined #bitcoin-core-dev
1122025-08-25T09:08:02 *** emcy__ <emcy__!~durandal@148.252.146.193> has quit IRC (Ping timeout: 260 seconds)
1132025-08-25T09:12:24 <bitcoin-git> [bitcoin] frankomosh closed pull request #33252: fuzz: add target for `DifferenceFormatter` and invariant check in `net_processing.cpp` (master...fuzz-differenceFormatter) https://github.com/bitcoin/bitcoin/pull/33252
1142025-08-25T09:12:26 <bitcoin-git> [bitcoin] frankomosh reopened pull request #33252: fuzz: add target for `DifferenceFormatter` and invariant check in `net_processing.cpp` (master...fuzz-differenceFormatter) https://github.com/bitcoin/bitcoin/pull/33252
1152025-08-25T09:28:56 *** _aj_ <_aj_!aj@user/aj/x-5857768> has quit IRC (Server closed connection)
1162025-08-25T09:32:09 *** maxedw <maxedw!sid625334@id-625334.uxbridge.irccloud.com> has quit IRC (Server closed connection)
1172025-08-25T09:32:18 *** maxedw <maxedw!sid625334@id-625334.uxbridge.irccloud.com> has joined #bitcoin-core-dev
1182025-08-25T09:37:34 *** jetpack <jetpack!~jetpack@mcfly.vm.tornadovps.net> has quit IRC (Quit: ZNC 1.8.2+deb2+deb11u1 - https://znc.in)
1192025-08-25T09:37:58 *** jetpack <jetpack!~jetpack@mcfly.vm.tornadovps.net> has joined #bitcoin-core-dev
1202025-08-25T09:39:21 *** f321x <f321x!~f321x@user/f321x> has quit IRC (Remote host closed the connection)
1212025-08-25T09:40:35 *** f321x <f321x!~f321x@user/f321x> has joined #bitcoin-core-dev
1222025-08-25T09:40:58 *** w0xlt <w0xlt!~w0xlt@209.184.121.14> has joined #bitcoin-core-dev
1232025-08-25T09:45:34 *** w0xlt <w0xlt!~w0xlt@209.184.121.14> has quit IRC (Ping timeout: 256 seconds)
1242025-08-25T09:48:27 *** aj-test <aj-test!~aj-test@60.42.96.58.static.exetel.com.au> has joined #bitcoin-core-dev
1252025-08-25T09:49:42 *** aj_ <aj_!aj@user/aj/x-5857768> has joined #bitcoin-core-dev
1262025-08-25T09:49:45 *** aj_ <aj_!aj@user/aj/x-5857768> has quit IRC (Client Quit)
1272025-08-25T09:50:40 *** aj_ <aj_!aj@user/aj/x-5857768> has joined #bitcoin-core-dev
1282025-08-25T09:50:50 *** aj-test <aj-test!~aj-test@60.42.96.58.static.exetel.com.au> has quit IRC (Client Quit)
1292025-08-25T09:51:11 *** aj_ is now known as _aj_
1302025-08-25T09:52:25 *** f321x <f321x!~f321x@user/f321x> has quit IRC (Quit: f321x)
1312025-08-25T10:03:43 <bitcoin-git> [bitcoin] ajtowns opened pull request #33253: Revert compact block cache inefficiencies (master...202508-cache-friendly-compactblock) https://github.com/bitcoin/bitcoin/pull/33253
1322025-08-25T10:09:45 *** f321x <f321x!~f321x@user/f321x> has joined #bitcoin-core-dev
1332025-08-25T10:21:08 *** SpellChecker <SpellChecker!~SpellChec@user/SpellChecker> has quit IRC (Ping timeout: 272 seconds)
1342025-08-25T10:30:11 *** SpellChecker <SpellChecker!~SpellChec@user/SpellChecker> has joined #bitcoin-core-dev
1352025-08-25T10:35:04 *** SpellChecker <SpellChecker!~SpellChec@user/SpellChecker> has quit IRC (Ping timeout: 272 seconds)
1362025-08-25T10:36:54 *** SpellChecker <SpellChecker!~SpellChec@user/SpellChecker> has joined #bitcoin-core-dev
1372025-08-25T11:40:09 *** amiti___ <amiti___!sid373138@id-373138.lymington.irccloud.com> has quit IRC (Server closed connection)
1382025-08-25T11:40:16 *** amiti___ <amiti___!sid373138@id-373138.lymington.irccloud.com> has joined #bitcoin-core-dev
1392025-08-25T11:41:16 *** jonatack <jonatack!~jonatack@user/jonatack> has joined #bitcoin-core-dev
1402025-08-25T11:44:01 *** w0xlt <w0xlt!~w0xlt@209.184.121.14> has joined #bitcoin-core-dev
1412025-08-25T11:48:47 *** w0xlt <w0xlt!~w0xlt@209.184.121.14> has quit IRC (Ping timeout: 258 seconds)
1422025-08-25T11:50:54 *** Cory12 <Cory12!~Cory67@user/pasha> has quit IRC (Quit: Client closed)
1432025-08-25T11:51:13 *** Cory12 <Cory12!~Cory12@user/pasha> has joined #bitcoin-core-dev
1442025-08-25T12:33:27 *** Cory61 <Cory61!~Cory12@user/pasha> has joined #bitcoin-core-dev
1452025-08-25T12:37:29 *** Cory12 <Cory12!~Cory12@user/pasha> has quit IRC (Ping timeout: 250 seconds)
1462025-08-25T12:55:12 *** bugs_ <bugs_!~bugs@user/bugs/x-5128603> has joined #bitcoin-core-dev
1472025-08-25T12:56:58 *** Cory14 <Cory14!~Cory61@user/pasha> has joined #bitcoin-core-dev
1482025-08-25T13:00:27 *** Cory61 <Cory61!~Cory12@user/pasha> has quit IRC (Ping timeout: 250 seconds)
1492025-08-25T13:01:28 *** bitdex <bitdex!~bitdex@gateway/tor-sasl/bitdex> has quit IRC (Quit: = "")
1502025-08-25T13:02:08 *** Cory44 <Cory44!~Cory14@user/pasha> has joined #bitcoin-core-dev
1512025-08-25T13:03:47 *** yonson <yonson!sid663712@id-663712.helmsley.irccloud.com> has quit IRC (Server closed connection)
1522025-08-25T13:03:58 *** yonson <yonson!sid663712@id-663712.helmsley.irccloud.com> has joined #bitcoin-core-dev
1532025-08-25T13:04:16 *** Cory99 <Cory99!~Cory44@user/pasha> has joined #bitcoin-core-dev
1542025-08-25T13:06:05 *** Cory14 <Cory14!~Cory61@user/pasha> has quit IRC (Ping timeout: 250 seconds)
1552025-08-25T13:08:04 *** Cory52 <Cory52!~Cory99@user/pasha> has joined #bitcoin-core-dev
1562025-08-25T13:08:15 *** Cory44 <Cory44!~Cory14@user/pasha> has quit IRC (Ping timeout: 250 seconds)
1572025-08-25T13:11:26 *** Cory22 <Cory22!~Cory52@user/pasha> has joined #bitcoin-core-dev
1582025-08-25T13:11:43 *** Cory99 <Cory99!~Cory44@user/pasha> has quit IRC (Ping timeout: 250 seconds)
1592025-08-25T13:12:21 *** instagibbs <instagibbs!~instagibb@pool-100-15-116-202.washdc.fios.verizon.net> has joined #bitcoin-core-dev
1602025-08-25T13:15:11 *** Cory52 <Cory52!~Cory99@user/pasha> has quit IRC (Ping timeout: 250 seconds)
1612025-08-25T13:27:45 *** crank <crank!~Crank@123.20.124.72> has joined #bitcoin-core-dev
1622025-08-25T13:29:14 *** f321x <f321x!~f321x@user/f321x> has quit IRC (Ping timeout: 272 seconds)
1632025-08-25T13:29:15 *** crank <crank!~Crank@123.20.124.72> has quit IRC (Quit: Leaving)
1642025-08-25T13:29:57 *** ___nick___ <___nick___!~quassel@82-132-215-12.dab.02.net> has quit IRC (Ping timeout: 260 seconds)
1652025-08-25T13:30:21 *** ___nick___ <___nick___!~quassel@82-132-214-78.dab.02.net> has joined #bitcoin-core-dev
1662025-08-25T13:30:49 *** f321x <f321x!~f321x@user/f321x> has joined #bitcoin-core-dev
1672025-08-25T13:45:20 *** ___nick___ <___nick___!~quassel@82-132-214-78.dab.02.net> has quit IRC (Ping timeout: 245 seconds)
1682025-08-25T13:45:32 *** ___nick___ <___nick___!~quassel@82-132-214-78.dab.02.net> has joined #bitcoin-core-dev
1692025-08-25T13:49:54 *** Cory68 <Cory68!~Cory22@user/pasha> has joined #bitcoin-core-dev
1702025-08-25T13:51:13 *** Cory94 <Cory94!~Cory68@user/pasha> has joined #bitcoin-core-dev
1712025-08-25T13:52:42 *** michael__ <michael__!sid690039@id-690039.helmsley.irccloud.com> has quit IRC (Server closed connection)
1722025-08-25T13:52:50 *** michael__ <michael__!sid690039@id-690039.helmsley.irccloud.com> has joined #bitcoin-core-dev
1732025-08-25T13:53:45 *** Cory22 <Cory22!~Cory52@user/pasha> has quit IRC (Ping timeout: 250 seconds)
1742025-08-25T13:54:37 *** Cory68 <Cory68!~Cory22@user/pasha> has quit IRC (Ping timeout: 250 seconds)
1752025-08-25T13:57:10 *** Cory67 <Cory67!~Cory94@user/pasha> has joined #bitcoin-core-dev
1762025-08-25T14:00:41 *** Cory94 <Cory94!~Cory68@user/pasha> has quit IRC (Ping timeout: 250 seconds)
1772025-08-25T14:03:20 *** Ademan <Ademan!~Ademan@user/Ademan> has quit IRC (Ping timeout: 244 seconds)
1782025-08-25T14:08:03 *** w0xlt <w0xlt!~w0xlt@209.184.121.14> has joined #bitcoin-core-dev
1792025-08-25T14:12:32 *** w0xlt <w0xlt!~w0xlt@209.184.121.14> has quit IRC (Ping timeout: 260 seconds)
1802025-08-25T14:13:25 *** enochazariah <enochazariah!uid710351@id-710351.hampstead.irccloud.com> has joined #bitcoin-core-dev
1812025-08-25T14:16:01 *** w0xlt <w0xlt!~w0xlt@209.184.121.14> has joined #bitcoin-core-dev
1822025-08-25T14:18:06 *** kevkevin <kevkevin!~kevkevin@209.242.39.30> has joined #bitcoin-core-dev
1832025-08-25T14:30:27 *** jon_atack <jon_atack!~jonatack@user/jonatack> has joined #bitcoin-core-dev
1842025-08-25T14:32:39 *** jonatack <jonatack!~jonatack@user/jonatack> has quit IRC (Ping timeout: 252 seconds)
1852025-08-25T14:42:41 *** Cory5 <Cory5!~Cory67@user/pasha> has joined #bitcoin-core-dev
1862025-08-25T14:43:38 *** hacker4web3bitco <hacker4web3bitco!~hacker4we@user/hacker4web3bitco> has quit IRC (Ping timeout: 244 seconds)
1872025-08-25T14:46:11 *** Cory67 <Cory67!~Cory94@user/pasha> has quit IRC (Ping timeout: 250 seconds)
1882025-08-25T14:55:54 *** tqfoley2 <tqfoley2!~default@107-137-16-146.lightspeed.chtnsc.sbcglobal.net> has joined #bitcoin-core-dev
1892025-08-25T14:58:10 *** Cory11 <Cory11!~Cory5@user/pasha> has joined #bitcoin-core-dev
1902025-08-25T15:01:47 *** Cory5 <Cory5!~Cory67@user/pasha> has quit IRC (Ping timeout: 250 seconds)
1912025-08-25T15:09:12 *** aleggg <aleggg!~aleggg@187.34.168.103> has quit IRC (Ping timeout: 248 seconds)
1922025-08-25T15:09:33 *** aleggg <aleggg!~aleggg@187.34.168.103> has joined #bitcoin-core-dev
1932025-08-25T15:16:08 *** w0xlt <w0xlt!~w0xlt@209.184.121.14> has quit IRC (Ping timeout: 248 seconds)
1942025-08-25T15:23:46 *** eugenesiegel <eugenesiegel!~eugenesie@user/eugenesiegel> has joined #bitcoin-core-dev
1952025-08-25T15:25:18 <_aj_> instagibbs: re: 33253, the benchmark doesn't exercise a8203e9 -- it just passes an empty vector of extra transactions
1962025-08-25T15:31:26 *** w0xlt <w0xlt!~w0xlt@209.184.121.14> has joined #bitcoin-core-dev
1972025-08-25T15:32:37 <instagibbs> pasted on the PR thanks
1982025-08-25T15:36:06 *** w0xlt <w0xlt!~w0xlt@209.184.121.14> has quit IRC (Ping timeout: 258 seconds)
1992025-08-25T15:40:04 *** zeropoint <zeropoint!~alex@45-28-139-114.lightspeed.sntcca.sbcglobal.net> has joined #bitcoin-core-dev
2002025-08-25T15:50:23 *** Ademan <Ademan!~Ademan@user/Ademan> has joined #bitcoin-core-dev
2012025-08-25T15:52:04 *** f321x <f321x!~f321x@user/f321x> has quit IRC (Quit: f321x)
2022025-08-25T15:54:33 *** Cory61 <Cory61!~Cory11@user/pasha> has joined #bitcoin-core-dev
2032025-08-25T15:58:33 *** Cory11 <Cory11!~Cory5@user/pasha> has quit IRC (Ping timeout: 250 seconds)
2042025-08-25T16:16:27 *** nanotube <nanotube!~nanotube@user/nanotube> has quit IRC (Ping timeout: 276 seconds)
2052025-08-25T16:18:36 *** jonatack <jonatack!~jonatack@user/jonatack> has joined #bitcoin-core-dev
2062025-08-25T16:20:55 *** jon_atack <jon_atack!~jonatack@user/jonatack> has quit IRC (Ping timeout: 255 seconds)
2072025-08-25T16:23:37 *** jon_atack <jon_atack!~jonatack@user/jonatack> has joined #bitcoin-core-dev
2082025-08-25T16:25:54 *** jonatack <jonatack!~jonatack@user/jonatack> has quit IRC (Ping timeout: 256 seconds)
2092025-08-25T16:28:45 *** jonatack <jonatack!~jonatack@user/jonatack> has joined #bitcoin-core-dev
2102025-08-25T16:30:25 <jonatack> If I understand GitHub protocol correctly, "Drahtbot locked and limited conversation to collaborators" just after each merge seems a little aggressive? I cannot provide a post-merge review.
2112025-08-25T16:31:00 *** jon_atack <jon_atack!~jonatack@user/jonatack> has quit IRC (Ping timeout: 256 seconds)
2122025-08-25T16:31:15 <jonatack> IIUC "collaborators" does not seem to include repository members, only those with write access.
2132025-08-25T16:32:45 <fanquake> Which PR?
2142025-08-25T16:33:46 <fanquake> Drahtbot generally only batch locks historical PRs, on some schedule
2152025-08-25T16:36:52 <fanquake> jonatack?
2162025-08-25T16:37:32 *** jon_atack <jon_atack!~jonatack@user/jonatack> has joined #bitcoin-core-dev
2172025-08-25T16:39:54 *** jonatack <jonatack!~jonatack@user/jonatack> has quit IRC (Ping timeout: 248 seconds)
2182025-08-25T16:40:50 <jon_atack> power went off, the off-grid setup here needs better failover
2192025-08-25T16:42:23 <jon_atack> thanks fanquake. was looking at https://github.com/bitcoin/bitcoin/pull/29752#issuecomment-3216827263 locked the same date as merge
2202025-08-25T16:42:34 *** jon_atack <jon_atack!~jonatack@user/jonatack> has quit IRC (Quit: WeeChat 4.7.1)
2212025-08-25T16:43:02 <fanquake> It was locked 1 year after merge
2222025-08-25T16:43:25 <fanquake> Merged 9 April 2024. Locked 9 April 2025
2232025-08-25T16:44:13 *** jonatack <jonatack!~jonatack@user/jonatack> has joined #bitcoin-core-dev
2242025-08-25T16:44:19 <fanquake> Unlocked it now, given there's discussion happening.
2252025-08-25T16:44:53 <jonatack> fanquake: I missed the year, thanks
2262025-08-25T16:48:06 *** cotsuka <cotsuka!~cotsuka@user/cotsuka> has quit IRC (Remote host closed the connection)
2272025-08-25T16:49:48 *** cotsuka <cotsuka!~cotsuka@user/cotsuka> has joined #bitcoin-core-dev
2282025-08-25T17:13:04 *** szkl <szkl!uid110435@id-110435.uxbridge.irccloud.com> has joined #bitcoin-core-dev
2292025-08-25T17:28:51 *** purpleKarrot <purpleKarrot!~purpleKar@185.240.173.188> has quit IRC (Quit: purpleKarrot)
2302025-08-25T17:38:56 *** nanotube <nanotube!~nanotube@user/nanotube> has joined #bitcoin-core-dev
2312025-08-25T18:08:22 *** Guest11 <Guest11!~Guest11@155.190.37.7> has joined #bitcoin-core-dev
2322025-08-25T18:20:53 *** Guyver2 <Guyver2!~Guyver@77-174-98-73.fixed.kpn.net> has left #bitcoin-core-dev (Closing Window)
2332025-08-25T18:24:09 *** eugenesiegel <eugenesiegel!~eugenesie@user/eugenesiegel> has quit IRC (Ping timeout: 250 seconds)
2342025-08-25T18:29:44 *** eugenesiegel <eugenesiegel!~eugenesie@user/eugenesiegel> has joined #bitcoin-core-dev
2352025-08-25T18:46:41 *** eugenesiegel <eugenesiegel!~eugenesie@user/eugenesiegel> has quit IRC (Ping timeout: 250 seconds)
2362025-08-25T18:53:10 *** enochazariah <enochazariah!uid710351@id-710351.hampstead.irccloud.com> has quit IRC (Quit: Connection closed for inactivity)
2372025-08-25T19:12:15 *** Guest11 <Guest11!~Guest11@155.190.37.7> has quit IRC (Ping timeout: 250 seconds)
2382025-08-25T19:18:32 *** tqfoley2 <tqfoley2!~default@107-137-16-146.lightspeed.chtnsc.sbcglobal.net> has quit IRC (Read error: Connection reset by peer)
2392025-08-25T19:34:08 *** Talkless <Talkless!~Talkless@138.199.6.197> has quit IRC (Quit: Konversation terminated!)
2402025-08-25T19:36:22 *** Guest60 <Guest60!~Guest60@2a05:fa40:3d8:ad00:80df:4e59:5e47:862c> has joined #bitcoin-core-dev
2412025-08-25T19:37:21 *** Guest60 <Guest60!~Guest60@2a05:fa40:3d8:ad00:80df:4e59:5e47:862c> has quit IRC (Client Quit)
2422025-08-25T19:54:03 *** PaperSword <PaperSword!~Thunderbi@securemail.qrsnap.io> has quit IRC (Quit: PaperSword)
2432025-08-25T19:58:24 *** ___nick___ <___nick___!~quassel@82-132-214-78.dab.02.net> has quit IRC (Ping timeout: 256 seconds)
2442025-08-25T20:08:46 *** nanotube_ <nanotube_!~nanotube@user/nanotube> has joined #bitcoin-core-dev
2452025-08-25T20:30:15 <bitcoin-git> [bitcoin] 151henry151 opened pull request #33254: wallet: Replace fee magic numbers with named constants (master...magic-number-cleanup) https://github.com/bitcoin/bitcoin/pull/33254
2462025-08-25T21:02:33 *** w0xlt <w0xlt!~w0xlt@209.184.121.14> has joined #bitcoin-core-dev
2472025-08-25T21:07:04 *** w0xlt <w0xlt!~w0xlt@209.184.121.14> has quit IRC (Ping timeout: 248 seconds)
2482025-08-25T21:12:09 <bitcoin-git> [bitcoin] achow101 pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/9703b7e6d563...6ca6f3b37b99
2492025-08-25T21:12:10 <bitcoin-git> bitcoin/master dd68d0f Ryan Ofsky: Squashed 'src/ipc/libmultiprocess/' changes from b4120d34bad2..1b8d4a6f1e54
2502025-08-25T21:12:10 <bitcoin-git> bitcoin/master 323b3fd Ryan Ofsky: Merge commit 'dd68d0f40b614474f24469fbe1ba02f8f9146b31' into pr/subtree-3
2512025-08-25T21:12:10 <bitcoin-git> bitcoin/master 6ca6f3b Ava Chow: Merge bitcoin/bitcoin#33241: Update libmultiprocess subtree to fix build i...
2522025-08-25T21:12:12 <bitcoin-git> [bitcoin] achow101 merged pull request #33241: Update libmultiprocess subtree to fix build issues (master...pr/subtree-3) https://github.com/bitcoin/bitcoin/pull/33241
2532025-08-25T21:22:39 *** jon_atack <jon_atack!~jonatack@user/jonatack> has joined #bitcoin-core-dev
2542025-08-25T21:24:03 *** jonatack <jonatack!~jonatack@user/jonatack> has quit IRC (Ping timeout: 252 seconds)
2552025-08-25T21:30:53 *** szkl <szkl!uid110435@id-110435.uxbridge.irccloud.com> has quit IRC (Quit: Connection closed for inactivity)
2562025-08-25T21:54:01 *** Cory61 <Cory61!~Cory11@user/pasha> has quit IRC (Quit: Client closed)
2572025-08-25T21:54:18 *** Cory61 <Cory61!~Cory61@user/pasha> has joined #bitcoin-core-dev
2582025-08-25T22:24:04 *** SSL <SSL!~ssl@user/SSL> has joined #bitcoin-core-dev
2592025-08-25T22:28:11 *** nanotube_ <nanotube_!~nanotube@user/nanotube> has quit IRC (Ping timeout: 258 seconds)
2602025-08-25T22:28:57 *** pinheadmz <pinheadmz!~pinheadmz@165.227.93.117> has quit IRC (Ping timeout: 258 seconds)
2612025-08-25T22:29:58 *** pinheadmz <pinheadmz!~pinheadmz@165.227.93.117> has joined #bitcoin-core-dev
2622025-08-25T22:39:55 *** nanotube_ <nanotube_!~nanotube@user/nanotube> has joined #bitcoin-core-dev
2632025-08-25T22:40:01 *** bugs_ <bugs_!~bugs@user/bugs/x-5128603> has quit IRC (Quit: Leaving)
2642025-08-25T22:42:25 *** Cory54 <Cory54!~Cory61@user/pasha> has joined #bitcoin-core-dev
2652025-08-25T22:46:19 *** Cory61 <Cory61!~Cory61@user/pasha> has quit IRC (Ping timeout: 250 seconds)
2662025-08-25T22:56:06 *** jonatack <jonatack!~jonatack@user/jonatack> has joined #bitcoin-core-dev
2672025-08-25T22:56:27 *** jon_atack <jon_atack!~jonatack@user/jonatack> has quit IRC (Ping timeout: 252 seconds)
2682025-08-25T22:57:50 *** SSL <SSL!~ssl@user/SSL> has quit IRC (Ping timeout: 245 seconds)
2692025-08-25T23:02:20 *** Cory14 <Cory14!~Cory54@user/pasha> has joined #bitcoin-core-dev
2702025-08-25T23:05:49 *** Cory54 <Cory54!~Cory61@user/pasha> has quit IRC (Ping timeout: 250 seconds)
2712025-08-25T23:19:19 *** w0xlt <w0xlt!~w0xlt@209.184.121.14> has joined #bitcoin-core-dev
2722025-08-25T23:23:46 *** w0xlt <w0xlt!~w0xlt@209.184.121.14> has quit IRC (Ping timeout: 258 seconds)
2732025-08-25T23:42:00 *** stratospher[m] <stratospher[m]!~stratosph@2620:6e:a000:ce11::1e> has quit IRC (Server closed connection)
2742025-08-25T23:42:18 *** stratospher[m] <stratospher[m]!~stratosph@2620:6e:a000:ce11::1e> has joined #bitcoin-core-dev
2752025-08-25T23:59:59 *** rogeliodh <rogeliodh!~rogeliodh@v2202502256910318645.luckysrv.de> has quit IRC (Server closed connection)