12026-01-05T00:46:43 *** jonatack <jonatack!~jonatack@user/jonatack> has quit IRC (Ping timeout: 260 seconds)
22026-01-05T00:55:08 *** jonatack <jonatack!~jonatack@user/jonatack> has joined #bitcoin-core-dev
32026-01-05T02:46:53 *** conman <conman!~con@180-150-21-3.b49615.mel.static.aussiebb.net> has joined #bitcoin-core-dev
42026-01-05T02:52:29 *** entropyx <entropyx!~blackbox@user/entropyx> has quit IRC (Quit: no love here!)
52026-01-05T03:35:51 *** TheRec_ <TheRec_!~toto@84-74-100-31.dclient.hispeed.ch> has joined #bitcoin-core-dev
62026-01-05T03:36:23 *** jon_atack <jon_atack!~jonatack@user/jonatack> has joined #bitcoin-core-dev
72026-01-05T03:37:58 *** luke-jr_ <luke-jr_!~luke-jr@user/luke-jr> has joined #bitcoin-core-dev
82026-01-05T03:39:15 *** jadi1 <jadi1!~jadi@node-1w7jr9quqz0sdjbthwasog84s.ipv6.telus.net> has joined #bitcoin-core-dev
92026-01-05T03:40:05 *** Chris_St1 <Chris_St1!~Chris_Ste@static-68-235-46-71.cust.tzulo.com> has joined #bitcoin-core-dev
102026-01-05T03:40:07 *** TheRec <TheRec!~toto@user/therec> has quit IRC (Ping timeout: 240 seconds)
112026-01-05T03:40:07 *** sliv3r__ <sliv3r__!~sliv3r__@user/sliv3r-:76883> has quit IRC (Ping timeout: 240 seconds)
122026-01-05T03:40:07 *** Chris_Stewart_5 <Chris_Stewart_5!~Chris_Ste@static-68-235-46-71.cust.tzulo.com> has quit IRC (Ping timeout: 240 seconds)
132026-01-05T03:40:07 *** jonatack <jonatack!~jonatack@user/jonatack> has quit IRC (Ping timeout: 240 seconds)
142026-01-05T03:40:08 *** luke-jr <luke-jr!~luke-jr@user/luke-jr> has quit IRC (Ping timeout: 240 seconds)
152026-01-05T03:40:08 *** nanotube <nanotube!~nanotube@user/nanotube> has quit IRC (Ping timeout: 240 seconds)
162026-01-05T03:40:08 *** jadi <jadi!~jadi@d172-218-191-176.bchsia.telus.net> has quit IRC (Ping timeout: 240 seconds)
172026-01-05T03:40:08 *** S3RK <S3RK!~S3RK@user/s3rk> has quit IRC (Ping timeout: 240 seconds)
182026-01-05T03:40:12 *** sliv3r__- <sliv3r__-!~sliv3r__@user/sliv3r-:76883> has joined #bitcoin-core-dev
192026-01-05T03:40:30 *** nanotube <nanotube!~nanotube@user/nanotube> has joined #bitcoin-core-dev
202026-01-05T03:42:07 *** S3RK <S3RK!~S3RK@user/s3rk> has joined #bitcoin-core-dev
212026-01-05T03:44:47 *** cmirror <cmirror!~cmirror@4.53.92.114> has quit IRC (Ping timeout: 246 seconds)
222026-01-05T03:46:21 *** cman <cman!~con@180-150-21-3.b49615.mel.static.aussiebb.net> has joined #bitcoin-core-dev
232026-01-05T03:46:48 *** cm_ <cm_!~chaz@user/cm> has joined #bitcoin-core-dev
242026-01-05T03:47:03 *** justache- <justache-!~justache@user/justache> has joined #bitcoin-core-dev
252026-01-05T03:47:24 *** dongcarl00 <dongcarl00!~dongcarl@66.65.169.19> has joined #bitcoin-core-dev
262026-01-05T03:48:02 *** pinheadmz[m]1 <pinheadmz[m]1!~pinheadmz@2620:6e:a000:ce11::4a> has joined #bitcoin-core-dev
272026-01-05T03:48:09 *** achow101_ <achow101_!~achow101@user/achow101> has joined #bitcoin-core-dev
282026-01-05T03:49:35 *** jimhhq_ <jimhhq_!~jimhhq@srv779079.hstgr.cloud> has joined #bitcoin-core-dev
292026-01-05T03:50:35 *** Chris_Stewart_5 <Chris_Stewart_5!~Chris_Ste@static-68-235-46-71.cust.tzulo.com> has joined #bitcoin-core-dev
302026-01-05T03:50:39 *** justache <justache!~justache@user/justache> has quit IRC (Ping timeout: 246 seconds)
312026-01-05T03:50:39 *** BUSY <BUSY!~BUSY@user/busy> has quit IRC (Ping timeout: 246 seconds)
322026-01-05T03:50:39 *** pinheadmz[m] <pinheadmz[m]!~pinheadmz@2620:6e:a000:ce11::4a> has quit IRC (Ping timeout: 246 seconds)
332026-01-05T03:50:39 *** achow101 <achow101!~achow101@user/achow101> has quit IRC (Ping timeout: 246 seconds)
342026-01-05T03:50:39 *** BlueMattTest1 <BlueMattTest1!~test-acct@2620:6e:a000:ce11::c> has quit IRC (Ping timeout: 246 seconds)
352026-01-05T03:50:39 *** dongcarl0 <dongcarl0!~dongcarl@66.65.169.19> has quit IRC (Ping timeout: 246 seconds)
362026-01-05T03:50:40 *** cm <cm!~chaz@user/cm> has quit IRC (Ping timeout: 246 seconds)
372026-01-05T03:50:40 *** Chris_St1 <Chris_St1!~Chris_Ste@static-68-235-46-71.cust.tzulo.com> has quit IRC (Ping timeout: 246 seconds)
382026-01-05T03:50:40 *** conman <conman!~con@180-150-21-3.b49615.mel.static.aussiebb.net> has quit IRC (Ping timeout: 246 seconds)
392026-01-05T03:50:40 *** jimhhq <jimhhq!~jimhhq@srv779079.hstgr.cloud> has quit IRC (Ping timeout: 246 seconds)
402026-01-05T03:50:40 *** cm_ is now known as cm
412026-01-05T03:51:16 *** maxedw__ <maxedw__!sid625334@id-625334.uxbridge.irccloud.com> has quit IRC (Ping timeout: 246 seconds)
422026-01-05T03:53:52 *** maxedw__ <maxedw__!sid625334@id-625334.uxbridge.irccloud.com> has joined #bitcoin-core-dev
432026-01-05T03:59:43 *** BUSY <BUSY!~BUSY@user/busy> has joined #bitcoin-core-dev
442026-01-05T04:00:11 *** BlueMattTest1 <BlueMattTest1!~test-acct@2620:6e:a000:ce11::c> has joined #bitcoin-core-dev
452026-01-05T04:03:08 *** justache- <justache-!~justache@user/justache> has quit IRC (Ping timeout: 240 seconds)
462026-01-05T04:03:09 *** dongcarl00 <dongcarl00!~dongcarl@66.65.169.19> has quit IRC (Read error: Connection reset by peer)
472026-01-05T04:03:24 *** dongcarl00 <dongcarl00!~dongcarl@66.65.169.19> has joined #bitcoin-core-dev
482026-01-05T04:03:33 *** BlueMattMtrxBot <BlueMattMtrxBot!~bluemattm@2620:6e:a000:ce11::44> has quit IRC (*.net *.split)
492026-01-05T04:04:39 *** BlueMattMtrxBot <BlueMattMtrxBot!~bluemattm@2620:6e:a000:ce11::44> has joined #bitcoin-core-dev
502026-01-05T04:05:19 *** justache <justache!~justache@user/justache> has joined #bitcoin-core-dev
512026-01-05T04:06:40 *** BlueMattTest1 <BlueMattTest1!~test-acct@2620:6e:a000:ce11::c> has quit IRC (Ping timeout: 246 seconds)
522026-01-05T04:06:41 *** BUSY <BUSY!~BUSY@user/busy> has quit IRC (Ping timeout: 246 seconds)
532026-01-05T04:07:05 *** BUSY <BUSY!~BUSY@user/busy> has joined #bitcoin-core-dev
542026-01-05T04:08:34 *** BlueMattTest1 <BlueMattTest1!~test-acct@2620:6e:a000:ce11::c> has joined #bitcoin-core-dev
552026-01-05T05:01:32 *** cmirror <cmirror!~cmirror@4.53.92.114> has joined #bitcoin-core-dev
562026-01-05T05:04:51 <Sjors[m]1> It may seem boring, but I have a bunch of MuSig2 related things based on #29136, so please give it a review!
572026-01-05T05:04:54 <corebot> https://github.com/bitcoin/bitcoin/issues/29136 | wallet: `addhdkey` RPC to add just keys to wallets via new `unused(KEY)` descriptor by achow101 · Pull Request #29136 · bitcoin/bitcoin · GitHub
582026-01-05T05:17:19 *** TallTim_ <TallTim_!~talltim@24-124-35-28-dynamic.midco.net> has joined #bitcoin-core-dev
592026-01-05T05:18:59 *** TallTim <TallTim!~talltim@24-124-35-28-dynamic.midco.net> has quit IRC (Ping timeout: 244 seconds)
602026-01-05T05:42:59 *** kevkevin <kevkevin!~kevkevin@209.242.39.30> has quit IRC (Remote host closed the connection)
612026-01-05T05:59:04 *** kevkevin <kevkevin!~kevkevin@209.242.39.30> has joined #bitcoin-core-dev
622026-01-05T06:03:34 *** kevkevin <kevkevin!~kevkevin@209.242.39.30> has quit IRC (Ping timeout: 246 seconds)
632026-01-05T06:33:21 *** kevkevin <kevkevin!~kevkevin@209.242.39.30> has joined #bitcoin-core-dev
642026-01-05T07:03:11 *** ghost43 <ghost43!~ghost43@gateway/tor-sasl/ghost43> has quit IRC (Ping timeout: 252 seconds)
652026-01-05T07:03:54 *** kevkevin <kevkevin!~kevkevin@209.242.39.30> has quit IRC (Ping timeout: 265 seconds)
662026-01-05T07:14:15 *** ghost43 <ghost43!~ghost43@gateway/tor-sasl/ghost43> has joined #bitcoin-core-dev
672026-01-05T07:32:43 *** kevkevin <kevkevin!~kevkevin@209.242.39.30> has joined #bitcoin-core-dev
682026-01-05T07:37:01 *** kevkevin <kevkevin!~kevkevin@209.242.39.30> has quit IRC (Ping timeout: 246 seconds)
692026-01-05T07:52:28 *** kevkevin <kevkevin!~kevkevin@209.242.39.30> has joined #bitcoin-core-dev
702026-01-05T08:12:18 *** btsf_1 <btsf_1!~btsf_1@2a02:6b6f:e702:de00:d983:328c:a53:7c99> has joined #bitcoin-core-dev
712026-01-05T08:25:45 <bitcoin-git> [bitcoin] maflcko closed pull request #34167: tests: add concise docstrings in chain_tiebreaks (master...master) https://github.com/bitcoin/bitcoin/pull/34167
722026-01-05T08:42:15 *** ___nick___ <___nick___!~quassel@82-132-214-65.dab.02.net> has joined #bitcoin-core-dev
732026-01-05T08:43:41 *** ___nick___ <___nick___!~quassel@82-132-214-65.dab.02.net> has quit IRC (Client Quit)
742026-01-05T08:46:14 *** ___nick___ <___nick___!~quassel@82-132-214-65.dab.02.net> has joined #bitcoin-core-dev
752026-01-05T08:54:06 *** kevkevin <kevkevin!~kevkevin@209.242.39.30> has quit IRC (Ping timeout: 265 seconds)
762026-01-05T09:07:07 *** vasild <vasild!~vd@user/vasild> has quit IRC (Ping timeout: 252 seconds)
772026-01-05T09:07:28 *** kevkevin <kevkevin!~kevkevin@209.242.39.30> has joined #bitcoin-core-dev
782026-01-05T09:08:52 *** vasild <vasild!~vd@user/vasild> has joined #bitcoin-core-dev
792026-01-05T09:10:00 *** l0rinc <l0rinc!~l0rinc@user/l0rinc> has quit IRC (Quit: l0rinc)
802026-01-05T09:36:18 *** Guyver2 <Guyver2!Guyver@77-174-98-73.fixed.kpn.net> has joined #bitcoin-core-dev
812026-01-05T09:39:31 *** l0rinc <l0rinc!~l0rinc@user/l0rinc> has joined #bitcoin-core-dev
822026-01-05T09:52:23 *** xFFFC0000 <xFFFC0000!uid629468@id-629468.ilkley.irccloud.com> has joined #bitcoin-core-dev
832026-01-05T09:55:09 *** vasild <vasild!~vd@user/vasild> has quit IRC (Ping timeout: 252 seconds)
842026-01-05T09:56:55 *** vasild <vasild!~vd@user/vasild> has joined #bitcoin-core-dev
852026-01-05T09:58:27 *** l0rinc <l0rinc!~l0rinc@user/l0rinc> has quit IRC (Quit: l0rinc)
862026-01-05T10:10:40 *** kevkevin <kevkevin!~kevkevin@209.242.39.30> has quit IRC (Ping timeout: 246 seconds)
872026-01-05T10:41:00 *** kevkevin <kevkevin!~kevkevin@209.242.39.30> has joined #bitcoin-core-dev
882026-01-05T10:48:23 <bitcoin-git> [qa-assets] maflcko merged pull request #251: add inputs for process_message (main...2026-01-process-message) https://github.com/bitcoin-core/qa-assets/pull/251
892026-01-05T10:48:25 <bitcoin-git> [qa-assets] maflcko pushed 2 commits to main: https://github.com/bitcoin-core/qa-assets/compare/f5f602a43581...c87ae4dd4daf
902026-01-05T10:48:26 <bitcoin-git> qa-assets/main 42a8eea Bruno Garcia: add inputs for process_message
912026-01-05T10:48:26 <bitcoin-git> qa-assets/main c87ae4d maflcko: Merge pull request #251 from brunoerg/2026-01-process-message
922026-01-05T11:06:38 *** l0rinc <l0rinc!~l0rinc@user/l0rinc> has joined #bitcoin-core-dev
932026-01-05T11:25:17 <bitcoin-git> [bitcoincore.org] fanquake pushed 2 commits to master: https://github.com/bitcoin-core/bitcoincore.org/compare/3a2961fbdd58...269840c1666f
942026-01-05T11:25:17 <bitcoin-git> bitcoincore.org/master 772dd7f fanquake: Bitcoin Core 30.1
952026-01-05T11:25:18 <bitcoin-git> bitcoincore.org/master 269840c merge-script: Merge bitcoin-core/bitcoincore.org#1207: Bitcoin Core 30.1
962026-01-05T11:25:19 <bitcoin-git> [bitcoincore.org] fanquake merged pull request #1207: Bitcoin Core 30.1 (master...bitcoin_core_30_1) https://github.com/bitcoin-core/bitcoincore.org/pull/1207
972026-01-05T11:33:40 *** durandal_ <durandal_!~durandal@94.196.70.5.threembb.co.uk> has quit IRC (Ping timeout: 245 seconds)
982026-01-05T11:45:11 *** kevkevin <kevkevin!~kevkevin@209.242.39.30> has quit IRC (Ping timeout: 246 seconds)
992026-01-05T11:46:04 *** durandal_ <durandal_!~durandal@94.196.68.235.threembb.co.uk> has joined #bitcoin-core-dev
1002026-01-05T11:56:01 *** l0rinc <l0rinc!~l0rinc@user/l0rinc> has quit IRC (Quit: l0rinc)
1012026-01-05T11:56:03 *** maflcko <maflcko!~none@107.172.8.183> has quit IRC (Quit: ZNC 1.8.2+deb2ubuntu0.1 - https://znc.in)
1022026-01-05T11:56:19 *** maflcko <maflcko!~none@107.172.8.183> has joined #bitcoin-core-dev
1032026-01-05T12:00:18 *** jerryf_ <jerryf_!~jerryf@user/jerryf> has joined #bitcoin-core-dev
1042026-01-05T12:02:01 *** jerryf <jerryf!~jerryf@user/jerryf> has quit IRC (Ping timeout: 252 seconds)
1052026-01-05T12:02:05 *** PaperSword <PaperSword!~Thunderbi@securemail.qrsnap.io> has quit IRC (Quit: PaperSword)
1062026-01-05T12:06:25 *** kevkevin <kevkevin!~kevkevin@209.242.39.30> has joined #bitcoin-core-dev
1072026-01-05T12:12:20 *** adys <adys!~adys@user/adys> has quit IRC (Ping timeout: 256 seconds)
1082026-01-05T12:12:51 *** Guyver2 <Guyver2!Guyver@77-174-98-73.fixed.kpn.net> has quit IRC (Quit: Going offline, see ya! (www.adiirc.com))
1092026-01-05T12:16:21 *** ___nick___ <___nick___!~quassel@82-132-214-65.dab.02.net> has quit IRC (Read error: Connection reset by peer)
1102026-01-05T12:16:34 *** ___nick___ <___nick___!~quassel@82-132-214-65.dab.02.net> has joined #bitcoin-core-dev
1112026-01-05T12:23:42 *** Guyver2 <Guyver2!~Guyver@77.174.98.73> has joined #bitcoin-core-dev
1122026-01-05T12:51:23 *** greypw1495085720 <greypw1495085720!~greypw@user/greypw> has joined #bitcoin-core-dev
1132026-01-05T13:00:52 *** l0rinc <l0rinc!~l0rinc@user/l0rinc> has joined #bitcoin-core-dev
1142026-01-05T13:14:12 *** jerryf <jerryf!~jerryf@user/jerryf> has joined #bitcoin-core-dev
1152026-01-05T13:15:43 *** jerryf_ <jerryf_!~jerryf@user/jerryf> has quit IRC (Ping timeout: 252 seconds)
1162026-01-05T13:17:55 *** ___nick___ <___nick___!~quassel@82-132-214-65.dab.02.net> has quit IRC (Ping timeout: 240 seconds)
1172026-01-05T13:31:22 *** jerryf_ <jerryf_!~jerryf@user/jerryf> has joined #bitcoin-core-dev
1182026-01-05T13:33:27 *** btsf_1 <btsf_1!~btsf_1@2a02:6b6f:e702:de00:d983:328c:a53:7c99> has quit IRC (Remote host closed the connection)
1192026-01-05T13:33:41 *** jerryf <jerryf!~jerryf@user/jerryf> has quit IRC (Ping timeout: 252 seconds)
1202026-01-05T13:37:28 *** flooded <flooded!~flooded@149.102.226.195> has joined #bitcoin-core-dev
1212026-01-05T13:38:32 *** jerryf <jerryf!~jerryf@user/jerryf> has joined #bitcoin-core-dev
1222026-01-05T13:40:39 *** jerryf_ <jerryf_!~jerryf@user/jerryf> has quit IRC (Ping timeout: 252 seconds)
1232026-01-05T13:44:19 *** jerryf <jerryf!~jerryf@user/jerryf> has quit IRC (Ping timeout: 252 seconds)
1242026-01-05T13:45:45 *** jerryf <jerryf!~jerryf@user/jerryf> has joined #bitcoin-core-dev
1252026-01-05T13:50:49 *** jerryf_ <jerryf_!~jerryf@user/jerryf> has joined #bitcoin-core-dev
1262026-01-05T13:52:01 *** jerryf <jerryf!~jerryf@user/jerryf> has quit IRC (Ping timeout: 252 seconds)
1272026-01-05T13:55:38 *** jerryf <jerryf!~jerryf@user/jerryf> has joined #bitcoin-core-dev
1282026-01-05T13:55:58 *** kevkevin <kevkevin!~kevkevin@209.242.39.30> has quit IRC (Ping timeout: 260 seconds)
1292026-01-05T13:57:09 *** jerryf_ <jerryf_!~jerryf@user/jerryf> has quit IRC (Ping timeout: 252 seconds)
1302026-01-05T13:58:02 <bitcoin-git> [bitcoincore.org] azuchi opened pull request #1209: Add japanese translation for 30.1 (master...ja-translate-30.1) https://github.com/bitcoin-core/bitcoincore.org/pull/1209
1312026-01-05T14:05:50 <bitcoin-git> [bitcoincore.org] fanquake pushed 2 commits to master: https://github.com/bitcoin-core/bitcoincore.org/compare/269840c1666f...fafd6038084e
1322026-01-05T14:05:51 <bitcoin-git> bitcoincore.org/master 1273b2c azuchi: Add japanese translation for 30.1
1332026-01-05T14:05:51 <bitcoin-git> bitcoincore.org/master fafd603 merge-script: Merge bitcoin-core/bitcoincore.org#1209: Add japanese translation for 30.1
1342026-01-05T14:05:52 <bitcoin-git> [bitcoincore.org] fanquake merged pull request #1209: Add japanese translation for 30.1 (master...ja-translate-30.1) https://github.com/bitcoin-core/bitcoincore.org/pull/1209
1352026-01-05T14:24:39 <bitcoin-git> [qa-assets] maflcko opened pull request #252: Add fuzz inputs (main...main) https://github.com/bitcoin-core/qa-assets/pull/252
1362026-01-05T14:25:50 *** kevkevin <kevkevin!~kevkevin@209.242.39.30> has joined #bitcoin-core-dev
1372026-01-05T14:29:19 *** Guyver2 <Guyver2!~Guyver@77.174.98.73> has left #bitcoin-core-dev (Closing Window)
1382026-01-05T14:32:52 *** jon_atack <jon_atack!~jonatack@user/jonatack> has quit IRC (Ping timeout: 256 seconds)
1392026-01-05T14:51:32 <bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/bd4f4782f23b...755f0900a28a
1402026-01-05T14:51:32 <bitcoin-git> bitcoin/master fac5a1b MarcoFalke: test: Allow mempool_updatefromblock.py to run on 32-bit
1412026-01-05T14:51:32 <bitcoin-git> bitcoin/master 755f090 merge-script: Merge bitcoin/bitcoin#34136: test: Allow mempool_updatefromblock.py to run...
1422026-01-05T14:51:35 <bitcoin-git> [bitcoin] fanquake merged pull request #34136: test: Allow mempool_updatefromblock.py to run on 32-bit (master...2512-test-32-bit) https://github.com/bitcoin/bitcoin/pull/34136
1432026-01-05T15:21:28 <bitcoin-git> [bitcoin] theStack opened pull request #34203: doc: p2p: replace last remaining "command" terminology with "message type" (master...202601-doc-p2p-command-afuera) https://github.com/bitcoin/bitcoin/pull/34203
1442026-01-05T15:29:10 *** kevkevin <kevkevin!~kevkevin@209.242.39.30> has quit IRC (Ping timeout: 246 seconds)
1452026-01-05T15:37:06 *** kevkevin <kevkevin!~kevkevin@209.242.39.30> has joined #bitcoin-core-dev
1462026-01-05T15:56:43 <bitcoin-git> [bitcoin] 0xB10C opened pull request #34204: test: fix intermittent failure in p2p_addr_selfannouncement (master...2026-01-fix-addrselfanouncement-test) https://github.com/bitcoin/bitcoin/pull/34204
1472026-01-05T16:07:29 *** jadi1 <jadi1!~jadi@node-1w7jr9quqz0sdjbthwasog84s.ipv6.telus.net> has quit IRC (Ping timeout: 250 seconds)
1482026-01-05T16:41:40 *** jerryf_ <jerryf_!~jerryf@user/jerryf> has joined #bitcoin-core-dev
1492026-01-05T16:42:53 *** jerryf <jerryf!~jerryf@user/jerryf> has quit IRC (Ping timeout: 252 seconds)
1502026-01-05T16:44:24 *** jerryf <jerryf!~jerryf@user/jerryf> has joined #bitcoin-core-dev
1512026-01-05T16:46:11 *** jerryf_ <jerryf_!~jerryf@user/jerryf> has quit IRC (Ping timeout: 252 seconds)
1522026-01-05T16:51:23 *** jerryf <jerryf!~jerryf@user/jerryf> has quit IRC (Remote host closed the connection)
1532026-01-05T16:52:43 *** jerryf <jerryf!~jerryf@user/jerryf> has joined #bitcoin-core-dev
1542026-01-05T16:57:01 *** jerryf <jerryf!~jerryf@user/jerryf> has quit IRC (Remote host closed the connection)
1552026-01-05T16:57:32 *** jerryf <jerryf!~jerryf@user/jerryf> has joined #bitcoin-core-dev
1562026-01-05T16:59:03 *** jerryf <jerryf!~jerryf@user/jerryf> has quit IRC (Remote host closed the connection)
1572026-01-05T16:59:22 *** jerryf <jerryf!~jerryf@user/jerryf> has joined #bitcoin-core-dev
1582026-01-05T17:07:43 *** jerryf_ <jerryf_!~jerryf@user/jerryf> has joined #bitcoin-core-dev
1592026-01-05T17:08:19 *** jadi <jadi!~jadi@ip-208-181-103-138.adsl.radiant.net> has joined #bitcoin-core-dev
1602026-01-05T17:08:27 *** jerryf__ <jerryf__!~jerryf@user/jerryf> has joined #bitcoin-core-dev
1612026-01-05T17:09:39 *** jerryf <jerryf!~jerryf@user/jerryf> has quit IRC (Ping timeout: 252 seconds)
1622026-01-05T17:09:46 *** jerryf_ <jerryf_!~jerryf@user/jerryf> has quit IRC (Remote host closed the connection)
1632026-01-05T17:12:27 *** kevkevin <kevkevin!~kevkevin@209.242.39.30> has quit IRC (Remote host closed the connection)
1642026-01-05T17:25:02 *** adys <adys!~adys@user/adys> has joined #bitcoin-core-dev
1652026-01-05T17:27:29 <bitcoin-git> [bitcoin] fanquake pushed 10 commits to 30.x: https://github.com/bitcoin/bitcoin/compare/dd47caee822b...e9f73b8149f9
1662026-01-05T17:27:29 <bitcoin-git> bitcoin/30.x 7ea855f Hennadii Stepanov: build: Update minimum required Boost version
1672026-01-05T17:27:30 <bitcoin-git> bitcoin/30.x b734c40 fanquake: guix: reduce allowed exported symbols
1682026-01-05T17:27:30 <bitcoin-git> bitcoin/30.x f620dde brunoerg: fuzz: doc: remove any mention to address_deserialize_v2
1692026-01-05T17:27:31 <bitcoin-git> [bitcoin] fanquake merged pull request #34192: [30.x] Backports (30.x...30_2_backports) https://github.com/bitcoin/bitcoin/pull/34192
1702026-01-05T17:31:39 *** jerryf__ <jerryf__!~jerryf@user/jerryf> has quit IRC (Ping timeout: 252 seconds)
1712026-01-05T17:32:24 *** jerryf <jerryf!~jerryf@user/jerryf> has joined #bitcoin-core-dev
1722026-01-05T17:38:15 *** jadi <jadi!~jadi@ip-208-181-103-138.adsl.radiant.net> has quit IRC (Ping timeout: 240 seconds)
1732026-01-05T17:54:34 *** jadi <jadi!~jadi@ip-208-181-103-138.adsl.radiant.net> has joined #bitcoin-core-dev
1742026-01-05T17:59:49 *** Earnestly <Earnestly!~earnest@user/earnestly> has quit IRC (Ping timeout: 260 seconds)
1752026-01-05T18:00:19 *** tla_ <tla_!~tla2k21@user/tla-:23128> has quit IRC (Remote host closed the connection)
1762026-01-05T18:00:38 *** tla_ <tla_!~tla2k21@user/tla-:23128> has joined #bitcoin-core-dev
1772026-01-05T18:06:21 *** afiore <afiore!~afiore@user/afiore> has joined #bitcoin-core-dev
1782026-01-05T18:09:00 *** kevkevin <kevkevin!~kevkevin@38.88.173.10> has joined #bitcoin-core-dev
1792026-01-05T18:15:08 *** tla_ <tla_!~tla2k21@user/tla-:23128> has quit IRC (Remote host closed the connection)
1802026-01-05T18:15:18 *** tla_ <tla_!~tla2k21@user/tla-:23128> has joined #bitcoin-core-dev
1812026-01-05T18:25:14 *** Earnestly <Earnestly!~earnest@user/earnestly> has joined #bitcoin-core-dev
1822026-01-05T18:26:16 *** jerryf_ <jerryf_!~jerryf@user/jerryf> has joined #bitcoin-core-dev
1832026-01-05T18:26:17 *** adys2 <adys2!~adys@user/adys> has joined #bitcoin-core-dev
1842026-01-05T18:27:55 *** adys <adys!~adys@user/adys> has quit IRC (Ping timeout: 240 seconds)
1852026-01-05T18:27:55 *** adys2 is now known as adys
1862026-01-05T18:28:51 *** jerryf <jerryf!~jerryf@user/jerryf> has quit IRC (Ping timeout: 252 seconds)
1872026-01-05T18:30:06 *** WizJin_ <WizJin_!~Wizzy@150.129.166.255> has joined #bitcoin-core-dev
1882026-01-05T18:31:55 *** jerryf <jerryf!~jerryf@user/jerryf> has joined #bitcoin-core-dev
1892026-01-05T18:32:31 *** jerryf_ <jerryf_!~jerryf@user/jerryf> has quit IRC (Ping timeout: 252 seconds)
1902026-01-05T18:33:06 *** WizJin__ <WizJin__!~Wizzy@43.249.228.109> has quit IRC (Ping timeout: 244 seconds)
1912026-01-05T18:50:22 *** WizJin__ <WizJin__!~Wizzy@150.129.166.255> has joined #bitcoin-core-dev
1922026-01-05T18:52:20 *** jerryf_ <jerryf_!~jerryf@user/jerryf> has joined #bitcoin-core-dev
1932026-01-05T18:54:09 *** jerryf <jerryf!~jerryf@user/jerryf> has quit IRC (Ping timeout: 252 seconds)
1942026-01-05T18:54:16 *** WizJin_ <WizJin_!~Wizzy@150.129.166.255> has quit IRC (Ping timeout: 246 seconds)
1952026-01-05T18:57:13 *** cotsuka <cotsuka!~cotsuka@user/cotsuka> has quit IRC (Remote host closed the connection)
1962026-01-05T18:57:13 *** adys <adys!~adys@user/adys> has quit IRC (Read error: Connection reset by peer)
1972026-01-05T18:58:27 *** adys <adys!~adys@user/adys> has joined #bitcoin-core-dev
1982026-01-05T18:59:37 *** cotsuka <cotsuka!~cotsuka@user/cotsuka> has joined #bitcoin-core-dev
1992026-01-05T19:01:59 *** xFFFC0000 <xFFFC0000!uid629468@id-629468.ilkley.irccloud.com> has quit IRC (Quit: Connection closed for inactivity)
2002026-01-05T19:37:58 *** kevkevin <kevkevin!~kevkevin@38.88.173.10> has quit IRC (Remote host closed the connection)
2012026-01-05T19:38:19 *** Cory95 <Cory95!~Cory12@user/pasha> has quit IRC (Quit: Client closed)
2022026-01-05T19:38:35 *** Cory95 <Cory95!~Cory95@user/pasha> has joined #bitcoin-core-dev
2032026-01-05T20:00:15 *** szarka <szarka!~szarka@2603:3003:4eac:100:a50a:31e3:ce07:c419> has quit IRC (Quit: Leaving)
2042026-01-05T20:06:33 *** Cory22 <Cory22!~Cory95@user/pasha> has joined #bitcoin-core-dev
2052026-01-05T20:10:35 *** Cory95 <Cory95!~Cory95@user/pasha> has quit IRC (Ping timeout: 272 seconds)
2062026-01-05T20:31:06 <darosior> achow101_, furszy: been reading the existing wallet migration code to review #34156 and i have a few questions:
2072026-01-05T20:31:07 <darosior> - Why does HasLegacyRecords return `true` when the result of `cursor->Next` is `Status::FAIL`? I was able to change the check to just "return true if status == MORE" and no test fail.
2082026-01-05T20:31:07 <darosior> - Why is `empty_local_wallet` never set to `true` when `HasLegacyRecords()` returns `false`? Moving the line that sets `empty_local_wallet` outside the if/else block similarly does not make any test fail.
2092026-01-05T20:31:09 <corebot> https://github.com/bitcoin/bitcoin/issues/34156 | wallet: fix unnamed legacy wallet migration failure by furszy · Pull Request #34156 · bitcoin/bitcoin · GitHub
2102026-01-05T20:40:27 *** Cory5 <Cory5!~Cory22@user/pasha> has joined #bitcoin-core-dev
2112026-01-05T20:40:30 *** jerryf <jerryf!~jerryf@user/jerryf> has joined #bitcoin-core-dev
2122026-01-05T20:42:41 *** jerryf_ <jerryf_!~jerryf@user/jerryf> has quit IRC (Ping timeout: 252 seconds)
2132026-01-05T20:44:47 *** Cory22 <Cory22!~Cory95@user/pasha> has quit IRC (Ping timeout: 272 seconds)
2142026-01-05T20:45:30 <bitcoin-git> [bitcoincore.org] achow101 opened pull request #1210: Blog post about wallet migration bug in 30.x and force download page to 29.2 (master...pull-30.x) https://github.com/bitcoin-core/bitcoincore.org/pull/1210
2152026-01-05T20:49:09 <darosior> PSA ^
2162026-01-05T20:49:39 <darosior> Would be nice to get as many eyes on #34156 as possible and ship it ASAP.
2172026-01-05T20:49:41 <corebot> https://github.com/bitcoin/bitcoin/issues/34156 | wallet: fix unnamed legacy wallet migration failure by furszy · Pull Request #34156 · bitcoin/bitcoin · GitHub
2182026-01-05T20:53:10 <achow101_> darosior: "Why does HasLegacyRecords" <-- it doesn't particularly matter since BerkeleyROCursor::Next doesn't return FAIL, but == MORE is more correct
2192026-01-05T20:54:34 <achow101_> wait, nvm it's a SQLiteCursor, so FAIL can happen
2202026-01-05T20:56:58 <achow101_> "Why is `empty_local_wallet`" <-- a wallet might be intentionally empty, i.e. a blank wallet, which we want to preserve after migrating instead of deleting. the case we want to remove it is if the wallet contained only watchonly things and the resulting migrated spendable wallet contains nothing
2212026-01-05T20:57:10 <achow101_> and moving the setter into the if/else results in UB
2222026-01-05T20:57:19 *** achow101_ is now known as achow101
2232026-01-05T20:59:55 <darosior> empty_local_wallet: ah right i see. (I don't think what i actually suggested would be UB, but it would incorrect (though this is untested)).
2242026-01-05T21:00:51 <darosior> Thanks
2252026-01-05T21:02:16 *** Cory27 <Cory27!~Cory5@user/pasha> has joined #bitcoin-core-dev
2262026-01-05T21:06:11 *** zeropoint <zeropoint!~alex@45-28-139-114.lightspeed.sntcca.sbcglobal.net> has joined #bitcoin-core-dev
2272026-01-05T21:06:19 *** Cory5 <Cory5!~Cory22@user/pasha> has quit IRC (Ping timeout: 272 seconds)
2282026-01-05T21:11:26 *** Cory83 <Cory83!~Cory27@user/pasha> has joined #bitcoin-core-dev
2292026-01-05T21:15:49 *** Cory27 <Cory27!~Cory5@user/pasha> has quit IRC (Ping timeout: 272 seconds)
2302026-01-05T21:19:23 *** jerryf_ <jerryf_!~jerryf@user/jerryf> has joined #bitcoin-core-dev
2312026-01-05T21:21:11 *** jerryf <jerryf!~jerryf@user/jerryf> has quit IRC (Ping timeout: 252 seconds)
2322026-01-05T21:26:02 *** jerryf_ <jerryf_!~jerryf@user/jerryf> has quit IRC (Remote host closed the connection)
2332026-01-05T21:26:26 *** jerryf <jerryf!~jerryf@user/jerryf> has joined #bitcoin-core-dev
2342026-01-05T21:27:13 *** l0rinc <l0rinc!~l0rinc@user/l0rinc> has quit IRC (Ping timeout: 246 seconds)
2352026-01-05T21:31:43 *** l0rinc <l0rinc!~l0rinc@user/l0rinc> has joined #bitcoin-core-dev
2362026-01-05T21:45:30 *** l0rinc <l0rinc!~l0rinc@user/l0rinc> has quit IRC (Remote host closed the connection)
2372026-01-05T21:45:51 *** l0rinc <l0rinc!~l0rinc@user/l0rinc> has joined #bitcoin-core-dev
2382026-01-05T22:01:33 *** Cory90 <Cory90!~Cory83@user/pasha> has joined #bitcoin-core-dev
2392026-01-05T22:05:51 *** Cory83 <Cory83!~Cory27@user/pasha> has quit IRC (Ping timeout: 272 seconds)
2402026-01-05T22:09:54 *** zeropoint <zeropoint!~alex@45-28-139-114.lightspeed.sntcca.sbcglobal.net> has quit IRC (Quit: leaving)
2412026-01-05T22:21:41 *** WakeTrainDev <WakeTrainDev!~WakeTrain@user/WakeTrainDev> has joined #bitcoin-core-dev
2422026-01-05T22:36:35 *** l0rinc <l0rinc!~l0rinc@user/l0rinc> has quit IRC (Ping timeout: 240 seconds)
2432026-01-05T22:40:18 *** kevkevin <kevkevin!~kevkevin@209.242.39.30> has joined #bitcoin-core-dev
2442026-01-05T22:44:35 *** kevkevin <kevkevin!~kevkevin@209.242.39.30> has quit IRC (Ping timeout: 240 seconds)
2452026-01-05T22:56:54 <bitcoin-git> [bitcoin] achow101 pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/755f0900a28a...d6a6afd955b5
2462026-01-05T22:56:54 <bitcoin-git> bitcoin/master 5805a8b rkrux: psbt: detect invalid MuSig2 pubkeys in deserialization
2472026-01-05T22:56:55 <bitcoin-git> bitcoin/master d6a6afd Ava Chow: Merge bitcoin/bitcoin#34010: psbt: detect invalid MuSig2 pubkeys in deseri...
2482026-01-05T22:56:55 <bitcoin-git> [bitcoin] achow101 merged pull request #34010: psbt: detect invalid MuSig2 pubkeys in deserialization (master...musig-key-fix) https://github.com/bitcoin/bitcoin/pull/34010
2492026-01-05T23:14:57 *** LainIwakura <LainIwakura!~LainIwaku@user/LainIwakura> has joined #bitcoin-core-dev
2502026-01-05T23:18:02 <bitcoin-git> [bitcoin] achow101 pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/d6a6afd955b5...c267b3a2c695
2512026-01-05T23:18:03 <bitcoin-git> bitcoin/master 4ce3f4a Sebastian Falbesoner: rpc, net: deprecate `startingheight` field of `getpeerinfo` RPC
2522026-01-05T23:18:03 <bitcoin-git> bitcoin/master c267b3a Ava Chow: Merge bitcoin/bitcoin#34197: rpc, net: deprecate `startingheight` field of...
2532026-01-05T23:18:04 <bitcoin-git> [bitcoin] achow101 merged pull request #34197: rpc, net: deprecate `startingheight` field of `getpeerinfo` RPC (master...202601-deprecate-startingheight) https://github.com/bitcoin/bitcoin/pull/34197
2542026-01-05T23:19:49 <darosior> I think this comment is outdated right? We don't flush to disk every 1000 writes, or am i missing something? https://github.com/bitcoin/bitcoin/blob/c267b3a2c695179de686c00f7a455e8f99476342/src/wallet/walletdb.h#L190
2552026-01-05T23:20:18 <darosior> Looks like it was removed in c0f3f3264ff7f17c39c00c4409a48580f98d4f57 (introduced in d6576e349e8a)
2562026-01-05T23:22:43 <achow101> darosior: yes
2572026-01-05T23:24:42 *** LainIwakura <LainIwakura!~LainIwaku@user/LainIwakura> has quit IRC (Quit: Client closed)
2582026-01-05T23:31:55 *** adys <adys!~adys@user/adys> has quit IRC (Ping timeout: 240 seconds)
2592026-01-05T23:32:28 *** adys <adys!~adys@user/adys> has joined #bitcoin-core-dev
2602026-01-05T23:47:01 <WakeTrainDev> if the starting height / blocks field is getting deprecated from the rpc, is it still going to be sent in the version message?
2612026-01-05T23:48:13 <bitcoin-git> [bitcoin] achow101 pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/c267b3a2c695...0ad4376a49fa
2622026-01-05T23:48:14 <bitcoin-git> bitcoin/master fa9fdbc MarcoFalke: test: Pass bench exe into test framework utils
2632026-01-05T23:48:14 <bitcoin-git> bitcoin/master fa65bc0 MarcoFalke: test: Run bench sanity checks in parallel with functional tests
2642026-01-05T23:48:14 <bitcoin-git> bitcoin/master 0ad4376 Ava Chow: Merge bitcoin/bitcoin#33142: test: Run bench sanity checks in parallel wit...
2652026-01-05T23:48:15 <bitcoin-git> [bitcoin] achow101 merged pull request #33142: test: Run bench sanity checks in parallel with functional tests (master...2508-bench-faster-sanity) https://github.com/bitcoin/bitcoin/pull/33142
2662026-01-05T23:49:14 <achow101> WakeTrainDev: no