12026-01-06T00:00:52 *** jadi <jadi!~jadi@ip-208-181-103-138.adsl.radiant.net> has quit IRC (Ping timeout: 246 seconds)
22026-01-06T00:02:29 *** jadi <jadi!~jadi@ip-208-181-103-138.adsl.radiant.net> has joined #bitcoin-core-dev
32026-01-06T00:09:57 <lightlike> achow101: not convinced: removing it (as in always sending zero instead?) could break compatibility with other software, including old versions of core. I guess we could work around with versioning, but I don't really see the point, just for one field.
42026-01-06T00:10:27 <achow101> whoops, misread that message. meant to say no it's not being removed
52026-01-06T00:10:40 <lightlike> oh ok :)
62026-01-06T00:17:26 <WakeTrainDev> i'm assuming it's going to be set to -1 or similar in the version message, and removed from qt/peer list as well
72026-01-06T00:17:49 <WakeTrainDev> at least thats how i read it :P
82026-01-06T00:25:43 *** durandal_ <durandal_!~durandal@94.196.68.235.threembb.co.uk> has quit IRC (Ping timeout: 246 seconds)
92026-01-06T00:26:59 <lightlike> yes, not worth the compatibility troubles imo. removing from the gui seems unproblematic though.
102026-01-06T00:27:51 *** jerryf_ <jerryf_!~jerryf@user/jerryf> has joined #bitcoin-core-dev
112026-01-06T00:30:01 *** jerryf <jerryf!~jerryf@user/jerryf> has quit IRC (Ping timeout: 252 seconds)
122026-01-06T00:36:43 *** jonatack <jonatack!~jonatack@user/jonatack> has joined #bitcoin-core-dev
132026-01-06T00:39:59 *** durandal_ <durandal_!~durandal@94.196.68.235.threembb.co.uk> has joined #bitcoin-core-dev
142026-01-06T00:43:41 *** jerryf <jerryf!~jerryf@user/jerryf> has joined #bitcoin-core-dev
152026-01-06T00:46:09 *** jerryf_ <jerryf_!~jerryf@user/jerryf> has quit IRC (Ping timeout: 252 seconds)
162026-01-06T00:52:08 *** jerryf_ <jerryf_!~jerryf@user/jerryf> has joined #bitcoin-core-dev
172026-01-06T00:53:51 *** jerryf <jerryf!~jerryf@user/jerryf> has quit IRC (Ping timeout: 252 seconds)
182026-01-06T00:54:46 *** kevkevin <kevkevin!~kevkevin@209.242.39.30> has joined #bitcoin-core-dev
192026-01-06T01:35:23 *** jadi <jadi!~jadi@ip-208-181-103-138.adsl.radiant.net> has quit IRC (Ping timeout: 260 seconds)
202026-01-06T01:35:58 <bitcoin-git> [gui] waketraindev opened pull request #921: Remove deprecated "Starting Block" from Peer Detail (master...pr/qt_remove_startingheight) https://github.com/bitcoin-core/gui/pull/921
212026-01-06T01:37:38 *** WakeTrainDev <WakeTrainDev!~WakeTrain@user/WakeTrainDev> has quit IRC (Quit: Client closed)
222026-01-06T01:40:09 <bitcoin-git> [bitcoincore.org] achow101 pushed 3 commits to master: https://github.com/bitcoin-core/bitcoincore.org/compare/fafd6038084e...998889d8170c
232026-01-06T01:40:09 <bitcoin-git> bitcoincore.org/master 1edf9cb Ava Chow: posts: Add post about wallet migration deletion bug
242026-01-06T01:40:09 <bitcoin-git> bitcoincore.org/master 160ca44 Ava Chow: templates: Force download page to 29.2
252026-01-06T01:40:10 <bitcoin-git> bitcoincore.org/master 998889d Ava Chow: Merge bitcoin-core/bitcoincore.org#1210: Blog post about wallet migration ...
262026-01-06T01:40:11 <bitcoin-git> [bitcoincore.org] achow101 merged pull request #1210: Blog post about wallet migration bug in 30.x and force download page to 29.2 (master...pull-30.x) https://github.com/bitcoin-core/bitcoincore.org/pull/1210
272026-01-06T01:40:48 *** kevkevin <kevkevin!~kevkevin@209.242.39.30> has quit IRC (Remote host closed the connection)
282026-01-06T02:13:01 <bitcoin-git> [bitcoincore.org] azuchi opened pull request #1211: Add japanese translation for wallet migration bug (master...ja-translate-wallet-migration-bug) https://github.com/bitcoin-core/bitcoincore.org/pull/1211
292026-01-06T02:55:02 *** dongcarl000 <dongcarl000!~dongcarl@66.65.169.19> has joined #bitcoin-core-dev
302026-01-06T02:55:20 *** maflcko <maflcko!~none@107.172.8.183> has quit IRC (Quit: ZNC 1.8.2+deb2ubuntu0.1 - https://znc.in)
312026-01-06T02:55:20 *** dongcarl00 <dongcarl00!~dongcarl@66.65.169.19> has quit IRC (Read error: Connection reset by peer)
322026-01-06T02:55:20 *** Earnestly <Earnestly!~earnest@user/earnestly> has quit IRC (Ping timeout: 240 seconds)
332026-01-06T02:55:37 *** maflcko <maflcko!~none@107.172.8.183> has joined #bitcoin-core-dev
342026-01-06T02:59:10 *** Earnestly <Earnestly!~earnest@user/earnestly> has joined #bitcoin-core-dev
352026-01-06T03:00:51 *** _flood <_flood!~flooded@149.102.226.195> has joined #bitcoin-core-dev
362026-01-06T03:01:28 *** cotsuka <cotsuka!~cotsuka@user/cotsuka> has quit IRC (Ping timeout: 246 seconds)
372026-01-06T03:01:47 *** TallTim_ <TallTim_!~talltim@24-124-35-28-dynamic.midco.net> has quit IRC (Read error: Connection reset by peer)
382026-01-06T03:01:50 *** flooded <flooded!~flooded@149.102.226.195> has quit IRC (Ping timeout: 246 seconds)
392026-01-06T03:02:04 *** TallTim_ <TallTim_!~talltim@24-124-35-28-dynamic.midco.net> has joined #bitcoin-core-dev
402026-01-06T03:16:22 *** cotsuka <cotsuka!~cotsuka@user/cotsuka> has joined #bitcoin-core-dev
412026-01-06T03:41:10 *** BGL <BGL!sixty@75.149.171.58> has quit IRC (Ping timeout: 245 seconds)
422026-01-06T04:46:10 *** gekk0 <gekk0!~gekk0@user/gekk0> has joined #bitcoin-core-dev
432026-01-06T04:47:54 *** abubakarsadiq <abubakarsadiq!uid602234@id-602234.hampstead.irccloud.com> has joined #bitcoin-core-dev
442026-01-06T04:48:55 <bitcoin-git> [bitcoincore.org] azuchi opened pull request #1212: Fix overlapping text in multi-line post title (master...fix-overlapping-text) https://github.com/bitcoin-core/bitcoincore.org/pull/1212
452026-01-06T05:01:01 *** cmirror <cmirror!~cmirror@4.53.92.114> has quit IRC (Remote host closed the connection)
462026-01-06T05:01:32 *** cmirror <cmirror!~cmirror@4.53.92.114> has joined #bitcoin-core-dev
472026-01-06T05:15:13 <bitcoin-git> [bitcoincore.org] achow101 pushed 2 commits to master: https://github.com/bitcoin-core/bitcoincore.org/compare/998889d8170c...a5d03d8588f1
482026-01-06T05:15:14 <bitcoin-git> bitcoincore.org/master 0287a9b azuchi: Add japanese translation for wallet migration bug
492026-01-06T05:15:14 <bitcoin-git> bitcoincore.org/master a5d03d8 Ava Chow: Merge bitcoin-core/bitcoincore.org#1211: Add japanese translation for wall...
502026-01-06T05:15:15 <bitcoin-git> [bitcoincore.org] achow101 merged pull request #1211: Add japanese translation for wallet migration bug (master...ja-translate-wallet-migration-bug) https://github.com/bitcoin-core/bitcoincore.org/pull/1211
512026-01-06T05:21:55 *** BGL <BGL!ninety@75.149.171.58> has joined #bitcoin-core-dev
522026-01-06T06:43:43 *** maflcko <maflcko!~none@107.172.8.183> has quit IRC (Ping timeout: 240 seconds)
532026-01-06T06:46:53 *** maflcko <maflcko!~none@107.172.8.183> has joined #bitcoin-core-dev
542026-01-06T06:48:01 *** _flood <_flood!~flooded@149.102.226.195> has quit IRC (Ping timeout: 240 seconds)
552026-01-06T07:00:10 *** BGL <BGL!ninety@75.149.171.58> has quit IRC (Ping timeout: 246 seconds)
562026-01-06T07:03:27 *** ghost43 <ghost43!~ghost43@gateway/tor-sasl/ghost43> has quit IRC (Ping timeout: 252 seconds)
572026-01-06T07:09:08 *** ghost43 <ghost43!~ghost43@gateway/tor-sasl/ghost43> has joined #bitcoin-core-dev
582026-01-06T07:14:25 <bitcoin-git> [bitcoin] maflcko closed pull request #34117: net: reduce log level for PCP/NAT-PMP NOT_AUTHORIZED failures (master...master) https://github.com/bitcoin/bitcoin/pull/34117
592026-01-06T07:43:15 *** moisteroyster <moisteroyster!~moisteroy@static.116.60.217.95.clients.your-server.de> has joined #bitcoin-core-dev
602026-01-06T08:38:09 *** BGL <BGL!sixty@75.149.171.58> has joined #bitcoin-core-dev
612026-01-06T08:40:48 *** l0rinc <l0rinc!~l0rinc@user/l0rinc> has joined #bitcoin-core-dev
622026-01-06T08:42:27 *** jerryf_ <jerryf_!~jerryf@user/jerryf> has quit IRC (Ping timeout: 252 seconds)
632026-01-06T08:44:23 *** jerryf <jerryf!~jerryf@user/jerryf> has joined #bitcoin-core-dev
642026-01-06T08:48:17 *** Guyver2 <Guyver2!~Guyver@77-174-98-73.fixed.kpn.net> has joined #bitcoin-core-dev
652026-01-06T09:10:50 *** durandal_ <durandal_!~durandal@94.196.68.235.threembb.co.uk> has quit IRC (Quit: Leaving)
662026-01-06T09:12:42 *** durandal_ <durandal_!~durandal@94.196.68.235.threembb.co.uk> has joined #bitcoin-core-dev
672026-01-06T09:36:15 *** merilin <merilin!~merilyn@172.103.166.66> has joined #bitcoin-core-dev
682026-01-06T09:38:21 <bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/0ad4376a49fa...d7cbdfa090b2
692026-01-06T09:38:22 <bitcoin-git> bitcoin/master 3185205 0xb10c: test: fix intermittent failure in p2p_addr_selfannouncement
702026-01-06T09:38:22 <bitcoin-git> bitcoin/master d7cbdfa merge-script: Merge bitcoin/bitcoin#34204: test: fix intermittent failure in p2p_addr_se...
712026-01-06T09:38:23 <bitcoin-git> [bitcoin] fanquake merged pull request #34204: test: fix intermittent failure in p2p_addr_selfannouncement (master...2026-01-fix-addrselfanouncement-test) https://github.com/bitcoin/bitcoin/pull/34204
722026-01-06T09:41:07 *** jerryf_ <jerryf_!~jerryf@user/jerryf> has joined #bitcoin-core-dev
732026-01-06T09:41:28 *** jerryf__ <jerryf__!~jerryf@user/jerryf> has joined #bitcoin-core-dev
742026-01-06T09:42:35 *** jerryf <jerryf!~jerryf@user/jerryf> has quit IRC (Ping timeout: 252 seconds)
752026-01-06T09:42:37 *** jerryf_ <jerryf_!~jerryf@user/jerryf> has quit IRC (Read error: Connection reset by peer)
762026-01-06T09:46:05 <bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/d7cbdfa090b2...114901c0655d
772026-01-06T09:46:06 <bitcoin-git> bitcoin/master 5b7bf47 Sebastian Falbesoner: doc: p2p: replace last remaining "command" terminology with "message type"
782026-01-06T09:46:07 <bitcoin-git> bitcoin/master 114901c merge-script: Merge bitcoin/bitcoin#34203: doc: p2p: replace last remaining "command" te...
792026-01-06T09:46:42 <bitcoin-git> [bitcoin] fanquake merged pull request #34203: doc: p2p: replace last remaining "command" terminology with "message type" (master...202601-doc-p2p-command-afuera) https://github.com/bitcoin/bitcoin/pull/34203
802026-01-06T09:47:02 *** jerryf__ <jerryf__!~jerryf@user/jerryf> has quit IRC (Remote host closed the connection)
812026-01-06T09:47:26 *** jerryf <jerryf!~jerryf@user/jerryf> has joined #bitcoin-core-dev
822026-01-06T09:53:21 *** jerryf_ <jerryf_!~jerryf@user/jerryf> has joined #bitcoin-core-dev
832026-01-06T09:55:47 *** jerryf <jerryf!~jerryf@user/jerryf> has quit IRC (Ping timeout: 252 seconds)
842026-01-06T09:59:28 *** Guyver2 <Guyver2!~Guyver@77-174-98-73.fixed.kpn.net> has left #bitcoin-core-dev (Closing Window)
852026-01-06T10:11:18 *** l0rinc <l0rinc!~l0rinc@user/l0rinc> has quit IRC (Quit: l0rinc)
862026-01-06T10:13:19 *** jerryf_ <jerryf_!~jerryf@user/jerryf> has quit IRC (Remote host closed the connection)
872026-01-06T10:13:45 *** jerryf <jerryf!~jerryf@user/jerryf> has joined #bitcoin-core-dev
882026-01-06T10:20:28 *** jerryf_ <jerryf_!~jerryf@user/jerryf> has joined #bitcoin-core-dev
892026-01-06T10:20:34 *** jerryf <jerryf!~jerryf@user/jerryf> has quit IRC (Remote host closed the connection)
902026-01-06T10:26:04 *** ___nick___ <___nick___!~quassel@82-132-213-96.dab.02.net> has joined #bitcoin-core-dev
912026-01-06T10:27:02 *** ___nick___ <___nick___!~quassel@82-132-213-96.dab.02.net> has quit IRC (Client Quit)
922026-01-06T10:28:56 *** ___nick___ <___nick___!~quassel@82-132-213-96.dab.02.net> has joined #bitcoin-core-dev
932026-01-06T10:45:57 *** l0rinc <l0rinc!~l0rinc@user/l0rinc> has joined #bitcoin-core-dev
942026-01-06T11:04:51 *** ozdeadman <ozdeadman!~deadmanoz@user/deadmanoz> has joined #bitcoin-core-dev
952026-01-06T11:06:40 *** ozdeadman <ozdeadman!~deadmanoz@user/deadmanoz> has quit IRC (Quit: ZNC 1.7.5+deb4 - https://znc.in)
962026-01-06T11:07:38 *** deadmanoz <deadmanoz!~deadmanoz@user/deadmanoz> has joined #bitcoin-core-dev
972026-01-06T11:12:13 *** Guest36 <Guest36!~Guest36@103.147.174.195> has joined #bitcoin-core-dev
982026-01-06T11:12:30 *** Guest36 <Guest36!~Guest36@103.147.174.195> has quit IRC (Client Quit)
992026-01-06T11:20:14 *** vasild <vasild!~vd@user/vasild> has quit IRC (Quit: leaving)
1002026-01-06T11:21:07 *** l0rinc <l0rinc!~l0rinc@user/l0rinc> has quit IRC (Ping timeout: 244 seconds)
1012026-01-06T11:21:54 *** l0rinc <l0rinc!~l0rinc@user/l0rinc> has joined #bitcoin-core-dev
1022026-01-06T11:25:14 <bitcoin-git> [bitcoin] l0rinc opened pull request #34207: coins/refactor: enforce `GetCoin()` returns only unspent coins (master...l0rinc/getcoin-unspent) https://github.com/bitcoin/bitcoin/pull/34207
1032026-01-06T11:27:00 *** vasild <vasild!~vd@user/vasild> has joined #bitcoin-core-dev
1042026-01-06T11:45:40 <bitcoin-git> [bitcoin] l0rinc opened pull request #34208: bench: add fluent API for untimed `setup` steps in nanobench (master...l0rinc/untimed-setup-nanobench) https://github.com/bitcoin/bitcoin/pull/34208
1052026-01-06T12:02:55 *** ___nick___ <___nick___!~quassel@82-132-213-96.dab.02.net> has quit IRC (Ping timeout: 240 seconds)
1062026-01-06T12:03:37 *** ___nick___ <___nick___!~quassel@82-132-213-96.dab.02.net> has joined #bitcoin-core-dev
1072026-01-06T13:18:24 *** ___nick___ <___nick___!~quassel@82-132-213-96.dab.02.net> has quit IRC (Ping timeout: 244 seconds)
1082026-01-06T13:22:02 *** memset <memset!~memset@gateway/tor-sasl/memset> has quit IRC (Remote host closed the connection)
1092026-01-06T13:22:43 *** memset <memset!~memset@gateway/tor-sasl/memset> has joined #bitcoin-core-dev
1102026-01-06T13:31:29 *** Cory90 <Cory90!~Cory83@user/pasha> has quit IRC (Quit: Client closed)
1112026-01-06T13:31:49 *** Cory90 <Cory90!~Cory90@user/pasha> has joined #bitcoin-core-dev
1122026-01-06T13:34:54 *** ___nick___ <___nick___!~quassel@82-132-214-168.dab.02.net> has joined #bitcoin-core-dev
1132026-01-06T13:49:09 *** jerryf <jerryf!~jerryf@user/jerryf> has joined #bitcoin-core-dev
1142026-01-06T13:51:33 *** jerryf_ <jerryf_!~jerryf@user/jerryf> has quit IRC (Ping timeout: 252 seconds)
1152026-01-06T13:56:25 *** jerryf_ <jerryf_!~jerryf@user/jerryf> has joined #bitcoin-core-dev
1162026-01-06T13:56:35 *** jonatack <jonatack!~jonatack@user/jonatack> has quit IRC (Ping timeout: 250 seconds)
1172026-01-06T13:59:37 *** jerryf <jerryf!~jerryf@user/jerryf> has quit IRC (Ping timeout: 252 seconds)
1182026-01-06T14:01:56 *** eugenesiegel <eugenesiegel!~eugenesie@user/eugenesiegel> has joined #bitcoin-core-dev
1192026-01-06T14:10:04 *** eugenesiegel <eugenesiegel!~eugenesie@user/eugenesiegel> has quit IRC (Quit: Client closed)
1202026-01-06T14:20:38 *** jamesob443688173 <jamesob443688173!~jamesob@pool-70-106-190-236.clppva.fios.verizon.net> has joined #bitcoin-core-dev
1212026-01-06T14:20:39 *** jamesob1566593 <jamesob1566593!~jamesob@pool-70-106-190-236.clppva.fios.verizon.net> has joined #bitcoin-core-dev
1222026-01-06T14:31:18 *** WakeTrainDev <WakeTrainDev!~WakeTrain@user/WakeTrainDev> has joined #bitcoin-core-dev
1232026-01-06T14:52:59 *** WakeTrainDev <WakeTrainDev!~WakeTrain@user/WakeTrainDev> has quit IRC (Quit: leaving)
1242026-01-06T14:54:17 *** dongcarl000 <dongcarl000!~dongcarl@66.65.169.19> has quit IRC (Read error: Connection reset by peer)
1252026-01-06T14:54:38 *** dongcarl000 <dongcarl000!~dongcarl@66.65.169.19> has joined #bitcoin-core-dev
1262026-01-06T14:55:09 *** WakeTrainDev <WakeTrainDev!~WakeTrain@user/WakeTrainDev> has joined #bitcoin-core-dev
1272026-01-06T15:00:51 *** kevkevin <kevkevin!~kevkevin@209.242.39.30> has joined #bitcoin-core-dev
1282026-01-06T15:02:25 *** willcl-ark <willcl-ark!~willcl-ar@user/willcl-ark> has quit IRC (Ping timeout: 264 seconds)
1292026-01-06T15:02:29 *** willcl-ark_ <willcl-ark_!~willcl-ar@150.228.36.148> has joined #bitcoin-core-dev
1302026-01-06T15:24:14 *** flooded <flooded!~flooded@149.102.226.195> has joined #bitcoin-core-dev
1312026-01-06T15:24:52 *** Cory90 <Cory90!~Cory90@user/pasha> has quit IRC (Quit: Client closed)
1322026-01-06T15:25:11 *** Cory90 <Cory90!~Cory90@user/pasha> has joined #bitcoin-core-dev
1332026-01-06T15:32:13 *** deadmanoz <deadmanoz!~deadmanoz@user/deadmanoz> has quit IRC (Quit: Leaving)
1342026-01-06T15:34:06 *** deadmanoz <deadmanoz!~deadmanoz@user/deadmanoz> has joined #bitcoin-core-dev
1352026-01-06T15:51:53 <bitcoin-git> [bitcoin] fanquake pushed 6 commits to master: https://github.com/bitcoin/bitcoin/compare/114901c0655d...c60f9cb66ee7
1362026-01-06T15:51:53 <bitcoin-git> bitcoin/master 01ffcf4 Pieter Wuille: clusterlin: support fixing linearizations (feature)
1372026-01-06T15:51:54 <bitcoin-git> bitcoin/master 62dd886 Pieter Wuille: txgraph: drop NEEDS_SPLIT_ACCEPTABLE (simplification)
1382026-01-06T15:51:54 <bitcoin-git> bitcoin/master 3380e0c Pieter Wuille: txgraph: use PostLinearize less prior to linearizing
1392026-01-06T15:51:55 <bitcoin-git> [bitcoin] fanquake merged pull request #34085: cluster mempool: exploit SFL properties in txgraph (master...202512_txgraph_sfl) https://github.com/bitcoin/bitcoin/pull/34085
1402026-01-06T16:18:17 <bitcoin-git> [bitcoin] fanquake opened pull request #34209: [30.x]: Final backports & 30.2rc1 (30.x...30_2_rc1) https://github.com/bitcoin/bitcoin/pull/34209
1412026-01-06T16:30:36 *** jerryf <jerryf!~jerryf@user/jerryf> has joined #bitcoin-core-dev
1422026-01-06T16:32:01 *** jerryf <jerryf!~jerryf@user/jerryf> has quit IRC (Remote host closed the connection)
1432026-01-06T16:32:23 *** jerryf <jerryf!~jerryf@user/jerryf> has joined #bitcoin-core-dev
1442026-01-06T16:32:53 *** jerryf_ <jerryf_!~jerryf@user/jerryf> has quit IRC (Ping timeout: 252 seconds)
1452026-01-06T16:37:09 *** jerryf_ <jerryf_!~jerryf@user/jerryf> has joined #bitcoin-core-dev
1462026-01-06T16:38:45 *** jerryf <jerryf!~jerryf@user/jerryf> has quit IRC (Ping timeout: 252 seconds)
1472026-01-06T16:41:47 *** ___nick___ <___nick___!~quassel@82-132-214-168.dab.02.net> has quit IRC (Quit: No Ping reply in 180 seconds.)
1482026-01-06T16:43:11 *** ___nick___ <___nick___!~quassel@82-132-214-168.dab.02.net> has joined #bitcoin-core-dev
1492026-01-06T16:43:21 <bitcoin-git> [bitcoin] maflcko opened pull request #34210: bench: Remove -priority-level= option (master...2601-bench-less-prio) https://github.com/bitcoin/bitcoin/pull/34210
1502026-01-06T16:47:32 *** l0rinc <l0rinc!~l0rinc@user/l0rinc> has quit IRC (Quit: l0rinc)
1512026-01-06T16:48:59 <bitcoin-git> [bitcoin] D33r-Gee opened pull request #34211: build: Alt restore cross-compilation for Android (master...260601-android-deployqt-build) https://github.com/bitcoin/bitcoin/pull/34211
1522026-01-06T16:49:06 <bitcoin-git> [bitcoin] DrahtBot closed pull request #34211: build: Alt restore cross-compilation for Android (master...260601-android-deployqt-build) https://github.com/bitcoin/bitcoin/pull/34211
1532026-01-06T16:50:13 <bitcoin-git> [bitcoin] hebasto reopened pull request #34211: build: Alt restore cross-compilation for Android (master...260601-android-deployqt-build) https://github.com/bitcoin/bitcoin/pull/34211
1542026-01-06T17:09:41 *** jadi <jadi!~jadi@ip-208-181-103-138.adsl.radiant.net> has joined #bitcoin-core-dev
1552026-01-06T17:23:30 *** l0rinc <l0rinc!~l0rinc@user/l0rinc> has joined #bitcoin-core-dev
1562026-01-06T17:39:37 *** jadi <jadi!~jadi@ip-208-181-103-138.adsl.radiant.net> has quit IRC (Ping timeout: 264 seconds)
1572026-01-06T17:47:10 *** jadi <jadi!~jadi@ip-208-181-103-138.adsl.radiant.net> has joined #bitcoin-core-dev
1582026-01-06T17:48:36 *** l0rinc <l0rinc!~l0rinc@user/l0rinc> has quit IRC (Quit: l0rinc)
1592026-01-06T17:50:44 <furszy> darosior: "Why does HasLegacyRecords" --> At that point, we've just created the sqlite db. The FAIL return could only happen if the db is busy, locked, the API is misused (which we ensure is not the case for all this three), or⦠if there is a memory allocation failure.
1602026-01-06T17:52:34 <furszy> this last one could cause an issue (and should be fixed). But still, we are talking about a non-realistic scenario. bitcoind would fail much earlier if there is no enough memory.
1612026-01-06T17:54:14 <darosior> Yeah it does seem unrealistic, was just going through the possible cases systematically
1622026-01-06T17:54:57 <furszy> all good, keep going. The more eyes, the better
1632026-01-06T17:55:42 <darosior> On the other hand this is the kind of things where we are better off just doing the "more correct" thing just in case, to harden against future modifications of the code where reviewers may not realize that a function named `HasLegacyRecords()`, possibly outside of a PR's diff, actually returns true on failure
1642026-01-06T18:10:28 *** ___nick___ <___nick___!~quassel@82-132-214-168.dab.02.net> has quit IRC (Quit: No Ping reply in 180 seconds.)
1652026-01-06T18:11:11 *** dzxzg <dzxzg!~dzxzg@user/dzxzg> has joined #bitcoin-core-dev
1662026-01-06T18:12:07 *** ___nick___ <___nick___!~quassel@82-132-214-168.dab.02.net> has joined #bitcoin-core-dev
1672026-01-06T18:20:21 *** szarka <szarka!~szarka@2603:3003:4eac:100:855c:56fe:bcfb:a697> has joined #bitcoin-core-dev
1682026-01-06T18:29:39 *** WizJin_ <WizJin_!~Wizzy@43.249.228.126> has joined #bitcoin-core-dev
1692026-01-06T18:32:48 *** WizJin__ <WizJin__!~Wizzy@150.129.166.255> has quit IRC (Ping timeout: 252 seconds)
1702026-01-06T18:34:49 *** jadi <jadi!~jadi@ip-208-181-103-138.adsl.radiant.net> has quit IRC (Ping timeout: 264 seconds)
1712026-01-06T18:36:37 *** jadi <jadi!~jadi@ip-208-181-103-138.adsl.radiant.net> has joined #bitcoin-core-dev
1722026-01-06T18:37:28 *** abubakarsadiq <abubakarsadiq!uid602234@id-602234.hampstead.irccloud.com> has quit IRC (Quit: Connection closed for inactivity)
1732026-01-06T18:39:28 *** BUSY <BUSY!~BUSY@user/busy> has quit IRC (Ping timeout: 246 seconds)
1742026-01-06T18:42:34 *** BUSY <BUSY!~BUSY@user/busy> has joined #bitcoin-core-dev
1752026-01-06T18:50:24 *** WizJin__ <WizJin__!~Wizzy@43.249.228.126> has joined #bitcoin-core-dev
1762026-01-06T18:54:37 *** WizJin_ <WizJin_!~Wizzy@43.249.228.126> has quit IRC (Ping timeout: 264 seconds)
1772026-01-06T19:01:30 *** Cory17 <Cory17!~Cory90@user/pasha> has joined #bitcoin-core-dev
1782026-01-06T19:05:33 *** Cory90 <Cory90!~Cory90@user/pasha> has quit IRC (Ping timeout: 272 seconds)
1792026-01-06T19:14:56 *** ___nick___ <___nick___!~quassel@82-132-214-168.dab.02.net> has quit IRC (Read error: Connection reset by peer)
1802026-01-06T19:15:10 *** ___nick___ <___nick___!~quassel@82-132-214-168.dab.02.net> has joined #bitcoin-core-dev
1812026-01-06T19:26:13 <bitcoin-git> [bitcoin] BitcoinMechanic opened pull request #34212: doc: Clarify -migratewallet can be used to delete private keys (master...fix-docs) https://github.com/bitcoin/bitcoin/pull/34212
1822026-01-06T19:26:19 <bitcoin-git> [bitcoin] DrahtBot closed pull request #34212: . (master...fix-docs) https://github.com/bitcoin/bitcoin/pull/34212
1832026-01-06T19:37:55 *** deadmanoz <deadmanoz!~deadmanoz@user/deadmanoz> has quit IRC (Ping timeout: 240 seconds)
1842026-01-06T19:38:50 *** deadmanoz <deadmanoz!~deadmanoz@user/deadmanoz> has joined #bitcoin-core-dev
1852026-01-06T19:53:43 *** adys <adys!~adys@user/adys> has quit IRC (Ping timeout: 264 seconds)
1862026-01-06T19:56:10 *** Chris_Stewart_5 <Chris_Stewart_5!~Chris_Ste@static-68-235-46-71.cust.tzulo.com> has quit IRC (Ping timeout: 245 seconds)
1872026-01-06T19:58:43 *** Cory94 <Cory94!~Cory17@user/pasha> has joined #bitcoin-core-dev
1882026-01-06T20:02:33 *** Cory17 <Cory17!~Cory90@user/pasha> has quit IRC (Ping timeout: 272 seconds)
1892026-01-06T20:07:52 *** jonatack <jonatack!~jonatack@user/jonatack> has joined #bitcoin-core-dev
1902026-01-06T20:16:02 *** jerryf <jerryf!~jerryf@user/jerryf> has joined #bitcoin-core-dev
1912026-01-06T20:16:07 *** jerryf_ <jerryf_!~jerryf@user/jerryf> has quit IRC (Remote host closed the connection)
1922026-01-06T20:27:21 *** jerryf_ <jerryf_!~jerryf@user/jerryf> has joined #bitcoin-core-dev
1932026-01-06T20:28:17 *** jerryf <jerryf!~jerryf@user/jerryf> has quit IRC (Ping timeout: 252 seconds)
1942026-01-06T20:32:01 *** jerryf_ <jerryf_!~jerryf@user/jerryf> has quit IRC (Remote host closed the connection)
1952026-01-06T20:34:13 *** jerryf <jerryf!~jerryf@user/jerryf> has joined #bitcoin-core-dev
1962026-01-06T21:03:53 *** robszarka <robszarka!~szarka@2603:3003:4eac:100:7810:ee4e:38b6:2f9f> has joined #bitcoin-core-dev
1972026-01-06T21:04:15 *** ___nick___ <___nick___!~quassel@82-132-214-168.dab.02.net> has quit IRC (Ping timeout: 240 seconds)
1982026-01-06T21:05:30 *** Cory28 <Cory28!~Cory94@user/pasha> has joined #bitcoin-core-dev
1992026-01-06T21:06:49 *** szarka <szarka!~szarka@2603:3003:4eac:100:855c:56fe:bcfb:a697> has quit IRC (Ping timeout: 246 seconds)
2002026-01-06T21:09:41 *** Cory94 <Cory94!~Cory17@user/pasha> has quit IRC (Ping timeout: 272 seconds)
2012026-01-06T21:26:20 <bitcoin-git> [bitcoin] brunoerg opened pull request #34213: net: do not read/dump anchors if network is not active (master...2026-01-net-anchors-networkactive) https://github.com/bitcoin/bitcoin/pull/34213
2022026-01-06T21:29:21 <bitcoin-git> [bitcoin] bensig opened pull request #34214: policy: restore 80-byte default for datacarriersize (master...revert-datacarrier-default) https://github.com/bitcoin/bitcoin/pull/34214
2032026-01-06T21:30:59 *** jamesob1566593 <jamesob1566593!~jamesob@pool-70-106-190-236.clppva.fios.verizon.net> has quit IRC (Read error: Connection reset by peer)
2042026-01-06T21:31:01 *** jamesob443688173 <jamesob443688173!~jamesob@pool-70-106-190-236.clppva.fios.verizon.net> has quit IRC (Read error: Connection reset by peer)
2052026-01-06T21:31:16 *** Cory56 <Cory56!~Cory28@user/pasha> has joined #bitcoin-core-dev
2062026-01-06T21:32:03 *** Cory5 <Cory5!~Cory56@user/pasha> has joined #bitcoin-core-dev
2072026-01-06T21:33:13 *** jamesob443688173 <jamesob443688173!~jamesob@pool-70-106-190-236.clppva.fios.verizon.net> has joined #bitcoin-core-dev
2082026-01-06T21:33:13 *** jamesob1566593 <jamesob1566593!~jamesob@pool-70-106-190-236.clppva.fios.verizon.net> has joined #bitcoin-core-dev
2092026-01-06T21:34:01 *** afiore <afiore!~afiore@user/afiore> has quit IRC (Remote host closed the connection)
2102026-01-06T21:34:38 *** afiore <afiore!~afiore@user/afiore> has joined #bitcoin-core-dev
2112026-01-06T21:35:39 *** Cory28 <Cory28!~Cory94@user/pasha> has quit IRC (Ping timeout: 272 seconds)
2122026-01-06T21:36:17 *** Cory56 <Cory56!~Cory28@user/pasha> has quit IRC (Ping timeout: 272 seconds)
2132026-01-06T21:51:42 <bitcoin-git> [bitcoin] pinheadmz closed pull request #34214: policy: restore 80-byte default for datacarriersize (master...revert-datacarrier-default) https://github.com/bitcoin/bitcoin/pull/34214
2142026-01-06T21:53:34 *** l0rinc <l0rinc!~l0rinc@user/l0rinc> has joined #bitcoin-core-dev
2152026-01-06T21:57:17 *** Guest80 <Guest80!~Guest80@2603:8081:3ff0:add0:2c5f:7eb3:5194:5a18> has joined #bitcoin-core-dev
2162026-01-06T21:58:09 *** Guest80 <Guest80!~Guest80@2603:8081:3ff0:add0:2c5f:7eb3:5194:5a18> has quit IRC (Client Quit)
2172026-01-06T22:02:04 *** Cory82 <Cory82!~Cory5@user/pasha> has joined #bitcoin-core-dev
2182026-01-06T22:06:03 *** Cory5 <Cory5!~Cory56@user/pasha> has quit IRC (Ping timeout: 272 seconds)
2192026-01-06T22:29:38 *** l0rinc <l0rinc!~l0rinc@user/l0rinc> has quit IRC (Quit: l0rinc)
2202026-01-06T22:34:03 *** kevkevin_ <kevkevin_!~kevkevin@209.242.39.26> has joined #bitcoin-core-dev
2212026-01-06T22:35:53 *** kevkevin <kevkevin!~kevkevin@209.242.39.30> has quit IRC (Ping timeout: 244 seconds)
2222026-01-06T22:40:55 *** robszarka <robszarka!~szarka@2603:3003:4eac:100:7810:ee4e:38b6:2f9f> has quit IRC (Quit: Leaving)
2232026-01-06T22:41:48 *** szarka <szarka!~szarka@2603:3003:4eac:100:7810:ee4e:38b6:2f9f> has joined #bitcoin-core-dev
2242026-01-06T22:46:54 *** kevkevin <kevkevin!~kevkevin@209.242.39.30> has joined #bitcoin-core-dev
2252026-01-06T22:47:16 *** kevkevin_ <kevkevin_!~kevkevin@209.242.39.26> has quit IRC (Ping timeout: 246 seconds)
2262026-01-06T23:21:43 *** shesek7 <shesek7!~shesek@user/shesek> has joined #bitcoin-core-dev
2272026-01-06T23:23:25 *** shesek <shesek!~shesek@user/shesek> has quit IRC (Ping timeout: 264 seconds)
2282026-01-06T23:23:25 *** shesek7 is now known as shesek
2292026-01-06T23:31:06 *** PaperSword <PaperSword!~Thunderbi@securemail.qrsnap.io> has joined #bitcoin-core-dev
2302026-01-06T23:39:01 *** justache <justache!~justache@user/justache> has quit IRC (Ping timeout: 264 seconds)
2312026-01-06T23:40:49 *** WakeTrainDev <WakeTrainDev!~WakeTrain@user/WakeTrainDev> has quit IRC (Quit: leaving)
2322026-01-06T23:50:43 *** justache <justache!~justache@user/justache> has joined #bitcoin-core-dev
2332026-01-06T23:59:06 <bitcoin-git> [bitcoin] achow101 pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/c60f9cb66ee7...a9daa6dbd3ae
2342026-01-06T23:59:07 <bitcoin-git> bitcoin/master fafbc70 MarcoFalke: rpc: [wallet] Use unsigned type for tx version in sendall
2352026-01-06T23:59:07 <bitcoin-git> bitcoin/master a9daa6d Ava Chow: Merge bitcoin/bitcoin#34135: rpc: [wallet] Use unsigned type for tx versio...
2362026-01-06T23:59:08 <bitcoin-git> [bitcoin] achow101 merged pull request #34135: rpc: [wallet] Use unsigned type for tx version in sendall (master...2512-rpc-wallet-less-i32) https://github.com/bitcoin/bitcoin/pull/34135