12026-08-19T00:03:29 *** jonatack <jonatack!~jonatack@user/jonatack> has joined #bitcoin-core-dev
22026-08-19T00:11:38 *** memset <memset!~memset@gateway/tor-sasl/memset> has quit IRC (Remote host closed the connection)
32026-08-19T00:11:58 *** memset <memset!~memset@gateway/tor-sasl/memset> has joined #bitcoin-core-dev
42026-08-19T00:14:07 *** afiore <afiore!~afiore@user/afiore> has quit IRC (Remote host closed the connection)
52026-08-19T00:16:11 *** lhj98787 <lhj98787!~lhj98787@2601:240:cd01:c0d3:90bb:9eb:dfb5:ce80> has quit IRC (Quit: lhj98787)
62026-08-19T00:17:18 *** afiore <afiore!~afiore@user/afiore> has joined #bitcoin-core-dev
72026-08-19T00:52:27 *** Guest86 <Guest86!~Guest86@2a04:4e41:1600:f43e::2f33:743e> has joined #bitcoin-core-dev
82026-08-19T00:53:01 *** Guest86 <Guest86!~Guest86@2a04:4e41:1600:f43e::2f33:743e> has quit IRC (Client Quit)
92026-08-19T00:58:58 *** w0xlt <w0xlt!~w0xlt@99.95.229.189> has quit IRC (Remote host closed the connection)
102026-08-19T01:02:27 *** jonatack <jonatack!~jonatack@user/jonatack> has quit IRC (Ping timeout: 276 seconds)
112026-08-19T01:02:52 *** jonatack <jonatack!~jonatack@user/jonatack> has joined #bitcoin-core-dev
122026-08-19T01:29:28 *** adil <adil!~Thunderbi@2402:4000:2301:6c03:3d6f:4604:7c12:89b2> has joined #bitcoin-core-dev
132026-08-19T01:57:16 *** ___nick___ <___nick___!~quassel@82-132-236-14.dab.02.net> has quit IRC (Quit: https://quassel-irc.org - Chat comfortably. Anywhere.)
142026-08-19T01:59:15 *** ___nick___ <___nick___!~quassel@82-132-236-14.dab.02.net> has joined #bitcoin-core-dev
152026-08-19T02:00:04 *** jonatack <jonatack!~jonatack@user/jonatack> has quit IRC (Ping timeout: 269 seconds)
162026-08-19T02:00:07 *** ___nick___ <___nick___!~quassel@82-132-236-14.dab.02.net> has quit IRC (Client Quit)
172026-08-19T02:00:27 *** jon_atack <jon_atack!~jonatack@user/jonatack> has joined #bitcoin-core-dev
182026-08-19T02:02:20 *** adil <adil!~Thunderbi@2402:4000:2301:6c03:3d6f:4604:7c12:89b2> has quit IRC (Quit: adil)
192026-08-19T02:02:29 *** ___nick___ <___nick___!~quassel@82-132-236-14.dab.02.net> has joined #bitcoin-core-dev
202026-08-19T02:56:11 *** jon_atack <jon_atack!~jonatack@user/jonatack> has quit IRC (Ping timeout: 272 seconds)
212026-08-19T02:58:03 *** jonatack <jonatack!~jonatack@user/jonatack> has joined #bitcoin-core-dev
222026-08-19T03:06:06 *** jon_atack <jon_atack!~jonatack@user/jonatack> has joined #bitcoin-core-dev
232026-08-19T03:06:36 *** jonatack <jonatack!~jonatack@user/jonatack> has quit IRC (Ping timeout: 276 seconds)
242026-08-19T03:40:00 *** memset <memset!~memset@gateway/tor-sasl/memset> has quit IRC (Remote host closed the connection)
252026-08-19T03:41:23 *** memset <memset!~memset@gateway/tor-sasl/memset> has joined #bitcoin-core-dev
262026-08-19T03:53:10 *** jon_atack <jon_atack!~jonatack@user/jonatack> has quit IRC (Ping timeout: 244 seconds)
272026-08-19T03:55:47 *** jonatack <jonatack!~jonatack@user/jonatack> has joined #bitcoin-core-dev
282026-08-19T04:01:01 *** cmirror <cmirror!~cmirror@4.53.92.114> has quit IRC (Remote host closed the connection)
292026-08-19T04:01:33 *** cmirror <cmirror!~cmirror@4.53.92.114> has joined #bitcoin-core-dev
302026-08-19T04:11:52 *** ChanServ <ChanServ!ChanServ@services.libera.chat> has quit IRC (shutting down)
312026-08-19T04:17:40 *** ChanServ <ChanServ!ChanServ@services.libera.chat> has joined #bitcoin-core-dev
322026-08-19T04:17:40 *** gallium.libera.chat sets mode: +o ChanServ
332026-08-19T04:19:32 *** l0rinc <l0rinc!~l0rinc@user/l0rinc> has quit IRC (Quit: l0rinc)
342026-08-19T04:22:10 *** jonatack <jonatack!~jonatack@user/jonatack> has quit IRC (Read error: Connection reset by peer)
352026-08-19T05:03:51 *** l0rinc <l0rinc!~l0rinc@user/l0rinc> has joined #bitcoin-core-dev
362026-08-19T05:04:18 *** afiore <afiore!~afiore@user/afiore> has quit IRC (Remote host closed the connection)
372026-08-19T05:04:35 *** afiore <afiore!~afiore@user/afiore> has joined #bitcoin-core-dev
382026-08-19T05:06:32 *** phungus8153520 <phungus8153520!~phungus@47.24.199.213> has quit IRC (Quit: Ping timeout (120 seconds))
392026-08-19T05:11:05 *** afiore_ <afiore_!~afiore@user/afiore> has joined #bitcoin-core-dev
402026-08-19T05:11:23 *** afiore <afiore!~afiore@user/afiore> has quit IRC (Remote host closed the connection)
412026-08-19T05:11:29 *** afiore_ is now known as afiore
422026-08-19T05:19:34 *** afiore <afiore!~afiore@user/afiore> has quit IRC (Remote host closed the connection)
432026-08-19T05:22:05 *** afiore <afiore!~afiore@user/afiore> has joined #bitcoin-core-dev
442026-08-19T06:02:03 *** lightningbot <lightningbot!lightningb@azure.erisian.com.au> has quit IRC (Server closed connection)
452026-08-19T06:21:41 *** lightningbot <lightningbot!~supybot@2400:8901::f03c:91ff:febb:bbc1> has joined #bitcoin-core-dev
462026-08-19T06:38:19 *** enochazariah_ <enochazariah_!uid710351@id-710351.hampstead.irccloud.com> has joined #bitcoin-core-dev
472026-08-19T07:17:51 *** tegila <tegila!~tegila@189.37.64.225> has joined #bitcoin-core-dev
482026-08-19T07:21:25 *** tegila_ <tegila_!~tegila@189.37.68.102> has quit IRC (Ping timeout: 266 seconds)
492026-08-19T07:28:57 *** Guyver2 <Guyver2!~Guyver@77-174-98-73.fixed.kpn.net> has joined #bitcoin-core-dev
502026-08-19T07:44:20 *** l0rinc <l0rinc!~l0rinc@user/l0rinc> has quit IRC (Quit: l0rinc)
512026-08-19T07:47:14 *** javi404 <javi404!~quassel@2601:58b:4a81:a8e1:b24f:e2dd:b79f:9c95> has quit IRC (Ping timeout: 244 seconds)
522026-08-19T07:47:55 *** javi404 <javi404!~quassel@2601:58b:4a81:a8e1:b24f:e2dd:b79f:9c95> has joined #bitcoin-core-dev
532026-08-19T07:53:06 *** conman <conman!~con@180-150-21-3.b49615.mel.static.aussiebb.net> has quit IRC (Quit: Konversation terminated!)
542026-08-19T07:57:07 *** conman <conman!~con@2403-5803-70b2-0-3f29-23da-35a2-fe61.ip6.aussiebb.net> has joined #bitcoin-core-dev
552026-08-19T08:15:16 *** memset <memset!~memset@gateway/tor-sasl/memset> has quit IRC (Remote host closed the connection)
562026-08-19T08:15:54 *** memset <memset!~memset@gateway/tor-sasl/memset> has joined #bitcoin-core-dev
572026-08-19T08:20:19 *** enochazariah <enochazariah!~enochazar@user/enochazariah> has joined #bitcoin-core-dev
582026-08-19T08:21:35 *** Guyver2 <Guyver2!~Guyver@77-174-98-73.fixed.kpn.net> has left #bitcoin-core-dev (Closing Window)
592026-08-19T08:38:26 *** jarolrod_ <jarolrod_!sid475272@uxbridge.irccloud.com> has quit IRC (Server closed connection)
602026-08-19T08:38:34 *** jarolrod_ <jarolrod_!sid475272@id-475272.uxbridge.irccloud.com> has joined #bitcoin-core-dev
612026-08-19T08:50:50 *** RubenSomsen <RubenSomsen!sid301948@user/rubensomsen> has quit IRC (Server closed connection)
622026-08-19T08:51:07 *** RubenSomsen <RubenSomsen!sid301948@user/rubensomsen> has joined #bitcoin-core-dev
632026-08-19T09:03:04 *** svanstaa_ <svanstaa_!~quassel@2a00:4841:173c:bf00:b951:5d80:8ba9:94e9> has joined #bitcoin-core-dev
642026-08-19T09:03:27 *** svanstaa <svanstaa!~quassel@2a00:4841:173c:bf00:23bb:9d47:b10d:5010> has quit IRC (Ping timeout: 268 seconds)
652026-08-19T09:32:36 *** smartin <smartin!~Thunderbi@78.56.226.85> has quit IRC (Quit: smartin)
662026-08-19T09:32:47 *** smartin2 <smartin2!~Thunderbi@78.56.226.85> has joined #bitcoin-core-dev
672026-08-19T09:35:04 *** smartin2 is now known as smartin
682026-08-19T10:05:57 *** SpellChecker_ <SpellChecker_!~SpellChec@user/SpellChecker> has joined #bitcoin-core-dev
692026-08-19T10:06:45 *** SpellChecker <SpellChecker!~SpellChec@user/SpellChecker> has quit IRC (Ping timeout: 252 seconds)
702026-08-19T10:06:46 *** greypw1495085720 <greypw1495085720!~greypw@user/greypw> has quit IRC (Ping timeout: 252 seconds)
712026-08-19T10:07:45 *** ghost43_ <ghost43_!~ghost43@gateway/tor-sasl/ghost43> has joined #bitcoin-core-dev
722026-08-19T10:07:51 *** ghost43 <ghost43!~ghost43@gateway/tor-sasl/ghost43> has quit IRC (Ping timeout: 252 seconds)
732026-08-19T10:28:29 *** johnny9dev <johnny9dev!johnny9dev@user/johnny9dev> has quit IRC (Server closed connection)
742026-08-19T10:28:41 *** johnny9dev <johnny9dev!johnny9dev@user/johnny9dev> has joined #bitcoin-core-dev
752026-08-19T10:45:42 *** kinlo <kinlo!~peter@user/kinlo> has quit IRC (Server closed connection)
762026-08-19T10:45:52 *** kinlo <kinlo!~peter@user/kinlo> has joined #bitcoin-core-dev
772026-08-19T11:07:14 *** mbrochh_ <mbrochh_!uid3052@helmsley.irccloud.com> has quit IRC (Server closed connection)
782026-08-19T11:07:26 *** mbrochh_ <mbrochh_!sid3052@id-3052.helmsley.irccloud.com> has joined #bitcoin-core-dev
792026-08-19T11:38:59 *** Guest66 <Guest66!~Guest66@2604:9cc0:14:4b25:2331:4127:77a5:6ad> has joined #bitcoin-core-dev
802026-08-19T11:40:18 *** Guest66 <Guest66!~Guest66@2604:9cc0:14:4b25:2331:4127:77a5:6ad> has quit IRC (Client Quit)
812026-08-19T11:40:33 *** Guest66 <Guest66!~Guest66@2604:9cc0:14:4b25:2331:4127:77a5:6ad> has joined #bitcoin-core-dev
822026-08-19T11:42:40 *** Guest66 <Guest66!~Guest66@2604:9cc0:14:4b25:2331:4127:77a5:6ad> has quit IRC (Client Quit)
832026-08-19T12:08:57 *** ghost43_ <ghost43_!~ghost43@gateway/tor-sasl/ghost43> has quit IRC (Remote host closed the connection)
842026-08-19T12:09:09 *** ghost43 <ghost43!~ghost43@gateway/tor-sasl/ghost43> has joined #bitcoin-core-dev
852026-08-19T12:16:04 *** ghost43 <ghost43!~ghost43@gateway/tor-sasl/ghost43> has quit IRC (Remote host closed the connection)
862026-08-19T12:16:33 *** ghost43 <ghost43!~ghost43@gateway/tor-sasl/ghost43> has joined #bitcoin-core-dev
872026-08-19T12:26:27 *** ghost43 <ghost43!~ghost43@gateway/tor-sasl/ghost43> has quit IRC (Ping timeout: 252 seconds)
882026-08-19T12:28:08 *** ghost43 <ghost43!~ghost43@gateway/tor-sasl/ghost43> has joined #bitcoin-core-dev
892026-08-19T12:46:09 *** pzafonte_ <pzafonte_!~pzafonte@user/pzafonte> has quit IRC (Ping timeout: 244 seconds)
902026-08-19T13:02:02 *** ghost43 <ghost43!~ghost43@gateway/tor-sasl/ghost43> has quit IRC (Remote host closed the connection)
912026-08-19T13:02:24 *** ghost43 <ghost43!~ghost43@gateway/tor-sasl/ghost43> has joined #bitcoin-core-dev
922026-08-19T13:25:21 *** katsu <katsu!~0x0ff@user/0x0ff/x-0302470> has quit IRC (Server closed connection)
932026-08-19T13:26:27 *** pzafonte <pzafonte!~pzafonte@user/pzafonte> has joined #bitcoin-core-dev
942026-08-19T13:31:35 *** bugs_ <bugs_!~bugs@user/bugs/x-5128603> has joined #bitcoin-core-dev
952026-08-19T13:40:41 *** fjahr <fjahr!sid374480@uxbridge.irccloud.com> has quit IRC (Server closed connection)
962026-08-19T13:40:52 *** fjahr <fjahr!sid374480@id-374480.uxbridge.irccloud.com> has joined #bitcoin-core-dev
972026-08-19T14:03:01 *** jonatack <jonatack!~jonatack@user/jonatack> has joined #bitcoin-core-dev
982026-08-19T14:06:52 *** diego <diego!~diego@2804:14c:5781:8ef3:6a16:a749:b59:acad> has left #bitcoin-core-dev
992026-08-19T14:07:50 *** dviola <dviola!~diego@user/dviola> has joined #bitcoin-core-dev
1002026-08-19T14:11:27 *** SpellChecker_ <SpellChecker_!~SpellChec@user/SpellChecker> has quit IRC (Quit: bye)
1012026-08-19T14:11:50 *** SpellChecker <SpellChecker!~SpellChec@user/SpellChecker> has joined #bitcoin-core-dev
1022026-08-19T14:24:46 *** SpellChecker <SpellChecker!~SpellChec@user/SpellChecker> has quit IRC (Remote host closed the connection)
1032026-08-19T14:25:34 *** SpellChecker <SpellChecker!~SpellChec@user/SpellChecker> has joined #bitcoin-core-dev
1042026-08-19T14:25:56 *** Guest42 <Guest42!~Guest42@108.181.23.123> has joined #bitcoin-core-dev
1052026-08-19T14:28:01 *** Guest42 <Guest42!~Guest42@108.181.23.123> has quit IRC (Client Quit)
1062026-08-19T14:28:19 *** Guest42 <Guest42!~Guest42@108.181.23.123> has joined #bitcoin-core-dev
1072026-08-19T14:28:24 *** Guest42 <Guest42!~Guest42@108.181.23.123> has quit IRC (Client Quit)
1082026-08-19T14:29:35 *** ozdeadman <ozdeadman!~deadmanoz@user/deadmanoz> has joined #bitcoin-core-dev
1092026-08-19T14:30:24 *** deadmanoz <deadmanoz!~deadmanoz@user/deadmanoz> has quit IRC (Ping timeout: 276 seconds)
1102026-08-19T14:37:20 *** adil <adil!~Thunderbi@2402:4000:2301:6c03:3d6f:4604:7c12:89b2> has joined #bitcoin-core-dev
1112026-08-19T14:38:43 <dviola> hebasto: hi, I managed to solve that specific problem here: https://github.com/bitcoin-core/gui/pull/948#issuecomment-5337430176 -- but honestly, I think freespacechecker.cpp needs an overhaul, right now when passing -blocksdir via gArgs.IsArgSet, dataDir becomes the blocksdir path and by the look of it, freespacechecker.cpp wasn't designed around that assumption, but it works
1122026-08-19T14:39:18 <dviola> anyway, I'm not too familiar with the code in freespacechecker.cpp so I can't be the one to make that refactor, or at least not yet
1132026-08-19T14:40:32 *** tegila <tegila!~tegila@189.37.64.225> has quit IRC (Ping timeout: 252 seconds)
1142026-08-19T14:49:10 *** SpellChecker <SpellChecker!~SpellChec@user/SpellChecker> has quit IRC (Remote host closed the connection)
1152026-08-19T14:49:25 *** SpellChecker <SpellChecker!~SpellChec@user/SpellChecker> has joined #bitcoin-core-dev
1162026-08-19T14:56:47 *** tegila <tegila!~tegila@189.37.64.225> has joined #bitcoin-core-dev
1172026-08-19T14:58:17 <dviola> I'd probably change freespacechecker.cpp to consider 1 or all paths bitcoin-qt knows about, combine their sizes and estimate
1182026-08-19T14:58:24 *** jonatack <jonatack!~jonatack@user/jonatack> has quit IRC (Ping timeout: 263 seconds)
1192026-08-19T14:59:17 *** jonatack <jonatack!~jonatack@user/jonatack> has joined #bitcoin-core-dev
1202026-08-19T15:02:12 *** enochazariah <enochazariah!~enochazar@user/enochazariah> has quit IRC (Ping timeout: 242 seconds)
1212026-08-19T15:04:25 *** enochazariah <enochazariah!~enochazar@user/enochazariah> has joined #bitcoin-core-dev
1222026-08-19T15:04:58 <dviola> thank you for testing btw
1232026-08-19T15:07:01 <maflcko> I don't think we need to treat authors and co-authors differently. Any author is already required to fully understand the complete patch (and required to could have written it themselves). So I think it is fine to apply the same policy to co-authors and avoid introducing a new policy for this.
1242026-08-19T15:08:35 <fanquake> I was going to mention that in this case, https://github.com/bitcoin/bitcoin/pull/36000#discussion_r3806893819, I don't see why I'd be added as co-author. I barely glanced at the code, and just merged it into another branch to run a benchmark
1252026-08-19T15:09:19 *** Guest53 <Guest53!~Guest53@2001:861:32c0:b800:f292:1cff:fe8a:a44e> has joined #bitcoin-core-dev
1262026-08-19T15:09:26 <fanquake> If everyone is a co-author, it starts to make git blame less useful, and it's not clear who actually understands, or can be asked questions about the code (now or in future)
1272026-08-19T15:10:53 *** Guest53 <Guest53!~Guest53@2001:861:32c0:b800:f292:1cff:fe8a:a44e> has quit IRC (Client Quit)
1282026-08-19T15:12:06 *** Guest53 <Guest53!~Guest53@2001:861:32c0:b800:f292:1cff:fe8a:a44e> has joined #bitcoin-core-dev
1292026-08-19T15:16:10 <maflcko> Also (re low-prio AI issues): I agree that it is fine to file them in the public repo. If needed, they can be marked with a label such as ON_HOLD or LOW_PRIO and if needed DrahtBot can automatically close all pulls fixing such issues as ai slop.
1302026-08-19T15:16:47 *** Guest53 <Guest53!~Guest53@2001:861:32c0:b800:f292:1cff:fe8a:a44e> has quit IRC (Client Quit)
1312026-08-19T15:19:46 *** Guest53 <Guest53!~Guest53@2001:861:32c0:b800:f292:1cff:fe8a:a44e> has joined #bitcoin-core-dev
1322026-08-19T15:21:47 *** adil <adil!~Thunderbi@2402:4000:2301:6c03:3d6f:4604:7c12:89b2> has quit IRC (Quit: adil)
1332026-08-19T15:23:38 *** tegila <tegila!~tegila@189.37.64.225> has quit IRC (Ping timeout: 256 seconds)
1342026-08-19T15:24:30 *** tegila <tegila!~tegila@189.37.64.225> has joined #bitcoin-core-dev
1352026-08-19T15:25:58 *** Guest53 <Guest53!~Guest53@2001:861:32c0:b800:f292:1cff:fe8a:a44e> has quit IRC (Quit: Client closed)
1362026-08-19T15:27:22 *** Guest10 <Guest10!~Guest10@114.10.82.35> has joined #bitcoin-core-dev
1372026-08-19T15:27:22 *** enochazariah <enochazariah!~enochazar@user/enochazariah> has quit IRC (Read error: Connection reset by peer)
1382026-08-19T15:30:53 *** Guest10 <Guest10!~Guest10@114.10.82.35> has quit IRC (Client Quit)
1392026-08-19T15:32:57 *** enochazariah <enochazariah!~enochazar@user/enochazariah> has joined #bitcoin-core-dev
1402026-08-19T15:33:40 *** Guest54 <Guest54!~Guest54@2001:861:32c0:b800:f292:1cff:fe8a:a44e> has joined #bitcoin-core-dev
1412026-08-19T15:34:22 *** Guest54 <Guest54!~Guest54@2001:861:32c0:b800:f292:1cff:fe8a:a44e> has quit IRC (Client Quit)
1422026-08-19T15:37:35 <dviola> the problem with changing freespacechecker.cpp is that you have to change all the other things that call it
1432026-08-19T15:38:23 *** pzafonte <pzafonte!~pzafonte@user/pzafonte> has quit IRC (Quit: Lost terminal)
1442026-08-19T15:38:52 <hebasto> dviola: have you checked handling of blocksdir in https://github.com/bitcoin-core/gui-qml ?
1452026-08-19T15:39:19 <dviola> not yet, I'll take a look
1462026-08-19T15:42:45 <andrewtoth_> maflcko: I guess what we need clarity on is in what circumstances we should add a contributor as a co-author to a commit we have authored?
1472026-08-19T15:43:51 <maflcko> I'd say only if they have substantially (co-) authored a good chunk of the patch (and fully understand the whole patch)
1482026-08-19T15:56:21 *** jonatack <jonatack!~jonatack@user/jonatack> has quit IRC (Ping timeout: 265 seconds)
1492026-08-19T15:58:29 *** jonatack <jonatack!~jonatack@user/jonatack> has joined #bitcoin-core-dev
1502026-08-19T16:03:06 *** janb84 <janb84!~janb84@user/janb84> has quit IRC (Remote host closed the connection)
1512026-08-19T16:07:28 *** janb84 <janb84!~janb84@user/janb84> has joined #bitcoin-core-dev
1522026-08-19T16:08:59 *** _flood <_flood!~flooded@149.88.18.225> has quit IRC (Remote host closed the connection)
1532026-08-19T16:09:26 *** _flood <_flood!~flooded@149.88.18.225> has joined #bitcoin-core-dev
1542026-08-19T16:21:26 *** enochazariah <enochazariah!~enochazar@user/enochazariah> has quit IRC (Ping timeout: 264 seconds)
1552026-08-19T16:36:02 *** l0rinc <l0rinc!~l0rinc@user/l0rinc> has joined #bitcoin-core-dev
1562026-08-19T16:38:54 *** l0rinc <l0rinc!~l0rinc@user/l0rinc> has quit IRC (Client Quit)
1572026-08-19T16:43:01 *** l0rinc <l0rinc!~l0rinc@user/l0rinc> has joined #bitcoin-core-dev
1582026-08-19T16:48:39 *** WizJin <WizJin!~Wizzy@user/WizJin> has joined #bitcoin-core-dev
1592026-08-19T16:51:30 <sipa> fanquake: if co-authors are expected to understand the whole patch, that would mean it's not just a means of giving credit but comes with a responsibility as well, and you should probably have permission from the co-author to list them? I think that's perhaps a step too far. My interpretation of it is really something like "you wrote a patch which could reasonably be a commit on its own, but for
1602026-08-19T16:51:36 <sipa> logistical reasons i squashed it into mine", which doesn't...
1612026-08-19T16:51:38 <sipa> imply you understand the whole combined patch. I think this makes sense, as it's roughly the point where you'd be considered a copyright holder
1622026-08-19T16:53:17 *** jonatack <jonatack!~jonatack@user/jonatack> has quit IRC (Ping timeout: 265 seconds)
1632026-08-19T16:55:22 <fanquake> sipa: sure, I donât know where the bar is exactly, I just think itâs gotta be higher than someone cloning and running the code
1642026-08-19T16:57:32 <sipa> fanquake: my friendly neighborhood LLM says that the bar for claiming copyright ownership is a rather subjective "threshold of originality", but many people use a 5-10 line patch limit as rule of thumb.
1652026-08-19T16:58:05 <sipa> I think this matches with my interpretation of "co-author", you basically contributed (the near-actual code of, not just the idea) of a substantial function
1662026-08-19T16:58:07 *** sliv3r__ <sliv3r__!~sliv3r__@user/sliv3r-:76883> has quit IRC (Quit: ZNC 1.8.2+deb3.1+deb12u1 - https://znc.in)
1672026-08-19T16:58:22 *** sliv3r__ <sliv3r__!~sliv3r__@user/sliv3r-:76883> has joined #bitcoin-core-dev
1682026-08-19T16:59:16 <sipa> So I'd say just assisting with a PR, doing benchmarks, providing review comments/ideas... not co-author. You need to actually have contributed code that got included in the commit.
1692026-08-19T16:59:34 <sipa> On the other hand, I also don't think co-authorship needs to come with a responsibility of being able to explain the entire commit.
1702026-08-19T17:02:57 <sipa> unrelatedly, anyone know how to resolve this error when building --preset libfuzzer-nosan?
1712026-08-19T17:03:00 <sipa> /home/pw/git/bitcoin/src/ipc/libmultiprocess/src/mp/gen.cpp:277:23: error: use of undeclared identifier 'capnp_PREFIX' 277 | args.emplace_back(capnp_PREFIX "/bin/capnp");
1722026-08-19T17:08:15 <sipa> -DENABLE_IPC=OFF helps, but i don't see why (and why it doesn't happen with --prefix libfuzzer)
1732026-08-19T17:20:32 *** WizJin <WizJin!~Wizzy@user/WizJin> has quit IRC (Quit: Leaving)
1742026-08-19T17:25:16 *** jonatack <jonatack!~jonatack@user/jonatack> has joined #bitcoin-core-dev
1752026-08-19T17:42:29 *** schmidty <schmidty!sid297174@lymington.irccloud.com> has quit IRC (Server closed connection)
1762026-08-19T17:42:40 *** schmidty <schmidty!sid297174@id-297174.lymington.irccloud.com> has joined #bitcoin-core-dev
1772026-08-19T17:49:11 *** dzxzg <dzxzg!~dzxzg@user/dzxzg> has joined #bitcoin-core-dev
1782026-08-19T17:51:36 <hebasto> sipa: cannot reproduce on my machine; `libmultiprocess/cmake/compat_config.cmake` is involved, so the detailed description of the affected system is needed
1792026-08-19T17:54:24 <hebasto> just in case, please assure that the build tree is empty
1802026-08-19T17:54:54 *** jerryf <jerryf!~jerryf@user/jerryf> has joined #bitcoin-core-dev
1812026-08-19T18:02:07 <sipa> yeah, i wiped the build_fuzz_nosan directory and recreated it
1822026-08-19T18:02:17 <sipa> don't worry about it if it's not easily reproducible
1832026-08-19T18:04:38 *** dzxzg2 <dzxzg2!~dzxzg@user/dzxzg> has joined #bitcoin-core-dev
1842026-08-19T18:04:48 *** dzxzg <dzxzg!~dzxzg@user/dzxzg> has quit IRC (Ping timeout: 248 seconds)
1852026-08-19T18:07:46 *** jerryf <jerryf!~jerryf@user/jerryf> has quit IRC (Remote host closed the connection)
1862026-08-19T18:08:10 *** jerryf <jerryf!~jerryf@user/jerryf> has joined #bitcoin-core-dev
1872026-08-19T18:20:17 *** whist <whist!~y0ungbra1@user/whist> has quit IRC (Server closed connection)
1882026-08-19T18:20:32 *** whist <whist!~y0ungbra1@user/whist> has joined #bitcoin-core-dev
1892026-08-19T18:21:19 *** WizJin <WizJin!~Wizzy@user/WizJin> has joined #bitcoin-core-dev
1902026-08-19T18:39:49 *** hacker4web3bitco <hacker4web3bitco!~hacker4we@user/hacker4web3bitco> has quit IRC (Ping timeout: 263 seconds)
1912026-08-19T18:40:29 *** hacker4web3bitco <hacker4web3bitco!~hacker4we@user/hacker4web3bitco> has joined #bitcoin-core-dev
1922026-08-19T18:43:29 *** _flood <_flood!~flooded@149.88.18.225> has quit IRC (Remote host closed the connection)
1932026-08-19T18:54:02 <dviola> hebasto: https://github.com/bitcoin-core/gui-qml/blob/qt6/qml/onboarding_settings.cpp#L157-L171
1942026-08-19T18:54:40 <dviola> I haven't tested yet (ran the code) but it does look similar to what I'm doing with args.IsArgSet("-blocksdir")
1952026-08-19T18:59:10 <dviola> that either provides the blocksdir path or datadir path, not both (I think)
1962026-08-19T18:59:18 *** Nebraskka <Nebraskka!~Nebraskka@user/nebraskka> has quit IRC (Quit: Good day old chaps)
1972026-08-19T18:59:51 *** memset <memset!~memset@gateway/tor-sasl/memset> has quit IRC (Remote host closed the connection)
1982026-08-19T19:00:24 <dviola> which yeah, match the behavior here: https://github.com/bitcoin-core/gui/pull/948
1992026-08-19T19:00:35 *** memset <memset!~memset@gateway/tor-sasl/memset> has joined #bitcoin-core-dev
2002026-08-19T19:03:50 *** Nebraskka <Nebraskka!~Nebraskka@user/nebraskka> has joined #bitcoin-core-dev
2012026-08-19T19:08:19 *** jerryf <jerryf!~jerryf@user/jerryf> has quit IRC (Ping timeout: 252 seconds)
2022026-08-19T19:10:45 <dviola> hebasto: anyway, I look forward to your feedback (if you test it, but no rush) -- thanks in advance
2032026-08-19T19:11:52 *** jerryf <jerryf!~jerryf@user/jerryf> has joined #bitcoin-core-dev
2042026-08-19T19:22:15 *** jerryf <jerryf!~jerryf@user/jerryf> has quit IRC (Remote host closed the connection)
2052026-08-19T19:23:16 *** jerryf <jerryf!~jerryf@user/jerryf> has joined #bitcoin-core-dev
2062026-08-19T19:54:50 *** angusp <angusp!9e8eed9774@2a03:6000:1812:100::1048> has quit IRC (Server closed connection)
2072026-08-19T19:54:59 *** angusp <angusp!9e8eed9774@2a03:6000:1812:100::1048> has joined #bitcoin-core-dev
2082026-08-19T19:56:12 *** ___nick___ <___nick___!~quassel@82-132-236-14.dab.02.net> has quit IRC (Ping timeout: 256 seconds)
2092026-08-19T20:03:32 *** elichai2 <elichai2!sid212594@hampstead.irccloud.com> has quit IRC (Server closed connection)
2102026-08-19T20:03:45 *** elichai2 <elichai2!sid212594@id-212594.hampstead.irccloud.com> has joined #bitcoin-core-dev
2112026-08-19T20:08:40 *** l0rinc <l0rinc!~l0rinc@user/l0rinc> has quit IRC (Quit: l0rinc)
2122026-08-19T20:12:08 *** l0rinc <l0rinc!~l0rinc@user/l0rinc> has joined #bitcoin-core-dev
2132026-08-19T20:18:04 *** enochazariah_ <enochazariah_!uid710351@id-710351.hampstead.irccloud.com> has quit IRC (Quit: Connection closed for inactivity)
2142026-08-19T20:21:35 *** ___nick___ <___nick___!~quassel@82-132-237-27.dab.02.net> has joined #bitcoin-core-dev
2152026-08-19T20:33:51 *** _flood <_flood!~flooded@149.88.18.225> has joined #bitcoin-core-dev
2162026-08-19T20:53:47 *** Guest89 <Guest89!~Guest77@2804:7f0:6782:d4ad:f281:6628:605d:c0eb> has joined #bitcoin-core-dev
2172026-08-19T21:07:51 *** Guest89 <Guest89!~Guest77@2804:7f0:6782:d4ad:f281:6628:605d:c0eb> has quit IRC (Quit: Client closed)
2182026-08-19T21:09:44 *** bugs_ <bugs_!~bugs@user/bugs/x-5128603> has quit IRC (Quit: Leaving)
2192026-08-19T21:16:06 *** jonatack <jonatack!~jonatack@user/jonatack> has quit IRC (Ping timeout: 256 seconds)
2202026-08-19T21:50:36 *** S3RK_ <S3RK_!~S3RK@user/s3rk> has joined #bitcoin-core-dev
2212026-08-19T21:50:56 <fjahr> I haven't been seeing any git opens or merges here recently, is that bot dead? Sorry if that was raised earlier or if that is intentional, then I must have missed it. Seems like it died even before the GitHub outage earlier this week.
2222026-08-19T21:53:28 *** S3RK <S3RK!~S3RK@user/s3rk> has quit IRC (Ping timeout: 241 seconds)
2232026-08-19T22:04:33 *** _andrewtoth_ <_andrewtoth_!~andrewtot@gateway/tor-sasl/andrewtoth> has joined #bitcoin-core-dev
2242026-08-19T22:06:53 *** andrewtoth_ <andrewtoth_!~andrewtot@gateway/tor-sasl/andrewtoth> has quit IRC (Ping timeout: 252 seconds)
2252026-08-19T22:07:15 *** jerryf <jerryf!~jerryf@user/jerryf> has quit IRC (Ping timeout: 252 seconds)
2262026-08-19T22:07:37 *** afiore <afiore!~afiore@user/afiore> has quit IRC (Ping timeout: 252 seconds)
2272026-08-19T22:09:03 *** afiore <afiore!~afiore@user/afiore> has joined #bitcoin-core-dev
2282026-08-19T22:09:27 *** ghost43 <ghost43!~ghost43@gateway/tor-sasl/ghost43> has quit IRC (Ping timeout: 252 seconds)
2292026-08-19T22:12:12 *** jerryf <jerryf!~jerryf@user/jerryf> has joined #bitcoin-core-dev
2302026-08-19T22:13:21 <achow101> pinged laanwj about that
2312026-08-19T22:13:39 *** memset_ <memset_!~memset@gateway/tor-sasl/memset> has joined #bitcoin-core-dev
2322026-08-19T22:15:27 *** Flow <Flow!~none@gentoo/developer/flow> has quit IRC (Server closed connection)
2332026-08-19T22:15:43 *** memset <memset!~memset@gateway/tor-sasl/memset> has quit IRC (Remote host closed the connection)
2342026-08-19T22:16:08 *** Flow <Flow!~none@gentoo/developer/flow> has joined #bitcoin-core-dev
2352026-08-19T22:20:18 *** ghost43 <ghost43!~ghost43@gateway/tor-sasl/ghost43> has joined #bitcoin-core-dev
2362026-08-19T22:22:08 <l0rinc> fanquake: I have removed your coauthorship from #36000 as requested.
2372026-08-19T22:22:10 <corebot> https://github.com/bitcoin/bitcoin/issues/36000 | validation: prefetch blocks while connecting by l0rinc · Pull Request #36000 · bitcoin/bitcoin · GitHub
2382026-08-19T22:24:14 <l0rinc> We already have reviewers acking, if we need to ask questions it's usually the reviewers who can answer them.
2392026-08-19T22:24:31 <l0rinc> Coauthors are per commit and I consider them to be simple attributions: other people have helped me get to this state. It's simply a way to thank and incentivise people to review: their work is appreciated and noted.
2402026-08-19T22:26:12 <l0rinc> btw, on the topic of #36000 - I just finished a reindex-chainstate on a HDD and it was 1.37x faster.
2412026-08-19T22:26:13 <corebot> https://github.com/bitcoin/bitcoin/issues/36000 | validation: prefetch blocks while connecting by l0rinc · Pull Request #36000 · bitcoin/bitcoin · GitHub
2422026-08-19T22:29:16 <l0rinc> I'm also investigating how much faster we could get (given we're already loading the blocks from disk on threads that don't expose the blocks immediately) whether we can do a simple context-independent `CheckBlock` validation before handing the block to the rest of validation. The diff is tiny, but we should probably do this after #36000.
2432026-08-19T22:29:18 <corebot> https://github.com/bitcoin/bitcoin/issues/36000 | validation: prefetch blocks while connecting by l0rinc · Pull Request #36000 · bitcoin/bitcoin · GitHub
2442026-08-19T23:05:36 *** jonatack <jonatack!~jonatack@user/jonatack> has joined #bitcoin-core-dev
2452026-08-19T23:11:05 *** afiore <afiore!~afiore@user/afiore> has quit IRC (Remote host closed the connection)
2462026-08-19T23:11:21 *** afiore <afiore!~afiore@user/afiore> has joined #bitcoin-core-dev
2472026-08-19T23:13:34 *** ghost43 <ghost43!~ghost43@gateway/tor-sasl/ghost43> has quit IRC (Remote host closed the connection)
2482026-08-19T23:14:47 *** afiore <afiore!~afiore@user/afiore> has quit IRC (Client Quit)
2492026-08-19T23:15:42 *** andrewtoth_ <andrewtoth_!~andrewtot@gateway/tor-sasl/andrewtoth> has joined #bitcoin-core-dev
2502026-08-19T23:16:51 *** _andrewtoth_ <_andrewtoth_!~andrewtot@gateway/tor-sasl/andrewtoth> has quit IRC (Remote host closed the connection)
2512026-08-19T23:17:18 *** l0rinc <l0rinc!~l0rinc@user/l0rinc> has quit IRC (Quit: l0rinc)
2522026-08-19T23:21:35 *** afiore <afiore!~afiore@user/afiore> has joined #bitcoin-core-dev
2532026-08-19T23:29:04 *** _andrewtoth_ <_andrewtoth_!~andrewtot@gateway/tor-sasl/andrewtoth> has joined #bitcoin-core-dev
2542026-08-19T23:29:34 *** ghost43 <ghost43!~ghost43@gateway/tor-sasl/ghost43> has joined #bitcoin-core-dev
2552026-08-19T23:31:35 *** andrewtoth_ <andrewtoth_!~andrewtot@gateway/tor-sasl/andrewtoth> has quit IRC (Ping timeout: 252 seconds)
2562026-08-19T23:33:05 *** dzxzg2 <dzxzg2!~dzxzg@user/dzxzg> has quit IRC (Remote host closed the connection)