19:00:24 <wumpus> #startmeeting
19:00:24 <lightningbot> Meeting started Thu Dec  6 19:00:24 2018 UTC.  The chair is wumpus. Information about MeetBot at http://wiki.debian.org/MeetBot.
19:00:24 <lightningbot> Useful Commands: #action #agreed #help #info #idea #link #topic.
19:00:29 <wumpus> #bitcoin-core-dev Meeting: wumpus sipa gmaxwell jonasschnelli morcos luke-jr sdaftuar jtimon cfields petertodd kanzure bluematt instagibbs phantomcircuit codeshark michagogo marcofalke paveljanik NicolasDorier jl2012 achow101 meshcollider jnewbery maaku fanquake promag provoostenator aj Chris_Stewart_5 dongcarl gwillen jamesob ken281221 ryanofsky gleb
19:00:42 <sipa> hi
19:00:43 <jnewbery> hi
19:00:43 <gleb> hi
19:00:45 <meshcollider> hi
19:00:45 <jamesob> hi
19:00:50 <Teddy_> ji
19:00:56 <dongcarl> hi
19:00:59 <wumpus> topics? (one has been proposed in https://gist.github.com/moneyball/071d608fdae217c2a6d7c35955881d8a)
19:01:22 <chenpo> hi
19:01:27 <achow101> hi
19:01:37 <meshcollider> gleb also mentioned earlier in the week he wanted to talk about dandelion but i'm not sure if that was a meeting topic or just a general desire :)
19:02:28 <moneyball> Hi
19:02:34 <gleb> meshcollider: More of a second. I can't really drive the discussion because I don't remember all the specifics
19:02:52 <provoostenator> hi
19:03:18 <wumpus> #topic high priority for review
19:03:37 <wumpus> 6 PRs on the list right now: https://github.com/bitcoin/bitcoin/projects/8
19:03:51 <phantomcircuit> hi
19:04:11 <wumpus> if there's anything to add or remove, please let me know
19:04:27 <gmaxwell> welp, I can't seem to reach github right now. :(
19:04:43 <jnewbery> I added #14565 today since it was blocking a bunch of other people's PRs
19:04:47 <gribble> https://github.com/bitcoin/bitcoin/issues/14565 | Overhaul importmulti logic by sipa · Pull Request #14565 · bitcoin/bitcoin · GitHub
19:04:51 <wumpus> gmaxwell: strange! no problems here it seems
19:04:57 <meshcollider> yeah there are like 4 PRs stacked on that
19:05:00 <jnewbery> also #14886 since sipa's was blocked on adding test coverage
19:05:01 <sipa> #14782 #13932 #14336 #14646 #14565 #14886
19:05:03 <gribble> https://github.com/bitcoin/bitcoin/issues/14886 | [tests] Refactor importmulti tests by jnewbery · Pull Request #14886 · bitcoin/bitcoin · GitHub
19:05:05 <gribble> https://github.com/bitcoin/bitcoin/issues/14782 | [0.17] Bugfix: Correctly calculate balances when min_conf is used, and for getbalance("*") by luke-jr · Pull Request #14782 · bitcoin/bitcoin · GitHub
19:05:08 <gribble> https://github.com/bitcoin/bitcoin/issues/13932 | Additional utility RPCs for PSBT by achow101 · Pull Request #13932 · bitcoin/bitcoin · GitHub
19:05:12 <gribble> https://github.com/bitcoin/bitcoin/issues/14336 | net: implement poll by pstratem · Pull Request #14336 · bitcoin/bitcoin · GitHub
19:05:15 <gribble> https://github.com/bitcoin/bitcoin/issues/14646 | Add expansion cache functions to descriptors (unused for now) by sipa · Pull Request #14646 · bitcoin/bitcoin · GitHub
19:05:19 <gribble> https://github.com/bitcoin/bitcoin/issues/14565 | Overhaul importmulti logic by sipa · Pull Request #14565 · bitcoin/bitcoin · GitHub
19:05:20 <gribble> https://github.com/bitcoin/bitcoin/issues/14886 | [tests] Refactor importmulti tests by jnewbery · Pull Request #14886 · bitcoin/bitcoin · GitHub
19:05:21 <wumpus> yes, those
19:05:27 <sipa> That's the high priority list
19:06:58 <MarcoFalke> I'd like to add #14480, since it seems required for some other work
19:07:00 <gribble> https://github.com/bitcoin/bitcoin/issues/14480 | refactor: Drop boost::this_thread::interruption_point and boost::thread_interrupted in main thread by ken2812221 · Pull Request #14480 · bitcoin/bitcoin · GitHub
19:07:47 <MarcoFalke> Also, the getbalance fixes need rebase for some days now
19:07:57 <MarcoFalke> usually we take them off of hipri?
19:08:09 <wumpus> ok, added
19:08:14 <sipa> maybe we should first discuss what's left to do for 0.17.1?
19:08:21 <sipa> or as a separate topic
19:08:28 <achow101> #13932 can be removed for now. I won't have time to work on it for another week or two
19:08:30 <gribble> https://github.com/bitcoin/bitcoin/issues/13932 | Additional utility RPCs for PSBT by achow101 · Pull Request #13932 · bitcoin/bitcoin · GitHub
19:08:31 <wumpus> nothing on the high priority list is required for 0.17.1, that's a separate topic
19:08:36 <wumpus> achow101: ok
19:09:15 <MarcoFalke> removed #14782
19:09:17 <gribble> https://github.com/bitcoin/bitcoin/issues/14782 | [0.17] Bugfix: Correctly calculate balances when min_conf is used, and for getbalance("*") by luke-jr · Pull Request #14782 · bitcoin/bitcoin · GitHub
19:09:26 <wumpus> makes sense
19:09:54 <wumpus> #topic 0.17.1
19:10:07 <phantomcircuit> #14336 is done
19:10:09 <MarcoFalke> meshcollider wanted to get in two more fixes
19:10:12 <gribble> https://github.com/bitcoin/bitcoin/issues/14336 | net: implement poll by pstratem · Pull Request #14336 · bitcoin/bitcoin · GitHub
19:10:53 <wumpus> there's nothing open on the 0.17.1 milestone at least
19:10:53 <gmaxwell> MarcoFalke: what are the two outstanding?
19:11:02 <sipa> meshcollider: i haven't paid that much attention lately; do you have a backport for 14424?
19:11:12 <MarcoFalke> https://github.com/bitcoin/bitcoin/issues?q=label%3A%22Needs+backport%22+is%3Aclosed
19:11:14 <meshcollider> Im about to open one
19:11:27 <MarcoFalke> the ones with tag "17.1"
19:12:24 <wumpus> I think it's really due time to release 0.17.1
19:12:44 <wumpus> we wanted to do the release weeks agao AFAIK, we should avoid adding new things to it again and again
19:13:06 <sipa> yeah, i think it's too late to add new things
19:13:14 <jnewbery> wumpus: +1
19:13:16 <gmaxwell> I don't think these are new unfortunately, somehow they fell of the radar. They are good, but we shouldn't delay more.
19:13:21 <gmaxwell> s/of/off/
19:13:27 <meshcollider> fair enough :)
19:13:30 <sipa> gmaxwell: exactly
19:13:55 <wumpus> but it's fine with me to wait another day or so for more backports
19:14:07 <gmaxwell> (like 14689 I asked it to be tagged for backport 17 days ago, it was tagged 15 days ago, but just got missed)
19:14:16 <gmaxwell> wumpus: could we do the RC today otherwise?
19:14:39 <wumpus> gmaxwell: yes, the version has been bumped, afaik everything has been done for the release process, just needs tagging
19:14:51 <bitcoin-git> [13bitcoin] 15MeshCollider opened pull request #14889: [0.17] Backport #14424 (Stop requiring imported pubkey to sign non-PKH schemes) (060.17...06201812_backport_14424) 02https://github.com/bitcoin/bitcoin/pull/14889
19:14:57 <meshcollider> ill tag that for 0.17.2 then
19:15:19 <MarcoFalke> In the future we should really backport in the same order as they are merged to master
19:15:21 <wumpus> but if there are known serious fixes that affect a lot of users of course they should still be backported
19:15:27 <MarcoFalke> Ideally a bot would do that
19:15:30 <gmaxwell> well it's the backport is done and works, waiting a couple hours to tag 0.17.1 wouldn't be an issue.
19:15:47 <wumpus> MarcoFalke: I used to do that with a script
19:16:21 <gmaxwell> MarcoFalke: I think in this case, things got needs backport tags out of order.  I went and pinged a dozen PRs to get tagged, and some were and some took a few days, and some took a week.
19:16:24 <wumpus> (e.g. it takes a list of PRs and cherry-picks the commits in the order the commits appear in master)
19:16:26 <gmaxwell> and some got backported in the meantime.
19:16:57 <MarcoFalke> Yeah, we should be more careful with tagging bug fixes to the right milestone
19:17:01 <wumpus> but it's more complex for things that can't just be cherry picked
19:17:28 <wumpus> whose PRs really need extra work
19:17:48 <wumpus> and we had a few of those, this time
19:17:48 <meshcollider> e.g. this one which relied on some keyorigininfo
19:17:58 <MarcoFalke> Right when there is a bug fix it should say when it was introduced and what the target branch is
19:18:59 <wumpus> yes
19:19:04 <MarcoFalke> We should also require a test with each bug fix and travis and other testers should check that the test fails withou the code changes
19:19:35 <wumpus> I tend to ask for that
19:19:42 <gmaxwell> That should help reduce the number of fixes which will make backporting easier... :P
19:19:47 <MarcoFalke> Similar to the scripted-diff prefix we could add a bug-fix: prefix that must do just that
19:19:56 <gmaxwell> (I don't disagree, though some things are pretty hard to test.)
19:20:02 <MarcoFalke> Yeah
19:20:33 <wumpus> anyhow we're drifting off topic, what still needs to be done for 0.17.1?
19:20:59 <wumpus> I guess someone needs to backport #14689 and #14424
19:21:01 <gribble> https://github.com/bitcoin/bitcoin/issues/14689 | Require a public key to be retrieved when signing a P2PKH input by achow101 · Pull Request #14689 · bitcoin/bitcoin · GitHub
19:21:04 <gribble> https://github.com/bitcoin/bitcoin/issues/14424 | Stop requiring imported pubkey to sign non-PKH schemes by sipa · Pull Request #14424 · bitcoin/bitcoin · GitHub
19:21:10 <meshcollider> i just did the second, #14889
19:21:11 <gribble> https://github.com/bitcoin/bitcoin/issues/14889 | [0.17] Backport #14424 (Stop requiring imported pubkey to sign non-PKH schemes) by MeshCollider · Pull Request #14889 · bitcoin/bitcoin · GitHub
19:21:12 <gmaxwell> In any case, if people think they can review that backport that just went up, presumably it could go in.  I think if we have things that could go into today then RC we should, we certantly shouldn't _wait_.
19:21:27 <provoostenator> Are there up to date Gitian instructions for Docker? I'd like to try both Bionic in a VM and Docker this time.
19:21:55 <gmaxwell> I can try to test the backport of 14424 as soon as the meeting is over.
19:22:03 <wumpus> gitian with docker? I'm not aware of anyone doing that
19:22:05 <wumpus> gmaxwell: thanks!
19:22:11 <MarcoFalke> provoostenator: build-gitian.py (in our master brach)
19:22:23 <MarcoFalke> --docker or something
19:22:46 <gmaxwell> wumpus: want to basically just tag 0.17.1 in N hours (you pick N) with whatever is merged by then?
19:23:34 <gmaxwell> (presumaby N set before you go to bed)
19:24:21 <wumpus> gmaxwell: sounds good to me
19:24:33 <sipa> sgtm
19:24:54 <wumpus> MarcoFalke: ah yes, I keep forgetting about that script
19:25:48 <wumpus> #topic next CoreDev meetup (moneyball)
19:25:59 <moneyball> hi
19:26:29 <moneyball> i wanted to get feedback on having the next CoreDev June 5-7 in Amsterdam right before Breaking Bitcoin conference
19:26:41 <wumpus> good idea!
19:26:47 <moneyball> i think Europe is a good location as the past 4 CoreDevs haven't been in Europe
19:26:53 <moneyball> and yes wumpus surely likes it :)
19:26:57 <jnewbery> ACK
19:27:06 <moneyball> it also gives the opportunity to attend BB if interested
19:28:00 <moneyball> so "save the date" on your calendars, and let me know here or over DM if you have any thoughts or feedback
19:29:36 <phantomcircuit> moneyball, BB ?
19:29:48 <wumpus> combining it with a conference is useful
19:29:50 <moneyball> https://twitter.com/breakingbitcoin/status/1070060118866305026
19:30:22 <sipa> ack amsterdam
19:30:25 <sipa> :)
19:31:10 <wumpus> I think we agree then :) any other topics?
19:33:52 <wumpus> PSA: if, during the course of the week, you have any ideas for next week's meeting let moneyball know, he'll add it to the list on https://gist.github.com/moneyball/071d608fdae217c2a6d7c35955881d8a
19:34:06 <wumpus> I've also added that link to the topic here
19:34:35 <jnewbery> use tag #proposedmeetingtopic so Steve can grep
19:35:22 <wumpus> would be good to add that to the gist
19:35:36 <wumpus> can't put much more in the topic itself
19:37:59 <wumpus> any other topics?
19:38:44 <wumpus> #endmeeting