19:00:32 #startmeeting 19:00:32 Meeting started Fri Feb 8 19:00:32 2019 UTC. The chair is meshcollider. Information about MeetBot at http://wiki.debian.org/MeetBot. 19:00:32 Useful Commands: #action #agreed #help #info #idea #link #topic. 19:00:50 #bitcoin-core-dev Wallet Meeting: wumpus sipa gmaxwell jonasschnelli morcos luke-jr sdaftuar jtimon cfields petertodd kanzure bluematt instagibbs phantomcircuit codeshark michagogo marcofalke paveljanik NicolasDorier jl2012 achow101 meshcollider jnewbery maaku fanquake promag provoostenator aj Chris_Stewart_5 dongcarl gwillen jamesob ken281221 ryanofsky gleb 19:01:01 only half here 19:01:12 here 19:01:13 hi 19:01:15 Ok, topics? 19:01:45 I guess we should start with discussing what wallet PRs we can aim to get into 0.18 19:02:01 hi 19:03:05 https://github.com/bitcoin/bitcoin/milestone/35 19:03:43 yes hello 19:04:25 I am pestering for people to go review #13932 19:04:28 https://github.com/bitcoin/bitcoin/issues/13932 | Additional utility RPCs for PSBT by achow101 · Pull Request #13932 · bitcoin/bitcoin · GitHub 19:04:38 will do 19:04:48 https://github.com/bitcoin/bitcoin/pulls?utf8=%E2%9C%93&q=is%3Apr+is%3Aopen+milestone%3A0.18.0+label%3AWallet 19:04:56 also review #15226 pls 19:05:00 https://github.com/bitcoin/bitcoin/issues/15226 | Allow creating blank (empty) wallets (alternative) by achow101 · Pull Request #15226 · bitcoin/bitcoin · GitHub 19:05:01 only wallet PRs ^ 19:06:02 #14075 and #14021 would be nice, but they're a bit more involved 19:06:04 https://github.com/bitcoin/bitcoin/issues/14075 | Import watch only pubkeys to the keypool if private keys are disabled by achow101 · Pull Request #14075 · bitcoin/bitcoin · GitHub 19:06:07 https://github.com/bitcoin/bitcoin/issues/14021 | Import key origin data through descriptors in importmulti by achow101 · Pull Request #14021 · bitcoin/bitcoin · GitHub 19:06:44 Yes, I put them on the milestone but not sure they'll be ready in time 19:07:09 there's also a merge conflict between those two and 15226 which may not be trivial to resolve, so i don't think we can get all of them in 19:09:36 I would really like at least #14021 but we'll see I guess 19:09:39 https://github.com/bitcoin/bitcoin/issues/14021 | Import key origin data through descriptors in importmulti by achow101 · Pull Request #14021 · bitcoin/bitcoin · GitHub 19:09:55 achow101: Is 15226 your highest priority one 19:10:03 I'd love to see #15288 merged soon since we now seem to have some momentum in that series of PRs, but it might be better to do that after forking 0.18 19:10:06 https://github.com/bitcoin/bitcoin/issues/15288 | Remove wallet -> node global function calls by ryanofsky · Pull Request #15288 · bitcoin/bitcoin · GitHub 19:10:17 hi. 19:10:30 it's a very easy review. Lots of line change but all very mechanical, and nicely structured commits 19:10:31 jnewbery: yeah I think after 0.18 is better, but I agree 19:10:38 currently 14021 is my highest priority 19:11:22 (since 14491 is merged now) 19:12:08 achow101: perhaps you could give a summary of the state of HWI? How far are we from HWI in master? 19:12:31 instagibbs: or you if you're around ^ 19:12:59 I think #14912 is tracking 19:13:05 https://github.com/bitcoin/bitcoin/issues/14912 | [WIP] External signer support (e.g. hardware wallet) by Sjors · Pull Request #14912 · bitcoin/bitcoin · GitHub 19:13:11 hwi has all basic functionality completed for the 5 common hardware wallets 19:13:59 provoostenator has a branch for calling it from core 19:14:48 we would need that and 14021 and 14075 for hwi to work. 19:15:37 (gtg, have to take a quiz now) 19:15:40 Also #14481 is the last PR on the "Segwit" github project which hasn't gone in, it'd be nice to have that in for 0.18 19:15:42 https://github.com/bitcoin/bitcoin/issues/14481 | Add P2SH-P2WSH support to listunspent RPC by MeshCollider · Pull Request #14481 · bitcoin/bitcoin · GitHub 19:16:36 Quite a small PR to review 19:16:40 meshcollider: i'm slightly inclined to instead just aim to have signrawtransaction etc work with descriptors 19:16:49 as listunspent gives the descriptors already 19:17:08 (not an objection to also doing that PR... but i suspect in the end the descriptor based approach is more convenient) 19:19:45 sipa: I think having both is nice, but yeah making descriptors more consistently used across the RPCs would be a nice change 19:19:58 But we can't aim for that in 0.18 19:20:07 agree 19:21:03 Does anyone have any other topics for the meeting? 19:21:47 sipa: how's the checksum search coming 19:22:22 meshcollider: #15368 19:22:23 https://github.com/bitcoin/bitcoin/issues/15368 | Descriptor checksums by sipa · Pull Request #15368 · bitcoin/bitcoin · GitHub 19:22:38 i'll add documentation and release notes today 19:24:30 Ok 19:24:59 Looks like there's nothing else to discuss this week 19:25:13 #endmeeting