19:01:17 #startmeeting 19:01:17 Meeting started Thu Apr 4 19:01:17 2019 UTC. The chair is wumpus. Information about MeetBot at http://wiki.debian.org/MeetBot. 19:01:17 Useful Commands: #action #agreed #help #info #idea #link #topic. 19:01:24 hi 19:02:02 #bitcoin-core-dev Meeting: wumpus sipa gmaxwell jonasschnelli morcos luke-jr sdaftuar jtimon cfields petertodd kanzure bluematt instagibbs phantomcircuit codeshark michagogo marcofalke paveljanik NicolasDorier jl2012 achow101 meshcollider jnewbery maaku fanquake promag provoostenator aj Chris_Stewart_5 dongcarl gwillen jamesob ken281221 ryanofsky gleb 19:02:08 proposed topics? 19:02:17 TODOs in the release notes 19:02:32 They seem generally ready, but we'd need to finalize them for -final 19:02:54 ok 19:02:59 They are "TODO sipa", not sure if that means sipa should do something or they were added by sipa 19:03:01 #topic high priority for review 19:03:11 https://github.com/bitcoin/bitcoin/projects/8 19:03:51 #15006 #15557 #14121 #15141 #15512 19:03:56 https://github.com/bitcoin/bitcoin/issues/15006 | Add option to create an encrypted wallet by achow101 · Pull Request #15006 · bitcoin/bitcoin · GitHub 19:03:58 https://github.com/bitcoin/bitcoin/issues/15557 | Enhance `bumpfee` to include inputs when targeting a feerate by instagibbs · Pull Request #15557 · bitcoin/bitcoin · GitHub 19:04:01 MarcoFalke: it means i'll try to write them if nobody beats me :) 19:04:10 https://github.com/bitcoin/bitcoin/issues/15141 | Rewrite DoS interface between validation and net_processing by sdaftuar · Pull Request #15141 · bitcoin/bitcoin · GitHub 19:04:11 https://github.com/bitcoin/bitcoin/issues/15512 | Add ChaCha20 encryption option (XOR) by jonasschnelli · Pull Request #15512 · bitcoin/bitcoin · GitHub 19:04:11 https://github.com/bitcoin/bitcoin/issues/14121 | Index for BIP 157 block filters by jimpo · Pull Request #14121 · bitcoin/bitcoin · GitHub 19:04:53 dunno if someone has something to add or remove? 19:05:16 hi 19:05:42 helloo 19:05:51 * sipa waves at wumpus 19:06:25 i don't have anything right now for high priority 19:06:36 I'm still at ICPC so apologies for lack of activity 19:06:51 are any of gwillen's issue's blockers for rc3? 19:06:58 s/rc3/final/ 19:07:14 I don't think there's any blocking issues for rc3 19:07:19 eh, for 0.18.0 19:07:42 i'm making a PR to fix #15743 right now, but i think it's a minor thing 19:07:43 https://github.com/bitcoin/bitcoin/issues/15743 | getaddressinfo missing key origin information for multisig · Issue #15743 · bitcoin/bitcoin · GitHub 19:08:29 #topic blockers for 0.18.0 19:09:22 gwillen: opinions? 19:10:22 so are any of these regressions for 0.18? 19:10:50 I don't think so. they're all new stuff added with descriptors 19:10:52 I don't have opinions about 0.18 19:11:13 none of them are correctness issues 19:11:15 achow101: ok, thanks 19:12:03 doesn't seem that needs to block the release 19:12:20 #topic release notes TODOs 0.18.0 19:12:33 well, "manual coin control broken with multiple wallets" is not merely superficial, but I don't think you can successfully do anything broken with it, as far as I can tell 19:12:44 i'd welcome help to fill in my TODOs :) 19:13:28 working on it rn 19:13:29 gwillen: right-I just think the criterion at this point is "worked in 0.17 and broken in 0.18" 19:13:51 :+1: 19:14:11 unless it's really dangerous ofc, but in that case we could also opt for disabling the feature that introduces it 19:14:19 it is not totally out of the question that a clever user could accidentally send coins from the wrong wallet with it 19:14:27 but when I tried to do so, I got an error 19:14:36 https://github.com/bitcoin-core/bitcoin-devwiki/wiki/0.18.0-Release-Notes-Draft 19:15:04 and it only triggers if you are performing coin control on multiple wallets at once, which would be a weird thing to be doing 19:15:21 gwillen: we could add a known issue 19:15:43 that would make sense, although who reads those 19:15:57 but I think it is definitely a known thing that one should avoid triggering 19:16:02 sigh, who ever reads anything right ... 19:16:11 if you start asking that why spend time writing release notes at all ! 19:17:00 anyhow the TODO s are; 19:17:13 (TODO pieter: it feels like this section can be merged with the earlier RPC changes section) (under low-level changes) 19:17:31 Descriptors with key origin information imported through importmulti will have their key origin information stored in the wallet for use with creating PSBTs. (TODO pieter: this should probably be merged with the text on importmulti gaining descriptor support) 19:17:53 (TODO pieter: mention getdata randomization from #14897 and perhaps orphan tx handling from #14626) under "network" 19:17:58 https://github.com/bitcoin/bitcoin/issues/14897 | randomize GETDATA(tx) request order and introduce bias toward outbound by naumenkogs · Pull Request #14897 · bitcoin/bitcoin · GitHub 19:18:01 https://github.com/bitcoin/bitcoin/issues/14626 | Select orphan transaction uniformly for eviction by sipa · Pull Request #14626 · bitcoin/bitcoin · GitHub 19:18:10 (TODO pieter: mention HWI project?) under "wallet" 19:18:26 (TODO pieter: mention that the rdseed instruction is used where available) under "security" 19:18:34 I think the latter is very low-level for release notes 19:18:42 yeah 19:19:24 we also need to be careful to include things that are useful to users to know 19:19:45 too much and people will indeed just skip over things 19:20:20 (TODO pieter: mention new descriptor RPCs deriveaddresses/getdescriptorinfo, and descriptor support in importmulti) under "Documentation" 19:21:17 anyhow help is welcome here 19:21:56 assuming no further problems in rc3, when final? 19:21:59 TODO: remove any leftover TODOs before sending the final release notes :) 19:22:53 more or less one week per rc, so I think next week thursday 19:23:36 agree on that timeline 19:24:02 yeha 19:24:07 *yeah 19:24:59 wumpus: I added some suggested known-issue text to #15725 19:25:01 https://github.com/bitcoin/bitcoin/issues/15725 | Manual coin control dialog interacts badly with multiple wallets · Issue #15725 · bitcoin/bitcoin · GitHub 19:25:32 when do we switch release notes back from wallet to repo? 19:25:56 next tuesday? 19:26:10 sipa: usually just before labeling final 19:26:21 okay 19:26:43 Shouldn't there be one day so that everyone can look over what is going to be tagged as final? 19:26:52 MarcoFalke: also fine with me, if we know we're going to do final next 19:27:14 just, if you want to do release note editing, please do it on the wiki 19:28:42 any other topics? 19:30:32 no warren update today 19:30:43 thanks for letting us know kanzure 19:32:16 I guess that's all for today 19:32:24 #endmeeting