19:04:42 <achow101> #startmeeting
19:04:42 <lightningbot> Meeting started Fri Mar 27 19:04:42 2020 UTC.  The chair is achow101. Information about MeetBot at http://wiki.debian.org/MeetBot.
19:04:42 <lightningbot> Useful Commands: #action #agreed #help #info #idea #link #topic.
19:04:54 <provoostenator> jonatack:  I guess that missed the feature freeze?
19:05:07 <jonatack> ah
19:05:09 <jonatack> hi
19:05:10 <fjahr> hi
19:05:14 <provoostenator> hi
19:05:17 <achow101> #bitcoin-core-dev Wallet Meeting: wumpus sipa gmaxwell jonasschnelli morcos luke-jr sdaftuar jtimon cfields petertodd kanzure bluematt instagibbs phantomcircuit codeshark michagogo marcofalke paveljanik NicolasDorier jl2012 achow101 meshcollider jnewbery maaku fanquake promag provoostenator aj Chris_Stewart_5 dongcarl gwillen jamesob ken281221 ryanofsky gleb moneyball ariard digi_james amiti fjahr
19:05:17 <achow101> jeremyrubin emilengler jonatack hebasto jb55
19:05:25 <bitcoin-git> [13bitcoin] 15laanwj pushed 3 commits to 06master: 02https://github.com/bitcoin/bitcoin/compare/210b533a1144...f2c416bcf5f8
19:05:25 <bitcoin-git> 13bitcoin/06master 14b837b33 15Wladimir J. van der Laan: net: Fail instead of truncate command name in CMessageHeader
19:05:26 <bitcoin-git> 13bitcoin/06master 14ff9c671 15Russell Yanofsky: refactor: Work around GCC 9 `-Wredundant-move` warning
19:05:27 <bitcoin-git> 13bitcoin/06master 14f2c416b 15Wladimir J. van der Laan: Merge #16995: Fix gcc 9 warnings
19:05:41 <achow101> #topic: wallet bug fixes for 0.20
19:05:56 <achow101> #17509 seems to be a feature, not a buf fix
19:05:59 <gribble> https://github.com/bitcoin/bitcoin/issues/17509 | gui: save and load PSBT by Sjors · Pull Request #17509 · bitcoin/bitcoin · GitHub
19:06:13 <achow101> so I think it's too late for 0.20
19:06:28 <bitcoin-git> [13bitcoin] 15laanwj merged pull request #16995: Fix gcc 9 warnings (06master...062019_09_resolve_gcc_warnings) 02https://github.com/bitcoin/bitcoin/pull/16995
19:07:12 <hebasto> hi
19:08:19 <achow101> nly two wallet related PRs listed for 0.20, #18338 and #18160
19:08:22 <gribble> https://github.com/bitcoin/bitcoin/issues/18338 | Fix wallet unload race condition by promag · Pull Request #18338 · bitcoin/bitcoin · GitHub
19:08:24 <gribble> https://github.com/bitcoin/bitcoin/issues/18160 | gui: Avoid Wallet::GetBalance in WalletModel::pollBalanceChanged by promag · Pull Request #18160 · bitcoin/bitcoin · GitHub
19:08:37 <jonatack> yes https://github.com/bitcoin/bitcoin/milestones/0.20.0
19:09:56 <jonatack> they both have an ack and seem not too bad to review
19:10:03 <hebasto> reviewing 18338
19:11:47 <jonatack> correction 18160 seems to have 3 acks
19:13:16 <jonatack> make that 4... i can't count this evening apparently
19:13:42 <achow101> doesn't look like there are any other wallet PRs that are really bug fixes
19:14:03 <bitcoin-git> [13bitcoin] 15laanwj closed pull request #17645: gui: increases default GraphRange of Network Traffic to 12 hours. (06master...06GraphRange) 02https://github.com/bitcoin/bitcoin/pull/17645
19:14:42 <achow101> possibly #18095
19:14:44 <gribble> https://github.com/bitcoin/bitcoin/issues/18095 | Fix crashes and infinite loop in ListWalletDir() by uhliksk · Pull Request #18095 · bitcoin/bitcoin · GitHub
19:16:00 <achow101> any other topics?
19:18:36 <achow101> seems not
19:18:38 <jonatack> fjahr: achow101: which pr do you want review on first
19:18:38 <achow101> #endmeeting